Daryl Koopersmith
23b62b3d77
Media JS: Use correct variable name when binding to the change:library
event. see [22477], #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 01:24:55 +00:00
Daryl Koopersmith
103694aa4f
Media JS: Add JIT composite library creation/destruction to states to allow for dynamically excluded Attachment models. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 01:23:20 +00:00
Andrew Nacin
1b0a4561a4
Use correct variable. props picklewagon. fixes #22394 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 00:16:30 +00:00
Bot (Assets)
0f3d286dd3
Compress scripts/styles: 3.5-beta2-22475.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 22:58:34 +00:00
Andrew Nacin
5b8081b787
Return nothing in get_adjacent_post() when $in_same_cat = true but the post doesn't support (or otherwise have) categories. Avoids SQL error. props batmoo, SergeyBiryukov. fixes #15959 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 21:16:15 +00:00
Andrew Nacin
e5c1d8d7af
Account for unfiltered_upload cap in wp_upload_bits(). see #21292 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 20:41:34 +00:00
Ryan Boren
c6bbdd075c
Add SimplePie/Exception.php.
...
Props ocean90
fixes #22321
git-svn-id: http://core.svn.wordpress.org/trunk@22469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 19:14:53 +00:00
Daryl Koopersmith
fe570eb90c
Media JS: Add media.model.Composite, to aid in the representation of joint views. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 15:32:40 +00:00
Daryl Koopersmith
ef0774026b
Media: Improve sidebar handling and make attachment display properties attachment-specific.
...
`wp.mce.media`
* Watch all workflows for the `insert` event and attempt to insert the current state's `selection` if it exists.
* Fetch and pass attachment display properties through to `wp.media.string.image()`.
`wp.media.controller.Region`
* Separate the concept of events and modes.
* All events triggered on a `Region` trigger both `event` and `event:mode` callbacks.
* When a mode is deactivated, `deactivate` and `deactivate:mode` events are fired.
* When a mode is activated, `activate` and `activate:mode` events are fired.
`wp.media.controller.Library`
* Remove the `details()`, `buildDetails()`, and `clearDetails()` methods that juggled sidebar views. Instead, handle the sidebar views using modes.
`wp.media.controller.Gallery`
* Shift the overloaded `sidebar()` method to use modes.
`wp.media.view.MediaFrame.Post`
* Declare `activate:mode` event bindings using an nested object to reduce repetition.
* Update sidebar activation callbacks.
`wp.media.view.Settings`
* Refactor to leverage HTML data attributes and implicit values (instead of setting the fallback whenever an object was created). This has the additional benefit that gallery shortcode parameters are not output when the user has left them set to the default.
see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 14:15:09 +00:00
Ryan Boren
7cc32c3990
If $this->posts is empty, don't do stuff to it.
...
Props wonderboymusic
fixes #22061
git-svn-id: http://core.svn.wordpress.org/trunk@22465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 13:52:40 +00:00
Andrew Nacin
c67a081816
Revert [22445]. see #20376 . fixes #22389 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 03:30:56 +00:00
Andrew Nacin
4a6d2bbc00
In WP_Image_Editor / wp_load_image(), use is_file() rather than file_exists() so we do not accidentally load a directory.
...
props benkulbertis, DH-Shredder, scribu.
fixes #17814 .
git-svn-id: http://core.svn.wordpress.org/trunk@22463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 02:02:03 +00:00
Andrew Nacin
1d312da957
Fix the matching in is_email_address_unsafe(), which was too aggressive.
...
We should only check to see if the user's email address has the same
domain as or is a subdomain of any banned email domain.
Add a filter.
props mdawaffe.
fixes #21570 .
git-svn-id: http://core.svn.wordpress.org/trunk@22461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-08 01:06:17 +00:00
Bot (Assets)
9cc507b1c9
Compress scripts/styles: 3.5-beta2-22455.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 22:58:33 +00:00
Daryl Koopersmith
4daeaf464d
Media: Improve memory management of views, events, and DOM nodes. see #21390 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 22:43:16 +00:00
Andrew Nacin
9beec00613
Sanity checks in get_body_class() to ensure we are operating on the type of queried object that we expect. props wonderboymusic. fixes #17662 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 22:12:44 +00:00
Andrew Nacin
f85592021d
Don't call get_term_by() in get_queried_object() if we have no terms. props wonderboymusic. fixes #21967 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 22:09:05 +00:00
Andrew Nacin
837fadc3dc
Merge two strings. props pavelevap, see #22306 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 22:03:23 +00:00
Andrew Nacin
180b0f19e5
Ensure a method is compatible with its parent. props kurtpayne, fixes #22265 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 21:59:20 +00:00
Andrew Nacin
8eb8948a2e
Fix meta value querying in wp_list_pages(). props SergeyBiryukov. fixes #20376 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 21:48:38 +00:00
Andrew Nacin
a79310d45c
Update the old wp-app.php rule to allow for a trailing slash followed by endpoint data. props wonderboymusic. fixes #22035 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 21:27:02 +00:00
Andrew Nacin
033506e18c
Allow the .hidden class to hide a button. props helenyhou. fixes #22018 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 21:25:25 +00:00
Andrew Ozz
1276bcefb5
More retina backgrounds and bits, props saracannon, empireoflight and lessbloat, see #21019
...
git-svn-id: http://core.svn.wordpress.org/trunk@22439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:54:08 +00:00
Bot (Assets)
a94a72e010
Compress scripts/styles: 3.5-beta2-22438. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:29:58 +00:00
Daryl Koopersmith
90781c9e83
Media: Integrate the gallery workflow with the media menu.
...
`wp.media.model.Query.more()`
* If a request has already been sent out for more attachments, return that request object instead of creating another.
`wp.media.controller.Region`
* A region allows views to be swapped in and out of a section of the page without either view having to know about the other.
* Application components can use the same callbacks and resources by leveraging `Region.mode()`, which triggers a set of callbacks to create or transform the current view, but only if necessary.
`wp.media.view.Frame`
* Leverage `Region` controllers instead of forcing states to swap view objects, which causes states to fit more comfortably in the controller-camp.
* Add `previous()`, a method to fetch the previous state `id`.
* Separate out the default settings over several objects (so blank frames can be instantiated).
`wp.media.view.MediaFrame`
* The base `Frame` used for media management: handles integration with the `Modal` and `UploaderWindow` views.
`wp.media.view.MediaFrame.Post`
* Includes all default media states and callbacks necessary for inserting media into a post.
see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:14:41 +00:00
Andrew Nacin
e1f25c2c0e
Allow get_custom_header() to handle a default registered header that has yet to be saved to the database. fixes #22221 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:12:47 +00:00
Andrew Nacin
a73aa40cb5
Avoid an uncaught exception in get_gmt_from_date(). The return value is imperfect - date( $format, 0 ) - but better than a fatal error. props wonderboymusic. fixes #20942 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:07:41 +00:00
Ryan Boren
33fe750dce
Don't assign wp_the_query to wp_query by reference. Removing the ref avoids accidentally stomping wp_the_query.
...
Props scribu, wpmuguru
fixes #22125
git-svn-id: http://core.svn.wordpress.org/trunk@22434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:03:28 +00:00
Andrew Nacin
039279db28
Only call wp_get_object_terms() if get_object_term_cache() says there is no cache (false), which is different than no terms. props wonderboymusic, fixes #16505 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:00:51 +00:00
Andrew Nacin
30d048a1e7
Don't return encoded ampersands from get_post_comments_feed_link() to avoid canonical redirect issues. Apply esc_url() when appropriate.
...
props markjaquith, SergeyBiryukov. fixes #21841 .
git-svn-id: http://core.svn.wordpress.org/trunk@22431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:56:10 +00:00
Andrew Nacin
dc40f18228
Merge some strings. props pavelevap. fixes #22306 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:37:54 +00:00
Andrew Nacin
e588812a49
Enforce a minimum of two arguments for wpdb::prepare(). The first argument is the query (or fragment thereof), which is required. Additional arguments are values to substitute into placeholders.
...
This will generate E_WARNINGs for insufficient arguments when prepare() is called with no additional arguments. This should discourage improper uses of prepare() under the guise of safely running a query.
props xknown. fixes #22262 .
git-svn-id: http://core.svn.wordpress.org/trunk@22429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:30:59 +00:00
Andrew Nacin
3a86c87c31
Remove single-argument calls to wpdb:prepare(), which are invalid as nothing is being prepared. see #22262 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:28:08 +00:00
Andrew Nacin
5e4cb3af70
Display links if no link categories exist. props MikeHansenMe. fixes #22216 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 19:25:18 +00:00
Mark Jaquith
2ec9c4acc2
Use ImageOptim to losslessly smush our images. About half a MB in savings! fixes #22381 . props waldojaquith
...
git-svn-id: http://core.svn.wordpress.org/trunk@22425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 18:49:10 +00:00
Andrew Nacin
a5c0829f35
Remove the post-format-standard term on upgrade if it exists in the database. fixes #20697 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 18:01:31 +00:00
Ryan Boren
15f0f2524e
Call Imagick::queryformats() non-statically to preserve back compat with older versions of Imagick.
...
Props mpvanwinkle77
fixes #22308
see #6821
git-svn-id: http://core.svn.wordpress.org/trunk@22421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 17:50:38 +00:00
Andrew Nacin
03794fddb3
Properly return new WP_Error objects. props bpetty. see #6812 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 17:49:00 +00:00
Ryan Boren
fac33f51fa
When using WP_User::set_role() to set the role, don't unset all caps when the requested role matches the current role.
...
Props scribu, jammitch
fixes #18932
git-svn-id: http://core.svn.wordpress.org/trunk@22418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 17:16:37 +00:00
Andrew Nacin
711f6f2619
Treat a single taxonomy passed as an array the same as when passed as a string in get_terms(). props wonderboymusic, fixes #17955 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 09:03:40 +00:00
Andrew Nacin
17a387ccb8
Use correct variable name in code comment. props SergeyBiryukov, fixes #21962 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 08:57:49 +00:00
Daryl Koopersmith
9329d742cb
Use Mustache-insipired template tags.
...
Underscore's default ERB-style templates are incompatible with PHP when asp_tags is enabled. As a result, we've settled on an alternative syntax that should be familiar to devs: Mustache-inspired for interpolating and escaping content, and ERB-inspired for execution.
`{{{a}}}` - interpolating
`{{ a }}` - escaping
`<# a #>` - execution
props rmccue. fixes #22344 , see #21390 .
git-svn-id: http://core.svn.wordpress.org/trunk@22415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 08:41:17 +00:00
Andrew Nacin
3a8a6471e3
Check for WP_Error in get_the_category(). props batmoo. fixes #21155 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:47:14 +00:00
Andrew Ozz
c09c079a6f
Allow commonly used obsolete HTML5 attributes in TinyMCE, table[summary|width|border|frame|rules|cellspacing|cellpadding|align|bgcolor] and a[name], fixes #22175
...
git-svn-id: http://core.svn.wordpress.org/trunk@22411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:36:10 +00:00
Andrew Nacin
224a21db80
Stop adding title attributes to images (in the old media uploader). props martythornley. fixes #18984 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:23:03 +00:00
Bot (Assets)
aa464fde32
Compress scripts/styles: 3.5-beta2-22407.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 22:58:35 +00:00
Andrew Nacin
1a3e4a1207
Don't show a hand cursor when hovering over a disabled button. props sabreuse, fixes #22371 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 22:30:41 +00:00
Ryan Boren
8bb0fc5079
Revert [22365]. see #21167
...
git-svn-id: http://core.svn.wordpress.org/trunk@22403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 19:45:51 +00:00
Jon Cave
df39c7be71
Update shortcode regular expression commentary. See #17657 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 14:47:33 +00:00
Andrew Nacin
abe7ee8ec8
Keyboard accessibility for the theme customizer. props lessbloat, jorbin, JustinSainton. fixes #21283 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 14:47:25 +00:00