Drew Jaynes
d829ec4cf2
Docs: Provide best practice guidance for achieving parity between $menu_slug
values supplied when adding menu and submenu pages, and later trying to compare those initial values against sanitized screen IDs derived from $menu_slug
.
...
At the heart of the matter, the `$menu_slug` parameter in `add_menu_page()` and `add_submenu_page()` is not sanitized with `sanitize_key()`. When the screen object is later built for the admin page, the screen ID is derived from that `$menu_slug` value, though passed through `sanitize_key()`, which can produce unexpected results in comparison check.
Changing the sanitization code to provide actual parity is out of the question at this juncture, so updating the docs to describe how to avoid this edge case is the next best option.
Props GregRoss.
Fixes #35305 .
Built from https://develop.svn.wordpress.org/trunk@40967
git-svn-id: http://core.svn.wordpress.org/trunk@40817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 04:18:43 +00:00
Sergey Biryukov
165807d39f
Administration: In WP_List_Table::comments_bubble()
, replace the mdash with its HTML entity for consistency with the similar code in other list tables.
...
Props afercia.
See #40659 , #32152 .
Built from https://develop.svn.wordpress.org/trunk@40960
git-svn-id: http://core.svn.wordpress.org/trunk@40810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-29 00:04:43 +00:00
Sergey Biryukov
c6289b7440
Docs: Add missing backtick character in export_wp()
DocBlock.
...
Props pbiron.
Fixes #41178 .
Built from https://develop.svn.wordpress.org/trunk@40958
git-svn-id: http://core.svn.wordpress.org/trunk@40808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-27 00:58:41 +00:00
Sergey Biryukov
01a6f4d38e
Administration: In taxonomy list tables, display a dash instead of a blank space and add "No description" as a screen reader text when the term description is blank.
...
Props pratikgandhi, yahil.
Fixes #40659 .
Built from https://develop.svn.wordpress.org/trunk@40957
git-svn-id: http://core.svn.wordpress.org/trunk@40807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-27 00:34:41 +00:00
Sergey Biryukov
25e94961b4
Administration: In user list tables, display a dash instead of a blank space and add "Unknown" as a screen reader text when the user's first name and last name are blank.
...
Props Girishpanchal, yahil.
Fixes #40628 .
Built from https://develop.svn.wordpress.org/trunk@40956
git-svn-id: http://core.svn.wordpress.org/trunk@40806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-27 00:27:39 +00:00
Felix Arntz
5650910c50
Multisite: Remove full stops from radio and checkbox labels in the Network Settings screen.
...
This change brings consistency with the regular site administration panel settings pages: Radio and checkbox labels do not use full stops there, so those in the network administration panel should not either.
Props Ankit K Gupta.
Fixes #39319 .
Built from https://develop.svn.wordpress.org/trunk@40953
git-svn-id: http://core.svn.wordpress.org/trunk@40803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-26 19:20:40 +00:00
Drew Jaynes
07f01a2e10
Docs: Replace a variety of http links referenced in inline docs with their https counterparts (where possible).
...
Props johnpgreen.
Fixes #40732 .
Built from https://develop.svn.wordpress.org/trunk@40948
git-svn-id: http://core.svn.wordpress.org/trunk@40798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-25 22:06:41 +00:00
Weston Ruter
b7ca48fff0
Widgets: Add accessibility mode support for TinyMCE-enhanced Text and Media widgets (Video, Audio, Images).
...
Amends [40640], [40631].
Props westonruter, afercia.
See #35243 , #32417 .
Fixes #40986 .
Built from https://develop.svn.wordpress.org/trunk@40941
git-svn-id: http://core.svn.wordpress.org/trunk@40791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-25 18:48:41 +00:00
John Blackbourn
a507248146
Users: Use more appropriate HTTP status codes for errors relating to user management.
...
Also re-uses one error message string.
Props tuanmh
Fixes #40230
Built from https://develop.svn.wordpress.org/trunk@40940
git-svn-id: http://core.svn.wordpress.org/trunk@40790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-25 18:46:44 +00:00
Weston Ruter
46551a898a
Widgets: Forcibly limit Video widget to only accept oEmbed URLs from YouTube and Vimeo (for now).
...
Amends [40640].
Props timmydcrawford.
See #34115 , #39994 .
Fixes #40935 .
Built from https://develop.svn.wordpress.org/trunk@40939
git-svn-id: http://core.svn.wordpress.org/trunk@40789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-25 07:24:41 +00:00
Weston Ruter
980f342ad6
Customize: Ensure header_image_data
setting exists before attempting to use it.
...
Amends [27497].
Props Collizo4sky.
Fixes #41007 .
Built from https://develop.svn.wordpress.org/trunk@40935
git-svn-id: http://core.svn.wordpress.org/trunk@40785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-25 07:04:42 +00:00
Sergey Biryukov
c0cf33b8f5
Import: Increase color contrast for "This importer is not installed" message on Multisite.
...
Remove `.not-installed-main-site` class introduced in [38075], but never used.
Props nishitlangaliya, mbootsman.
Fixes #41117 .
Built from https://develop.svn.wordpress.org/trunk@40928
git-svn-id: http://core.svn.wordpress.org/trunk@40778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-24 18:07:43 +00:00
Drew Jaynes
3a6985de96
Docs: Standardize and add missing deprecation notations in DocBlocks for the following functions:
...
* `post_form_autocomplete_off()`
* `_rotate_image_resource()`
* `_flip_image_resource()`
* `wp_get_sites()`
* `deactivate_sitewide_plugin()`
Props jrf.
See #41121 .
Built from https://develop.svn.wordpress.org/trunk@40922
git-svn-id: http://core.svn.wordpress.org/trunk@40772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-22 17:48:45 +00:00
Peter Wilson
395ff7aebe
Docs: Add wp-admin/js/media.js
documentation.
...
Props jipmoors, jjcomack, diedeexterkate.
Fixes #41072 .
Built from https://develop.svn.wordpress.org/trunk@40915
git-svn-id: http://core.svn.wordpress.org/trunk@40765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 15:37:53 +00:00
Peter Wilson
952975fd0d
Docs: Add wp-admin/js/custom-background.js
documentation.
...
Props jipmoors.
Fixes #41067 .
Built from https://develop.svn.wordpress.org/trunk@40914
git-svn-id: http://core.svn.wordpress.org/trunk@40764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 13:24:41 +00:00
Sergey Biryukov
c569080cd1
Docs: Add documentation for wp-admin/js/comment.js
.
...
Props ireneyoast, andizer, jipmoors.
Fixes #41065 .
Built from https://develop.svn.wordpress.org/trunk@40913
git-svn-id: http://core.svn.wordpress.org/trunk@40763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 13:02:40 +00:00
Sergey Biryukov
f1740f3702
I18N: Correct translator comment for response error message in WP_Community_Events::get_events()
.
...
Props Soean, tfirdaus.
Fixes #40939 .
Built from https://develop.svn.wordpress.org/trunk@40909
git-svn-id: http://core.svn.wordpress.org/trunk@40759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 12:07:41 +00:00
Sergey Biryukov
4398862f3d
I18N: Add context for News blog URL in 'WordPress Events and News' dashboard widget.
...
Props zodiac1978.
Fixes #40929 .
Built from https://develop.svn.wordpress.org/trunk@40905
git-svn-id: http://core.svn.wordpress.org/trunk@40755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 11:52:43 +00:00
Andrea Fercia
f28f4fc637
Accessibility: Avoid a keyboard trap on the permalink custom structure setting.
...
Using the `focus` event on the permalink custom structure field made impossible
to navigate through all the form fields using only the keyboard without actually
selecting the custom structure setting. Instead, using click and input preserves
the original functionality when using any kind of pointing or input device.
Also changes `attr()` to `prop()`` as recommended for a `checked` property.
Fixes #40982 .
Built from https://develop.svn.wordpress.org/trunk@40897
git-svn-id: http://core.svn.wordpress.org/trunk@40747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-12 14:09:43 +00:00
Weston Ruter
2327afb5fe
Customize: Restore right border on footer actions.
...
Fixes regression introduced in [40511].
Props timmydcrawford.
See #32296 .
Fixes #40978 .
Built from https://develop.svn.wordpress.org/trunk@40896
git-svn-id: http://core.svn.wordpress.org/trunk@40746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-12 00:17:44 +00:00
Sergey Biryukov
5041510529
Docs: Remove duplicate @return
keyword in WP_Community_Events::get_request_args
.
...
Props ketuchetan.
Fixes #40973 .
Built from https://develop.svn.wordpress.org/trunk@40895
git-svn-id: http://core.svn.wordpress.org/trunk@40745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-11 11:10:43 +00:00
Aaron Jorbin
9cff8ff056
About Page: update CSS with prefixes
...
Seconded by melchoyce.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40885
git-svn-id: http://core.svn.wordpress.org/trunk@40735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-08 04:51:42 +00:00
Sergey Biryukov
04c688ad52
Docs: Add missing closing quote for 'Restore' in post_row_actions
and page_row_actions
filters documentation.
...
See #26397 .
Built from https://develop.svn.wordpress.org/trunk@40882
git-svn-id: http://core.svn.wordpress.org/trunk@40732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-07 23:11:43 +00:00
Mel Choyce
1f2231fccc
About: Swap out images and videos for CDN versions, and add responsive images.
...
Props: joemcgill, pento.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40881
git-svn-id: http://core.svn.wordpress.org/trunk@40731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-07 22:07:40 +00:00
Dominik Schilling
ec0918a6a7
Upgrade: Add wp-includes/js/tinymce/plugins/wpembed
to $_old_files
.
...
See #39513 .
Fixes #40942 .
Built from https://develop.svn.wordpress.org/trunk@40879
git-svn-id: http://core.svn.wordpress.org/trunk@40729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-07 21:32:44 +00:00
Andrea Fercia
1d34043e8c
Dashboard: Better titles for the Recent Drafts widget.
...
- changes "Drafts" to "Your Recent Drafts" to clarify displayed drafts are the ones from the current user
- clarifies and simplifies the "View all" link
Props soniakash, sudar, bhargavbhandari90, zachwtx, johnroper100, rcutmore.
Fixes #37595 .
Built from https://develop.svn.wordpress.org/trunk@40877
git-svn-id: http://core.svn.wordpress.org/trunk@40727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-05 12:00:43 +00:00
Dominik Schilling
55497ccfd1
I18N: Improve translator comments for strings in the community events widget.
...
Props dimadin, iandunn.
Fixes #40865 .
Built from https://develop.svn.wordpress.org/trunk@40866
git-svn-id: http://core.svn.wordpress.org/trunk@40716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-01 09:49:42 +00:00
Dominik Schilling
7737e48a21
About: Sync tagline from about page with credits and freedoms.
...
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40865
git-svn-id: http://core.svn.wordpress.org/trunk@40715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-01 09:24:43 +00:00
Dominik Schilling
0e82284d87
Multisite: Revert indentation of the sample page content added in [40296].
...
Props swissspidy.
Fixes #40895 .
Built from https://develop.svn.wordpress.org/trunk@40864
git-svn-id: http://core.svn.wordpress.org/trunk@40714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-01 09:16:40 +00:00
Mel Choyce
d69e67581f
About: Finalize strings.
...
Props: bridgetwillard, jenblogs4u, michelleweber, flixos90, johnbillion, francina, voldemortensen, melchoyce.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40863
git-svn-id: http://core.svn.wordpress.org/trunk@40713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-01 03:14:41 +00:00
Mel Choyce
69a7ab7d37
About: Add Link Boundary video and update poster image.
...
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40861
git-svn-id: http://core.svn.wordpress.org/trunk@40711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-31 18:02:44 +00:00
Mel Choyce
530577a670
About: Introduce design and add link to Media Widgets API dev note.
...
Props: ryelle rclations melchoyce westonruter.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40849
git-svn-id: http://core.svn.wordpress.org/trunk@40700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-27 15:04:43 +00:00
Andrew Ozz
b015889bb8
About: Further polish for Under The Hood.
...
Props: melchoyce apmarshall obenland. General props for the About page: hedgefield reportermike.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40841
git-svn-id: http://core.svn.wordpress.org/trunk@40692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-25 17:53:40 +00:00
Adam Silverstein
5f411ba353
Plugins: fix regression in search input field size.
...
Fix a formatting regression introduced in [40792] which attempted to resize the input for mobile, see #40130 .
Props leemon, juhise, voldemortensen.
Fixes #40857 .
Built from https://develop.svn.wordpress.org/trunk@40840
git-svn-id: http://core.svn.wordpress.org/trunk@40691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-25 15:22:42 +00:00
Konstantin Obenland
25c2b2cab7
About: Further polish for feature descriptions.
...
Also adds Under The Hood content.
Props apmarshall, azaozz, iandunn, bridgetwillard, melchoyce.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40838
git-svn-id: http://core.svn.wordpress.org/trunk@40689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-25 15:11:42 +00:00
Weston Ruter
bb2e8b0d63
Widgets: Ensure that audio and video files appear in media library browser upon upload.
...
Props timmydcrawford.
Amends [40640].
See #32417 , #39994 , #39995 .
Fixes #40803 .
Built from https://develop.svn.wordpress.org/trunk@40836
git-svn-id: http://core.svn.wordpress.org/trunk@40687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-25 03:20:41 +00:00
Weston Ruter
478d7730b6
Widgets: Prevent multiple items from being selectable when first populating a media widget.
...
Amends [40640].
Props obenland, timmydcrawford.
See #32417 .
Built from https://develop.svn.wordpress.org/trunk@40827
git-svn-id: http://core.svn.wordpress.org/trunk@40684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-24 05:31:42 +00:00
Adam Silverstein
5cc6c39430
Themes: improve browser history support on new themes page.
...
When closing the theme preview, restore the previously selected tab. Avoid an issue where duplicate entries in the history prevented navigation. When re-opening the preview, remove bound event handlers before re-adding them.
Props afercia.
Fixes #36613 .
Built from https://develop.svn.wordpress.org/trunk@40824
git-svn-id: http://core.svn.wordpress.org/trunk@40681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-23 20:32:44 +00:00
Andrea Fercia
3aabc09e9c
Administration: Fix some HTML validation errors.
...
Fixes some minor HTML issues in the admin and, most notably, changes the rel
attribute used in the List Tables from `rel="permalink"` to `rel="bookmark"`.
Props mihai2u, pento, arena, topher1kenobe, michalzuber, stubgo.
Fixes #37004 .
Built from https://develop.svn.wordpress.org/trunk@40823
git-svn-id: http://core.svn.wordpress.org/trunk@40680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-23 17:58:43 +00:00
Sergey Biryukov
da0a505497
Administration: Update the docs for wp_check_browser_version()
.
...
Correct `update_url` key name, add missing `platform` key.
Props coffee2code.
Fixes #40839 .
Built from https://develop.svn.wordpress.org/trunk@40822
git-svn-id: http://core.svn.wordpress.org/trunk@40679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-23 00:17:42 +00:00
Weston Ruter
6e935e7f20
Widgets: Further refine WP JS coding style in media widgets code.
...
Props afercia.
See #32417 .
Built from https://develop.svn.wordpress.org/trunk@40821
git-svn-id: http://core.svn.wordpress.org/trunk@40678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-22 22:05:42 +00:00
Dominik Schilling
24a7666e69
About: Remove a stray quotation mark.
...
Props odysseygate.
See #40721 .
Fixes #40837 .
Built from https://develop.svn.wordpress.org/trunk@40814
git-svn-id: http://core.svn.wordpress.org/trunk@40672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-22 15:02:43 +00:00
Dominik Schilling
96549c5022
Widgets: Remove unused JS variable to fix JSHint error introduced in [40640].
...
See #39994 .
Built from https://develop.svn.wordpress.org/trunk@40811
git-svn-id: http://core.svn.wordpress.org/trunk@40669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-20 09:45:42 +00:00
Weston Ruter
039397721e
Widgets: Introduce isHostedVideo
method on VideoWidgetControl
to allow plugins to extend for recognizing services beyond YouTube and Vimeo.
...
Also update jshint configuration in Gruntfile to include the widget scripts among the JS files linted.
Props timmydcrawford.
See #39994 .
Fixes #40808 .
Built from https://develop.svn.wordpress.org/trunk@40810
git-svn-id: http://core.svn.wordpress.org/trunk@40668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-20 04:18:41 +00:00
Sergey Biryukov
2c5e9a34b2
Dashboard: Change the cache key for dashboard RSS widget; remove the unnecessary database upgrade routine.
...
Props iandunn, ocean90.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40803
git-svn-id: http://core.svn.wordpress.org/trunk@40661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 19:14:42 +00:00
Sergey Biryukov
a2788b09d5
Dashboard: Append the current locale to dashboard RSS widget cache key in wp_dashboard_rss_control()
, for consistency with the changes to wp_dashboard_cached_rss_widget()
in [33183] and [33192].
...
See #32804 , #40702 .
Built from https://develop.svn.wordpress.org/trunk@40802
git-svn-id: http://core.svn.wordpress.org/trunk@40660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 19:00:44 +00:00
Joe McGill
7d43d71800
Media: Ensure WP_Screen sets post type on wp-admin/upload.php.
...
The post type property is set to 'attachment' when on the upload screen.
Props postpostmodern.
Fixes #39509 .
Built from https://develop.svn.wordpress.org/trunk@40800
git-svn-id: http://core.svn.wordpress.org/trunk@40658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 18:29:42 +00:00
Andrea Fercia
1a8f7ab144
Dashboard: Don't trigger an Events search when the search field is empty.
...
Fixes #40816 .
Built from https://develop.svn.wordpress.org/trunk@40799
git-svn-id: http://core.svn.wordpress.org/trunk@40657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 17:27:43 +00:00
Konstantin Obenland
92642624fd
About: Optimize strings for l10n
...
Uses html entities for quotes and adds translator comment for event links.
Props ocean90.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40798
git-svn-id: http://core.svn.wordpress.org/trunk@40656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 16:45:44 +00:00
Andrea Fercia
e008a5c7db
Themes: Improve the theme installer Favorites and Feature Filter tabs alignment.
...
Props nitin kevadiya, darshan02, mp518.
Fixes #40315 .
Built from https://develop.svn.wordpress.org/trunk@40797
git-svn-id: http://core.svn.wordpress.org/trunk@40655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 16:18:41 +00:00