Commit Graph

212 Commits

Author SHA1 Message Date
Andrew Ozz
70ac7ab943 Editor: hide the Move to Trash link for auto-drafts until they are auto-saved.
Props iseulde.
Fixes #16116.
Built from https://develop.svn.wordpress.org/trunk@36972


git-svn-id: http://core.svn.wordpress.org/trunk@36940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 17:22:26 +00:00
Dominik Schilling
b3d8732c17 jQuery: Replace the use of the .size() method with the .length property.
The `.size()` method is deprecated since jQuery 1.8. The `.length` property is preferred because it doesn't have the overhead of a function call.

See https://api.jquery.com/size/.
See #35380.
Built from https://develop.svn.wordpress.org/trunk@36286


git-svn-id: http://core.svn.wordpress.org/trunk@36253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 16:17:27 +00:00
Boone Gorges
cbb245196c Use a more generous selector when setting up tag suggestion.
This allows taxonomy metaboxes to be registered in a greater variety of
locations on the Dashboard.

Props johnjamesjacoby..
Fixes #35349.
Built from https://develop.svn.wordpress.org/trunk@36227


git-svn-id: http://core.svn.wordpress.org/trunk@36194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-08 23:18:25 +00:00
Scott Taylor
e649fabb6a Accessibility: add missing alt attributes to a gaggle of <img>s.
Props afercia.
Fixes #34583.

Built from https://develop.svn.wordpress.org/trunk@35567


git-svn-id: http://core.svn.wordpress.org/trunk@35531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 16:12:27 +00:00
Sergey Biryukov
f98136c1b5 Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
Props afercia.
Fixes #34255.
Built from https://develop.svn.wordpress.org/trunk@35229


git-svn-id: http://core.svn.wordpress.org/trunk@35195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:02:25 +00:00
Scott Taylor
5fdf928bcf Admin JS: after [34977], avoid variable names conflicts with e.
Props afercia.
Fixes #18590.

Built from https://develop.svn.wordpress.org/trunk@35014


git-svn-id: http://core.svn.wordpress.org/trunk@34979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:50:24 +00:00
Andrew Ozz
a6cf0b41a6 JS: in event callbacks replace the very outdated return false with preventDefault().
Props adamsilverstein.
Fixes #18590.
Built from https://develop.svn.wordpress.org/trunk@34977


git-svn-id: http://core.svn.wordpress.org/trunk@34942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 01:27:27 +00:00
Helen Hou-Sandí
02703fae19 Sample permalink: Buttons still need the .button class.
Also fixes unit tests post-[34670]. The test methods have been slightly renamed because it is no longer a button. Hopefully this name will be more future-proof.

see #18306.

Built from https://develop.svn.wordpress.org/trunk@34671


git-svn-id: http://core.svn.wordpress.org/trunk@34635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 22:07:25 +00:00
Helen Hou-Sandí
e976f9b503 Edit: Remove the redundant "View Post" button-link and link the sample permalink.
Previously there were two persistent "View Post" links on an edit screen: next to the permalink and in the toolbar. This would then become three links after a post was published or updated, as a link is also included in the admin notice. This is a lot of redundancy and visual noise for a flow that is not your primary action upon starting to edit a post. The "View Post" link next to the sample permalink was particularly bad because it is styled like a button, but unlike a button, does not keep you on the current screen.

Because the permalink is now linked, there is no highlighted slug that you can click to edit, but rather just the "Edit" button.

props scribu, lessbloat, sabreuse, SergeyBiryukov, DrewAPicture, helen.
see #18306.

Built from https://develop.svn.wordpress.org/trunk@34670


git-svn-id: http://core.svn.wordpress.org/trunk@34634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 20:10:26 +00:00
Scott Taylor
373d73f781 Turn off autocomplete for the new-post-slug field.
Props johnbillion.
Fixes #32752.

Built from https://develop.svn.wordpress.org/trunk@34105


git-svn-id: http://core.svn.wordpress.org/trunk@34073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 02:03:25 +00:00
Scott Taylor
b453af5718 When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on commentsBox, ->load(), that resets st (cool name) to the number of visible <tr>s before calling ->get(). This will account for spam'd and trash'd comments when returning comments at the proper offset.
Props utkarshpatel.
Fixes #33829.

Built from https://develop.svn.wordpress.org/trunk@34069


git-svn-id: http://core.svn.wordpress.org/trunk@34037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 02:28:26 +00:00
Andrew Ozz
e3f3f470ea Editor, Press This: force a page reload when the user publishes a post and then clicks the back button.
Fixes #23691.
Built from https://develop.svn.wordpress.org/trunk@33836


git-svn-id: http://core.svn.wordpress.org/trunk@33804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 23:08:22 +00:00
Andrew Ozz
fa25fe82ef Fix updating of nonces on the Edit Post screen after the log in expires and the user logs in again.
Props iseulde, azaozz. Fixes #33098.
Built from https://develop.svn.wordpress.org/trunk@33468


git-svn-id: http://core.svn.wordpress.org/trunk@33435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-28 22:07:25 +00:00
Ella Iseulde Van Dorpe
482f174f2e Publish box: move focus when the animation is done
Also move the focus back to 'edit' when saving changes.

Props afercia.
Fixes #33060.

Built from https://develop.svn.wordpress.org/trunk@33352


git-svn-id: http://core.svn.wordpress.org/trunk@33324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:46:24 +00:00
Ella Iseulde Van Dorpe
253d9db831 Publish box: focus first date field on edit
The order of the fields may change depending on the translation.

Props afercia.
Fixes #33059.

Built from https://develop.svn.wordpress.org/trunk@33349


git-svn-id: http://core.svn.wordpress.org/trunk@33321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:23:24 +00:00
Ella Iseulde Van Dorpe
52f6aebdaa Publish box: fix leading zeros in date format
See #30716.

Built from https://develop.svn.wordpress.org/trunk@33341


git-svn-id: http://core.svn.wordpress.org/trunk@33313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 14:55:24 +00:00
Ella Iseulde Van Dorpe
262c1a7e54 Publish box: fix strange date format after change
Part props tyxla.
Fixes #30716.

Built from https://develop.svn.wordpress.org/trunk@33340


git-svn-id: http://core.svn.wordpress.org/trunk@33312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 11:40:25 +00:00
Konstantin Obenland
2f383536fc Check if commentReply exists before trying to work with it.
Fixes a bug that caused the save/publish flow to be interrupted by an AYS.

Introduced in [33024].
See #29457.


Built from https://develop.svn.wordpress.org/trunk@33066


git-svn-id: http://core.svn.wordpress.org/trunk@33037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 15:32:25 +00:00
Ella Iseulde Van Dorpe
12fba44414 Editor: refresh word count quicker
2 seconds is a bit slow. Debouncing with 1 second means it can only run maximum once per second. In reality it won't run us much. Even people who type slow will usually type faster than 1 character per second.

See #30966.


Built from https://develop.svn.wordpress.org/trunk@33060


git-svn-id: http://core.svn.wordpress.org/trunk@33031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 09:15:24 +00:00
Konstantin Obenland
d03ff4b3d9 Close comment quick edit before updating a post.
Fixes a bug where the user gets redirected to the All Posts screen, after
updating a post while quick editing a comment.

Props polevaultweb.
Fixes #29457.


Built from https://develop.svn.wordpress.org/trunk@33024


git-svn-id: http://core.svn.wordpress.org/trunk@32995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:54:24 +00:00
Ella Iseulde Van Dorpe
fd95002b2a Editor: restructure word count
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.

See #30966. Fixes #26620.


Built from https://develop.svn.wordpress.org/trunk@32856


git-svn-id: http://core.svn.wordpress.org/trunk@32827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 10:35:26 +00:00
Andrew Ozz
02f5020d52 Editor: run autosave when pressing Ctrl or Command + S in the Text editor, same as the Visual editor.
Fixes #31655.
Built from https://develop.svn.wordpress.org/trunk@32680


git-svn-id: http://core.svn.wordpress.org/trunk@32650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 19:02:25 +00:00
Helen Hou-Sandí
3ac1a19529 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.

Built from https://develop.svn.wordpress.org/trunk@31996


git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Gary Pendergast
b7546d798f Emoji: Instead of having custom hooks for Ajax callbacks, use MutationObserver to re-parse any changed elements in the DOM.
Props iseulde

See #31242


Built from https://develop.svn.wordpress.org/trunk@31750


git-svn-id: http://core.svn.wordpress.org/trunk@31731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 12:52:26 +00:00
Andrew Nacin
78679bfb3f Emoji JS cleanup.
* Filename: emoji.js => wp-emoji.js
 * Script handle: emoji => wp-emoji
 * Object: WPEmoji => wp.emoji
 * Script settings: EmojiSettings => _wpemojiSettings
 * Setting key: base_url => baseUrl
 * Remove executable bit from files

see #31242.

Built from https://develop.svn.wordpress.org/trunk@31744


git-svn-id: http://core.svn.wordpress.org/trunk@31725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 03:17:26 +00:00
Sergey Biryukov
9f6cd01346 Fix JSHint errors in [31734] and add missing dependencies.
props iseulde.
fixes #31328.
Built from https://develop.svn.wordpress.org/trunk@31741


git-svn-id: http://core.svn.wordpress.org/trunk@31722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 01:05:26 +00:00
Gary Pendergast
03ade8c011 Add emoji URL support, and Twemoji fallback for displaying slugs in wp-admin, when the browser doesn't natively support emoji.
Props pento, SergeyBiryukov and boonebgorges.

Fixes #31328


Built from https://develop.svn.wordpress.org/trunk@31734


git-svn-id: http://core.svn.wordpress.org/trunk@31715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 22:55:28 +00:00
Andrew Ozz
d84eda9f35 Grunt precommit cleanup. See [31533], [31535].
Built from https://develop.svn.wordpress.org/trunk@31538


git-svn-id: http://core.svn.wordpress.org/trunk@31519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 04:17:27 +00:00
Andrew Ozz
1857055bb8 PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31534


git-svn-id: http://core.svn.wordpress.org/trunk@31515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 01:50:26 +00:00
Helen Hou-Sandí
cb5c43df83 Don't over-target buttons in the publish meta box.
This selector caused breakage for any custom buttons added.

props ericlewis.
fixes #30035.

Built from https://develop.svn.wordpress.org/trunk@30698


git-svn-id: http://core.svn.wordpress.org/trunk@30688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 02:35:28 +00:00
Andrew Ozz
b9886e92e3 Editor scrolling:
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.
Built from https://develop.svn.wordpress.org/trunk@29336


git-svn-id: http://core.svn.wordpress.org/trunk@29116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 02:43:17 +00:00
Andrew Ozz
39bf5e06b1 Editor scrolling: disable on mobile devices and hide the resize handle. See #28328.
Built from https://develop.svn.wordpress.org/trunk@29117


git-svn-id: http://core.svn.wordpress.org/trunk@28903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-12 00:54:14 +00:00
Andrew Ozz
5e4a020ff8 Enhance the editor on the Add/Edit Post screens, first run. Props avril, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29049


git-svn-id: http://core.svn.wordpress.org/trunk@28837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-09 22:06:15 +00:00
Sergey Biryukov
d2a43e7cb2 Don't add # to URL when clicking 'OK' without changing the permalink.
props avryl.
fixes #27594.
Built from https://develop.svn.wordpress.org/trunk@28771


git-svn-id: http://core.svn.wordpress.org/trunk@28584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-18 00:29:15 +00:00
Andrew Ozz
46bdcce0eb Ensure the editor height is saved properly, props jupiterwise, see #28000, for trunk.
Built from https://develop.svn.wordpress.org/trunk@28193


git-svn-id: http://core.svn.wordpress.org/trunk@28023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-24 04:11:15 +00:00
Andrew Ozz
dea2eaa1e3 Fix typo in var definition in [28069], see #27750
Built from https://develop.svn.wordpress.org/trunk@28070


git-svn-id: http://core.svn.wordpress.org/trunk@27901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-10 22:14:15 +00:00
Andrew Ozz
8072976c06 Fix tabbing out of the title field on Media -> Edit Media screen, fixes #27750
Built from https://develop.svn.wordpress.org/trunk@28069


git-svn-id: http://core.svn.wordpress.org/trunk@27900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-10 22:10:15 +00:00
Andrew Ozz
2194145373 When autosaving a new post for the first time after a title was typed, cancel the autosave if the user is submitting the form. (Includes a precommit fix for customize-controls.css.) Props Nessworthy, davidmarichal, fixes #27657
Built from https://develop.svn.wordpress.org/trunk@27951


git-svn-id: http://core.svn.wordpress.org/trunk@27781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 01:29:14 +00:00
Andrew Ozz
2d0ce517e8 TinyMCE: better calculation for editor height when switching Text to Visual and back. Add stopping of editor resizing when the mouse leaves the browser window. See #27279
Built from https://develop.svn.wordpress.org/trunk@27941


git-svn-id: http://core.svn.wordpress.org/trunk@27771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 01:31:15 +00:00
Andrew Nacin
68bfa704cf Remove unused JS variables after [27770]. see #27013.
Built from https://develop.svn.wordpress.org/trunk@27783


git-svn-id: http://core.svn.wordpress.org/trunk@27619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 17:31:14 +00:00
Andrew Ozz
15549e75f3 Remove containment of scrolling inside the editor for now. See #27013
Built from https://develop.svn.wordpress.org/trunk@27770


git-svn-id: http://core.svn.wordpress.org/trunk@27607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 02:35:14 +00:00
Andrew Ozz
339a33bb45 Autosave: don't create the temporary permalink if the title field had focus (the user was typing a title) at the time of the last autosave. Fixes #27503
Built from https://develop.svn.wordpress.org/trunk@27728


git-svn-id: http://core.svn.wordpress.org/trunk@27565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 22:22:14 +00:00
Andrew Ozz
cab6362f2b Editor: throttle scrolling of the main window when the editor is active and is being scrolled with the mouse wheel or a trackpad, see #27013
Built from https://develop.svn.wordpress.org/trunk@27368


git-svn-id: http://core.svn.wordpress.org/trunk@27218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 02:34:14 +00:00
Andrew Nacin
6adabc6e4d Various JSHint fixes. see #26446.
Built from https://develop.svn.wordpress.org/trunk@27131


git-svn-id: http://core.svn.wordpress.org/trunk@26998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-08 00:52:12 +00:00
Andrew Ozz
5ea367cfe1 Fix scrolling inside the Visual editor on MacOS, add the same functionality to the Text editor, see #27013
Built from https://develop.svn.wordpress.org/trunk@27110


git-svn-id: http://core.svn.wordpress.org/trunk@26977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 19:34:12 +00:00
Andrew Ozz
87c3c8adc0 Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233.
Built from https://develop.svn.wordpress.org/trunk@27079


git-svn-id: http://core.svn.wordpress.org/trunk@26952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-02 23:50:13 +00:00
Andrew Ozz
864ab9ae56 Autosave:
- Move the 'Saving post' and 'Draft saved at...' strings from autosaveL10n to postL10n as they are used only there.
- Use the custom jQuery events 'before-autosave' and 'after-autosave' to show these messages.
- Separate autosave.suspend() for local and server so local autosaves can continue while server autosaves are suspended.
- Remove the recently added autosave.server.disable() and use autosave.server.suspend() instead.
- Bring back .button.disabled, button-primary.disabled and use .disabled to prevent multiple form submissions.
See #25272.

Built from https://develop.svn.wordpress.org/trunk@27038


git-svn-id: http://core.svn.wordpress.org/trunk@26914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-27 00:28:13 +00:00
Andrew Ozz
61540893f3 Fix tabbing order when opening/closing post status and visibility in the Publish postbox and cache some of the jQuery selectors. Part-props atimmer, fixes #25460.
Built from https://develop.svn.wordpress.org/trunk@27035


git-svn-id: http://core.svn.wordpress.org/trunk@26911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-26 03:07:16 +00:00
Andrew Ozz
4d531835a8 Autosave: don't set "submit" buttons to disabled right before submitting the form. They are not sent with the form data, see #25272.
Built from https://develop.svn.wordpress.org/trunk@27015


git-svn-id: http://core.svn.wordpress.org/trunk@26892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 21:26:10 +00:00
Andrew Ozz
97afd9c251 Autosave: don't disable the buttons on previewing a post, see #25272.
Built from https://develop.svn.wordpress.org/trunk@27003


git-svn-id: http://core.svn.wordpress.org/trunk@26880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 17:58:12 +00:00