Scott Taylor
19b8ef0c92
get_comments()
can return int
, so a few places need to check if the return value is traversable before passing what is assumed to be an array
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32600
git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:59:25 +00:00
Drew Jaynes
4c37f68b79
Fix inline documentation syntax in wp_xmlrpc_server
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32591
git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:25:25 +00:00
Scott Taylor
af7a017f46
When calling unset()
, it is unnecessary to immediately precede it with a call to isset()
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32545
git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:47:25 +00:00
Scott Taylor
a69b8b3b91
In WP_Media_List_Table::get_views()
, declare $num_posts
explicitly before looping.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32517
git-svn-id: http://core.svn.wordpress.org/trunk@32487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:50:27 +00:00
Scott Taylor
5a3dc2a371
In WP_Comments_List_Table::column_comment()
, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32516
git-svn-id: http://core.svn.wordpress.org/trunk@32486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:46:25 +00:00
Dion Hulse
2ba7f3da75
Allow plugins to activate other plugins within their Activation hook. Fixes #32368
...
Built from https://develop.svn.wordpress.org/trunk@32504
git-svn-id: http://core.svn.wordpress.org/trunk@32474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 06:58:27 +00:00
Dominik Schilling
f9e1c18698
List Table: Add placeholder to a plural string.
...
props SergeyBiryukov.
fixes #32034 .
Built from https://develop.svn.wordpress.org/trunk@32473
git-svn-id: http://core.svn.wordpress.org/trunk@32443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 19:22:24 +00:00
Dominik Schilling
5268a77a80
Sites List Table: Replace context with a translators comment for the site name and tagline.
...
props ramiy.
fixes #31849 .
Built from https://develop.svn.wordpress.org/trunk@32472
git-svn-id: http://core.svn.wordpress.org/trunk@32442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 19:18:27 +00:00
Dominik Schilling
c37bdc3c9e
Merge similar error strings.
...
props pavelevap.
fixes #32327 .
Built from https://develop.svn.wordpress.org/trunk@32471
git-svn-id: http://core.svn.wordpress.org/trunk@32441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 18:27:26 +00:00
Gary Pendergast
02621f2a14
Upgrades: If a table has already been converted to utf8mb4
, there's no need to try and convert it again.
...
Props gabrielperezs for the initial patch.
See #32310 .
Built from https://develop.svn.wordpress.org/trunk@32456
git-svn-id: http://core.svn.wordpress.org/trunk@32426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 12:22:25 +00:00
Michael Adams
a3807c1d34
Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes.
...
Props jorbin, et alii.
See #32165 .
Built from https://develop.svn.wordpress.org/trunk@32440
git-svn-id: http://core.svn.wordpress.org/trunk@32410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-07 01:11:29 +00:00
Michael Adams
26c3c6d9cb
Upgrade: $wpdb->get_col_length()
sanity check: bail on unexpected return value.
...
See #32165 .
Built from https://develop.svn.wordpress.org/trunk@32429
git-svn-id: http://core.svn.wordpress.org/trunk@32399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 23:11:26 +00:00
Michael Adams
0640526e72
Upgrade: Ensure unintelligible DB schemas don't result in content loss.
...
See #32165 .
Built from https://develop.svn.wordpress.org/trunk@32417
git-svn-id: http://core.svn.wordpress.org/trunk@32387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 21:46:26 +00:00
Aaron Jorbin
2d189ef812
When upgrading WordPress remove genericons example.html files
...
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin
--This line,build.wordpress-develop.dea and those below, will be ignored--
M src/wp-admin/includes/update-core.php
Built from https://develop.svn.wordpress.org/trunk@32385
git-svn-id: http://core.svn.wordpress.org/trunk@32355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 18:37:25 +00:00
Sergey Biryukov
77572cf024
Multisite: Add translator comments to default email messages with non-typical placeholders.
...
props yoavf.
fixes #32263 .
Built from https://develop.svn.wordpress.org/trunk@32381
git-svn-id: http://core.svn.wordpress.org/trunk@32351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 09:12:25 +00:00
Gary Pendergast
4e615fb9ff
Fix an incorrect version number check in [32378].
...
See #32099 .
Built from https://develop.svn.wordpress.org/trunk@32379
git-svn-id: http://core.svn.wordpress.org/trunk@32349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 07:41:24 +00:00
Gary Pendergast
3a6e79c409
Upgrades: When converting to utf8mb4
, we were trying to change the wrong index on wp_signups
, causing the conversion to later fail.
...
Props kovshenin, pento.
See #32099 .
Built from https://develop.svn.wordpress.org/trunk@32378
git-svn-id: http://core.svn.wordpress.org/trunk@32348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 07:34:24 +00:00
Gary Pendergast
364886a5be
WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding()
, as it behaves differently to MySQL's character encoding conversion.
...
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.
See #32165 .
Built from https://develop.svn.wordpress.org/trunk@32364
git-svn-id: http://core.svn.wordpress.org/trunk@32335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 03:00:25 +00:00
Drew Jaynes
a452927c39
Fix documentation syntax and formatting for the media_sideload_image()
DocBlock.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32352
git-svn-id: http://core.svn.wordpress.org/trunk@32323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-05 02:20:25 +00:00
Drew Jaynes
cbd07f213d
Add two changelog entries for functional changes introduced in 4.2.0.
...
Props dimadin.
See #31925 .
Built from https://develop.svn.wordpress.org/trunk@32350
git-svn-id: http://core.svn.wordpress.org/trunk@32321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-05 02:16:25 +00:00
Drew Jaynes
08e3572b7c
Add a missing DocBlock for wp_caption_input_textarea()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32341
git-svn-id: http://core.svn.wordpress.org/trunk@32312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:13:25 +00:00
Drew Jaynes
e7e93f50cf
Add a missing @return
tag to the DocBlock for `uninstall_plugin().
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32340
git-svn-id: http://core.svn.wordpress.org/trunk@32311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:08:27 +00:00
Drew Jaynes
87e149a19f
Add a missing @return
tag to the DocBlock for site_admin_notice()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32339
git-svn-id: http://core.svn.wordpress.org/trunk@32310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:06:25 +00:00
Drew Jaynes
cdbecf201b
Clarify accepted types for the $args
and $context
parameters in WP_Filesystem()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32338
git-svn-id: http://core.svn.wordpress.org/trunk@32309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 01:04:25 +00:00
Sergey Biryukov
ed0da72d97
Replace echo __()
with _e()
.
...
props marsjaninzmarsa.
fixes #32239 .
Built from https://develop.svn.wordpress.org/trunk@32333
git-svn-id: http://core.svn.wordpress.org/trunk@32304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-03 16:18:28 +00:00
Scott Taylor
2807b7146f
After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
...
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.
See #31139 .
Built from https://develop.svn.wordpress.org/trunk@32330
git-svn-id: http://core.svn.wordpress.org/trunk@32301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 21:40:25 +00:00
Sergey Biryukov
aaafb3113a
Bulk Edit: Properly associate the Format select with its label.
...
props afercia.
fixes #32210 .
Built from https://develop.svn.wordpress.org/trunk@32329
git-svn-id: http://core.svn.wordpress.org/trunk@32300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 16:04:24 +00:00
Dion Hulse
610e34c215
When creating a temporary file treat the /
directory properly, to prevent it ending up in an endless self-calling loop.
...
Props hnle, taka2. Fixes #32135 . See #31811
Built from https://develop.svn.wordpress.org/trunk@32322
git-svn-id: http://core.svn.wordpress.org/trunk@32293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-29 03:17:31 +00:00
Gary Pendergast
44b56d9393
When deleting suspicious comments, do so permanently.
...
Built from https://develop.svn.wordpress.org/trunk@32310
git-svn-id: http://core.svn.wordpress.org/trunk@32281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:11:26 +00:00
Gary Pendergast
b89fc65951
[32308] was for 4.3, not 4.2.1.
...
Built from https://develop.svn.wordpress.org/trunk@32309
git-svn-id: http://core.svn.wordpress.org/trunk@32280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:08:27 +00:00
Gary Pendergast
51402dc520
When upgrading to 4.2.1, delete suspicious comments.
...
Built from https://develop.svn.wordpress.org/trunk@32308
git-svn-id: http://core.svn.wordpress.org/trunk@32279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-27 16:04:25 +00:00
Dominik Schilling
89e45feb4c
Don't focus input fields outside of the request filesystem credentials form.
...
props valendesigns.
fixes #32055 .
Built from https://develop.svn.wordpress.org/trunk@32266
git-svn-id: http://core.svn.wordpress.org/trunk@32237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:24:26 +00:00
Dominik Schilling
e0657e6904
Don't return empty themes in wp_prepare_themes_for_js()
.
...
see #32002 .
Built from https://develop.svn.wordpress.org/trunk@32264
git-svn-id: http://core.svn.wordpress.org/trunk@32235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-22 16:11:25 +00:00
Andrew Ozz
60706015e1
Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
...
Props iseulde. Fixes #31139 , fixes #32006 .
Built from https://develop.svn.wordpress.org/trunk@32258
git-svn-id: http://core.svn.wordpress.org/trunk@32229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 22:41:26 +00:00
Helen Hou-Sandí
1d1c026e8e
Rename the pre_wp_prepare_themes_for_js
filter to pre_prepare_themes_for_js
.
...
props DrewAPicture.
fixes #31789 .
Built from https://develop.svn.wordpress.org/trunk@32246
git-svn-id: http://core.svn.wordpress.org/trunk@32217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 14:23:27 +00:00
Gary Pendergast
e3f1f8fed1
Ensure post titles are correctly escaped on the Dashboard.
...
Props helen, ocean90, dd32, pento.
Built from https://develop.svn.wordpress.org/trunk@32175
git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 07:39:25 +00:00
Sergey Biryukov
7f48138743
Press This: Update documentation for press_this_save_redirect
filter after [31992].
...
props kraftbj.
fixes #31996 .
Built from https://develop.svn.wordpress.org/trunk@32143
git-svn-id: http://core.svn.wordpress.org/trunk@32123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-19 01:34:28 +00:00
Dominik Schilling
786bce5b9c
Customizer: Escape theme preview URLs.
...
props johnbillion, ocean90.
see #31896 .
Built from https://develop.svn.wordpress.org/trunk@32134
git-svn-id: http://core.svn.wordpress.org/trunk@32113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-15 16:33:25 +00:00
Scott Taylor
5e4616039c
Move the built media JS files up a directory to their previous location and naming convention. This fidgets with part of [31373] and will maintain BC for those who were loading those files directly (not using the enqueue system).
...
Props iseulde, ocean90.
Fixes #31912 .
Built from https://develop.svn.wordpress.org/trunk@32125
git-svn-id: http://core.svn.wordpress.org/trunk@32104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 15:31:28 +00:00
Andrew Ozz
fe150b9ef2
Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php.
...
Props kraftbj. Fixes #31968 .
Built from https://develop.svn.wordpress.org/trunk@32122
git-svn-id: http://core.svn.wordpress.org/trunk@32101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 05:45:28 +00:00
Dominik Schilling
64fc7294b6
Use HTTPS URLs for codex.wordpress.org.
...
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@32116
git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Gary Pendergast
0179958273
When dbDelta()
is checking whether an index is defined in a CREATE TABLE
statement, don't worry if MySQL has a subpart defined on an index, but the CREATE TABLE
doesn't.
...
Fixes #31869 .
Built from https://develop.svn.wordpress.org/trunk@32108
git-svn-id: http://core.svn.wordpress.org/trunk@32087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-11 10:40:31 +00:00
Andrew Ozz
ad475b3c69
Press This: check the bookmarklet version and add the update notice from PHP.
...
Fixes #31942 .
Built from https://develop.svn.wordpress.org/trunk@32106
git-svn-id: http://core.svn.wordpress.org/trunk@32085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-10 21:08:29 +00:00
Andrew Ozz
0d4b29ffb9
Press This: add ARIA attributes to the alerts
container.
...
Props afercia. Fixes #31942 .
Built from https://develop.svn.wordpress.org/trunk@32102
git-svn-id: http://core.svn.wordpress.org/trunk@32081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-09 23:45:27 +00:00
Andrew Ozz
9db5bac3c4
Press This: change the link text to Standard Editor.
...
Props Michael-Arestad. See #31923 .
Built from https://develop.svn.wordpress.org/trunk@32093
git-svn-id: http://core.svn.wordpress.org/trunk@32072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:28:25 +00:00
Andrew Ozz
33a0022773
Press This:
...
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923 .
Built from https://develop.svn.wordpress.org/trunk@32092
git-svn-id: http://core.svn.wordpress.org/trunk@32071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 23:14:28 +00:00
Boone Gorges
54a6a8e137
Don't allow whitespace-only image captions from the Media modal.
...
Captions containing only whitespace trick `image_add_caption()` into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.
Fixes #21848 .
Built from https://develop.svn.wordpress.org/trunk@32079
git-svn-id: http://core.svn.wordpress.org/trunk@32058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 17:11:27 +00:00
Aaron Jorbin
abfddb8f3e
Update placeholder for FTP credentials
...
Two changes:
* Remove superfluous __ function call
* Update domain used
Fixes #31922
Props Tmeister
Built from https://develop.svn.wordpress.org/trunk@32077
git-svn-id: http://core.svn.wordpress.org/trunk@32056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:50:27 +00:00
Aaron Jorbin
99d6c67148
Enable users to initiate a shiny update from plugin detail modal
...
The plugin detail modal can contain a link to update a plugin. When it does, we should initiate a shiny update.
This relies upon postMessage which isn't available in all browsers, specifically it isn't in IE versions below 8 so this is going to be a progressive enhancement that some small percentage of users will miss out on. These are the same users that can't use the customizer.
Fixes #31739
Built from https://develop.svn.wordpress.org/trunk@32062
git-svn-id: http://core.svn.wordpress.org/trunk@32041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-07 03:09:26 +00:00
Helen Hou-Sandí
42028327a2
Insert from URL: Make sure the link text is actually used.
...
Turns out there were more pieces to renaming the field.
props iseulde.
fixes #29476 .
Built from https://develop.svn.wordpress.org/trunk@32055
git-svn-id: http://core.svn.wordpress.org/trunk@32034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-06 18:25:27 +00:00