Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-02 16:59:35 +01:00
Code Issues Projects Releases Wiki Activity
43,596 Commits 50 Branches 747 Tags 785 MiB
267f9d7479
Commit Graph

192 Commits

Author SHA1 Message Date
Sergey Biryukov
47ed56f38f Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
Built from https://develop.svn.wordpress.org/trunk@47198


git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-06 06:33:11 +00:00
Gary Pendergast
af0a914d14 Coding Standards: Move wp-includes/class-oembed.php to wp-includes/class-wp-oembed.php. 
This renames the file containing the `WP_oEmbed` class to conform to the coding standards.

This commit also includes:

- A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45663


git-svn-id: http://core.svn.wordpress.org/trunk@45474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 04:32:57 +00:00
Gary Pendergast
4803fc405e Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45590


git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 23:42:58 +00:00
John Blackbourn
9e891be893 Embeds: Remove the "Supports HTTPS" column from the whitelisted oEmbed provider list now that all supported providers use HTTPS. 
See #28507

Built from https://develop.svn.wordpress.org/trunk@45386


git-svn-id: http://core.svn.wordpress.org/trunk@45197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-23 21:23:53 +00:00
John Blackbourn
5fe92586c0 Embeds: Use HTTPS for the Hulu oEmbed endpoint, as it redirects to HTTPS now. 
Fixes #28507

Built from https://develop.svn.wordpress.org/trunk@45385


git-svn-id: http://core.svn.wordpress.org/trunk@45196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-23 21:20:52 +00:00
John Blackbourn
437285dba4 Embeds: Update the Crowdsignal embed handler so that surveys on subdomains are supported. 
Props kraftbj

Fixes #46467

Built from https://develop.svn.wordpress.org/trunk@45061


git-svn-id: http://core.svn.wordpress.org/trunk@44870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:27:51 +00:00
Sergey Biryukov
f8cfe858c9 Embeds: Scribd: Add support for /document/ URL format, in addition to /doc/. 
Props manzoorwani.jk, neobabis, swissspidy.
Fixes #46444.
Built from https://develop.svn.wordpress.org/trunk@45024


git-svn-id: http://core.svn.wordpress.org/trunk@44833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 00:34:52 +00:00
desrosj
b98affb210 Embeds: Remove Photobucket, FunnyOrDie from the list of oEmbed providers. 
These services no longer support oEmbed.

Props skostadinov, notnownikki.
Fixes #45399.
Built from https://develop.svn.wordpress.org/trunk@44552


git-svn-id: http://core.svn.wordpress.org/trunk@44383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-10 22:42:51 +00:00
Pascal Birchler
3b0b49f900 Embeds: Fix typo introduced in [44484]. 
Props JustinSainton.
Fixes #45036.

Built from https://develop.svn.wordpress.org/trunk@44511


git-svn-id: http://core.svn.wordpress.org/trunk@44342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 10:54:51 +00:00
Gary Pendergast
c6dea4c784 Embeds: Add Instagram TV support. 
Props dannydehaan.
Fixes #44557.


Built from https://develop.svn.wordpress.org/trunk@44486


git-svn-id: http://core.svn.wordpress.org/trunk@44317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-09 00:24:50 +00:00
Gary Pendergast
64d846c7c2 Embeds: Polldaddy is now called Crowdsignal. 
Crowdsignal adds an additional embed URL, survey.fm.

Props donncha.
Fixes #45036.


Built from https://develop.svn.wordpress.org/trunk@44484


git-svn-id: http://core.svn.wordpress.org/trunk@44315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-08 23:52:50 +00:00
Drew Jaynes
9c934c7272 Docs: Remove erroneous pipe character usage in the oembed_providers filter DocBlock. 
Avoids markdown table display errors when parsed and displayed in the Code Reference.

See #42505.

Built from https://develop.svn.wordpress.org/trunk@44333


git-svn-id: http://core.svn.wordpress.org/trunk@44163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-19 16:36:48 +00:00
Gary Pendergast
c925b89152 Embeds: Filter HTML response in oEmbed proxy controller. 
Adapts the response from `WP_oEmbed_Controller::get_proxy_item()` so that the response is correctly filtered and embeds work properly in JavaSccript editors. Introduces new `get_oembed_response_data_for_url()` function for preparing internal oEmbed responses.

Merges [43810] from the 5.0 branch to trunk.

Props danielbachhuber, imath, swissspidy.
Fixes #45142.


Built from https://develop.svn.wordpress.org/trunk@44154


git-svn-id: http://core.svn.wordpress.org/trunk@43984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-14 03:20:37 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
John Blackbourn
b13e73d05c Docs: Document more parameters and properties using typed array notation. 
See #41756

Built from https://develop.svn.wordpress.org/trunk@42875


git-svn-id: http://core.svn.wordpress.org/trunk@42705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-25 18:10:32 +00:00
Sergey Biryukov
b026fde152 Docs: Remove @static notations from property DocBlocks in wp-admin/* and wp-includes/* classes. 
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.

Props birgire.
See #42803.
Built from https://develop.svn.wordpress.org/trunk@42747


git-svn-id: http://core.svn.wordpress.org/trunk@42577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 20:32:30 +00:00
Sergey Biryukov
08227812a0 Docs: Remove @static notations from method DocBlocks in wp-includes/* classes. 
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.

Props birgire.
See #42803.
Built from https://develop.svn.wordpress.org/trunk@42746


git-svn-id: http://core.svn.wordpress.org/trunk@42576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-02-25 20:22:30 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
John Blackbourn
67c973f95e Docs: Correct parameter type documentation for various __call() methods. 
See #42505

Built from https://develop.svn.wordpress.org/trunk@42151


git-svn-id: http://core.svn.wordpress.org/trunk@41982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-10 22:56:47 +00:00
John Blackbourn
3dda9e9257 Embeds: Add oEmbed support for someecards.com. 
Props someecards

Fixes #40792

Built from https://develop.svn.wordpress.org/trunk@41681


git-svn-id: http://core.svn.wordpress.org/trunk@41515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-02 19:10:49 +00:00
John Blackbourn
7859e22ad5 Embeds: Switch the collegehumor.com oEmbed endpoint to HTTPS, as it redirects there by default now. 
See #28507

Built from https://develop.svn.wordpress.org/trunk@41680


git-svn-id: http://core.svn.wordpress.org/trunk@41514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-02 19:06:46 +00:00
John Blackbourn
2e3581c3ad Embeds: Alignment following [41615]. 
See #38181

Built from https://develop.svn.wordpress.org/trunk@41676


git-svn-id: http://core.svn.wordpress.org/trunk@41510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-02 18:38:46 +00:00
John Blackbourn
5c7a7a2989 Embeds: Documentation alignment following [41615]. 
See #38181

Built from https://develop.svn.wordpress.org/trunk@41616


git-svn-id: http://core.svn.wordpress.org/trunk@41451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-27 13:27:44 +00:00
John Blackbourn
4b76c1f22f Embeds: Add support for Amazon Kindle instant previews. 
Props jsepia, morganestes, adamsilverstein, swissspidy, jbpaul17, johnbillion, rugved

Fixes #38181

Built from https://develop.svn.wordpress.org/trunk@41615


git-svn-id: http://core.svn.wordpress.org/trunk@41450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-27 13:26:45 +00:00
Dion Hulse
af3c440b1d Embeds: Switch the Imgur oEmbed endpoint to use SSL as the HTTP version has been deprecated. 
Props swissspidy.
Fixes #41984.

Built from https://develop.svn.wordpress.org/trunk@41599


git-svn-id: http://core.svn.wordpress.org/trunk@41434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-26 08:33:44 +00:00
John Blackbourn
2bd20bb0db Embeds: Remove support for oEmbedded videos from Vine. 
* Vine effectively shut down in December 2016.
* The oEmbed endpoint no longer works and returns a 404.
* Developer documentation for Vine has been removed.

Fixes #41817

Built from https://develop.svn.wordpress.org/trunk@41347


git-svn-id: http://core.svn.wordpress.org/trunk@41180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-08 15:01:44 +00:00
John Blackbourn
e061a432cc Embeds: Add the dnt (Do Not Track) query parameter to all oEmbed provider URLs. 
This means that, for those providers that support this somewhat de-facto standard, visitor tracking is disabled by default for all embeds.

Props norcross, joostdevalk

Fixes #41784

Built from https://develop.svn.wordpress.org/trunk@41345


git-svn-id: http://core.svn.wordpress.org/trunk@41178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-08 12:31:43 +00:00
Drew Jaynes
0860bb2771 Docs: Remove @access notations from method DocBlocks in wp-includes/* classes. 
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.

See #41452.

Built from https://develop.svn.wordpress.org/trunk@41162


git-svn-id: http://core.svn.wordpress.org/trunk@41002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-07-27 00:41:44 +00:00
Pascal Birchler
b0fed2af63 Embeds: Update oEmbed endpoint URL for VideoPress. 
Props NomNom99.
Fixes #41019.
Built from https://develop.svn.wordpress.org/trunk@40901


git-svn-id: http://core.svn.wordpress.org/trunk@40751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-06-15 05:38:45 +00:00
James Nylen
589c4b4b2d REST API: Add endpoint for proxying requests to external oEmbed providers. 
This endpoint is a prerequisite for the media widgets work (see https://github.com/xwp/wp-core-media-widgets).

Also use the new endpoint in the media modal instead of the `parse-embed` AJAX action.

Props westonruter, timmydcrawford, swissspidy, jnylen0.
Fixes #40450.

Built from https://develop.svn.wordpress.org/trunk@40628


git-svn-id: http://core.svn.wordpress.org/trunk@40489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-11 18:18:46 +00:00
Pascal Birchler
e1d5fd1c6b Embeds: Add screencast.com to oEmbed provider whitelist. 
Props ENDif Media.
Fixes #38367.

Built from https://develop.svn.wordpress.org/trunk@40574


git-svn-id: http://core.svn.wordpress.org/trunk@40444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-05-06 14:25:45 +00:00
Sergey Biryukov
e1906ab3f1 Embeds: After [31148], list correct method in WP_oEmbed::$compat_methods. 
Props LewisCowles.
Fixes #39292.
Built from https://develop.svn.wordpress.org/trunk@40026


git-svn-id: http://core.svn.wordpress.org/trunk@39963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-01-29 07:32:43 +00:00
Dominik Schilling
c40eadefb2 Embeds: Realign the provider list after [38693]. 
See #38003.
Built from https://develop.svn.wordpress.org/trunk@38923


git-svn-id: http://core.svn.wordpress.org/trunk@38866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-25 20:16:56 +00:00
Dominik Schilling
b154ab767e Embeds: Add oEmbed support for User, List and Like Twitter timelines. 
Props earnjam.
Fixes #38003.
Built from https://develop.svn.wordpress.org/trunk@38693


git-svn-id: http://core.svn.wordpress.org/trunk@38636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-09-30 21:42:28 +00:00
Dominik Schilling
2e4748c544 Embeds: Add support for embedding Facebook photos of a user/page. 
See #34737.
Built from https://develop.svn.wordpress.org/trunk@38691


git-svn-id: http://core.svn.wordpress.org/trunk@38634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-09-30 20:40:28 +00:00
Sergey Biryukov
31f0fd5a54 Embeds: Escape periods in oEmbed regex. 
Props jrf.
Fixes #38187.
Built from https://develop.svn.wordpress.org/trunk@38684


git-svn-id: http://core.svn.wordpress.org/trunk@38627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-09-30 11:25:30 +00:00
Sergey Biryukov
6c2d92c19f Docs: Correct 'Since' version number for Cloudup in oembed_providers filter description. 
Props jrf.
Fixes #38188.
Built from https://develop.svn.wordpress.org/trunk@38675


git-svn-id: http://core.svn.wordpress.org/trunk@38618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-09-29 17:13:29 +00:00
John Blackbourn
94c8ca0f2e Docs: Correct various documentation around object and stdClass types. 
See #37770

Built from https://develop.svn.wordpress.org/trunk@38369


git-svn-id: http://core.svn.wordpress.org/trunk@38310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 16:49:45 +00:00
John Blackbourn
f53cc848e4 Embeds: Add a missing regex delimiter for Facebook URLs. 
See #34737

Built from https://develop.svn.wordpress.org/trunk@38368


git-svn-id: http://core.svn.wordpress.org/trunk@38309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 12:17:28 +00:00
John Blackbourn
07c31a5437 Embeds: Add support for embedding Facebook posts and videos via oEmbed. 
Fixes #34737
Props pento, GaryJ

Built from https://develop.svn.wordpress.org/trunk@38367


git-svn-id: http://core.svn.wordpress.org/trunk@38308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 11:57:30 +00:00
John Blackbourn
a71d445b80 Embeds: Many of our oEmbed providers now default to HTTPS embeds, redirect to the HTTPS oEmbed endpoint, or have complete support for HTTPS even if they don't default to HTTPS. 
This change defaults to using HTTPS endpoints for oEmbeds for those providers that have full HTTPS support and don't redirect back to HTTP when clicking through from the embed. It covers:

* Vimeo
* SmugMug
* Scribd
* WordPress.tv
* SoundCloud
* Meetup
* issuu
* Mixcloud
* TED

See #28507

Built from https://develop.svn.wordpress.org/trunk@38366


git-svn-id: http://core.svn.wordpress.org/trunk@38307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 11:25:29 +00:00
John Blackbourn
c7884d542e Embeds: Always use the HTTPS endpoint for YouTube embeds. The scheme parameter is no longer required as all YouTube assets now use HTTPS. 
See #36274, #28507
Props zsusag, tollmanz

Built from https://develop.svn.wordpress.org/trunk@38365


git-svn-id: http://core.svn.wordpress.org/trunk@38306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 10:39:32 +00:00
Scott Taylor
ff59281441 OEmbed: move _wp_oembed_get_object() to embed.php, where all of the other embed functions live. WP_oEmbed is then in a file by itself. Load class-oembed.php in wp-settings.php and remove extraneous include calls. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38361


git-svn-id: http://core.svn.wordpress.org/trunk@38302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 09:49:28 +00:00
Sergey Biryukov
822db9ce1d Embeds: Fix copy/paste error in WP_oEmbed::_add_provider_early() description. 
Props ivantedja.
Fixes #37602.
Built from https://develop.svn.wordpress.org/trunk@38230


git-svn-id: http://core.svn.wordpress.org/trunk@38171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 14:10:30 +00:00
Sergey Biryukov
d50ac5598f Embeds: In WP_oEmbed::get_provider() and WP_oEmbed::get_html(), parse the $args string to an array, as we treat it as an array later. 
See #37071.
Built from https://develop.svn.wordpress.org/trunk@37720


git-svn-id: http://core.svn.wordpress.org/trunk@37686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-15 18:52:28 +00:00
Pascal Birchler
629b43769b Embeds: Improve performance when embedding a post from the current site. 
When the post being embedded is from the same site, there's no reason to do an HTTP request for it. The data can be fetched directly using `get_oembed_response_data()`.

Fixes #36767 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37708


git-svn-id: http://core.svn.wordpress.org/trunk@37674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-15 11:23:28 +00:00
Drew Jaynes
9cb5247392 Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37518


git-svn-id: http://core.svn.wordpress.org/trunk@37486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:50:28 +00:00
Drew Jaynes
b1804afeaf Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs. 
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.

Built from https://develop.svn.wordpress.org/trunk@37431


git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 18:41:31 +00:00
Drew Jaynes
9f48d46be3 Docs: Properly mark $args parameters in two WP_oEmbed methods as optional. 
Also clarify that the `$args` parameters can accept a string (the default) in addition to an array.

Props ramiy.
See #36296.

Built from https://develop.svn.wordpress.org/trunk@37069


git-svn-id: http://core.svn.wordpress.org/trunk@37036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-23 17:08:27 +00:00
Drew Jaynes
d78762c1ef Docs: Use third-person singular verbs for summary DocBlocks in WP_oEmbed. 
Also fixes inline `@see` formatting in appropriate places (summaries should not contain tags or markdown).

Props ramiy.
See #36296.

Built from https://develop.svn.wordpress.org/trunk@37068


git-svn-id: http://core.svn.wordpress.org/trunk@37035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-23 16:58:26 +00:00