Gary Pendergast
d0c327443c
When a hyphen -
or double hyphen --
was at the start or the end of a string, it wasn't texturized correctly.
...
Fixes #31030
Built from https://develop.svn.wordpress.org/trunk@31199
git-svn-id: http://core.svn.wordpress.org/trunk@31180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 03:54:24 +00:00
Helen Hou-Sandí
798439c273
Media: Prevent filter selects from jiggling when the spinner shows.
...
props valendesigns.
fixes #30725 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31197
git-svn-id: http://core.svn.wordpress.org/trunk@31178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 03:00:23 +00:00
Scott Taylor
e760ecfb13
Make _wp_scripts_maybe_doing_it_wrong( $function )
"private".
...
Props obenland for the thought leadership.
See #20513 .
Built from https://develop.svn.wordpress.org/trunk@31196
git-svn-id: http://core.svn.wordpress.org/trunk@31177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 02:42:22 +00:00
Gary Pendergast
b74f13511a
Allow comment_post_ID
to be passed to wp_update_comment()
, so that a comment can be moved to a different post.
...
Props tyxla, rachelbaker
Fixes #30946
Built from https://develop.svn.wordpress.org/trunk@31195
git-svn-id: http://core.svn.wordpress.org/trunk@31176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 02:39:23 +00:00
Scott Taylor
9ee49b130c
After [31192], create a function, wp_styles()
, to reduce duplicated code in functions.wp-styles.php
. The style functions can reuse wp_scripts_maybe_doing_it_wrong( $function )
internally.
...
See #20513 .
Built from https://develop.svn.wordpress.org/trunk@31194
git-svn-id: http://core.svn.wordpress.org/trunk@31175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 02:31:23 +00:00
Scott Taylor
2849a791b4
In wp_print_scripts()
, bail if $handles
is false
and the $wp_scripts
global has not been instantiated.
...
See [31192], #20513 .
Built from https://develop.svn.wordpress.org/trunk@31193
git-svn-id: http://core.svn.wordpress.org/trunk@31174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 02:28:22 +00:00
Scott Taylor
74a8d68bbf
functions.wp-scripts.php
contains a lot of duplicated code. Make 2 new functions: wp_scripts()
and wp_scripts_maybe_doing_it_wrong( $function )
, to encapsulate the repeated logic.
...
Props GaryJ, scribu, wonderboymusic.
Fixes #20513 .
Built from https://develop.svn.wordpress.org/trunk@31192
git-svn-id: http://core.svn.wordpress.org/trunk@31173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 02:07:22 +00:00
Scott Taylor
378d66f038
After [31186], remove figcaption
from the list of inline elements that are autop'd in Tests_Formatting_Autop::test_that_wpautop_treats_inline_elements_as_inline()
.
...
See #29219 .
Built from https://develop.svn.wordpress.org/trunk@31191
git-svn-id: http://core.svn.wordpress.org/trunk@31172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 01:51:24 +00:00
Scott Taylor
6f8e01adf2
In WP_User
, ->get_role_caps()
and ->update_user_level_from_caps()
must be called inside ->add_cap()
and ->remove_cap()
after updating user meta. ->has_cap()
checks are currently failing directly after calling ->add_cap()
.
...
Adds unit test.
Props rachelbaker.
Fixes #28374 .
Built from https://develop.svn.wordpress.org/trunk@31190
git-svn-id: http://core.svn.wordpress.org/trunk@31171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 01:49:25 +00:00
Scott Taylor
cf6adef68f
Revert [31032], this did not get much love.
...
See #25277 .
Built from https://develop.svn.wordpress.org/trunk@31189
git-svn-id: http://core.svn.wordpress.org/trunk@31170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 01:11:23 +00:00
Scott Taylor
fe6b5983df
In PHP 5.0.0, is_a()
became deprecated in favour of the instanceof
operator. Calling is_a()
would result in an E_STRICT
warning.
...
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.
To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.
`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.
Props markoheijnen, wonderboymusic.
Fixes #25672 .
Built from https://develop.svn.wordpress.org/trunk@31188
git-svn-id: http://core.svn.wordpress.org/trunk@31169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 01:06:24 +00:00
Scott Taylor
6704875855
Replace the 3 remaining occurrences of wpspin
GIF with spinner
.
...
Props avryl.
Fixes #27482 .
Built from https://develop.svn.wordpress.org/trunk@31187
git-svn-id: http://core.svn.wordpress.org/trunk@31168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 00:33:22 +00:00
Scott Taylor
6b84df3bbd
Ensure that <figcaption>
is not autop'd.
...
Fixes #29219 .
Built from https://develop.svn.wordpress.org/trunk@31186
git-svn-id: http://core.svn.wordpress.org/trunk@31167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 00:27:21 +00:00
Andrew Ozz
3e529d6753
TinyMCE: remove the fade in/out when opening/closing native modals to match the rest of our UI. Props afercia, avryl. Fixes #27388 .
...
Built from https://develop.svn.wordpress.org/trunk@31185
git-svn-id: http://core.svn.wordpress.org/trunk@31166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-15 23:29:21 +00:00
Lance Willett
7be12f7d8d
Twenty Fifteen: move js
and no-js
class name functionality out of header template and into a wp_head
hook in functions.php file so that the JavaScript functionality isn't hard-coded into a template file.
...
Fixes #30770 , props chipbennett, valendesigns, and peterwilsoncc.
Built from https://develop.svn.wordpress.org/trunk@31184
git-svn-id: http://core.svn.wordpress.org/trunk@31165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-15 23:10:22 +00:00
Lance Willett
4d00172987
Twenty Fifteen: remove unused CSS rules for wp_page_menu
since are not used in the theme. And a bit of CSS cleanup.
...
Props iamtakashi, fixes #30957 .
Built from https://develop.svn.wordpress.org/trunk@31183
git-svn-id: http://core.svn.wordpress.org/trunk@31164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-15 23:05:22 +00:00
Lance Willett
6960d5ce12
Twenty Fifteen: remove border on post navigation when post thumbnail is available.
...
Props jartes, fixes #30918 .
Built from https://develop.svn.wordpress.org/trunk@31182
git-svn-id: http://core.svn.wordpress.org/trunk@31163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-15 23:03:26 +00:00
Helen Hou-Sandí
62a197d6bf
List tables: Use CSS :nth-child() selectors for zebra striping.
...
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.
There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.
fixes #30981 and #26060 . see #25060 .
Built from https://develop.svn.wordpress.org/trunk@31181
git-svn-id: http://core.svn.wordpress.org/trunk@31162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-14 22:14:22 +00:00
Andrew Ozz
a7dcd2d736
TinyMCE: select the iframe element by id. Needed as some browser extensions insert extra elements in the page. Props avryl, see #30785 .
...
Built from https://develop.svn.wordpress.org/trunk@31180
git-svn-id: http://core.svn.wordpress.org/trunk@31161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-14 21:33:25 +00:00
Boone Gorges
3f033dc73d
Support array values in WP_Date_Query::validate_date_values()
.
...
Introduced in [29925], `validate_date_values()` throws `_doing_it_wrong()`
notices when values passed as part of a `WP_Date_Query` do not reflect actual
dates. However, the validation did not account properly for the case where an
array of multiple values is passed, as when doing IN or BETWEEN queries.
Props dlh.
Fixes #31001 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31179
git-svn-id: http://core.svn.wordpress.org/trunk@31160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-14 16:51:24 +00:00
Jeremy Felt
8d55b418ec
Don't overcheck the expected return from get_blog_details()
in get_blogaddress_by_id()
...
If `get_blog_details()` is returning something that is not our expected object or `false`, then a notice would already be thrown there.
Also adds proper return docs to `get_blog_details()`.
Props SergeyBiryukov.
Fixes #30566
Built from https://develop.svn.wordpress.org/trunk@31178
git-svn-id: http://core.svn.wordpress.org/trunk@31159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-14 05:33:25 +00:00
Sergey Biryukov
19e51601ab
Revert [31173] and target only taxonomy and link manager tables in keyboard focus code.
...
props afercia.
fixes #30980 .
Built from https://develop.svn.wordpress.org/trunk@31177
git-svn-id: http://core.svn.wordpress.org/trunk@31158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 14:01:22 +00:00
Sergey Biryukov
c3c35cf645
Customizer: Use deep-link for Widgets in toolbar on front-end.
...
props caseypatrickdriscoll.
fixes #30971 .
Built from https://develop.svn.wordpress.org/trunk@31176
git-svn-id: http://core.svn.wordpress.org/trunk@31157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 07:45:22 +00:00
Sergey Biryukov
b2b4233b7b
Twenty Fifteen: Add print section to the table of contents in the stylesheet.
...
props iamtakashi.
fixes #30993 .
Built from https://develop.svn.wordpress.org/trunk@31175
git-svn-id: http://core.svn.wordpress.org/trunk@31156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 07:21:21 +00:00
Sergey Biryukov
68c50a9e1b
Scope attachment selectors in media views to avoid interfering with attachment pages on front-end.
...
props valendesigns.
fixes #30878 .
Built from https://develop.svn.wordpress.org/trunk@31174
git-svn-id: http://core.svn.wordpress.org/trunk@31155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 07:16:23 +00:00
Sergey Biryukov
3ac60370b8
Reveal row actions on focus on taxonomy screens.
...
props afercia.
fixes #30980 .
Built from https://develop.svn.wordpress.org/trunk@31173
git-svn-id: http://core.svn.wordpress.org/trunk@31154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 07:02:22 +00:00
Sergey Biryukov
dcaa26c1de
Add 'user_id' to the list of fields wp_update_comment() can update.
...
props jphase.
fixes #30307 .
Built from https://develop.svn.wordpress.org/trunk@31172
git-svn-id: http://core.svn.wordpress.org/trunk@31153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 06:48:22 +00:00
Sergey Biryukov
47b47c4980
Add 'comment_type' to the list of fields wp_update_comment() can update.
...
props desaiuditd.
fixes #30627 .
Built from https://develop.svn.wordpress.org/trunk@31171
git-svn-id: http://core.svn.wordpress.org/trunk@31152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 06:42:21 +00:00
Drew Jaynes
f2bc30c03f
Ensure we're using the correct @ignore
phpDocumentor tag to mark elements that should be skipped when parsing.
...
Up to this point, various core elements' DocBlocks incorrectly included an `@internal` tag as a means for skipping the parsing process. When paired with a description (inline or otherwise), `@internal` is a valid tag meant to provide internal-only context, but not necessarily to skip parsing the entire element.
See #30987 .
Built from https://develop.svn.wordpress.org/trunk@31170
git-svn-id: http://core.svn.wordpress.org/trunk@31151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 00:51:21 +00:00
Drew Jaynes
632c26d142
Remove an erroneous @internal
tag from the DocBlock for get_children()
.
...
Use of the `@internal` tag caused the reference article for this function to be skipped during the parsing process.
Fixes #30987 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31169
git-svn-id: http://core.svn.wordpress.org/trunk@31150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 00:08:22 +00:00
Scott Taylor
fc843ce4d0
There are some random add_action()
and add_filter()
calls littered around some files in wp-includes/
. These should be moved to wp-includes/default-filters.php
with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT
- a lot of the hooks registered won't run anyways (that's already the case).
...
See #30947 .
Built from https://develop.svn.wordpress.org/trunk@31168
git-svn-id: http://core.svn.wordpress.org/trunk@31149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:40:23 +00:00
Scott Taylor
b51593763a
WP_Themes_List_Table
accesses $_pagination_args
from the parent class. Switch $_pagination_args
to protected
in WP_List_Table
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31167
git-svn-id: http://core.svn.wordpress.org/trunk@31148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:26:21 +00:00
Scott Taylor
4f6de09a5b
Add a private
field to WP_Terms_List_Table
, $level
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31166
git-svn-id: http://core.svn.wordpress.org/trunk@31147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:23:22 +00:00
Scott Taylor
194932fd6b
Add a private
field to WP_Posts_List_Table
, $is_trash
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31165
git-svn-id: http://core.svn.wordpress.org/trunk@31146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:22:22 +00:00
Scott Taylor
71f9bc3f42
Add a private
field to WP_Plugin_Install_List_Table
, $error
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31164
git-svn-id: http://core.svn.wordpress.org/trunk@31145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:19:22 +00:00
Scott Taylor
91312e71cd
In lieu of refactoring, add a private
field to WP_MS_Themes_List_Table
, $has_items
. Ideally, this class would overload ->has_items()
and not set a private
field.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31163
git-svn-id: http://core.svn.wordpress.org/trunk@31144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:17:22 +00:00
Scott Taylor
86c0f63739
Add 2 private
fields to WP_Media_List_Table
, $detached
and $is_trash
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31162
git-svn-id: http://core.svn.wordpress.org/trunk@31143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:08:21 +00:00
Scott Taylor
df09597a65
After [31146], properly declare $user_can
as a private
field in WP_Comments_List_Table
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31161
git-svn-id: http://core.svn.wordpress.org/trunk@31142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:02:24 +00:00
Dion Hulse
af92025162
More concise documentation for wp_install_maybe_enable_pretty_permalinks()
...
See #6481 . Props ericlewis.
Built from https://develop.svn.wordpress.org/trunk@31160
git-svn-id: http://core.svn.wordpress.org/trunk@31141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 04:33:23 +00:00
Dion Hulse
a114d0929b
The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable.
...
See #6481 . Props nacin, valendesigns
Built from https://develop.svn.wordpress.org/trunk@31159
git-svn-id: http://core.svn.wordpress.org/trunk@31140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 04:31:23 +00:00
Jeremy Felt
8f35b191db
Use a less complex approach for enforcing path slashes in update_blog_details()
...
Ensure leading and traling slashes are in place and don't touch anything in the middle. Validating with `array_filter()` would have missed a possible valid falsy path - `/my-path/0/`.
Props nacin.
Fixes #18117 .
Built from https://develop.svn.wordpress.org/trunk@31158
git-svn-id: http://core.svn.wordpress.org/trunk@31139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 04:21:22 +00:00
Jeremy Felt
343a6587cf
Check for existence of data from get_blogaddress_by_id()
before returning a URL
...
* Prevent a notice when an invalid ID is used with `get_blogaddres_by_id()`.
* Return a falsy empty string rather than the previous "http://".
* Add unit tests for `get_blogaddress_by_id()`.
Props nerrad.
Fixes #30566 .
Built from https://develop.svn.wordpress.org/trunk@31157
git-svn-id: http://core.svn.wordpress.org/trunk@31138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 02:24:22 +00:00
Jeremy Felt
40bcb404a3
Update home
and siteurl
after path slashes are validated in update_blog_details()
...
When editing a site, if `home` and `siteurl` are checked to be updated along with a site's domain and path, they should receive the results of any modifications in `update_blog_details()` rather than trusting the POST data.
Previously, it was possible to save a value without a leading slash on the path, causing an invalid URL to be stored.
Props earnjam.
Fixes #30417 .
Built from https://develop.svn.wordpress.org/trunk@31156
git-svn-id: http://core.svn.wordpress.org/trunk@31137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 01:57:23 +00:00
Jeremy Felt
eaf7f8df74
Enforce leading and trailing slashes on paths updated with update_blog_details()
...
In multisite, core expects the stored value for a site's path to have leading and trailing slashes. When these slashes are missing, it becomes impossible to visit the site.
This enforces proper `/path/` creation in `update_blog_details()`, most likely used when updating an existing site through `site-info.php`.
Props earnjam, simonwheatley.
Fixes #18117 . Fixes #23865 .
Built from https://develop.svn.wordpress.org/trunk@31155
git-svn-id: http://core.svn.wordpress.org/trunk@31136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 01:43:22 +00:00
Gary Pendergast
34636a0e41
If get_avatar_data()
is passed an empty value for the default avatar, we should be using the site's avatar_default
option instead.
...
See #21195
Built from https://develop.svn.wordpress.org/trunk@31154
git-svn-id: http://core.svn.wordpress.org/trunk@31135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 00:23:24 +00:00
Gary Pendergast
3d051df3c9
In get_avatar_data()
, there's no need to return false
if we couldn't find an avatar, as Gravatar can handle being given an empty email hash. This allows the default avatar to show when no email address is given.
...
See #21195
Built from https://develop.svn.wordpress.org/trunk@31153
git-svn-id: http://core.svn.wordpress.org/trunk@31134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 00:20:24 +00:00
Gary Pendergast
4bc89fef32
In get_avatar()
, revert the <img>
tag attributes to using single quotes, instead of double quotes. This behaviour was changed in [31107], but caused problems for code that attempted to parse the <img>
tag.
...
See #21195
Built from https://develop.svn.wordpress.org/trunk@31152
git-svn-id: http://core.svn.wordpress.org/trunk@31133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 00:03:24 +00:00
Scott Taylor
eed3698c49
In WP_Query
, only call magic method internals again whitelists of properties and methods, $compat_fields
and $compat_methods
. Remove __unset()
since __set()
is not implemented.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31151
git-svn-id: http://core.svn.wordpress.org/trunk@31132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:41:24 +00:00
Scott Taylor
61e12e00c1
In WP_Comment_Query
, only allow __call()
to run against ->get_search_sql()
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31150
git-svn-id: http://core.svn.wordpress.org/trunk@31131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:33:24 +00:00
Scott Taylor
0e84d59de5
In wp_xmlrpc_server
, only allow __call()
to run against ->_multisite_getUsersBlogs()
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31149
git-svn-id: http://core.svn.wordpress.org/trunk@31130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:31:22 +00:00
Scott Taylor
ed4e7b01d4
In WP_oEmbed
, only allow __call()
to run against a whitelist of methods, $compat_methods
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31148
git-svn-id: http://core.svn.wordpress.org/trunk@31129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:27:23 +00:00
Scott Taylor
a4092e90f0
In WP_Roles
, only allow __call()
to run against ->_init()
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31147
git-svn-id: http://core.svn.wordpress.org/trunk@31128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:23:23 +00:00
Scott Taylor
e6fc90f973
In WP_List_Table
, only call magic method internals again whitelists of properties and methods, $compat_fields
and $compat_methods
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31146
git-svn-id: http://core.svn.wordpress.org/trunk@31127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:20:22 +00:00
Scott Taylor
2749e46178
In WP_Filesystem_Base
, make the only private
member, $cache
, public
and remove magic methods. $cache
was always public
until [28487], has been essentially public
via a magic method since.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31145
git-svn-id: http://core.svn.wordpress.org/trunk@31126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:04:22 +00:00
Scott Taylor
a79c242038
In WP_User_Query
, only call magic method internals against a whitelist of properties, $compat_fields
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31144
git-svn-id: http://core.svn.wordpress.org/trunk@31125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:00:23 +00:00
Andrew Ozz
d079899553
TinyMCE wpView: when clicking in the editor optimize the caret placement before or after a view. Props avryl, fixes #30938 .
...
Built from https://develop.svn.wordpress.org/trunk@31143
git-svn-id: http://core.svn.wordpress.org/trunk@31124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 20:42:23 +00:00
Andrew Ozz
49c0b22828
TinyMCE: fix (switch) the indent/outdent icons in RTL mode so the arrow points at the proper direction. Props avryl, fixes #21281 .
...
Built from https://develop.svn.wordpress.org/trunk@31142
git-svn-id: http://core.svn.wordpress.org/trunk@31123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 20:30:26 +00:00
Boone Gorges
77875a273e
Walker::$has_children
should be public for backward compatibility.
...
See [31137]. See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31141
git-svn-id: http://core.svn.wordpress.org/trunk@31122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 01:56:22 +00:00
Boone Gorges
5c0ddb8602
Default $parent
in category_exists()
should default to null rather than 0.
...
[29863] made the corresponding change in `term_exists()`. Failure to change the
default value in `category_exists()` meant that an unspecified value for
`$parent` would limit results to top-level categories.
Includes unit tests and corrected function documentation.
Props hissy.
Fixes #30975 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31140
git-svn-id: http://core.svn.wordpress.org/trunk@31121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 01:26:27 +00:00
Scott Taylor
c9bc1cc46e
WP_Ajax_Response
has one property only, $responses
. It was public until [28508], when it became private
in name only. Is it worth 4 magic methods to pretend that this property is private
? It is not.
...
Make it `public` and remove the magic methods.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31139
git-svn-id: http://core.svn.wordpress.org/trunk@31120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 00:13:23 +00:00
Scott Taylor
d8e5aabab5
In WP_Error
:
...
* `wp_send_json_error()` accesses `$errors` on an instance, it must be `public`
* `$error_data` is a local message cache for error codes and doesn't particularly hide info, would be the only non-public field or method in the class
Make `$errors` and `$error_data` public and remove magic methods.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31138
git-svn-id: http://core.svn.wordpress.org/trunk@31119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 00:01:22 +00:00
Scott Taylor
b962499be6
In Walker
:
...
* Every subclass of `Walker` overrides `$db_fields` and makes it public
* `wp_list_comments()` accesses `->max_pages` on an instance of `Walker`, it must be public
* `$has_children` was added as `protected` in 4.0. doesn't need BC
Make `$db_fields` and `$max_pages` public and remove magic methods.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31137
git-svn-id: http://core.svn.wordpress.org/trunk@31118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 23:44:23 +00:00
Scott Taylor
eab3aa7802
In WP_MatchesMapRegex
:
...
* Exactly one method was made private in [28516], and is only used internally.
* 2 properties were made private, but they just store variables passed to the constructor.
* Instances of this class are never created in core. `WP_MatchesMapRegex::apply()` is called statically in `WP->parse_request()` and `url_to_postid()`.
The chances that:
1) this class is used as an instance somewhere and
2) the properties that have always been marked `@access private` and begin with `_` were used publicly
...is extremely low.
Remove the magic methods, I should not have added them.
While we're at it, use the PHP5-style `__construct()` instead of the class name.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31136
git-svn-id: http://core.svn.wordpress.org/trunk@31117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 23:27:21 +00:00
Scott Taylor
65a459b34f
In WP_Text_Diff_Renderer_Table
:
...
* In [28525], `$_diff_threshold`, `$inline_diff_renderer`, and `$_show_split_view` were marked `protected`; magic methods were also added.
* The magic methods should only perform operations on a whitelisted set of properties, now specified in `$compat_fields`
* Remove `__call()`, is unnecessary and can wreak havoc on the parent class.
This class is used in one place: `wp_text_diff()`.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31135
git-svn-id: http://core.svn.wordpress.org/trunk@31116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 22:58:24 +00:00
Scott Taylor
a56d920454
In Custom_Image_Header
:
...
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` values
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 4 properties marked `private`: `$uploaded_headers`, `$default_headers`, `$page`, and `$updated` - `$page` and `$uploaded_headers` are never used and `$updated` was added by me in [30187] during 4.1. `$default_headers` does not necessarily need to be `private`
Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the `$uploaded_headers` property - it is used nowhere and is dead code.
Set `$default_headers` to `public`.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31134
git-svn-id: http://core.svn.wordpress.org/trunk@31115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 22:11:22 +00:00
Scott Taylor
61f5cc459e
In Custom_Background
:
...
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` value
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 2 properties marked `private`, `$page` and `$updated` - `$page` is never used and `$updated` was added by me in [30186] during 4.1
Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31133
git-svn-id: http://core.svn.wordpress.org/trunk@31114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:59:22 +00:00
Scott Taylor
806b2e9bae
get_post()
takes $output
as its 2nd param. The @return
annotation should reflect the function's ability to return an array.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31132
git-svn-id: http://core.svn.wordpress.org/trunk@31113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:38:23 +00:00
Scott Taylor
56d6682461
In edit-form-advanced.php
:
...
* `get_permalink( $post_ID )` can return `false`, set it to a variable and check it
* Using the variable allows us to replace 11 separate calls to `get_permalink( $post_ID )` in the file
* These notices were triggered by the potential for `false` to be passed to `esc_url()`
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31131
git-svn-id: http://core.svn.wordpress.org/trunk@31112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:21:22 +00:00
Scott Taylor
a6d6ba957b
get_header_image()
can return false
. In Custom_Image_Header->step_1()
, check the value before setting the background-image
portion of the style
attribute. Setting the the URL to empty string will cause the current request to be set as the source of the background image.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31130
git-svn-id: http://core.svn.wordpress.org/trunk@31111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:08:22 +00:00
Scott Taylor
aaae4e9df0
Since get_theme_mod()
returns false
on failure, $background_image_thumb
can be set to it and checked instead of calling get_background_image()
3 times in Custom_Background->admin_page()
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31129
git-svn-id: http://core.svn.wordpress.org/trunk@31110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 20:44:22 +00:00
Scott Taylor
2b6b7c0235
Declare $action
as a global in wp-admin/comment.php
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31128
git-svn-id: http://core.svn.wordpress.org/trunk@31109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 20:42:24 +00:00
Scott Taylor
5547115dc2
Fix some @param
docs that have chars too close them.
...
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31127
git-svn-id: http://core.svn.wordpress.org/trunk@31108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:57:22 +00:00
Scott Taylor
0a511680f4
Adding a @return
annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31126
git-svn-id: http://core.svn.wordpress.org/trunk@31107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:54:23 +00:00
Scott Taylor
da99d29a59
Adding a @return
annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31125
git-svn-id: http://core.svn.wordpress.org/trunk@31106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:13:22 +00:00
Scott Taylor
1b3f91f500
Declare $wp_version
, $required_php_version
, and $required_mysql_version
as globals in install and upgrade admin files.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31124
git-svn-id: http://core.svn.wordpress.org/trunk@31105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:57:22 +00:00
Scott Taylor
1bac6fb886
In wp-admin/includes/revision.php
, $post->modified
is a coding error. It should be $post->post_modified
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31123
git-svn-id: http://core.svn.wordpress.org/trunk@31104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:50:22 +00:00
Scott Taylor
d6ce5dd553
WP_Upgrader
will take any "skin" that is passed to it, and set ->skin
via composition. The default type of ->skin
is WP_Upgrader_Skin
, which doesn't have methods declared for ->bulk_header()
and ->bulk_footer()
. Add noop methods to WP_Upgrader_Skin
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31122
git-svn-id: http://core.svn.wordpress.org/trunk@31103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:42:22 +00:00
Scott Taylor
84867b3e9c
Admin globals:
...
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and `$post` as globals where applicable
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31121
git-svn-id: http://core.svn.wordpress.org/trunk@31102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:29:22 +00:00
Scott Taylor
ac654632fe
Use PHP_SAPI
constant instead of php_sapi_name()
in iis7_supports_permalinks()
, wp_fix_server_vars()
, and wp_redirect()
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31120
git-svn-id: http://core.svn.wordpress.org/trunk@31101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 04:59:22 +00:00
Scott Taylor
afd09f1f04
In wp_ajax_upload_attachment()
, wp_check_filetype_and_ext()
doesn't need a 3rd param - it already defaults to null
. Passing false
would fail a strict check
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31119
git-svn-id: http://core.svn.wordpress.org/trunk@31100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 04:55:25 +00:00
Andrew Ozz
3324fb71f6
TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961 .
...
Built from https://develop.svn.wordpress.org/trunk@31118
git-svn-id: http://core.svn.wordpress.org/trunk@31099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 01:32:26 +00:00
Andrew Ozz
71885dceca
Media modal: do not attempt to focus the hidden file input field added by Plupload when tabbing. Props afercia, fixes #30392 .
...
Built from https://develop.svn.wordpress.org/trunk@31117
git-svn-id: http://core.svn.wordpress.org/trunk@31098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 21:47:29 +00:00
Scott Taylor
709698a579
In Custom_Background
and Custom_Header
:
...
* In `->init()`, don't check `current_user_can()` since `add_theme_page()` will return `false` immediately if the cap check fails.
* Bail if `add_theme_page()` returns `false`
* `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already defaults to `null`. Passing `false` would fail a strict check.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31116
git-svn-id: http://core.svn.wordpress.org/trunk@31097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 21:07:22 +00:00
Scott Taylor
236d8ae9dc
After [31016], would be cool if we actually included the froogaloop
file to interact with Vimeo.
...
Props dimadin.
Fixes #29267 .
Built from https://develop.svn.wordpress.org/trunk@31115
git-svn-id: http://core.svn.wordpress.org/trunk@31096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 20:04:23 +00:00
Boone Gorges
df945fcdcb
In get_permalink()
, don't resolve to pretty permalink if post has 'future' status.
...
We already do this for other non-public statuses, to prevent leaking non-public
information about unpublished posts.
Props e.mazovetskiy, CalEvans.
Fixes #30910 .
Built from https://develop.svn.wordpress.org/trunk@31114
git-svn-id: http://core.svn.wordpress.org/trunk@31095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 16:40:22 +00:00
Sergey Biryukov
7b04e6d4f4
Add variable type for sync_category_tag_slugs() parameters.
...
props tillkruess.
fixes #30718 .
Built from https://develop.svn.wordpress.org/trunk@31113
git-svn-id: http://core.svn.wordpress.org/trunk@31094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 11:19:22 +00:00
Sergey Biryukov
2be2af7789
Avoid a PHP notice in _WP_Editors::wp_fullscreen_html() when no $post global is set.
...
props marcochiesi.
fixes #30071 .
Built from https://develop.svn.wordpress.org/trunk@31112
git-svn-id: http://core.svn.wordpress.org/trunk@31093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 10:28:23 +00:00
Sergey Biryukov
a2f9b410f8
Toolbar: Make network admin accessible via keyboard.
...
props Cheffheid.
fixes #29422 .
Built from https://develop.svn.wordpress.org/trunk@31111
git-svn-id: http://core.svn.wordpress.org/trunk@31092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 09:51:22 +00:00
Sergey Biryukov
e214fce67f
Use localized format for Last Updated date in plugin details modal, for consistency with [31055].
...
see #30717 .
Built from https://develop.svn.wordpress.org/trunk@31110
git-svn-id: http://core.svn.wordpress.org/trunk@31091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 06:21:22 +00:00
Sergey Biryukov
d5d0b367ab
Improve documentation for media_handle_upload().
...
props ericlewis.
fixes #30962 .
Built from https://develop.svn.wordpress.org/trunk@31109
git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 05:05:23 +00:00
Sergey Biryukov
e24b443f50
Correct @return value for WP_Theme::load_textdomain() after [30681].
...
see #30224 .
Built from https://develop.svn.wordpress.org/trunk@31108
git-svn-id: http://core.svn.wordpress.org/trunk@31089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 04:54:24 +00:00
Gary Pendergast
5ee3ff435d
Add get_avatar_url()
, for retrieving just the URL of an avatar, rather than the entire <img>
tag that get_avatar()
produces.
...
Unlike `get_avatar()`, `get_avatar_url()` is not pluggable. It can be extended/or modified through the new filters included.
Fixes #21195 .
Props mdawaffe, pento, pathawks, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@31107
git-svn-id: http://core.svn.wordpress.org/trunk@31088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 04:43:23 +00:00
Scott Taylor
8ee598169f
After [31105], don't ditch the isset()
calls for BC. Declare $page_hook
as null
so it is initialized for all execution paths but will still fail isset()
checks.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31106
git-svn-id: http://core.svn.wordpress.org/trunk@31087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:52:22 +00:00
Scott Taylor
60e1dd409b
Properly declare $hook_suffix
, $plugin_page
, $typenow
, and $taxnow
as globals in wp-admin/admin.php
.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31105
git-svn-id: http://core.svn.wordpress.org/trunk@31086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:15:24 +00:00
Sergey Biryukov
91297b7a30
If WP_Rewrite::flush_rules() is called on 'init' or earlier, wait until 'wp_loaded' before actually flushing the rules, to make sure all the rules registered on 'init' are included.
...
props joostdevalk.
see #30501 .
Built from https://develop.svn.wordpress.org/trunk@31104
git-svn-id: http://core.svn.wordpress.org/trunk@31085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:00:23 +00:00
Sergey Biryukov
6e29458407
Remove a redundant inline comment with a typo.
...
props nicnicnicdevos.
fixes #30956 .
Built from https://develop.svn.wordpress.org/trunk@31103
git-svn-id: http://core.svn.wordpress.org/trunk@31084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:29:24 +00:00
Sergey Biryukov
24b3ee8680
Make a hint on Edit Selection view in media modal more accurate, as it applies to all media files, not just images.
...
props pavelevap.
see #30931 .
Built from https://develop.svn.wordpress.org/trunk@31102
git-svn-id: http://core.svn.wordpress.org/trunk@31083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:24:23 +00:00
Scott Taylor
e4b6265c7a
Overriding methods should do more than simply call the same method in the super class.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31101
git-svn-id: http://core.svn.wordpress.org/trunk@31082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:20:22 +00:00
Scott Taylor
4a1ad9acec
Jump statements should not be followed by other statements (there were 5 lingering).
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31100
git-svn-id: http://core.svn.wordpress.org/trunk@31081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:15:22 +00:00
Scott Taylor
4feecb922c
Use &&
instead of and
in the 3 places where and
was used.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31099
git-svn-id: http://core.svn.wordpress.org/trunk@31080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:12:22 +00:00
Sergey Biryukov
dfac056cf1
Pass post type to count_user_posts() in get_the_author_posts().
...
props Caspie, tyxla.
fixes #30904 .
Built from https://develop.svn.wordpress.org/trunk@31098
git-svn-id: http://core.svn.wordpress.org/trunk@31079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 19:53:22 +00:00
Sergey Biryukov
ff4968ebc4
Use home_url() instead of hardcoded domain in Tests_Link_GetAdjacentPostLink.
...
props CalEvans.
fixes #30955 .
Built from https://develop.svn.wordpress.org/trunk@31097
git-svn-id: http://core.svn.wordpress.org/trunk@31078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 18:45:23 +00:00
Sergey Biryukov
e53b581817
Remove non-functional date filter from Edit Selection view in media modal.
...
props tyxla.
fixes #30931 .
Built from https://develop.svn.wordpress.org/trunk@31096
git-svn-id: http://core.svn.wordpress.org/trunk@31077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 18:23:23 +00:00
Helen Hou-Sandí
bc7cc3bb12
Collapse additional avatar settings if avatars are disabled.
...
props markjaquith, krogsgard, valendesigns.
fixes #30168 .
Built from https://develop.svn.wordpress.org/trunk@31095
git-svn-id: http://core.svn.wordpress.org/trunk@31076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 17:01:24 +00:00
Gary Pendergast
c777f6a29c
WPDB: When sanity checking a string, check that it's a string, first - PHP notices can occur if an array or object is handled like a string.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@31094
git-svn-id: http://core.svn.wordpress.org/trunk@31075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 08:45:22 +00:00
Gary Pendergast
83a229084f
WPDB: When wpdb::query()
needs to sanity check a query string, make sure to run wpdb:flush()
afterwards, to ensure the results from sanity check queries aren't mixed up with the results for the user query.
...
See #21212 .
Fixes #30948 .
Built from https://develop.svn.wordpress.org/trunk@31093
git-svn-id: http://core.svn.wordpress.org/trunk@31074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 08:32:22 +00:00
Scott Taylor
ac6fddee35
In wp_xmlrpc_server
, remove dead code.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31092
git-svn-id: http://core.svn.wordpress.org/trunk@31073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:21:22 +00:00
Scott Taylor
383a5c6c24
In wp-includes/plugin.php
, collapse 3 else-newline-tab-if
statements.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31091
git-svn-id: http://core.svn.wordpress.org/trunk@31072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:13:24 +00:00
Scott Taylor
60b0cd7943
The keyword elseif
should be used instead of else if
so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31090
git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Dion Hulse
a4ed093250
Enable Pretty Permalinks for new sites during install if the server supports it.
...
See #6481 , Props valendesigns, DrewAPicture & ericlewis
Built from https://develop.svn.wordpress.org/trunk@31089
git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:47:23 +00:00
Scott Taylor
bc4cd01190
In wp-includes/taxonomy.php
:
...
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31087
git-svn-id: http://core.svn.wordpress.org/trunk@31068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:26:23 +00:00
Scott Taylor
29cd3fa5bf
PHP keywords and constants "true", "false", "null" should be in lower case - there was one lingering capitalized false
in _http_build_query()
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31086
git-svn-id: http://core.svn.wordpress.org/trunk@31067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:14:23 +00:00
Scott Taylor
55fdfb529a
There is no need to use the final
modifier inside a final
class. Everything in it is final
by default.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31085
git-svn-id: http://core.svn.wordpress.org/trunk@31066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:10:46 +00:00
Scott Taylor
905f35f289
In Customizer classes:
...
* `public final function` methods should be `final public function` - confusing Hack and aligns with PSR2
* Some methods were missing access modifiers
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31083
git-svn-id: http://core.svn.wordpress.org/trunk@31064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:02:24 +00:00
Scott Taylor
80915aaf16
WP_Query->parse_tax_query()
- for BC, this method is not marked as protected. See [28987]. It needs an access modifier, it shall have public
. The comment remains.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31081
git-svn-id: http://core.svn.wordpress.org/trunk@31062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:54:44 +00:00
Scott Taylor
ac4e67b82e
Perl-style comments should not be used
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31079
git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:52:24 +00:00
Scott Taylor
e029005847
Access Modifiers:
...
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31078
git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:44:23 +00:00
Scott Taylor
ff98cfcf45
Pinking Shears.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31077
git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:03:23 +00:00
Sergey Biryukov
9b0e279e82
In dashboard activity widget, display a front-end link if the user cannot edit the post.
...
props UaMV, DrewAPicture.
fixes #29025 .
Built from https://develop.svn.wordpress.org/trunk@31075
git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 00:26:22 +00:00
Sergey Biryukov
f2b5ac8ef1
Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices.
...
props ocean90.
fixes #30827 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31074
git-svn-id: http://core.svn.wordpress.org/trunk@31055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:43:24 +00:00
Sergey Biryukov
f601e45055
TinyMCE: Remove dashicon-no-alt.png, unused since [30694].
...
props kpdesign, MattyRob.
fixes #30791 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31073
git-svn-id: http://core.svn.wordpress.org/trunk@31054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:32:22 +00:00
Sergey Biryukov
da4a8f56f5
Theme install: Display an appropriate string if theme has not been rated yet.
...
props kevdotbadger, valendesigns.
fixes #28147 .
Built from https://develop.svn.wordpress.org/trunk@31072
git-svn-id: http://core.svn.wordpress.org/trunk@31053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:17:22 +00:00
Sergey Biryukov
3dcd0e2119
Add context for 'Previous' and 'Next' strings in get_the_posts_pagination().
...
fixes #30762 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31071
git-svn-id: http://core.svn.wordpress.org/trunk@31052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:07:22 +00:00
Andrew Ozz
00ff6675a2
Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167 .
...
Built from https://develop.svn.wordpress.org/trunk@31070
git-svn-id: http://core.svn.wordpress.org/trunk@31051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 22:48:22 +00:00
Sergey Biryukov
23a5deba53
Customizer: Correctly display "Select" option in Navigation section dropdowns.
...
props kucrut.
fixes #30929 .
Built from https://develop.svn.wordpress.org/trunk@31069
git-svn-id: http://core.svn.wordpress.org/trunk@31050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 19:50:23 +00:00
Sergey Biryukov
833c148bb5
Dashicons: Fix typo in .dashicons-excerpt-view class.
...
props desrosj.
fixes #30832 .
Built from https://develop.svn.wordpress.org/trunk@31068
git-svn-id: http://core.svn.wordpress.org/trunk@31049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 09:02:23 +00:00
Sergey Biryukov
1c9e1836ac
Remove obsolete help sentence on Edit User screen.
...
fixes #30750 .
Built from https://develop.svn.wordpress.org/trunk@31067
git-svn-id: http://core.svn.wordpress.org/trunk@31048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 08:23:23 +00:00
Sergey Biryukov
7df3885d2e
Don't force newlines around URLs in WP_Embed::autoembed().
...
props chipx86, sgrant.
fixes #23776 .
Built from https://develop.svn.wordpress.org/trunk@31066
git-svn-id: http://core.svn.wordpress.org/trunk@31047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 07:51:22 +00:00
Sergey Biryukov
6299d3f617
Fix typo in a comment in slashing tests.
...
Built from https://develop.svn.wordpress.org/trunk@31065
git-svn-id: http://core.svn.wordpress.org/trunk@31046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 07:09:23 +00:00
Gary Pendergast
c20f6afb05
Options: When updating options, make sure the user isn't trying to insert characters that aren't supported by the database character set.
...
See #30361 .
Built from https://develop.svn.wordpress.org/trunk@31064
git-svn-id: http://core.svn.wordpress.org/trunk@31045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 04:15:23 +00:00
Drew Jaynes
727999d6fb
Add a description for the $data
parameter in the DocBlock for the customize_save_response
hook introduced in [31062].
...
Props westonruter.
Fixes #29098 .
Built from https://develop.svn.wordpress.org/trunk@31063
git-svn-id: http://core.svn.wordpress.org/trunk@31044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 01:48:24 +00:00
Dominik Schilling
56981c7143
Customizer: Send JSON success for customize_save
and allow response to be filtered.
...
props westonruter.
fixes #29098 .
Built from https://develop.svn.wordpress.org/trunk@31062
git-svn-id: http://core.svn.wordpress.org/trunk@31043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 21:47:23 +00:00
Dominik Schilling
c6e7a90331
Autoprefixer for [31038].
...
see #30886 .
Built from https://develop.svn.wordpress.org/trunk@31061
git-svn-id: http://core.svn.wordpress.org/trunk@31042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 21:44:25 +00:00
Sergey Biryukov
e253251ef4
Remove space before comma in wp_notify_postauthor() and wp_notify_moderator().
...
see #30930 .
Built from https://develop.svn.wordpress.org/trunk@31060
git-svn-id: http://core.svn.wordpress.org/trunk@31041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 17:17:21 +00:00
Sergey Biryukov
71d255fde1
Remove padding from the comment notification emails in wp_notify_moderator().
...
See [30015] for wp_notify_postauthor().
props pavelevap.
fixes #30930 .
Built from https://develop.svn.wordpress.org/trunk@31059
git-svn-id: http://core.svn.wordpress.org/trunk@31040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 17:10:35 +00:00
Sergey Biryukov
7685e9dc97
Skip building the query in wp_count_posts() if cached results are used.
...
props MikeHansenMe.
fixes #30928 .
Built from https://develop.svn.wordpress.org/trunk@31058
git-svn-id: http://core.svn.wordpress.org/trunk@31039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 16:58:26 +00:00
Sergey Biryukov
da5b68a17e
Fix 'compare' parameter description in WP_Date_Query.
...
props dlh.
fixes #30925 .
Built from https://develop.svn.wordpress.org/trunk@31057
git-svn-id: http://core.svn.wordpress.org/trunk@31038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 03:36:21 +00:00
Sergey Biryukov
c2260dc85b
Remove obsolete inline comment.
...
props travisnorthcutt.
fixes #30924 .
Built from https://develop.svn.wordpress.org/trunk@31056
git-svn-id: http://core.svn.wordpress.org/trunk@31037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 01:57:22 +00:00
Sergey Biryukov
483e7a36d7
Use localized format for Last Updated date on Add Plugins screen.
...
props tyxla.
fixes #30717 .
Built from https://develop.svn.wordpress.org/trunk@31055
git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 01:03:23 +00:00
Sergey Biryukov
291de9cac1
Themes: Fix position of admin notice with .notice class.
...
fixes #30895 .
Built from https://develop.svn.wordpress.org/trunk@31054
git-svn-id: http://core.svn.wordpress.org/trunk@31035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 20:06:23 +00:00
Sergey Biryukov
1541bc1537
Pass comment author name and comment ID to 'get_comment_author_link' filter on Edit Comment screen, for consistency with [30092].
...
props tyxla.
fixes #30894 .
Built from https://develop.svn.wordpress.org/trunk@31053
git-svn-id: http://core.svn.wordpress.org/trunk@31034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 19:10:23 +00:00
Gary Pendergast
e6a74136f9
size_format()
incorrectly included a trailing space for B
values: less than 1024 bytes.
...
Also add a unit test to check for this, so we don't do it again.
Fixes #30908 .
Props tillkruess.
Built from https://develop.svn.wordpress.org/trunk@31052
git-svn-id: http://core.svn.wordpress.org/trunk@31033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 13:13:23 +00:00
Gary Pendergast
0e806f1695
WPDB: To ensure we're not asking MySQL to read data using queries that it can't handle, make sure that we run all read queries through the character set sanity checks.
...
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@31051
git-svn-id: http://core.svn.wordpress.org/trunk@31032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 04:40:22 +00:00
Gary Pendergast
9704ee2a5c
WPDB Docs: Update the @since version from 4.1.0 to 4.2.0, for all the methods/members that were punted from 4.1.
...
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@31050
git-svn-id: http://core.svn.wordpress.org/trunk@31031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 03:51:22 +00:00
Dion Hulse
c975c8eeb0
Preinitialize WP_User::$data to an object in the event an empty user object is created. Avoids a "Creating default object from empty value" PHP Warning.
...
Fixes #28019
Built from https://develop.svn.wordpress.org/trunk@31049
git-svn-id: http://core.svn.wordpress.org/trunk@31030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 01:41:23 +00:00
Sergey Biryukov
05f1506d93
A couple more tweaks to the post-thumbnail-template.php description.
...
see #30867 .
Built from https://develop.svn.wordpress.org/trunk@31048
git-svn-id: http://core.svn.wordpress.org/trunk@31029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 23:10:21 +00:00
Boone Gorges
28c918e49c
Add tests for the 'post_status' behavior of WP_Query
.
...
See #29167 .
Built from https://develop.svn.wordpress.org/trunk@31047
git-svn-id: http://core.svn.wordpress.org/trunk@31028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 20:36:22 +00:00
Boone Gorges
26436a4374
Remove non-built-in post statuses during each unit test teardown.
...
See #29167 .
Built from https://develop.svn.wordpress.org/trunk@31046
git-svn-id: http://core.svn.wordpress.org/trunk@31027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 20:06:26 +00:00
Scott Taylor
fb454239fb
In Media Views, use this.listenTo( this.model, .... )
instead of this.model.on( .... )
to fix garbage collection and to avoid "ghost views."
...
Fixes #30896 .
Built from https://develop.svn.wordpress.org/trunk@31045
git-svn-id: http://core.svn.wordpress.org/trunk@31026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 05:25:22 +00:00
Scott Taylor
be59efcfbf
ImageMagick expects TIFF files to have .tiff
as an extension, so the key in wp_get_mime_types()
should be 'tiff|tif'
not 'tif|tiff'
so the proper extension is returned in WP_Image_Editor->get_extension()
subclass invocations.
...
Fixes #30211 .
Built from https://develop.svn.wordpress.org/trunk@31044
git-svn-id: http://core.svn.wordpress.org/trunk@31025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 03:09:22 +00:00
Scott Taylor
a9302b2e36
If IMAGE_EDIT_OVERWRITE
is defined as true
, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical).
...
Props hew.
Fixes #30394 .
Built from https://develop.svn.wordpress.org/trunk@31043
git-svn-id: http://core.svn.wordpress.org/trunk@31024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:52:24 +00:00
Scott Taylor
f79eb196df
Improve the handling of comma-separated mime-types in wp_match_mime_types()
, particularly as pertains to the mime-type selector on the Media list table screen.
...
Props mdgl.
Fixes #30788 .
Built from https://develop.svn.wordpress.org/trunk@31042
git-svn-id: http://core.svn.wordpress.org/trunk@31023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:32:22 +00:00
Scott Taylor
ada7442b9e
After [31037], ensure that the library is passed as a map to the Media Grid instance. Remove useless query vars.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31041
git-svn-id: http://core.svn.wordpress.org/trunk@31022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:07:23 +00:00
Scott Taylor
de4d970d77
Preserve alpha transparency when rotating a PNG while GD is the active image editor.
...
Adds unit tests.
Props frankpw, voldemortensen.
Fixes #30596 .
Built from https://develop.svn.wordpress.org/trunk@31040
git-svn-id: http://core.svn.wordpress.org/trunk@31021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 22:02:24 +00:00
Scott Taylor
e678f9d051
In Media Grid, don't immediately load full size images if the requested size passed to wp.media.view.Attachment.imageSize()
does not exist, look for other suitable sizes.
...
Fixes #30861 .
Built from https://develop.svn.wordpress.org/trunk@31039
git-svn-id: http://core.svn.wordpress.org/trunk@31020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 21:32:23 +00:00
Scott Taylor
a5cd4c0493
Fix spacing of .compat-item .field
form widgets in media modal.
...
Props trepmal.
Fixes #30886 .
Built from https://develop.svn.wordpress.org/trunk@31038
git-svn-id: http://core.svn.wordpress.org/trunk@31019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 20:47:23 +00:00
Scott Taylor
c5f9a7c26a
Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31037
git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 08:24:22 +00:00
Scott Taylor
f5f3006981
Remove whitespace side effects from comment_form()
.
...
Props timersys.
Fixes #30500 .
Built from https://develop.svn.wordpress.org/trunk@31036
git-svn-id: http://core.svn.wordpress.org/trunk@31017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 06:27:24 +00:00
Scott Taylor
190165cb32
Use the 'not_found'
label when there are no items for a taxonomy in the terms list table.
...
Props SergeyBiryukov.
Fixes #30586 .
Built from https://develop.svn.wordpress.org/trunk@31035
git-svn-id: http://core.svn.wordpress.org/trunk@31016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 06:20:21 +00:00
Scott Taylor
af0e5cc851
Inline <script>
s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA
comments.
...
Props tw2113 for the initial patch.
See #18788 .
Built from https://develop.svn.wordpress.org/trunk@31034
git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:46:25 +00:00
Scott Taylor
b39c37ff89
After [31030]: if a callable
is passed as the 3rd arg to wp_localize_script()/WP_Scripts->localize()
, pass $handle
and $object_name
to the user func when invoking it.
...
Props jtsternberg.
Fixes #26111 .
Built from https://develop.svn.wordpress.org/trunk@31033
git-svn-id: http://core.svn.wordpress.org/trunk@31014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:13:24 +00:00
Scott Taylor
650a6d1062
Add the ability to print data *after* a script, whether it is concatenated or not:
...
* Add a third argument to `WP_Scripts->print_extra_script()`, `$key`, which will be passed to `->get_data()` (no longer passes hardcoded `'data'`)
* When `$key` is set to `'data-after'`, the inline script will be printed after the `<script>` tag. If the scripts are being concatenated, all scripts' `'data-after'` data will be printed after the concatenated `<script>` has been rendered.
Props hakre, wonderboymusic.
Fixes #25277 .
Built from https://develop.svn.wordpress.org/trunk@31032
git-svn-id: http://core.svn.wordpress.org/trunk@31013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:08:24 +00:00
Scott Taylor
f7aef5b69a
Ensure that inline styles attached to conditional stylesheets are also conditional.
...
Adds unit test.
Props georgestephanis.
Fixes #29180 .
Built from https://develop.svn.wordpress.org/trunk@31031
git-svn-id: http://core.svn.wordpress.org/trunk@31012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 04:10:21 +00:00
Scott Taylor
e649887e40
Allow the 3rd argument to wp_localize_script()/WP_Scripts->localize()
to be a callable
, allowing data to be lazy-loaded when the script is actually enqueued.
...
Props jtsternberg.
Fixes #26111 .
Built from https://develop.svn.wordpress.org/trunk@31030
git-svn-id: http://core.svn.wordpress.org/trunk@31011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 03:54:22 +00:00
Scott Taylor
618c5b4333
When outputting JS with a Content-Type
header:
...
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.
Props sergej.mueller.
Fixes #29196 .
Built from https://develop.svn.wordpress.org/trunk@31029
git-svn-id: http://core.svn.wordpress.org/trunk@31010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 02:57:21 +00:00
Scott Taylor
2d7c3eec73
When calling wp_enqueue_script()
with a registered $handle
, no $src
(using the default value, false
), and true
as the value for $in_footer
, ensure that the script actually loads in the footer. If the handle was registered with $in_footer
equal to true
, this already worked. Make it work for scripts like where $in_footer
was initially false
, example: wp_enqueue_script( 'json2', false, array(), false, true );
...
Props SergeyBiryukov.
Fixes #14488 .
Built from https://develop.svn.wordpress.org/trunk@31028
git-svn-id: http://core.svn.wordpress.org/trunk@31009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 02:41:23 +00:00
Boone Gorges
a374f9f092
Introduce 'category_css_classes' filter.
...
Paralleling the 'page_css_classes' filter, this allows developers to modify
the list of CSS classes used when creating category list markup via
`Walker_Category`.
Props sivel.
Fixes #16497 .
Built from https://develop.svn.wordpress.org/trunk@31027
git-svn-id: http://core.svn.wordpress.org/trunk@31008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 02:31:22 +00:00
Boone Gorges
cc8f18b698
Add tests for wp_list_categories()
CSS class generation.
...
See #16497 .
Built from https://develop.svn.wordpress.org/trunk@31026
git-svn-id: http://core.svn.wordpress.org/trunk@31007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 02:23:24 +00:00
Boone Gorges
a0d1faa383
In Walker_Category
, don't generate list elements for empty cat names.
...
This change allows the 'list_cats' filter to be used to suppress certain
items in category lists, without creating invalid or superfluous markup.
Props samo9789.
Fixes #16792 .
Built from https://develop.svn.wordpress.org/trunk@31025
git-svn-id: http://core.svn.wordpress.org/trunk@31006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 02:05:22 +00:00
Boone Gorges
1b63ada83d
Introduce 'name' parameter for get_terms()
.
...
This enhancement requires a modification in the way that `wp_dropdown_categories()`
prepares its arguments for `get_terms()`, so that its unrelated 'name' param is
not mistaken for the new 'name' argument in `get_terms()`.
Props danielbachhuber.
Fixes #30611 .
Built from https://develop.svn.wordpress.org/trunk@31024
git-svn-id: http://core.svn.wordpress.org/trunk@31005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-02 21:34:23 +00:00
Andrew Ozz
e0189c3686
Move the (recently added) .notice
admin notices below the first H2, same as the .updated
and .error
notices. Props sippis, fixes #30885 .
...
Built from https://develop.svn.wordpress.org/trunk@31023
git-svn-id: http://core.svn.wordpress.org/trunk@31004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-02 18:52:23 +00:00
Andrew Ozz
fe0bf57deb
Fix the background color in the auth. check modal. Props melchoyce, fixes #30278 .
...
Built from https://develop.svn.wordpress.org/trunk@31022
git-svn-id: http://core.svn.wordpress.org/trunk@31003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-02 17:21:22 +00:00
Boone Gorges
77e635f8fe
Add tests for wp_delete_object_term_relationships()
.
...
See #30879 .
Built from https://develop.svn.wordpress.org/trunk@31021
git-svn-id: http://core.svn.wordpress.org/trunk@31002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-02 14:03:26 +00:00
Scott Taylor
aa26b4c1a0
If you set '_wp_page_template'
for a post, and then switch to a theme that doesn't support the template, subsequent calls to wp_insert_post()
will bail early without running a plethora of hooks. This shouldn't happen. We should set the template to 'default'
and continue through the rest of the function. The function will still bail if $wp_error
is true
via wp_insert_post( $arr, true )
.
...
Props nofearinc.
Fixes #25334 .
Built from https://develop.svn.wordpress.org/trunk@31020
git-svn-id: http://core.svn.wordpress.org/trunk@31001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-01 20:35:30 +00:00
Scott Taylor
5e4941023b
WP_List_Table
's constructor registers an 'admin_footer'
callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when wp_comment_reply()
invokes the class constructor without checking for the existing instance via the $wp_list_table
global.
...
We shall check the `$wp_list_table` global in `wp_comment_reply()`.
Props sorich87.
Fixes #17413 .
Built from https://develop.svn.wordpress.org/trunk@31019
git-svn-id: http://core.svn.wordpress.org/trunk@31000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-01 19:55:35 +00:00
Scott Taylor
a5593a64d3
More-specific docs for wp_embed_handler_youtube()
.
...
Fixes #30711 .
Built from https://develop.svn.wordpress.org/trunk@31018
git-svn-id: http://core.svn.wordpress.org/trunk@30999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-01 19:21:27 +00:00
Sergey Biryukov
f3ef425b11
Update license copyright year to 2015.
...
props valendesigns.
fixes #30877 .
Built from https://develop.svn.wordpress.org/trunk@31017
git-svn-id: http://core.svn.wordpress.org/trunk@30998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-01 12:25:26 +00:00
Scott Taylor
952a5c9971
Support chromeless Vimeo via MEjs:
...
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)
Fixes #29267 .
Built from https://develop.svn.wordpress.org/trunk@31016
git-svn-id: http://core.svn.wordpress.org/trunk@30997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 20:41:24 +00:00
Boone Gorges
f1a4fd6e85
Support array values for post-related parameters in WP_Comment_Query
.
...
Props nprasath002, c3mdigital, ianmjones.
Fixes #20006 .
Built from https://develop.svn.wordpress.org/trunk@31015
git-svn-id: http://core.svn.wordpress.org/trunk@30996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 19:38:22 +00:00
Boone Gorges
36f36dca77
In remove_all_filters()
, only remove callbacks that match the $priority
parameter.
...
Props GeertDD, valendesigns.
Fixes #20920 .
Built from https://develop.svn.wordpress.org/trunk@31014
git-svn-id: http://core.svn.wordpress.org/trunk@30995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 19:07:24 +00:00
Scott Taylor
586c1ac7bc
Fix docs for WP_User::allcaps
:
...
The `allcaps` property of the `WP_User` class represents all of the caps of the user, not the caps of the user's role. Introduced in [26126].
Props dlh.
Fixes #30852 .
Built from https://develop.svn.wordpress.org/trunk@31013
git-svn-id: http://core.svn.wordpress.org/trunk@30994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 18:15:23 +00:00
Scott Taylor
96558ac3c3
Update/fix inline docs for update_object_term_cache()
.
...
Props DrewAPicture.
Fixes #30731 .
Built from https://develop.svn.wordpress.org/trunk@31012
git-svn-id: http://core.svn.wordpress.org/trunk@30993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 18:12:26 +00:00
Scott Taylor
7f94333084
Correct a typo in wp-includes/post-thumbnail-template.php
.
...
Props ixkaito.
Fixes #30867 .
Built from https://develop.svn.wordpress.org/trunk@31011
git-svn-id: http://core.svn.wordpress.org/trunk@30992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 18:09:25 +00:00
Aaron Jorbin
7ea306dd9d
Set the type attribute of the buttons for logging out of all sessions to buttons
...
By not setting this attribute, the buttons default to submit and as the first
submit button on the page, it causes pressing the enter key to log you out of
all sessions. This change restores the pre 4.1 behavior where pressing enter
while focused on a form field submits the form.
props ocean90
fixes #30871 for trunk
Built from https://develop.svn.wordpress.org/trunk@31010
git-svn-id: http://core.svn.wordpress.org/trunk@30991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 17:33:24 +00:00
Boone Gorges
a170302b36
Back up and restore dropins during get_dropins()
tests.
...
This change ensures that the `get_dropins()` tests don't detect any actual
dropins that you might be running on your develop.wordpress installation.
Props valendesigns.
Fixes #30860 .
Built from https://develop.svn.wordpress.org/trunk@31009
git-svn-id: http://core.svn.wordpress.org/trunk@30990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 15:01:22 +00:00
Andrew Nacin
bc60e63518
Use correct function name in docs for get_plugin_data().
...
props eliorivero.
fixes #30699 .
Built from https://develop.svn.wordpress.org/trunk@31008
git-svn-id: http://core.svn.wordpress.org/trunk@30989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 08:08:22 +00:00
Dion Hulse
e165f2caec
Add a revision number to $wp_version for nightly update purposes. See [30411]
...
Built from https://develop.svn.wordpress.org/trunk@31007
git-svn-id: http://core.svn.wordpress.org/trunk@30988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 05:35:22 +00:00
Andrew Nacin
fc1931e7e8
Trunk is now 4.2 alpha.
...
Built from https://develop.svn.wordpress.org/trunk@30800
git-svn-id: http://core.svn.wordpress.org/trunk@30790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-10 08:44:22 +00:00
Drew Jaynes
d72fac0131
Twenty Fifteen: Replace encoded HTML entities in the file header DocBlock for header.php with 'head element'.
...
Props iamtakashi.
Fixes #30649 .
Built from https://develop.svn.wordpress.org/trunk@30798
git-svn-id: http://core.svn.wordpress.org/trunk@30788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-10 03:02:23 +00:00
Dominik Schilling
2428fce4ed
Dashicons: Update to the latest files.
...
New icons:
* .dashicons-controls-play (f522)
* .dashicons-controls-pause (f523)
* .dashicons-controls-forward (f519)
* .dashicons-controls-skipforward (f517)
* .dashicons-controls-back (f518)
* .dashicons-controls-skipback (f516)
* .dashicons-controls-repeat (f515)
* .dashicons-controls-volumeon (f521)
* .dashicons-controls-volumeoff (f520)
* .dashicons-phone (f525)
* .dashicons-building (f512)
* .dashicons-store (f513)
* .dashicons-album (f514)
* .dashicons-palmtree (f527)
* .dashicons-tickets-alt (f524)
* .dashicons-money (f526)
Updated icons:
* .dashicons-align-left (f135)
* .dashicons-align-right (f136)
* .dashicons-align-center (f134)
* .dashicons-align-none (f138)
props liljimmi, melchoyce, empireoflight.
fixes #29444 .
Built from https://develop.svn.wordpress.org/trunk@30797
git-svn-id: http://core.svn.wordpress.org/trunk@30787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-09 19:34:23 +00:00
John Blackbourn
64fb3e7175
In Twenty Fourteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised.
...
See #30641
Built from https://develop.svn.wordpress.org/trunk@30796
git-svn-id: http://core.svn.wordpress.org/trunk@30786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-09 18:57:24 +00:00
John Blackbourn
e9f7c78d38
In Twenty Thirteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised.
...
See #30641
Built from https://develop.svn.wordpress.org/trunk@30795
git-svn-id: http://core.svn.wordpress.org/trunk@30785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-09 18:56:22 +00:00
Dominik Schilling
18349e84cf
Remove a stray $ from [30793].
...
props ipm-frommen.
see #30553 .
Built from https://develop.svn.wordpress.org/trunk@30794
git-svn-id: http://core.svn.wordpress.org/trunk@30784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-09 11:27:22 +00:00
Dominik Schilling
332e0a7f82
Themes: Use Customizer deep-links inside the theme modal.
...
props DrewAPicture, ocean90.
see #25569 , #25571 .
fixes #30553 .
Built from https://develop.svn.wordpress.org/trunk@30793
git-svn-id: http://core.svn.wordpress.org/trunk@30783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 22:23:23 +00:00
Dominik Schilling
93078d7d9f
Fix JSHint error introduced in [30780].
...
see #30608 .
Built from https://develop.svn.wordpress.org/trunk@30792
git-svn-id: http://core.svn.wordpress.org/trunk@30782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 22:07:24 +00:00
Sergey Biryukov
0ef8e683f2
Revert [28948], which caused a regression.
...
see #29573 for trunk. see #28350 .
Built from https://develop.svn.wordpress.org/trunk@30791
git-svn-id: http://core.svn.wordpress.org/trunk@30781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 21:14:23 +00:00
Ian Stewart
aa9fa42f91
Twenty Fifteen: moving to a single line for tranlator comments to prevent them being missed in i18n tools.
...
Props netweb, DrewAPicture, fixes #30603 .
Built from https://develop.svn.wordpress.org/trunk@30790
git-svn-id: http://core.svn.wordpress.org/trunk@30780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 18:25:22 +00:00
Ian Stewart
3ec55886cd
Twenty Fifteen: layout correction for IE8 and IE7 after r30388 introduced a defect with the header there.
...
Props iamtakashi, fixes #30630 .
Built from https://develop.svn.wordpress.org/trunk@30789
git-svn-id: http://core.svn.wordpress.org/trunk@30779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 17:46:23 +00:00
Sergey Biryukov
b2185048c6
Move the logic from WP_Image_Editor::get_quality() to WP_Image_Editor::set_quality(), so that 'wp_editor_set_quality' and 'jpeg_quality' filters run when setting the default value.
...
props markoheijnen.
fixes #29856 .
Built from https://develop.svn.wordpress.org/trunk@30788
git-svn-id: http://core.svn.wordpress.org/trunk@30778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 16:19:23 +00:00
John Blackbourn
fbb5c1f1f5
Improve the doing_it_wrong()
text for title-tag
theme support.
...
Props ocean90
Fixes #18548
Built from https://develop.svn.wordpress.org/trunk@30787
git-svn-id: http://core.svn.wordpress.org/trunk@30777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 16:06:26 +00:00
Jeremy Felt
210b51552c
Clean up factory arguments in ms-sites group.
...
* Arguments for user, path, and title are only necessary when we need to do something with those arguments later. Most cases in the ms-sites group do not require them.
* In `test_get_blog_id_from_url_is_case_insensitive()`, we should pass a lowercase domain argument.
* A user factory in `test_switch_restore_blog()` is not necessary.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30786
git-svn-id: http://core.svn.wordpress.org/trunk@30776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 02:33:22 +00:00
Jeremy Felt
1e6c83c130
Split current tests for update_blog_status()
...
The current tests for `update_blog_status()` mirrored the tests for `update_blog_details()` in many ways and can be split in the same way. A noticeable difference is that the the matching actions fire even when no change is made to a field.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30785
git-svn-id: http://core.svn.wordpress.org/trunk@30775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 02:15:22 +00:00
Jeremy Felt
96bb2247b6
Split current tests for update_blog_details()
...
The current tests for `upload_blog_details()` were focused on the actions fired whenever a site is marked as spam, archived, deleted, or matured. This breaks those into individual sections with fewer assertions per test.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30784
git-svn-id: http://core.svn.wordpress.org/trunk@30774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 01:44:22 +00:00
Scott Taylor
a702c60e9d
Incorporate https://github.com/johndyer/mediaelement/pull/1385 into our custom build of MediaElement 2.16.2.
...
Props bradyvercher.
Fixes #30281 .
Built from https://develop.svn.wordpress.org/trunk@30783
git-svn-id: http://core.svn.wordpress.org/trunk@30773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 23:59:23 +00:00
Andrew Ozz
a445806c6f
Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337 .
...
Built from https://develop.svn.wordpress.org/trunk@30782
git-svn-id: http://core.svn.wordpress.org/trunk@30772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 23:40:24 +00:00
Andrew Ozz
7f0526ad08
Twenty Fifteen: add spaces after screen reader text strings to make them readable. Props nvwd, pavelevap, afercia. Fixes #30606 .
...
Built from https://develop.svn.wordpress.org/trunk@30781
git-svn-id: http://core.svn.wordpress.org/trunk@30771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 23:28:21 +00:00
Andrew Ozz
31990810f4
Media: ensure the toolbar is shown after leaving iframe-based content. Props mcsf, fixes #30608 .
...
Built from https://develop.svn.wordpress.org/trunk@30780
git-svn-id: http://core.svn.wordpress.org/trunk@30770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 21:12:21 +00:00
Drew Jaynes
24090d065a
Fix formatting in the DocBlock for wp_get_sidebars_widgets()
.
...
See #30315 .
Built from https://develop.svn.wordpress.org/trunk@30779
git-svn-id: http://core.svn.wordpress.org/trunk@30769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:15:26 +00:00
Drew Jaynes
16e46b2a1e
Flesh out and fix formatting in the DocBlock for wp_register_widget_control()
.
...
Includes:
* Added todos for documenting `$options` in the hash notation style
* Backtick-escaping and general formatting
See #30315 .
Built from https://develop.svn.wordpress.org/trunk@30778
git-svn-id: http://core.svn.wordpress.org/trunk@30768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:13:23 +00:00
Scott Taylor
845e8ab23d
When using the spacebar to select something in "bulk select" mode, don't scroll the page.
...
Props avryl.
Fixes #30622 .
Built from https://develop.svn.wordpress.org/trunk@30777
git-svn-id: http://core.svn.wordpress.org/trunk@30767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:11:43 +00:00
Drew Jaynes
cc4d102260
Flesh out information in the DocBlock for wp_register_sidebar_widget()
.
...
Includes:
* Documenting the `$options` parameter in hash notation style
* Converting `@uses` tags to `@global`
* Various backtick-escaping.
See #30315 .
Built from https://develop.svn.wordpress.org/trunk@30776
git-svn-id: http://core.svn.wordpress.org/trunk@30766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:11:22 +00:00
Andrew Ozz
498c5d719c
TinyMCE: return focus to the editor after closing the image toolbar. Props afercia, see #27642 .
...
Built from https://develop.svn.wordpress.org/trunk@30775
git-svn-id: http://core.svn.wordpress.org/trunk@30765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:08:42 +00:00
Drew Jaynes
1f8f2e5ba1
Introduce documentation for three methods in WP_Widget_Factory
: register()
, unregister()
, _register_widgets()
.
...
See #30315 .
Built from https://develop.svn.wordpress.org/trunk@30774
git-svn-id: http://core.svn.wordpress.org/trunk@30764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:08:21 +00:00
Drew Jaynes
25a65d856b
Introduce documentation for the $id_base
, $name
, $widget_options
, $control_options
, $number
, $id
, and $updated
properties in `WP_Widget'.
...
See #30315 .
Built from https://develop.svn.wordpress.org/trunk@30773
git-svn-id: http://core.svn.wordpress.org/trunk@30763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 20:05:22 +00:00
Drew Jaynes
ced94748fa
Tweak formatting in the DocBlock for the install_themes_tabs
hook.
...
Props kpdesign.
See #28578 .
Built from https://develop.svn.wordpress.org/trunk@30772
git-svn-id: http://core.svn.wordpress.org/trunk@30762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 18:41:21 +00:00
Boone Gorges
7e69e5484f
In WP_Query::get_queried_object()
, use the new format for referencing tax query clauses.
...
`queried_terms`, rather than `queries`, is the tax_query property where a flat
index of terms is stored.
See [29901] for a similar fix in `redirect_canonical()`. See #29738 .
Props dd32.
Fixes #30623 .
Built from https://develop.svn.wordpress.org/trunk@30771
git-svn-id: http://core.svn.wordpress.org/trunk@30761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 14:58:22 +00:00
Drew Jaynes
8b83a73511
Document the default arguments for the_widget()
in the hash notation style.
...
Props coffee2code.
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30770
git-svn-id: http://core.svn.wordpress.org/trunk@30760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 11:04:23 +00:00
Drew Jaynes
2a9c5910c6
Document the default arguments for register_sidebars()
in the hash notation style.
...
Props coffee2code.
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30769
git-svn-id: http://core.svn.wordpress.org/trunk@30759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 11:01:25 +00:00
Drew Jaynes
7c01a454ce
Improve inline documentation for wpdb::has_cap()
.
...
Adds a changelog entry for the addition of the 'utf8mb4' feature, accepted values for `$db_cap`, and a return description.
Props kpdesign.
See #21212 .
Built from https://develop.svn.wordpress.org/trunk@30768
git-svn-id: http://core.svn.wordpress.org/trunk@30758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 05:23:22 +00:00
Drew Jaynes
0cbaa88027
Fix a typo in the DocBlock for WP_Http_Curl::$bytes_written_total
introduced in [29968].
...
Props kpdesign.
See #26726 .
Built from https://develop.svn.wordpress.org/trunk@30767
git-svn-id: http://core.svn.wordpress.org/trunk@30757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 05:16:24 +00:00
Dion Hulse
e0ac8c0386
In the links_add_base()
callback, use a HTTP-aware URL joining function, rather than a filesystem joining function to avoid PHP warnings on certain systems.
...
Fixes #29950
Built from https://develop.svn.wordpress.org/trunk@30766
git-svn-id: http://core.svn.wordpress.org/trunk@30756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 03:19:23 +00:00
Dion Hulse
26b85eb9b3
WP_HTTP: Revert r30491 which updated the bundled root certificates. There's a report that this is breaking under certain PHP/OpenSSL versions (which we've encountered before), and we're safer with a slighty out of date CA bundle than breaking HTTPS communication on affected sites.
...
See #30434
Built from https://develop.svn.wordpress.org/trunk@30765
git-svn-id: http://core.svn.wordpress.org/trunk@30755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 03:13:22 +00:00
Andrew Ozz
1e9f5755aa
Admin toolbar: remove unneeded overrides of z-index
and left
on screens narrower than 782px. Props avryl, babbardel. Fixes #29867 .
...
Built from https://develop.svn.wordpress.org/trunk@30764
git-svn-id: http://core.svn.wordpress.org/trunk@30754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 03:01:24 +00:00
Andrew Ozz
adf4f440f5
Twenty Fifteen: clean up of twentyfifteen_color_scheme_css_template()
in customizer.php. Props iamtakashi. Fixes #30601 .
...
Built from https://develop.svn.wordpress.org/trunk@30763
git-svn-id: http://core.svn.wordpress.org/trunk@30753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 02:40:21 +00:00
Andrew Ozz
ef0501e1bc
Better docs for Plugin_Upgrader::deactivate_plugin_before_upgrade()
. Props DrewAPicture. Fixes #29088 .
...
Built from https://develop.svn.wordpress.org/trunk@30762
git-svn-id: http://core.svn.wordpress.org/trunk@30752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 01:19:24 +00:00
Andrew Ozz
1bb4b6a82b
Always return a value in Plugin_Upgrader::deactivate_plugin_before_upgrade()
. Props jdgrimes. Fixes #29088 .
...
Built from https://develop.svn.wordpress.org/trunk@30761
git-svn-id: http://core.svn.wordpress.org/trunk@30751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:53:23 +00:00
Andrew Ozz
53d22ffb10
Customizer - Widgets: add feedback for screen readers when moving up or down. Props adamsilverstein, afercia. Fixes #28892 .
...
Built from https://develop.svn.wordpress.org/trunk@30760
git-svn-id: http://core.svn.wordpress.org/trunk@30750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:45:24 +00:00
Drew Jaynes
337dfe7111
Restore missing line in DocBlock for WP_Tax_Query::get_sql_for_clause()
.
...
Props kpdesign.
See [30622], #30469 .
Built from https://develop.svn.wordpress.org/trunk@30759
git-svn-id: http://core.svn.wordpress.org/trunk@30749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:39:24 +00:00
Drew Jaynes
473ebca2af
Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader
, Plugin_Upgrader
, Theme_Upgrader
, Language_Pack_Upgrader
, Core_Upgrader
, and File_upload_Upgrader
.
...
Props jdgrimes, DrewAPicture.
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@30758
git-svn-id: http://core.svn.wordpress.org/trunk@30748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:26:22 +00:00
Andrew Ozz
efe8fd4694
TinyMCE, improve accessibility:
...
- Return focus to the editor on pressing Escape while the image toolbar is focused.
- Add a Close button to the Help modal and close it on Escape.
- Override the title on the editor iframe (read by screen reader apps), replace with the Alt+Shift+H shortcut.
- Add focus shortcuts descriptions to the Help modal.
Fixes #27642 .
Built from https://develop.svn.wordpress.org/trunk@30757
git-svn-id: http://core.svn.wordpress.org/trunk@30747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 23:53:22 +00:00
Drew Jaynes
bb27a3c53a
Add a blank line preceding a Markdown-formatted ordered list in the DocBlock for the admin_body_class
filter.
...
Props kpdesign.
See #30558 .
Built from https://develop.svn.wordpress.org/trunk@30756
git-svn-id: http://core.svn.wordpress.org/trunk@30746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 23:21:24 +00:00
Drew Jaynes
cc4ac906dc
Fix a typo in the return description for get_sample_permalink()
.
...
Props TobiasBg.
Fixes #30591 .
Built from https://develop.svn.wordpress.org/trunk@30755
git-svn-id: http://core.svn.wordpress.org/trunk@30745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:46:23 +00:00
John Blackbourn
bdd00b3902
Improve various hook and filter docs so they are correctly parsed for the code reference.
...
Fixes #30558
Props DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30754
git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:32:24 +00:00
Drew Jaynes
23707b1ada
Convert various uses of (optional)
in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP.
...
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.
Props coffee2code.
Fixes #30591 .
Built from https://develop.svn.wordpress.org/trunk@30753
git-svn-id: http://core.svn.wordpress.org/trunk@30743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:24:45 +00:00
Mark Jaquith
14b0899e57
Revert [28719] and no longer math-process multiplication of negative numbers
...
see #19308
fixes #30445
props rmccue
Built from https://develop.svn.wordpress.org/trunk@30752
git-svn-id: http://core.svn.wordpress.org/trunk@30742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:24:23 +00:00
Boone Gorges
bc35a81482
Remove <code>
tags from translatable string in WP_Date_Query
.
...
This was missed in [30300]. See #25834 .
Props ramiy.
Fixes #30612 .
Built from https://develop.svn.wordpress.org/trunk@30751
git-svn-id: http://core.svn.wordpress.org/trunk@30741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 02:38:22 +00:00
Boone Gorges
44116d4b72
Use wp_checkdate()
when checking date validity in WP_Date_Query
.
...
See #25834 .
Built from https://develop.svn.wordpress.org/trunk@30750
git-svn-id: http://core.svn.wordpress.org/trunk@30740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 02:29:24 +00:00
Andrew Ozz
79eb593440
Editor DFW v2: fade out the Screen Options/Help tabs when open. Props avryl, fixes #30593 .
...
Built from https://develop.svn.wordpress.org/trunk@30749
git-svn-id: http://core.svn.wordpress.org/trunk@30739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 00:50:22 +00:00
Andrew Ozz
91b8617f29
TinyMCE: manually fire ExecCommand
when aligning images as we do preventDefault()
on BeforeExecCommand
for them. Props avryl, fixes #30565 .
...
Built from https://develop.svn.wordpress.org/trunk@30748
git-svn-id: http://core.svn.wordpress.org/trunk@30738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 00:33:24 +00:00
Andrew Ozz
3826c2de6a
Themes screen: fix the position of the search field. Props jesin, fixes #29556 .
...
Built from https://develop.svn.wordpress.org/trunk@30747
git-svn-id: http://core.svn.wordpress.org/trunk@30737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 00:13:23 +00:00
Andrew Ozz
1ce44564aa
Twenty Twelve: menu on touch devices: fix jQuery selector for menu items with submenus. props babbardel, fixes #24767 .
...
Built from https://develop.svn.wordpress.org/trunk@30746
git-svn-id: http://core.svn.wordpress.org/trunk@30736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 22:59:23 +00:00
Drew Jaynes
0c7e70604d
Document the default arguments for register_sidebar()
in the hash notation style.
...
Props coffee2code.
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30745
git-svn-id: http://core.svn.wordpress.org/trunk@30735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 03:38:22 +00:00
Drew Jaynes
13dab23d23
Add missing documentation for the xmlrpc_element_limit
hook in wp-includes/class-IXR.php.
...
Props ankitgadertcampcom, kpdesign.
Fixes #29977 .
Built from https://develop.svn.wordpress.org/trunk@30744
git-svn-id: http://core.svn.wordpress.org/trunk@30734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 03:28:22 +00:00
Andrew Ozz
0a199ff4a8
Editor: fix initial state for editor-expand when TinyMCE is disabled or not supported. Props avryl, fixes #30592 .
...
Built from https://develop.svn.wordpress.org/trunk@30743
git-svn-id: http://core.svn.wordpress.org/trunk@30733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 01:53:22 +00:00
Andrew Nacin
1cf7a49ffd
Adjust [29806] and revert [29807] to restore placeholder and email copy order.
...
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.
fixes #21089 .
Built from https://develop.svn.wordpress.org/trunk@30742
git-svn-id: http://core.svn.wordpress.org/trunk@30732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 01:15:26 +00:00
Ian Stewart
a83fdf7b17
Twenty Fifteen: updating customizer label text for more clarity.
...
Props iamtakashi, fixes #30545 .
Built from https://develop.svn.wordpress.org/trunk@30741
git-svn-id: http://core.svn.wordpress.org/trunk@30731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 22:57:22 +00:00
Helen Hou-Sandí
f5efcf295b
Filter bar: Better field display on smaller screens.
...
props TacoVerdo, jesin.
fixes #29556 and #29495 .
Built from https://develop.svn.wordpress.org/trunk@30740
git-svn-id: http://core.svn.wordpress.org/trunk@30730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 22:23:25 +00:00
John Blackbourn
543f408098
Correct the default value of the show_split_view
argument for revisions so they are correctly displayed side by side ins
...
tead of inline.
Fixes #24908
Built from https://develop.svn.wordpress.org/trunk@30739
git-svn-id: http://core.svn.wordpress.org/trunk@30729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 14:36:24 +00:00
Scott Taylor
097e4ede58
Add some inline JS docs for Customizer.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30738
git-svn-id: http://core.svn.wordpress.org/trunk@30728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 02:04:22 +00:00
Scott Taylor
82188f74aa
Show title, album, and artist info for audio files displayed in WP_Customize_Upload_Control()
.
...
See #21483 .
Built from https://develop.svn.wordpress.org/trunk@30737
git-svn-id: http://core.svn.wordpress.org/trunk@30727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 01:59:22 +00:00
Scott Taylor
8b1b1a10ed
Monkey-patch MediaElement to restore H264 support to Chromium.
...
Documented here:
https://core.trac.wordpress.org/ticket/30281#comment:9
See #30281 .
Built from https://develop.svn.wordpress.org/trunk@30736
git-svn-id: http://core.svn.wordpress.org/trunk@30726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 00:59:23 +00:00
Scott Taylor
48620242c4
Give up on making uninterrupted hierarchies work in get_page_children()
for now, reverts [30159], [30246], [30636].
...
Props boonebgorges.
See #14477 .
Built from https://develop.svn.wordpress.org/trunk@30735
git-svn-id: http://core.svn.wordpress.org/trunk@30725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 00:24:22 +00:00
Andrew Ozz
1bb20da03b
Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557 .
...
Built from https://develop.svn.wordpress.org/trunk@30734
git-svn-id: http://core.svn.wordpress.org/trunk@30724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 22:00:29 +00:00
Andrew Ozz
f1385e4031
TinyMCE: remove <address>
from the block formats drop-down. Props avryl, mor10. Fixes #30132 .
...
Built from https://develop.svn.wordpress.org/trunk@30733
git-svn-id: http://core.svn.wordpress.org/trunk@30723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 20:31:24 +00:00
Ian Stewart
f5697a4d62
Twenty Fifteen: updating one point oh version number in .pot.
...
Props ocean90, see #30502 .
Built from https://develop.svn.wordpress.org/trunk@30732
git-svn-id: http://core.svn.wordpress.org/trunk@30722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:32:22 +00:00
Ian Stewart
771c7e1954
Twenty Fifteen: updating everything to one point oh.
...
See #30502 .
Built from https://develop.svn.wordpress.org/trunk@30731
git-svn-id: http://core.svn.wordpress.org/trunk@30721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:24:24 +00:00
Andrew Ozz
5299e95360
Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30730
git-svn-id: http://core.svn.wordpress.org/trunk@30720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:18:23 +00:00
Ian Stewart
b6ddf3ab5d
Twenty Fifteen: It's about time we call it one point oh.
...
Closes #30502 .
Built from https://develop.svn.wordpress.org/trunk@30729
git-svn-id: http://core.svn.wordpress.org/trunk@30719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:08:23 +00:00
Ian Stewart
20ea28b289
Twenty Fifteen: removing unused styles.
...
Props iamtakashi, fixes #30578 .
Built from https://develop.svn.wordpress.org/trunk@30728
git-svn-id: http://core.svn.wordpress.org/trunk@30718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:03:23 +00:00
Sergey Biryukov
1f64435284
Fix a typo in [30546].
...
see #30473 .
Built from https://develop.svn.wordpress.org/trunk@30727
git-svn-id: http://core.svn.wordpress.org/trunk@30717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 13:55:24 +00:00
Drew Jaynes
ad1ecf88c5
Only backtick-escape individual HTML entities in the DocBlock for wp_kses_normalize_entities()
.
...
Props TobiasBg.
Fixes #30473 .
Built from https://develop.svn.wordpress.org/trunk@30726
git-svn-id: http://core.svn.wordpress.org/trunk@30716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 11:47:23 +00:00
Drew Jaynes
ad1f226c35
Improve formatting of inline documentation for get_pages()
.
...
Adds missing default values, corrects several argument types, backtick-escapes argument names used in descriptions.
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30725
git-svn-id: http://core.svn.wordpress.org/trunk@30715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 10:31:23 +00:00
Drew Jaynes
27297bcddf
Use the correct hash notation syntax for the wp_insert_term()
DocBlock.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30724
git-svn-id: http://core.svn.wordpress.org/trunk@30714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 10:17:24 +00:00
Drew Jaynes
68ed7af808
Use the correct hash notation syntax for the get_pages()
DocBlock.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30723
git-svn-id: http://core.svn.wordpress.org/trunk@30713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 10:16:23 +00:00
Drew Jaynes
8df7115760
Use the correct hash notation syntax for the WP_Filesystem_Base::dirlist()
DocBlock.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30722
git-svn-id: http://core.svn.wordpress.org/trunk@30712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 10:11:22 +00:00
Drew Jaynes
3d77f9a816
Remove some now-unnecessary double quotes around HTML entities used in DocBlock comments.
...
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30721
git-svn-id: http://core.svn.wordpress.org/trunk@30711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 08:49:23 +00:00
Drew Jaynes
8e5543da53
Backtick-escape three sets of HTML entities used in DocBlock descriptions in wp-includes/kses.php.
...
Without the escaping, the Code Reference/browser may inadvertently attempt to convert and display entities.
Fixes #30473 .
Built from https://develop.svn.wordpress.org/trunk@30720
git-svn-id: http://core.svn.wordpress.org/trunk@30710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 08:47:22 +00:00
Jeremy Felt
31fa5cd4bc
Split tests for get_blog_id_from_url()
...
Breaks the many assertions for `get_blog_id_from_url()` into individual tests.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30719
git-svn-id: http://core.svn.wordpress.org/trunk@30709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 05:52:23 +00:00
Andrew Ozz
04c2e80c03
Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557 .
...
Built from https://develop.svn.wordpress.org/trunk@30718
git-svn-id: http://core.svn.wordpress.org/trunk@30708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 23:23:23 +00:00
Andrew Ozz
71d0c1c977
Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30717
git-svn-id: http://core.svn.wordpress.org/trunk@30707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 23:11:24 +00:00
Dominik Schilling
858a51273a
Customizer: Move private helper functions to wp.customize.utils
so they can be unit tested.
...
Includes unit tests.
props ryankienstra, westonruter.
see #28709 .
Built from https://develop.svn.wordpress.org/trunk@30716
git-svn-id: http://core.svn.wordpress.org/trunk@30706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:56:45 +00:00
Jeremy Felt
2c25a4947f
Split and improve multisite tests for upload quota
...
Break a single test with many assertions into many tests with single assertions.
In the process, provide separate and comprehensive tests for `upload_is_user_over_quota()`, `is_upload_space_available()`, and `get_space_allowed()`.
Also removes a check for `BLOGSUPLOADDIR`, a constant that never existed. New tests will need to be introduced to handle the ms-files group.
See #30080
Built from https://develop.svn.wordpress.org/trunk@30715
git-svn-id: http://core.svn.wordpress.org/trunk@30705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:56:22 +00:00
Dominik Schilling
0826f8ede2
Customizer: Add panel/section type as CSS class to the HTML container.
...
see #28709 .
Built from https://develop.svn.wordpress.org/trunk@30714
git-svn-id: http://core.svn.wordpress.org/trunk@30704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:16:23 +00:00
Dominik Schilling
c2d9591122
Toolbar: Make Customize support classes work on narrow viewports too.
...
fixes #30571 .
Built from https://develop.svn.wordpress.org/trunk@30713
git-svn-id: http://core.svn.wordpress.org/trunk@30703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:01:26 +00:00
Dominik Schilling
3db8b08686
Customizer: Enhance Background Image/Upload controls.
...
* Adopt the Header Image layout to the Background Image/Upload control.
* Remove templates for interactive audio/video previews. They haven't worked yet.
* Don't show a "Remove" button when the default value is set.
* Avoid calculating of container/placeholder heights which are unrelated to custom headers.
see #21483 .
Built from https://develop.svn.wordpress.org/trunk@30712
git-svn-id: http://core.svn.wordpress.org/trunk@30702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 21:55:23 +00:00
Andrew Ozz
f1dcfa9712
Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568 .
...
Built from https://develop.svn.wordpress.org/trunk@30711
git-svn-id: http://core.svn.wordpress.org/trunk@30701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 20:40:22 +00:00
Andrew Ozz
ab2c480d86
Editor, DFW v2: use a 2D transform to force repaint of the admin toolbar, only on #wp-toolbar
. Fixes calculating the position of the right sidebar on fade-in and removes any performance and stacking implications.
...
Props joemcgill, see #30516 .
Built from https://develop.svn.wordpress.org/trunk@30710
git-svn-id: http://core.svn.wordpress.org/trunk@30700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 20:25:24 +00:00
Ian Stewart
1cb6721c81
Twenty Fifteen: removing unused styles inherited from Twenty Fourteen.
...
Props iamtakashi, fixes #30572 .
Built from https://develop.svn.wordpress.org/trunk@30709
git-svn-id: http://core.svn.wordpress.org/trunk@30699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 16:05:22 +00:00
John Blackbourn
d58c44dc00
Apply a no-op CSS transformation to the admin toolbar (among other elements) in order to trigger hardware acceleration when focus/DFW deactivates. This helps prevent rendering issues seen in browsers on Retina devices.
...
See #30516
Props joemcgill
Built from https://develop.svn.wordpress.org/trunk@30708
git-svn-id: http://core.svn.wordpress.org/trunk@30698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 14:18:27 +00:00
John Blackbourn
e96e165c3a
Prevent scrolling beneath modals on mobile devices by removing overflow from #wpwrap
when a modal is open.
...
Fixes #29909
Props avryl
Built from https://develop.svn.wordpress.org/trunk@30707
git-svn-id: http://core.svn.wordpress.org/trunk@30697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 08:09:25 +00:00
John Blackbourn
a5fa87325b
Don't fix the position of the admin toolbar submenus when the viewport is below 600px. This avoids them becoming detached from the admin toolbar when scrolling.
...
Fixes #29905
Props avryl
Built from https://develop.svn.wordpress.org/trunk@30706
git-svn-id: http://core.svn.wordpress.org/trunk@30696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 06:49:22 +00:00
John Blackbourn
9b9424aa77
Admin help text changes for the General Settings screen, post editing screen, network settings screen, and user editing screen.
...
Fixes #30547
Props kpdesign
Built from https://develop.svn.wordpress.org/trunk@30705
git-svn-id: http://core.svn.wordpress.org/trunk@30695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 05:15:23 +00:00
Gary Pendergast
6501c3c217
Unit Tests: The test_set_allowed_incompatible_sql_mode()
test tries to set the NO_ZERO_DATE
sql mode, which was removed in MySQL 5.7. This causes the test to incorrectly fail when run against MySQL 5.7.
...
Built from https://develop.svn.wordpress.org/trunk@30704
git-svn-id: http://core.svn.wordpress.org/trunk@30694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 05:12:23 +00:00
Drew Jaynes
c4b9da857a
Using let's properly in inline comments lets us move on to more pressing matters of inline documentation.
...
Props trepmal.
Fixes #30570 .
Built from https://develop.svn.wordpress.org/trunk@30703
git-svn-id: http://core.svn.wordpress.org/trunk@30693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 04:43:22 +00:00
John Blackbourn
511489d7e4
Update the tests for get_metadata()
to reflect the revert in r30701.
...
See #15030
Built from https://develop.svn.wordpress.org/trunk@30702
git-svn-id: http://core.svn.wordpress.org/trunk@30692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 03:44:23 +00:00
John Blackbourn
d28823df33
Revert r30115 which was a breaking change for code which interacts with the return value of get_metadata()
when no meta key is specified.
...
See #15030
Built from https://develop.svn.wordpress.org/trunk@30701
git-svn-id: http://core.svn.wordpress.org/trunk@30691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 03:35:22 +00:00
John Blackbourn
6f3414ea67
Correct the width of the background vignette in the plugin info modal.
...
Fixes #28229
Built from https://develop.svn.wordpress.org/trunk@30700
git-svn-id: http://core.svn.wordpress.org/trunk@30690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 03:19:22 +00:00
Gary Pendergast
de6d84935f
WPDB: When looking up the character set for a table or column, make sure we send the table name to MySQL in the correct case, as MySQL can be configured with case sensitive table names.
...
Fixes #30538 .
Built from https://develop.svn.wordpress.org/trunk@30699
git-svn-id: http://core.svn.wordpress.org/trunk@30689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 03:00:23 +00:00
Helen Hou-Sandí
cb5c43df83
Don't over-target buttons in the publish meta box.
...
This selector caused breakage for any custom buttons added.
props ericlewis.
fixes #30035 .
Built from https://develop.svn.wordpress.org/trunk@30698
git-svn-id: http://core.svn.wordpress.org/trunk@30688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 02:35:28 +00:00
John Blackbourn
6fcf4ed3c5
Prevent the deletion of a theme while it has an active child theme.
...
Fixes #29580
Props karpstrucking, jesin
Built from https://develop.svn.wordpress.org/trunk@30697
git-svn-id: http://core.svn.wordpress.org/trunk@30687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 02:21:24 +00:00
John Blackbourn
b0a2416040
Ensure the theme and plugin update checks are always in sync with the current theme and plugin versions before fetching cached update data. This change only triggers a request to the update API when necessary.
...
Fixes #13071
Props bswatson
Built from https://develop.svn.wordpress.org/trunk@30696
git-svn-id: http://core.svn.wordpress.org/trunk@30686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 01:52:23 +00:00
Drew Jaynes
ad297dab6d
Correctly capitalize JavaScript throughout core docs.
...
Fixes #30569 .
Built from https://develop.svn.wordpress.org/trunk@30695
git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 00:31:22 +00:00
Andrew Ozz
d16c8cf1fc
TinyMCE: update the wpView toolbar to look the same as the new image toolbar.
...
Fixes #30561 .
Built from https://develop.svn.wordpress.org/trunk@30694
git-svn-id: http://core.svn.wordpress.org/trunk@30684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 00:26:22 +00:00
Andrew Ozz
16e54ae8c0
Editor DFW v2: do not fade out on using keyboard shortcuts in TinyMCE (Alt+Shift+letter).
...
Fixes #30539 .
Built from https://develop.svn.wordpress.org/trunk@30693
git-svn-id: http://core.svn.wordpress.org/trunk@30683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 22:53:24 +00:00
Ian Stewart
c9c02be354
Twenty Fifteen: correct stylesheet dependencies.
...
Props ocean90, fixes #30532 .
Built from https://develop.svn.wordpress.org/trunk@30692
git-svn-id: http://core.svn.wordpress.org/trunk@30682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 19:41:22 +00:00
Drew Jaynes
4bdf9961d4
Improve inline documentation for four methods in WP_Widget
: get_field_id()
, display_callback()
, update_callback()
, and form_callback()
.
...
Props jazzs3quence for the initial patch.
See #30315 .
Built from https://develop.svn.wordpress.org/trunk@30691
git-svn-id: http://core.svn.wordpress.org/trunk@30681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 19:35:25 +00:00
Ian Stewart
4c86797ba7
Twenty Fifteen: broader selection of avatars that should catch any plugins adding avatars that use the avatar class.
...
Props iamtakashi, fixes #30541 .
Built from https://develop.svn.wordpress.org/trunk@30690
git-svn-id: http://core.svn.wordpress.org/trunk@30680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 19:34:22 +00:00
Ian Stewart
20d135f3b2
Twenty Fifteen: correct list indentation inside blockquotes.
...
Props iamtakashi, fixes #30543 .
Built from https://develop.svn.wordpress.org/trunk@30689
git-svn-id: http://core.svn.wordpress.org/trunk@30679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 19:31:24 +00:00
Boone Gorges
9c047d48ab
Use assertEqualSetsWithIndex()
as appropriate in get_terms()
tests.
...
See #30522 .
Built from https://develop.svn.wordpress.org/trunk@30688
git-svn-id: http://core.svn.wordpress.org/trunk@30678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 14:25:23 +00:00
Gary Pendergast
e1e546c330
Unit Tests: The assertEqualSets()
helper was returning true for some sets that were not equal. assertEqualSets()
now behaves correctly, and the new assertEqualSetsWithIndex()
helper also checks that the array indexes are the same.
...
Fixes #30522 .
Built from https://develop.svn.wordpress.org/trunk@30687
git-svn-id: http://core.svn.wordpress.org/trunk@30677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 05:02:23 +00:00