Commit Graph

11809 Commits

Author SHA1 Message Date
Andrew Ozz
dcb9622465 Customize: Do not attempt to count uncountable value.
Props dlh.
Merges [43480] to the 4.9 branch.
Fixes #44104.
Built from https://develop.svn.wordpress.org/branches/4.9@43481


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 14:40:23 +00:00
Sergey Biryukov
29dfd13361 Privacy: Rename username_or_email_to_export POST variable on Erase Personal Data screen to a more generic username_or_email_for_privacy_request.
Props ianbelanger, allendav.
Merges [43478] to the 4.9 branch.
Fixes #44181.
Built from https://develop.svn.wordpress.org/branches/4.9@43479


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 14:18:27 +00:00
Andrew Ozz
42a2dc2f7a Privacy: Add filter for the subject of the erasure complete notification emails.
Props desrosj.
Merges [43475] to the 4.9 branch.
Fixes #44265.


Built from https://develop.svn.wordpress.org/branches/4.9@43476


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 13:44:25 +00:00
Andrew Ozz
249407985c TinyMCE: do not force-load external plugins, not needed any more and may cause issues.
Merges [43337] to the 4.9 branch.
Fixes #44330.
Built from https://develop.svn.wordpress.org/branches/4.9@43474


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 10:09:24 +00:00
Andrew Ozz
fa393c7fdc Privacy: Fix tests after [43467].
Merges [43471] to the 4.9. branch.
See #44141.

Built from https://develop.svn.wordpress.org/branches/4.9@43473


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 10:07:25 +00:00
Andrew Ozz
6547731cfe TinyMCE: update to 4.8.0, changelog: https://www.tiny.cloud/docs/changelog/#version480july112018
Merges [43447] to the 4.9 branch.
Fixes #44134.
Built from https://develop.svn.wordpress.org/branches/4.9@43472


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 10:04:26 +00:00
Andrew Ozz
eeef639639 Privacy: Add a setting to disable comment cookie consent.
Merges [43469] to the 4.9 branch.
Fixes #44373.
Built from https://develop.svn.wordpress.org/branches/4.9@43470


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 09:30:25 +00:00
Andrew Ozz
672ccbbc3c Privacy: Don't replace comment author URL and email with anything.
Props TZ-Media, desrosj, birgire.
Merges [43467] to the 4.9 branch.
Fixes #44141.
Built from https://develop.svn.wordpress.org/branches/4.9@43468


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-17 09:04:28 +00:00
Sergey Biryukov
c0903e830b Posts, Post Types: Add a new add_inline_data action which allows extra fields to be added to the inline editing fields.
Props mensmaximus, NathanAtmoz.
Merges [42676] and [43460] to the 4.9 branch.
Fixes #36085.
Built from https://develop.svn.wordpress.org/branches/4.9@43461


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 15:34:25 +00:00
Sergey Biryukov
cb2625e260 Privacy: Use consistent values for the site name and URL used in notification emails.
The functions `send_confirmation_on_profile_email()`, `_wp_privacy_send_request_confirmation_notification()`, `_wp_privacy_send_erasure_fulfillment_notification()`, and `wp_send_user_request()` all include a title and URL indicating the current site. However, so far they have dealt with those values inconsistently, sometimes using the site values, other times using the network values if in a multisite. This changeset ensures that only the current site is taken into account in all cases and that special characters in the site name are consistently decoded.

Props subrataemfluence, desrosj.
Merges [43388], [43390], and [43435] to the 4.9 branch.
Fixes #44396.
Built from https://develop.svn.wordpress.org/branches/4.9@43459


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 14:24:26 +00:00
Sergey Biryukov
d2342e75d0 Login and Registration: Set a better default value for $wp_error parameter in login_header().
To prevent someone from passing a string (which would not be added to a new `WP_Error` instance), check for `is_wp_error()` explicitly.

Props desrosj, chetan200891, spyderbytes, lbenicio, sebastien@thivinfo.com, abdullahramzan.
Merges [43457] to the 4.9 branch.
Fixes #44052.
Built from https://develop.svn.wordpress.org/branches/4.9@43458


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 14:14:27 +00:00
Sergey Biryukov
665b28aad0 Privacy: use wp_login_url() for the link in the user confirmation email.
Props desrosj, usmankhalid.
Merges [43379] to the 4.9 branch.
Fixes #44353.
Built from https://develop.svn.wordpress.org/branches/4.9@43456


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 13:54:26 +00:00
Sergey Biryukov
30b402c24b Privacy: append (Draft) to draft page titles in the page drop-down on the Privacy Settings screen.
Props allendav, desrosj.
Merges [43376] and [43454] to the 4.9 branch.
Fixes #44100.
Built from https://develop.svn.wordpress.org/branches/4.9@43455


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 13:52:26 +00:00
Sergey Biryukov
8040b247a4 Privacy: on the Privacy Settings screen change view to preview when a draft page is selected for the privacy policy.
Props garrett-eclipse, desrosj.
Merges [43374] to the 4.9 branch.
Fixes #44131.
Built from https://develop.svn.wordpress.org/branches/4.9@43453


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 13:30:26 +00:00
Sergey Biryukov
14a11fc4db Privacy: Change @since entry for user_request_confirmed_email_subject filter added in [43373] to 4.9.8.
Merges [43451] to the 4.9 branch.
Fixes #44382.
Built from https://develop.svn.wordpress.org/branches/4.9@43452


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 13:24:27 +00:00
Sergey Biryukov
8f33283493 Privacy: add user request type to the admin notification email subject.
Merges [43375] to the 4.9 branch.
Props birgire, desrosj.
Fixes #44099.
Built from https://develop.svn.wordpress.org/branches/4.9@43450


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 12:09:26 +00:00
Sergey Biryukov
9ad59101ab Privacy: do not show the comment cookies opt-in checkbox (on the front-end comments form) when comment cookies are disabled.
Props felipeelia, johnbillion.
Merges [43370] to the 4.9 branch.
Fixes #44342.
Built from https://develop.svn.wordpress.org/branches/4.9@43449


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 12:07:25 +00:00
Sergey Biryukov
b74a18dc8b Privacy: Silence is golden and invisible.
"Be more discrete." declared matt in [3155], and since then, "Silence is Golden" has been the calling card of placeholder index files. Historically, these have been php files, but [43012] changed that and added index.html files for privacy export generated folders.

The php silence files produce no visible content. This adds consistency with these new html files in that there will be no visible content. Silence will fall when the question is asked.

Merges [43446] to the 4.9 branch.
Fixes #44195.
Props audrasjb, rafsuntaskin, Ov3rfly, johnbillion, pento
Built from https://develop.svn.wordpress.org/branches/4.9@43448


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-16 12:02:29 +00:00
Gary Pendergast
595cd450eb REST API: Filter responses based on the _fields parameter, before data is processed.
Historically, the REST API would generate the entire response object, including running expensive filters, then it would apply the `_fields` parameter, discarding the fields that weren't specificed.

This change causes `_fields` to be applied earlier, so that only requested fields are processed.

Merges [43087] to the 4.9 branch.

Props danielbachhuber.
See #43874.


Built from https://develop.svn.wordpress.org/branches/4.9@43445


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-13 06:51:27 +00:00
Gary Pendergast
cb0ea9d291 Emoji: Update Twemoji to version 11.0.
🦹

Backport of [43377] to the 4.9 branch.

Props kraftbj,
Fixes #44339.


Built from https://develop.svn.wordpress.org/branches/4.9@43444


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-13 06:37:26 +00:00
Gary Pendergast
547a500699 REST API: Tweak permission checks for taxonomy and term endpoints
To match behaviour in the Classic Editor, we need to slightly loosen permissions on taxonomy and term endpoints. This allows users to create terms to assign to a post that they're editing.

Merges [43440] to the 4.9 branch.

Props danielbachhuber.
Fixes #44096.


Built from https://develop.svn.wordpress.org/branches/4.9@43443


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-13 06:29:25 +00:00
Gary Pendergast
d802d709c7 REST API: Expose revision count and last revision ID on Post response
So that REST API clients can show appropriate UI for a post's revisions, it needs to know how many revisions the post has, and what the latest revision ID is.

Merge of [43439] and [43441] to the 4.9 branch.

Props kadamwhite, danielbachhuber, birgire, TimothyBlynJacobs, pento.
Fixes #44321.


Built from https://develop.svn.wordpress.org/branches/4.9@43442


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-13 06:14:25 +00:00
Gary Pendergast
26f6aeaeea REST API: Declare user capabilities using JSON Hyper Schema's "targetSchema".
There are a variety of operations a WordPress user can only perform if they have the correct capabilities. A REST API client should only display UI for one of these operations if the WordPress user can perform the operation.

Rather than requiring REST API clients to calculate whether to display UI based on potentially complicated combinations of user capabilities, `targetSchema` allows us to expose a single flag to show whether the corresponding UI should be displayed.

This change also includes flags on post objects for the following actions:

- `action-publish`: The current user can publish this post.
- `action-sticky`: The current user can make this post sticky, and the post type supports sticking.
- `action-assign-author': The current user can change the author on this post.
- `action-assign-{$taxonomy}`: The current user can assign terms from the "$taxonomy" taxonomy to this post.
- `action-create-{$taxonomy}`: The current user can create terms int the "$taxonomy" taxonomy.

Merges [43437] to the 4.9 branch.

Props TimothyBlynJacobs, danielbachhuber.
Fixes #44287.


Built from https://develop.svn.wordpress.org/branches/4.9@43438


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-11 09:21:29 +00:00
Aaron Campbell
cf8c4fa0d8 Bump 4.9 branch to version 4.9.7
Built from https://develop.svn.wordpress.org/branches/4.9@43407


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 16:05:26 +00:00
John Blackbourn
b564da95fb Media: Limit thumbnail file deletions to the same directory as the original file.
Built from https://develop.svn.wordpress.org/branches/4.9@43393


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-07-05 14:45:31 +00:00
Andrew Ozz
b4aaf4a73c Privacy: add esc_html to assertion in test_wp_comments_personal_data_exporter.
Props mermel, 1naveengiri.
Merges [43371] to the 4.9 branch.
Fixes #44113.
Built from https://develop.svn.wordpress.org/branches/4.9@43372


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:40:47 +00:00
John Blackbourn
1f5f8129de Security: Harden the random aspect of the hash used for user profile and admin email address changes.
Props BjornW

Fixes #43771

Merges [43367] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@43368


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:39:07 +00:00
John Blackbourn
15054d8a94 Options, Meta APIs: Use the correct escaping function when outputting the meta box context.
Props khaihong, abdullahramzan, leanderiversen, aryamaaru, lbenicio, palmiak

Fixes #44274

Merges [43365] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@43366


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:38:18 +00:00
Sergey Biryukov
cd2f52dda1 Privacy: Make sure wp_add_privacy_policy_content() does not cause a fatal error by unintentionally flushing rewrite rules outside of the admin context.
Add a `_doing_it_wrong()` message describing the correct usage of the function.

Props kraftbj, azaozz, SergeyBiryukov, YuriV.
Merges [43361], [43362], [43363] to the 4.9 branch.
Fixes #44142.
Built from https://develop.svn.wordpress.org/branches/4.9@43364


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:37:26 +00:00
Sergey Biryukov
ea7c189825 Privacy: Only link to menus panel in Customizer if selected privacy page can be accessed there.
Props dlh.
Merges [43343] to the 4.9 branch.
Fixes #44117.
Built from https://develop.svn.wordpress.org/branches/4.9@43358


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:34:55 +00:00
Sergey Biryukov
567d4b0961 Community Events Dashboard: Always show a WordCamp if one is coming up.
WordCamps are celebrations of the local WordPress Community and once a local one is scheduled, people in that community should know it is coming. This adjusts the WordPress Events in the dashboard widgets to always display a WordCamp, even if there are multiple Meetups happening first.

Props iandunn, metalandcoffee, warmlaundry, alejandroxlopez, jorbin.
Merges [42726], [42728], and [43356] to the 4.9 branch.
Fixes #41112.
Built from https://develop.svn.wordpress.org/branches/4.9@43357


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:34:30 +00:00
Sergey Biryukov
e2bf0ae498 Privacy: Remove unnecessary This email has been sent to ###EMAIL### from privacy emails.
The line was copied from the emails that get sent when an email address changes, without considering if it made sense in the new context.

Props iandunn, ianbelanger, desrosj.
Merges [43353] to the 4.9 branch.
Fixes #44030.
Built from https://develop.svn.wordpress.org/branches/4.9@43354


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:33:14 +00:00
Sergey Biryukov
eaf96830ce Privacy: Fix typo in default privacy policy text.
Props garetharnold, abdullahramzan.
Merges [43350] to the 4.9 branch.
Fixes #44166.
Built from https://develop.svn.wordpress.org/branches/4.9@43351


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:31:57 +00:00
Sergey Biryukov
1bb5174584 Posts, Post Types: Clear post password cookie when logging out.
Props skoldin, subrataemfluence, ianbelanger, johnbillion.
Merges [43317] and [43318] to the 4.9 branch.
Fixes #44089.
Built from https://develop.svn.wordpress.org/branches/4.9@43349


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:31:05 +00:00
Sergey Biryukov
ddc8032efd Users: In wp_validate_user_request_key(), properly return the WP_Error object in case the confirmation email has expired.
Props itowhid06.
Merges [43331] to the 4.9 branch.
Fixes #44298.
Built from https://develop.svn.wordpress.org/branches/4.9@43342


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:28:08 +00:00
John Blackbourn
d668b72f5b Build/Test Tools: Allow the unit test framework to be used without the data directory in place.
Fixes #43982

Merges [43315] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@43316


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-25 22:48:28 +00:00
Boone Gorges
30b40c8f52 Taxonomy: Improve cache handling when querying for terms using all_with_object_id.
When a term query using `fields=all_with_object_id` hits the cache, the
cached `stdClass` objects must be converted to `WP_Term` objects. This
was overlooked when `WP_Term_Query` was refactored to support object
queries in [38667].

Merges [43313] to the 4.9 branch.

Props dlh.
Fixes #44221.

Built from https://develop.svn.wordpress.org/branches/4.9@43314


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-25 01:26:29 +00:00
Sergey Biryukov
5129da3af5 Docs: Document the cookies default comment field added in [42772].
Props desrosj, chetan200891.
Merges [43304] to the 4.9 branch.
See #44125.
Built from https://develop.svn.wordpress.org/branches/4.9@43306


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-21 13:17:25 +00:00
Sergey Biryukov
98eb869d8b Docs: Add missing documentation and duplicate hook references for wp_privacy_personal_data_export_file, wp_privacy_personal_data_exporters, and wp_privacy_personal_data_erasers hooks.
Props birgire.
Merges [43303] to the 4.9 branch.
See #44125.
Built from https://develop.svn.wordpress.org/branches/4.9@43305


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-21 13:16:25 +00:00
Sergey Biryukov
f1773beb0c Widgets: Allow basic inline tags in wp_sidebar_description().
The customizer has allowed HTML in sidebar descriptions since adding support for sidebars. This change ensures that basic HTML is also allowed for them in the widgets admin screen.

Props flixos90.
Merges [43275] to the 4.9 branch.
Fixes #42608.
Built from https://develop.svn.wordpress.org/branches/4.9@43302


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-21 12:43:27 +00:00
Sergey Biryukov
e782caa1e7 Comments: Escape permalink values on edit screen to prevent XSS.
There doesn't appear to be any way for an attacker to introduce malicious input into the URL, unless a plugin is filtering the URL to add it, but it's better to be safe than sorry.

Props 1naveengiri, joyously.
Merges [43290] to the 4.9 branch.
Fixes #44115.
Built from https://develop.svn.wordpress.org/branches/4.9@43301


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-21 12:40:26 +00:00
Sergey Biryukov
4d9aadc80c Privacy: Correct the error check when creating an export folder in wp_privacy_generate_personal_data_export_file().
`wp_mkdir_p()` returns `false` on error, not a `WP_Error` object.

Props birgire.
Merges [43299] to the 4.9 branch.
Fixes #44158.
Built from https://develop.svn.wordpress.org/branches/4.9@43300


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-21 12:02:29 +00:00
Dominik Schilling
09734c5576 Branch 4.9 is now 4.9.7-alpha.
Built from https://develop.svn.wordpress.org/branches/4.9@43298


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-17 19:57:27 +00:00
iandunn
0afda3e678 Bump 4.9 branch to version 4.9.5.
Built from https://develop.svn.wordpress.org/branches/4.9@43296


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-17 18:56:26 +00:00
iandunn
05d3ae380d Bundled Themes: Bump version numbers and update changelogs for 4.9.6 release
Also, updates POT files for Twenty Ten and Twenty Eleven.

Props earnjam, laurelfulford.
Merges [43293] to the 4.9 branch.
Fixes #43915.

Built from https://develop.svn.wordpress.org/branches/4.9@43295


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-17 18:27:27 +00:00
iandunn
d097213a7b Bundled Themes: Add link to privacy policy page in footer.
If a privacy policy has been set, then a link to it will automatically be shown in the footer.

The element containing the "Proudly powered by WordPress" link was chosen for the new policy link, in order to minimize visual conflicts with custom CSS that was written before the new link existed. Unfortunately, some minor conflicts are expected and unavoidable. Adding this link is required as part of GDPR compliance, and the benefits outweigh the downsides. 

To further mitigate the conflicts, a new imprint class was added to the "Proudly powered..." link, in order to facilitate targeting each link invididually with custom styles.

This was accidentally not backported to the `4.9` branch before the beta/RC phase, but there was a consensus that it is safe to do that this late in the release cycle. 
See https://wordpress.slack.com/archives/C02RQBWTW/p1526577643000132.
See https://wordpress.slack.com/archives/C02RQBWTW/p1526580781000240.

Props xkon, laurelfulford, birgire, azaozz, iandunn.
Merges [43051] to the 4.9 branch.
See #43715.

Built from https://develop.svn.wordpress.org/branches/4.9@43294


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-17 18:21:26 +00:00
iandunn
bed757a726 Post WordPress 4.9.6 RC 2 version bump.
Built from https://develop.svn.wordpress.org/branches/4.9@43289


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 21:29:26 +00:00
iandunn
68c6632f86 WordPress 4.9.6 RC 2.
Built from https://develop.svn.wordpress.org/branches/4.9@43288


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 21:20:27 +00:00
iandunn
4bfee774d5 Privacy: Require manage_privacy_options to edit policy page.
A user is required to have the `manage_privacy_options` capability in order to determine which page is set as the privacy policy (the `wp_page_for_privacy_policy`). Given that, it doesn't make sense to allow users without that capability to edit or delete the page. 

A similar situation exists with the `page_for_posts` and `page_on_front` options, but Editors are allowed to edit those pages. The reason that this situation is different is because it is more likely that an administrator will want to restrict modifications to the privacy policy, than it is that they will want to allow modifications. Modifications to the policy often require specialized knowledge of local laws, and can have implications for compliance with those laws.

Props dlh, desrosj.
Merges [43286] to the 4.9 branch.
Fixes #44079.

Built from https://develop.svn.wordpress.org/branches/4.9@43287


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 20:59:25 +00:00
Andrew Ozz
f4a436c522 Privacy: Rename exports folder to avoid deleting other files.
Previously, personal data exports were stored in `wp-content/uploads/exports`, which is generic enough that it's likely there are existing folders with that name, either created by plugins or manually by administrators. If that folder were reused by Core, then `wp_privacy_delete_old_export_files()` would delete all of the existing files inside it, which is almost certainly not what the site owner wants or expects.

To avoid that, the folder is being renamed to include a specific reference to Core, and a more verbose description of its purpose. With those factored in, it's very unlikely that there will be any conflicts with existing folders.

The `wp_privacy_exports_dir()` and `wp_privacy_exports_url()` functions were introduced to provide a canonical source for the location, and the `wp_privacy_exports_dir` and `wp_privacy_exports_url` filters were introduced to allow plugins to customize it.

Props johnjamesjacoby, allendav.
Merges [43284] to the 4.9 branch.
Fixes #44091.
Built from https://develop.svn.wordpress.org/branches/4.9@43285


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 20:32:26 +00:00
Andrew Ozz
2062f3f891 Privacy: use the more compatible word-break: break-all;, see [43278].
Merges [43282] to the 4.9 branch.
See #44092.
Built from https://develop.svn.wordpress.org/branches/4.9@43283


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 20:09:26 +00:00
Andrew Ozz
d78a4944a2 Privacy: fix styling of the "next steps" buttons on the Export/Erase tools screens when text is long.
Props audrasjb, ianbelanger.
Merges [43278] to the 4.9 branch.
Fixes #44092.
Built from https://develop.svn.wordpress.org/branches/4.9@43281


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 19:45:27 +00:00
Andrew Ozz
3e4f800ee3 Privacy: fix styling of the Privacy Settings buttons on mobile/small screens.
Props ianbelanger, azaozz.
Merges [43279] to the 4.9 branch.
Fixes #44093.
Built from https://develop.svn.wordpress.org/branches/4.9@43280


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 19:43:28 +00:00
iandunn
d1007dd45c Privacy: require manage_privacy_options capability for showing WP_Privacy_Policy_Content::notice().
Props ocean90.
Merges [43248] to the 4.9 branch.
Fixes #44055.

Built from https://develop.svn.wordpress.org/branches/4.9@43277


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 18:04:25 +00:00
Andrew Ozz
61322a844a Privacy: Reposition log in policy link to avoid overlapping elements.
Previously, the link used absolute positioning, in order to stick it at the bottom of the page. That was done in order to create visual separation between it and the "action" links, like "Lost Your Password?"

The absolute positioning can cause conflicts in some situations, though. For example, if extra text or error notices are added above the form, then the login link would be positioned on top of other elements.

Switching to relative positioning with extra margins avoids those issues, while maintaining the visual separation between the "action" links and the privacy policy link.

Props imath, melchoyce, desrosj, xkon, iandunn.
Merges [43274] to the 4.9 branch.
Fixes #44046.
Built from https://develop.svn.wordpress.org/branches/4.9@43276


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 16:55:46 +00:00
Sergey Biryukov
09fe564f4e Privacy: only remove the "Suggested text has changed" bubble when an admin visits the Privacy Policy Guide screen.
Props azaozz.
Merges [43269] to the 4.9 branch.
Fixes #44063.
Built from https://develop.svn.wordpress.org/branches/4.9@43273


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 15:52:25 +00:00
Sergey Biryukov
9438733d24 Privacy: automatically create a Privacy Policy page when installing WordPress.
Props fclaussen, azaozz.
Merges [42981], [42982], [43243] to the 4.9 branch.
Fixes #43491.
Built from https://develop.svn.wordpress.org/branches/4.9@43272


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 15:30:26 +00:00
Sergey Biryukov
10c9d391a8 Privacy: fix Export and Erase Personal Data list-tables on small screens.
Props ianbelanger, subrataemfluence, desrosj.
Merges [43251] to the 4.9 branch.
Fixes #44026.
Built from https://develop.svn.wordpress.org/branches/4.9@43271


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 15:10:25 +00:00
Andrew Ozz
9b3e2b76b4 Privacy: Escape comment URLs in personal export file to prevent XSS.
There doesn't appear to be any way for an attacker to introduce malicious input into the URL, unless a plugin is filtering the URL to add it, but it's better to be safe than sorry.

Props birgire.
Merges [43245] to the 4.9 branch.
Fixes #44054.
Built from https://develop.svn.wordpress.org/branches/4.9@43270


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-15 14:08:29 +00:00
Andrew Ozz
0ffa2fc49b Privacy: add wp_page_for_privacy_policy to populate_options().
Props ocean90.
Merges [43267] to the 4.9 branch.
Fixes #44076.
Built from https://develop.svn.wordpress.org/branches/4.9@43268


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 17:02:26 +00:00
Andrew Ozz
ca52f0f101 Privacy: fix markup for the table of contents on privacy policy guide screen.
Props ocean90, azaozz.
Merges [43265] to the 4.9 branch.
Fixes #44056.
Built from https://develop.svn.wordpress.org/branches/4.9@43266


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 16:48:27 +00:00
Andrew Ozz
77d526e000 Privacy: fix the "Privacy Policy Guide updated" message and add a link to the guide.
Props birgire, azaozz.
Merges [43263] to the 4.9 branch.
Fixes #44057.
Built from https://develop.svn.wordpress.org/branches/4.9@43264


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 16:25:28 +00:00
Dominik Schilling
70eb518623 Privacy: Remove is-dismissible class from notice when privacy info has changed.
The notice isn't dismissible as it only gets removed once you visit the privacy guide, see #44057 and #44063.

Merge of [43260] to the 4.9 branch.

See #44065.
Built from https://develop.svn.wordpress.org/branches/4.9@43262


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 16:08:26 +00:00
Dominik Schilling
7c30cc3c92 Privacy: Don't show privacy feature pointer to new users.
Merge of [43259] to the 4.9 branch.

See #44062.
Built from https://develop.svn.wordpress.org/branches/4.9@43260


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 15:53:26 +00:00
Andrew Ozz
b82ed28add Privacy: improve inline documentation.
Props desrosj.
Merges [43256] to the 4.9 branch.
Fixes #44075.
Built from https://develop.svn.wordpress.org/branches/4.9@43257


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 15:12:25 +00:00
Sergey Biryukov
6e76869056 Privacy: exclude the wrapper from the default policy content.
Props azaozz.
Merges [43242] to the 4.9 branch.
Fixes #44048.
Built from https://develop.svn.wordpress.org/branches/4.9@43255


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 14:07:24 +00:00
Sergey Biryukov
eb592352b5 Privacy: fix two typos in WP_Privacy_Policy_Content::get_default_content().
Props dlh.
Merges [43249] to the 4.9 branch.
Fixes #44050.
Built from https://develop.svn.wordpress.org/branches/4.9@43254


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 14:03:25 +00:00
Sergey Biryukov
b475d439b3 Privacy: Reposition pointer to ensure dismiss link is always visible.
r43158 introduced a new admin pointer for the privacy tools added in 4.9.6. With the previous positioning, though, sometimes the `Dismiss` link would be fixed off screen, making it impossible for the user to dismiss the pointer. This happened when there were enough extra menu items, or when the viewport height was short enough.

This commit repositions the pointer to work around that problem. One down side of this workaround is that the arrow will not always be positioned next to the `Tools` menu, where it should be. That's an acceptable compromise given the current time constraints, though. A long term solution would be to make `WP_Pointer` robust enough to handle this use case.

Props imath, audrasjb, desrosj.
Merges [43246] to the 4.9 branch.
Fixes #44045.
Built from https://develop.svn.wordpress.org/branches/4.9@43253


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 14:00:26 +00:00
Sergey Biryukov
4d5c5e90dd Privacy: define $title and $parent_file in privacy.php. Fixes showing the proper document title.
Props ocean90.
Merges [43250] to the 4.9 branch.
Fixes #44064.
Built from https://develop.svn.wordpress.org/branches/4.9@43252


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-14 13:54:24 +00:00
iandunn
39dcb61452 Post WordPress 4.9.6 RC 1 version bump.
Built from https://develop.svn.wordpress.org/branches/4.9@43241


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 22:34:26 +00:00
iandunn
b244bafda0 WordPress 4.9.6 RC 1.
Built from https://develop.svn.wordpress.org/branches/4.9@43240


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 22:18:25 +00:00
Sergey Biryukov
1600aef2ab Privacy: On Privacy Settings screen, check if any pages exist before displaying the page selector.
Props abdullahramzan, desrosj, melchoyce.
Merges [43238] to the 4.9 branch.
Fixes #43940.
Built from https://develop.svn.wordpress.org/branches/4.9@43239


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 21:41:26 +00:00
Sergey Biryukov
843c263881 Privacy: Expose erasure notification recipient to filter callbacks.
The previous `user_email` value was redundant, because it always matched `$request_data->email`. That value might be different from where the message is sent, though, if `the user_erasure_fulfillment_email_to` filter is used. If they are different, then callbacks for the `user_confirmed_action_email_content` filter may want to distinguish between the email address of the user making the request, and the email address that the confirmation notification is being sent to.

Props desrosj, iandunn.
Merges [43236] to the 4.9 branch.
See #43973.
Built from https://develop.svn.wordpress.org/branches/4.9@43237


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 21:22:26 +00:00
Sergey Biryukov
8c9bb731ed Privacy: Normalize file paths in wp_privacy_generate_personal_data_export_file() to make sure Windows paths don't have their backslashes stripped.
Props xkon, pmbaldha.
Merges [43234] to the 4.9 branch.
Fixes #43908.
Built from https://develop.svn.wordpress.org/branches/4.9@43235


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 21:13:27 +00:00
Sergey Biryukov
faf5abc16e Privacy: Update request confirmation notice text for clarity.
Props desrosj, melchoyce, garrett-eclipse.
Merges [43232] to the 4.9 branch.
Fixes #43970.
Built from https://develop.svn.wordpress.org/branches/4.9@43233


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 21:05:26 +00:00
Sergey Biryukov
ad8efe232e Privacy: Send an email notification to the user once their personal data erasure request is fulfilled.
Props desrosj, allendav, garrett-eclipse.
Merges [43230] to the 4.9 branch.
Fixes #43973.
Built from https://develop.svn.wordpress.org/branches/4.9@43231


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 20:44:25 +00:00
Sergey Biryukov
2c2db8337f Privacy: Avoid a PHP notice in wp_ajax_wp_privacy_erase_personal_data(), make sure $eraser_key is always defined.
Props allendav.
Merges [43228] to the 4.9 branch.
Fixes #44040.
Built from https://develop.svn.wordpress.org/branches/4.9@43229


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 20:25:25 +00:00
Sergey Biryukov
cc1c032638 General: Skip test_is_countable_ResourceBundle() on PHP 5.3 and below.
`ResourceBundle` is only countable in PHP 5.4+, which can be considered an acceptable edge case for WordPress core purposes.

Props jrf, ayeshrajans.
Merges [43226] to the 4.9 branch.
Fixes #43583.
Built from https://develop.svn.wordpress.org/branches/4.9@43227


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 20:17:26 +00:00
Andrew Ozz
f149d8fabc Privacy: Replace intrusive policy update notice with menu bubbles.
Previously, when a plugin updated its suggested privacy policy text, an admin notice was shown on all screens in the Administration Panels. That was done in order to make sure that administrators were aware of it, so that they could update their policy if needed. That was a very heavy-handed and intrusive approach, though, which leads to a poor user experience, and notice fatigue.

An alternative approach is to use bubble notifications in the menu, similar to when plugins have updates that need to be installed. That still makes it obvious that something needs the administrator's attention, but is not as distracting as a notice.

The notice will still appear on the Privacy page, though, since it is relevant to that screen, and provides an explanation of why the bubble is appearing.

Props azaozz, xkon, iandunn.
Merges [43223] to the 4.9 branch.
Fixes #43954. See #43953.
Built from https://develop.svn.wordpress.org/branches/4.9@43225


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 20:08:26 +00:00
Andrew Ozz
8e660e35d1 TinyMCE: switch off concatenation when a custom TinyMCE theme is used. Prevents conflict with the default theme as it loads first.
Props programmin, azaozz.
Merges [43222] to the 4.9 branch.
Fixes #43969.
Built from https://develop.svn.wordpress.org/branches/4.9@43224


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 19:54:25 +00:00
Sergey Biryukov
faca308a47 General: In the is_countable() polyfill, if the provided object implements SimpleXMLElement or ResourceBundle, consider it countable.
Props ayeshrajans, jrf, desrosj.
Merges [43220] to the 4.9 branch.
Fixes #43583.
Built from https://develop.svn.wordpress.org/branches/4.9@43221


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 17:59:25 +00:00
Sergey Biryukov
fbb106494f Privacy: Tweak Privacy Policy page intro text for clarity.
Props macbookandrew, allendav.
Merges [43218] to the 4.9 branch.
See #43933.
Built from https://develop.svn.wordpress.org/branches/4.9@43219


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 16:14:25 +00:00
Andrew Ozz
6bbbdf94c0 Privacy: fix styling on personal data tables.
Props melchoyce, allendav.
Merges [43216] to the 4.9 branch.
Fixes #43909.
Built from https://develop.svn.wordpress.org/branches/4.9@43217


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 16:04:25 +00:00
Sergey Biryukov
b9bda541d4 Privacy: Notify admin via email when a request is confirmed.
Previously the admin didn't have any way to know if a pending request was ready to be processed, aside from manually checking the Export/Erase pages. Sending them an email is a much more convenient option.

Props garrett-eclipse, desrosj, iandunn.
Merges [43211] to the 4.9 branch.
See #43967.
Built from https://develop.svn.wordpress.org/branches/4.9@43215


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 15:56:25 +00:00
Sergey Biryukov
3bd2b3ad62 Privacy: Reposition admin pointer to avoid covering collapsed menu.
Previously the pointer overlapped the menu in order to draw attention to the fact that it applies to both the `Tools` and `Settings` menus. That caused a conflict if the menu was collapsed, though, because the icons were covered by the pointer and therefore inaccessible.

Additionally, minor tweaks were made to the text order and formatting. The order of the two sections was swapped in the title and paragraph, in order to match the order of the corresponding menu items. The spacing around headings and paragraphs was tweaked to remove extraneous whitespace.

Props littler.chicken, desrosj, ianbelanger, melchoyce.
Merges [43210] to the 4.9 branch.
Fixes #43961.
Built from https://develop.svn.wordpress.org/branches/4.9@43214


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 15:54:25 +00:00
Andrew Ozz
bf039f8987 Privacy: cleanup of the "Export Personal Data" and "Erase Personal Data" screens.
Props desrosj, xkon.
Merges [43212] to the 4.9 branch.
See #43929.
Built from https://develop.svn.wordpress.org/branches/4.9@43213


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-10 10:03:27 +00:00
Sergey Biryukov
4cf2959f1e Privacy: Pass export request ID to wp_privacy_personal_data_export_file_created filter.
Props thomasplevy.
Merges [43208] to the 4.9 branch.
Fixes #44031.
Built from https://develop.svn.wordpress.org/branches/4.9@43209


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 23:19:25 +00:00
Sergey Biryukov
728530718b Privacy: Make the help hint for Privacy Policy page more translatable and accessible.
Props tobifjellner.
Merges [43206] to the 4.9 branch.
See #43980.
Built from https://develop.svn.wordpress.org/branches/4.9@43207


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 23:14:26 +00:00
Andrew Ozz
44dc191a6d Privacy: show the privacy policy guide and suggested content on a new page instead of a postbox. Then:
- Separate the guide text form the suggested policy text.
- Add table of content for easier navigation.
- Move the content to tools.php (prevents the settings menu of being open).
- Add a link to the guide from the Privacy settings screen.

Props melchoyce, azaozz.
Merges [43184] and [43203] to the 4.9 branch.
Fixes #43980.
Built from https://develop.svn.wordpress.org/branches/4.9@43204


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 21:00:28 +00:00
Andrew Ozz
7156e5171c Privacy: remove the help tab from Settings => Privacy until we have something helpful to say :)
Props allendav.
Merges [43201] to the 4.9 branch.
Fixes #44023.
Built from https://develop.svn.wordpress.org/branches/4.9@43202


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 18:14:26 +00:00
Andrew Ozz
451d53723b Privacy: remove leftover comment after [43197].
Merges [43199] to the 4.9 branch.
See #43968.
Built from https://develop.svn.wordpress.org/branches/4.9@43200


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 17:59:24 +00:00
Andrew Ozz
1d477066e4 Privacy: add request type and filter to the subject of request confirmation emails for GDPR.
Props desrosj, azaozz.
Merges [43197] to the 4.9 branch.
Fixes #43968.
Built from https://develop.svn.wordpress.org/branches/4.9@43198


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 17:54:24 +00:00
Andrew Ozz
0827e54cc0 Privacy: increase filter priority of the User group in Personal Data Exports.
Props allendav desrosj.
Merges [43195] to the 4.9 branch.
Fixes #43966.
Built from https://develop.svn.wordpress.org/branches/4.9@43196


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 17:13:26 +00:00
Andrew Ozz
45c4047586 Privacy: fix spacing on small screens for the Use This Page button in Privacy Tools.
Props PressTigers, desrosj.
Merges [43193] to the 4.9 branch.
Fixes #43852.


Built from https://develop.svn.wordpress.org/branches/4.9@43194


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 16:16:25 +00:00
Sergey Biryukov
547912fbfc Privacy: Add id attribute to WP_Privacy_Requests_Table and WP_Privacy_Data_Export_Requests_Table rows, for consistency with other post list tables.
Props desrosj.
Merges [43191] to the 4.9 branch.
Fixes #44015.
Built from https://develop.svn.wordpress.org/branches/4.9@43192


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 15:08:26 +00:00
Sergey Biryukov
9209c0738c Docs: Remove unused ###USERNAME### placeholder reference from user_request_action_email_content filter documentation.
Props desrosj.
Merges [43189] to the 4.9 branch.
Fixes #44016.
Built from https://develop.svn.wordpress.org/branches/4.9@43190


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 14:39:26 +00:00
Sergey Biryukov
094c20d004 Privacy: Mark erasure requests as completed after processing.
r42986 introduced the beginnings of an Ajax handler for processing requests to erase personal data. At the time, a method for marking requests as completed was planned, but had not yet been created. This commit introduces that mechanism, bringing the erasure process closer to completion.

Props coreymckrill, allendav.
Merges [43185] to the 4.9 branch.
Fixes #43922.
Built from https://develop.svn.wordpress.org/branches/4.9@43188


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 14:33:26 +00:00
Sergey Biryukov
2ce4a04aff Privacy: Mark processed requests as completed instead of confirmed.
r43008 refactored the request flow to make several improvements, but accidentally marked `completed` requests as `confirmed`. This commit restores the intended statuses, so that the data and corresponding UI reflect reality.

Props allendav, birgire.
Merges [43183] to the 4.9 branch.
Fixes #43913.
Built from https://develop.svn.wordpress.org/branches/4.9@43187


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 14:31:26 +00:00
Sergey Biryukov
809d5fa08e Privacy: Reuse existing archive filenames to maintain URLs.
Whenever an admin initiates a download or email of a personal data export, a fresh copy of the file is generated. Previously, a new filename was used each time, which could lead to situations where a URL that was emailed to a data subject is broken.

That can be avoided by reusing the same filename when building fresh archives.

Props desrosj, tz-media, allendav.
Merges [43180] to the 4.9 branch.
Fixes #43905.
Built from https://develop.svn.wordpress.org/branches/4.9@43186


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 14:30:26 +00:00
Andrew Ozz
cca8f1053b TinyMCE: fix setting of zIndex on the dialogs.
Props subrataemfluence, azaozz.
Merges [43181] to the 4.9 branch.
Fixes #43984.
Built from https://develop.svn.wordpress.org/branches/4.9@43182


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-08 20:57:28 +00:00
Sergey Biryukov
1d2fd8ef87 Privacy: Use the terms "erase"/"erasure" instead of "remove"/"removal" for personal data.
Props allendav.
Merges [43175] to the 4.9 branch.
Fixes #43920.
Built from https://develop.svn.wordpress.org/branches/4.9@43176


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-07 16:46:26 +00:00
Sergey Biryukov
318ebdf1eb Privacy: Change "Email Data" link text on "Export Personal Data" screen to "Send Export Link" for clarity.
Props birgire, ianbelanger.
Merges [43172] to the 4.9 branch.
Fixes #43964.
Built from https://develop.svn.wordpress.org/branches/4.9@43173


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-05 09:23:26 +00:00
Sergey Biryukov
deeee40510 Privacy: Remove stray closing tag in WP_Privacy_Policy_Content::get_default_content(), fix typo in @return tag.
Props dlh, tobifjellner.
Merges [43170] to the 4.9 branch.
Fixes #43951.
Built from https://develop.svn.wordpress.org/branches/4.9@43171


git-svn-id: http://core.svn.wordpress.org/branches/4.9@43000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-04 01:57:26 +00:00
Sergey Biryukov
a86c8727b6 Docs: Add missing duplicate hook comment for user_request_key_expiration filter.
Props birgire, desrosj.
Merges [43168] to the 4.9 branch.
Fixes #43934.
Built from https://develop.svn.wordpress.org/branches/4.9@43169


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-04 01:49:49 +00:00
Sergey Biryukov
45cee39420 Customize: Correct closing tag in WP_Customize_Theme_Control::content_template().
Props itowhid06.
Merges [43166] to the 4.9 branch.
Fixes #43945.
Built from https://develop.svn.wordpress.org/branches/4.9@43167


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-04 01:05:26 +00:00
iandunn
c85cf4f9bc Post WordPress 4.9.6 Beta 1 version bump.
Built from https://develop.svn.wordpress.org/branches/4.9@43165


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 21:59:25 +00:00
iandunn
2c263a2069 WordPress 4.9.6 Beta 1.
Built from https://develop.svn.wordpress.org/branches/4.9@43164


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 21:30:26 +00:00
Andrew Ozz
80159017d2 Privacy: Return before scheduling cron during install to avoid error.
r43046 introduced wp_schedule_delete_old_privacy_export_files() to schedule the wp_privacy_delete_old_export_files cron job, but it did not check to make sure it wasn't running in the context of the install process. When it did run in that context, it created a database error, because the necessary database tables don't exist at that point.

Checking the current context and returning early during the installation phase avoids that issue.

Props helen, timothyblynjacobs, iandunn.
Merges [43162] to the 4.9 branch.
Fixes #43952.
Built from https://develop.svn.wordpress.org/branches/4.9@43163


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 21:15:26 +00:00
Andrew Ozz
d664ac9ea6 Privacy: Redirect to newly created Privacy Policy page to improve UX.
Previously the user was shown a message that the page was created, but might not understand that they still need to visit the page and publish it. Redirecting them to the page makes it more obvious that additional steps are involved.

Props Clorith, xkon, azaozz.
Merges [43160] to the 4.9 branch.
Fixes #43926.
Built from https://develop.svn.wordpress.org/branches/4.9@43161


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 20:10:24 +00:00
Andrew Ozz
3e36496be3 Privacy: Add an admin pointer for new privacy features in 4.9.6.
The new features are very important for some users, because of their GDPR obligations. They're also spread across multiple top-level menus, making them less discoverable. An admin pointer will help to ensure that users are aware of the new tools and how to find them.

Props desrosj, andreamiddleton, allendav, xkon.
Merges [43158] to the 4.9 branch.
Fixes #43942.
Built from https://develop.svn.wordpress.org/branches/4.9@43159


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 19:52:26 +00:00
Andrew Ozz
4eeea599bd Privacy: Store plugin callbacks in associative array for flexibility.
The personal data export and erasure tools allow plugins to register their own callbacks, in order to add additional data to the export and erasure processes. Previously, these were registered without specifying a constant identifier in the array of callbacks. Using mutable integers makes it difficult for plugins to modify the callbacks of other plugins, though.

Using associative array keys instead provides a covenient and reliable way to identify and interact with another plugin's callbacks.

Props desrosj, allendav, ocean90.
Merges [43154] to the 4.9 branch.
Fixes #43931.
Built from https://develop.svn.wordpress.org/branches/4.9@43157


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 19:38:27 +00:00
Andrew Ozz
8aa3f8aa17 Privacy: rename manage_privacy_policy to manage_privacy_options.
Props desrosj.
Merges [43155] to the 4.9 branch.
Fixes #43935.
Built from https://develop.svn.wordpress.org/branches/4.9@43156


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 19:35:26 +00:00
Andrew Ozz
b5dd35f036 Privacy: Limit Privacy Settings screen to Super Admins in Multisite.
In many common Multisite use cases, the network administrator will want to set a network-wide privacy policy -- via the privacy_policy_url filter -- for consistency and convenience. When that's done, the Privacy Settings screen on individual sites becomes unnecessary, and may confuse administrators of those sites when they see that their changes don't have any effect on the policy link in the footer.

Since we can't programatically determine which behavior the network admins would like, the safest default setting is to restrict the ability to super admins, and let them delegate it to individual site owners via a plugin, if they'd like to.

Merhes [43147] to the 4.9 branch.
Fixes #43935.
Built from https://develop.svn.wordpress.org/branches/4.9@43153


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 18:42:26 +00:00
Andrew Ozz
1dfbe95995 Privacy: Move privacy policy page to Settings menu for consistency.
The page was originally placed under Tools so that it would be grouped with the pages to export and erase personal data, since they're all part of the effort to bring privacy management tools to Core ahead of GDPR's deadline. After more consideration, though, it makes sense to move this page to the Settings menu, since it's fundamental purpose is to configure an option, rather than to facilitate a recurring task. This keeps all of the configuration pages in a single place, making them consistent and easier to find.

Exporting and erasing personal data are recurring tasks, so they still make sense under the Tools menu.

Props xkon, helen, melchoyce, allendav, desrosj, ocean90, azaozz.
Merges [43145] to the 4.9 branch.
Fixes #43873.
Built from https://develop.svn.wordpress.org/branches/4.9@43152


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 18:32:25 +00:00
Andrew Ozz
2b0b7ffa89 Privacy: use sprintf() in translations.
Props birgire.
Merges [43150] to the 4.9 branch.
See #43473.
Built from https://develop.svn.wordpress.org/branches/4.9@43151


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 18:28:26 +00:00
Andrew Ozz
b78d21d9f0 Privacy: add default text for a privacy policy including a tutorial on now to create one.
Insert both the text and tutorial in new policy pages and highlight is brightly in the editor.
Show only the suggested text in the policy postbox.

Props melchoyce, idea15, allendav, xkon, macbookandrew, azaozz.
Merges [43044], [43048], [43052], [43126], [43146], and [43148] to the 4.9 branch.
Fixes #43473.
Built from https://develop.svn.wordpress.org/branches/4.9@43149


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 17:59:30 +00:00
Andrew Ozz
65e67aeaa5 Privacy: fix displaying of messages during personal data erasure.
Props allendav.
Merges [43139] to the 4.9 branch.
Fixes #43943.
Built from https://develop.svn.wordpress.org/branches/4.9@43140


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 09:26:27 +00:00
Sergey Biryukov
17c256df0b REST API: When handling who=authors query parameter for GET wp/v2/users, only check edit_posts for post types that support author.
Props danielbachhuber.
Merges [43137] to the 4.9 branch.
Fixes #42202.
Built from https://develop.svn.wordpress.org/branches/4.9@43138


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 06:54:25 +00:00
Sergey Biryukov
5247520fe2 Media: Add aac to the list of allowed file types.
Props desrosj.
Merges [42697] and [43135] to the 4.9 branch.
Fixes #42919.
Built from https://develop.svn.wordpress.org/branches/4.9@43136


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 06:42:25 +00:00
Sergey Biryukov
95c9ca4091 Privacy: Uncapitalize "privacy policy" when used in a sentence.
In these contexts, "privacy policy" is not a proper noun, and therefore should not be capitalized.

The remaining uses are page titles and section headers, where capitalization is appropriate.

Props idea15, garrett-eclipse, allendav.
Merges [43132] to the 4.9 branch.
Fixes #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43134


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 05:31:25 +00:00
Sergey Biryukov
9db1397f08 Privacy: Revise Privacy Policy page text to avoid misunderstanding.
The previous sentence was gramatically awkward, and using the term "compliance" could accidentally be mistaken by a site owner for a promise by WordPress that their site will be compliant after using the tool, which is not necessarily true.

Props idea15, allendav, azaozz, iandunn.
Merges [43131] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43133


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-03 05:30:26 +00:00
Sergey Biryukov
2878ae6271 Comments: Move comment consent input outside the label for a11y.
Non-wrapping `label`s are more widely supported by assitive technologies. The CSS changes account for the element re-ordering, and tweak the formatting for improved readability.

Props afercia, xkon, laurelfulford, azaozz.
Merges [43125] to the 4.9 branch.
Fixes #43436.
Built from https://develop.svn.wordpress.org/branches/4.9@43130


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 22:15:25 +00:00
Sergey Biryukov
f345a0b15e Privacy: Use "website" in comment cookie consent text for clarity.
The term "URL" is technical jargon which will not be familiar to all commenters. "Website" is more universal, and matches the label on the url input field.

Props johnjamesjacoby, allendav, azaozz.
Merges [43123] to the 4.9 branch.
See #43436.
Built from https://develop.svn.wordpress.org/branches/4.9@43129


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 22:14:24 +00:00
Sergey Biryukov
103ca5c6cf Respect the commenter decision when they have checked the checkbox to consent to cookies, and keep it checked when they reload the page or post another comment.
Props azaozz.
Merges [42815] to the 4.9 branch.
See #43436.
Built from https://develop.svn.wordpress.org/branches/4.9@43128


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 22:13:27 +00:00
Sergey Biryukov
26fdba2c5b Add a checkbox to the comment form so logged out users can opt-out of commenter cookies.
Props lakenh, xkon, birgire, azaozz, johnbillion.
Merges [42772] and [43042] to the 4.9 branch.
See #43436.
Built from https://develop.svn.wordpress.org/branches/4.9@43127


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 22:11:25 +00:00
Sergey Biryukov
dd3024e7c4 Privacy: Add policy link to login screen.
Personal data collection is more likely for registered users than casual visitors, and the privacy policy might have been updated since a user last logged in. Those changes could impact the collection of personal data from registered users, so it makes sense to provide a link to the policy before users log in.

Props voneff, xkon, melchoyce, chetan200891, desrosj.
Merges [43120] to the 4.9 branch.
Fixes #43721.
Built from https://develop.svn.wordpress.org/branches/4.9@43124


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 22:00:27 +00:00
Andrew Ozz
3b7d4b49c0 Privacy: fix typo.
Props casiepa.
Merges [43121] to the 4.9 branch.
Fixes #43939.
Built from https://develop.svn.wordpress.org/branches/4.9@43122


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 20:08:25 +00:00
Andrew Ozz
7cf7767298 Privacy: fix inconsistencies in new strings.
Props audrasjb.
Merges [43118] to the 4.9 branch.
Fixes #43925.
Built from https://develop.svn.wordpress.org/branches/4.9@43119


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 18:51:26 +00:00
Sergey Biryukov
a2be0cd32b Privacy: add user information to the personal data export file.
Props TZ-Media, desrosj.
Merges [43055] and [43116] to the 4.9 branch.
See #43547.
Built from https://develop.svn.wordpress.org/branches/4.9@43117


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 04:21:25 +00:00
Sergey Biryukov
e0d8b2663c Privacy: add better docs for wp_add_privacy_policy_content() and WP_Privacy_Policy_Content::add().
Props azaozz.
Merges [43003] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43115


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:57:24 +00:00
Sergey Biryukov
eba98dc78d Make the string WordPress translatable.
Props mnelson4.
Merges [42999] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43114


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:55:24 +00:00
Sergey Biryukov
0896655aea Privacy: make the sections in the suggested privacy policy text postbox foldable. Add Read More/Read Less buttons. Fix copying of the suggested text by pressing the button.
Props melchoyce, xkon, azaozz.
Merges [42992] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43113


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:54:24 +00:00
Sergey Biryukov
7aab5bc693 Fix typo in 'wp_get_default_privacy_policy_content' filter.
Props claudiu.
Merges [42985] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43112


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:52:26 +00:00
Sergey Biryukov
c60aa91d76 Privacy: Limit export and erasure to super admins on Multisite.
Multisite networks have a variety of use cases, and in many of them single-site administrators are not trusted to take actions that affect the whole network, require making decisions about legal compliance, etc. By default, those actions should require super admin capabilities. Plugins can be used to override that behavior if a particular site's use case calls for it.

Props allendav, jeremyfelt, iandunn.
Merges [43085] to the 4.9 branch.
Fixes #43919.
Built from https://develop.svn.wordpress.org/branches/4.9@43111


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:49:26 +00:00
Sergey Biryukov
a6284311e8 Privacy: improve wp_privacy_erase_personal_data(), return boolean values.
Props ericdaams.
Merges [43061] to the 4.9 branch.
See #43602.
Built from https://develop.svn.wordpress.org/branches/4.9@43110


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:44:24 +00:00
Sergey Biryukov
3095491428 Privacy: Add template tags for building link to privacy policy page.
This introduces the `get_the_privacy_policy_link()` and `the_privacy_policy_link()` functions, as well as the `privacy_policy_url` filter.

A new `tests/url/` folder was added to better organize tests related to `get_*_url()` functions. Previously, those tests were placed in `tests/url.php` and `tests/link/`, but neither of those locations are optimal. Placing tests in `tests/url.php` violates the guideline of creating separate files/classes for each function under test, and using `tests/link/` conflates two distinct -- albeit related -- groups of functions. Over time, URL-related tests can be migrated to the new folder.

Props birgire, xkon, azaozz, iandunn.
Merges [43002] to the 4.9 branch.
See #43850.
Built from https://develop.svn.wordpress.org/branches/4.9@43109


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:39:27 +00:00
Sergey Biryukov
8114ac92ef Privacy: add attachments to the personal data export file.
Props allendav.
Merges [43054] to the 4.9 branch.
See #43883.
Built from https://develop.svn.wordpress.org/branches/4.9@43108


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:34:25 +00:00
Sergey Biryukov
2083557ea9 I18N: Use consistent pattern for placeholder references in translator comments in wp_ajax_wp_privacy_erase_personal_data().
Merges [43088] to the 4.9 branch.
See #43438.
Built from https://develop.svn.wordpress.org/branches/4.9@43107


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:24:25 +00:00
Sergey Biryukov
fdb8a97664 Docs: Correct DocBlock formatting for wp_privacy_personal_data_erasers filter.
Merges [43104] to the 4.9 branch.
See #43637.
Built from https://develop.svn.wordpress.org/branches/4.9@43106


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:20:25 +00:00
Sergey Biryukov
050ea51bcb Privacy: translate error messages, some fixes and improvements for the AJAX actions for exporting and erasing user data.
Props desrosj, birgire.
Merges [43060] to the 4.9 branch.
See #43438.
Built from https://develop.svn.wordpress.org/branches/4.9@43105


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:19:26 +00:00
Sergey Biryukov
38e4408131 Privacy: fix and improve the help text about adding a privacy policy page.
Props idea15, xkon.
Merges [43053] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43103


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:02:25 +00:00
Sergey Biryukov
0b40d2f9cf Privacy: fix get_privacy_policy_url() to only return the URL when the page is published.
Props azaozz.
Merges [42995] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43102


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 03:00:25 +00:00
Sergey Biryukov
c7ac8db6e4 Privacy: add a postbox that is shown when editing the privacy policy page, and where plugins and core will output suggested content and additional privacy info. First run.
Props melchoyce, azaozz.
Merges [42980] to the 4.9 branch.
See #43620.
Built from https://develop.svn.wordpress.org/branches/4.9@43101


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:59:25 +00:00
Sergey Biryukov
6703bb7c72 Privacy: improve the screen for setting a privacy policy page.
Props melchoyce, xkon, azaozz.
Merges [42978] and [43091] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43100


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:50:26 +00:00
Sergey Biryukov
1b0bd1ff7a Accessibility improvements for the Privacy Tools screen.
Props afercia.
Merges [42823] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43099


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:48:26 +00:00
Sergey Biryukov
9af2f7cd35 Add Privacy Tools admin page under the Tools menu.
Props allendav, xkon, azaozz.
Merges [42814] to the 4.9 branch.
See #43435.
Built from https://develop.svn.wordpress.org/branches/4.9@43098


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:46:25 +00:00
Sergey Biryukov
df15be7cf9 Privacy: Include wp-admin/includes/file.php to avoid fatal error.
`list_files()` is defined in `wp-admin/includes/file.php`, which is not included by `wp-cron.php`, so it needs to be included by the caller in order to avoid a fatal PHP error.

This bug was not detected during testing because the file _is_ included when executing jobs via `wp cron event run`.

Props mikejolley, iandunn.
Merges [43059] to the 4.9 branch.
See #43546.
See https://wordpress.slack.com/archives/C9695RJBW/p1525190405000860.
Built from https://develop.svn.wordpress.org/branches/4.9@43097


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:38:25 +00:00
Sergey Biryukov
894cec5697 Privacy: Add wp_privacy_personal_data_export_file_created filter.
This runs immediately after the data export file has been successfully created, allowing plugins to introduce some workflow customizations. For example, a plugin could password-protect the export file, for peace of mind, even though the CSPRN in the filename makes brute force attacks nearly impossible.

Props iandunn.
Merges [43047] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43096


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:35:27 +00:00
Sergey Biryukov
06dd3449e9 Privacy: Add cron to delete expired export files to protect privacy.
The primary means of protecting the files is the CSPRN appended to the filename, but there is no reason to keep the files after the data subject has downloaded them, so deleting them provides an additional layer of protection. Previously this was done from `wp_privacy_generate_personal_data_export_file()`, but that does not guarantee that it will be run regularly, and on smaller sites that could result in export files being exposed for much longer than necessary.

`wp_privacy_delete_old_export_files()` was moved to a front end file, so that it can be called from `cron.php`.

This introduces the `wp_privacy_export_expiration` filter, which allows plugins to customize how long the exports are kept before being deleted.

`index.html` was added to the `$exclusions` parameter of `list_files()` to make sure that it isn't deleted. If it were, then poorly-configured servers would allow the directory to be traversed, exposing all of the exported files.

Props iandunn, desrosj.
Merges [43046] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43095


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:33:26 +00:00
Sergey Biryukov
7a7e45a530 Privacy: Use a CSPRNG in export filenames for more security.
`rand()` is deterministic and therefore offers much less protection in this context. `wp_generate_password()` is a convenient wrapper around `wp_rand()`, which uses `random_int()` to generate cryptographically-secure psuedorandom numbers.

Props iandunn.
Merges [43045] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43094


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:19:25 +00:00
Sergey Biryukov
c3c9eaf45e Privacy: fix unit tests after [43012].
Props iandunn.
Merges [43015] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43093


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:17:25 +00:00
Sergey Biryukov
e5c53b9bbd Privacy: add means to export personal data by username or email address. Generate a zipped export file containing all data. First run.
Props allendav.
Merges [43012] and [43089] to the 4.9 branch.
See #43546.
Built from https://develop.svn.wordpress.org/branches/4.9@43092


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 02:16:25 +00:00
Sergey Biryukov
d4be2db521 Privacy: make the emails in export and erasure list-tables clickable.
Props birgire.
Merges [43057] to the 4.9 branch.
See #43911.
Built from https://develop.svn.wordpress.org/branches/4.9@43086


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 01:08:25 +00:00
Sergey Biryukov
14d25f6094 Privacy: update and enhance the method to confirm user requests by email. Introduce WP_User_Request to hold all request vars similarly to WP_Post.
Props mikejolley, desrosj.
Merges [43011] and [43014] to the 4.9 branch.
See #43443.
Built from https://develop.svn.wordpress.org/branches/4.9@43084


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 01:04:26 +00:00
Sergey Biryukov
e5b5b15b88 Privacy: update the method to confirm user requests by email. Use a single CPT to store the requests and to allow logging/audit trail.
Props mikejolley.
Merges [43008] to the 4.9 branch.
See #43443.
Built from https://develop.svn.wordpress.org/branches/4.9@43083


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 01:01:25 +00:00
Sergey Biryukov
b433465f15 Privacy: add helper function for anonymizing data in a standardized way.
Props jesperher, allendav, iandunn, birgire, azaozz, joemcgill.
Merges [42971] and [43081] to the 4.9 branch.
Fixes #43545.
Built from https://develop.svn.wordpress.org/branches/4.9@43082


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 00:49:26 +00:00
Sergey Biryukov
bcb3a839d1 Privacy: add functionality to anonymize commenters.
Props xkon, fclaussen, allendav, birgire, azaozz.
Merges [42994] to the 4.9 branch.
See #43442.
Built from https://develop.svn.wordpress.org/branches/4.9@43080


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 00:21:25 +00:00
Sergey Biryukov
257be25506 Privacy: docs fixes and improvements for wp_comments_personal_data_exporter().
Props desrosj.
Merges [43058] to the 4.9 branch.
See #43440.
Built from https://develop.svn.wordpress.org/branches/4.9@43079


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 00:18:26 +00:00
Sergey Biryukov
59593950dc Privacy: Fix JSHint errors.
Introduced in [42986].

Props jorbin.
Merges [42989] to the 4.9 branch.
See #43440.
Built from https://develop.svn.wordpress.org/branches/4.9@43078


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 00:15:25 +00:00
Sergey Biryukov
6a3018a7c9 Privacy: fix docs, formatting, white space, add tests for the personal data from comments exporter.
Props birgire.
Merges [42987] to the 4.9 branch.
See #43440.
Built from https://develop.svn.wordpress.org/branches/4.9@43077


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 00:12:25 +00:00
Sergey Biryukov
2f6f41170a Privacy: add functionality for exporting personal data from comments.
Props allendav, xkon.
Merges [42888] to the 4.9 branch.
See #43440.
Built from https://develop.svn.wordpress.org/branches/4.9@43076


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 00:11:24 +00:00
Sergey Biryukov
82687eb7af Privacy: add means to erase personal data by username or email address. First run.
Props allendav, coreymckrill, ericdaams, azaozz.
Merges [42986] to the 4.9 branch.
See #43637, #43602.
Built from https://develop.svn.wordpress.org/branches/4.9@43075


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-02 00:03:27 +00:00
Sergey Biryukov
309984de5f Privacy: add support for exporting multiple pages of personal data.
Props allendav.
Merges [42889] to the 4.9 branch.
See #43438.
Built from https://develop.svn.wordpress.org/branches/4.9@43074


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 23:58:25 +00:00
Sergey Biryukov
b1c0bffa78 Privacy: fix error message and list table sorting errors on the Export Personal Data and Remove Personal Data screens.
Props azaozz.
Merges [42977] to the 4.9 branch.
See #43481.
Built from https://develop.svn.wordpress.org/branches/4.9@43073


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 23:49:26 +00:00
Sergey Biryukov
feb3e4caec Tests: Update the REST API fixtures.
[42967] included new post statii, but didn't add them to the REST API tests.

Props pento.
Merges [42972] to the 4.9 branch.
See #43481.
Built from https://develop.svn.wordpress.org/branches/4.9@43072


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 23:46:25 +00:00
Sergey Biryukov
88bc6a609e Privacy: add new wp-admin screens for exporting and removing of personal data.
Props melchoyce, mikejolley, allendav, xkon.
Merges [42967] to the 4.9 branch.
See #43481.
Built from https://develop.svn.wordpress.org/branches/4.9@43071


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 23:42:25 +00:00
Sergey Biryukov
e08597f8fa Privacy: fixes and updates for the method to confirm user requests by email.
- Improve function and variable names.
- Allow extra data to be passed with the request.
- Make the option/user meta names more consistent.
- Adds an inline comment explaining use of hash.

Props mikejolley.
Merges [42964] to the 4.9 branch.
See #43443.
Built from https://develop.svn.wordpress.org/branches/4.9@43070


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 23:37:27 +00:00
Sergey Biryukov
01e3c640fe Add a method to confirm user requests by email. First run.
Props mikejolley.
Merges [42791] to the 4.9 branch.
See #43443.
Built from https://develop.svn.wordpress.org/branches/4.9@43069


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 23:34:26 +00:00
Sergey Biryukov
85d1ba9726 TinyMCE: Update to 4.7.11.
Props iseulde.
Merges [43004] to the 4.9 branch.
Fixes #43862.
Built from https://develop.svn.wordpress.org/branches/4.9@43068


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 22:31:24 +00:00
Sergey Biryukov
59a7fbddde REST API: Add who=authors as a query parameter for GET wp/v2/users.
Any WordPress user who can `edit_posts` of a post type with `show_in_rest=true` can query for authors. This maps to current WordPress behavior where a WordPress user who can view the Manage Posts view for a post type can see any WordPress user assigned to a post (whether published or draft).

This implementation, over restricting `who=authors` to users with `list_users`, gives us future flexibility in displaying lists of posts. It still respects more restrictive permissions for `context=edit`.

Props danielbachhuber.
Merges [43001] to the 4.9 branch.
Fixes #42202.
Built from https://develop.svn.wordpress.org/branches/4.9@43067


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 22:18:26 +00:00
Sergey Biryukov
dc3d22edd9 Login and Registration: Send nocache_headers() on Multisite account activation pages.
Props herregroen.
Merges [43065] to the 4.9 branch.
Fixes #43917.
Built from https://develop.svn.wordpress.org/branches/4.9@43066


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 22:10:26 +00:00
Sergey Biryukov
ee43146223 Privacy: add "Mine" filter for media similarly to posts and comments.
Props audrasjb.
Merged [43056], [43062], [43063] to the 4.9 branch.
Fixes #43820.
Built from https://develop.svn.wordpress.org/branches/4.9@43064


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-01 22:04:28 +00:00
Sergey Biryukov
cf7288a673 Themes: Avoid a PHP 7.2 warning in get_theme_roots() when $wp_theme_directories is an uncountable value.
See [41174] for `wp_get_themes()` and `get_raw_theme_root()`.

Props burlingtonbytes, teddytime, lbenicio, desrosj.
Merges [43039] to the 4.9 branch.
Fixes #43374. See #40109.
Built from https://develop.svn.wordpress.org/branches/4.9@43040


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-30 04:55:26 +00:00
Sergey Biryukov
f04d84149f REST API: Include viewable attribute on Post Type resource for edit context.
For the block editor to be able to expose the Preview button correctly, it needs to know the `is_post_type_viewable()` setting, this change adds it to the Post Type response.

Props danielbachhuber.
Merges [43007] to the 4.9 branch.
Fixes #43739.
Built from https://develop.svn.wordpress.org/branches/4.9@43038


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-30 04:31:25 +00:00
Sergey Biryukov
9bee0589fb General: Introduce a polyfill for is_iterable() function added in PHP 7.1.
Props jrf, schlessera, desrosj.
Merges [43036] to the 4.9 branch.
See #43619.
Built from https://develop.svn.wordpress.org/branches/4.9@43037


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-30 04:17:25 +00:00
Sergey Biryukov
408d8c63be General: Introduce a polyfill for is_countable() function added in PHP 7.3.
Props jrf, ayeshrajans, desrosj.
Merges [43034] to the 4.9 branch.
See #43583.
Built from https://develop.svn.wordpress.org/branches/4.9@43035


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-30 03:47:24 +00:00
Sergey Biryukov
3408441e15 Help/About: Move "Get involved" link on Credits screen to the top of the page for better visibility.
Props bridgetwillard, desrosj.
Merges [43032] to the 4.9 branch.
See #23348.
Built from https://develop.svn.wordpress.org/branches/4.9@43033


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-30 03:19:24 +00:00
Sergey Biryukov
57e36f1ed2 Login and Registration: Send nocache_headers() on Multisite signup pages.
Props herregroen.
Merges [43030] to the 4.9 branch.
Fixes #43843.
Built from https://develop.svn.wordpress.org/branches/4.9@43031


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-29 23:10:26 +00:00
Sergey Biryukov
e40df25f76 Plugins: Show the required PHP version in the plugin details view, if specified.
Props xkon.
Merges [42998] to the 4.9 branch.
Fixes #43650.
Built from https://develop.svn.wordpress.org/branches/4.9@43029


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-29 22:51:25 +00:00
Sergey Biryukov
40bd08b50f Themes: Introduce theme_templates filter for page templates of all post types.
This complements the `theme_{$post_type}_templates` dynamic filter added in [38951].

Props desrosj.
Merges [43025] and [43027] to the 4.9 branch.
Fixes #43872.
Built from https://develop.svn.wordpress.org/branches/4.9@43028


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-29 22:45:24 +00:00
Sergey Biryukov
13b6280373 Docs: Correct $id parameter type for old_slug_redirect_post_id filter.
Props dlh.
Merges [42722] to the 4.9 branch.
Fixes #43375.
Built from https://develop.svn.wordpress.org/branches/4.9@43026


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-29 22:37:28 +00:00
Aaron Campbell
65a757621d Bump 4.9 branch to version 4.9.5
Built from https://develop.svn.wordpress.org/branches/4.9@42933


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-03 20:17:40 +00:00
Dominik Schilling
760aa16ab8 Media: Update minified version of imgAreaSelect after [42874].
Adds imgAreaSelect to the uglify grunt process.

Merge of [42930] to the 4.9 branch.

Props adamsilverstein.
See #41242.
Built from https://develop.svn.wordpress.org/branches/4.9@42932


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-03 19:51:37 +00:00
Dominik Schilling
7f5c437803 Template: Make sure the version string is correctly escaped for use in attributes.
Merge of [42893] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42917


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-03 16:05:39 +00:00
Dominik Schilling
8cd1a27463 HTTP: Don't treat localhost as same host by default.
Merge of [42894] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42908


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-03 15:35:41 +00:00
Dominik Schilling
076fb0ff4d Login: Use wp_safe_redirect() when redirecting the login page if forced to use HTTPS.
Merge of [42892] to the 4.9 branch.

Built from https://develop.svn.wordpress.org/branches/4.9@42895


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-04-03 15:22:42 +00:00
Sergey Biryukov
4c34006070 Post WordPress 4.9.5 RC 1 version bump.
Built from https://develop.svn.wordpress.org/branches/4.9@42885


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-28 01:39:38 +00:00
Sergey Biryukov
8d99bb5288 WordPress 4.9.5 RC 1.
Built from https://develop.svn.wordpress.org/branches/4.9@42884


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-28 01:08:38 +00:00
Gary Pendergast
bac5694e88 Dashboard: Remove the "Try Gutenberg" callout.
As eager as we all are to see Gutenberg put before a wider audience, there are still a handful of issues that need to be fixed, which won't be done before the 4.9.5 release.

Reverts [42869].
See #41316.


Built from https://develop.svn.wordpress.org/branches/4.9@42883


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-28 00:18:43 +00:00
Sergey Biryukov
2aed23cc97 Twenty Seventeen: Bump version and update the changelog.
Props audrasjb.
Merges [42881] to the 4.9 branch.
Fixes #43572.
Built from https://develop.svn.wordpress.org/branches/4.9@42882


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-27 21:12:42 +00:00
Adam Silverstein
4650753c6b Media: Fix image cropping on touch screen devices.
* In initCrop, handle touch events in addition to mouse events.
* In imageSelect jQuery plugin, accept event.which of 0 as provided by touch events.

Props yahil, alexgso, joemcgill.
Merges [42818] to the 4.9 branch.
Fixes #41242.


Built from https://develop.svn.wordpress.org/branches/4.9@42874


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-24 20:26:42 +00:00
Gary Pendergast
61be857c95 Dashboard: Introduce a "Try Gutenberg" callout.
To encourage more people to try Gutenberg, this new Dashboard box allows site users to easily install and try out Gutenberg.

Props pento, melchoyce, joen, karmatosed, joemcgill, SergeyBiryukov, jorbin.

Fixes #41316.


Built from https://develop.svn.wordpress.org/branches/4.9@42869


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-22 00:59:44 +00:00
Sergey Biryukov
c12c3a96b3 Post WordPress 4.9.5 Beta 1 version bump.
Built from https://develop.svn.wordpress.org/branches/4.9@42868


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-21 02:16:37 +00:00
Sergey Biryukov
ce8c932138 WordPress 4.9.5 Beta 1
Built from https://develop.svn.wordpress.org/branches/4.9@42867


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-21 02:08:40 +00:00
Sergey Biryukov
9d75986391 Media: On Media Settings screen, make the pairs of labels and inputs always stacked vertically, on both mobile and desktop screens.
Make `<br />` tags on the screen behave as line breaks again after [41836]. Add a missing fieldset + legend for better accessibility.

Props afercia, RavanH, obenland, garrett-eclipse.
Merges [42864] to the 4.9 branch.
Fixes #42724. See #34539.
Built from https://develop.svn.wordpress.org/branches/4.9@42865


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-20 22:49:39 +00:00
Sergey Biryukov
8fae65141a Formatting: Avoid a PHP 7.2 warning in wp_kses_attr() when one of $allowedtags elements is an uncountable value.
Props andrei0x309, soulseekah, SergeyBiryukov.
Merges [42860] to the 4.9 branch.
Fixes #43312.
Built from https://develop.svn.wordpress.org/branches/4.9@42861


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-20 21:37:41 +00:00
Sergey Biryukov
6d16a905b8 Twenty Seventeen: Underline links in comments.
Props jainnidhi, larrach, audrasjb.
Merges [42713] to the 4.9 branch.
Fixes #43317.
Built from https://develop.svn.wordpress.org/branches/4.9@42859


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-20 21:19:41 +00:00
Dominik Schilling
04d41666dc REST API JavaScript Client: Support an empty string for nonce to disable sending the X-WP-Nonce header.
Passing a `nonce` argument with an empty string to `wp.api.init()` now does no longer fall back to `wpApiSettings.nonce`. This makes it possible to stop sending nonce headers, for example to a read-only endpoint on another site in a multisite install.

Merge of [42852] to the 4.9 branch.

Props adamsilverstein, FPCSJames, ocean90, swissspidy.
See #42948, #43266.
Built from https://develop.svn.wordpress.org/branches/4.9@42854


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-18 20:04:42 +00:00
Dominik Schilling
7faddf9e50 REST API JS Client: Extend custom nonce functionality to collections.
This brings the improved nonce handling from [41553] to collections to remove the direct `wpApiSettings.nonce` dependency.

Merge of [42851] to the 4.9 branch.

Props adamsilverstein, ocean90, swissspidy.
See #43265.
Built from https://develop.svn.wordpress.org/branches/4.9@42853


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-18 20:00:40 +00:00
Dominik Schilling
baba344254 Customizer menus: correct oversized viewport after dragging menu items.
Fix an issue where the screen viewport resized to an oversized state on mobile devices after moving sub-menus.

Merge of [42817] to the 4.9 branch.

Props adamsilverstein, kwonye.
Fixes #36884.
Built from https://develop.svn.wordpress.org/branches/4.9@42850


git-svn-id: http://core.svn.wordpress.org/branches/4.9@42680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-18 16:49:41 +00:00