Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-14 22:56:19 +01:00
Code Issues Projects Releases Wiki Activity
41,182 Commits 50 Branches 748 Tags 792 MiB
293bc81bf6
Commit Graph

18139 Commits

Author SHA1 Message Date
Sergey Biryukov
037a736757 Docs: Improve comments in some wp-admin files per the documentation standards. 
Follow-up to [47084].

Props passoniate, apedog.
Fixes #49223, #49227.
Built from https://develop.svn.wordpress.org/trunk@47119


git-svn-id: http://core.svn.wordpress.org/trunk@46919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:35:08 +00:00
Sergey Biryukov
e65032ff6b Coding Standards: Use strict comparison in wp-admin/user/admin.php. 
Apply the case-insensitive network-site comparisons added in [27725] for `wp-admin/network/admin.php` to `wp-admin/user/admin.php` too, for consistency.

Props rimadoshi.
Fixes #49300.
Built from https://develop.svn.wordpress.org/trunk@47115


git-svn-id: http://core.svn.wordpress.org/trunk@46915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-27 14:30:05 +00:00
Sergey Biryukov
b79e042b00 Docs: Remove extra trailing spaces from wp_add_privacy_policy_content() DocBlock to fix WPCS issues, apply minor formatting changes for consistency. 
Follow-up to [47112].

See #49282.
Built from https://develop.svn.wordpress.org/trunk@47113


git-svn-id: http://core.svn.wordpress.org/trunk@46913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-27 01:06:04 +00:00
Andrew Ozz
516629964c Privacy: Cleanup .wp-policy-help CSS remnants and add back-compat when hiding the tutorial content before copying. 
Props garrett-eclipse.
Fixes #49282.
Built from https://develop.svn.wordpress.org/trunk@47112


git-svn-id: http://core.svn.wordpress.org/trunk@46912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-26 23:02:03 +00:00
Sergey Biryukov
cfa3dc8ee8 Docs: Correct @return value for parent_dropdown(). 
Follow-up to [47100].

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47102


git-svn-id: http://core.svn.wordpress.org/trunk@46902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:33:04 +00:00
Sergey Biryukov
eb513c5ac8 Docs: Adjust @return value of parent_dropdown() for consistency with other dropdown functions. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47100


git-svn-id: http://core.svn.wordpress.org/trunk@46900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:22:03 +00:00
Sergey Biryukov
381df97419 Docs: Correct @return value for update_core() and Core_Upgrader::upgrade(). 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47099


git-svn-id: http://core.svn.wordpress.org/trunk@46899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-22 00:19:04 +00:00
Sergey Biryukov
60c651ad6a I18N: Add missing placeholders to some translators comments in wp-admin. 
Props ramiy.
Fixes #49248.
Built from https://develop.svn.wordpress.org/trunk@47093


git-svn-id: http://core.svn.wordpress.org/trunk@46893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 15:43:04 +00:00
Sergey Biryukov
c946a71d9d I18N: Correct translator comment in wp-admin/options-permalink.php. 
Props ramiy.
Fixes #49247.
Built from https://develop.svn.wordpress.org/trunk@47092


git-svn-id: http://core.svn.wordpress.org/trunk@46892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 15:10:04 +00:00
Sergey Biryukov
1adca958e3 I18N: Remove unnecessary HTML from "Active:" strings in wp-admin/themes.php. 
Follow-up to [45435].

Props ramiy.
Fixes #49243.
Built from https://develop.svn.wordpress.org/trunk@47090


git-svn-id: http://core.svn.wordpress.org/trunk@46890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 14:27:04 +00:00
Sergey Biryukov
d5be8f0635 I18N: Correct translator comments in WP_Users_List_Table::get_views() to provide information about each placeholder. 
Props ramiy.
Fixes #49242.
Built from https://develop.svn.wordpress.org/trunk@47089


git-svn-id: http://core.svn.wordpress.org/trunk@46889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 14:08:05 +00:00
Sergey Biryukov
2900bb8ea7 Docs: Update links to https://secure.php.net/, they now redirect to https://www.php.net/. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47088


git-svn-id: http://core.svn.wordpress.org/trunk@46888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-20 03:14:06 +00:00
Sergey Biryukov
89f5d3dd0c Networks and Sites: Clarify the recommendation to remove the www prefix from the site domain before creating a network. 
The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL.

Props kharisblank, tobifjellner, ramiy.
Fixes #49214.
Built from https://develop.svn.wordpress.org/trunk@47085


git-svn-id: http://core.svn.wordpress.org/trunk@46885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-18 01:15:04 +00:00
Sergey Biryukov
053a9cd5b8 Docs: Improve comments in some wp-admin files per the documentation standards. 
Props passoniate.
Fixes #49215, #49216.
Built from https://develop.svn.wordpress.org/trunk@47084


git-svn-id: http://core.svn.wordpress.org/trunk@46884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-18 00:54:04 +00:00
Sergey Biryukov
1cfc32af58 Coding Standards: Remove unnecessary // phpcs:ignore instances in WP_Debug_Data. 
`WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too.

Additionally, remove one short ternary instance, not allowed per the coding standards.

See #49222.
Built from https://develop.svn.wordpress.org/trunk@47083


git-svn-id: http://core.svn.wordpress.org/trunk@46883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-18 00:26:06 +00:00
Sergey Biryukov
0f47f2b9e5 Widgets: Remove extra padding from number inputs in Recent Posts and Recent Comments widgets. 
Props marcio-zebedeu, audrasjb, SergeyBiryukov.
Fixes #49195.
Built from https://develop.svn.wordpress.org/trunk@47082


git-svn-id: http://core.svn.wordpress.org/trunk@46882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-17 13:57:03 +00:00
Sergey Biryukov
691adde1e6 Date/Time: Use wp_date() to display the correct time of the next DST transition in Timezone setting on General Settings screen. 
Props Rarst, autotutorial.
Fixes #49038.
Built from https://develop.svn.wordpress.org/trunk@47073


git-svn-id: http://core.svn.wordpress.org/trunk@46873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-16 00:28:06 +00:00
Sergey Biryukov
3e68a63e6a Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor. 
Props pratik-jain, justinahinon, audrasjb.
Fixes #49115.
Built from https://develop.svn.wordpress.org/trunk@47072


git-svn-id: http://core.svn.wordpress.org/trunk@46872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-15 18:31:07 +00:00
Sergey Biryukov
57fbd3c847 File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens. 
Props passoniate.
Fixes #49197.
Built from https://develop.svn.wordpress.org/trunk@47071


git-svn-id: http://core.svn.wordpress.org/trunk@46871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-15 00:23:07 +00:00
Sergey Biryukov
569ff9dd27 Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process. 
Props garrett-eclipse, audrasjb.
Fixes #49018.
Built from https://develop.svn.wordpress.org/trunk@47070


git-svn-id: http://core.svn.wordpress.org/trunk@46870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-14 01:11:03 +00:00
Sergey Biryukov
10ae398727 Site Health: Avoid "Undefined property" PHP notices in wp_dashboard_site_health() when the status result transient does not exist yet. 
Props dlh for initial patch.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47069


git-svn-id: http://core.svn.wordpress.org/trunk@46869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-13 17:27:06 +00:00
Sergey Biryukov
f18b173674 Networks and Sites: Use warning styles for 'Caution' and 'Warning' messages during Multisite installation. 
Props dlh.
Fixes #49186.
Built from https://develop.svn.wordpress.org/trunk@47067


git-svn-id: http://core.svn.wordpress.org/trunk@46867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-13 17:00:06 +00:00
Sergey Biryukov
fa2f6e0644 Docs: Improve documentation for wp_save_image_file() and related functions. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47065


git-svn-id: http://core.svn.wordpress.org/trunk@46865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-12 16:56:05 +00:00
Sergey Biryukov
2c4480958b Site Health: Introduce Site Health Status dashboard widget. 
The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details.

Props Clorith, hedgefield, guddu1315.
See #47606.
Built from https://develop.svn.wordpress.org/trunk@47063


git-svn-id: http://core.svn.wordpress.org/trunk@46863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-12 13:33:05 +00:00
Sergey Biryukov
f8a5ae6b93 Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation. 
With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.

Props casiepa, danieltj, tobifjellner, netweb.
Fixes #43242.
Built from https://develop.svn.wordpress.org/trunk@47061


git-svn-id: http://core.svn.wordpress.org/trunk@46861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-12 02:24:03 +00:00
Sergey Biryukov
dd4d98a368 Docs: In various @return tags, list the expected type first, instead of false. 
Follow-up to [46696].

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47060


git-svn-id: http://core.svn.wordpress.org/trunk@46860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-11 18:32:05 +00:00
Sergey Biryukov
2294d65753 Docs: Synchronize @return descriptions for ::handle_row_actions() methods in list tables. 
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.

See #49170, #48303.
Built from https://develop.svn.wordpress.org/trunk@47059


git-svn-id: http://core.svn.wordpress.org/trunk@46859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-11 17:59:04 +00:00
Sergey Biryukov
d469aa8162 Docs: Correct @return description for WP_List_Table::handle_row_actions(). 
Props pbiron.
Fixes #49170.
Built from https://develop.svn.wordpress.org/trunk@47058


git-svn-id: http://core.svn.wordpress.org/trunk@46858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-11 17:57:03 +00:00
Sergey Biryukov
6a3deacf86 Docs: Correct @return type for Theme_Upgrader::check_parent_theme_filter(). 
Props diddledan.
Fixes #48570.
Built from https://develop.svn.wordpress.org/trunk@47057


git-svn-id: http://core.svn.wordpress.org/trunk@46857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-11 02:46:05 +00:00
Sergey Biryukov
d3d630c98a Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button. 
Props garrett-eclipse.
Fixes #49139.
Built from https://develop.svn.wordpress.org/trunk@47047


git-svn-id: http://core.svn.wordpress.org/trunk@46847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-07 00:09:04 +00:00
Sergey Biryukov
667f26b3af I18N: Replace php.ini, post_max_size, and upload_max_filesize with placeholders in "File is empty" error message. 
Props ramiy.
Fixes #48868.
Built from https://develop.svn.wordpress.org/trunk@47043


git-svn-id: http://core.svn.wordpress.org/trunk@46843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-06 16:16:03 +00:00
Sergey Biryukov
6a3a0b519c Docs: Fix typo in media_post_single_attachment_fields_to_edit() description. 
Props mukesh27.
Fixes #49131.
Built from https://develop.svn.wordpress.org/trunk@47039


git-svn-id: http://core.svn.wordpress.org/trunk@46839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-04 18:00:06 +00:00
Sergey Biryukov
8ec3da8a25 Site Health: Fix typo in a variable name in js/_enqueues/admin/site-health.js. 
Props nickylimjj.
Fixes #49112.
Built from https://develop.svn.wordpress.org/trunk@47031


git-svn-id: http://core.svn.wordpress.org/trunk@46831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-02 12:11:02 +00:00
Sergey Biryukov
6357cae029 Docs: Fix typo in _crop_image_resource() DocBlock. 
Props mukesh27.
Fixes #49103.
Built from https://develop.svn.wordpress.org/trunk@47024


git-svn-id: http://core.svn.wordpress.org/trunk@46824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-31 12:34:01 +00:00
Sergey Biryukov
7970e62c06 Coding Standards: Fix WPCS issue in [47015]. 
See #49082.
Built from https://develop.svn.wordpress.org/trunk@47016


git-svn-id: http://core.svn.wordpress.org/trunk@46816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-26 15:53:02 +00:00
Sergey Biryukov
7c2275dfe4 Docs: Fix typo in wp_dashboard_cached_rss_widget() documentation. 
Props mukesh27.
Fixes #49082.
Built from https://develop.svn.wordpress.org/trunk@47015


git-svn-id: http://core.svn.wordpress.org/trunk@46815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-26 14:42:03 +00:00
Sergey Biryukov
bb70f4e530 Docs: Correct the note about the CORE_UPGRADE_SKIP_NEW_BUNDLED constant in $_new_bundled_files global description. 
In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`.

Follow-up to [39064].

Props tomgreer, knutsp, crdunst.
See #49056.
Built from https://develop.svn.wordpress.org/trunk@47007


git-svn-id: http://core.svn.wordpress.org/trunk@46807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-23 18:00:02 +00:00
Sergey Biryukov
246a035d99 Docs: Improve documentation for admin menu functions: 
* `get_admin_page_parent()`
* `get_admin_page_title()`
* `get_plugin_page_hook()`
* `get_plugin_page_hookname()`
* `user_can_access_admin_page()`

Add missing descriptions and `@since` tags.

Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov.
Fixes #44253, #49067.
Built from https://develop.svn.wordpress.org/trunk@47006


git-svn-id: http://core.svn.wordpress.org/trunk@46806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-23 14:36:04 +00:00
Sergey Biryukov
f501814eac Upgrade/Install: When creating the .htaccess file in insert_with_markers(), make sure it has 0644 as a minimum set of permissions. 
Props rcutmore, dd32, i3anaan.
Fixes #40572.
Built from https://develop.svn.wordpress.org/trunk@47005


git-svn-id: http://core.svn.wordpress.org/trunk@46805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-22 02:45:03 +00:00
Sergey Biryukov
4edec193bc Users: When creating the first user on installation, populate the Website profile field with the site URL. 
Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites.

Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat.
Fixes #35778.
Built from https://develop.svn.wordpress.org/trunk@46989


git-svn-id: http://core.svn.wordpress.org/trunk@46789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-18 02:26:03 +00:00
Sergey Biryukov
bbd898b1dd Upgrade/Install: Remove unused global in upgrade_430_fix_comments(). 
Props adnan.limdi.
Fixes #41970.
Built from https://develop.svn.wordpress.org/trunk@46972


git-svn-id: http://core.svn.wordpress.org/trunk@46772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 16:45:03 +00:00
Andrew Ozz
c67c3ee6a0 Fix the colors in all color schemes for the .active class for buttons. 
Props ryelle, audrasjb.
Fixes #49003 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46967


git-svn-id: http://core.svn.wordpress.org/trunk@46767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-17 00:15:03 +00:00
Sergey Biryukov
8894c0f1a2 Coding Standards: Use strict comparison in wp-admin/widgets.php. 
Props jenilk.
Fixes #49000.
Built from https://develop.svn.wordpress.org/trunk@46964


git-svn-id: http://core.svn.wordpress.org/trunk@46764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 12:55:03 +00:00
Sergey Biryukov
5b9fd2d7e7 Coding Standards: Use strict comparison in wp-admin/includes/network.php. 
Props ataurr.
Fixes #48994.
Built from https://develop.svn.wordpress.org/trunk@46963


git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-16 12:37:06 +00:00
Sergey Biryukov
6d40400756 Coding Standards: Use strict comparison in wp-admin/edit-tags.php. 
Props passoniate.
Fixes #48985.
Built from https://develop.svn.wordpress.org/trunk@46962


git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 10:46:02 +00:00
Sergey Biryukov
087282e810 Coding Standards: Use strict comparison in wp-admin/term.php. 
Props vinita29.
Fixes #48983.
Built from https://develop.svn.wordpress.org/trunk@46961


git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 09:45:01 +00:00
Sergey Biryukov
0b8438a6d2 I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders. 
Props ramiy.
Fixes #48863.
Built from https://develop.svn.wordpress.org/trunk@46957


git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-13 21:27:05 +00:00
Sergey Biryukov
db18e7d50b Upgrade/Install: Improve the appearance of language selection on install: 
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Fixes #48927.
Built from https://develop.svn.wordpress.org/trunk@46887


git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 23:03:03 +00:00
Sergey Biryukov
9b91ffde04 Docs: Improve documentation for wp_dashboard_browser_nag() and dashboard_browser_nag_class(). 
Props grapplerulrich.
Fixes #48932.
Built from https://develop.svn.wordpress.org/trunk@46880


git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 10:59:05 +00:00
Sergey Biryukov
6ddf02b188 Menus: Avoid a PHP warning in add_submenu_page() when the same value is passed for both $parent_slug and $menu_slug parameters. 
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599.
Built from https://develop.svn.wordpress.org/trunk@46868


git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 21:03:02 +00:00
Sergey Biryukov
a209908501 Administration: Standardize form control height and alignment across the admin. 
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420.
Built from https://develop.svn.wordpress.org/trunk@46866


git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 20:26:03 +00:00
Sergey Biryukov
dd47d5aa81 Media: Use consistent width for Scale and Crop inputs. 
Follow-up to [46359].

Props sabernhardt, audrasjb.
Fixes #48907.
Built from https://develop.svn.wordpress.org/trunk@46856


git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:23:02 +00:00
Sergey Biryukov
9648c368f0 Help/About: Add a hover effect for links on About pages. 
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582.
Built from https://develop.svn.wordpress.org/trunk@46852


git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:31:05 +00:00
Sergey Biryukov
dcf0cb68a2 Administration: Correct checkbox width in list tables on smaller screens. 
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815.
Built from https://develop.svn.wordpress.org/trunk@46845


git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:26:02 +00:00
Sergey Biryukov
ac690426eb Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created. 
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409.
Built from https://develop.svn.wordpress.org/trunk@46842


git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:49:03 +00:00
John Blackbourn
d53103ed62 Docs: Further docblock corrections and improvements. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46826


git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 13:23:01 +00:00
John Blackbourn
f93ee2ca76 Docs: Increase the specificity of various docblock parameter types and return types. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46823


git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:43:04 +00:00
John Blackbourn
aa1fdcbd52 Docs: Correct various docblocks documentation. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46821


git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:23:04 +00:00
Aaron Jorbin
7d84502589 Text Changes: Rename Comment Blacklist option to be more inclusive 
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.

Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900.


Built from https://develop.svn.wordpress.org/trunk@46820


git-svn-id: http://core.svn.wordpress.org/trunk@46620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 18:12:02 +00:00
Sergey Biryukov
2165eef44c Accessibility: Administration: Correct active button color for the alternative color schemes. 
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598.
Built from https://develop.svn.wordpress.org/trunk@46817


git-svn-id: http://core.svn.wordpress.org/trunk@46617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 22:12:03 +00:00
Sergey Biryukov
20e18613d0 Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes. 
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585.
Built from https://develop.svn.wordpress.org/trunk@46815


git-svn-id: http://core.svn.wordpress.org/trunk@46615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-05 21:32:03 +00:00
Sergey Biryukov
38ad319fdf I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings. 
Props ramiy.
Fixes #48875.
Built from https://develop.svn.wordpress.org/trunk@46812


git-svn-id: http://core.svn.wordpress.org/trunk@46612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-04 10:36:01 +00:00
Sergey Biryukov
a5e52e04ee Docs: Move the canonical DocBlock for handle_bulk_actions-{$screen} action to wp-admin/edit.php. 
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.

Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857.
Built from https://develop.svn.wordpress.org/trunk@46811


git-svn-id: http://core.svn.wordpress.org/trunk@46611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-03 13:58:05 +00:00
Andrew Ozz
135e608b46 Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original. 
Fixes #48736.
Built from https://develop.svn.wordpress.org/trunk@46809


git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-01 18:26:05 +00:00
Sergey Biryukov
0221a593b9 Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile. 
Props donmhico, jeremyfelt.
Fixes #48799.
Built from https://develop.svn.wordpress.org/trunk@46807


git-svn-id: http://core.svn.wordpress.org/trunk@46607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-30 00:42:01 +00:00
Sergey Biryukov
1d1c74385f REST API: Use strict in_array() checks for the list of usernames blacklisted via illegal_user_logins filter. 
See #48839.
Built from https://develop.svn.wordpress.org/trunk@46804


git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 22:04:02 +00:00
Sergey Biryukov
2a0489ec49 Docs: Replace @returns tags in JS docs with @return. 
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

See #48303.
Built from https://develop.svn.wordpress.org/trunk@46800


git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 18:01:03 +00:00
Sergey Biryukov
4a4afbd68c Docs: Add missing full stops to @returns tags in JS docs, per the documentation standards. 
Props shital-patel, kalpshit.
Fixes #48305.
Built from https://develop.svn.wordpress.org/trunk@46799


git-svn-id: http://core.svn.wordpress.org/trunk@46599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-29 16:56:02 +00:00
Sergey Biryukov
acd0a3ca99 Site Health: Add a test for PHP default timezone. 
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692.
Built from https://develop.svn.wordpress.org/trunk@46797


git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-28 15:48:03 +00:00
Sergey Biryukov
6f86cedb09 Menus: Improve the wording of instructions for dragging the items into the preferred order. 
Props amolv, equin0x80, dlh.
Fixes #48184.
Built from https://develop.svn.wordpress.org/trunk@46791


git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 19:51:01 +00:00
Sergey Biryukov
d8b251f0af Administration: Properly wrap long titles in list tables on smaller screens. 
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805.
Built from https://develop.svn.wordpress.org/trunk@46790


git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-27 16:52:02 +00:00
Dominik Schilling
f4165a697d Upgrade/Install: Provide a default label for "Continue" button in language selection form. 
Prevents an empty continue button if a translation isn't yet available.

Props sathyapulse.
Fixes #48776.
Built from https://develop.svn.wordpress.org/trunk@46784


git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-26 15:19:04 +00:00
Sergey Biryukov
63fefb540a Users: Use correct variable when displaying the Additional Capabilities list in user profile. 
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725.
Built from https://develop.svn.wordpress.org/trunk@46782


git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-25 14:01:03 +00:00
Sergey Biryukov
2a85fe21d8 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: 
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.
Built from https://develop.svn.wordpress.org/trunk@46770


git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-24 19:57:05 +00:00
Sergey Biryukov
c786eaa1df Coding Standards: Fix WPCS issue in [46763]. 
See #48777.
Built from https://develop.svn.wordpress.org/trunk@46764


git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 19:21:03 +00:00
Sergey Biryukov
26a750e162 Docs: Add missing @since tags for functions in wp-admin/includes/update.php. 
Props sathyapulse, zodiac1978.
Fixes #48777.
Built from https://develop.svn.wordpress.org/trunk@46763


git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-23 18:51:01 +00:00
Sergey Biryukov
56af5db74f Editor: Improve the appearance of tag cloud in Tags meta box in classic editor. 
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592.
Built from https://develop.svn.wordpress.org/trunk@46758


git-svn-id: http://core.svn.wordpress.org/trunk@46558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-22 00:04:02 +00:00
Sergey Biryukov
44d5372825 I18N: Correct translator comment for By %s string in Plugins list table. 
Follow-up to [44541].

See #45898.
Built from https://develop.svn.wordpress.org/trunk@46755


git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-21 00:08:02 +00:00
Andrea Fercia
71725aeb95 Accessibility: Add an aria-current attribute to the Media Library switch links. 
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Fixes #48271.

Built from https://develop.svn.wordpress.org/trunk@46746


git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 16:51:02 +00:00
Andrea Fercia
eec579dd86 Widgets: Avoid to move focus to the Image Widget "Insert from URL" field. 
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169.

Props dufresnesteven.
See #43169.
Fixes #48588.

Built from https://develop.svn.wordpress.org/trunk@46745


git-svn-id: http://core.svn.wordpress.org/trunk@46545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 16:23:02 +00:00
Sergey Biryukov
306045277e Administration: Switch rgb() CSS property for paused plugin error message in Plugins list table to rgba(). 
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.

Props manikmist09.
Fixes #48629.
Built from https://develop.svn.wordpress.org/trunk@46744


git-svn-id: http://core.svn.wordpress.org/trunk@46544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-18 13:18:03 +00:00
Sergey Biryukov
5aa3a51264 Docs: Update broken source code link in WP_Filesystem_SSH2 class. 
Props mryoga, finchps.
Fixes #48467.
Built from https://develop.svn.wordpress.org/trunk@46742


git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-17 16:16:02 +00:00
Sergey Biryukov
418db0297e Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages. 
Props garrett-eclipse.
Fixes #48676.
Built from https://develop.svn.wordpress.org/trunk@46739


git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-17 07:43:01 +00:00
Sergey Biryukov
927aa4b44c Docs: Fix typo in wp_credits_section_title() description. 
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.

Props hareesh-pillai.
Fixes #48674.
Built from https://develop.svn.wordpress.org/trunk@46738


git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-16 21:04:01 +00:00
Sergey Biryukov
4ec53dc54c Docs: Remove incorrect @return tags. 
Props diddledan.
Fixes #48613, #48614.
Built from https://develop.svn.wordpress.org/trunk@46732


git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-14 09:57:03 +00:00
Sergey Biryukov
6ceb0279af Help/About: Move images to the CDN. 
Props ryelle.
Fixes #47708.
Built from https://develop.svn.wordpress.org/trunk@46724


git-svn-id: http://core.svn.wordpress.org/trunk@46524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-12 18:30:03 +00:00
Sergey Biryukov
2265c36568 Help/About: Update the 5.3 About page. 
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46709


git-svn-id: http://core.svn.wordpress.org/trunk@46509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 20:45:04 +00:00
Sergey Biryukov
ba249d8951 Help/About: Update the 5.3 About page. 
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.

Previously [46556], [46572], [46616].

Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46705


git-svn-id: http://core.svn.wordpress.org/trunk@46505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 16:07:03 +00:00
Sergey Biryukov
3d623995a8 Docs: In various @return tags, list the expected type first, instead of WP_Error. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46696


git-svn-id: http://core.svn.wordpress.org/trunk@46496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 02:43:03 +00:00
Sergey Biryukov
82dfb2d151 Docs: Miscellaneous docblock corrections in wp-admin/includes/plugin.php. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46695


git-svn-id: http://core.svn.wordpress.org/trunk@46495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-11 00:05:01 +00:00
Sergey Biryukov
2af39e45cb Docs: Improve documentation for deactivate_plugins() and activate_plugins(). 
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352.
Built from https://develop.svn.wordpress.org/trunk@46694


git-svn-id: http://core.svn.wordpress.org/trunk@46494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-10 23:05:03 +00:00
Sergey Biryukov
0e79d4d101 Coding Standards: Fix WPCS issue in [46684]. 
See #48255.
Built from https://develop.svn.wordpress.org/trunk@46687


git-svn-id: http://core.svn.wordpress.org/trunk@46487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 13:33:02 +00:00
Sergey Biryukov
1f816ad18d Docs: Use the {@see ...} tag for the replacement in @deprecated tags, so that Developer Reference could automatically link to the replacement. 
Props jrf.
See #48255.
Built from https://develop.svn.wordpress.org/trunk@46685


git-svn-id: http://core.svn.wordpress.org/trunk@46485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 13:05:02 +00:00
Sergey Biryukov
f60094679f Coding Standards: Consistently use do_action_deprecated() and apply_filters_deprecated() for deprecated hooks. 
Props jrf.
See #48255.
Built from https://develop.svn.wordpress.org/trunk@46684


git-svn-id: http://core.svn.wordpress.org/trunk@46484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 12:59:03 +00:00
Sergey Biryukov
ba21b391f6 Docs: Correct some inconsistencies in comments with Dashicon class references in wp-admin/css/customize-widgets.css. 
Prepend all class name references with `dashicons-` for clarity.

Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417.
Built from https://develop.svn.wordpress.org/trunk@46681


git-svn-id: http://core.svn.wordpress.org/trunk@46481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-09 00:03:02 +00:00
Sergey Biryukov
15a4289c8d Docs: Correct description for $recursive parameter of ::chmod() and ::delete() methods in WP_Filesystem implementations. 
Props skithund.
Fixes #48422.
Built from https://develop.svn.wordpress.org/trunk@46679


git-svn-id: http://core.svn.wordpress.org/trunk@46479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-08 22:56:02 +00:00
Andrew Ozz
60c2966222 Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in wp_get_missing_image_subsizes(). Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold. 
Props desrosj, azaozz.
Fixes #48518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46677


git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-07 18:51:02 +00:00
John Blackbourn
eda6a9e111 Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46662


git-svn-id: http://core.svn.wordpress.org/trunk@46462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:30:03 +00:00
Andrew Ozz
f9e81c83d5 Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image. 
Props ianmjones, azaozz.
Fixes #48453 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46658


git-svn-id: http://core.svn.wordpress.org/trunk@46458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 20:53:03 +00:00
Andrew Ozz
43ed67661a Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it. 
See #48472.
Built from https://develop.svn.wordpress.org/trunk@46651


git-svn-id: http://core.svn.wordpress.org/trunk@46451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 17:07:03 +00:00
Sergey Biryukov
8b76312eb3 Docs: Correct some array hash notations added in [46644]. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46647


git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 09:37:02 +00:00
John Blackbourn
b3d6acd6a4 Docs: Fix some incorrect return tags in docblocks. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46644


git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:23:01 +00:00
whyisjake
a87271af60 Login and Registration: Allow email logins to be more flexible. 
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.

Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@46640


git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 20:12:02 +00:00
desrosj
583e49d95f Customize: Formally deprecate unused Customizer classes. 
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.

Props weston.ruter, matthias-reuter, jrf.
Fixes #42364.
Built from https://develop.svn.wordpress.org/trunk@46637


git-svn-id: http://core.svn.wordpress.org/trunk@46437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 16:48:00 +00:00
Sergey Biryukov
2651ff3ae8 Docs: Update URLs in some @link tags and switch them to HTTPS. 
Props tsuyoring.
Fixes #48479.
Built from https://develop.svn.wordpress.org/trunk@46626


git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-01 14:57:02 +00:00
John Blackbourn
d1b23193dd Docs: Correct some incorrect docblock tags. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46623


git-svn-id: http://core.svn.wordpress.org/trunk@46420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-31 17:51:01 +00:00
Sergey Biryukov
3d76b537d6 Docs: Add @since tag for the $context parameter added to wp_generate_attachment_metadata filter in [46621]. 
See #48472.
Built from https://develop.svn.wordpress.org/trunk@46622


git-svn-id: http://core.svn.wordpress.org/trunk@46419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-31 00:13:01 +00:00
Andrew Ozz
ed651b17a4 Upload: 
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.

Fixes #48472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46621


git-svn-id: http://core.svn.wordpress.org/trunk@46418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-30 21:10:04 +00:00
desrosj
0b94025ba9 Help/About: Update the 5.3 About page for RC3. 
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46616


git-svn-id: http://core.svn.wordpress.org/trunk@46413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 20:10:04 +00:00
John Blackbourn
057f661ce3 Docs: Miscellaneous docblock corrections. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46610


git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 19:48:01 +00:00
John Blackbourn
c8f91f77ac Docs: Correct invalid hook docblocks. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46603


git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 19:11:02 +00:00
John Blackbourn
9e2b6902b3 Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46597


git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:16:04 +00:00
John Blackbourn
3caaa40fc6 Docs: Switch more docs over to typed array notation, plus some fixes. 
See #48303, #41756

Built from https://develop.svn.wordpress.org/trunk@46596


git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 21:09:04 +00:00
John Blackbourn
7c2b9f2a2e Docs: Miscellaneous docblock fixes and improvements. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46594


git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 20:43:04 +00:00
Sergey Biryukov
67ce1885db Docs: Improve formatting of various WP_Screen DocBlocks. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46591


git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:36:05 +00:00
Sergey Biryukov
67c73ea3ea Docs: Improve documentation for WP_Screen::add_help_tab(). 
Props atachibana.
Fixes #48395.
Built from https://develop.svn.wordpress.org/trunk@46590


git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:34:07 +00:00
Sergey Biryukov
49007e52bc Build/Test Tools: Add banner to RTL CSS and minified JS files. 
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.

This is a follow-up to [41271], which added the banner to minified CSS files.

Fixes #48424. See #30666.
Built from https://develop.svn.wordpress.org/trunk@46589


git-svn-id: http://core.svn.wordpress.org/trunk@46386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:17:07 +00:00
Sergey Biryukov
7e11e9d732 Posts, Post Types: Remove unintended change from [46578]. 
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46579


git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:54:03 +00:00
Sergey Biryukov
0b83bffd45 Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp. 
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46578


git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:51:03 +00:00
Andrea Fercia
5b85aa1936 Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241]. 
Props david.binda, audrasjb, azaozz.
See #34904.
Fixes #48396.

Built from https://develop.svn.wordpress.org/trunk@46575


git-svn-id: http://core.svn.wordpress.org/trunk@46372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-23 20:57:05 +00:00
desrosj
27994975f9 Help/About: Update the 5.3 About page for RC2. 
This includes numerous improvements:

- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.

Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46572


git-svn-id: http://core.svn.wordpress.org/trunk@46369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 19:19:07 +00:00
Sergey Biryukov
0609e04266 Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197]. 
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.
Built from https://develop.svn.wordpress.org/trunk@46570


git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 17:52:04 +00:00
Andrew Ozz
e1560cd1e0 Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append scaled- to the file names of the scaled images to make them easier to recognize. 
Props kraftbj, azaozz.
Fixes #48304.
Built from https://develop.svn.wordpress.org/trunk@46565


git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 21:43:04 +00:00
John Blackbourn
67104bb3f4 Administration: Revert changes to the admin menu styles for long line lengths. 
This reverts [46555], [46453], and [46332].

See #42201

Built from https://develop.svn.wordpress.org/trunk@46561


git-svn-id: http://core.svn.wordpress.org/trunk@46358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-17 18:38:03 +00:00
desrosj
1d6bd71ce4 Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing. 
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.

Follow up of [46455].

Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699.
Built from https://develop.svn.wordpress.org/trunk@46560


git-svn-id: http://core.svn.wordpress.org/trunk@46357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-16 21:03:02 +00:00
Andrea Fercia
44de60e8da Script Loader: Partially revert [46550] as it brought in unrelated CSS changes. 
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.

See #47069.

Built from https://develop.svn.wordpress.org/trunk@46559


git-svn-id: http://core.svn.wordpress.org/trunk@46356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-16 17:49:03 +00:00
John Blackbourn
2ab1e4dcd8 Help/About: Let's tell the world about 5.3. 
Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald

Thanks to everyone who provided feedback for this page for 5.3.

See #47708

Built from https://develop.svn.wordpress.org/trunk@46556


git-svn-id: http://core.svn.wordpress.org/trunk@46353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 20:42:03 +00:00
John Blackbourn
7cdb93a374 Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed. 
Props afercia, amolv, sabernhardt

Fixes #42201, #48294

Built from https://develop.svn.wordpress.org/trunk@46555


git-svn-id: http://core.svn.wordpress.org/trunk@46352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 19:39:01 +00:00
Andrea Fercia
02810533c4 Accessibility: Script Loader: Remove jQuery as dependency of admin-bar after [46440]. 
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.

See #47069.

Built from https://develop.svn.wordpress.org/trunk@46550


git-svn-id: http://core.svn.wordpress.org/trunk@46347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 17:23:04 +00:00
Andrew Ozz
1940cf7d54 Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging. 
Fixes #40439.
Built from https://develop.svn.wordpress.org/trunk@46507


git-svn-id: http://core.svn.wordpress.org/trunk@46304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 20:05:01 +00:00
Sergey Biryukov
b0e0f69b2e I18N: Don't capitalize "Extension" in update_core(), for consistency with other strings. 
Follow-up to [46455].

See #47699.
Built from https://develop.svn.wordpress.org/trunk@46464


git-svn-id: http://core.svn.wordpress.org/trunk@46262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 02:42:01 +00:00
Sergey Biryukov
e19329bad0 Docs: Add requires_php to the list of fields returned by plugins_api(). 
Props ediamin.
Fixes #48291.
Built from https://develop.svn.wordpress.org/trunk@46463


git-svn-id: http://core.svn.wordpress.org/trunk@46261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 02:35:04 +00:00
antpb
ebd52ce048 Administration: Prevents horizontal scroll jumping around while admin menu is open. 
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.

Built from https://develop.svn.wordpress.org/trunk@46460


git-svn-id: http://core.svn.wordpress.org/trunk@46258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 19:22:02 +00:00
Mike Schroder
66c8085fc4 Media: Update fallback previews to support _wp_make_subsizes() 
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.
Built from https://develop.svn.wordpress.org/trunk@46459


git-svn-id: http://core.svn.wordpress.org/trunk@46257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 07:54:03 +00:00
desrosj
c6d3987b08 Upgrade/Install: Detect the presence of the native PHP JSON extension before updating. 
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.
Built from https://develop.svn.wordpress.org/trunk@46455


git-svn-id: http://core.svn.wordpress.org/trunk@46253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 22:22:04 +00:00
whyisjake
ec02d199f4 Administration: Ensure visual consistency with large titles in the sidebar. 
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201

Built from https://develop.svn.wordpress.org/trunk@46453


git-svn-id: http://core.svn.wordpress.org/trunk@46251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 04:58:02 +00:00
Sergey Biryukov
8d1e51e9c7 Docs: Add a @since note about new parameters with the spread operator added to function signatures. 
Props jrf.
See #47678.
Built from https://develop.svn.wordpress.org/trunk@46451


git-svn-id: http://core.svn.wordpress.org/trunk@46249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 04:28:02 +00:00
Sergey Biryukov
843c39b9bc Themes: Properly align Close/Previous/Next icons in theme preview overlay. 
Props chetan200891.
Fixes #48248.
Built from https://develop.svn.wordpress.org/trunk@46444


git-svn-id: http://core.svn.wordpress.org/trunk@46242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 19:07:04 +00:00
Sergey Biryukov
93279742c1 Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu. 
Props chetan200891.
Fixes #48250.
Built from https://develop.svn.wordpress.org/trunk@46443


git-svn-id: http://core.svn.wordpress.org/trunk@46241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 18:49:03 +00:00
johnjamesjacoby
477f0ffd71 Network Admin: Improve Site States in List Table rows. 
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)

Fixes #37684. Props pbiron.
Built from https://develop.svn.wordpress.org/trunk@46441


git-svn-id: http://core.svn.wordpress.org/trunk@46239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 17:46:02 +00:00
Sergey Biryukov
760a55b310 Docs: Add missing @deprecated tags in the file docblock of some deprecated files. 
Props jrf.
Fixes #48254.
Built from https://develop.svn.wordpress.org/trunk@46439


git-svn-id: http://core.svn.wordpress.org/trunk@46237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 17:19:04 +00:00
Andrea Fercia
92f09c0496 Accessibility: Improve and modernize user interface controls: Revert the new links focus style. 
Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus.
It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle.
Partially reverts [46241] and [46293].

See #34904, #47153.

Built from https://develop.svn.wordpress.org/trunk@46425


git-svn-id: http://core.svn.wordpress.org/trunk@46223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 19:57:02 +00:00
Andrea Fercia
3a27f92158 Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class. 
- improves the buttons `.active` CSS class for buttons that need to be styled as "pressed"
- update the alternate color schemes `.active` CSS class accordingly
- improves a few icons colors in the alternate color schemes

See #34904.

Built from https://develop.svn.wordpress.org/trunk@46423


git-svn-id: http://core.svn.wordpress.org/trunk@46221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 18:47:05 +00:00
Andrew Ozz
f793398e4f Upload: Set custom header with the attachment ID for all uploads from media_handle_upload(). Let the REST API endpoint set it separately. 
Props timothyblynjacobs.
Fixes #48200.
Built from https://develop.svn.wordpress.org/trunk@46421


git-svn-id: http://core.svn.wordpress.org/trunk@46219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 15:30:02 +00:00
Andrea Fercia
e9065659f4 Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments. 
- improves input fields height in the customizer
- improves input fields height for Internet Explorer 11
- improves input fields height in the Image Editor
- improves alignment of selects and buttons in the privacy policy pages
- makes the search themes fields font-size consistent

Props garrett-eclipse, afercia.
See #47477.

Built from https://develop.svn.wordpress.org/trunk@46419


git-svn-id: http://core.svn.wordpress.org/trunk@46217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 13:20:03 +00:00
Andrea Fercia
1f3d583825 Accessibility: Media: Improve the search media field labelling. 
Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.

Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:

- users with cognitive disabilities may have trouble remembering what the filled field does
- speech recognition users cannot see the name they can speak to set focus on the field
- low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input

Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331.
Fixes #47138.

Built from https://develop.svn.wordpress.org/trunk@46418


git-svn-id: http://core.svn.wordpress.org/trunk@46216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 12:43:03 +00:00
whyisjake
ea5d76fbb2 Privacy: Ensure that sending email, and remove data follow the same user experience. 
Both personal data request processes should follow the same convention.

Fixes: #43974.
Props: garrett-eclipse, kjellr, Kerfred, birgire, marybaum, SergeyBiryukov.



Built from https://develop.svn.wordpress.org/trunk@46412


git-svn-id: http://core.svn.wordpress.org/trunk@46210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 06:56:02 +00:00
whyisjake
4269998771 Administration: Add a max-width to the Privacy Policy Page dropdown. 
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.

Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.

Built from https://develop.svn.wordpress.org/trunk@46411


git-svn-id: http://core.svn.wordpress.org/trunk@46209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 06:42:02 +00:00
Sergey Biryukov
554b60da76 Docs: Format comments in wp-admin/includes/plugin.php as per the documentation standards. 
Props dkarfa.
Fixes #48191.
Built from https://develop.svn.wordpress.org/trunk@46410


git-svn-id: http://core.svn.wordpress.org/trunk@46208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 02:23:03 +00:00
Aaron Jorbin
ebd841790b Build/Test: Update Grunt Uglify options 
Follow up to [46408]

Sometimes you need to take documentation literally. And sometimes you need to take it seriously. Deprecations and replacements in uglify are a case where I took them literally and should have taken them seriously.

See #48203.


Built from https://develop.svn.wordpress.org/trunk@46409


git-svn-id: http://core.svn.wordpress.org/trunk@46207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 22:01:04 +00:00