Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-16 15:46:04 +01:00
Code Issues Projects Releases Wiki Activity
40,048 Commits 50 Branches 748 Tags 792 MiB
29a6063f45
Commit Graph

40048 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andrea Fercia
7b45746001 Menus: Fix the Custom Links text fallback. 
When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".

The changes in [36379] broke this behavior making the fallback text: ` (Pending)`, with a leading space.

Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.

Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Fixes #38415.

Built from https://develop.svn.wordpress.org/trunk@45727


git-svn-id: http://core.svn.wordpress.org/trunk@45538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 12:19:56 +00:00
Andrea Fercia
2d60076e77 Accessibility: Improve the way emojis are announced by screen readers. 
Adds an ARIA `role="img"` to the emojis markup in the front end. While the ARIA role is technically redundant, it helps Safari and VoiceOver to properly announce the emojis as "image". Without the role, they announce a generic "group" role.
Tested with Safari 12.1.1 / VoiceOver 9.

Props pento.
See #37486.

Built from https://develop.svn.wordpress.org/trunk@45726


git-svn-id: http://core.svn.wordpress.org/trunk@45537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 11:53:56 +00:00
Andrea Fercia
9228eeb47b Accessibility: Fix the alt attribute of the Gallery images within the Classic Editor. 
Passes the images `alt` attribute value to the Gallery template used within the Classic Editor.

Props yarnboy, wpboss.
Fixes #47687.

Built from https://develop.svn.wordpress.org/trunk@45725


git-svn-id: http://core.svn.wordpress.org/trunk@45536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 11:36:53 +00:00
Sergey Biryukov
76f482de43 Posts, Post Types: Check the result of wp_update_post() in wp_trash_post() and wp_untrash_post(). 
Props abhijitrakas, manzoorwani.jk, siliconforks.
Fixes #47773.
Built from https://develop.svn.wordpress.org/trunk@45724


git-svn-id: http://core.svn.wordpress.org/trunk@45535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 03:47:54 +00:00
Sergey Biryukov
c26f1c5d90 Taxonomy: Fix deprecated calls to get_terms(). 
The taxonomy should be passed as part of `$args`, rather than as its own argument.

Props sgastard, mukesh27, SergeyBiryukov.
Fixes #47819.
Built from https://develop.svn.wordpress.org/trunk@45723


git-svn-id: http://core.svn.wordpress.org/trunk@45534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 03:35:56 +00:00
Andrea Fercia
60431f3c53 Customize: Make the color picker close when clicking on the empty area on the right. 
Props monikarao.
Fixes #47693.

Built from https://develop.svn.wordpress.org/trunk@45722


git-svn-id: http://core.svn.wordpress.org/trunk@45533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 17:09:57 +00:00
Sergey Biryukov
ad46ef7c06 Twenty Thirteen: Make twentythirteen_author_bio_template() use author templates if exist, fall back to regular template hierarchy otherwise. 
See #32096.
Built from https://develop.svn.wordpress.org/trunk@45721


git-svn-id: http://core.svn.wordpress.org/trunk@45532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 03:09:55 +00:00
Sergey Biryukov
b900e22629 Twenty Fifteen: Make twentyfifteen_author_bio_template() use author templates if exist, fall back to regular template hierarchy otherwise. 
See #32096.
Built from https://develop.svn.wordpress.org/trunk@45720


git-svn-id: http://core.svn.wordpress.org/trunk@45531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 03:08:55 +00:00
Sergey Biryukov
e2ea3f7f30 Twenty Thirteen: Prevent author-bio.php partial template from interfering with rendering an author archive of a user with the bio username. 
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
Fixes #32096.
Built from https://develop.svn.wordpress.org/trunk@45719


git-svn-id: http://core.svn.wordpress.org/trunk@45530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 02:34:52 +00:00
Sergey Biryukov
97f28973da Twenty Fifteen: Prevent author-bio.php partial template from interfering with rendering an author archive of a user with the bio username. 
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
See #32096.
Built from https://develop.svn.wordpress.org/trunk@45718


git-svn-id: http://core.svn.wordpress.org/trunk@45529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 02:33:57 +00:00
Sergey Biryukov
f6770efd94 Users: Clean user cache in check_password_reset_key() tests. 
Props davidbaumwald, spacedmonkey.
See #45845.
Built from https://develop.svn.wordpress.org/trunk@45717


git-svn-id: http://core.svn.wordpress.org/trunk@45528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 19:54:55 +00:00
Sergey Biryukov
65420d3c7a Users: Replace raw SQL query in check_password_reset_key() with get_user_by(). 
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845.
Built from https://develop.svn.wordpress.org/trunk@45716


git-svn-id: http://core.svn.wordpress.org/trunk@45527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 19:19:55 +00:00
Sergey Biryukov
ee5e044a2a Users: Use clean_user_cache() in wp_insert_user(), wp_update_user(), wp_set_password(), add_user_to_blog(). 
Props spacedmonkey.
Fixes #47021.
Built from https://develop.svn.wordpress.org/trunk@45715


git-svn-id: http://core.svn.wordpress.org/trunk@45526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 17:49:57 +00:00
Sergey Biryukov
75857aa857 Users: Use wp_update_user() in get_password_reset_key(). 
Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov.
Fixes #45746.
Built from https://develop.svn.wordpress.org/trunk@45714


git-svn-id: http://core.svn.wordpress.org/trunk@45525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 17:25:55 +00:00
Sergey Biryukov
f6189321e1 Users: Reorganize user_nicename, user_url, user_registered setting in wp_insert_user() for consistency with the order or fields in the database. 
See #45746.
Built from https://develop.svn.wordpress.org/trunk@45713


git-svn-id: http://core.svn.wordpress.org/trunk@45524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 17:13:57 +00:00
Sergey Biryukov
4a6461dcc2 Users: Use get_password_reset_key() in wp_new_user_notification(). 
Props mrasharirfan, spacedmonkey.
Fixes #45745.
Built from https://develop.svn.wordpress.org/trunk@45712


git-svn-id: http://core.svn.wordpress.org/trunk@45523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 15:30:58 +00:00
Sergey Biryukov
6623a824d0 Taxonomy: Correct some strict comparisons after [45710]. 
See #47573.
Built from https://develop.svn.wordpress.org/trunk@45711


git-svn-id: http://core.svn.wordpress.org/trunk@45522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 15:04:56 +00:00
Sergey Biryukov
3e1126d940 Coding Standards: Use strict comparison in wp-includes/taxonomy.php. 
Props andizer, SergeyBiryukov.
Fixes #47573.
Built from https://develop.svn.wordpress.org/trunk@45710


git-svn-id: http://core.svn.wordpress.org/trunk@45521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 13:45:56 +00:00
Sergey Biryukov
fd03949143 Coding Standards: Fix WPCS violations after [45708]. 
See #45747.
Built from https://develop.svn.wordpress.org/trunk@45709


git-svn-id: http://core.svn.wordpress.org/trunk@45520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 12:03:56 +00:00
Sergey Biryukov
b32cff72c2 Users: Deprecate update_user_status() in favor of wp_update_user(). 
Props spacedmonkey, SergeyBiryukov.
Fixes #45747.
Built from https://develop.svn.wordpress.org/trunk@45708


git-svn-id: http://core.svn.wordpress.org/trunk@45519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 11:28:54 +00:00
Sergey Biryukov
2d574d673f Database: Use a strict comparison for has_filter() check in wpdb::placeholder_escape(). 
The filter is added with a priority of `0`, so a loose comparison had an unintended effect of adding the filter on every call.

Props withinboredom.
Fixes #47430.
Built from https://develop.svn.wordpress.org/trunk@45707


git-svn-id: http://core.svn.wordpress.org/trunk@45518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 02:25:56 +00:00
K. Adam White
5f9ba92af4 REST API: Skip processing fields which are not present in the selected context. 
In `WP_REST_Controller::get_fields_for_response()`, exclude fields which are not registered to appear in the request's context.

In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit.

Props dlh.
Fixes #45605.

Built from https://develop.svn.wordpress.org/trunk@45706


git-svn-id: http://core.svn.wordpress.org/trunk@45517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 20:21:56 +00:00
K. Adam White
d296736b75 REST API: Generate sample permalink only when a dependent field is requested. 
The sample permalink will now only be generated if the derivative `permalink_template` or `generated_slug` fields are to be included in the response, preventing an unnecessary database request for each post (via `wp_unique_post_slug()`) when those fields are not requested.

Props dlh.
See #45605.

Built from https://develop.svn.wordpress.org/trunk@45705


git-svn-id: http://core.svn.wordpress.org/trunk@45516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 20:00:57 +00:00
Sergey Biryukov
ee23869c68 Docs: Correct parameter documentation for bulk_edit_custom_box and quick_edit_custom_box actions. 
Props abrain.
Fixes #47810.
Built from https://develop.svn.wordpress.org/trunk@45704


git-svn-id: http://core.svn.wordpress.org/trunk@45515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 15:10:58 +00:00
Sergey Biryukov
fec01b0685 Docs: Correct parameter type and description for is_email filter. 
Props jenkoian.
Fixes #47793.
Built from https://develop.svn.wordpress.org/trunk@45703


git-svn-id: http://core.svn.wordpress.org/trunk@45514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 01:26:54 +00:00
Sergey Biryukov
383c1df66b Docs: Correct @return value description for get_term_link(). 
Props garrett-eclipse.
Fixes #47806.
Built from https://develop.svn.wordpress.org/trunk@45702


git-svn-id: http://core.svn.wordpress.org/trunk@45513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 01:19:56 +00:00
Tammie Lister
d5c7657189 Media: Reduces the bulk media options to have one primary button 
This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov
Fixes #46757, #46758

Built from https://develop.svn.wordpress.org/trunk@45701


git-svn-id: http://core.svn.wordpress.org/trunk@45512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-30 23:20:57 +00:00
Tammie Lister
fa9980049e Admin: Improve Dashboard icon contrast. 
The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast.

Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr 
Fixes #46935

Built from https://develop.svn.wordpress.org/trunk@45700


git-svn-id: http://core.svn.wordpress.org/trunk@45511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-30 22:54:57 +00:00
Sergey Biryukov
c7493264a4 Rewrite Rules: Check if $wp_rewrite->flush_rules() is callable before calling it in flush_rewrite_rules(). 
Props bsetiawan88, markjaquith.
Fixes #47087.
Built from https://develop.svn.wordpress.org/trunk@45699


git-svn-id: http://core.svn.wordpress.org/trunk@45510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 17:52:56 +00:00
Sergey Biryukov
98642b4821 Users: Use case-insensitive email address comparison when checking whether "Grant this user super admin privileges" checkbox should be displayed on Edit User screen. 
Props trepmal.
Fixes #47119.
Built from https://develop.svn.wordpress.org/trunk@45698


git-svn-id: http://core.svn.wordpress.org/trunk@45509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 17:42:55 +00:00
Sergey Biryukov
ec8940edeb Coding Standards: Fix WPCS violations in wp-admin/includes/class-walker-nav-menu-edit.php. 
Props sudhiryadav, audrasjb.
Fixes #46902.
Built from https://develop.svn.wordpress.org/trunk@45697


git-svn-id: http://core.svn.wordpress.org/trunk@45508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:53:52 +00:00
Sergey Biryukov
c9942bb3d8 Coding Standards: Fix WPCS violations in [45694]. 
See #47466.
Built from https://develop.svn.wordpress.org/trunk@45696


git-svn-id: http://core.svn.wordpress.org/trunk@45507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:52:56 +00:00
Sergey Biryukov
e7abdc7040 Docs: Improve the DocBlocks for got_mod_rewrite(), extract_from_markers(), insert_with_markers(). 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@45695


git-svn-id: http://core.svn.wordpress.org/trunk@45506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:35:56 +00:00
Sergey Biryukov
67e5038470 Rewrite Rules: Add a comment to # BEGIN/END .htaccess markers to clarify that the directives are dynamically generated, and should only be modified via WordPress filters. 
Introduce `insert_with_markers_inline_instructions` filter to modify the default instructions text.

Props bradleyt, SergeyBiryukov.
Fixes #47466.
Built from https://develop.svn.wordpress.org/trunk@45694


git-svn-id: http://core.svn.wordpress.org/trunk@45505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:31:57 +00:00
Sergey Biryukov
7a4d1b5dbd Permalinks: Improve appearance of URL examples on Permalink Settings screen. 
Props luan-ramos, sarath.ar.
Fixes #41559.
Built from https://develop.svn.wordpress.org/trunk@45693


git-svn-id: http://core.svn.wordpress.org/trunk@45504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:11:56 +00:00
Sergey Biryukov
b95b055225 Administration: Allow breaking long strings in <code> tags at any point, to avoid overflowing on mobile. 
Props david.binda, mukesh27.
Fixes #47329.
Built from https://develop.svn.wordpress.org/trunk@45692


git-svn-id: http://core.svn.wordpress.org/trunk@45503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:09:55 +00:00
Sergey Biryukov
a59301c2ba Site Health: Consistently use wpdb::db_version() for checking the database server version, instead of partically replicating its functionality. 
Props Clorith, wpfed.
Fixes #47738.
Built from https://develop.svn.wordpress.org/trunk@45691


git-svn-id: http://core.svn.wordpress.org/trunk@45502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 14:55:57 +00:00
Dominik Schilling
182f813e24 I18N: Display the logged out message in the user's locale 
Built from https://develop.svn.wordpress.org/trunk@45690


git-svn-id: http://core.svn.wordpress.org/trunk@45501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 14:31:55 +00:00
Dominik Schilling
391d6a3f2b I18N: Following [45688], remove test for removed method. 
See #44865.
Built from https://develop.svn.wordpress.org/trunk@45689


git-svn-id: http://core.svn.wordpress.org/trunk@45500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 14:30:57 +00:00
Dominik Schilling
892a80d974 I18N: Use RTL stylesheets when running from /src. 
To run WordPress from /src you have to use the `--dev` flag which also builds the RTL stylesheets thus the admin notice and force to LTR is no longer required.

See #44492.
Fixes #44865.
Built from https://develop.svn.wordpress.org/trunk@45688


git-svn-id: http://core.svn.wordpress.org/trunk@45499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 14:17:57 +00:00
Dominik Schilling
4d3ca52c45 REST API: Pass current request object to rest_authentication_errors filter in WP_REST_Server::check_authentication(). 
Fixes #46907.
Built from https://develop.svn.wordpress.org/trunk@45687


git-svn-id: http://core.svn.wordpress.org/trunk@45498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 13:44:57 +00:00
Dominik Schilling
81bfb111d1 Tools: Remove internationalization tools (also known as makepot.php). 
It has been a great pleasure to work with `makepot.php` over the past [https://i18n.trac.wordpress.org/changeset/4169/ 11 years] but now it's time to say goodbye.
The tools have been integrated into WP-CLI as [https://developer.wordpress.org/cli/commands/i18n/make-pot/ wp i18n make-pot] and [https://developer.wordpress.org/cli/commands/i18n/make-json/ wp i18n make-json]. The new commands were optimized to support current PHP versions and are more flexible and reliable when extracting strings for PHP, and JavaScript.

Access to the old tools continue to exist in previous branches or at https://i18n.svn.wordpress.org/tools/.

Fixes #45287.
Built from https://develop.svn.wordpress.org/trunk@45686


git-svn-id: http://core.svn.wordpress.org/trunk@45497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 13:10:56 +00:00
Dominik Schilling
8059b362e8 I18N: Add support for custom WP_PLUGIN_URL in load_script_textdomain(). 
Plugins may not be on the same host/path as the rest of the content. To support loading translations for this setup check if the script source matches `plugins_url()`.
Also fixes an undefined index notice when a custom content URL has no path.

Props odminstudios, ocean90.
Fixes #46336, #46387.
Built from https://develop.svn.wordpress.org/trunk@45685


git-svn-id: http://core.svn.wordpress.org/trunk@45496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 12:44:56 +00:00
Sergey Biryukov
0af752e360 Accessibility: Toolbar: Make the min-width value for #wpadminbar at 782px breakpoint consistent with that of <body>. 
This ensures that the "My Account" toolbar item stays visible at high zoom levels.

Props isabel_brison, chetan200891.
Fixes #47603.
Built from https://develop.svn.wordpress.org/trunk@45684


git-svn-id: http://core.svn.wordpress.org/trunk@45495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 22:04:55 +00:00
Sergey Biryukov
f933abef11 Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests. 
Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607.
Built from https://develop.svn.wordpress.org/trunk@45683


git-svn-id: http://core.svn.wordpress.org/trunk@45494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 17:46:56 +00:00
Sergey Biryukov
5cdbe22b16 Administration: Merge CSS rules for #adminmenu .wp-submenu a in one place. 
Props ozmatflc, AkSDvP.
Fixes #47780.
Built from https://develop.svn.wordpress.org/trunk@45682


git-svn-id: http://core.svn.wordpress.org/trunk@45493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 13:49:57 +00:00
Sergey Biryukov
33b2fbc7e7 REST API: Make "Could not update meta value in database" error messages more helpful. 
Props apermo, AkSDvP.
Fixes #46252.
Built from https://develop.svn.wordpress.org/trunk@45681


git-svn-id: http://core.svn.wordpress.org/trunk@45492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 13:20:56 +00:00
Sergey Biryukov
e925997562 Site Health: Show parent theme in its own accordion on Site Health Info screen; rename "Other Themes" to "Inactive Themes". 
Props garrett-eclipse, mukesh27, Clorith, xkon, msaggiorato.
Fixes #46925.
Built from https://develop.svn.wordpress.org/trunk@45680


git-svn-id: http://core.svn.wordpress.org/trunk@45491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 03:49:55 +00:00
Sergey Biryukov
dae07c8216 Coding Standards: Fix newlines in wp-includes/date.php. 
See #47775.
Built from https://develop.svn.wordpress.org/trunk@45679


git-svn-id: http://core.svn.wordpress.org/trunk@45490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 00:12:55 +00:00
Sergey Biryukov
cff445d55f Coding Standards: Move wp-includes/date.php to wp-includes/class-wp-date-query.php. 
This renames the file containing the `WP_Date_Query` class to conform to the coding standards.

This commit also includes:

- A new `date.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

Fixes #47775. See #47632.
Built from https://develop.svn.wordpress.org/trunk@45678


git-svn-id: http://core.svn.wordpress.org/trunk@45489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 23:31:56 +00:00