Peter Wilson
0d39b35c11
General: Replace Cheatin’ uh?
with friendlier error messages.
...
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.
Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332 .
Built from https://develop.svn.wordpress.org/trunk@42648
git-svn-id: http://core.svn.wordpress.org/trunk@42477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-05 02:30:34 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
John Blackbourn
67c973f95e
Docs: Correct parameter type documentation for various __call()
methods.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42151
git-svn-id: http://core.svn.wordpress.org/trunk@41982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-10 22:56:47 +00:00
Peter Wilson
339d838475
Comments: Check if wp_new_comment()
returns an error.
...
Adds checks throughout to allow for `wp_new_comment()` returning a `WP_Error` instance.
Updates the docs for the `pre_comment_approved` filter to include that it can be passed an error.
Props enrico.sorcinelli, ryotsun.
Fixes #39730 .
Built from https://develop.svn.wordpress.org/trunk@41980
git-svn-id: http://core.svn.wordpress.org/trunk@41814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-23 22:12:51 +00:00
Sergey Biryukov
0afafb7a1b
I18N: Unify error messages in XML-RPC methods wp_deleteCategory()
and wp_deleteComment()
.
...
Props ramiy.
Fixes #39019 .
Built from https://develop.svn.wordpress.org/trunk@41927
git-svn-id: http://core.svn.wordpress.org/trunk@41761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 21:12:51 +00:00
Sergey Biryukov
b8edb91f43
I18N: Merge two similar "Cannot set parent term" error strings.
...
Props ramiy.
Fixes #41637 .
Built from https://develop.svn.wordpress.org/trunk@41574
git-svn-id: http://core.svn.wordpress.org/trunk@41407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-22 22:08:46 +00:00
Sergey Biryukov
bcb126292c
I18N: Merge two similar error strings.
...
Props ramiy.
Fixes #39172 .
Built from https://develop.svn.wordpress.org/trunk@41572
git-svn-id: http://core.svn.wordpress.org/trunk@41405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-22 20:55:45 +00:00
Drew Jaynes
0860bb2771
Docs: Remove @access
notations from method DocBlocks in wp-includes/* classes.
...
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.
See #41452 .
Built from https://develop.svn.wordpress.org/trunk@41162
git-svn-id: http://core.svn.wordpress.org/trunk@41002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-27 00:41:44 +00:00
Sergey Biryukov
e8e68a50f8
Docs: Correct $term_id
parameter description in wp_xmlrpc_server::get_term_custom_fields()
and ::set_term_custom_fields()
.
...
Props upadalavipul.
Fixes #41397 .
Built from https://develop.svn.wordpress.org/trunk@41114
git-svn-id: http://core.svn.wordpress.org/trunk@40954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-21 13:40:43 +00:00
Drew Jaynes
1d95dcfa2c
Docs: Remove superfluous @package WordPress
and @subpackage
notations used outside of file headers in a variety of core files.
...
Per the inline documentation standards for PHP, there should only be one `@package` and/or `@subpackage` notation per file, and only in the file header.
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40988
git-svn-id: http://core.svn.wordpress.org/trunk@40838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:58:42 +00:00
Boone Gorges
92175dbd33
Add term meta support to XML-RPC addTerm
and editTerm
endpoints.
...
This changeset also includes the new function `has_term_meta()`, a
counterpart to `has_meta()` (for posts).
Props enrico.sorcinelli.
Fixes #35991 .
Built from https://develop.svn.wordpress.org/trunk@40916
git-svn-id: http://core.svn.wordpress.org/trunk@40766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-18 10:40:46 +00:00
Pascal Birchler
3d95e3ae81
Adjust post meta checks
...
Built from https://develop.svn.wordpress.org/trunk@40692
git-svn-id: http://core.svn.wordpress.org/trunk@40555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 08:46:42 +00:00
Pascal Birchler
e88a48a066
Whitelist post arguments in XML-RPC
...
Built from https://develop.svn.wordpress.org/trunk@40677
git-svn-id: http://core.svn.wordpress.org/trunk@40540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 08:09:42 +00:00
Sergey Biryukov
dca7d8d0ea
Text Changes: Merge strings referring to list_users
capability.
...
See #38857 .
Built from https://develop.svn.wordpress.org/trunk@39312
git-svn-id: http://core.svn.wordpress.org/trunk@39252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-19 02:16:30 +00:00
Sergey Biryukov
acc30b09d7
Text Changes: Merge some duplicate strings with the same meaning in error messages, adjust some other strings for consistency and accuracy.
...
Props ramiy, SergeyBiryukov.
Fixes #38808 .
Built from https://develop.svn.wordpress.org/trunk@39278
git-svn-id: http://core.svn.wordpress.org/trunk@39218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-17 15:53:33 +00:00
John Blackbourn
8c811f8f90
XML-RPC: Correctly handle empty and duplicate comments.
...
This prevents `wp_die()` being sent in response to an XML-RPC call that attempts to submit a duplicate comment, and correctly returns an error in response to an attempt to submit an empty comment.
Props markoheijnen, websupporter.
Fixes #14452 , #38466 .
See #36901
Built from https://develop.svn.wordpress.org/trunk@39045
git-svn-id: http://core.svn.wordpress.org/trunk@38987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-31 01:27:31 +00:00
Jeremy Felt
a4e98f7cb9
Multisite: Replace get_blog_details()
in wp_xmlrpc_server::_multisite_getUsersBlogs()
.
...
Use `get_site()` instead.
Props flixos90.
Fixes #38350 .
Built from https://develop.svn.wordpress.org/trunk@38934
git-svn-id: http://core.svn.wordpress.org/trunk@38877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-25 22:54:35 +00:00
Jeremy Felt
1560fbcbc5
Multisite: Use get_network()
and get_current_network_id()
for current network data.
...
`get_network()` falls back to the current network when called without any arguments. Between this and `get_current_network_id()`, we can replace almost all instances of the global `$current_site` and all instances of `get_current_site()`.
This effectively deprecates `get_current_site()`, something that we'll do in a future ticket.
Props flixos90.
Fixes #37414 .
Built from https://develop.svn.wordpress.org/trunk@38814
git-svn-id: http://core.svn.wordpress.org/trunk@38757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-19 04:47:30 +00:00
Gary Pendergast
7c1cb69e7a
XML-RPC: Re-add a global $wpdb
missed in [38768].
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38775
git-svn-id: http://core.svn.wordpress.org/trunk@38718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-11 01:43:31 +00:00
Gary Pendergast
af69f4ab1a
General: Restore usage of $wpdb
, instead of $this->db
.
...
Hiding the `$wpdb` global behind a property decreases the readability of the code, as well as causing irrelevant output when dumping an object.
Reverts [38275], [38278], [38279], [38280], [38387].
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38768
git-svn-id: http://core.svn.wordpress.org/trunk@38711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-10 06:38:31 +00:00
Pascal Birchler
ef8f9168b6
Taxonomy: Introduce WP_Taxonomy
and use it in register_taxonomy()
and unregister_taxonomy()
.
...
This changes the global `$wp_taxonomies` to an array of `WP_Taxonomy ` objects. `WP_Taxonomy ` includes methods to handle rewrite rules and hooks.
Each taxonomy argument becomes a property of `WP_Taxonomy`. Introducing such a class makes further improvements in the future much more feasible.
Props boonebgorges for review.
Fixes #36224 . See #36217 .
Built from https://develop.svn.wordpress.org/trunk@38747
git-svn-id: http://core.svn.wordpress.org/trunk@38690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-07 17:12:29 +00:00
John Blackbourn
b84023ea33
Taxonomy: Introduce more fine grained capabilities for managing taxonomy terms.
...
This introduces the singular `edit_term`, `delete_term`, and `assign_term` meta capabilities for terms, and switches the base capability name for tags from `manage_categories` to `manage_post_tags` and the corresponding `edit_post_tags`, `delete_post_tags`, and `assign_post_tags`.
All of these capabilities ultimately map to `manage_categories` so by default there is no change in the behaviour of the capabilities for categories, tags, or custom taxonomies. The `map_meta_cap` filter and the `capabilities` argument when registering a taxonomy now allow for control over editing, deleting, and assigning individual terms, as well as a separation of capabilities for tags from those of categories.
Fixes #35614
Props johnjamesjacoby for feedback
Built from https://develop.svn.wordpress.org/trunk@38698
git-svn-id: http://core.svn.wordpress.org/trunk@38641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-30 22:40:28 +00:00
Sergey Biryukov
788c3680f9
XML-RPC: Avoid a PHP notice in ::pingback_ping()
if page title was not found.
...
Props RedSand.
Fixes #36727 .
Built from https://develop.svn.wordpress.org/trunk@38620
git-svn-id: http://core.svn.wordpress.org/trunk@38563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-18 14:26:29 +00:00
Sergey Biryukov
d7f840a211
XML-RPC: Check the minimum number of arguments in ::wp_getUsersBlogs()
and ::blogger_getUsersBlogs()
.
...
Props kitchin for initial patch.
Fixes #29750 .
Built from https://develop.svn.wordpress.org/trunk@38600
git-svn-id: http://core.svn.wordpress.org/trunk@38543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-13 23:17:28 +00:00
Sergey Biryukov
e318b5bf1d
I18N: Add translator comments for XML-RPC strings with placeholders.
...
See #37792 .
Built from https://develop.svn.wordpress.org/trunk@38510
git-svn-id: http://core.svn.wordpress.org/trunk@38451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 04:13:28 +00:00
Aaron Jorbin
7a8f0f10ad
Text Changes: Improve Error messages in XML-RPC
...
Three changes to the error message strings:
* add some missing periods.
* merge similar translation strings.
* remove the "Something wrong happened" suffix.
Fixes #37792 .
Props ramiy.
Built from https://develop.svn.wordpress.org/trunk@38509
git-svn-id: http://core.svn.wordpress.org/trunk@38450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 03:57:28 +00:00
Scott Taylor
9383bf8f74
General: use get_bloginfo( 'version' )
instead of global $wp_version
in several locations - excluding those locations which reload version.php
mid-flight.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38459
git-svn-id: http://core.svn.wordpress.org/trunk@38400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 05:49:37 +00:00
Scott Taylor
e7ffad7fac
Query: add a protected
field, $db
, (composition, as it were) to WP_*_Query
classes to hold the value for the database abstraction, instead of importing the global $wpdb
into every method that uses it. Reduces the number of global imports by 32.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38275
git-svn-id: http://core.svn.wordpress.org/trunk@38216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-18 18:21:31 +00:00
Sergey Biryukov
7d421dbe42
Text Changes: Add a full stop to "Invalid taxonomy" and "Invalid term ID" strings, for consistency with similar post-related messages.
...
See #18218 , #32329 .
Built from https://develop.svn.wordpress.org/trunk@38077
git-svn-id: http://core.svn.wordpress.org/trunk@38018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 16:15:34 +00:00
Sergey Biryukov
866bd39813
I18N: Combine two duplicate "Invalid post type" strings.
...
Props @ramiy.
See #18218 .
Built from https://develop.svn.wordpress.org/trunk@38076
git-svn-id: http://core.svn.wordpress.org/trunk@38017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-17 16:05:31 +00:00
Drew Jaynes
60de6917fb
Docs: Add and clarify changelog entries for elements that can now accept, use, or return WP_Post_Type
objects.
...
Also adds a missing initial `@since` version for `wp_xmlrpc_server::_prepare_post_type()`.
See [37890]. See #36217 .
Built from https://develop.svn.wordpress.org/trunk@38051
git-svn-id: http://core.svn.wordpress.org/trunk@37992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-13 15:24:28 +00:00
Dominik Schilling
97bf32c66a
Text Changes: Unify/merge two more permission error messages.
...
Props ramiy.
Fixes #34521 .
Built from https://develop.svn.wordpress.org/trunk@38037
git-svn-id: http://core.svn.wordpress.org/trunk@37978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-12 11:45:29 +00:00
Dominik Schilling
1630c97795
Text Changes: Unify a few more permission error messages which were missed in [37914].
...
Props ramiy.
Fixes #34521 .
Built from https://develop.svn.wordpress.org/trunk@37999
git-svn-id: http://core.svn.wordpress.org/trunk@37940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-07 11:33:33 +00:00
Dominik Schilling
25e66e4f1e
Text Changes: Unify permission error messages.
...
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.
Props ramiy, Presskopp.
Fixes #34521 .
Built from https://develop.svn.wordpress.org/trunk@37914
git-svn-id: http://core.svn.wordpress.org/trunk@37855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-29 15:16:29 +00:00
Dominik Schilling
60dc856d64
Posts: Introduce WP_Post_Type
and use it in register_post_type()
and unregister_post_type()
.
...
This changes the global `$wp_post_types` to an array of `WP_Post_Type` objects. `WP_Post_Type` includes methods to handle post type supports, rewrite rules, meta boxes, hooks, and taxonomies.
Each post type argument becomes a property of `WP_Post_Type`.
Props swissspidy, flixos90.
Fixes #36217 .
Built from https://develop.svn.wordpress.org/trunk@37890
git-svn-id: http://core.svn.wordpress.org/trunk@37831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-28 16:41:35 +00:00
Peter Wilson
47d26cd9fb
DOCS: Replace HTTP links with HTTPS.
...
Replaces unsecure links in documentation and translator comments with their secure versions.
Props johnpgreen, netweb
Fixes #36993
Built from https://develop.svn.wordpress.org/trunk@37674
git-svn-id: http://core.svn.wordpress.org/trunk@37640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-10 04:50:33 +00:00
Drew Jaynes
fb6d8bae49
Docs: Apply inline @see
tags to hooks referenced in DocBlocks for core classes.
...
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.
See #36921 .
Built from https://develop.svn.wordpress.org/trunk@37539
git-svn-id: http://core.svn.wordpress.org/trunk@37507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 18:54:27 +00:00
Drew Jaynes
602b51a209
Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.
...
See #36913 .
Built from https://develop.svn.wordpress.org/trunk@37492
git-svn-id: http://core.svn.wordpress.org/trunk@37460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:15:28 +00:00
Drew Jaynes
f52a8cb1fa
Docs: Remove/replace invalid inline @link
tags in DocBlocks in wp-includes/*.
...
Fixes #36910 .
Built from https://develop.svn.wordpress.org/trunk@37487
git-svn-id: http://core.svn.wordpress.org/trunk@37455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 17:39:28 +00:00
Drew Jaynes
b1804afeaf
Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
...
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.
Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.
Props ocean90.
Fixes #36835 .
Built from https://develop.svn.wordpress.org/trunk@37431
git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 18:41:31 +00:00
Rachel Baker
470110ec3d
XMLRPC: Fix bug where draft posts couldn’t be published in the future, and would publish immediately.
...
Resolves bug introduced in [r34572], in which editing a Post via the XMLRPC API with a draft post_status, where the post_status changes from draft->publish with a future post_date set for the publish action, will have the future post_date disregarded and the Post will be published immediately. The expected behavior is that the post_date is used to schedule the Post to be published in the future.
Fixes #35874 .
Props redsweater, rachelbaker, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@37043
git-svn-id: http://core.svn.wordpress.org/trunk@37010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-22 15:10:28 +00:00
Drew Jaynes
a41f27a7f9
Docs: Clarify documentation for the xmlrpc_enabled
filter to better explain that its scope only extends to methods requiring authentication.
...
When the `xmlrpc_enabled` filter was initially introduced in [21509], it was effectively intended to replace the `enable_xmlrpc' UI option, which only controlled whether authenticated XML-RPC methods were enabled, such as for publishing actions. This change clarifies the expected behavior and adds information about ways to more granularly control XML-RPC method and request behavior with related hooks.
Part props mensmaximus.
See #21509 . Fixes #36055 .
Built from https://develop.svn.wordpress.org/trunk@37025
git-svn-id: http://core.svn.wordpress.org/trunk@36992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-17 03:53:26 +00:00
Sergey Biryukov
7c66e0648a
Comments: In wp_xmlrpc_server::pingback_ping()
:
...
* Rename `$linea` to `$remote_source` for clarity.
* Add `remote_source` to comment data, so it's available to `preprocess_comment` and `comment_post` filters.
* Pass the original (unfiltered) response source to the filters too (as `remote_source_original` in comment data).
Props dshanske for the original patch.
Fixes #34141 .
Built from https://develop.svn.wordpress.org/trunk@36661
git-svn-id: http://core.svn.wordpress.org/trunk@36628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-24 00:55:26 +00:00
Andrew Nacin
8090ae273d
XML-RPC: Revert [34681] as it broke date handling.
...
props dossy, hnle, redsweater.
see #35053 , #30429 (original ticket).
Built from https://develop.svn.wordpress.org/trunk@36163
git-svn-id: http://core.svn.wordpress.org/trunk@36129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 19:49:32 +00:00
Drew Jaynes
25eca6974e
Docs: Add a missing summary, @since
version, and parameter descriptions to the DocBlock for wp_xmlrpc_server::pingback_error()
.
...
Introduced in [23329]. Also corrects return descriptions for two deprecated methods.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35964
git-svn-id: http://core.svn.wordpress.org/trunk@35929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:38:27 +00:00
Drew Jaynes
7614bd71d3
Docs: Add a missing summary, @since
version, and parameter descriptions to the DocBlock for wp_xmlrpc_server::add_enclosure_if_new()
.
...
Introduced in [10383].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35963
git-svn-id: http://core.svn.wordpress.org/trunk@35928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:32:28 +00:00
Drew Jaynes
92dd7b7447
Docs: Add missing notations for the unused $args
parameter in the blogger_getTemplate()
and blogger_setTemplate()
methods in wp_xmlrpc_server
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35962
git-svn-id: http://core.svn.wordpress.org/trunk@35927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:26:28 +00:00
Drew Jaynes
fcd35518d9
Docs: Add a missing notation for the $args
parameter in the DocBlock for wp_xmlrpc_server::_multisite_getUsersBlogs()
.
...
Also adds a missing `@since` version. The method was introduced in [12852].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35957
git-svn-id: http://core.svn.wordpress.org/trunk@35921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:49:26 +00:00
Drew Jaynes
489023e001
Docs: Add a missing summary and @since
version to the DocBlock for wp_xmlrpc_server::serve_request()
.
...
Introduced in [11789].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35956
git-svn-id: http://core.svn.wordpress.org/trunk@35920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:43:26 +00:00
Scott Taylor
d8eacd51d8
Media: add a new image size, medium_large
. Bumps db version to add new options.
...
Adds unit tests.
Props DH-Shredder, joemcgill, azaozz.
Fixes #34196 .
Built from https://develop.svn.wordpress.org/trunk@35479
git-svn-id: http://core.svn.wordpress.org/trunk@35443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:50:25 +00:00
Dion Hulse
a579aad05b
XMLRPC: Prevent authentication from occuring after a failed authentication attmept in any single XML-RPC call.
...
This hardens WordPress against a common vector which uses multiple user identifiers in a single `system.multicall` call. In the event that authentication fails, all following authentication attempts ''in that call'' will also fail.
Props dd32, johnbillion.
Fixes #34336
Built from https://develop.svn.wordpress.org/trunk@35366
git-svn-id: http://core.svn.wordpress.org/trunk@35331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 04:46:24 +00:00
Drew Jaynes
217b661703
Docs: Add missing descriptions for the $wpdb
global in DocBlocks all the places.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35170
git-svn-id: http://core.svn.wordpress.org/trunk@35136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 23:44:25 +00:00
Scott Taylor
8c256a3357
XML-RPC: allow wp_xmlrpc_server::wp_getPosts()
to receive s
as a filter.
...
Props chriscct7.
Fixes #25406 .
Built from https://develop.svn.wordpress.org/trunk@34860
git-svn-id: http://core.svn.wordpress.org/trunk@34825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 13:41:26 +00:00
Sergey Biryukov
0aacea6535
Merge some strings with the same meaning in wp-includes/class-wp-xmlrpc-server.php
.
...
Props pavelevap.
Fixes #33644 .
Built from https://develop.svn.wordpress.org/trunk@34798
git-svn-id: http://core.svn.wordpress.org/trunk@34763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 14:09:43 +00:00
Scott Taylor
111c05ba47
XML-RPC: calculate the proper offset for GMT in wp.newPost
, mw.newPost
, and mw.editPost
when post_date
is set, wp.editComment
when comment_date
is set. post|comment_date
is assumed to be GMT. This is only true if the timezone string for the site matches GMT.
...
Adds unit tests for each.
Props smerriman, justdaiv, wonderboymusic.
Fixes #30429 .
Built from https://develop.svn.wordpress.org/trunk@34681
git-svn-id: http://core.svn.wordpress.org/trunk@34645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 04:05:24 +00:00
Scott Taylor
2c30a11518
After [34577], alter wp_xmlrpc_server::mw_newMediaObject()
to check upload space in multisite.
...
See #21292 .
Built from https://develop.svn.wordpress.org/trunk@34603
git-svn-id: http://core.svn.wordpress.org/trunk@34567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 19:49:25 +00:00
Scott Taylor
0405a03b5e
XML-RPC: in wp_xmlrpc_server::wp_editTerm()
, check ! empty
when applying parent
logic.
...
Adds unit tests.
Props hrishiv90, markoheijnen, sam2kb.
Fixes #21977 .
Built from https://develop.svn.wordpress.org/trunk@34580
git-svn-id: http://core.svn.wordpress.org/trunk@34544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 05:31:25 +00:00
Scott Taylor
80ac048cbc
XML-RPC: upgrade the resposnse ofwp_xmlrpc_server::mw_newMediaObject()
based on work down in 3.4 so that it runs the struct through ->_prepare_media_item()
.
...
Props markoheijnen.
Fixes #6430 .
Built from https://develop.svn.wordpress.org/trunk@34579
git-svn-id: http://core.svn.wordpress.org/trunk@34543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 05:15:25 +00:00
Scott Taylor
e9aa518f04
XML-RPC: move the malfunctioning 'overwrite' code from wp_xmlrpc_server::mw_newMediaObject()
. This was suggested 3 years ago.
...
Props markoheijnen.
Fixes #17604 .
Built from https://develop.svn.wordpress.org/trunk@34578
git-svn-id: http://core.svn.wordpress.org/trunk@34542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 05:03:24 +00:00
Scott Taylor
ffe7f0ec5a
XML-RPC: In wp_xmlrpc_server::wp_getComments()
, allow post_type
to be passed as part of $struct
.
...
Props nprasath002.
Fixes #20026 .
Built from https://develop.svn.wordpress.org/trunk@34575
git-svn-id: http://core.svn.wordpress.org/trunk@34539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 04:45:25 +00:00
Scott Taylor
c8b308a647
XML-RPC: In wp_xmlrpc_server::wp_getUsersBlogs()
, return the isPrimary
flag for each blog.
...
Props SergeyBiryukov, daniloercoli.
Fixes #25958 .
Built from https://develop.svn.wordpress.org/trunk@34574
git-svn-id: http://core.svn.wordpress.org/trunk@34538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 04:35:25 +00:00
Scott Taylor
9b253bbc7b
XML-RPC: In wp_xmlrpc_server::blogger_editPost()
, make use of the $publish
arg (the 6th arg passed to the method) to specify publish
or draft
. Restores the arg, which I removed in [31092], because it was unused cruft.
...
Props mdawaffe.
Fixes #10764 .
Built from https://develop.svn.wordpress.org/trunk@34573
git-svn-id: http://core.svn.wordpress.org/trunk@34537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 04:01:26 +00:00
Scott Taylor
dd1098e7c5
XML-RPC: In wp_xmlrpc_server::mw_newPost()
, if $dateCreated
is not set, don't set post_date
and post_date_gmt
. It calls wp_insert_post()
, which will handle it correctly. The problem was drafts being created and GMT date being set. It shouldn't be.
...
Adds unit test.
Fixes #16985 .
Built from https://develop.svn.wordpress.org/trunk@34572
git-svn-id: http://core.svn.wordpress.org/trunk@34536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 03:38:25 +00:00
Scott Taylor
a0ccd4eae8
XML-RPC: wp.getComments
should be allowed to return approved comments to those without the 'moderate_comments'
cap.
...
Adds (rewrites) unit tests from 4 years ago that we never committed because....
Props wonderboymusic, koke, ericmann, nprasath002.
Fixes #17981 .
Built from https://develop.svn.wordpress.org/trunk@34570
git-svn-id: http://core.svn.wordpress.org/trunk@34534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 02:49:27 +00:00
Scott Taylor
5ea01de963
XML-RPC: Introduce the concept of unit testing to wp_xmlrpc_server::wp_newComment()
:
...
* Don't allow comments to be created for posts that have `comment_status` set to `'closed'`
* Set some magic props on `WP_User` to vars before passing them to `wp_xmlrpc_server::escape()`
Props wonderboymusic, jesin.
Fixes #27471 .
Built from https://develop.svn.wordpress.org/trunk@34559
git-svn-id: http://core.svn.wordpress.org/trunk@34523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 20:20:23 +00:00
Scott Taylor
c871986819
Uploader: Fire 'wp_handle_upload' in wp_upload_bits()
. Thusly, the filter in wp_xmlrpc_server::mw_newMediaObject()
is redundant.
...
Props dllh.
Fixes #33539 .
Built from https://develop.svn.wordpress.org/trunk@34257
git-svn-id: http://core.svn.wordpress.org/trunk@34221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 04:46:25 +00:00
Dominik Schilling
e932a2dc5d
XMLRPC: Don't allow private posts to be sticky.
...
See #20662 .
Built from https://develop.svn.wordpress.org/trunk@34135
git-svn-id: http://core.svn.wordpress.org/trunk@34103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:38:23 +00:00
Scott Taylor
e73ee5ac98
Introduce WP_Comment
class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
...
* Takes inspiration from `WP_Post` and adds sanity to comment caching.
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now
Props wonderboymusic, nacin.
See #32619 .
Built from https://develop.svn.wordpress.org/trunk@33891
git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:17:24 +00:00
Sergey Biryukov
ce05b02a59
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/users.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679 . see #14530 .
Built from https://develop.svn.wordpress.org/trunk@33885
git-svn-id: http://core.svn.wordpress.org/trunk@33854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 08:54:24 +00:00
Sergey Biryukov
b136b074bf
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit.php
.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671 . see #14530 .
Built from https://develop.svn.wordpress.org/trunk@33861
git-svn-id: http://core.svn.wordpress.org/trunk@33829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 18:15:20 +00:00
Scott Taylor
ef87172270
foreach
is a statement, not a function.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33734
git-svn-id: http://core.svn.wordpress.org/trunk@33702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 20:28:22 +00:00
Scott Taylor
3982598305
Doc block for_wp_specialchars
: $quote_style
can also be string
('single' or 'double')
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33700
git-svn-id: http://core.svn.wordpress.org/trunk@33667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 18:36:24 +00:00
Drew Jaynes
02ec47fc92
Docs: Standardize @deprecated
tag formatting in the DocBlock for wp_xmlrpc_server::login_pass_ok()
.
...
Props Alphawolf.
See #28806 .
Built from https://develop.svn.wordpress.org/trunk@33677
git-svn-id: http://core.svn.wordpress.org/trunk@33644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 22:38:25 +00:00
Scott Taylor
45fc6a3def
Deprecate post_permalink()
(Introduced in 1.0, already had a deprecated argument in 1.3), which just wraps get_permalink()
and was only used by XML-RPC in 4 places.
...
Props solarissmoke.
Fixes #16982 .
Built from https://develop.svn.wordpress.org/trunk@33659
git-svn-id: http://core.svn.wordpress.org/trunk@33626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 06:24:26 +00:00
Scott Taylor
4a1f50f732
After [33325], supply a missing post_type
in ->mw_editPost()
.
...
Add unit test.
Props ocean90.
Fixes #20662 .
Built from https://develop.svn.wordpress.org/trunk@33612
git-svn-id: http://core.svn.wordpress.org/trunk@33579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-13 15:28:27 +00:00
Drew Jaynes
bed02906f2
Docs: Fix incorrect indentation for the wp_xmlrpc_server->wp_getPostFormats()
DocBlock.
...
Also adds a missing return description.
Props TomHarrigan.
Fixes #33078 .
Built from https://develop.svn.wordpress.org/trunk@33407
git-svn-id: http://core.svn.wordpress.org/trunk@33375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-23 13:19:27 +00:00
Scott Taylor
bf481ed496
After [33325], add a doc summary.
...
Fixes #20662 .
Built from https://develop.svn.wordpress.org/trunk@33343
git-svn-id: http://core.svn.wordpress.org/trunk@33315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 15:18:25 +00:00
Scott Taylor
432f9891f7
Ensure that private posts cannot be made sticky via Quick Edit.
...
DRY the logic for stickies in `wp_xmlrpc_server` by introducing `->_toggle_sticky()`.
Props wonderboymusic, obenland, chriscct7.
Fixes #20662 .
Built from https://develop.svn.wordpress.org/trunk@33325
git-svn-id: http://core.svn.wordpress.org/trunk@33297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 18:09:25 +00:00
Konstantin Obenland
a4e803fbd4
Use get_default_comment_status()
globally.
...
Also makes the filter name static and passes the post type for context.
Props valendesigns.
Fixes #31168 .
Built from https://develop.svn.wordpress.org/trunk@33054
git-svn-id: http://core.svn.wordpress.org/trunk@33025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 22:32:25 +00:00
Dion Hulse
2a35e075d7
XML-RPC: Only escape what we need to in wp.editPage
, this allows for passwords with the special characters "'
to work in a request.
...
Props redsweater for initial Patch.
Fixes #32703
Built from https://develop.svn.wordpress.org/trunk@32993
git-svn-id: http://core.svn.wordpress.org/trunk@32964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-29 02:07:23 +00:00
Scott Taylor
5c6b63d3a6
if
is a statment, not a function.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32800
git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:01:25 +00:00
Scott Taylor
f888767c73
$status
shouldn't be loosely compared to true
in wp_xmlrpc_server::wp_deleteComment()
.
...
`$initial` shouldn't be loosely compared to `true` in `get_calendar()`.
`current_user_can()` shouldn't be loosely compared to `false` in `kses_init()`
`$get_all` shouldn't be loosely compared to `true` in `get_blog_details()`.
`is_array()` and `in_array()` shouldn't be loosely compared in `wpmu_validate_user_signup()`.
`$result` should by strictly compared in `check_ajax_referer()`.
`wp_verify_nonce()` should by strictly compared in `_show_post_preview()`.
`is_user_logged_in()` should not be loosly compared against `false` in `wp-signup.php`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32733
git-svn-id: http://core.svn.wordpress.org/trunk@32704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:48:26 +00:00
Scott Taylor
c502a281bb
After [32656], add @access
annotations to methods that have no doc block in wp-includes/*
.
...
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32657
git-svn-id: http://core.svn.wordpress.org/trunk@32627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:37:24 +00:00
Scott Taylor
19b8ef0c92
get_comments()
can return int
, so a few places need to check if the return value is traversable before passing what is assumed to be an array
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32600
git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:59:25 +00:00
Drew Jaynes
4c37f68b79
Fix inline documentation syntax in wp_xmlrpc_server
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32591
git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:25:25 +00:00
Scott Taylor
bd8fafea54
Use void
instead of null
where appropriate when pipe-delimiting @return
types. If a @return
only contains void
, remove it.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32568
git-svn-id: http://core.svn.wordpress.org/trunk@32538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-24 05:40:25 +00:00
Drew Jaynes
459ccb0d8b
Add missing or incomplete argument and return descriptions for wp_xmlrpc_server->wp_editPost()
.
...
Also includes many small syntax fixes for inline documentation throughout the file.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32565
git-svn-id: http://core.svn.wordpress.org/trunk@32535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:47:25 +00:00
Drew Jaynes
2bebcf4c39
Add missing parameter and return descriptions to the DocBlock for wp_xmlrpc_server->_convert_date_gmt()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32564
git-svn-id: http://core.svn.wordpress.org/trunk@32534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:41:24 +00:00
Drew Jaynes
d94d97eab6
Add missing parameter and return descriptions to the DocBlock for wp_xmlrpc_server->_convert_date()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32563
git-svn-id: http://core.svn.wordpress.org/trunk@32533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:40:24 +00:00
Drew Jaynes
9f73a3351f
Fix inline documentation syntax in the DocBlock for wp_xmlrpc_server->_prepare_taxonomy()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32562
git-svn-id: http://core.svn.wordpress.org/trunk@32532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:38:25 +00:00
Drew Jaynes
8aa163e65a
Fix some inline documentation syntax in the DocBlock for wp_xmlrpc_server->minimum_args()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32561
git-svn-id: http://core.svn.wordpress.org/trunk@32531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:37:26 +00:00
Drew Jaynes
ebe60d1fc4
Use a valid parameter type of string for the $name
parameter in the xmlrpc_call
hook docs.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32560
git-svn-id: http://core.svn.wordpress.org/trunk@32530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:36:26 +00:00
Drew Jaynes
18066945ae
Add missing argument descriptions for the $args
hash notation in wp_xmlrpc_server->wp_getUsersBlogs()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@32559
git-svn-id: http://core.svn.wordpress.org/trunk@32529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:33:27 +00:00
Drew Jaynes
c76493d29b
Properly notate the inline link to the xmlrpc_blog_options
filter in the description for wp_xmlrpc_server->initialise_blog_option_info()
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@32558
git-svn-id: http://core.svn.wordpress.org/trunk@32528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:30:26 +00:00
Drew Jaynes
ed0421e7de
Add a proper return description for the wp_xmlrpc_server->addTwoNumbers()
method.
...
See [30181]. See #30224 .
Built from https://develop.svn.wordpress.org/trunk@32557
git-svn-id: http://core.svn.wordpress.org/trunk@32527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:26:26 +00:00
Drew Jaynes
7a93dda2d2
Add proper descriptions for the $methods
, $blog_options
, and $error
properties in wp_xmlrpc_server
.
...
See [30181]. See #30224 .
Built from https://develop.svn.wordpress.org/trunk@32556
git-svn-id: http://core.svn.wordpress.org/trunk@32526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:23:25 +00:00
Scott Taylor
ecf4c668b3
Upgrade the doc blocks in class-wp-xmlrpc-server.php
. Rehabilitate some unfortunate use of tabbing.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32550
git-svn-id: http://core.svn.wordpress.org/trunk@32520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 19:37:24 +00:00
Dominik Schilling
60c9fdf9fd
Merge similar error strings for invalid data.
...
props pavelevap.
fixes #32329 .
Built from https://develop.svn.wordpress.org/trunk@32477
git-svn-id: http://core.svn.wordpress.org/trunk@32447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 21:09:25 +00:00
Sergey Biryukov
7a6cba1308
Remove duplicate string with a typo, merge it with an existing string.
...
props pavelevap.
fixes #32020 .
Built from https://develop.svn.wordpress.org/trunk@32209
git-svn-id: http://core.svn.wordpress.org/trunk@32182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 15:27:25 +00:00
John Blackbourn
c996169c04
Correctly set the post author in wp_xmlrpc_server::mw_editPost()
when the current user is not the author of the post.
...
Props redsweater, markoheijnen, DrewAPicture
Fixes #24916
Built from https://develop.svn.wordpress.org/trunk@31983
git-svn-id: http://core.svn.wordpress.org/trunk@31962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 15:49:30 +00:00