Commit Graph

17136 Commits

Author SHA1 Message Date
John Blackbourn
2b596377be Build/Test Tools: Ensure the test_php_and_js_shortcode_attribute_regexes_match() test can run when testing using either the src or build directory.
Props alexstine, desrosj

See #51734

Built from https://develop.svn.wordpress.org/trunk@50501


git-svn-id: http://core.svn.wordpress.org/trunk@50114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 15:28:03 +00:00
Sergey Biryukov
497171a1c8 XML-RPC: Pass an empty array to the xmlrpc_call action in methods that have no arguments.
This avoids an "Undefined variable" PHP notice in the `::mt_supportedMethods()` and `::mt_supportedTextFilters()` methods.

Follow-up to [50353].

Props dd32.
Fixes #52524.
Built from https://develop.svn.wordpress.org/trunk@50499


git-svn-id: http://core.svn.wordpress.org/trunk@50112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 11:03:06 +00:00
noisysocks
328fa9858d Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 3.

See #52718.

Built from https://develop.svn.wordpress.org/trunk@50496


git-svn-id: http://core.svn.wordpress.org/trunk@50109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-05 04:10:44 +00:00
ryelle
22358d62ce Help/About: Clarify two strings.
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.

Props jdy68, audrasjb, marybaum, davidbaumwald.
See #52347.


Built from https://develop.svn.wordpress.org/trunk@50495


git-svn-id: http://core.svn.wordpress.org/trunk@50108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 19:10:06 +00:00
desrosj
d3324379f9 Twenty Twenty-One: Make text readable when dark background is selected for the Media & Text block.
This change ensures that the text in the Media & Text block is readable when dark background colors are selected.

This is a regression that was introduced in [49987].

Props hellofromTonya, poena, paaljoachim, ryelle.
Fixes #52702.
Built from https://develop.svn.wordpress.org/trunk@50493


git-svn-id: http://core.svn.wordpress.org/trunk@50106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 16:57:05 +00:00
Sergey Biryukov
290229ae07 Docs: Update inline comments in some test files per the documentation standards.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50491


git-svn-id: http://core.svn.wordpress.org/trunk@50104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 10:13:07 +00:00
Peter Wilson
4d2abda74a Roles/Caps: Return same result from current_user_can and user_can().
Ensure `current_user_can()` and `user_can()` return the same results for logged out users. For core capabilities this changes `user_can( 0, 'exist' )` to return `true` rather than `false` in line with `current_user_can( 'exist' )` for logged out users.

Convert `current_user_can()` and `current_user_can_for_blog()` to wrapper functions ultimately calling `user_can()`.

Add anonymous user to primitive capability checks as appropriate. Convert `Tests_User_Capabilities::test_other_caps_for_all_roles()` to use a data provider and add tests to check whether user exists in the database (`WP_User::exists()`) as that intentionally differs from the `exist` capability.

Props jjj, johnbillion, peterwilsoncc, SergeyBiryukov, TimothyBlynJacobs.
Fixes #52076.


Built from https://develop.svn.wordpress.org/trunk@50490


git-svn-id: http://core.svn.wordpress.org/trunk@50103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-04 00:14:04 +00:00
noisysocks
534bbf3f36 Block Editor: Fix color support for dynamic blocks
Changes wp_apply_colors_support to check for for color instead of
__experimentalColor when determining block support for color.

Props nosolosw, rafhun, youknowriad.
See #52709.

Built from https://develop.svn.wordpress.org/trunk@50488


git-svn-id: http://core.svn.wordpress.org/trunk@50101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 23:31:04 +00:00
desrosj
bbdc16d705 Build/Test Tools: Update some dependencies.
This updates the following `devDependencies`:

- `grunt-contrib-cssmin` from `3.0.0` to `4.0.0`.
- `uglify-js` from `3.12.8` to `3.13.0`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50487


git-svn-id: http://core.svn.wordpress.org/trunk@50100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 21:16:22 +00:00
desrosj
c082c48111 Build/Test Tools: Pin SHA versions to the remaining 3rd party actions.
This also adds inline comments to the end of each action installed using a SHA value to make it easier to determine which version of an action is currently being used.

Follow up to [50474,50476].

Props johnbillion.
See #52625.
Built from https://develop.svn.wordpress.org/trunk@50486


git-svn-id: http://core.svn.wordpress.org/trunk@50099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 20:31:06 +00:00
desrosj
2af9d4751a Build/Test Tools: Generalize the NPM test workflow.
The NPM test GitHub Actions workflow is currently used to verify that `npm install` and `npm run build` will complete successfully on Windows.

This generalizes the workflow and adds testing for Linux and MacOS to confirm that the scripts used to build WordPress also complete successfully in those environments.

Because MacOS workflow runs consume GHA minutes at a 10x rate, it’s added in a separate job in order to perform a more strict check.

This also adds steps to verify that using `npm run build:dev` and `npm run grunt clean`/`npm run grunt clean —dev` run successfully 

Props johnbillion.
Fixes #52658.
Built from https://develop.svn.wordpress.org/trunk@50485


git-svn-id: http://core.svn.wordpress.org/trunk@50098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 19:52:05 +00:00
Sergey Biryukov
4f61efe826 Docs: Update documentation in some WP_REST_Request tests per the documentation standards.
Follow-up to [49329].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@50484


git-svn-id: http://core.svn.wordpress.org/trunk@50097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-03 19:26:08 +00:00
Sergey Biryukov
3cdbafe164 Help/About: Clarify a string about lazy-loading iframes.
Props davidbaumwald, audrasjb, hellofromTonya.
See #52347.
Built from https://develop.svn.wordpress.org/trunk@50483


git-svn-id: http://core.svn.wordpress.org/trunk@50094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 21:38:03 +00:00
desrosj
679c86818b Build/Test Tools: Add path detection when running GitHub Actions on pull_request.
This change adds a list of paths to check when determining which workflows to run on `pull_request`. This will prevent certain workflows from running unnecessarily when the files updated are not related to the tests and checks being performed.

Props peterwilsoncc, johnbillion.
Fixes #52667.
Built from https://develop.svn.wordpress.org/trunk@50479


git-svn-id: http://core.svn.wordpress.org/trunk@50090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 19:59:03 +00:00
ryelle
f4f117144e Help/About: Iterate on the 5.7 About Page.
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.

Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Fixes #52693. See #52347.


Built from https://develop.svn.wordpress.org/trunk@50478


git-svn-id: http://core.svn.wordpress.org/trunk@50089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 19:50:04 +00:00
desrosj
37b71d9d40 Build/Test Tools: Change the cancel-workflow-action version to a SHA value.
Additionally, the `access_token` input now defaults to `github.token`, so specifying it is unnecessary.

Follow up to [50474].

Props johnbillion.
See #52625.
Built from https://develop.svn.wordpress.org/trunk@50476


git-svn-id: http://core.svn.wordpress.org/trunk@50087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 17:49:02 +00:00
Mike Schroder
34b0dc8023 Upgrade/Install: Invalidate OPcache for version.php during update.
Invalidate OPcache for `wp-content/version.php` on update individually, since it’s copied separately.

Props stodorovic, krstarica, cenay, desrosj, pbiron, sergeybiryukov, mikeschroder.
Fixes #51686, #51281.
See #36455.
Built from https://develop.svn.wordpress.org/trunk@50475


git-svn-id: http://core.svn.wordpress.org/trunk@50086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 17:13:03 +00:00
desrosj
a2a326b7cc Build/Test Tools: Pin the welcome-action to a specific commit SHA.
Some GitHub Action scripts require additional permissions to perform the desired operations. This permission is usually given by passing a personal access token (PAT) to the action as an input.

Because PATs grant access to sensitive information about the repository and actions with PATs become trusted actors, 3rd party actions should not be installed by specifying a major or minor version.

Instead, specifying a full length commit SHA will use the 3rd party action as an immutable release, ensuring the workflows within the repository are not affected by upstream security problems should they occur.

Props johnbillion.
See #52625.
Built from https://develop.svn.wordpress.org/trunk@50474


git-svn-id: http://core.svn.wordpress.org/trunk@50085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 16:11:04 +00:00
desrosj
39eb1e5ee0 Build/Test Tools: Run automated testing workflows for trunk branch.
This ensures a seamless transition when the primary branch is changed from `master` to `trunk` in the GitHub mirror. Once the transition is completed, the `master` branch can be removed.

See https://make.wordpress.org/systems/2021/03/02/update-git-wordpress-org-to-rename-master-to-trunk/ and https://make.wordpress.org/core/2020/06/18/proposal-update-all-git-repositories-to-use-main-instead-of-master/.

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50473


git-svn-id: http://core.svn.wordpress.org/trunk@50084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 15:28:05 +00:00
Sergey Biryukov
e1239d91a9 Security, Site Health: Do not store HTTPS request error messages in an option.
This changes the logic in `update_https_detection_errors()` to never store error messages from the actual request since they could use a different encoding, which would make storing them in an option potentially fail, leading WordPress to then falsely assume that HTTPS is supported.

While this doesn't actually fix the encoding issue, it is not crucial to do so anyway, since these messages are not used anywhere. A simple differentiation between whether the overall HTTPS request or only the SSL verification failed should be sufficient for the purpose of this function.

Props flixos90, tmatsuur, lukecarbis.
Fixes #52484.
Built from https://develop.svn.wordpress.org/trunk@50471


git-svn-id: http://core.svn.wordpress.org/trunk@50082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-02 15:08:09 +00:00
ryelle
c2f6f53b9b Twenty Twenty-One: Correct inner container background color for Cover Blocks.
Adjust the background color palette rules so they don't show up on inner containers when they're not supposed to:
- When an inner container block is present, it only applies them to direct children of the block with the background color assigned.
- Since the background color should only be applied to the Cover block's overlay, not to the inner container, it opts that specific block out of this rule.

Props dianeco, kjellr, paaljoachim.
Fixes #52676.


Built from https://develop.svn.wordpress.org/trunk@50466


git-svn-id: http://core.svn.wordpress.org/trunk@50077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 23:26:04 +00:00
ryelle
75d57e1379 Twenty Fifteen & Twenty Sixteen: Remove extra space around post editor.
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Props antonlukin, paaljoachim, felipeelia.
Fixes #52646.


Built from https://develop.svn.wordpress.org/trunk@50465


git-svn-id: http://core.svn.wordpress.org/trunk@50076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 21:58:08 +00:00
John Blackbourn
eb9496cdaf Build/Test Tools: Remove redundant teardown functionality from individual tests which is already covered in the base teardown method.
See #52625

Built from https://develop.svn.wordpress.org/trunk@50463


git-svn-id: http://core.svn.wordpress.org/trunk@50074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 18:44:07 +00:00
Aaron Jorbin
2ee126547e Disable comments from codecov.
Docs explaining this https://docs.codecov.io/docs/pull-request-comments#disable-comment

Putting inside .github to not litter the root. Docs explaining why this is possible https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml

Fixes #52684.


Built from https://develop.svn.wordpress.org/trunk@50462


git-svn-id: http://core.svn.wordpress.org/trunk@50073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 16:58:04 +00:00
TimothyBlynJacobs
a0d4e5e080 REST API: Correct error code for the maxItems keyword.
See [50007]. 

Built from https://develop.svn.wordpress.org/trunk@50461


git-svn-id: http://core.svn.wordpress.org/trunk@50072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 16:32:08 +00:00
Sergey Biryukov
69a0a68817 Docs: Clarify a comment about wp_opcache_invalidate() in _copy_dir().
Follow-up to [48160].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@50460


git-svn-id: http://core.svn.wordpress.org/trunk@50071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 10:38:05 +00:00
noisysocks
630a593765 Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 2.

Fixes #52680.

Built from https://develop.svn.wordpress.org/trunk@50458


git-svn-id: http://core.svn.wordpress.org/trunk@50069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-01 08:25:27 +00:00
Sergey Biryukov
30847f9125 Tests: Rename classes in phpunit/tests/l10n/ per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291], [50292], [50342], [50452], [50453].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50456


git-svn-id: http://core.svn.wordpress.org/trunk@50067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-28 17:24:03 +00:00
Sergey Biryukov
071336ebec Tests: Add missing @covers tags for files in phpunit/tests/load/.
Props sephsekla, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50455


git-svn-id: http://core.svn.wordpress.org/trunk@50066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-28 17:14:05 +00:00
Sergey Biryukov
0c41c86761 Tests: Add missing @covers tags for files in phpunit/tests/link/.
Props sephsekla, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50454


git-svn-id: http://core.svn.wordpress.org/trunk@50065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-28 17:11:05 +00:00
Sergey Biryukov
15059e0a68 Tests: Rename classes in phpunit/tests/load/ per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291], [50292], [50342], [50452].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50453


git-svn-id: http://core.svn.wordpress.org/trunk@50064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-28 13:44:05 +00:00
Sergey Biryukov
18af98a18b Tests: Rename some classes in phpunit/tests/link/ per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291], [50292], [50342].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50452


git-svn-id: http://core.svn.wordpress.org/trunk@50063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-28 13:41:03 +00:00
Sergey Biryukov
b7c1e7eb62 Docs: Use correct variable in the style_loader_tag filter DocBlock.
Follow-up to [46088].

Props rima1889.
Fixes #52673.
Built from https://develop.svn.wordpress.org/trunk@50451


git-svn-id: http://core.svn.wordpress.org/trunk@50062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-27 17:59:03 +00:00
John Blackbourn
c04efbe92e Build/Test Tools: Fix and standardise calls to the tearDown() method in the test suite.
The parent method should be called after any test-specific teardown.

See #52625

Built from https://develop.svn.wordpress.org/trunk@50450


git-svn-id: http://core.svn.wordpress.org/trunk@50061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-27 17:10:03 +00:00
John Blackbourn
fd8fe61045 Build/Test Tools: Fix and standardise calls to the setUp() and setUpBeforeClass() methods in the test suite.
The parent methods should always be called before any test-specific functionality is set up, unless there is a specific and documented reason.

See #52625

Built from https://develop.svn.wordpress.org/trunk@50449


git-svn-id: http://core.svn.wordpress.org/trunk@50060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-27 16:56:04 +00:00
John Blackbourn
210fd37d37 Build/Test Tools: Add some more tests that perform HTTP requests to the external-http test group.
See #52625

Built from https://develop.svn.wordpress.org/trunk@50448


git-svn-id: http://core.svn.wordpress.org/trunk@50059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-27 14:38:04 +00:00
Sergey Biryukov
1a7d246fcc Bootstrap/Load: Check if the error_reporting() function exists in wp-load.php.
This avoids a fatal error on PHP 8 if `error_reporting()` is disabled in `php.ini`.

On systems with this function disabled, it's best to add a dummy function to the `wp-config.php` file, as there are multiple other calls in core or plugins.

However, as this call to the function is run prior to `wp-config.php` loading, it is now wrapped in a `function_exists()` check.

Props peterwilsoncc, fijisunshine, ayeshrajans.
Fixes #52226.
Built from https://develop.svn.wordpress.org/trunk@50447


git-svn-id: http://core.svn.wordpress.org/trunk@50058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-27 11:09:07 +00:00
John Blackbourn
96710a174b Build/Test Tools: Switch away from npx install-changed in GitHub Actions to increase the cache performance.
Using `npm ci` makes better use of the npm cache that's in use, speeding up the test runs by around 30 seconds.

See #52660

Built from https://develop.svn.wordpress.org/trunk@50446


git-svn-id: http://core.svn.wordpress.org/trunk@50057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-26 22:49:03 +00:00
Sergey Biryukov
dacf8681f4 External Libraries: Install jQuery via NPM.
Previously, jQuery 1.12.4 was added to the WordPress SVN repo in order to backport an upstream security patch from jQuery 3.4.0.

Now that WordPress includes an unmodified version of jQuery 3.5.1 and no longer needs to maintain a fork, it can be removed from the SVN repo and installed via NPM again as part of the build.

Follow-up to [45342], [49101].

Props peterwilsoncc, SergeyBiryukov.
Fixes #52647.
Built from https://develop.svn.wordpress.org/trunk@50445


git-svn-id: http://core.svn.wordpress.org/trunk@50056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-26 17:51:20 +00:00
John Blackbourn
a64c512657 Build/Test Tools: Split the PHPUnit tests for PHP versions below 7.0 in half, allowing them to run in parallel and reduce the overall test run duration on GitHub Actions.
The `external-http`, `media`, and `restapi` groups combined take roughly the same time as all the other tests combined. Splitting the test run in two speeds up the PHP 5.6 test runs which are the slowest by quite a margin. The net reduction in duration is only seen on PHP versions older than 7.0 where the reduction is greater than the time taken for the job to be set up.

Props peterwilsoncc, desrosj, johnbillion

Special shout out to manzoorwanijk whose article about running steps in parallel started me down this path.

Fixes #52645

Built from https://develop.svn.wordpress.org/trunk@50444


git-svn-id: http://core.svn.wordpress.org/trunk@50055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-26 15:09:02 +00:00
John Blackbourn
1cfb5ef953 Build/Test Tools: Increase the reliability of backing up the mu-plugins directory during tests.
Fixes #51735

Built from https://develop.svn.wordpress.org/trunk@50443


git-svn-id: http://core.svn.wordpress.org/trunk@50054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-26 14:39:04 +00:00
John Blackbourn
56ca8431ad Build/Test Tools: Avoid attempting to redeclare the origin remote prior to sending the test results to the test reporting API.
Props desroj
See #51734

Built from https://develop.svn.wordpress.org/trunk@50442


git-svn-id: http://core.svn.wordpress.org/trunk@50053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-26 14:30:04 +00:00
John Blackbourn
95e4e3d484 Build/Test Tools: Switch back to running the PHPUnit test suite against the src directory instead of build.
Some PHPUnit tests were concerned with the state of files in the `build` directory. In order to allow the tests to run without requiring a build to be run first, these have been moved into assertions that run after the build step (and therefore cause it to fail if they do not pass), or into QUnit tests as necessary.

Various other PHPUnit tests implictly depend on built JavaScript files being present. These files are now touched during the test setup to avoid PHP warnings if the `build` files are not present.

The `wp-tests-config-sample.php` file and the GitHub Actions configuration have also been changed so `ABSPATH` uses `src` instead of `build`, therefore allowing the PHPUnit tests to be run without a build having to be run first. This means all new local installations of WordPress will use `src` for PHPUnit testing. If you would like to switch your existing installation over then change the location of `ABSPATH` in `wp-tests-config.php` to point to `src` instead of `build`.

Props peterwilsoncc, iandunn, gziolo, desroj, johnbillion

Fixes #51734
See #45863

Built from https://develop.svn.wordpress.org/trunk@50441


git-svn-id: http://core.svn.wordpress.org/trunk@50052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-26 14:09:06 +00:00
Peter Wilson
7b26eac3a3 Users: Use localized site title for password reset emails.
When sending password reset emails, switch to the user's locale prior to obtaining the site title to allow for plugins filtering based on locale.

Follow up to [50129,50139-50141,50152,50415].

Props chouby.
Fixes #52605. See #34281.


Built from https://develop.svn.wordpress.org/trunk@50439


git-svn-id: http://core.svn.wordpress.org/trunk@50050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-26 00:52:02 +00:00
desrosj
ba60f353f8 Build/Test Tools: Prevent the NPM/Composer caches in GitHub Actions from snowballing.
The `actions/cache` GitHub action uses a `key` input to find the desired cache in storage. Currently, this is defined as a combination of the operating system being used, the software being cached (NPM or Composer), PHP version (Composer only), and a hash of the relevant lock file.

The `cache` action also supports a `restore-keys` input, which is an ordered list of keys to use for restoring a cache if no cache hit occurred for the specified key.

However, this means that every time a lock file is updated, the cache is being recreated by first restoring a previous one (when available), and then installing new versions of dependencies on top of that. This results in old, unused versions of dependencies never being removed from the cache.

In this change, the `restore-keys` are removed. This will force a new, fresh cache to be generated when the desired `key` is not matched. In testing, this results in a ~40% reduction in cache size when compared to the latest successful workflow runs. Since there is no way to manually flush the cache in GHA, the benefits of this change will not be seen until the `package-lock.json` and `composer.lock` files are updated, or the cache at the desired key is evicted.

Props johbillion.
See #52660.
Built from https://develop.svn.wordpress.org/trunk@50436


git-svn-id: http://core.svn.wordpress.org/trunk@50047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-25 20:49:08 +00:00
desrosj
7abbffa346 Build/Test Tools: Disable fail-fast for PHPUnit testing.
In GitHub Actions, there is a `fail-fast` option that will cancel all incomplete jobs within a workflow as soon as one failure is encountered. This defaults to `true`.

This is great for alerting you of a failure faster, but does not give you the full picture of what is failing. For example, it’s possible that there is a failing test on 2 versions of PHP, but not others. If `fail-fast` is enabled, it’s impossible to know this.

Even with `fail-fast` disabled, the workflow will still report a failure if one or more jobs produce a failing result.

Props johbillion, jorbin.
Fixes #52612.
Built from https://develop.svn.wordpress.org/trunk@50435


git-svn-id: http://core.svn.wordpress.org/trunk@50046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-25 14:05:04 +00:00
Sergey Biryukov
74e0d8ba54 Docs: Correct function name in add_settings_field() DocBlock.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50434


git-svn-id: http://core.svn.wordpress.org/trunk@50045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-25 12:02:03 +00:00
Sergey Biryukov
09d7cacc6b Tests: Reset current screen after setting it to dashboard in add_submenu_page() tests.
This avoids polluting other tests and allows the `ms-excluded` test group to successfully run on its own.

Props johnbillion, SergeyBiryukov.
See #52607.
Built from https://develop.svn.wordpress.org/trunk@50433


git-svn-id: http://core.svn.wordpress.org/trunk@50044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-25 11:12:07 +00:00
desrosj
dc3a76e8f3 Build/Test Tools: Limit when GitHub Action workflows run on pull_request.
Different branches have support for different types of testing based on the tooling that was in place at the time each version was branched. The workflows currently in place have patterns configured to match the relevant `branches` and `tags` for each workflow, but only for `push` events.

This copies the patterns for matching supported `branches` over to the `pull_request` event to prevent workflows from running for a pull request to a branch that does not support that workflow.

Fixes #52643.
Built from https://develop.svn.wordpress.org/trunk@50432


git-svn-id: http://core.svn.wordpress.org/trunk@50043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-24 19:36:09 +00:00
desrosj
b231afc0b7 Help/About: Remove extra space in the 5.7 About page copy.
Props tobifjellner, audrasjb.
Fixes #52632.
Built from https://develop.svn.wordpress.org/trunk@50430


git-svn-id: http://core.svn.wordpress.org/trunk@50041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-24 15:51:06 +00:00