Andrew Ozz
2cdc22aded
Site health:
...
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.
Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645 .
Built from https://develop.svn.wordpress.org/trunk@45104
git-svn-id: http://core.svn.wordpress.org/trunk@44913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 23:33:53 +00:00
Sergey Biryukov
1909df67a7
Docs: Remove an empty line between @param
and @return
in the tests added in [45101], per documentation coding standards.
...
See #45029 .
Built from https://develop.svn.wordpress.org/trunk@45103
git-svn-id: http://core.svn.wordpress.org/trunk@44912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:22:50 +00:00
Sergey Biryukov
0c92764023
Site Health: Use an established pattern for numbered placeholders in translator comments in WP_Debug_Data
.
...
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45102
git-svn-id: http://core.svn.wordpress.org/trunk@44911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:18:52 +00:00
Sergey Biryukov
cbbe38c09c
Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema
filter are not overridden by subclasses.
...
Add unit tests missed in [45100].
Props Toro_Unit, birgire.
See #45029 .
Built from https://develop.svn.wordpress.org/trunk@45101
git-svn-id: http://core.svn.wordpress.org/trunk@44910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:15:51 +00:00
Sergey Biryukov
2931a2d95e
Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema
filter are not overridden by subclasses.
...
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.
Props Toro_Unit, birgire.
Fixes #45029 .
Built from https://develop.svn.wordpress.org/trunk@45100
git-svn-id: http://core.svn.wordpress.org/trunk@44909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 22:13:52 +00:00
Sergey Biryukov
f7357d3957
Site Health: i18n audit, take 1.
...
* Split plural strings with multiple sentences to avoid duplicating translations.
* Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
* Use an established pattern for numbered placeholders in translator comments.
* Replace constants in translatable strings with placeholders, mark them as code.
* Make sure sentences are translated as a whole, not as separate string parts.
* Remove unnecessary context and escaping.
Props ocean90, SergeyBiryukov.
See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45099
git-svn-id: http://core.svn.wordpress.org/trunk@44908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 21:32:53 +00:00
Sergey Biryukov
5291f46c8a
Docs: Fix typo in a comment in unzip_file()
.
...
Props mukesh27.
Fixes #46766 .
Built from https://develop.svn.wordpress.org/trunk@45098
git-svn-id: http://core.svn.wordpress.org/trunk@44907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 13:34:53 +00:00
desrosj
6d1f493d1d
Administration: Remove unnecessary transition-delay
values from Dashicons.
...
A unitless `0` value for a `<time>` CSS data type was reintroduced in [45040]. This is allowed for `<length>` data types, but is invalid for `<time>`.
See #43195 .
Fixes #46774 .
Built from https://develop.svn.wordpress.org/trunk@45097
git-svn-id: http://core.svn.wordpress.org/trunk@44906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 13:19:52 +00:00
Sergey Biryukov
45cd565be3
Twenty Fifteen: Fix typo in a comment for print styles.
...
Props mukesh27.
Fixes #46767 .
Built from https://develop.svn.wordpress.org/trunk@45096
git-svn-id: http://core.svn.wordpress.org/trunk@44905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 13:07:51 +00:00
Sergey Biryukov
474f57e0fa
Site Health: Add missing i18n for Security and Performance badge labels.
...
Props iworks.
Fixes #46755 . See #46683 .
Built from https://develop.svn.wordpress.org/trunk@45095
git-svn-id: http://core.svn.wordpress.org/trunk@44904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-02 10:08:56 +00:00
Sergey Biryukov
ccbf084609
Docs: Fix more typos in WP_Site_Health
DocBlocks.
...
See #46753 .
Built from https://develop.svn.wordpress.org/trunk@45094
git-svn-id: http://core.svn.wordpress.org/trunk@44903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 20:30:52 +00:00
Sergey Biryukov
12a2bf946a
Docs: Fix typos in WP_Site_Health
DocBlocks.
...
Props mukesh27.
Fixes #46753 .
Built from https://develop.svn.wordpress.org/trunk@45093
git-svn-id: http://core.svn.wordpress.org/trunk@44902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 20:23:50 +00:00
Sergey Biryukov
9c8e9354b1
Docs: Add missing @since
tag for WP_Site_Health::get_test_php_extensions()
.
...
Props mukesh27.
Fixes #46752 .
Built from https://develop.svn.wordpress.org/trunk@45092
git-svn-id: http://core.svn.wordpress.org/trunk@44901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 20:17:54 +00:00
Andrea Fercia
83546a04f5
Administration: Site Health: reserve some space for the admin notices.
...
Props xkon, Clorith, hedgefield, mapk, karmatosed, afercia.
Fixes #46651 .
Built from https://develop.svn.wordpress.org/trunk@45091
git-svn-id: http://core.svn.wordpress.org/trunk@44900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 18:01:52 +00:00
Sergey Biryukov
57a8f51e06
PHPCS: Fix WPCS violation in [45088].
...
See #38168 .
Built from https://develop.svn.wordpress.org/trunk@45090
git-svn-id: http://core.svn.wordpress.org/trunk@44899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 16:49:50 +00:00
Sergey Biryukov
130495e1c4
Docs: Correct @param
description for remove_theme_support()
.
...
Add `@return` description for `current_theme_supports()`.
See #46543 .
Built from https://develop.svn.wordpress.org/trunk@45089
git-svn-id: http://core.svn.wordpress.org/trunk@44898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 16:21:50 +00:00
Sergey Biryukov
3f3593aa6c
Customize: Only add custom-background
to body_class()
if the current theme supports custom background.
...
Props wido, swissspidy, ocean90, Mte90.
Fixes #38168 .
Built from https://develop.svn.wordpress.org/trunk@45088
git-svn-id: http://core.svn.wordpress.org/trunk@44897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 16:18:52 +00:00
Andrea Fercia
d8b8994336
Accessibility: Improve the Site Health accordions.
...
- removes the definition list and uses the markup from the ARIA Authoring Practices example
- removes incorrect ARIA roles
- avoids ARIA landmark regions proliferation
Props mukesh27 for the initial patch.
Fixes #46714 .
Built from https://develop.svn.wordpress.org/trunk@45087
git-svn-id: http://core.svn.wordpress.org/trunk@44896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 15:08:58 +00:00
Sergey Biryukov
95541a86ff
Docs: Correct parameter types for the_author()
, get_the_author_meta()
, and the_author_meta()
.
...
Props subrataemfluence.
Fixes #45596 .
Built from https://develop.svn.wordpress.org/trunk@45086
git-svn-id: http://core.svn.wordpress.org/trunk@44895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 14:23:53 +00:00
Sergey Biryukov
0aedea9470
Docs: Improve documentation for get_plugin_page_hook()
and get_plugin_page_hookname()
.
...
Props subrataemfluence, desrosj.
Fixes #44224 .
Built from https://develop.svn.wordpress.org/trunk@45085
git-svn-id: http://core.svn.wordpress.org/trunk@44894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 14:09:52 +00:00
Sergey Biryukov
06d8f376ea
PHPCS: Fix WPCS violation in [45082].
...
See #42223 .
Built from https://develop.svn.wordpress.org/trunk@45084
git-svn-id: http://core.svn.wordpress.org/trunk@44893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 13:30:52 +00:00
Sergey Biryukov
733ec3da48
Docs: Improve documentation for postbox_classes()
.
...
Rename `$page` and `$id` variables to `$screen_id` and `$box_id` for clarity.
Props sharifkiberu, DrewAPicture.
Fixes #45179 .
Built from https://develop.svn.wordpress.org/trunk@45083
git-svn-id: http://core.svn.wordpress.org/trunk@44892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 12:47:51 +00:00
Sergey Biryukov
2f5b5baa07
I18N: Merge similar strings about allowed space allocation in Multisite.
...
Props ramiy, Jonathandejong, pento.
Fixes #42223 .
Built from https://develop.svn.wordpress.org/trunk@45082
git-svn-id: http://core.svn.wordpress.org/trunk@44891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 12:24:51 +00:00
Sergey Biryukov
76e6cc67c2
Bundled Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex.
...
Props man4toman, andraganescu.
Fixes #46450 .
Built from https://develop.svn.wordpress.org/trunk@45081
git-svn-id: http://core.svn.wordpress.org/trunk@44890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 11:56:52 +00:00
Sergey Biryukov
de95fac19c
Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex.
...
Props man4toman.
See #46450 .
Built from https://develop.svn.wordpress.org/trunk@45080
git-svn-id: http://core.svn.wordpress.org/trunk@44889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 11:55:52 +00:00
Sergey Biryukov
5cca79f806
Site Health: If WP_DEBUG_LOG
contains a file path, display it on Site Info tab.
...
Props xkon, knutsp, ocean90.
Fixes #46692 .
Built from https://develop.svn.wordpress.org/trunk@45079
git-svn-id: http://core.svn.wordpress.org/trunk@44888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 01:26:51 +00:00
Sergey Biryukov
c241c16846
Site Health: Simplify the checks for constants that are always defined by default.
...
Props xkon.
Fixes #46738 .
Built from https://develop.svn.wordpress.org/trunk@45078
git-svn-id: http://core.svn.wordpress.org/trunk@44887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-01 00:10:53 +00:00
Sergey Biryukov
63d0abd5ff
Administration: Fix typo in fatal error email notification.
...
Props kraftbj.
Fixes #46722 .
Built from https://develop.svn.wordpress.org/trunk@45077
git-svn-id: http://core.svn.wordpress.org/trunk@44886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-30 18:54:51 +00:00
Andrea Fercia
61628dbd8b
Administration: Display a notice in the Site Health pages when JavaScript is off.
...
- displays an error notice when JavaScript is off, consistently with other admin screens that depend on JavaScript
- keeps the main `h1` visible
Minor clean-ups:
- makes code indentation consistent in `site-health.php` and `site-health-info.php`
- removes a couple of `<div class="wp-clearfix"></div>` as that's not the intended usage of `wp-clearfix` (those divs didn't do anything anyways)
Fixes #46717 .
Built from https://develop.svn.wordpress.org/trunk@45076
git-svn-id: http://core.svn.wordpress.org/trunk@44885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-30 15:38:51 +00:00
Andrea Fercia
2737a54374
Accessibility: Make sure the Site Health layout tables are correctly linearized.
...
Adds `role="presentation"` to the `<table>` elements used in the Site Health reports.
Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.
Props chetan200891.
Fixes #46725 .
Built from https://develop.svn.wordpress.org/trunk@45075
git-svn-id: http://core.svn.wordpress.org/trunk@44884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-30 14:42:51 +00:00
Andrea Fercia
fdda9ca9dd
Coding Standards: Improve the Site Health CSS for small screens.
...
Amends #45071 .
See #46685 .
Built from https://develop.svn.wordpress.org/trunk@45074
git-svn-id: http://core.svn.wordpress.org/trunk@44883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-30 14:09:51 +00:00
Sergey Biryukov
44602b5ed9
Docs: Fix typos in site_status_tests
filter DocBlock.
...
Props kraftbj.
Fixes #46727 .
Built from https://develop.svn.wordpress.org/trunk@45073
git-svn-id: http://core.svn.wordpress.org/trunk@44882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-30 10:58:52 +00:00
Andrea Fercia
0942dfc6d4
Administration: Improve the CSS for the Site Health pages header.
...
Avoids the Site Health pages header layout to break when the Hello Dolly plugin or other floated content is printed out at the top of the page.
Props xkon.
Fixes #46650 .
Built from https://develop.svn.wordpress.org/trunk@45072
git-svn-id: http://core.svn.wordpress.org/trunk@44881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 18:55:50 +00:00
Andrea Fercia
2a99454732
Coding Standards: Clean up the Site Health stylesheet.
...
- reduces selectors specificity to avoid over-qualified selectors
- removes unused rulesets / properties
- renames some CSS classes
Fixes #46685 .
Built from https://develop.svn.wordpress.org/trunk@45071
git-svn-id: http://core.svn.wordpress.org/trunk@44880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 18:44:51 +00:00
Andrea Fercia
d56f81fe45
Accessibility: Make sure the Site Health pages have a unique document title.
...
The document `<title>` gives a name to a web document. In the context of the WordPress admin, a unique, meaningful, title is important for various reasons:
- it allows browser's history to store meaningful entries
- when multiple browser's tabs are open, it allows users to better identify the tab content
- it's the first thing screen readers announce when navigating to a web page, thus helping users to identify the nature of the page content
Props chetan200891, mukesh27.
Fixes #46699 .
Built from https://develop.svn.wordpress.org/trunk@45070
git-svn-id: http://core.svn.wordpress.org/trunk@44879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 18:27:51 +00:00
Andrea Fercia
9f09fcb1c2
Accessibility: Remove arrows navigation from the Site Health accordions.
...
Arrows navigation on accordions is an optional keyboard interaction feature mentioned in the WAI-ARIA Authoring Practices. While it can add some value in some specific cases, it's not so discoverable and it's unlikely users, including assistive technologies users, would really "expect" this kind of interaction.
See #46573 .
Fixes #46682 .
Built from https://develop.svn.wordpress.org/trunk@45069
git-svn-id: http://core.svn.wordpress.org/trunk@44878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 11:27:51 +00:00
Sergey Biryukov
02983a458d
Site Health: Add missing <ul>
tags for lists on Site Info page.
...
Props mukesh27, chetan200891, afercia.
Fixes #46693 .
Built from https://develop.svn.wordpress.org/trunk@45068
git-svn-id: http://core.svn.wordpress.org/trunk@44877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 11:14:51 +00:00
Mike Schroder
672372d118
Media: Improve and fix rotate/flip image tests
...
Fix off-by-one error in pixel color checks for rotate and flip image tests.
Change to using PNG with single pixel to ensure that errors are caught in the future, rather than lost in JPEG noise.
Props Fuegas, mikeschroder.
Fixes #46073 .
Built from https://develop.svn.wordpress.org/trunk@45067
git-svn-id: http://core.svn.wordpress.org/trunk@44876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 02:49:51 +00:00
Andrew Ozz
7ab495bfed
TinyMCE:
...
- Fix adding the keyboard shortcuts to all button tooltips in the classic editor and classic block.
- Fix translating the aria labels for all buttons.
Fixes #35710 ;
Built from https://develop.svn.wordpress.org/trunk@45066
git-svn-id: http://core.svn.wordpress.org/trunk@44875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 00:49:51 +00:00
John Blackbourn
5a481ea118
Options, Meta APIs: Remove an accidental short array syntax in the tests.
...
See #43561
Built from https://develop.svn.wordpress.org/trunk@45065
git-svn-id: http://core.svn.wordpress.org/trunk@44874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 22:03:52 +00:00
John Blackbourn
8f5d82df7b
Options, Meta APIs: Ensure the $object_id
parameter passed to the delete_{$meta_type}_meta
and deleted_{$meta_type}_meta
filters is always an integer.
...
Props salcode
Fixes #43561
Built from https://develop.svn.wordpress.org/trunk@45064
git-svn-id: http://core.svn.wordpress.org/trunk@44873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:59:52 +00:00
Sergey Biryukov
2bb2af2731
PHPCS: Fix WPCS violations in [45062].
...
See #46056 .
Built from https://develop.svn.wordpress.org/trunk@45063
git-svn-id: http://core.svn.wordpress.org/trunk@44872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:57:51 +00:00
Sergey Biryukov
10409c0f7c
Privacy: Ensure the personal data export email is sent in the locale of the user whose data is being exported (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale.
...
Props garrett-eclipse.
Fixes #46056 .
Built from https://develop.svn.wordpress.org/trunk@45062
git-svn-id: http://core.svn.wordpress.org/trunk@44871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:29:50 +00:00
John Blackbourn
437285dba4
Embeds: Update the Crowdsignal embed handler so that surveys on subdomains are supported.
...
Props kraftbj
Fixes #46467
Built from https://develop.svn.wordpress.org/trunk@45061
git-svn-id: http://core.svn.wordpress.org/trunk@44870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:27:51 +00:00
Sergey Biryukov
459aef1fa5
Build/Test Tools: Exclude twentynineteen/node_modules
from jsvalidate:build
task.
...
Fixes #46706 .
Built from https://develop.svn.wordpress.org/trunk@45060
git-svn-id: http://core.svn.wordpress.org/trunk@44869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:17:52 +00:00
John Blackbourn
94e4da6aec
Themes: Introduce a generic action that's fired when a template part is loaded.
...
This action allows debugging mechanisms to perform greater introspection into which template parts are loaded for any given request. It also exposes the array of candidate template part file names for each template part instance.
Props pcfreak30, jdeeburke
Fixes #41575
Built from https://develop.svn.wordpress.org/trunk@45059
git-svn-id: http://core.svn.wordpress.org/trunk@44868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:13:54 +00:00
Aaron Jorbin
9ca5ec97b1
PHP: Finish updating PHP Minimum version
...
Previous [44982] and [44950].
This bumps the minimum version down slightly based on some research into the usage of php 5.6. This also brings the recommended version in line with https://wordpress.org/about/requirements/ .
The travis matrix is also being reduced in order to speed up builds. This is a hard break. PHP 5.2 - 5.5 we are never ever, ever, getting back together. You go talk to your friends, talk to my friends, talk to me, But we are never ever, ever, ever getting back together.
Props DD32, afergen for research.
Fixes #46594 .
Built from https://develop.svn.wordpress.org/trunk@45058
git-svn-id: http://core.svn.wordpress.org/trunk@44867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 21:12:52 +00:00
Sergey Biryukov
9ebc5e85fd
Twenty Nineteen: Update Theme URI
to point to the Theme Directory instead of the archived GitHub repository.
...
Update `style.scss` and `style-rtl.css`, missed in [45032].
Props dimadin.
See #46668 .
Built from https://develop.svn.wordpress.org/trunk@45057
git-svn-id: http://core.svn.wordpress.org/trunk@44866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 20:58:51 +00:00
Sergey Biryukov
4e4e8fa110
Bootstrap/Load: Ensure the fatal error handler is registered after WP_CONTENT_DIR
is defined, so the custom error handler drop-in could be properly loaded.
...
Props sebastian.pisula, diddledan.
Fixes #46069 .
Built from https://develop.svn.wordpress.org/trunk@45056
git-svn-id: http://core.svn.wordpress.org/trunk@44865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 19:04:51 +00:00
Sergey Biryukov
a2577854e6
Site Health: Declare ClipboardJS
global to fix JSHint issue.
...
See #46647 .
Built from https://develop.svn.wordpress.org/trunk@45055
git-svn-id: http://core.svn.wordpress.org/trunk@44864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-28 18:38:51 +00:00