Commit Graph

5920 Commits

Author SHA1 Message Date
Helen Hou-Sandí
2cdeac7cf6 Pass the $post object as context to postmeta_form_keys.
see #33885, #18979.

Built from https://develop.svn.wordpress.org/trunk@35730


git-svn-id: http://core.svn.wordpress.org/trunk@35694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-23 17:15:29 +00:00
Gary Pendergast
d04396d0ad Docs: Replace a reference to WP.org with WordPress.org.
Built from https://develop.svn.wordpress.org/trunk@35729


git-svn-id: http://core.svn.wordpress.org/trunk@35693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 22:38:26 +00:00
Sergey Biryukov
ae04eba0b6 Comments: After [35670], change the CSS class for the pending comments count back to moderated.
Fixes #34680.
Built from https://develop.svn.wordpress.org/trunk@35726


git-svn-id: http://core.svn.wordpress.org/trunk@35690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 15:23:26 +00:00
Sergey Biryukov
bc1e479fd0 After [35718], update the location of some files in This filter is documented in docs.
Partially reverts [33954].

Fixes #33413.
Built from https://develop.svn.wordpress.org/trunk@35725


git-svn-id: http://core.svn.wordpress.org/trunk@35689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-22 03:51:28 +00:00
Andrew Nacin
1579e45d41 Simplify the include graph after work to split out classes.
see #33413. More details there.

Built from https://develop.svn.wordpress.org/trunk@35718


git-svn-id: http://core.svn.wordpress.org/trunk@35682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 07:24:30 +00:00
Helen Hou-Sandí
e549e56f02 Custom fields: Allow for short-circuiting the meta key dropdown.
Adds the `postmeta_form_keys` filter which allows for a potentially expensive query against postmeta to be avoided.

props ericmann, tollmanz, nacin.
see #33885.

Built from https://develop.svn.wordpress.org/trunk@35717


git-svn-id: http://core.svn.wordpress.org/trunk@35681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:16:50 +00:00
Boone Gorges
f173cdfb18 On 4.4 upgrade, remove the unused 'add_users' cap from all roles.
Fixes #16719.
Built from https://develop.svn.wordpress.org/trunk@35701


git-svn-id: http://core.svn.wordpress.org/trunk@35665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 03:53:28 +00:00
Scott Taylor
a99f7baa5a List Tables: Fix PHP error notice when $columns is null
Use of `register_column_headers()` and `print_column_headers()` creates a `_WP_List_Table_Compat` without any columns. When the List Table object doesn't have any columns, there's naturally no primary column.

Props danielbachhuber.
Fixes #34148.

Built from https://develop.svn.wordpress.org/trunk@35698


git-svn-id: http://core.svn.wordpress.org/trunk@35662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 23:01:26 +00:00
Aaron Jorbin
e8d8e79371 Revert [34291] bringing back my-hacks
Keeping myhacks support is a small price to pay for not breaking people's sites.  Even if it is very very very few sites, breaking sites isn't something that should be encouraged. Even with 10 years of deprecation notices.

https://core.trac.wordpress.org/ticket/33741#comment:18 outlines all the ways that the hack_file and my-hacks options can be setup and thus all the ways that the removal of those options could break sites.

Fixes #33741.



Built from https://develop.svn.wordpress.org/trunk@35688


git-svn-id: http://core.svn.wordpress.org/trunk@35652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:49:26 +00:00
Dominik Schilling
c25efe2d52 Revert [35336] and [35337].
See #28344.
Built from https://develop.svn.wordpress.org/trunk@35685


git-svn-id: http://core.svn.wordpress.org/trunk@35649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:30:25 +00:00
Scott Taylor
19834a4c21 List Tables: After [35622] and [34271], improve pagination logic when queries are altered.
Props bradyvercher.
Fixes #29870.

Built from https://develop.svn.wordpress.org/trunk@35683


git-svn-id: http://core.svn.wordpress.org/trunk@35647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:25:26 +00:00
Scott Taylor
af0498989c List Tables: After [34728], don't try to infer orderby from query params.
List tables are really good.

Props cklosows.
Fixes #25493.

Built from https://develop.svn.wordpress.org/trunk@35682


git-svn-id: http://core.svn.wordpress.org/trunk@35646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:19:26 +00:00
Scott Taylor
f2e9e98fa6 Media: in media_send_to_editor(), use wp_json_encode() instead of addslashes().
Props TobiasBg.
Fixes #22135.

Built from https://develop.svn.wordpress.org/trunk@35677


git-svn-id: http://core.svn.wordpress.org/trunk@35641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:40:27 +00:00
Scott Taylor
838592c1ba List Tables: because we can never eradicate the existence of globals, ensure that $comment is hoisted into the global space inside WP_Comments_List_Table::single_row().
Fixes #34654.

Built from https://develop.svn.wordpress.org/trunk@35674


git-svn-id: http://core.svn.wordpress.org/trunk@35638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:05:30 +00:00
Sergey Biryukov
bc41f44158 I18N: After [34424], replace the placeholder with comments count after translate_nooped_plural() runs, not before.
Props hnle.
Fixes #34680.
Built from https://develop.svn.wordpress.org/trunk@35670


git-svn-id: http://core.svn.wordpress.org/trunk@35634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 18:04:28 +00:00
Drew Jaynes
283b7d0a66 Plugins: Rename the delete_plugin action hook (introduced in [35094]) to deleted_plugin as it fires ''following'' a plugin deletion attempt.
Further, introduce a new `delete_plugin` action hook, to be fired ''before'' a plugin deletion attempt. Both changes bring parity with other such transactional hooks in core that fire before and after certain actions, including on plugin activation/deactivation and install/uninstall, among others.

Props johnjamesjacoby.
Fixes #26904.

Built from https://develop.svn.wordpress.org/trunk@35669


git-svn-id: http://core.svn.wordpress.org/trunk@35633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:58:26 +00:00
Sergey Biryukov
0d4cf36199 I18N: Remove <a> tag from translatable string in wp-admin/includes/class-wp-comments-list-table.php.
Props ramiy.
Fixes #34686.
Built from https://develop.svn.wordpress.org/trunk@35666


git-svn-id: http://core.svn.wordpress.org/trunk@35630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:34:27 +00:00
Sergey Biryukov
5539193dd0 I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ftpsockets.php.
Fixes #34684.
Built from https://develop.svn.wordpress.org/trunk@35664


git-svn-id: http://core.svn.wordpress.org/trunk@35628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:23:29 +00:00
Sergey Biryukov
a7c5161db1 I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ftpext.php.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35663


git-svn-id: http://core.svn.wordpress.org/trunk@35627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:22:27 +00:00
Sergey Biryukov
0237fadd3a I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-base.php.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35662


git-svn-id: http://core.svn.wordpress.org/trunk@35626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:21:26 +00:00
Sergey Biryukov
6b94d7c89c I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ssh2.php.
Props ramiy.
See #34684.
Built from https://develop.svn.wordpress.org/trunk@35661


git-svn-id: http://core.svn.wordpress.org/trunk@35625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 17:18:40 +00:00
Dominik Schilling
99f4fc4404 Themes: Check if the browse view is set in wp_ajax_query_themes() to avoid a PHP notice when searching for new themes.
Introduced in [35527].

See #34206.
Built from https://develop.svn.wordpress.org/trunk@35646


git-svn-id: http://core.svn.wordpress.org/trunk@35610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 19:47:54 +00:00
Dion Hulse
42ff945649 Decrease the chances that wp_tempnam() will conflict with an existing file by suffixing a random ID to the generated filename.
This also switches from using `touch()` to using `fopen( $file, 'x')` to ensure that we're the process creating the file.

Fixes #34562

Built from https://develop.svn.wordpress.org/trunk@35644


git-svn-id: http://core.svn.wordpress.org/trunk@35608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 05:33:25 +00:00
Dion Hulse
be94558c46 Upgrader: Pass the $args['hook_extra'] context to the upgrader_source_selection filter.
Props afragen
Fixes #34696

Built from https://develop.svn.wordpress.org/trunk@35642


git-svn-id: http://core.svn.wordpress.org/trunk@35606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-16 02:47:25 +00:00
Dominik Schilling
40b303069a Schema: Increase length of user_pass and user_activation_key fields to 255.
Props grvrulz and Miglosh for testing.
Fixes #33904.
Built from https://develop.svn.wordpress.org/trunk@35638


git-svn-id: http://core.svn.wordpress.org/trunk@35602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-15 14:19:28 +00:00
Helen Hou-Sandí
ae9e173082 Buttons: Standardize on .button-link for link-like buttons.
This serves as both a reset and some basic styling. The class name also aligns with parallel components in other popular projects.

props paulwilde for the initial patch.
fixes #34242.

Built from https://develop.svn.wordpress.org/trunk@35636


git-svn-id: http://core.svn.wordpress.org/trunk@35600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-13 15:47:27 +00:00
Sergey Biryukov
95c55ca251 Cast 'illegal_user_logins' filter result to array.
See #27317.
Built from https://develop.svn.wordpress.org/trunk@35630


git-svn-id: http://core.svn.wordpress.org/trunk@35594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:34:27 +00:00
Sergey Biryukov
b08ae1d60b Users: After [35189], make 'illegal_user_logins' check case-insensitive.
Props juliobox.
Fixes #27317.
Built from https://develop.svn.wordpress.org/trunk@35629


git-svn-id: http://core.svn.wordpress.org/trunk@35593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-12 16:30:28 +00:00
Scott Taylor
128a9c3acd List Tables: after [34271], account for searches when calculating pagination.
Fixes #29870.


Built from https://develop.svn.wordpress.org/trunk@35622


git-svn-id: http://core.svn.wordpress.org/trunk@35586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 23:14:26 +00:00
Dominik Schilling
1f15d30396 Upgrade: Revert [34543] because of incomplete and incorrect functionality.
See #33932.
Fixes #34434.
Built from https://develop.svn.wordpress.org/trunk@35619


git-svn-id: http://core.svn.wordpress.org/trunk@35583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 22:46:26 +00:00
Sergey Biryukov
db8c89cccb Remove non-translatable HTML code from the first post content in populate_network() and wp_install_defaults().
Add translator comment.

Props ramiy.
Fixes #34619.
Built from https://develop.svn.wordpress.org/trunk@35614


git-svn-id: http://core.svn.wordpress.org/trunk@35578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 20:55:26 +00:00
Andrea Fercia
62e236b3c6 Accessibility: Improve form labels and descriptions for the Tags meta box in the Edit Post screen.
Fixes #34627.
Built from https://develop.svn.wordpress.org/trunk@35609


git-svn-id: http://core.svn.wordpress.org/trunk@35573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 15:24:29 +00:00
Andrea Fercia
5f93491286 Accessibility: improvements for the taxonomies Quick Edit form.
Changes the "Cancel" and "Update" controls in buttons for better semantics and
accessibility. On cancel and successful saving, moves focus back to the term title
to avoid a focus loss. Dispatches error and success messages to `wp.a11y.speak`
to give assistive technologies users an audible feedback.

Patch prepared at #wpcdit, first Italian WordPress Contributor Day.

Props garusky, chiara_09.
Fixes #34613.
Built from https://develop.svn.wordpress.org/trunk@35605


git-svn-id: http://core.svn.wordpress.org/trunk@35569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 00:24:28 +00:00
Dion Hulse
2103984c02 Fix a typo in a docblock
Built from https://develop.svn.wordpress.org/trunk@35586


git-svn-id: http://core.svn.wordpress.org/trunk@35550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 03:38:26 +00:00
Dion Hulse
09ada24c99 Upgrade: Force disable the rest-api plugin on upgrade to 4.4 unless it's beta5+. Previous versions of the plugin were not configured correctly to gradefully degrade during update which would cause fatal errors.
Props wonderboymusic.
Fixes #34415

Built from https://develop.svn.wordpress.org/trunk@35582


git-svn-id: http://core.svn.wordpress.org/trunk@35546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 01:22:28 +00:00
Dion Hulse
f47801d504 Media: Allow media_sideload_image() to work when the upload directory is a PHP Stream. Using copy() instead of rename() allows the function to work across different stream sources.
Props mattheu.
Fixes #29257

Built from https://develop.svn.wordpress.org/trunk@35579


git-svn-id: http://core.svn.wordpress.org/trunk@35543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-09 00:44:27 +00:00
Jeremy Felt
23c1050fb9 MS: Allow "Network Admin Email" to be a non-user during network setup.
The network admin email setting for a network is often used as a catch-all or notification email separate from the actual user ID set as the owner of the new network. If a non-user email address is set during network installation, we can defer to the current user as the actual network admin and apply the entered email as the address to which general notifications are sent and emails are sent from.

In the future, we'll want to update the messaging around "Network Admin Email" to reflect its reality. See #34293.

Props jjeaton.
Fixes #34065.

Built from https://develop.svn.wordpress.org/trunk@35575


git-svn-id: http://core.svn.wordpress.org/trunk@35539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-08 03:16:26 +00:00
Scott Taylor
e649fabb6a Accessibility: add missing alt attributes to a gaggle of <img>s.
Props afercia.
Fixes #34583.

Built from https://develop.svn.wordpress.org/trunk@35567


git-svn-id: http://core.svn.wordpress.org/trunk@35531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 16:12:27 +00:00
Scott Taylor
7a24b60c2a List Tables: to ensure that get_primary_column_name() can match columns that were added via the "manage_{$screen->id}_columns" filer, call get_column_headers() instead of $this->get_columns().
List Table classes and `WP_Screen` are already tangled together. The parent list table constructor adds a filter that is called by a function that references the instance globally, even though we have access to it via composition directly in the class that is adding the filter. So the fact that functions here have to be called that reference a screen instance we already have access to is what one might call... less than elegant.

#OOP

Props SergeyBiryukov.
Fixes #34508.

Built from https://develop.svn.wordpress.org/trunk@35565


git-svn-id: http://core.svn.wordpress.org/trunk@35529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-07 15:27:25 +00:00
Sergey Biryukov
7ad65267b6 Media: Avoid a PHP warning in wp_generate_attachment_metadata() if $metadata is not an array.
This was previously fixed in [25968], but accidentally reverted in [32545].

Props skithund.
Fixes #34599.
Built from https://develop.svn.wordpress.org/trunk@35554


git-svn-id: http://core.svn.wordpress.org/trunk@35518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 09:25:26 +00:00
Sergey Biryukov
cbe0cad509 Remove <code> tags from translatable strings in wp-admin/includes/network.php.
Add translator comments.

Props ramiy.
Fixes #34598.
Built from https://develop.svn.wordpress.org/trunk@35552


git-svn-id: http://core.svn.wordpress.org/trunk@35516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 00:59:25 +00:00
Sergey Biryukov
d6e25c0aae Remove <code> tags from translatable strings in wp-admin/includes/class-wp-upgrader.php.
Add translator comments.

Props ramiy.
Fixes #34580.
Built from https://develop.svn.wordpress.org/trunk@35551


git-svn-id: http://core.svn.wordpress.org/trunk@35515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-06 00:41:25 +00:00
Sergey Biryukov
a41e5d0270 Themes: Add a Favorites tab to the Add Themes screen.
You can now browse and install your wordpress.org theme favorites from the theme installer, just like with plugins.

Props swissspidy.
Fixes #34206.
Built from https://develop.svn.wordpress.org/trunk@35527


git-svn-id: http://core.svn.wordpress.org/trunk@35491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:49:26 +00:00
Dominik Schilling
122f38f748 List Tables: Define the global $mode variable for Quick Edit savings.
Also remove two unused global imports for `$mode`.

Fixes #34577.
Built from https://develop.svn.wordpress.org/trunk@35518


git-svn-id: http://core.svn.wordpress.org/trunk@35482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:29:25 +00:00
Scott Taylor
9135920061 Roles: map add_users cap to promote_users and remove it.
"Never used, will be removed." - The Ghost of 3.5 Nacin

Props Craig Ralston, renoirb.
Fixes #16719.

Built from https://develop.svn.wordpress.org/trunk@35507


git-svn-id: http://core.svn.wordpress.org/trunk@35471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 17:54:25 +00:00
Sergey Biryukov
18852f07f2 Menus: After [35450], use correct IDs in $initial_meta_boxes.
Props swissspidy.
Fixes #33925.
Built from https://develop.svn.wordpress.org/trunk@35502


git-svn-id: http://core.svn.wordpress.org/trunk@35466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 10:56:26 +00:00
Drew Jaynes
6b14ca9407 Docs: Fix two notations for the $_wp_real_parent_file global, which is an array.
Props NExt-Season.
Fixes #34443.

Built from https://develop.svn.wordpress.org/trunk@35495


git-svn-id: http://core.svn.wordpress.org/trunk@35459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 20:13:26 +00:00
Andrea Fercia
862cf19772 Media: Improve form fields labels association in the Edit Media screen.
Fixes #34548.
Built from https://develop.svn.wordpress.org/trunk@35493


git-svn-id: http://core.svn.wordpress.org/trunk@35457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 16:02:25 +00:00
Drew Jaynes
64f5e0683a Docs: Document use of the $comment_status global in the DocBlock for WP_Comments_List_Table::handle_row_actions().
Props shimakyohsuke.
Fixes #34425.

Built from https://develop.svn.wordpress.org/trunk@35490


git-svn-id: http://core.svn.wordpress.org/trunk@35454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-02 21:33:27 +00:00
Sergey Biryukov
f43a25bbe1 Docs: After [32654], remove duplicate @param tag in WP_List_Table::set_pagination_args() DocBlock.
Add `@since` tag.

Props bobbingwide.
See #32444.
Built from https://develop.svn.wordpress.org/trunk@35489


git-svn-id: http://core.svn.wordpress.org/trunk@35453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-02 21:03:24 +00:00