Gary Pendergast
0cff37abf5
Database: Find the correct table names in DELETE
queries with table aliases
...
Previously, `wpdb::get_table_from_query()` would not find the correct table name in the query `DELETE a FROM table a`, due to not recognising the table alias immediately after the `DELETE` as correct syntax.
Fixes #37660 .
Built from https://develop.svn.wordpress.org/trunk@38507
git-svn-id: http://core.svn.wordpress.org/trunk@38448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 00:19:28 +00:00
Gary Pendergast
75c1875587
Shortcodes: Add the pre_do_shortcode_tag
filter.
...
This filter allows the shortcode generation process to be short-circuited, so expensive short codes can be cached and returned immediately.
Props ideag.
Fixes #37906 .
Built from https://develop.svn.wordpress.org/trunk@38506
git-svn-id: http://core.svn.wordpress.org/trunk@38447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 00:10:28 +00:00
Sergey Biryukov
8682603166
Docs: Correct @since
entry for the smilies
filter added in [38504].
...
See #35905 .
Built from https://develop.svn.wordpress.org/trunk@38505
git-svn-id: http://core.svn.wordpress.org/trunk@38446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 00:08:30 +00:00
Gary Pendergast
cce2ffaed5
Smilies: Add the smilies
filter.
...
This new filter allows the smilies array to be modified with a filter, instead of having to directly access the global.
Props mte90, jorbin.
Fixes #35905 .
Built from https://develop.svn.wordpress.org/trunk@38504
git-svn-id: http://core.svn.wordpress.org/trunk@38445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-02 00:00:30 +00:00
Andrea Fercia
c01c23c4f7
Accessibility: Make links in the Customizer underlined by default.
...
Links within lines or blocks of text should always be underlined since they can't
rely on color alone to be distinguished from the surrounding text. Exceptions
can be handled on a case-by-case basis.
Props Presskopp for the initial patch.
Fixes #37527 .
Built from https://develop.svn.wordpress.org/trunk@38503
git-svn-id: http://core.svn.wordpress.org/trunk@38444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 22:02:30 +00:00
Aaron Jorbin
22e6d59c67
Administration: Use a bool when when a bool is called for
...
The third parameter of `date_i18n` is a bool. Currently, it's a weak check, otherwise the call showing the universal time on the "General Settings" screen would be messed up. Use an actual bool so we call our own functions correctly.
Fixes #37634 .
Props fronaldaraujo.
Built from https://develop.svn.wordpress.org/trunk@38502
git-svn-id: http://core.svn.wordpress.org/trunk@38443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 18:34:28 +00:00
Aaron Jorbin
93ad7eab80
Administration: Use #fff instead of white
...
Cleans up a few places where the CSS coding standards were not being followed.
Fixes #37576 .
Props Presskopp, johnpgreen, netweb
Built from https://develop.svn.wordpress.org/trunk@38501
git-svn-id: http://core.svn.wordpress.org/trunk@38442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 18:14:31 +00:00
Boone Gorges
77a3cc733e
Query: 'orderby=include' should support comma-separated lists.
...
[30052] assumed that 'include' would be an array.
Props TimothyBlynJacobs.
Fixes #37904 .
Built from https://develop.svn.wordpress.org/trunk@38500
git-svn-id: http://core.svn.wordpress.org/trunk@38441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 16:51:30 +00:00
Gary Pendergast
4babadb704
Bootstrap: class-wp-locale.php
needs to be require_once()
-ed.
...
After [38364], the inclusion of `class-wp-locale.php` was changed from a `require_once()` to a `require()`. This caused problems for anything that called `load_text_domain_early()` prior to the `require()` but didn't bail, as it was now being `require()`-ed a second time.
With the use of `require_once()`, it doesn't really matter where it's loaded, so it has been moved next to the related `l10n.php` load.
See #37827 .
Built from https://develop.svn.wordpress.org/trunk@38496
git-svn-id: http://core.svn.wordpress.org/trunk@38437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 12:36:28 +00:00
Sergey Biryukov
616eb41287
Docs: Move term_description()
reference from filter docblock to get_the_archive_description()
function docblock.
...
Props dlh.
See #37259 .
Built from https://develop.svn.wordpress.org/trunk@38495
git-svn-id: http://core.svn.wordpress.org/trunk@38436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 12:32:28 +00:00
Sergey Biryukov
2b5d7555b4
Users: After [33766], don't reset the password when clicking "Show Password" and then "Cancel" on Add New User screen.
...
Props smerriman for reporting.
Fixes #37902 . See #33419 .
Built from https://develop.svn.wordpress.org/trunk@38494
git-svn-id: http://core.svn.wordpress.org/trunk@38435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 12:24:29 +00:00
Sergey Biryukov
7aa79d3705
Template: After [38486], actually use the $description
variable in get_the_archive_description()
.
...
Props dlh.
Fixes #37259 .
Built from https://develop.svn.wordpress.org/trunk@38493
git-svn-id: http://core.svn.wordpress.org/trunk@38434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 11:47:30 +00:00
Weston Ruter
94e8a9cfa0
Customize: Introduce paneVisible
state and ensure pane is visible when a construct is expanded (or focused).
...
Fixes issue whereby a user would see nothing happen if the pane is collapsed while they shift-click to edit an element in the preview.
Props curdin, celloexpressions, westonruter.
See #27403 .
Fixes #36678 .
Built from https://develop.svn.wordpress.org/trunk@38492
git-svn-id: http://core.svn.wordpress.org/trunk@38433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 05:55:27 +00:00
Dion Hulse
227a80eba3
Query: Use AND
in a SQL query rather than &&
.
...
This appears to have been the only instance of `&&` being used in SQL, so for consistency lets remove it.
Props scrappy@hub.org .
Fixes #37903 .
Built from https://develop.svn.wordpress.org/trunk@38491
git-svn-id: http://core.svn.wordpress.org/trunk@38432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 05:11:31 +00:00
John Blackbourn
69c152cee7
Taxonomy: Correct the function description for wp_ajax_add_link_category()
.
...
See #37770
Built from https://develop.svn.wordpress.org/trunk@38490
git-svn-id: http://core.svn.wordpress.org/trunk@38431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 00:49:29 +00:00
John Blackbourn
01c3ae084b
Taxonomy: Update various docs for parameters which are now WP_Term
objects.
...
See #37770
See #14162
Built from https://develop.svn.wordpress.org/trunk@38489
git-svn-id: http://core.svn.wordpress.org/trunk@38430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-01 00:40:29 +00:00
Sergey Biryukov
bfe8ba91b6
Template: In get_the_archive_description()
, add support for author archives.
...
Props henry.wright.
Fixes #37259 .
Built from https://develop.svn.wordpress.org/trunk@38486
git-svn-id: http://core.svn.wordpress.org/trunk@38427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 23:01:29 +00:00
Sergey Biryukov
a4f8854a46
Taxonomy: Introduce wp_insert_term_data
and wp_update_term_data
filters for altering term data before it is inserted/updated in the database.
...
Props atimmer, SergeyBiryukov.
Fixes #22293 .
Built from https://develop.svn.wordpress.org/trunk@38484
git-svn-id: http://core.svn.wordpress.org/trunk@38425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 21:41:27 +00:00
Andrea Fercia
c451e71d42
Text Changes: Improve the timezone setting description in General Settings.
...
Makes more clear users can set either a city or a UTC timezone offset.
Props GrantDerepas, andrew.p.
Fixes #34789 .
Built from https://develop.svn.wordpress.org/trunk@38483
git-svn-id: http://core.svn.wordpress.org/trunk@38424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 21:37:27 +00:00
John Blackbourn
14e40fd20c
Role/Capability: Add two missing meta capabilities to the caps tests.
...
See #32394
Built from https://develop.svn.wordpress.org/trunk@38482
git-svn-id: http://core.svn.wordpress.org/trunk@38423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 21:34:30 +00:00
Sergey Biryukov
a2582f50cc
Users: Pass $profileuser
parameter to user_profile_picture_description
filter on "Edit User" screen.
...
Props turtlepod, deremohan.
Fixes #37379 .
Built from https://develop.svn.wordpress.org/trunk@38481
git-svn-id: http://core.svn.wordpress.org/trunk@38422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 21:13:32 +00:00
Scott Taylor
f1631f4e03
Bootstrap: goodnight sweet prince.
...
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38480
git-svn-id: http://core.svn.wordpress.org/trunk@38421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 20:36:30 +00:00
Weston Ruter
03adca4299
Customize: Fix i18n by re-using the add_new_item
post type label instead of using a post type name in a generic string.
...
Props afercia, westonruter.
See #34923 .
Fixes #37895 .
Built from https://develop.svn.wordpress.org/trunk@38479
git-svn-id: http://core.svn.wordpress.org/trunk@38420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 19:15:28 +00:00
Weston Ruter
bce5ea9494
Customize: Use new $status_code
parameter for wp_send_json_error()
instead of calling status_header()
separately.
...
Props johnbillion.
See #35666 .
Fixes #37897 .
Built from https://develop.svn.wordpress.org/trunk@38478
git-svn-id: http://core.svn.wordpress.org/trunk@38419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 19:01:28 +00:00
Sergey Biryukov
b4aaf3925d
Login and Registration: Change login label to Username or Email Address
for clarity.
...
Props GaryJ.
Fixes #37871 .
Built from https://develop.svn.wordpress.org/trunk@38477
git-svn-id: http://core.svn.wordpress.org/trunk@38418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 18:51:28 +00:00
Sergey Biryukov
fe12301ca9
Help/About: Remove an outdated help sentence on "My Sites" screen.
...
Props johnjamesjacoby.
Fixes #37896 .
Built from https://develop.svn.wordpress.org/trunk@38474
git-svn-id: http://core.svn.wordpress.org/trunk@38415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 17:44:29 +00:00
Scott Taylor
af71985625
Query: r38356, you were not long for this world.
...
Fixes #37830 .
Built from https://develop.svn.wordpress.org/trunk@38471
git-svn-id: http://core.svn.wordpress.org/trunk@38412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 16:53:29 +00:00
Scott Taylor
a3ffebce30
Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.
...
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38470
git-svn-id: http://core.svn.wordpress.org/trunk@38411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 16:31:29 +00:00
Scott Taylor
7e8d7f8a81
General: revert [38386], functions.php
was probably too tempting for some people to not load by itself.
...
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38469
git-svn-id: http://core.svn.wordpress.org/trunk@38410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 15:24:29 +00:00
Scott Taylor
0eebbed6b2
General: revert [38467], wp_is_IE()
should not exist.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38468
git-svn-id: http://core.svn.wordpress.org/trunk@38409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 15:22:31 +00:00
Scott Taylor
021e23e70b
General: use a new function, wp_is_IE()
, instead of the $is_IE
global in a number of places.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38467
git-svn-id: http://core.svn.wordpress.org/trunk@38408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 06:42:33 +00:00
Scott Taylor
69e7fe3c5b
Press This: don't check for already-hoisted global in press-this.php
.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38466
git-svn-id: http://core.svn.wordpress.org/trunk@38407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 06:29:28 +00:00
Scott Taylor
0419d1e318
Press This: in wp_ajax_press_this_save_post()
and wp_ajax_press_this_add_category()
, don't check for a global instance. WP_Press_This
is a Controller, but not really a Singleton. This also keeps it from being a pluggable class, which it is right now.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38465
git-svn-id: http://core.svn.wordpress.org/trunk@38406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 06:25:29 +00:00
Weston Ruter
9546303342
Customize: Improve handling of active state for dynamically-created controls/sections/panels.
...
When a customizer construct (panel, section, control) is not added in PHP, the JS has interpreted this to mean that a given construct should be deactivated (because it is gone). This is problematic for dynamically-created constructs in JS, as it has meant that the construct would also have to be created in PHP to ensure the `active` callback is called, or else a hack would be required to add a `construct.active.validate = function() { return true };` to forcibly prevent the construct from getting deactivated.
These workarounds can be eliminated by treating constructs differently when they are created dynamically in JS (after page load) as opposed to being created statically in PHP (on the server). Namely, if a construct is dynamically-created then its absence in a preview refresh should not signal that the construct should be deactivated. Rather, a dynamic construct should only have its activation state toggled if it has a corresponding construct created in PHP when the preview refreshes to explicitly indicate its `active` state. Otherwise, the management of the `active` state for a construct created in JS should also be the responsibility of client-side code.
Props westonruter, sayedwp.
Fixes #37270 .
Built from https://develop.svn.wordpress.org/trunk@38464
git-svn-id: http://core.svn.wordpress.org/trunk@38405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 06:22:23 +00:00
Scott Taylor
153ba4a832
Query: in wp_old_slug_redirect()
, use get_query_var()
instead of importing and touching the global $wp_query
directly.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38463
git-svn-id: http://core.svn.wordpress.org/trunk@38404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 06:21:41 +00:00
Scott Taylor
1dc37b77ef
Press This: in get_shortcut_link()
, just check a class constant on WP_Press_This
instead of instantiating the object and reading an instance prop.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38462
git-svn-id: http://core.svn.wordpress.org/trunk@38403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 06:08:00 +00:00
Scott Taylor
9383bf8f74
General: use get_bloginfo( 'version' )
instead of global $wp_version
in several locations - excluding those locations which reload version.php
mid-flight.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38459
git-svn-id: http://core.svn.wordpress.org/trunk@38400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 05:49:37 +00:00
Scott Taylor
cabb4a03c8
Multisite: use get_current_site()
instead of $GLOBALS['current_site']
(stop yelling!) in a few remaining spots.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38458
git-svn-id: http://core.svn.wordpress.org/trunk@38399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 05:04:29 +00:00
Scott Taylor
e5225324a2
Multisite: use get_current_blog_id()
where applicable, in lieu of plucking the $blog_id
global from outer space.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38457
git-svn-id: http://core.svn.wordpress.org/trunk@38398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 04:55:54 +00:00
John Blackbourn
049c36d11f
HTTP API: Revert changes to wp_parse_url()
while PHP 5.2 errors are investigated.
...
See #36356
Built from https://develop.svn.wordpress.org/trunk@38456
git-svn-id: http://core.svn.wordpress.org/trunk@38397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 00:24:31 +00:00
Scott Taylor
5d94d97b29
List Tables: AJAX actions for List Tables do not need to declare global $wp_list_table
. List tables on admin screens are in global scope, and they contain hooks that don't pass the the list table as context, hence using globals there so that functions can import them. That problem does not exist in the AJAX actions, which are virtually impossible to hook into as is.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38455
git-svn-id: http://core.svn.wordpress.org/trunk@38396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 20:07:29 +00:00
Scott Taylor
800fb85d1e
OEmbed: add unit tests. @group external-oembed
is not run by default.
...
Props johnbillion, wonderboymusic.
See #32360 .
Built from https://develop.svn.wordpress.org/trunk@38454
git-svn-id: http://core.svn.wordpress.org/trunk@38395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 18:55:28 +00:00
John Blackbourn
d412234bc1
HTTP API: Separate the test for wp_parse_url()
with -1
as its component into a separate test, so the remaining tests can use strict type checking. This helps avoid gotches with the potentially empty values (ie. null
) that we're testing for.
...
See #36356
Built from https://develop.svn.wordpress.org/trunk@38453
git-svn-id: http://core.svn.wordpress.org/trunk@38394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 18:31:30 +00:00
John Blackbourn
fad4b94bab
HTTP API: The tests for wp_parse_url()
can't be strict on type because this causes the tests to fail on PHP 5.2 which, bizarrely, returns the results of parse_url()
(when called with a $component
parameter) in a different order to later PHP versions.
...
Fixes #36356
Built from https://develop.svn.wordpress.org/trunk@38452
git-svn-id: http://core.svn.wordpress.org/trunk@38393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 17:49:29 +00:00
John Blackbourn
3a9cc4bf11
Posts, Post Types: Introduce a missing private query var that should have been introduced as part of #15459 .
...
This private query var allows the hierarchical page query on the Pages listing screen to query for `wp_posts.ID, wp_posts.post_parent` instead of `wp_posts.*`. This introduces large memory and time savings when the site contains a large number of Pages. Combined with the processing time savings introduced in [31730] this makes the Pages listing screen considerably more performant.
Fixes #34982
Props rodrigosprimo
Built from https://develop.svn.wordpress.org/trunk@38451
git-svn-id: http://core.svn.wordpress.org/trunk@38392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 17:40:30 +00:00
John Blackbourn
ebe159a4bc
HTTP API: Prevent a fatal error on PHP < 5.4.7 due to changes introduced in [38449].
...
Fixes #36356
Built from https://develop.svn.wordpress.org/trunk@38450
git-svn-id: http://core.svn.wordpress.org/trunk@38391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 17:16:30 +00:00
John Blackbourn
4fd9ad1ce2
HTTP API: Add a $component
parameter to wp_parse_url()
to give it parity with PHP's parse_url()
function.
...
Fixes #36356
Props jrf
Built from https://develop.svn.wordpress.org/trunk@38449
git-svn-id: http://core.svn.wordpress.org/trunk@38390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 16:36:28 +00:00
Andrea Fercia
99be6ffd3c
Accessibility: Hide the "No activity yet" smiley from assistive technologies.
...
Fixes #37511 .
Built from https://develop.svn.wordpress.org/trunk@38448
git-svn-id: http://core.svn.wordpress.org/trunk@38389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 16:14:30 +00:00
Pascal Birchler
4753f6e127
Script Loader: Properly adjust tests missed in [38443].
...
See #37800 .
Built from https://develop.svn.wordpress.org/trunk@38447
git-svn-id: http://core.svn.wordpress.org/trunk@38388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 14:51:28 +00:00
Boone Gorges
3a4169d7ab
Comments: Don't do direct SQL query when fetching decendants.
...
The SQL query was built using the clauses compiled when querying for
top-level comments. But in cases where the top-level comment query
results are already in the cache, the SQL clauses are not built, and
so are unavailable for `fill_descendants()`. Instead, we call
`get_comments()`, using modified versions of the parameters passed
to the main `WP_Comment_Query` class.
Props Akeif, Rarst for testing.
Fixes #37696 .
Built from https://develop.svn.wordpress.org/trunk@38446
git-svn-id: http://core.svn.wordpress.org/trunk@38387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 14:48:29 +00:00