Commit Graph

62 Commits

Author SHA1 Message Date
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Andrew Nacin
557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 05:26:19 +00:00
Andrew Nacin
b45c550376 Use $gmt_time rather than $local_time in cron, since it uses GMT/UTC and not a local timestamp. see #14391.
git-svn-id: http://core.svn.wordpress.org/trunk@21954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-23 16:57:21 +00:00
ryan
95cfdf2fd6 Introduce cron_request filter. Props ikailo. fixes #13449
git-svn-id: http://core.svn.wordpress.org/trunk@21293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 15:15:22 +00:00
ryan
15c7c9095b Use site_url() to construct the cron url. Props SergeyBiryukov. see #13449
git-svn-id: http://svn.automattic.com/wordpress/trunk@19922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-14 17:53:35 +00:00
ryan
2f915b5320 Use microtime() for cron locks. fixes #19700
git-svn-id: http://svn.automattic.com/wordpress/trunk@19722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-09 19:02:31 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
ryan
5ebcc1d3ea Improve cron locking. Avoid multiple cron processes looping over the same events. fixes #17462
git-svn-id: http://svn.automattic.com/wordpress/trunk@18659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-09 19:59:44 +00:00
nacin
844636bf1c Don't show extra .0 in _deprecated_argument calls. They should appear in @since docs though.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 11:27:38 +00:00
scribu
3b5707c4be Add note about wp_next_scheduled() in wp_schedule_event(). See #14668
git-svn-id: http://svn.automattic.com/wordpress/trunk@16690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-02 16:27:16 +00:00
nacin
d0b26b2d43 Kill check_server_timer(). fixes #15602.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-29 05:16:24 +00:00
ryan
a2ec5bfafa Introduce schedule_event filter. fixes #15146
git-svn-id: http://svn.automattic.com/wordpress/trunk@15837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-18 20:50:35 +00:00
dd32
a14d289755 Alot more tabs. Props jacobsantos & Viper007bond. See #14147
git-svn-id: http://svn.automattic.com/wordpress/trunk@15355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-30 00:05:18 +00:00
ryan
039b8aa6e5 Don't suppress errors when including cron if WP_DEBUG. Props sivel. fixes #11507
git-svn-id: http://svn.automattic.com/wordpress/trunk@14414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 21:46:19 +00:00
westi
ff7831207c Updates and improvements to _depreceated_argument. See #11386 props nacin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-30 16:23:39 +00:00
westi
47a7b1b003 Fix typo in _deprecated_argument() and start using _deprecated_argument() in wp-includes files. See #11386 props nacin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-24 11:12:04 +00:00
westi
53dfdc063b Fix wp_clear_scheduled_hook() so that it function prototype matches the other cron functions.
Include backwards compatibility code so that plugins that used the old way still work.
Fixes #10468.

git-svn-id: http://svn.automattic.com/wordpress/trunk@12462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-19 11:47:16 +00:00
matt
cff2ea75c7 Cast out the lowercase P demons that snuck in. http://www.google.com/search?q=out+out+you+demons+of+stupidity
git-svn-id: http://svn.automattic.com/wordpress/trunk@12341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-08 19:59:34 +00:00
ryan
31f5798fbb Schedule trash collection from admin page loads. see #4529
git-svn-id: http://svn.automattic.com/wordpress/trunk@12120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-27 18:13:42 +00:00
azaozz
2040971211 "Trash" status for comments updates, props caesarsgrunt, see #4529
git-svn-id: http://svn.automattic.com/wordpress/trunk@11741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-07-24 07:23:11 +00:00
ryan
6c8badc7c7 Fix handling of old timestamps in wp_reschedule_event(). Props natethelen. fixes #9318
git-svn-id: http://svn.automattic.com/wordpress/trunk@10969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-17 00:23:48 +00:00
westi
d2faeef333 Improve cron phpdoc.
git-svn-id: http://svn.automattic.com/wordpress/trunk@10898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-08 20:16:59 +00:00
azaozz
c8a972ed3e Add filter for local connection ssl verify to cron spawning, props sivel, see #8702
git-svn-id: http://svn.automattic.com/wordpress/trunk@10526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-02-08 15:26:16 +00:00
azaozz
a4df9a5326 Cron spawning improvement, see #9005
git-svn-id: http://svn.automattic.com/wordpress/trunk@10521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-02-07 13:32:34 +00:00
ryan
8c7d54a9dc Use transient for doing_cron. see #9048
git-svn-id: http://svn.automattic.com/wordpress/trunk@10519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-02-06 22:25:35 +00:00
azaozz
22e8d0e0e5 Spawn cron with AJAX request, see #9005
git-svn-id: http://svn.automattic.com/wordpress/trunk@10474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-31 02:23:24 +00:00
ryan
ae50ab2d59 Lose hash check
git-svn-id: http://svn.automattic.com/wordpress/trunk@10473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-30 22:35:41 +00:00
ryan
059800a983 cron phpdoc fixes. Props filosofo. fixes #8680 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@10233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-19 20:47:20 +00:00
ryan
40c754df1d Unused var fixes. Props DD32. see #8220
git-svn-id: http://svn.automattic.com/wordpress/trunk@9716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-15 18:10:35 +00:00
ryan
cdb2fa6a66 Fix the fix
git-svn-id: http://svn.automattic.com/wordpress/trunk@9407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-29 22:59:47 +00:00
ryan
25f4e26d33 Wrong view ryan
git-svn-id: http://svn.automattic.com/wordpress/trunk@9406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-29 22:56:48 +00:00
ryan
9479b4ed91 Formatting cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@9403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-29 20:26:20 +00:00
ryan
7ae1291c12 don't schedule a duplicate if there's already an identical event due in the next 10 minutes. Props tellyworth. fixes #6966
git-svn-id: http://svn.automattic.com/wordpress/trunk@9181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-15 06:00:42 +00:00
azaozz
0853ba158c Cron improvement, props hailin, fixes #7068
git-svn-id: http://svn.automattic.com/wordpress/trunk@8927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-18 07:09:38 +00:00
ryan
bc6cb67cc4 phpdoc for cron.php. Props jacobsantos and hansengel. fixes #5637
git-svn-id: http://svn.automattic.com/wordpress/trunk@8806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-04 19:12:40 +00:00
markjaquith
74c46749cb Cast to array when using foreach(). Props santosj (and thanks for your perseverance!). fixes #2784
git-svn-id: http://svn.automattic.com/wordpress/trunk@8572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-06 20:31:54 +00:00
ryan
b8dc4a3377 Don't use wp_guess_url(). Caused big problems. see #4779
git-svn-id: http://svn.automattic.com/wordpress/trunk@8537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-04 19:19:05 +00:00
ryan
ccbc13a123 Use wp_guess_url() for determining the cron URL. Props jacobsantos. see #4779
git-svn-id: http://svn.automattic.com/wordpress/trunk@8529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-03 21:07:21 +00:00
ryan
6425f7db9d Formatting changes and non-blocking mode. Props DD32. see #4779
git-svn-id: http://svn.automattic.com/wordpress/trunk@8519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-01 16:36:50 +00:00
ryan
3c99cfc4f5 HTTP POST and REQUEST API from jacobsantos. see #4779
git-svn-id: http://svn.automattic.com/wordpress/trunk@8516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-01 05:00:07 +00:00
ryan
06a67ae8d2 Don't run get_plugins() on every admin page load. Use cron for async update plugin requests. see #7372
git-svn-id: http://svn.automattic.com/wordpress/trunk@8514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-01 04:26:32 +00:00
ryan
6a0629e717 Take port into consideration when spawning cron. Props bchecketts. fixes #4782
git-svn-id: http://svn.automattic.com/wordpress/trunk@5972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-29 17:57:06 +00:00
ryan
2f09416258 Trim empty lines. Nothing but newline.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-14 02:25:30 +00:00
ryan
02cfbbe93b Use wp_hash to create cron's check hash.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-04-16 20:47:23 +00:00
ryan
1f35a9de8f Make sure openssl is available. Props Robert Deaton and rob1n. fixes #3765
git-svn-id: http://svn.automattic.com/wordpress/trunk@4984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-07 04:16:06 +00:00
ryan
6154ec1c7e Fix spawning with SSL. Props dragonhard and rob1n. fixes #3765
git-svn-id: http://svn.automattic.com/wordpress/trunk@4980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-07 01:47:57 +00:00
markjaquith
d0f79bb3f2 trailing tabs and whitespace cleanup.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-02-27 15:24:54 +00:00
markjaquith
b4671adb74 Prevent a missing wp-cron.php from causing an infinite loop. Props jan. fixes #3713
git-svn-id: http://svn.automattic.com/wordpress/trunk@4834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-01-30 13:06:56 +00:00
ryan
287467334e Change cron arg passing. Props masquerade. fixes #3169.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-08 17:50:21 +00:00
markjaquith
a450c80a6a case insensitive sorting. props Nazgul. fixes #3108
git-svn-id: http://svn.automattic.com/wordpress/trunk@4289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-04 03:49:56 +00:00