Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-05 18:32:23 +01:00
Code Issues Projects Releases Wiki Activity
39,674 Commits 50 Branches 747 Tags 790 MiB
349d95f27a
Commit Graph

51 Commits

Author SHA1 Message Date
Adam Silverstein
b287642342 Feeds: improve structure and naming of feed build date helper function. 
Simplify overall code structure by passing the required format to the helper function.
Clarify functionality by renaming `get_last_build_date` to `get_feed_build_date`.

Props pento, spacedmonkey.
Fixes #4575.


Built from https://develop.svn.wordpress.org/trunk@45247


git-svn-id: http://core.svn.wordpress.org/trunk@45056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 17:08:52 +00:00
Adam Silverstein
4268033aaf Feeds: ensure build/update date matches current query. 
Displaying the correct build date in feeds is as important today as it was twelve years ago when this ticket was opened.

Fix an issue where all feeds in WordPress showed the same date for their last build date (the datapoint is `lastBuildDate`, `updated` or `dc:date` depending on the feed type). 

Introduce a new `get_last_build_date` filter to adjust the date used for `lastBuildDate`. Developers who previously filtered `get_lastcommentmodified` to alter feed dates should use this filter instead.

* `get_last_build_date` extracts the latest post (or comment) in the current WP_Query object.
* In all feed templates, use `get_last_build_date` vs `get_lastpostmodified( 'GMT' );`.

Props stevenkword, spacedmonkey, ryanshoover, mauteri, nacin, jorbin, MikeNGarrett, Denis-de-Bernardy, peaceablewhale.
Fixes #4575.


Built from https://develop.svn.wordpress.org/trunk@44948


git-svn-id: http://core.svn.wordpress.org/trunk@44779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-20 20:39:00 +00:00
Gary Pendergast
7a617078fa Coding Standards: Upgrade WPCS to 1.2.1. 
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.


Built from https://develop.svn.wordpress.org/trunk@44574


git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-12 06:41:52 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
Sergey Biryukov
4848a09b35 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders. 
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.

Fixes #43523.
Built from https://develop.svn.wordpress.org/trunk@42827


git-svn-id: http://core.svn.wordpress.org/trunk@42657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-03-11 16:44:34 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Dion Hulse
f794939ed3 Feeds: Do not translate the lastBuildDate field in RSS feeds. 
Props stevenkword, dd32.
Fixes #39141

Built from https://develop.svn.wordpress.org/trunk@39613


git-svn-id: http://core.svn.wordpress.org/trunk@39553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-12-16 06:39:41 +00:00
John Blackbourn
4cf5550d8d I18n: Begin introducing translator comments for strings which include placeholders but no accompanying translator comment. 
Adds context to one string used in two different contexts for the new user and new site signup email notification.

More to come.

See #38882

Built from https://develop.svn.wordpress.org/trunk@39323


git-svn-id: http://core.svn.wordpress.org/trunk@39263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-11-21 01:22:32 +00:00
Rachel Baker
2f263fce99 Feeds: Always return a valid timestamp for the Last-Modified header of comment or post feeds. 
Fixes bug where an invalid Last-Modified value would be returned in feed requests for sites that had 0 items to return. Comment or post feeds will now return the current timestamp as the Last-Modified header value.  Example: a request for the comments feed for a site without any comments.

Replaced use of the local static variable `$cache_lastcommentmodified` to store the modified date in `get_lastcommentmodified()` with the Object Cache API.  The `get_lastcommentmodified()` function returns early if there is a cached value and returns `false` if there where no comments found. Introduced `_clear_modified_cache_on_transition_comment_status()` to flush the `lastcommentmodified` cache key when a comment enters or leaves approval status. In `get_lastpostmodified()` return early if there is a cached value and return `false` if there are no posts found.

Props swissspidy, rachelbaker, dllh, leobaiano.
Fixes #38027.
Built from https://develop.svn.wordpress.org/trunk@38925


git-svn-id: http://core.svn.wordpress.org/trunk@38868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-25 20:48:29 +00:00
Konstantin Obenland
c69e96422b Themes: Improve document title output. 
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.


Built from https://develop.svn.wordpress.org/trunk@35294


git-svn-id: http://core.svn.wordpress.org/trunk@35260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-20 16:21:25 +00:00
Konstantin Obenland
3271513442 Feeds: Revert [32765] because of objections raised in #4575. 
Built from https://develop.svn.wordpress.org/trunk@33281


git-svn-id: http://core.svn.wordpress.org/trunk@33253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-15 19:58:24 +00:00
Aaron Jorbin
cbb6f91a29 Improve lastBuildDate timestamp in rss feeds 
RSS feed timestamps should reflect the actual timestamps for those RSS feeds rather than the generic timestamp for all posts and all comments. 

Props stevenkword.
Fixes #4575.



Built from https://develop.svn.wordpress.org/trunk@32765


git-svn-id: http://core.svn.wordpress.org/trunk@32736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:37:24 +00:00
Scott Taylor
3ec1d3bf9d Serve RSS feeds with the proper mime-type: application/rss+xml. The reason for hacking around browsers by using text/xml appears to no longer be relevant. 
Props @chriscct7.
Reverts [11334] and [11358]
Fixes #15110.

Built from https://develop.svn.wordpress.org/trunk@32468


git-svn-id: http://core.svn.wordpress.org/trunk@32438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-09 06:39:24 +00:00
John Blackbourn
bdd00b3902 Improve various hook and filter docs so they are correctly parsed for the code reference. 
Fixes #30558
Props DrewAPicture

Built from https://develop.svn.wordpress.org/trunk@30754


git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:32:24 +00:00
Sergey Biryukov
c321e40016 Introduce 'rss_tag_pre' action, which fires between the xml and rss tags in a feed. 
props solarissmoke, wonderboymusic, DrewAPicture.
fixes #19017.
Built from https://develop.svn.wordpress.org/trunk@29014


git-svn-id: http://core.svn.wordpress.org/trunk@28802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 10:18:15 +00:00
Andrew Nacin
70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository. 
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-25 02:29:52 +00:00
Andrew Nacin
5361a8abca Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:59:20 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Ryan Boren
b87d4b77e5 Pinking shears 
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-23 14:38:10 +00:00
Andrew Nacin
74488bdcb0 Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-22 17:22:11 +00:00
Drew Jaynes
fe5ee3c5b3 Inline documentation of hooks for wp-includes/feed-rss2-comments.php. 
Props dustyf.
See #25229.

Built from https://develop.svn.wordpress.org/trunk@25532


git-svn-id: http://core.svn.wordpress.org/trunk@25452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-20 23:02:09 +00:00
Peter Westwood
cfdc33879e Use a CDATA second for comment authors in RSS2 comment feeds so that HTML in comments doesn't kill the XML validation. 
Fixes #17767 props wonderboymusic, dzver.

Built from https://develop.svn.wordpress.org/trunk@25009


git-svn-id: http://core.svn.wordpress.org/trunk@25003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-07 13:43:43 +00:00
ryan
29e6ade734 Use get_search_query() in feed-rss2-comments.php. Props SergeyBiryukov. fixes #21365 
git-svn-id: http://core.svn.wordpress.org/trunk@21332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-25 18:04:17 +00:00
markjaquith
a96c5c0b2a Use a CDATA section for RSS2 comments feeds, so HTML in comments doesn't kill XML validation. props bazza. fixes #16466 
git-svn-id: http://core.svn.wordpress.org/trunk@21238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-09 04:25:57 +00:00
westi
0826f08315 Set up the post global variable in the comment feed loops so that any calls to post related template tags work correctly. 
Ensures that atom feeds show threading for top-level comments correctly.
Fixes #14908 props solarissmoke and SergeyBiryukov.

git-svn-id: http://svn.automattic.com/wordpress/trunk@18716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-19 12:39:59 +00:00
westi
d8490aeea2 Add the generator element in feeds through the {rss2|atom|rdf|rss|opml}_head hooks. Fixes #6947 props sivel. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-13 16:45:16 +00:00
ryan
a5e73d3b9b Fix feed autodiscovery. Props peaceablewhale. fixes #9810 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-16 05:15:21 +00:00
ryan
1354d0660a Don't localize dates where not appropriate. Props Denis-de-Bernardy, hakre. fixes #9730 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-14 02:00:32 +00:00
ryan
c90e3f5f81 Feed namespace hooks. Props Denis-de-Bernardy, peaceablewhale. fixes #9792 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-12 16:57:49 +00:00
westi
3d95157033 Add a 'rss2_comments_ns' action to the namespaces section of the RSS2 comments feed. Fixes #5819. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-11 21:02:18 +00:00
ryan
0d4c0a54da Proper lastBuildDate for rss2 comments feed. Props peaceablewhale. fixes #9567 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-05 20:36:20 +00:00
markjaquith
6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-05 19:43:53 +00:00
ryan
2d489767bb s/attribute_escape/attr/. see #9650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-28 05:58:45 +00:00
azaozz
3949fb7e90 Add support for automatic feed links in themes, props Viper007Bond, see #8878 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-19 05:04:58 +00:00
ryan
34f737b984 Remove uuml. Props nbachiyski. fixes #8464 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-05 17:33:24 +00:00
ryan
fe44ea7c48 No named entities in comment feeds. Props nbachiyski. fixes #8464 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-04 17:47:50 +00:00
ryan
ed01be1927 Use post_password_required() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-20 19:10:31 +00:00
westi
ef8d0a6e30 Add syndication frequency recommendations to rss2 feeds. See #3513 props _ck_. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-11 20:50:41 +00:00
westi
77c0f608c8 Better self links for feeds. Fixes #5238 props andy. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-03-11 18:18:22 +00:00
markjaquith
5b22db23d1 Make RSS 2.0 comment feed GUIDs immutable. fixes #5072 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-06 22:33:21 +00:00
ryan
09f2286a41 Some file level phpdoc from darkdragon. fixes #5527 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-25 20:48:01 +00:00
westi
c75ec2b48a Add atom:self link to rss2 feeds per RSS Best Practices Profile. Fixes #5205 props lexhair and rubys. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-10-20 10:35:44 +00:00
westi
e9cfb43133 Centralise generator generation, move theme generator generation to wp-head hook. Fixes #5085, #4803. props docwhat, Viper007Bond. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-10-06 06:55:24 +00:00
ryan
321c310717 Remove trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-09-03 23:32:58 +00:00
ryan
763f8b8821 commentsrss2_head action from joostdevalk. fixes #4694 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-21 18:32:39 +00:00
ryan
9b395107f4 Deprecate permalink_single_rss(). Add the_permalink_rss() with accompanying filter. Props joostdevalk and Otto42. fixes #4654 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-21 18:27:45 +00:00
ryan
19f1e721bb Use dc:creator instead of author for rss2 comment feeds. Props lexhair, Otto42. fixes #4704 for 2.3 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-16 18:34:57 +00:00
ryan
ed549303d7 Move the_title filter to get_the_title. Props jhodgdon. fixes #4477 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-25 17:48:35 +00:00
rob1n
9ce729e656 Content-Type, not Content-type, as headers are case sensitive. Props foolswisdom and Nazgul. fixes #3545 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-02 05:21:18 +00:00
ryan
4bec99a338 Comment feeds everywhere. Props mdawaffe and rob1n. fixes #2485 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-02-24 07:33:29 +00:00