WordPress

mirror of https://github.com/WordPress/WordPress.git synced 2024-11-03 09:21:03 +01:00

Author	SHA1	Message	Date
desrosj	689fdc6319	Site Health: Verify PHP version requirements when auto-updating themes. Follow up of [47819]. See #49653. Fixes #50411. Built from https://develop.svn.wordpress.org/trunk@48071 git-svn-id: http://core.svn.wordpress.org/trunk@47838 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-17 14:48:07 +00:00
Sergey Biryukov	de59ad23a4	Docs: Consistently include an empty line between `@since` tag and `@see`, `@link`, or `@global`, per the documentation standards. See #49572. Built from https://develop.svn.wordpress.org/trunk@48067 git-svn-id: http://core.svn.wordpress.org/trunk@47834 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-16 21:07:14 +00:00
Andrea Fercia	f83c504b88	I18N: Remove the "Error:" prefix from error messages. For a number of years, most of the WordPress error messages have been prefixed with "Error:". However, these messages appear in a context where it's already clear an error occurred. Whether it's an error, a warning, or any other classification, that's not so relevant for users. The content of the message is the relevant part. The "Error:" prefix doesn't add great value while it does add unnecessary complexity for the message readability. Also, revises some of these messages to improve clarity and removes HTML from translatable strings. Props garrett-eclipse, ramiy, SergeyBiryukov, afercia, sabernhardt, quadthemes, audrasjb. See #47003, #43037, #42945, #15887. Fixes #47656. Built from https://develop.svn.wordpress.org/trunk@48059 git-svn-id: http://core.svn.wordpress.org/trunk@47826 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-16 15:35:13 +00:00
whyisjake	28d29b35f7	Comments: Don't display edit links to trashed post comments. If a post is in the trash, the comments bubble won't link to the comments list. Fixes: #37826. Props: swissspidy, helen, FolioVision, DrewAPicture, stevenlinx, donmhico, birgire, garrett-eclipse, andraganescu, johnbillion. Built from https://develop.svn.wordpress.org/trunk@48050 git-svn-id: http://core.svn.wordpress.org/trunk@47817 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-15 23:06:08 +00:00
Dominik Schilling	9f7a7f8d57	Coding Standards: Fix code indentation in `post_submit_meta_box()` to improve readability. See #49542. Built from https://develop.svn.wordpress.org/trunk@48041 git-svn-id: http://core.svn.wordpress.org/trunk@47808 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-14 16:31:08 +00:00
Sergey Biryukov	4cc11cdbdd	Filesystem API: Avoid a PHP notice in `WP_Filesystem_Direct::owner()` and `::group()` methods and their `WP_Filesystem_SSH2` counterparts. Although not officially documented in the PHP manual, `posix_getpwuid()` and `posix_getgrgid()` can return `false` in some circumstances. Props logig. Fixes #50373. Built from https://develop.svn.wordpress.org/trunk@48031 git-svn-id: http://core.svn.wordpress.org/trunk@47798 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-12 12:35:09 +00:00
whyisjake	dda0ccdd18	Administration: Add a new filter to extend `set-screen-option`. Props: xknown, SergeyBiryukov. Built from https://develop.svn.wordpress.org/trunk@47951 git-svn-id: http://core.svn.wordpress.org/trunk@47723 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-10 17:24:51 +00:00
whyisjake	7e9267567f	Editor: Prevent HTML decoding on by setting the proper editor context. Props: sstoqnov. Built from https://develop.svn.wordpress.org/trunk@47948 git-svn-id: http://core.svn.wordpress.org/trunk@47720 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-10 17:21:20 +00:00
desrosj	784908ae5f	Coding Standards: PHP short ternary operator syntax is not allowed. WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook. Follow up of [47927]. Fixes #50258. Built from https://develop.svn.wordpress.org/trunk@47929 git-svn-id: http://core.svn.wordpress.org/trunk@47702 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-08 21:27:10 +00:00
Sergey Biryukov	18a9359c06	Posts, Post Types: Display a more specific error message when an attachment could not be inserted into the database. Props shital-patel, Presskopp, ocean90. Fixes #50325. Built from https://develop.svn.wordpress.org/trunk@47922 git-svn-id: http://core.svn.wordpress.org/trunk@47696 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-07 09:24:11 +00:00
Adam Silverstein	0b9a800512	Media: remove any `attachment-filter` query param when switching views. Fix an issue where the media attachment filter no longer worked after switching to list view, filtering by a media type then switching back to the grid view. Props itzmekhokan, netsurfer2705, zodiac1978. Fixes #43656. Built from https://develop.svn.wordpress.org/trunk@47915 git-svn-id: http://core.svn.wordpress.org/trunk@47689 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-05 21:13:10 +00:00
Sergey Biryukov	4bbb7fb852	Docs: Update the DocBlock for the `wp_media_attach_action` hook per the documentation standards. Rename the `$att_id` variable to `$attachment_id` for clarity. Follow-up to [47909]. See #49614. Built from https://develop.svn.wordpress.org/trunk@47913 git-svn-id: http://core.svn.wordpress.org/trunk@47687 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-05 08:30:10 +00:00
desrosj	b013a15d43	Accessibility: Add the `aria-hidden` attribute to the auto-update related icons. `<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative. Props audrasjb, ryokuhi. Fixes #50293. Built from https://develop.svn.wordpress.org/trunk@47910 git-svn-id: http://core.svn.wordpress.org/trunk@47684 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-04 15:47:09 +00:00
whyisjake	00d3696923	Media: Add an action for `wp_media_attach_action`. This action fires when media is attached/detached from a post. Fixes: #49614. Props: jonoaldersonwp, antpb, rebasaurus, donmhico. Built from https://develop.svn.wordpress.org/trunk@47909 git-svn-id: http://core.svn.wordpress.org/trunk@47683 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-04 15:00:09 +00:00
Sergey Biryukov	b50e87d52b	Docs: Add missing `@global` reference for the `$post_id` global in `wp_admin_bar_edit_menu()`. Follow-up to [47903]. Props davidbaumwald. See #50312. Built from https://develop.svn.wordpress.org/trunk@47906 git-svn-id: http://core.svn.wordpress.org/trunk@47680 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-03 21:27:09 +00:00
desrosj	27485fd7aa	General: Continuing to work towards a passing PHP Compatibility scan. This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments. With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750). Props desrosj, johnbillion, jrf. See #49922. Built from https://develop.svn.wordpress.org/trunk@47902 git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-03 17:40:12 +00:00
Sergey Biryukov	f22e113e95	File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors. Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL. Follow-up to [46230]. Props munyagu. Fixes #50309. See #47957. Built from https://develop.svn.wordpress.org/trunk@47896 git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-03 11:43:15 +00:00
Sergey Biryukov	cf597dcf7c	Plugins: Make the message displayed when no plugins are installed more concise. Props johnjamesjacoby, Presskopp. Fixes #42336. Built from https://develop.svn.wordpress.org/trunk@47894 git-svn-id: http://core.svn.wordpress.org/trunk@47668 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-03 10:51:13 +00:00
whyisjake	69a866a1a9	Administration: Unify the date structure in list view and excerpt view. Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`. Fixes: #35391. Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson. Built from https://develop.svn.wordpress.org/trunk@47879 git-svn-id: http://core.svn.wordpress.org/trunk@47653 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-01 19:15:08 +00:00
gziolo	c704057e0d	Add fields to WP_Block_Type As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them. Props spacedmonkey, aduth. Fixes #48529. Built from https://develop.svn.wordpress.org/trunk@47875 git-svn-id: http://core.svn.wordpress.org/trunk@47649 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-01 12:27:08 +00:00
Andrea Fercia	38b7495af7	Administration and Site Health: Make information on Search engine visibility more prominent. - makes the "Search engines discouraged" message on the Dashboard more prominent - adds "Search engine visibility" information under Site Health > Info > WordPress - removes title case in favor of sentence case in all the related strings Props audrasjb, swissspidy, emanuel_blagonic, Presskopp, karmatosed, valentinbora, melchoyce. Fixes #35288. Built from https://develop.svn.wordpress.org/trunk@47859 git-svn-id: http://core.svn.wordpress.org/trunk@47635 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-27 14:33:11 +00:00
whyisjake	57fb3c6cf0	Coding Standards: Change auto-update filters to be more consistent. * send_theme_auto_update_email 👉 auto_theme_update_send_email * wp_plugins_auto_update_enabled 👉 plugins_auto_update_enabled * wp_themes_auto_update_enabled 👉 themes_auto_update_enabled Want to make sure that @ronalfy gets props for his work in #50052 too. See #50052. Props: ronalfy, pbiron, azaozz, audrasjb, whyisjake. Built from https://develop.svn.wordpress.org/trunk@47857 git-svn-id: http://core.svn.wordpress.org/trunk@47633 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-26 18:03:08 +00:00
Sergey Biryukov	7b192d406a	Coding Standards: Fix instances of `Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty`. See #49542. Built from https://develop.svn.wordpress.org/trunk@47855 git-svn-id: http://core.svn.wordpress.org/trunk@47631 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-26 09:37:10 +00:00
Sergey Biryukov	5b4174e409	Coding Standards: Use strict comparison for more `count()` calls. Follow-up to [47848]. Props mukesh27. Fixes #50232. See #49542. Built from https://develop.svn.wordpress.org/trunk@47851 git-svn-id: http://core.svn.wordpress.org/trunk@47627 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-23 16:22:07 +00:00
Sergey Biryukov	b9751d4efe	Coding Standards: Use strict comparison for `count()` calls. See #49542. Built from https://develop.svn.wordpress.org/trunk@47848 git-svn-id: http://core.svn.wordpress.org/trunk@47624 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-23 11:38:08 +00:00
Sergey Biryukov	5850f5f6ef	Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-site-health-auto-updates.php`. See #49542. Built from https://develop.svn.wordpress.org/trunk@47841 git-svn-id: http://core.svn.wordpress.org/trunk@47617 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-22 17:56:08 +00:00
Sergey Biryukov	64ed8a7355	Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-debug-data.php`. Follow-up to [47550], [47557], [47835]. See #50052. Built from https://develop.svn.wordpress.org/trunk@47840 git-svn-id: http://core.svn.wordpress.org/trunk@47616 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-22 17:26:07 +00:00
Sergey Biryukov	ba03c426db	Docs: Add missing `@since` tag for `auto_plugin_theme_update_email` filter. See #50052. Built from https://develop.svn.wordpress.org/trunk@47836 git-svn-id: http://core.svn.wordpress.org/trunk@47612 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-20 19:33:10 +00:00
whyisjake	661b929e1e	Security: Add user interface to auto-update themes and plugins. Building on core update mechanisms, this adds the ability to enable automatic updates for themes and plugins to the WordPress admin. Fixes: #50052. Props: afercia, afragen, audrasjb, azaozz, bookdude13, davidperonne, desrosj, gmays, gmays, javiercasares, karmatosed, knutsp, mapk, mukesh27, netweb, nicolaskulka, nielsdeblaauw, paaljoachim, passoniate, pbiron, pedromendonca, whodunitagency, whyisjake, wpamitkumar, and xkon. Built from https://develop.svn.wordpress.org/trunk@47835 git-svn-id: http://core.svn.wordpress.org/trunk@47611 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-20 18:49:09 +00:00
Sergey Biryukov	307725883a	Themes: Prevent installation of themes that require a higher version of PHP or WordPress. Props afragen. Fixes #49653. See #48491. Built from https://develop.svn.wordpress.org/trunk@47819 git-svn-id: http://core.svn.wordpress.org/trunk@47595 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-18 16:03:09 +00:00
Sergey Biryukov	54cdfaef59	Themes: Remove extra whitespace from `wp-admin/includes/ajax-actions.php` and `wp-admin/includes/theme.php`. Follow-up to [47816]. See #48491. Built from https://develop.svn.wordpress.org/trunk@47818 git-svn-id: http://core.svn.wordpress.org/trunk@47594 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-18 12:55:06 +00:00
Sergey Biryukov	b73bbd8139	Themes: Prevent activation and live preview of themes that require a higher version of PHP or WordPress. Props afragen, jorbin, TimothyBlynJacobs, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@47816 git-svn-id: http://core.svn.wordpress.org/trunk@47592 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-18 12:32:10 +00:00
Sergey Biryukov	d528d7a044	Site Health: Use `WP_Theme::parent()` in the inactive themes test as a more reliable check that the parent theme exists. This is also more consistent with the other instances of directly referencing `WP_Theme::parent()` properties or methods in core. Props mukesh27, juanlopez4691, davidbaumwald, afragen, SergeyBiryukov. Fixes #49934. Built from https://develop.svn.wordpress.org/trunk@47815 git-svn-id: http://core.svn.wordpress.org/trunk@47591 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-18 04:38:10 +00:00
Sergey Biryukov	91936df3d1	Coding Standards: Fix WPCS issues in plugin and theme upgrader classes. See #49542. Built from https://develop.svn.wordpress.org/trunk@47814 git-svn-id: http://core.svn.wordpress.org/trunk@47590 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-17 09:39:11 +00:00
Sergey Biryukov	7932193708	Coding Standards: Use strict comparison where static strings are involved. This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890. Includes minor code layout fixes for better readability. See #49542. Built from https://develop.svn.wordpress.org/trunk@47808 git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-16 18:42:12 +00:00
Sergey Biryukov	16a8128765	Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-screen.php`. See #49542. Built from https://develop.svn.wordpress.org/trunk@47802 git-svn-id: http://core.svn.wordpress.org/trunk@47578 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-15 18:13:09 +00:00
Sergey Biryukov	69adb593a2	Themes: Add "Block Editor Patterns" and "Full Site Editing" to the list of WordPress theme features. Follow-up to [meta9876]. Props dingo_d. Fixes #50164. See #meta5212. Built from https://develop.svn.wordpress.org/trunk@47797 git-svn-id: http://core.svn.wordpress.org/trunk@47573 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-14 14:43:08 +00:00
Sergey Biryukov	fb0e6531ab	Docs: Add `@since` notes for theme features added or removed in `get_theme_feature_list()` after its introduction in WordPress 3.1. See #50165. Built from https://develop.svn.wordpress.org/trunk@47794 git-svn-id: http://core.svn.wordpress.org/trunk@47570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-14 12:50:08 +00:00
Sergey Biryukov	04e3fd6995	Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features. These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now. Follow-up to [meta8273]. See #46272. Built from https://develop.svn.wordpress.org/trunk@47790 git-svn-id: http://core.svn.wordpress.org/trunk@47566 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-14 09:18:08 +00:00
Sergey Biryukov	5e42a6c9e5	Export: Use correct escaping function for term IDs in `<wp:term>` nodes. Follow-up to [34333]. Props DrLightman, marcio-zebedeu. Fixes #50113. Built from https://develop.svn.wordpress.org/trunk@47789 git-svn-id: http://core.svn.wordpress.org/trunk@47565 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-14 07:55:12 +00:00
Sergey Biryukov	bfba3fc458	Docs: Improve documentation for functions in `wp-admin/install-helper.php` per the documentation standards. Synchronize descriptions with the functions' counterparts from `wp-admin/includes/upgrade.php`. See #49572. Built from https://develop.svn.wordpress.org/trunk@47786 git-svn-id: http://core.svn.wordpress.org/trunk@47562 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-12 18:40:07 +00:00
Sergey Biryukov	aa69c25d5f	Coding Standards: Use strict comparison in some `wp-admin` files. Props pikamander2, mukesh27, SergeyBiryukov. Fixes #49239. Built from https://develop.svn.wordpress.org/trunk@47785 git-svn-id: http://core.svn.wordpress.org/trunk@47561 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-12 18:32:08 +00:00
Sergey Biryukov	3fc1b33d53	Docs: Use 3-digit, x.x.x style semantic versioning for inline comments in `populate_options()`. See #49572. Built from https://develop.svn.wordpress.org/trunk@47782 git-svn-id: http://core.svn.wordpress.org/trunk@47558 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-11 17:26:08 +00:00
Sergey Biryukov	5511b43e2c	Administration: Avoid a PHP 7.4 notice in `add_meta_box()` when attempting to re-add a previously removed box. The logic for skipping previously removed meta boxes with the `core` priority should also apply to the `sorted` priority that is used when the boxes were manually reordered. Add a unit test. Props coolmann, franzarmas, SergeyBiryukov. Fixes #50019. Built from https://develop.svn.wordpress.org/trunk@47777 git-svn-id: http://core.svn.wordpress.org/trunk@47553 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-09 12:26:12 +00:00
Sergey Biryukov	1cde7d86f9	Coding Standards: Fix WPCS issues in `wp-admin/includes/template.php`. See #49542. Built from https://develop.svn.wordpress.org/trunk@47775 git-svn-id: http://core.svn.wordpress.org/trunk@47551 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-08 16:36:18 +00:00
Dominik Schilling	7ded6c2d2a	Administration: Remove any CSS related to Internet Explorer versions 6 – 10. In WordPress 3.2 support for IE6 was dropped, IE7 followed a few versions later. With the 4.8 release, WordPress officially ended support for Internet Explorer versions 8, 9, and 10. Yet, we still have shipped CSS for the unsupported IE versions....until now! Goodbye to ie.css and star hacks! * Removes ie.css and `ie` style handle. * Removes IE specific class names and any related CSS. * Drops support for IE8 and older in `wp_customize_support_script()`. * Updates compatibility mode for CSS minification to `ie11`. Props ayeshrajans, isabel_brison, afercia, netweb, peterwilsoncc, ocean90. Fixes #17232, #46015. Built from https://develop.svn.wordpress.org/trunk@47771 git-svn-id: http://core.svn.wordpress.org/trunk@47547 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-06 20:15:07 +00:00
Sergey Biryukov	9782eb82ad	Site Health: Display the original PHP memory limit on Site Health Info screen. This ensures that if the limit has been modified for admin screens by `wp_raise_memory_limit()`, the original value is displayed along with the current value. Props Clorith, espiat, zodiac1978, SergeyBiryukov. Fixes #49329. Built from https://develop.svn.wordpress.org/trunk@47762 git-svn-id: http://core.svn.wordpress.org/trunk@47538 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-05 18:58:09 +00:00
John Blackbourn	1a27d51b48	Menus: Allow empty taxonomy terms to be surfaced when searching for items. This brings the behaviour inline with that of browsing terms or using the All Items tab, which correctly shows empty terms. Props birgire, audrasjb Fixes #45298 Built from https://develop.svn.wordpress.org/trunk@47747 git-svn-id: http://core.svn.wordpress.org/trunk@47523 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-02 22:36:07 +00:00
Dominik Schilling	a6f3ad2d21	Users: Don't reset user language preference on user update. Props johnbillion. Fixes #38665. Built from https://develop.svn.wordpress.org/trunk@47739 git-svn-id: http://core.svn.wordpress.org/trunk@47515 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-02 16:29:06 +00:00
desrosj	89ddd19884	General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset. As part of the continued effort to improve PHP compatibility, the following improvments are being made: - Removing deprecated PHP `safe_mode` checks not found in bundled external libraries. - Change the remaining `while` loops using `each()` to `foreach` loops. - Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way. - Add inline comments to not flag deprecated PHP directives in the getID3 library. Props desrosj, earnjam, dryanpress. See #49922. Built from https://develop.svn.wordpress.org/trunk@47735 git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-01 19:07:09 +00:00
Sergey Biryukov	10945d2f3d	Taxonomy: Restore (un-deprecate) the `tag_row_actions` filter. The filter provides a simple way for plugin authors to add actions generically for all taxonomy list tables without looping through each taxonomy individually. Props joemcgill, delowardev. Fixes #49808. Built from https://develop.svn.wordpress.org/trunk@47734 git-svn-id: http://core.svn.wordpress.org/trunk@47510 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-01 16:45:09 +00:00
Sergey Biryukov	3dc1e33fb5	Networks and Sites: Link to Nginx documentation on Network Setup screen when Nginx is in use. Props lipathor, audrasjb, johnbillion, flixos90. Fixes #41166. Built from https://develop.svn.wordpress.org/trunk@47632 git-svn-id: http://core.svn.wordpress.org/trunk@47407 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-29 14:43:09 +00:00
Sergey Biryukov	5371e3fd62	Site Health: Avoid a PHP notice in `WP_Site_Health::wp_cron_scheduled_check()` if async test response does not contain the expected result. Additionally, avoid a PHP notice in `::get_test_php_version()` if the minimum recommended version of PHP could not be determined. Props schlessera, oakesjosh. Fixes #49943. Built from https://develop.svn.wordpress.org/trunk@47628 git-svn-id: http://core.svn.wordpress.org/trunk@47403 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-27 22:01:08 +00:00
Sergey Biryukov	61a2f62ffd	Comments: Use `comment` instead of an empty string for the `comment_type` DB field value in comments table. This is the first step to bring support for custom comment types into WordPress. Add a scheduled upgrade routine to update the type value for existing comments, in batches of 100 at a time. Props imath, aaroncampbell, jeremyfelt, dshanske. Fixes #49236. Built from https://develop.svn.wordpress.org/trunk@47597 git-svn-id: http://core.svn.wordpress.org/trunk@47372 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-17 19:35:06 +00:00
Sergey Biryukov	af1a737b48	Coding Standards: Fix WPCS indentation issue in `wp-admin/includes/class-wp-links-list-table.php`. This was causing a `Generic.WhiteSpace.ScopeIndent.IncorrectExact` error if PHP_CodeSniffer 3.4.1 or newer is installed locally, despite the task passing on Travis. See #49542. Built from https://develop.svn.wordpress.org/trunk@47595 git-svn-id: http://core.svn.wordpress.org/trunk@47370 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-17 18:31:07 +00:00
Sergey Biryukov	900cfc4816	Administration: Remove the smiley from overly happy "No activity yet!" message on Dashboard. Props francoist, karmatosed, ibdz, estelaris, nrqsnchz, Presskopp. Fixes #48387. Built from https://develop.svn.wordpress.org/trunk@47592 git-svn-id: http://core.svn.wordpress.org/trunk@47367 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-17 07:57:10 +00:00
Sergey Biryukov	4fbfbf5f61	Plugins: Add HTML ID attributes to plugin action links for easier targeting in browser-based testing. Props roytanck, shooper. Fixes #49916. Built from https://develop.svn.wordpress.org/trunk@47588 git-svn-id: http://core.svn.wordpress.org/trunk@47363 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-16 17:02:08 +00:00
Sergey Biryukov	92538d89ee	Site Health: Detect an active PHP session as a possible reason for HTTP requests timing out. PHP sessions created by a `session_start()` function call may interfere with REST API and loopback requests. An active session should be closed by `session_write_close()` before making any HTTP requests. Props matthieumota, netweblogic, Clorith, afragen, vjik, SergeyBiryukov. Fixes #47320. Built from https://develop.svn.wordpress.org/trunk@47585 git-svn-id: http://core.svn.wordpress.org/trunk@47360 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-16 08:20:09 +00:00
Sergey Biryukov	4e13efaf96	Code Modernization: Remove conditional use of `stream_get_contents()` PHP function. The function was introduced in PHP 5.0.0. Now that the minimum version of PHP required by WordPress is 5.6.20, these conditions are no longer needed. Props jrf. Fixes #48091. Built from https://develop.svn.wordpress.org/trunk@47584 git-svn-id: http://core.svn.wordpress.org/trunk@47359 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-15 11:54:08 +00:00
Sergey Biryukov	ae59482c80	Plugins: Simplify the logic of `validate_plugin_requirements()`, update documentation. This updates the function for consistency with `validate_theme_requirements()`. Follow-up to [44978], [45546], [47573]. Fixes #43992. Built from https://develop.svn.wordpress.org/trunk@47574 git-svn-id: http://core.svn.wordpress.org/trunk@47349 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-13 15:31:05 +00:00
Sergey Biryukov	87b3b38242	Privacy: Add an indication when the Copy action in Privacy Policy Guide is complete. This adds a "Copied!" text near the "Copy this section to clipboard" button to provide direct feedback that the action was completed. Props garrett-eclipse, nickylimjj, xkon, desrosj, birgire. Fixes #44588. Built from https://develop.svn.wordpress.org/trunk@47572 git-svn-id: http://core.svn.wordpress.org/trunk@47347 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-12 14:26:11 +00:00
Sergey Biryukov	48225beffb	Rewrite Rules: Use double quotes instead of backticks in `.htaccess` instructions about `# BEGIN/END` markers. Previously, the backticks resulted in extra markup being added when posted on support forums. Props mayankmajeji, knutsp. Fixes #49868. Built from https://develop.svn.wordpress.org/trunk@47571 git-svn-id: http://core.svn.wordpress.org/trunk@47346 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-11 15:09:11 +00:00
Sergey Biryukov	9f379bb930	Docs: Fix typo in `WP_Upgrader::__construct()` DocBlock. Props mattrad. Fixes #49856. Built from https://develop.svn.wordpress.org/trunk@47570 git-svn-id: http://core.svn.wordpress.org/trunk@47345 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-10 09:48:17 +00:00
Sergey Biryukov	856e1a27b8	Coding Standards: Use strict type check for `in_array()` and `array_search()`. This addresses all the remaining `WordPress.PHP.StrictInArray.MissingTrueStrict` issues in core. Includes minor code layout fixes for better readability. Follow-up to [47550]. See #49542. Built from https://develop.svn.wordpress.org/trunk@47557 git-svn-id: http://core.svn.wordpress.org/trunk@47332 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-09 15:43:10 +00:00
Sergey Biryukov	c18e44d6b1	Privacy: Make the deprecated `wp_get_user_request_data()` function available on front end. Previously, it was accidentally made available only in admin context. Follow-up to [44606], [47245]. Props garrett-eclipse, johnjamesjacoby, r-a-y, Dono12. Fixes #49802. Built from https://develop.svn.wordpress.org/trunk@47555 git-svn-id: http://core.svn.wordpress.org/trunk@47330 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-08 18:33:08 +00:00
Sergey Biryukov	38676936ba	Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50. Includes minor code layout fixes for better readability. See #49542. Built from https://develop.svn.wordpress.org/trunk@47550 git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-05 03:02:11 +00:00
Sergey Biryukov	441001f29f	Docs: Add documentation for the `$parent` parameter of `get_admin_page_parent()`. Props subrataemfluence. Fixes #45849. Built from https://develop.svn.wordpress.org/trunk@47546 git-svn-id: http://core.svn.wordpress.org/trunk@47321 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-04-03 17:23:11 +00:00
Sergey Biryukov	49d7b8c51f	Filesystem API: Correct punctuation in `request_filesystem_credentials()` error message. Props mayankmajeji, kharisblank. Fixes #49724. Built from https://develop.svn.wordpress.org/trunk@47530 git-svn-id: http://core.svn.wordpress.org/trunk@47305 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-30 01:32:07 +00:00
Sergey Biryukov	764a1761aa	Site Health: Correct markup in `::get_test_php_extensions()` and `::get_test_background_updates()` description. These tests output an unordered list, which doesn't need to be wrapped in a paragraph tag. Additionally, pass an empty string as an `actions` parameter in `::get_test_php_default_timezone()`, for consistency with other tests. Props afercia. See #48948. Built from https://develop.svn.wordpress.org/trunk@47528 git-svn-id: http://core.svn.wordpress.org/trunk@47303 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-29 03:46:06 +00:00
Sergey Biryukov	d552e475fd	Site Health: Add pretty links support information to debug data. Props valentinbora, afragen. Fixes #49422. Built from https://develop.svn.wordpress.org/trunk@47527 git-svn-id: http://core.svn.wordpress.org/trunk@47302 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-28 21:20:06 +00:00
John Blackbourn	41ae74f7b4	Users: Add a user language preference option to the "Add New User" form. This uses the same language selection control as the user editing screen and allows new users to be invited to a site in their own language. Props barryceelen, johnbillion Fixes #38665 Built from https://develop.svn.wordpress.org/trunk@47516 git-svn-id: http://core.svn.wordpress.org/trunk@47291 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-27 21:58:05 +00:00
Sergey Biryukov	2b030a1647	Docs: Add documentation for `WP_Comments_List_Table::floated_admin_avatar()`. Props akbarhusen, ayeshrajans, Soean, ajayghaghretiya1, netweb, SergeyBiryukov. Fixes #41491. Built from https://develop.svn.wordpress.org/trunk@47507 git-svn-id: http://core.svn.wordpress.org/trunk@47282 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-25 14:43:11 +00:00
Sergey Biryukov	5ce4cc4930	Administration: Add `/` character to `<img>` tag in `WP_Plugin_Install_List_Table::display_rows()`. While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core. Props adnan.limdi, Soean. Fixes #41904. Built from https://develop.svn.wordpress.org/trunk@47493 git-svn-id: http://core.svn.wordpress.org/trunk@47268 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-23 03:03:07 +00:00
Sergey Biryukov	c6c8862b87	Post Formats: Pass post type to the `disable_formats_dropdown` filter in `WP_Posts_List_Table::formats_dropdown()`. Props MatheusFD, birgire. Fixes #47959. Built from https://develop.svn.wordpress.org/trunk@47472 git-svn-id: http://core.svn.wordpress.org/trunk@47259 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-18 19:13:10 +00:00
John Blackbourn	7004afe4f4	Docs: Various docblock corrections and improvements. See #49572 Built from https://develop.svn.wordpress.org/trunk@47461 git-svn-id: http://core.svn.wordpress.org/trunk@47248 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-16 18:40:07 +00:00
Sergey Biryukov	73ef224e64	Administration: When editing a plugin or theme file, close any active PHP session. This prevents HTTP requests from timing out when attempting to connect back to the site. Props bruandet, vjik, donmhico, SergeyBiryukov. Fixes #43358. Built from https://develop.svn.wordpress.org/trunk@47457 git-svn-id: http://core.svn.wordpress.org/trunk@47244 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-15 19:45:07 +00:00
Sergey Biryukov	cf75b95197	Site Health: Run the first scheduled site health check a day after the initial site setup. This reduces the chance of displaying incorrect results due to running the check too early in first time setup scenarios. Props Clorith, garrett-eclipse, roytanck, joostdevalk. Fixes #49577. Built from https://develop.svn.wordpress.org/trunk@47456 git-svn-id: http://core.svn.wordpress.org/trunk@47243 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-14 16:36:07 +00:00
Sergey Biryukov	62ef2d6719	Site Health: Fix typo in Site Health Status dashboard widget. Follow-up to [47063], [47413]. Props Clorith, dlh. See #49562. Built from https://develop.svn.wordpress.org/trunk@47415 git-svn-id: http://core.svn.wordpress.org/trunk@47202 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-03 12:22:07 +00:00
Sergey Biryukov	a9479f31d1	Docs: Correct formatting of some DocBlocks in `Plugin_Upgrader` and `Theme_Upgrader` per the documentation standards. See #49400. Built from https://develop.svn.wordpress.org/trunk@47414 git-svn-id: http://core.svn.wordpress.org/trunk@47201 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-03 11:39:08 +00:00
Sergey Biryukov	ab854ce518	Site Health: Improve the strings in Site Health Status dashboard widget. Follow-up to [47063]. Props dlh. Fixes #49562. Built from https://develop.svn.wordpress.org/trunk@47413 git-svn-id: http://core.svn.wordpress.org/trunk@47200 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-03 11:21:07 +00:00
John Blackbourn	da52485cf1	Editor: Revert a fix for incorrect usage of ID attributes on custom fields. This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector. See #46964 Built from https://develop.svn.wordpress.org/trunk@47410 git-svn-id: http://core.svn.wordpress.org/trunk@47197 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-03 00:37:06 +00:00
John Blackbourn	9860470360	Upgrade/Install: Improved inline docs for the plugin and theme updater maintenance mode functionality. Props bookdude13 See #49400 Built from https://develop.svn.wordpress.org/trunk@47409 git-svn-id: http://core.svn.wordpress.org/trunk@47196 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-03 00:29:06 +00:00
John Blackbourn	251d77e1a1	Docs: Miscellaneous docs fixes and improvements. See #48303. Built from https://develop.svn.wordpress.org/trunk@47398 git-svn-id: http://core.svn.wordpress.org/trunk@47185 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-01 10:40:07 +00:00
John Blackbourn	056dad9c2c	Docs: Use more specific types in parameter descriptions in place of `mixed`. See #48303. Built from https://develop.svn.wordpress.org/trunk@47397 git-svn-id: http://core.svn.wordpress.org/trunk@47184 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-01 10:38:07 +00:00
John Blackbourn	bf8c4ee5c6	Docs: Correct the parameter documentation of the `request_filesystem_credentials` filter. See #48303 Built from https://develop.svn.wordpress.org/trunk@47396 git-svn-id: http://core.svn.wordpress.org/trunk@47183 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-03-01 10:33:04 +00:00
Sergey Biryukov	3a333ef030	Coding Standards: Use strict comparison for `normalize_whitespace()` checks when comparing revisions or autosaves. Props dkarfa, itowhid06, TimothyBlynJacobs. Fixes #47965. Built from https://develop.svn.wordpress.org/trunk@47372 git-svn-id: http://core.svn.wordpress.org/trunk@47159 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-25 19:35:09 +00:00
Sergey Biryukov	e0a2660719	I18N: Replace `.htaccess` with placeholders in the strings for Site Health custom rules check. Props ramiy. Fixes #48864. Built from https://develop.svn.wordpress.org/trunk@47345 git-svn-id: http://core.svn.wordpress.org/trunk@47132 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-22 18:56:06 +00:00
Sergey Biryukov	f0dfe42216	I18N: Replace `upload_max_filesize`, `php.ini`, `MAX_FILE_SIZE` with placeholders in upload error strings. Props ramiy. Fixes #48869. Built from https://develop.svn.wordpress.org/trunk@47330 git-svn-id: http://core.svn.wordpress.org/trunk@47123 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-20 17:18:06 +00:00
desrosj	447536a0e6	Site Health: Display the REST API test error codes correctly. This change fixes an issue where the error codes associated with failed REST API tests are not being printed to the screen. In addition, the square brackets have been replaced with parentheses for consistency, and the error code (which is much less useful to end-users than the error message itself) has been moved to the end of the line. This also clarifies the associated translator comments. Props afercia, desrosj. Fixes #49426. Built from https://develop.svn.wordpress.org/trunk@47306 git-svn-id: http://core.svn.wordpress.org/trunk@47106 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-18 16:48:06 +00:00
Andrea Fercia	d1054fcb48	Accessibility: Improve readability by removing unnecessary italic font style. Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided. Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements. Removes italic font style from: - the Quick Edit / Bulk Edit forms - the Recovery Mode plugin error details - the Image Editor inline help Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia. See #47327. Built from https://develop.svn.wordpress.org/trunk@47304 git-svn-id: http://core.svn.wordpress.org/trunk@47104 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-18 15:32:09 +00:00
Sergey Biryukov	9de7b1c35e	Site Health: Prevent the Site Health Status dashboard widget from loading on network admin screen for now. Props Clorith, pbiron. See #47606, #47085. Built from https://develop.svn.wordpress.org/trunk@47300 git-svn-id: http://core.svn.wordpress.org/trunk@47100 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-17 09:59:04 +00:00
Sergey Biryukov	a2b2f63b78	Administration: Allow `wp_update_link()` to update the `link_owner` field, for consistency with other link fields. Props pbiron, valentinbora, nikhilgupte. Fixes #41687. Built from https://develop.svn.wordpress.org/trunk@47291 git-svn-id: http://core.svn.wordpress.org/trunk@47091 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-15 01:55:06 +00:00
Sergey Biryukov	6b2c63031c	Coding Standards: Rename `$d` parameter in various date/time functions to `$format` for clarity. See #49222. Built from https://develop.svn.wordpress.org/trunk@47287 git-svn-id: http://core.svn.wordpress.org/trunk@47087 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-14 00:07:07 +00:00
Sergey Biryukov	534fcd7b0e	Privacy: Only show the Privacy Policy page notice when editing the page, not on drafts list. Props chetan200891, xkon, garrett-eclipse. Fixes #48431. Built from https://develop.svn.wordpress.org/trunk@47284 git-svn-id: http://core.svn.wordpress.org/trunk@47084 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-12 11:44:08 +00:00
Sergey Biryukov	63ed0401a0	Privacy: Revert [47269] for now to address side effects on Multisite installations. See #44176. Built from https://develop.svn.wordpress.org/trunk@47280 git-svn-id: http://core.svn.wordpress.org/trunk@47080 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 21:48:06 +00:00
Sergey Biryukov	652966a2a5	Privacy: Introduce filters for the headers of all the privacy-related e-mails: * `wp_privacy_personal_data_email_headers` * `user_request_confirmed_email_headers` * `user_erasure_complete_email_headers` * `user_request_action_email_headers` Props xkon, garrett-eclipse, zaffarn, desrosj. Fixes #44501. Built from https://develop.svn.wordpress.org/trunk@47279 git-svn-id: http://core.svn.wordpress.org/trunk@47079 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 21:43:07 +00:00
Sergey Biryukov	e6d01e007c	Privacy: Add a table of contents to Personal Data Export report for easier navigation. Props xkon, garrett-eclipse, birgire, karmatosed. Fixes #46894. Built from https://develop.svn.wordpress.org/trunk@47278 git-svn-id: http://core.svn.wordpress.org/trunk@47078 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 21:28:05 +00:00
desrosj	be2ec734f2	Upgrade/Install: Enable maintenance mode when plugins are auto-updated. When an attempt is made to update an active plugin automatically, there is the potential currently for two negative scenarios: - The plugin can be deactivated if the Plugins admin screen is loaded when the plugin update is incomplete, causing a PHP error. - The WSOD protection could be triggered, sending a false alarm email to the site administrator. By enabling maintenance mode before an active plugin update is attempted, these scenarios can be avoided. This change implements the same approach as the `Theme_Upgrader` class of using the `upgrader_pre_install` and `upgrader_post_install` hooks to toggle maintenance mode. Props desrosj, SergeyBiryukov. Fixes #49400. Built from https://develop.svn.wordpress.org/trunk@47275 git-svn-id: http://core.svn.wordpress.org/trunk@47075 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 20:14:05 +00:00
Sergey Biryukov	30c7bb621c	Privacy: Un-map privacy capabilities to make them available to be assigned for custom roles: * `erase_others_personal_data` * `export_others_personal_data` * `manage_privacy_options` Previously mapped to `manage_options` or `manage_network` (on Multisite), these are now added to the Administrator role separately. Additionally, `manage_privacy_options` is added to the Editor role. Props garrett-eclipse, xkon, pbiron, desrosj, johnbillion, flixos90, juliobox, lakenh, Ov3rfly, ianatkins. Fixes #44176. Built from https://develop.svn.wordpress.org/trunk@47269 git-svn-id: http://core.svn.wordpress.org/trunk@47069 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 18:36:06 +00:00
Sergey Biryukov	bf29d14a69	Site Health: Adjust "Database username" and "Table prefix" strings for consistency with the same strings in `wp-admin/setup-config.php`. Props ramiy. Fixes #47043. Built from https://develop.svn.wordpress.org/trunk@47268 git-svn-id: http://core.svn.wordpress.org/trunk@47068 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 16:48:05 +00:00
Sergey Biryukov	5d00e8f78b	Administration: Move `.has-row-actions` class in Recent Comments dashboard widget next to `.dashboard-comment-wrap`, for consistency. Follow-up to [47255]. See #42938. Built from https://develop.svn.wordpress.org/trunk@47256 git-svn-id: http://core.svn.wordpress.org/trunk@47056 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 01:21:05 +00:00
Sergey Biryukov	8c2fb2148b	Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen. Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov. Fixes #42938. Built from https://develop.svn.wordpress.org/trunk@47255 git-svn-id: http://core.svn.wordpress.org/trunk@47055 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 01:17:06 +00:00
Sergey Biryukov	055af2b506	Site Health: Improve the wording for PHP update recommendations. Props Clorith, grafruessel, sathyapulse, wpgurudev, garrett-eclipse, marybaum, xkon, SergeyBiryukov. Fixes #48716. Built from https://develop.svn.wordpress.org/trunk@47254 git-svn-id: http://core.svn.wordpress.org/trunk@47054 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 00:41:05 +00:00
Sergey Biryukov	507d056b7e	Media: In `media_sideload_image()`, store the original attachment URL in the `_source_url` post meta value. Props dshanske, joemcgill, antpb. Fixes #48164. Built from https://develop.svn.wordpress.org/trunk@47251 git-svn-id: http://core.svn.wordpress.org/trunk@47051 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 23:47:04 +00:00
Sergey Biryukov	13922a3210	Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column. With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other. Props xkon, karmatosed. Fixes #49323. Built from https://develop.svn.wordpress.org/trunk@47247 git-svn-id: http://core.svn.wordpress.org/trunk@47047 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 21:15:05 +00:00
Sergey Biryukov	5ddf97e142	Privacy: Give progress indication for export and erasure. This adds a progress indicator for "Download Personal Data" and "Erase Personal Data" row actions, which can take a while with a lot of data. Props garrett-eclipse, allendav, dominic_ks, xkon, karmatosed, birgire. Fixes #44264. Built from https://develop.svn.wordpress.org/trunk@47246 git-svn-id: http://core.svn.wordpress.org/trunk@47046 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 20:19:05 +00:00
Sergey Biryukov	3342aafe5e	Privacy: Rename `wp_get_user_request_data()` to `wp_get_user_request()` for clarity; deprecate the old function. The function returns an instance of the `WP_User_Request` object itself, not its `$request_data` property. Follow-up to [44606]. Props garrett-eclipse. Fixes #46302. Built from https://develop.svn.wordpress.org/trunk@47245 git-svn-id: http://core.svn.wordpress.org/trunk@47045 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 19:57:05 +00:00
Sergey Biryukov	d98fe66044	Site Health: Move the warning about `WP_DEBUG_LOG` being publicly accessible from "critical issues" to "recommended improvements" if the error log is outside of the WordPress directory. Props afragen, Clorith, miss_jwo, mikeschroder, kubiq, xkon. Fixes #47985. Built from https://develop.svn.wordpress.org/trunk@47235 git-svn-id: http://core.svn.wordpress.org/trunk@47035 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 05:16:07 +00:00
Sergey Biryukov	4f151b577e	Administration: Standardize "found in Trash" messages. Props Presskopp, audrasjb. Fixes #38669. Built from https://develop.svn.wordpress.org/trunk@47234 git-svn-id: http://core.svn.wordpress.org/trunk@47034 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 04:57:06 +00:00
Sergey Biryukov	a6949956d1	Administration: Capitalize `Trash` consistently in various messages and comments. When used as a noun referring to the "virtual" place, `Trash` should be capitalized. Props garrett-eclipse, aandrewdixon, Presskopp. Fixes #45317. Built from https://develop.svn.wordpress.org/trunk@47233 git-svn-id: http://core.svn.wordpress.org/trunk@47033 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 04:12:07 +00:00
Sergey Biryukov	32edd58e4c	Docs: Add descriptions for some globals: * `$wp_version` * `$wp_local_package` * `$required_php_version` * `$required_mysql_version` See #48303. Built from https://develop.svn.wordpress.org/trunk@47230 git-svn-id: http://core.svn.wordpress.org/trunk@47030 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 03:30:06 +00:00
Sergey Biryukov	f13044b031	Editor: Add unique classes to `.post-attributes-label-wrapper` paragraphs for easier JS or CSS targeting. Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks. Fixes #44408. Built from https://develop.svn.wordpress.org/trunk@47228 git-svn-id: http://core.svn.wordpress.org/trunk@47028 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 02:29:06 +00:00
Sergey Biryukov	ddc8ddb294	Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins. Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links. See #meta4706 for the corresponding WordPress.org API change. Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse. Fixes #22994. See #21307. Built from https://develop.svn.wordpress.org/trunk@47227 git-svn-id: http://core.svn.wordpress.org/trunk@47027 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 02:12:06 +00:00
joedolson	61ce35440c	Editor: Fix incorrect usage of ID attributes on custom fields. Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match. Props jankimoradiya, audrasjb, donmhico, afercia. Fixes #46964. Built from https://develop.svn.wordpress.org/trunk@47222 git-svn-id: http://core.svn.wordpress.org/trunk@47022 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-09 19:41:07 +00:00
Sergey Biryukov	641c632b0c	Coding Standards: Use Yoda conditions where appropriate. See #49222. Built from https://develop.svn.wordpress.org/trunk@47219 git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-09 16:55:09 +00:00
Sergey Biryukov	e713bf9a88	Site Health: Only get MySQL server information in tests where it's actually needed. This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made. Props xkon, Otto42, Clorith. See #47606. Built from https://develop.svn.wordpress.org/trunk@47215 git-svn-id: http://core.svn.wordpress.org/trunk@47015 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-08 20:10:05 +00:00
Sergey Biryukov	01f133ee28	Accessibility: Menus: Make tab panels in `Add menu items` section more accessible for keyboard users. Props audrasjb, afercia. Fixes #49211. Built from https://develop.svn.wordpress.org/trunk@47209 git-svn-id: http://core.svn.wordpress.org/trunk@47009 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 21:38:06 +00:00
Sergey Biryukov	b2a1146380	Coding Standards: Adjust coding standards to always omit parentheses for `include`/`require` statements. These are language constructs, not function calls, so the parentheses are unnecessary. This updates the PHPCS configuration file the enforce the sniff until it is moved from the `WordPress-Extra` ruleset to the `WordPress-Core` ruleset upstream. Follow-up to [47198]. Props desrosj, jrf, GaryJ. Fixes #49376. Built from https://develop.svn.wordpress.org/trunk@47207 git-svn-id: http://core.svn.wordpress.org/trunk@47007 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 19:16:06 +00:00
John Blackbourn	1f1fd617f5	Posts, Post Types: Add a parameter to the `post_locked_dialog` action which contains a reference to the user who holds the lock. Fixes #48443 Built from https://develop.svn.wordpress.org/trunk@47206 git-svn-id: http://core.svn.wordpress.org/trunk@47006 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 17:53:06 +00:00
Andrew Ozz	aea25de893	Media: Add link to the original image in the image properties if it was scaled or rotated after uploading. Fixes #49290. Built from https://develop.svn.wordpress.org/trunk@47202 git-svn-id: http://core.svn.wordpress.org/trunk@47002 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 05:13:05 +00:00
Sergey Biryukov	47ed56f38f	Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`. This commit also includes: * Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls. * Replacing `include` statements for several files with `require_once`, for consistency: * `wp-admin/admin-header.php` * `wp-admin/admin-footer.php` * `wp-includes/version.php` Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb. Fixes #48082. Built from https://develop.svn.wordpress.org/trunk@47198 git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-06 06:33:11 +00:00
Sergey Biryukov	9ed35cf902	Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image". This makes it more consistent with other UI elements in the block editor. Props mcsf. Fixes #49371. Built from https://develop.svn.wordpress.org/trunk@47194 git-svn-id: http://core.svn.wordpress.org/trunk@46994 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-05 19:09:05 +00:00
Sergey Biryukov	44288356e2	Menus: Introduce `wp_nav_menu_item_custom_fields` action that fires just before the move buttons of a nav menu item in the menu editor. Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking. Fixes #47056. See #38904, #18584. Built from https://develop.svn.wordpress.org/trunk@47190 git-svn-id: http://core.svn.wordpress.org/trunk@46990 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-05 07:43:05 +00:00
Sergey Biryukov	84c43d1863	Docs: Correct type for `$item` and $args `parameters in` Walker_Nav_Menu_Checklist `and` Walker_Nav_Menu_Edit `to match the parent` Walker_Nav_Menu` class. Follow-up to [38559], [45537]. See #24587, #48303. Built from https://develop.svn.wordpress.org/trunk@47189 git-svn-id: http://core.svn.wordpress.org/trunk@46989 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-05 07:25:05 +00:00
Sergey Biryukov	8163215dc4	Plugins: Remove obsolete `plugin_slugs` transient from `WP_Plugins_List_Table::prepare_items()`. The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607]. The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`. Props aftabmuni. Fixes #49340. Built from https://develop.svn.wordpress.org/trunk@47167 git-svn-id: http://core.svn.wordpress.org/trunk@46967 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-02 15:50:04 +00:00
Sergey Biryukov	11fb46d4c6	Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode. The original script was deprecated in [30338] and removed in [32677]. Props Presskopp, ketuchetan. Fixes #39448. Built from https://develop.svn.wordpress.org/trunk@47164 git-svn-id: http://core.svn.wordpress.org/trunk@46964 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-02 04:15:03 +00:00
Sergey Biryukov	8e37999368	Docs: Correct DocBlock formatting for `register_setting()`. Document the full list of whitelisted option key names. See #48303. Built from https://develop.svn.wordpress.org/trunk@47157 git-svn-id: http://core.svn.wordpress.org/trunk@46957 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 22:01:07 +00:00
Sergey Biryukov	deb1886078	Accessibility: Text Changes: Use sentence case for the word `Error` in various error messages, instead of all caps. Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations. Props afercia, ryokuhi, sabernhardt, garrett-eclipse. See #47656, #43037, #42945. Built from https://develop.svn.wordpress.org/trunk@47156 git-svn-id: http://core.svn.wordpress.org/trunk@46956 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 21:38:04 +00:00
Sergey Biryukov	2fe7c95153	Text Changes: Capitalize error messages consistently. Props Presskopp. Fixes #42945. Built from https://develop.svn.wordpress.org/trunk@47154 git-svn-id: http://core.svn.wordpress.org/trunk@46954 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 20:55:05 +00:00
Sergey Biryukov	12a6907123	Text Changes: Add missing periods to some error messages, for consistency. Props Presskopp. Fixes #42735. Built from https://develop.svn.wordpress.org/trunk@47153 git-svn-id: http://core.svn.wordpress.org/trunk@46953 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 20:32:05 +00:00
Sergey Biryukov	06979c6597	Docs: Document the addition of `$json_report_pathname` parameter to the `wp_privacy_personal_data_export_file_created` action. Follow-up to [47146]. Props xkon. Fixes #49029. Built from https://develop.svn.wordpress.org/trunk@47150 git-svn-id: http://core.svn.wordpress.org/trunk@46950 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 04:17:05 +00:00
Sergey Biryukov	0aff1cf6bd	Site Health: Rename `WP_Site_Health::initialize()` introduced in [47063] to `::get_instance()`, for clarity and consistency with other core classes. Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class. Props afercia, xkon, Clorith, SergeyBiryukov. See #47606. Built from https://develop.svn.wordpress.org/trunk@47149 git-svn-id: http://core.svn.wordpress.org/trunk@46949 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 00:39:09 +00:00
Sergey Biryukov	3cd1514b91	Privacy: Clarify bulk action labels for personal data export and removal requests. Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold. Fixes #44674. Built from https://develop.svn.wordpress.org/trunk@47148 git-svn-id: http://core.svn.wordpress.org/trunk@46948 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-31 03:43:05 +00:00
Sergey Biryukov	39cef6947a	Privacy: Introduce a JSON file into the personal data export. The produced ZIP archive will now include an `export.json` file along with the current `index.html`. Props xkon. Fixes #49029. See #46424. Built from https://develop.svn.wordpress.org/trunk@47146 git-svn-id: http://core.svn.wordpress.org/trunk@46946 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-31 01:36:05 +00:00
Sergey Biryukov	eafc40be6d	Privacy: Remove user's email address from personal data export filename. Use `wp_unique_filename()` to avoid potential collisions instead. Props xkon, garrett-eclipse, donmhico, Ov3rfly, Clorith, allendav. Fixes #44197. Built from https://develop.svn.wordpress.org/trunk@47144 git-svn-id: http://core.svn.wordpress.org/trunk@46944 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-31 00:58:06 +00:00
Sergey Biryukov	d3c032bc35	Dashboard: Improve the appearance of "WordPress Events and News" dashboard widget for multi-day events. If an upcoming event spans over several days, this information is now properly reflected in the widget. Props imath, casiepa, iandunn, hareesh-pillai, melchoyce, mapk, desrosj, audrasjb, SergeyBiryukov. Fixes #47798. Built from https://develop.svn.wordpress.org/trunk@47124 git-svn-id: http://core.svn.wordpress.org/trunk@46924 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 02:19:08 +00:00
Sergey Biryukov	b2ffea836b	Docs: Fix typos in `wp-admin/includes/class-pclzip.php`. With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes. Props passoniate, ottok. Fixes #49163. See #38464. Built from https://develop.svn.wordpress.org/trunk@47123 git-svn-id: http://core.svn.wordpress.org/trunk@46923 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 00:56:04 +00:00
Sergey Biryukov	001ffe81fb	Docs: Improve inline comments per the documentation standards. Includes minor code layout fixes for better readability. See #48303. Built from https://develop.svn.wordpress.org/trunk@47122 git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 00:45:18 +00:00
Sergey Biryukov	037a736757	Docs: Improve comments in some `wp-admin` files per the documentation standards. Follow-up to [47084]. Props passoniate, apedog. Fixes #49223, #49227. Built from https://develop.svn.wordpress.org/trunk@47119 git-svn-id: http://core.svn.wordpress.org/trunk@46919 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 00:35:08 +00:00
Sergey Biryukov	b79e042b00	Docs: Remove extra trailing spaces from `wp_add_privacy_policy_content()` DocBlock to fix WPCS issues, apply minor formatting changes for consistency. Follow-up to [47112]. See #49282. Built from https://develop.svn.wordpress.org/trunk@47113 git-svn-id: http://core.svn.wordpress.org/trunk@46913 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-27 01:06:04 +00:00
Andrew Ozz	516629964c	Privacy: Cleanup `.wp-policy-help` CSS remnants and add back-compat when hiding the tutorial content before copying. Props garrett-eclipse. Fixes #49282. Built from https://develop.svn.wordpress.org/trunk@47112 git-svn-id: http://core.svn.wordpress.org/trunk@46912 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-26 23:02:03 +00:00
Sergey Biryukov	cfa3dc8ee8	Docs: Correct `@return` value for `parent_dropdown()`. Follow-up to [47100]. See #48303. Built from https://develop.svn.wordpress.org/trunk@47102 git-svn-id: http://core.svn.wordpress.org/trunk@46902 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-22 00:33:04 +00:00
Sergey Biryukov	eb513c5ac8	Docs: Adjust `@return` value of `parent_dropdown()` for consistency with other dropdown functions. See #48303. Built from https://develop.svn.wordpress.org/trunk@47100 git-svn-id: http://core.svn.wordpress.org/trunk@46900 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-22 00:22:03 +00:00
Sergey Biryukov	381df97419	Docs: Correct `@return` value for `update_core()` and `Core_Upgrader::upgrade()`. See #48303. Built from https://develop.svn.wordpress.org/trunk@47099 git-svn-id: http://core.svn.wordpress.org/trunk@46899 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-22 00:19:04 +00:00
Sergey Biryukov	60c651ad6a	I18N: Add missing placeholders to some translators comments in `wp-admin`. Props ramiy. Fixes #49248. Built from https://develop.svn.wordpress.org/trunk@47093 git-svn-id: http://core.svn.wordpress.org/trunk@46893 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-20 15:43:04 +00:00
Sergey Biryukov	d5be8f0635	I18N: Correct translator comments in `WP_Users_List_Table::get_views()` to provide information about each placeholder. Props ramiy. Fixes #49242. Built from https://develop.svn.wordpress.org/trunk@47089 git-svn-id: http://core.svn.wordpress.org/trunk@46889 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-20 14:08:05 +00:00
Sergey Biryukov	2900bb8ea7	Docs: Update links to https://secure.php.net/, they now redirect to https://www.php.net/. See #48303. Built from https://develop.svn.wordpress.org/trunk@47088 git-svn-id: http://core.svn.wordpress.org/trunk@46888 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-20 03:14:06 +00:00
Sergey Biryukov	89f5d3dd0c	Networks and Sites: Clarify the recommendation to remove the `www` prefix from the site domain before creating a network. The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL. Props kharisblank, tobifjellner, ramiy. Fixes #49214. Built from https://develop.svn.wordpress.org/trunk@47085 git-svn-id: http://core.svn.wordpress.org/trunk@46885 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-18 01:15:04 +00:00
Sergey Biryukov	053a9cd5b8	Docs: Improve comments in some `wp-admin` files per the documentation standards. Props passoniate. Fixes #49215, #49216. Built from https://develop.svn.wordpress.org/trunk@47084 git-svn-id: http://core.svn.wordpress.org/trunk@46884 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-18 00:54:04 +00:00
Sergey Biryukov	1cfc32af58	Coding Standards: Remove unnecessary `// phpcs:ignore` instances in `WP_Debug_Data`. `WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too. Additionally, remove one short ternary instance, not allowed per the coding standards. See #49222. Built from https://develop.svn.wordpress.org/trunk@47083 git-svn-id: http://core.svn.wordpress.org/trunk@46883 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-18 00:26:06 +00:00
Sergey Biryukov	10ae398727	Site Health: Avoid "Undefined property" PHP notices in `wp_dashboard_site_health()` when the status result transient does not exist yet. Props dlh for initial patch. See #47606. Built from https://develop.svn.wordpress.org/trunk@47069 git-svn-id: http://core.svn.wordpress.org/trunk@46869 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-13 17:27:06 +00:00
Sergey Biryukov	f18b173674	Networks and Sites: Use `warning` styles for 'Caution' and 'Warning' messages during Multisite installation. Props dlh. Fixes #49186. Built from https://develop.svn.wordpress.org/trunk@47067 git-svn-id: http://core.svn.wordpress.org/trunk@46867 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-13 17:00:06 +00:00
Sergey Biryukov	fa2f6e0644	Docs: Improve documentation for `wp_save_image_file()` and related functions. See #48303. Built from https://develop.svn.wordpress.org/trunk@47065 git-svn-id: http://core.svn.wordpress.org/trunk@46865 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-12 16:56:05 +00:00
Sergey Biryukov	2c4480958b	Site Health: Introduce Site Health Status dashboard widget. The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details. Props Clorith, hedgefield, guddu1315. See #47606. Built from https://develop.svn.wordpress.org/trunk@47063 git-svn-id: http://core.svn.wordpress.org/trunk@46863 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-12 13:33:05 +00:00
Sergey Biryukov	dd4d98a368	Docs: In various `@return` tags, list the expected type first, instead of `false`. Follow-up to [46696]. See #48303. Built from https://develop.svn.wordpress.org/trunk@47060 git-svn-id: http://core.svn.wordpress.org/trunk@46860 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-11 18:32:05 +00:00
Sergey Biryukov	2294d65753	Docs: Synchronize `@return` descriptions for `::handle_row_actions()` methods in list tables. Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes. See #49170, #48303. Built from https://develop.svn.wordpress.org/trunk@47059 git-svn-id: http://core.svn.wordpress.org/trunk@46859 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-11 17:59:04 +00:00
Sergey Biryukov	d469aa8162	Docs: Correct `@return` description for `WP_List_Table::handle_row_actions()`. Props pbiron. Fixes #49170. Built from https://develop.svn.wordpress.org/trunk@47058 git-svn-id: http://core.svn.wordpress.org/trunk@46858 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-11 17:57:03 +00:00
Sergey Biryukov	6a3deacf86	Docs: Correct `@return` type for `Theme_Upgrader::check_parent_theme_filter()`. Props diddledan. Fixes #48570. Built from https://develop.svn.wordpress.org/trunk@47057 git-svn-id: http://core.svn.wordpress.org/trunk@46857 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-11 02:46:05 +00:00
Sergey Biryukov	667f26b3af	I18N: Replace `php.ini`, `post_max_size`, and `upload_max_filesize` with placeholders in "File is empty" error message. Props ramiy. Fixes #48868. Built from https://develop.svn.wordpress.org/trunk@47043 git-svn-id: http://core.svn.wordpress.org/trunk@46843 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-06 16:16:03 +00:00
Sergey Biryukov	6a3a0b519c	Docs: Fix typo in `media_post_single_attachment_fields_to_edit()` description. Props mukesh27. Fixes #49131. Built from https://develop.svn.wordpress.org/trunk@47039 git-svn-id: http://core.svn.wordpress.org/trunk@46839 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-04 18:00:06 +00:00
Sergey Biryukov	6357cae029	Docs: Fix typo in `_crop_image_resource()` DocBlock. Props mukesh27. Fixes #49103. Built from https://develop.svn.wordpress.org/trunk@47024 git-svn-id: http://core.svn.wordpress.org/trunk@46824 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-31 12:34:01 +00:00
Sergey Biryukov	7970e62c06	Coding Standards: Fix WPCS issue in [47015]. See #49082. Built from https://develop.svn.wordpress.org/trunk@47016 git-svn-id: http://core.svn.wordpress.org/trunk@46816 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-26 15:53:02 +00:00
Sergey Biryukov	7c2275dfe4	Docs: Fix typo in `wp_dashboard_cached_rss_widget()` documentation. Props mukesh27. Fixes #49082. Built from https://develop.svn.wordpress.org/trunk@47015 git-svn-id: http://core.svn.wordpress.org/trunk@46815 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-26 14:42:03 +00:00
Sergey Biryukov	bb70f4e530	Docs: Correct the note about the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant in `$_new_bundled_files` global description. In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`. Follow-up to [39064]. Props tomgreer, knutsp, crdunst. See #49056. Built from https://develop.svn.wordpress.org/trunk@47007 git-svn-id: http://core.svn.wordpress.org/trunk@46807 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-23 18:00:02 +00:00
Sergey Biryukov	246a035d99	Docs: Improve documentation for admin menu functions: * `get_admin_page_parent()` * `get_admin_page_title()` * `get_plugin_page_hook()` * `get_plugin_page_hookname()` * `user_can_access_admin_page()` Add missing descriptions and `@since` tags. Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov. Fixes #44253, #49067. Built from https://develop.svn.wordpress.org/trunk@47006 git-svn-id: http://core.svn.wordpress.org/trunk@46806 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-23 14:36:04 +00:00
Sergey Biryukov	f501814eac	Upgrade/Install: When creating the `.htaccess` file in `insert_with_markers()`, make sure it has `0644` as a minimum set of permissions. Props rcutmore, dd32, i3anaan. Fixes #40572. Built from https://develop.svn.wordpress.org/trunk@47005 git-svn-id: http://core.svn.wordpress.org/trunk@46805 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-22 02:45:03 +00:00
Sergey Biryukov	4edec193bc	Users: When creating the first user on installation, populate the Website profile field with the site URL. Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites. Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat. Fixes #35778. Built from https://develop.svn.wordpress.org/trunk@46989 git-svn-id: http://core.svn.wordpress.org/trunk@46789 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-18 02:26:03 +00:00
Sergey Biryukov	bbd898b1dd	Upgrade/Install: Remove unused global in `upgrade_430_fix_comments()`. Props adnan.limdi. Fixes #41970. Built from https://develop.svn.wordpress.org/trunk@46972 git-svn-id: http://core.svn.wordpress.org/trunk@46772 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-17 16:45:03 +00:00
Sergey Biryukov	5b9fd2d7e7	Coding Standards: Use strict comparison in `wp-admin/includes/network.php`. Props ataurr. Fixes #48994. Built from https://develop.svn.wordpress.org/trunk@46963 git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-16 12:37:06 +00:00
Sergey Biryukov	9b91ffde04	Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`. Props grapplerulrich. Fixes #48932. Built from https://develop.svn.wordpress.org/trunk@46880 git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-11 10:59:05 +00:00
Sergey Biryukov	6ddf02b188	Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters. Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host. Fixes #48599. Built from https://develop.svn.wordpress.org/trunk@46868 git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-09 21:03:02 +00:00
Sergey Biryukov	ac690426eb	Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created. This ensures that the actual UI controls state matches the visually conveyed state. Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov. Fixes #48409. Built from https://develop.svn.wordpress.org/trunk@46842 git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-09 13:49:03 +00:00
John Blackbourn	d53103ed62	Docs: Further docblock corrections and improvements. See #48303 Built from https://develop.svn.wordpress.org/trunk@46826 git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-07 13:23:01 +00:00
John Blackbourn	f93ee2ca76	Docs: Increase the specificity of various docblock parameter types and return types. See #48303 Built from https://develop.svn.wordpress.org/trunk@46823 git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-06 22:43:04 +00:00
John Blackbourn	aa1fdcbd52	Docs: Correct various docblocks documentation. See #48303 Built from https://develop.svn.wordpress.org/trunk@46821 git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-06 22:23:04 +00:00
Andrew Ozz	135e608b46	Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original. Fixes #48736. Built from https://develop.svn.wordpress.org/trunk@46809 git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-01 18:26:05 +00:00
Sergey Biryukov	1d1c74385f	REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter. See #48839. Built from https://develop.svn.wordpress.org/trunk@46804 git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-29 22:04:02 +00:00
Sergey Biryukov	acd0a3ca99	Site Health: Add a test for PHP default timezone. The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`. WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues. Props Rarst, Clorith, TimothyBlynJacobs. Fixes #48692. Built from https://develop.svn.wordpress.org/trunk@46797 git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-28 15:48:03 +00:00
Dominik Schilling	f4165a697d	Upgrade/Install: Provide a default label for "Continue" button in language selection form. Prevents an empty continue button if a translation isn't yet available. Props sathyapulse. Fixes #48776. Built from https://develop.svn.wordpress.org/trunk@46784 git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-26 15:19:04 +00:00
Sergey Biryukov	2a85fe21d8	Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: * "change your theme completely" * Active theme in the "At a Glance" box * "View all drafts" in the Quick Draft box Split "Manage widgets or menus" into separate items for consistency with other links. For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished. Per accessibility coding standards: > When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined. https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone Props afercia, audrasjb, karmatosed. Fixes #48406. Built from https://develop.svn.wordpress.org/trunk@46770 git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-24 19:57:05 +00:00
Sergey Biryukov	26a750e162	Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`. Props sathyapulse, zodiac1978. Fixes #48777. Built from https://develop.svn.wordpress.org/trunk@46763 git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-23 18:51:01 +00:00
Sergey Biryukov	44d5372825	I18N: Correct translator comment for `By %s` string in Plugins list table. Follow-up to [44541]. See #45898. Built from https://develop.svn.wordpress.org/trunk@46755 git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-21 00:08:02 +00:00
Andrea Fercia	71725aeb95	Accessibility: Add an `aria-current` attribute to the Media Library switch links. The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items. Props mayanksonawat, afercia. Fixes #48271. Built from https://develop.svn.wordpress.org/trunk@46746 git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-18 16:51:02 +00:00
Sergey Biryukov	5aa3a51264	Docs: Update broken source code link in `WP_Filesystem_SSH2` class. Props mryoga, finchps. Fixes #48467. Built from https://develop.svn.wordpress.org/trunk@46742 git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-17 16:16:02 +00:00
Sergey Biryukov	418db0297e	Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages. Props garrett-eclipse. Fixes #48676. Built from https://develop.svn.wordpress.org/trunk@46739 git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-17 07:43:01 +00:00
Sergey Biryukov	927aa4b44c	Docs: Fix typo in `wp_credits_section_title()` description. Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards. Props hareesh-pillai. Fixes #48674. Built from https://develop.svn.wordpress.org/trunk@46738 git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-16 21:04:01 +00:00
Sergey Biryukov	4ec53dc54c	Docs: Remove incorrect `@return` tags. Props diddledan. Fixes #48613, #48614. Built from https://develop.svn.wordpress.org/trunk@46732 git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-14 09:57:03 +00:00
Sergey Biryukov	2265c36568	Help/About: Update the 5.3 About page. * Remove extra padding on the Credits tab. Previously [46556], [46572], [46616], [46705]. Props ryelle. See #47708. Built from https://develop.svn.wordpress.org/trunk@46709 git-svn-id: http://core.svn.wordpress.org/trunk@46509 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-11 20:45:04 +00:00
Sergey Biryukov	3d623995a8	Docs: In various `@return` tags, list the expected type first, instead of `WP_Error`. See #48303. Built from https://develop.svn.wordpress.org/trunk@46696 git-svn-id: http://core.svn.wordpress.org/trunk@46496 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-11 02:43:03 +00:00
Sergey Biryukov	82dfb2d151	Docs: Miscellaneous docblock corrections in `wp-admin/includes/plugin.php`. See #48303. Built from https://develop.svn.wordpress.org/trunk@46695 git-svn-id: http://core.svn.wordpress.org/trunk@46495 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-11 00:05:01 +00:00
Sergey Biryukov	2af39e45cb	Docs: Improve documentation for `deactivate_plugins()` and `activate_plugins()`. Props marekdedic, spenserhale, SergeyBiryukov. Fixes #48352. Built from https://develop.svn.wordpress.org/trunk@46694 git-svn-id: http://core.svn.wordpress.org/trunk@46494 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-10 23:05:03 +00:00
Sergey Biryukov	0e79d4d101	Coding Standards: Fix WPCS issue in [46684]. See #48255. Built from https://develop.svn.wordpress.org/trunk@46687 git-svn-id: http://core.svn.wordpress.org/trunk@46487 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-09 13:33:02 +00:00
Sergey Biryukov	1f816ad18d	Docs: Use the `{@see ...}` tag for the replacement in `@deprecated` tags, so that Developer Reference could automatically link to the replacement. Props jrf. See #48255. Built from https://develop.svn.wordpress.org/trunk@46685 git-svn-id: http://core.svn.wordpress.org/trunk@46485 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-09 13:05:02 +00:00
Sergey Biryukov	f60094679f	Coding Standards: Consistently use `do_action_deprecated()` and `apply_filters_deprecated()` for deprecated hooks. Props jrf. See #48255. Built from https://develop.svn.wordpress.org/trunk@46684 git-svn-id: http://core.svn.wordpress.org/trunk@46484 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-09 12:59:03 +00:00
Sergey Biryukov	15a4289c8d	Docs: Correct description for `$recursive` parameter of `::chmod()` and `::delete()` methods in `WP_Filesystem` implementations. Props skithund. Fixes #48422. Built from https://develop.svn.wordpress.org/trunk@46679 git-svn-id: http://core.svn.wordpress.org/trunk@46479 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-08 22:56:02 +00:00
Andrew Ozz	60c2966222	Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in `wp_get_missing_image_subsizes()`. Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold. Props desrosj, azaozz. Fixes #48518 for trunk. Built from https://develop.svn.wordpress.org/trunk@46677 git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-07 18:51:02 +00:00
John Blackbourn	eda6a9e111	Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes. See #48303 Built from https://develop.svn.wordpress.org/trunk@46662 git-svn-id: http://core.svn.wordpress.org/trunk@46462 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-05 21:30:03 +00:00
Andrew Ozz	f9e81c83d5	Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image. Props ianmjones, azaozz. Fixes #48453 for trunk. Built from https://develop.svn.wordpress.org/trunk@46658 git-svn-id: http://core.svn.wordpress.org/trunk@46458 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-05 20:53:03 +00:00
Andrew Ozz	43ed67661a	Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it. See #48472. Built from https://develop.svn.wordpress.org/trunk@46651 git-svn-id: http://core.svn.wordpress.org/trunk@46451 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-04 17:07:03 +00:00
Sergey Biryukov	8b76312eb3	Docs: Correct some array hash notations added in [46644]. See #48303. Built from https://develop.svn.wordpress.org/trunk@46647 git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-04 09:37:02 +00:00
John Blackbourn	b3d6acd6a4	Docs: Fix some incorrect return tags in docblocks. See #48303 Built from https://develop.svn.wordpress.org/trunk@46644 git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-03 22:23:01 +00:00
whyisjake	a87271af60	Login and Registration: Allow email logins to be more flexible. Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen. Fixes #38744 Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake. Built from https://develop.svn.wordpress.org/trunk@46640 git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-03 20:12:02 +00:00
Sergey Biryukov	2651ff3ae8	Docs: Update URLs in some `@link` tags and switch them to HTTPS. Props tsuyoring. Fixes #48479. Built from https://develop.svn.wordpress.org/trunk@46626 git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-01 14:57:02 +00:00
John Blackbourn	d1b23193dd	Docs: Correct some incorrect docblock tags. See #48303 Built from https://develop.svn.wordpress.org/trunk@46623 git-svn-id: http://core.svn.wordpress.org/trunk@46420 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-31 17:51:01 +00:00
Sergey Biryukov	3d76b537d6	Docs: Add `@since` tag for the `$context` parameter added to `wp_generate_attachment_metadata` filter in [46621]. See #48472. Built from https://develop.svn.wordpress.org/trunk@46622 git-svn-id: http://core.svn.wordpress.org/trunk@46419 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-31 00:13:01 +00:00
Andrew Ozz	ed651b17a4	Upload: - Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created. - Add another arg in the `wp_generate_attachment_metadata` filter for additional context. - Fix inline docs and ensure the new image meta is always saved before starting post-processing. Fixes #48472 for trunk. Built from https://develop.svn.wordpress.org/trunk@46621 git-svn-id: http://core.svn.wordpress.org/trunk@46418 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-30 21:10:04 +00:00
John Blackbourn	057f661ce3	Docs: Miscellaneous docblock corrections. See #48303 Built from https://develop.svn.wordpress.org/trunk@46610 git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-28 19:48:01 +00:00
John Blackbourn	c8f91f77ac	Docs: Correct invalid hook docblocks. See #48303 Built from https://develop.svn.wordpress.org/trunk@46603 git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-27 19:11:02 +00:00
John Blackbourn	9e2b6902b3	Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection. See #48303 Built from https://develop.svn.wordpress.org/trunk@46597 git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 23:16:04 +00:00
John Blackbourn	3caaa40fc6	Docs: Switch more docs over to typed array notation, plus some fixes. See #48303, #41756 Built from https://develop.svn.wordpress.org/trunk@46596 git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 21:09:04 +00:00
John Blackbourn	7c2b9f2a2e	Docs: Miscellaneous docblock fixes and improvements. See #48303 Built from https://develop.svn.wordpress.org/trunk@46594 git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 20:43:04 +00:00
Sergey Biryukov	67ce1885db	Docs: Improve formatting of various `WP_Screen` DocBlocks. See #48303. Built from https://develop.svn.wordpress.org/trunk@46591 git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 00:36:05 +00:00
Sergey Biryukov	67c73ea3ea	Docs: Improve documentation for `WP_Screen::add_help_tab()`. Props atachibana. Fixes #48395. Built from https://develop.svn.wordpress.org/trunk@46590 git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 00:34:07 +00:00
Sergey Biryukov	7e11e9d732	Posts, Post Types: Remove unintended change from [46578]. See #48384. Built from https://develop.svn.wordpress.org/trunk@46579 git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-25 12:54:03 +00:00
Sergey Biryukov	0b83bffd45	Date/Time: Correct the logic in `WP_Posts_List_Table::column_date()` and `WP_Media_List_Table::column_date()` to check for a valid post timestamp. Props Rarst. Reviewed by azaozz, SergeyBiryukov. See #48384. Built from https://develop.svn.wordpress.org/trunk@46578 git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-25 12:51:03 +00:00
Sergey Biryukov	0609e04266	Administration: Relax the default value check for the `$position` argument added to `add_submenu_page()` and related functions in [46197]. Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues. A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type. Props david.binda, desrosj, 123host, dennis_f, MattyRob. Reviewed by desrosj. Fixes #48249. Built from https://develop.svn.wordpress.org/trunk@46570 git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-22 17:52:04 +00:00
Andrew Ozz	e1560cd1e0	Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append `scaled-` to the file names of the scaled images to make them easier to recognize. Props kraftbj, azaozz. Fixes #48304. Built from https://develop.svn.wordpress.org/trunk@46565 git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-21 21:43:04 +00:00
desrosj	1d6bd71ce4	Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing. This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements. Follow up of [46455]. Reviewed by desrosj, jorbin, johnbillion. Fixes #47699. Built from https://develop.svn.wordpress.org/trunk@46560 git-svn-id: http://core.svn.wordpress.org/trunk@46357 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-16 21:03:02 +00:00
Andrew Ozz	1940cf7d54	Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging. Fixes #40439. Built from https://develop.svn.wordpress.org/trunk@46507 git-svn-id: http://core.svn.wordpress.org/trunk@46304 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-14 20:05:01 +00:00
Sergey Biryukov	b0e0f69b2e	I18N: Don't capitalize "Extension" in `update_core()`, for consistency with other strings. Follow-up to [46455]. See #47699. Built from https://develop.svn.wordpress.org/trunk@46464 git-svn-id: http://core.svn.wordpress.org/trunk@46262 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-12 02:42:01 +00:00
Sergey Biryukov	e19329bad0	Docs: Add `requires_php` to the list of fields returned by `plugins_api()`. Props ediamin. Fixes #48291. Built from https://develop.svn.wordpress.org/trunk@46463 git-svn-id: http://core.svn.wordpress.org/trunk@46261 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-12 02:35:04 +00:00
Mike Schroder	66c8085fc4	Media: Update fallback previews to support `_wp_make_subsizes()` Allows fallback previews (PDF by default, in core) to save image meta after each size is generated to allow for resuming, and make sizes immediately available. Props azaozz, antpb, progremzion, mikeschroder. See #48111. Built from https://develop.svn.wordpress.org/trunk@46459 git-svn-id: http://core.svn.wordpress.org/trunk@46257 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-11 07:54:03 +00:00
desrosj	c6d3987b08	Upgrade/Install: Detect the presence of the native PHP JSON extension before updating. The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]). However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues. Props jrf, jorbin, dd32, desrosj. Fixes #47699. Built from https://develop.svn.wordpress.org/trunk@46455 git-svn-id: http://core.svn.wordpress.org/trunk@46253 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-09 22:22:04 +00:00
Sergey Biryukov	8d1e51e9c7	Docs: Add a `@since` note about new parameters with the spread operator added to function signatures. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46451 git-svn-id: http://core.svn.wordpress.org/trunk@46249 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-09 04:28:02 +00:00
johnjamesjacoby	477f0ffd71	Network Admin: Improve Site States in List Table rows. This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.) Fixes #37684. Props pbiron. Built from https://develop.svn.wordpress.org/trunk@46441 git-svn-id: http://core.svn.wordpress.org/trunk@46239 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-08 17:46:02 +00:00
Sergey Biryukov	760a55b310	Docs: Add missing `@deprecated` tags in the file docblock of some deprecated files. Props jrf. Fixes #48254. Built from https://develop.svn.wordpress.org/trunk@46439 git-svn-id: http://core.svn.wordpress.org/trunk@46237 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-08 17:19:04 +00:00
Andrew Ozz	f793398e4f	Upload: Set custom header with the attachment ID for all uploads from `media_handle_upload()`. Let the REST API endpoint set it separately. Props timothyblynjacobs. Fixes #48200. Built from https://develop.svn.wordpress.org/trunk@46421 git-svn-id: http://core.svn.wordpress.org/trunk@46219 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-07 15:30:02 +00:00
Andrea Fercia	1f3d583825	Accessibility: Media: Improve the search media field labelling. Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels. Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format. Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example: - users with cognitive disabilities may have trouble remembering what the filled field does - speech recognition users cannot see the name they can speak to set focus on the field - low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia. See #40331. Fixes #47138. Built from https://develop.svn.wordpress.org/trunk@46418 git-svn-id: http://core.svn.wordpress.org/trunk@46216 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-07 12:43:03 +00:00
Sergey Biryukov	554b60da76	Docs: Format comments in `wp-admin/includes/plugin.php` as per the documentation standards. Props dkarfa. Fixes #48191. Built from https://develop.svn.wordpress.org/trunk@46410 git-svn-id: http://core.svn.wordpress.org/trunk@46208 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-06 02:23:03 +00:00
Sergey Biryukov	f1b5f2aa94	Site Health: Improve the wording for `UTF8MB4` test description. Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans. Fixes #48044. Built from https://develop.svn.wordpress.org/trunk@46402 git-svn-id: http://core.svn.wordpress.org/trunk@46201 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 02:39:58 +00:00
Sergey Biryukov	f19ecd19de	Filesystem API: Use strict type check in the `in_array()` call for the `$skip_list` parameter in `copy_dir()` and `_copy_dir()`. This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped. Props codex-m. Fixes #46581. Built from https://develop.svn.wordpress.org/trunk@46400 git-svn-id: http://core.svn.wordpress.org/trunk@46199 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 02:16:56 +00:00
Sergey Biryukov	30913bc9a2	Docs: Correct formatting of the `@return` value description in `_wp_handle_upload()`. See #47110. Built from https://develop.svn.wordpress.org/trunk@46399 git-svn-id: http://core.svn.wordpress.org/trunk@46198 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 02:09:57 +00:00
Sergey Biryukov	60617d471b	Docs: Add missing documentation for the first parameter of the `big_image_size_threshold` filter. Props dkarfa, desrosj, earnjam. Fixes #48214. Built from https://develop.svn.wordpress.org/trunk@46398 git-svn-id: http://core.svn.wordpress.org/trunk@46197 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 01:30:58 +00:00
Sergey Biryukov	d2a48496d2	Docs: Add missing description for `$comment` global. Props immeet94, mukesh27. Fixes #46928. See #47110. Built from https://develop.svn.wordpress.org/trunk@46391 git-svn-id: http://core.svn.wordpress.org/trunk@46190 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 22:19:57 +00:00
Sergey Biryukov	f34db2aa7e	I18N: Add missing comma in a translator comment. See #47515. Built from https://develop.svn.wordpress.org/trunk@46390 git-svn-id: http://core.svn.wordpress.org/trunk@46189 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 22:09:57 +00:00
Dominik Schilling	d38d1c2c35	I18N: Fix translator comment for a themes list table string with numbered placeholders. Props garrett-eclipse. Fixes #47515. Built from https://develop.svn.wordpress.org/trunk@46387 git-svn-id: http://core.svn.wordpress.org/trunk@46186 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 20:20:58 +00:00
Dominik Schilling	cd6110782e	Networks and Sites: Improve newly added strings for i18n. * Remove unnecessary numbered placeholders. * Add context to "All" and "Spam" status. * Add translator comments. Props pedromendonca. Fixes #48210. Built from https://develop.svn.wordpress.org/trunk@46385 git-svn-id: http://core.svn.wordpress.org/trunk@46184 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 19:58:55 +00:00
Andrew Ozz	ff225c8bfc	Upload: Fix the method used to create image sub-sizes when uploading fails with a PHP fatal error. Use a custom header to send the new attachment post ID even in HTTP 500 responses instead of an upload reference sent by the client. Also add another cap check and remove the action when deleting an attachment post during a failed upload cleanup. Props timothyblynjacobs, clorith, azaozz. Fixes #48200. Built from https://develop.svn.wordpress.org/trunk@46382 git-svn-id: http://core.svn.wordpress.org/trunk@46181 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-03 21:02:00 +00:00
desrosj	efa9da7446	Docs: Fix code example for removing internal pointers. Props daleharrison, swissspidy, garrett-eclipse, luciano-croce, jrf, desrosj. Fixes #45529. Built from https://develop.svn.wordpress.org/trunk@46381 git-svn-id: http://core.svn.wordpress.org/trunk@46180 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-03 20:39:58 +00:00
desrosj	6a0f3ddae3	Menus: Fix typo in the class attribute for the hidden `title` field in `Walker_Nav_Menu_Checklist`. Each item that `Walker_Nav_Menu_Checklist` displays is accompanied by several hidden `<input/>` fields that specify default values for each item when added to a menu. These values are passed in JavaScript to the AJAX call triggered when an item is added to a menu. The hidden field for the title attribute field incorrectly had an underscore instead of a hyphen. Because of this, it was impossible to supply a default value for the Title Attribute field of a nav menu item. Props yanngarcia, davidbaumwald. See #47838. Built from https://develop.svn.wordpress.org/trunk@46380 git-svn-id: http://core.svn.wordpress.org/trunk@46179 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-03 20:03:56 +00:00
Sergey Biryukov	3e40f12574	Privacy: Remove unused `$wpdb` global in `WP_Privacy_Requests_Table::prepare_items()`. Props david.binda. Fixes #48178. Built from https://develop.svn.wordpress.org/trunk@46374 git-svn-id: http://core.svn.wordpress.org/trunk@46173 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-02 23:22:58 +00:00
Sergey Biryukov	44c3cefb24	Docs: Fix typo in `wp_get_missing_image_subsizes()` DocBlock. Props david.binda. Fixes #48179. Built from https://develop.svn.wordpress.org/trunk@46368 git-svn-id: http://core.svn.wordpress.org/trunk@46167 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-01 01:19:57 +00:00
antpb	6531c237e7	Media: Prevents clipping of text when scaling image edit screen. This reapplies [46354] clean as the previous commit had remnants of an unrelated patch. Props sabernhardt, audrasjb, afercia. See #47115. Built from https://develop.svn.wordpress.org/trunk@46359 git-svn-id: http://core.svn.wordpress.org/trunk@46158 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 17:56:57 +00:00
desrosj	ae29987a17	Site Health: Improve the message displayed to sites not utilizing HTTPS. The new message better illustrates that there are many potential benefits of using HTTPS, not just a few. Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj. Fixes #48118. Built from https://develop.svn.wordpress.org/trunk@46358 git-svn-id: http://core.svn.wordpress.org/trunk@46157 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 17:54:58 +00:00
antpb	247e7eb7d5	Media: Revert [46354] preventing bad clipping of text in image details page. See #47115. Built from https://develop.svn.wordpress.org/trunk@46355 git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 17:12:59 +00:00
antpb	7c8028febf	Media: Prevents clipping of text when scaling image edit screen. Props sabernhardt, audrasjb, afercia. See #47115. Built from https://develop.svn.wordpress.org/trunk@46354 git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 16:34:58 +00:00
Andrew Ozz	38e6958698	Media: Move `wp_get_original_image_path()` to `wp-content/post.php` to make it easier to access from plugins. Props pbiron. See #47873. Built from https://develop.svn.wordpress.org/trunk@46353 git-svn-id: http://core.svn.wordpress.org/trunk@46152 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 16:28:59 +00:00
Sergey Biryukov	5f2c7142a1	Docs: Improve documentation for `::display()` methods in various list tables. Props itowhid06. Fixes #47947. Built from https://develop.svn.wordpress.org/trunk@46341 git-svn-id: http://core.svn.wordpress.org/trunk@46140 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-29 11:04:58 +00:00
Sergey Biryukov	07a753cb35	Docs: Add documentation for `WP_Comments_List_Table::display()`. Props itowhid06, dinhtungdu. Fixes #47929. Built from https://develop.svn.wordpress.org/trunk@46336 git-svn-id: http://core.svn.wordpress.org/trunk@46135 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-27 23:03:58 +00:00
whyisjake	c034f5b4c3	Menus: Replace http with https in placeholders. Encourage the use of https with the placeholder text in menus. Fixes #46312 Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin. Built from https://develop.svn.wordpress.org/trunk@46330 git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-26 20:32:55 +00:00

... 3 4 5 6 7 ...

7740 Commits