Sergey Biryukov
084b48e1ba
Help/About: Adjust capability checks formatting in help text on Dashboard screen for readability and consistency with similar checks in other files.
...
See #43472 .
Built from https://develop.svn.wordpress.org/trunk@42783
git-svn-id: http://core.svn.wordpress.org/trunk@42613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:32:30 +00:00
Sergey Biryukov
24f13abf63
Help/About: Remove popular plugins feed reference from help text on Dashboard screen, no longer relevant since [40607].
...
Props denisco.
See #43472 .
Built from https://develop.svn.wordpress.org/trunk@42782
git-svn-id: http://core.svn.wordpress.org/trunk@42612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:17:31 +00:00
Sergey Biryukov
31a3083c28
Help/About: Update "WordPress News" widget references in help text and inline documentation.
...
Props monikarao, denisco.
Fixes #43400 , #43472 .
Built from https://develop.svn.wordpress.org/trunk@42781
git-svn-id: http://core.svn.wordpress.org/trunk@42611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:04:31 +00:00
Sergey Biryukov
5596017878
Media: Recognize .ico
files as displayable images on PHP 5.3+ and allow attachment meta data to be generated for them.
...
Props remyvv, Guido07111975.
Fixes #43458 .
Built from https://develop.svn.wordpress.org/trunk@42780
git-svn-id: http://core.svn.wordpress.org/trunk@42610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 01:03:31 +00:00
Sergey Biryukov
e451dfac9e
Help/About: Correct the number of most recent drafts in help text on Dashboard screen.
...
Props denisco.
Fixes #43471 .
Built from https://develop.svn.wordpress.org/trunk@42779
git-svn-id: http://core.svn.wordpress.org/trunk@42609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 00:24:30 +00:00
Sergey Biryukov
3385d5b2de
Docs: Expand delete_theme()
return value, fix typo in delete_plugins()
return value.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42778
git-svn-id: http://core.svn.wordpress.org/trunk@42608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 22:07:29 +00:00
Sergey Biryukov
58592b64dc
Docs: Use consistent description for $wp_filesystem
global.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42777
git-svn-id: http://core.svn.wordpress.org/trunk@42607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 21:58:30 +00:00
Sergey Biryukov
179bec1306
Docs: Clarify return values and improve DocBlock formatting for verify_file_md5()
, unzip_file()
, _unzip_file_ziparchive()
, _unzip_file_pclzip()
, copy_dir()
, WP_Filesystem()
.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42776
git-svn-id: http://core.svn.wordpress.org/trunk@42606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 21:43:30 +00:00
Sergey Biryukov
3c8ae81018
Docs: Clarify download_url()
return value, improve DocBlock formatting.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42775
git-svn-id: http://core.svn.wordpress.org/trunk@42605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 19:50:31 +00:00
Sergey Biryukov
7b7ca428f3
Docs: Clarify that wp_update_user()
accepts an array as $userdata
argument.
...
Props nextendweb.
Fixes #43051 .
Built from https://develop.svn.wordpress.org/trunk@42774
git-svn-id: http://core.svn.wordpress.org/trunk@42604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 18:12:31 +00:00
Sergey Biryukov
86c3c7e1c9
Filesystem API: Allow download_url()
to return the response code and body on error as an additional WP_Error
object data.
...
The error response body size is limited to 1 KB by default to avoid taking up too much memory. The size can be increased using `download_url_error_max_body_size` filter.
Props soulseekah, campusboy1987, mihdan, SergeyBiryukov.
Fixes #43329 .
Built from https://develop.svn.wordpress.org/trunk@42773
git-svn-id: http://core.svn.wordpress.org/trunk@42603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 17:14:31 +00:00
Andrew Ozz
8ae59374f3
Add a checkbox to the comment form so logged out users can opt-out of commenter cookies.
...
Props lakenh, xkon, birgire, azaozz.
See #43436 .
Built from https://develop.svn.wordpress.org/trunk@42772
git-svn-id: http://core.svn.wordpress.org/trunk@42602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 16:41:33 +00:00
Dominik Schilling
d950c75307
Import: Avoid counting an uncountable type when reading arguments passed to a script.
...
Props josephscott.
Fixes #42898 .
Built from https://develop.svn.wordpress.org/trunk@42771
git-svn-id: http://core.svn.wordpress.org/trunk@42601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 17:17:31 +00:00
Andrew Ozz
de8936588c
Add pre-save content filter to make target=_blank always secure.
...
Props notnownikki, iseulde, azaozz
Fixes #43187
Built from https://develop.svn.wordpress.org/trunk@42770
git-svn-id: http://core.svn.wordpress.org/trunk@42600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 14:42:31 +00:00
Dominik Schilling
74cb5936fc
Docs: Remove trailing whitespace in wp-includes/post.php
.
...
Built from https://develop.svn.wordpress.org/trunk@42769
git-svn-id: http://core.svn.wordpress.org/trunk@42599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 10:02:33 +00:00
Boone Gorges
35ad9e9efc
Allow LIKE
queries against the 'key' value in meta queries.
...
The new `compare_key=LIKE` parameter works in conjunction with `key` in a
similar way to the `compare=LIKE` and `value`: by doing a "compares" `LIKE`
query. This allows developers to do partial matches against keys when
doing meta queries.
Props mariovalney, chasewg.
Fixes #42409 .
Built from https://develop.svn.wordpress.org/trunk@42768
git-svn-id: http://core.svn.wordpress.org/trunk@42598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-01 04:03:33 +00:00
Andrea Fercia
d2d64f13c7
Accessibility: Change the comments "Quick Edit" and "Reply" links to buttons.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Props Cheffeid, audrasjb, afercia.
See #43382 , #38677 .
Fixes #43376 .
Built from https://develop.svn.wordpress.org/trunk@42767
git-svn-id: http://core.svn.wordpress.org/trunk@42597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 22:36:34 +00:00
Sergey Biryukov
e786f9eb91
Docs: Mark WP_Http::_dispatch_request()
as deprecated. It's no longer used since [37428].
...
Fixes #43414 .
Built from https://develop.svn.wordpress.org/trunk@42766
git-svn-id: http://core.svn.wordpress.org/trunk@42596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:48:30 +00:00
Sergey Biryukov
b0ddd7ca43
Docs: Add description for register_admin_color_schemes()
.
...
Props terriann, danieltj.
Fixes #42779 .
Built from https://develop.svn.wordpress.org/trunk@42765
git-svn-id: http://core.svn.wordpress.org/trunk@42595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:28:31 +00:00
Sergey Biryukov
7d8809c98b
XML-RPC: Unify permission error messages in wp_xmlrpc_server
.
...
Props ramiy.
Fixes #42266 .
Built from https://develop.svn.wordpress.org/trunk@42764
git-svn-id: http://core.svn.wordpress.org/trunk@42594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:19:31 +00:00
iandunn
acfced54f0
External Libraries: Test for MEjs files in src
instead of build
.
...
The `build` task doesn't get run during TravisCI jobs, so the `build` folder doesn't exist in that context. Because of that, the test added in r42762 was failling.
Checking for the files in `src` instead achieves the same goal as that commit, but should pass in Travis.
See #43101
See https://wordpress.slack.com/archives/C02RQBWTW/p1519742993000615
Built from https://develop.svn.wordpress.org/trunk@42763
git-svn-id: http://core.svn.wordpress.org/trunk@42593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 00:26:31 +00:00
iandunn
f71c4f38c3
External Libraries: Test that MediaElement SWF files remain deleted.
...
The files were removed from Core in r42462 because they're no longer necessary, and have a history of security issues. They remain upstream, though, so this test makes it explicitly clear that they should not be added back in the future without careful consideration and discussion with the Security team.
`Tests_Admin_IncludesUpdateCore::test_new_files_are_not_in_old_files_array_compiled()` would already catch files with the exact same name, but this test will also catch files with new names, just to be extra cautious.
Props iandunn, ocean90, SergeyBiryukov
Fixes 43101
Built from https://develop.svn.wordpress.org/trunk@42762
git-svn-id: http://core.svn.wordpress.org/trunk@42592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-27 14:38:33 +00:00
Sergey Biryukov
0e802a627d
General: Introduce WP_Error::has_errors()
method and use it where appropriate.
...
Props robdxw, DrewAPicture, SergeyBiryukov.
Fixes #42742 .
Built from https://develop.svn.wordpress.org/trunk@42761
git-svn-id: http://core.svn.wordpress.org/trunk@42591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-27 02:31:31 +00:00
iandunn
71f206839d
Build/Test Tools: Add watch:phpunit
task.
...
This allow PHPUnit test groups to run automatically when files are changed, rather than having to be ran manually throughout the development process. This creates a smoother developer experience, and a tighter feedback loop.
Props iandunn, netweb, pento
Fixes #42282
Built from https://develop.svn.wordpress.org/trunk@42760
git-svn-id: http://core.svn.wordpress.org/trunk@42590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-27 00:32:33 +00:00
Sergey Biryukov
669f8bb750
Media: Remove unnecessary aria-required
attribute from legacy (pre-3.5.0) media functions, added in [7888].
...
At the time, having both `required` and `aria-required` meant a wider range of support for browsers and assistive technology. Today, it's safe to use just `required`.
Props shital-patel, afercia, audrasjb.
Fixes #43415 .
Built from https://develop.svn.wordpress.org/trunk@42759
git-svn-id: http://core.svn.wordpress.org/trunk@42589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 23:10:31 +00:00
Sergey Biryukov
d3b2daf490
Comments: Remove unnecessary aria-required
attribute from comment_form()
, added with the function in [12810].
...
At the time, having both `required` and `aria-required` meant a wider range of support for browsers and assistive technology. Today, it's safe to use just `required`.
Props lakenh, afercia, davidakennedy, henry.wright.
Fixes #39045 .
Built from https://develop.svn.wordpress.org/trunk@42758
git-svn-id: http://core.svn.wordpress.org/trunk@42588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 20:50:30 +00:00
Dominik Schilling
666e203f31
Administration: Remove unnecessary capitalization when referencing to plugin/theme editors.
...
Fixes #43072 .
Built from https://develop.svn.wordpress.org/trunk@42757
git-svn-id: http://core.svn.wordpress.org/trunk@42587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 19:35:30 +00:00
Sergey Biryukov
a018cdd4e3
Docs: Add missing @since
entries for functions in wp-admin/image-edit.php
.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42756
git-svn-id: http://core.svn.wordpress.org/trunk@42586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 18:38:31 +00:00
Sergey Biryukov
9cb07ec40e
Taxonomy: Make the "Format" taxonomy name plural, for consistency with other taxonomies.
...
Props afercia, danieltj.
Fixes #43370 .
Built from https://develop.svn.wordpress.org/trunk@42755
git-svn-id: http://core.svn.wordpress.org/trunk@42585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 18:22:31 +00:00
Sergey Biryukov
3812402cc7
Docs: Fix typo in wp.customize.selectiveRefresh.placements()
description.
...
Props Nikschavan.
Fixes #43418 .
Built from https://develop.svn.wordpress.org/trunk@42754
git-svn-id: http://core.svn.wordpress.org/trunk@42584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 17:52:31 +00:00
Pascal Birchler
5cde2018ea
Docs: Remove erroneous period in the description for esc_html__()
.
...
Props danieltj.
Fixes #43419 .
Built from https://develop.svn.wordpress.org/trunk@42753
git-svn-id: http://core.svn.wordpress.org/trunk@42583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-26 15:57:32 +00:00
Sergey Biryukov
9226691b3c
Docs: Remove erroneous @static
notation from WP_Tax_Query::get_sql()
, added in [32627].
...
The method was never used as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42752
git-svn-id: http://core.svn.wordpress.org/trunk@42582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 21:45:30 +00:00
Sergey Biryukov
0b45a1e5fa
Docs: Remove erroneous @static
notation from WP_Http::_dispatch_request()
, added in [32650].
...
The method was never user as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42751
git-svn-id: http://core.svn.wordpress.org/trunk@42581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 21:35:30 +00:00
Sergey Biryukov
bd9cdde1eb
Docs: Remove duplicated DocBlock for http_response
hook in WP_Http::_dispatch_request()
.
...
The filter is already documented in `WP_Http::request()`.
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42750
git-svn-id: http://core.svn.wordpress.org/trunk@42580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 21:32:30 +00:00
Sergey Biryukov
510feac5bb
Twenty Fourteen: Remove redundant @access
and @static
notations from classes.
...
Props birgire.
See #41452 , #42803 , #42505 .
Built from https://develop.svn.wordpress.org/trunk@42749
git-svn-id: http://core.svn.wordpress.org/trunk@42579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:49:30 +00:00
Sergey Biryukov
c3738e9617
Docs: Remove @access
notation from WP_Taxonomy::$meta_box_sanitize_cb
.
...
See #42505 , #41452 .
Built from https://develop.svn.wordpress.org/trunk@42748
git-svn-id: http://core.svn.wordpress.org/trunk@42578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:38:30 +00:00
Sergey Biryukov
b026fde152
Docs: Remove @static
notations from property DocBlocks in wp-admin/*
and wp-includes/*
classes.
...
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42747
git-svn-id: http://core.svn.wordpress.org/trunk@42577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:32:30 +00:00
Sergey Biryukov
08227812a0
Docs: Remove @static
notations from method DocBlocks in wp-includes/*
classes.
...
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42746
git-svn-id: http://core.svn.wordpress.org/trunk@42576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:22:30 +00:00
Sergey Biryukov
0fea564b7d
Docs: Remove @static
notations from method DocBlocks in wp-admin/*
classes.
...
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42745
git-svn-id: http://core.svn.wordpress.org/trunk@42575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:06:30 +00:00
Adam Silverstein
de6906a045
Customizer: in menus, reset results when closing the 'add items' panel.
...
Trigger a keyup event when clearing the search field in response to closing the add item panel. The keyup event triggers a search and resets the results. Previously, the search field was cleared while the potentially blank search results were left in place making it impossible to select new menu items.
Props Blair jersyer, aranwer104, afercia.
Fixes #43333 .
Built from https://develop.svn.wordpress.org/trunk@42744
git-svn-id: http://core.svn.wordpress.org/trunk@42574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 18:48:29 +00:00
Sergey Biryukov
b34b1ee061
Tests: Correct a "false positive" assertion in test_media_handle_upload_ignores_page_parent_for_directory_date()
.
...
Props birgire.
Fixes #42736 .
Built from https://develop.svn.wordpress.org/trunk@42743
git-svn-id: http://core.svn.wordpress.org/trunk@42573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 18:47:30 +00:00
Sergey Biryukov
61e8101442
Tests: Avoid hardcoded domain name in test_media_handle_upload_uses_post_parent_for_directory_date()
.
...
Props birgire.
See #42736 .
Built from https://develop.svn.wordpress.org/trunk@42742
git-svn-id: http://core.svn.wordpress.org/trunk@42572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 18:43:30 +00:00
Adam Silverstein
89c9e27fd1
Unit Tests: add a DIR_TESTROOT constant to avoid relative paths.
...
Fix an issue that prevents tests from running correctly when run outside their normal context.
Props PressLabs, johnbillion.
Fixes #40071 .
Built from https://develop.svn.wordpress.org/trunk@42741
git-svn-id: http://core.svn.wordpress.org/trunk@42571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 18:07:31 +00:00
Adam Silverstein
a299c5c344
Fix eshint error since r42739.
...
Remove a trailing comma in [42739] that was throing a jshint error.
Built from https://develop.svn.wordpress.org/trunk@42740
git-svn-id: http://core.svn.wordpress.org/trunk@42570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:49:30 +00:00
Adam Silverstein
da89d20c39
Media: grid view - correct placeholder positioning during uploads.
...
Preventing contextually created attachments from being added to the grid collection in Attachments.validator. Remove the previous filtering introduced in [41937] which caused the placement issue.
Props lancewillett, Junaidkbr, designsimply, joemcgill.
Fixes #42968 .
Built from https://develop.svn.wordpress.org/trunk@42739
git-svn-id: http://core.svn.wordpress.org/trunk@42569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:41:31 +00:00
Sergey Biryukov
4d47bfce41
Coding Standards: Fix code indent in unescape_invalid_shortcodes()
.
...
Props joelcj91, GaryJ.
Fixes #43346 .
Built from https://develop.svn.wordpress.org/trunk@42738
git-svn-id: http://core.svn.wordpress.org/trunk@42568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:36:30 +00:00
Adam Silverstein
505c2ddb61
Taxonomy: restore TagSearch unit tests and correct deprecated version string.
...
Reverts unit test removal, instead changing them to expect the function to be deprecated.
Correct the version the ajax callback was deprecated.
Amends [42614].
Props dlh, ocean90.
Fixes #38922 .
Built from https://develop.svn.wordpress.org/trunk@42737
git-svn-id: http://core.svn.wordpress.org/trunk@42567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:28:30 +00:00
Sergey Biryukov
395667f916
Comments: After [42703], make sure $args['type']
in paginate_comments_links()
is always defined.
...
Props anantajitjg.
Fixes #43299 .
Built from https://develop.svn.wordpress.org/trunk@42736
git-svn-id: http://core.svn.wordpress.org/trunk@42566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 16:08:30 +00:00
Sergey Biryukov
35d5163d66
Docs: Correct description for WP_User::get_role_caps()
.
...
Props thomaswm.
Fixes #43410 .
Built from https://develop.svn.wordpress.org/trunk@42735
git-svn-id: http://core.svn.wordpress.org/trunk@42565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 15:39:30 +00:00
Sergey Biryukov
b6229650e0
Themes: Pre-translate theme names on Themes screen before sorting the array, to improve performance and avoid a warning in PHP 5.x.
...
Props bobbingwide, sebastian.pisula.
Fixes #34565 .
Built from https://develop.svn.wordpress.org/trunk@42734
git-svn-id: http://core.svn.wordpress.org/trunk@42564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 13:18:30 +00:00