Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-15 23:25:50 +01:00
Code Issues Projects Releases Wiki Activity
35,192 Commits 50 Branches 748 Tags 792 MiB
36219c4f95
Commit Graph

22414 Commits

Author SHA1 Message Date
Dion Hulse
30270d851f HTTP: Accept non-string values in cookies, fixing a regression since 4.5. 
Props swissspidy.
Fixes #37768 for trunk.

Built from https://develop.svn.wordpress.org/trunk@38430


git-svn-id: http://core.svn.wordpress.org/trunk@38371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-29 02:42:45 +00:00
Dion Hulse
e45ebb28f2 HTTP: Handle an edgecase within the URI parsing library included in Requests, where if a double slash exists at the start of the path the URL is passed to cURL malformed. 
Props flixos90 for initial patch.
Fixes #37733 for trunk.

Built from https://develop.svn.wordpress.org/trunk@38429


git-svn-id: http://core.svn.wordpress.org/trunk@38370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-29 02:33:34 +00:00
John Blackbourn
b3faafc632 Themes: Correct the list of possible values for the dynamic portion of the {$type}_template_hierarchy and {$type}_template filters. 
See #14310

Built from https://develop.svn.wordpress.org/trunk@38428


git-svn-id: http://core.svn.wordpress.org/trunk@38369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 23:57:49 +00:00
Andrew Ozz
2b0e81c595 TinyMCE: change the default font for the vi locale to the same stack as he_IL. 
Props nmt90 for reporting and testing this.
Fixes #37755 for trunk.
Built from https://develop.svn.wordpress.org/trunk@38427


git-svn-id: http://core.svn.wordpress.org/trunk@38368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 18:52:41 +00:00
Andrew Ozz
bbc12c3dbe Editor: fix jumpiness on pressing backspace and delete in the Text editor. 
Fixes #37690 for trunk.
Built from https://develop.svn.wordpress.org/trunk@38426


git-svn-id: http://core.svn.wordpress.org/trunk@38367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 18:40:31 +00:00
Ella Iseulde Van Dorpe
b67367b6f8 Editor: Use Beacon API over sync request 
See https://www.w3.org/TR/beacon/ for more information.


Built from https://develop.svn.wordpress.org/trunk@38425


git-svn-id: http://core.svn.wordpress.org/trunk@38366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 18:29:30 +00:00
John Blackbourn
dbdc1c28b1 I18N: Correct various instances of incorrect usage of esc_attr_e(). 
Fixes #37457
Props henry.wright, afercia

Built from https://develop.svn.wordpress.org/trunk@38424


git-svn-id: http://core.svn.wordpress.org/trunk@38365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 18:06:30 +00:00
John Blackbourn
a7c3974cdc Upgrade/Install: Don't display PHP errors during installation. 
If a user is installing WordPress for the first time and has set `WP_DEBUG` to true, a PHP error during installation makes for a visually jarring experience.

Fixes #37358

Built from https://develop.svn.wordpress.org/trunk@38423


git-svn-id: http://core.svn.wordpress.org/trunk@38364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 17:50:29 +00:00
John Blackbourn
348c50b2a8 Formatting: Add a parameter to wp_send_json_error(), wp_send_json_success(), and wp_send_json() for specifying the HTTP response code. 
Defaults to `200` in all cases, but can be used, for example, to return a `403` when using `wp_send_json_error()`.

Fixes #35666
Props stephenharris

Built from https://develop.svn.wordpress.org/trunk@38422


git-svn-id: http://core.svn.wordpress.org/trunk@38363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 17:42:28 +00:00
John Blackbourn
a1d61a95e1 Security: Return a 403 instead of a 200 HTTP status when check_ajax_referer() fails. 
This is, unfortunately, untestable in the current test suite, even in the AJAX tests.

Fixes #36362

Built from https://develop.svn.wordpress.org/trunk@38421


git-svn-id: http://core.svn.wordpress.org/trunk@38362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 17:31:30 +00:00
John Blackbourn
b85e322e35 Security: Trigger a _doing_it_wrong() when check_ajax_referer() is called without its first parameter. This brings it inline with check_admin_referer(). 
Fixes #36361

Built from https://develop.svn.wordpress.org/trunk@38420


git-svn-id: http://core.svn.wordpress.org/trunk@38361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 17:15:28 +00:00
John Blackbourn
6b3a3713fd Themes: Introduce tests for the theme template hierarchy. 
See #14310

Built from https://develop.svn.wordpress.org/trunk@38419


git-svn-id: http://core.svn.wordpress.org/trunk@38360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 16:19:28 +00:00
John Blackbourn
d346835bfb Themes: Update filter names in the inline documentation for the get_*_template() functions. 
See #14310, #37770

Built from https://develop.svn.wordpress.org/trunk@38418


git-svn-id: http://core.svn.wordpress.org/trunk@38359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 16:15:30 +00:00
John Blackbourn
5985804f1f Permalinks: Correct an invalid peramstructure tag in a test. 
Fixes #37858

Built from https://develop.svn.wordpress.org/trunk@38417


git-svn-id: http://core.svn.wordpress.org/trunk@38358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 12:53:29 +00:00
Pascal Birchler
a09d7f3615 Bootstrap: Fix failing external HTTP tests after [38411]. 
When testing the transports, the transport name needs to be capitalized for the class name to be correct (`WP_Http_Curl` vs. `WP_Http_curl` ).

See #36335.
Built from https://develop.svn.wordpress.org/trunk@38416


git-svn-id: http://core.svn.wordpress.org/trunk@38357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 10:34:30 +00:00
Pascal Birchler
ac83e26875 Upgrade/Install: After [37687], fix the number of params passed to the upgrade hooks. 
`wp_version_check()`, `wp_update_plugins()` and `wp_update_themes()` are all originally hooked to the `upgrader_process_complete` action with zero arguments passed to them. Zero arguments should be passed when re-adding them after translation updates, otherwise the sky will fall.

Props ionutst, gitlost.
Fixes #37731.
Built from https://develop.svn.wordpress.org/trunk@38415


git-svn-id: http://core.svn.wordpress.org/trunk@38356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 10:04:30 +00:00
Scott Taylor
f96fff3c9d Admin: allow WP_Screen to be checked via autoload in convert_to_screen(). 
Props kraftbj.
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38414


git-svn-id: http://core.svn.wordpress.org/trunk@38355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 02:25:27 +00:00
John Blackbourn
17db8134c4 Query: Add and improve tests for query conditionals on the front page and home page. 
See #37851

Built from https://develop.svn.wordpress.org/trunk@38413


git-svn-id: http://core.svn.wordpress.org/trunk@38354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 02:02:32 +00:00
Scott Taylor
2a9b372471 Script Loader: autoload in load-{scripts|styles}.php. 
Props JohnPBloch.
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38412


git-svn-id: http://core.svn.wordpress.org/trunk@38353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-28 00:07:33 +00:00
Scott Taylor
390ceba6c7 Bootstrap: after r38409 and r38410, revert r38402 which reverted r38399. 
This fixes the paths in `wp-vendor/` that were including `src`. I want to drop this in so we can find out what else will break.

See #36335.

Built from https://develop.svn.wordpress.org/trunk@38411


git-svn-id: http://core.svn.wordpress.org/trunk@38352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 22:32:37 +00:00
Scott Taylor
1798d34f73 Bootstrap: run composer install after r38409. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38410


git-svn-id: http://core.svn.wordpress.org/trunk@38351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 19:09:30 +00:00
Scott Taylor
4bf37e5555 Bootstrap: move composer.{json|lock} into src. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38409


git-svn-id: http://core.svn.wordpress.org/trunk@38350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 19:06:31 +00:00
John Blackbourn
e0a0be9579 Media: Add a $wp_error parameter to wp_insert_attachment() to give it parity with wp_insert_post(). 
Fixes #37813
Props grapplerulrich, mrahmadawais

Built from https://develop.svn.wordpress.org/trunk@38408


git-svn-id: http://core.svn.wordpress.org/trunk@38349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 17:25:29 +00:00
John Blackbourn
d194f60a5c Build/Test tools: Ensure the Tests_Query_Conditionals tests set up the environment correctly before re-registering initial taxonomies. 
Fixes #37851

Built from https://develop.svn.wordpress.org/trunk@38407


git-svn-id: http://core.svn.wordpress.org/trunk@38348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 17:03:33 +00:00
John Blackbourn
9070bb3ace Users: Correct the documentation for the wp_dropdown_users_args filter description and its parameters. 
See #37770

Built from https://develop.svn.wordpress.org/trunk@38406


git-svn-id: http://core.svn.wordpress.org/trunk@38347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 16:54:31 +00:00
John Blackbourn
4739cc0075 Build/Test Tools: Add support for is_front_page() to assertQueryTrue() and assert that all the tested conditions are supported by the method. 
Fixes #37849

Built from https://develop.svn.wordpress.org/trunk@38405


git-svn-id: http://core.svn.wordpress.org/trunk@38346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 15:28:28 +00:00
Dion Hulse
ec83ce1a0c i18n: Retire another remaining wp-includes/locale.php require, and instead load the required WP_Locale class directly. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38404


git-svn-id: http://core.svn.wordpress.org/trunk@38345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 15:13:33 +00:00
John Blackbourn
71e8e8368a Themes: Remove failing tests introduced in [38390]. 
See #14310

Built from https://develop.svn.wordpress.org/trunk@38403


git-svn-id: http://core.svn.wordpress.org/trunk@38344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 14:53:38 +00:00
Dion Hulse
0e31a46161 Bootstrap: Revert [38399] as it's broken /build/ and subsequently core.svn.wordpress.org. 
The generated classmaps reference `/src/` files and operates in the assumption that the base directory is one level above `wp-settings.php`, which it isn't after our build processes are run.

See #36335

Built from https://develop.svn.wordpress.org/trunk@38402


git-svn-id: http://core.svn.wordpress.org/trunk@38343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 14:37:32 +00:00
Pascal Birchler
8b5fc84e63 After [38399], update the .gitignore file accordingly. 
The following files have been added to `svn:ignore` already as they are not compatible with PHP 5.2:

* src/wp-vendor/autoload.php
* src/wp-vendor/composer/autoload_real.php
* src/wp-vendor/composer/autoload_static.php
* src/wp-vendor/composer/ClassLoader.php

See #36335.
Built from https://develop.svn.wordpress.org/trunk@38401


git-svn-id: http://core.svn.wordpress.org/trunk@38342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 11:29:28 +00:00
Peter Wilson
62717837b5 Unit tests: Enforce $args object in wp_nav_menu() & Walker_Nav_Menu. 
WordPress always* passes $args to filters as an array of arugments. A exception is made in `wp_nav_menu()` and the associated walker where these are passed to filters as an object, this has been the case for seven years (since [13368]).

These new tests enforce the use of an object in these filters to ensure backward compatibility is maintained.

See #24587.

Built from https://develop.svn.wordpress.org/trunk@38400


git-svn-id: http://core.svn.wordpress.org/trunk@38341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 11:28:30 +00:00
Scott Taylor
6a529648cf Bootstrap: Autoload classes using a Composer-generated PHP 5.2-compatible Autoloader. 
* `wp-admin` and `wp-includes` are scanned for classes to autoload
* Several 3rd-party and Ryan McCue-shaped libraries are excluded when the classmap is generated, see `composer.json`: `autoload.exclude-from-classmap`
* `wp-vendor/autoload_52.php` is included at the top of `wp-settings.php` - no changes need to be made to unit tests to include the autoloader
* An avalanche of `require()` and `require_once()` calls that loaded class files have been removed from the codebase.

The following files have been added to `svn:ignore` - they are not 5.2-compatible and fail during pre-commit:
* src/wp-vendor/autoload.php
* src/wp-vendor/composer/autoload_real.php
* src/wp-vendor/composer/autoload_static.php
* src/wp-vendor/composer/ClassLoader.php

We favor these files instead:
* src/wp-vendor/autoload_52.php
* src/wp-vendor/composer/autoload_real_52.php
* src/wp-vendor/composer/ClassLoader52.php

When new PHP classes are added to the codebase, simply run `composer install` or `composer update` from the project root to update the autoloader.

The future is now.

See #36335.

Built from https://develop.svn.wordpress.org/trunk@38399


git-svn-id: http://core.svn.wordpress.org/trunk@38340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 09:15:29 +00:00
Scott Taylor
cb74a4401b Unit Tests: 
* Automatically delete objects that we were created during `wpSetUpBeforeClass` - posts, comments, terms (except 1), and user (except 1)
* The amount of leftover data between tests was breathtaking - use the new function: `_delete_all_data()`
* Commit database transactions for all `TestCase`s, not just those that implement `wpSetUpBeforeClass` and `wpTearDownAfterClass`
* The tests run 10-20 seconds faster now

See #37699.

Built from https://develop.svn.wordpress.org/trunk@38398


git-svn-id: http://core.svn.wordpress.org/trunk@38339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 08:36:31 +00:00
Scott Taylor
85d63f2af5 Press This: the file for the WP_Press_This class should not produce side effects. Similar to what we did in r38355 for WP_Site_Icon, drop the instances of global instantiation for $wp_press_this via loading the file. The variable can be set inline when necessary. In most of those places, if the global is already set, the file does not load and stomp it currently. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38397


git-svn-id: http://core.svn.wordpress.org/trunk@38338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 06:07:29 +00:00
Weston Ruter
e6ed174135 Customize: Circumvent the customizer attempting to preview links to static assets (such as uploaded images). 
The customizer's preview POST requests to static assets result in 405 Method Not Allowed responses.

Fixes #37828.

Built from https://develop.svn.wordpress.org/trunk@38396


git-svn-id: http://core.svn.wordpress.org/trunk@38337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 06:05:29 +00:00
Scott Taylor
e05a033bcb Bootstrap: exclude more files from the autoloader.classmap in composer.json. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38395


git-svn-id: http://core.svn.wordpress.org/trunk@38336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 05:40:29 +00:00
Scott Taylor
599d45019f Bootstrap: add composer.lock and src/wp-vendor files. Nothing is using this code yet, just going through the motions. Ignore the files in src/wp-vendor/composer that will explode in PHP 5.2. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38394


git-svn-id: http://core.svn.wordpress.org/trunk@38335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 03:49:28 +00:00
Scott Taylor
bb16c53108 Bootstrap: run composer require xrstf/composer-php52 to get the updated suggested version. Change the vendor-dir to wp-vendor. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38393


git-svn-id: http://core.svn.wordpress.org/trunk@38334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-27 03:36:29 +00:00
Scott Taylor
06aa510d56 List Tables: move _WP_List_Table_Compat into its own file. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38392


git-svn-id: http://core.svn.wordpress.org/trunk@38333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 22:23:29 +00:00
Scott Taylor
99aef2df30 Bootstrap: exclude some files from the Composer autoload setup via exclude-from-classmap. 
See #36335.


Built from https://develop.svn.wordpress.org/trunk@38391


git-svn-id: http://core.svn.wordpress.org/trunk@38332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 22:21:31 +00:00
John Blackbourn
3c6dd1d00d Themes: Begin introducing unit tests for the expected theme template hierarchy. More to come. 
See #14310

Built from https://develop.svn.wordpress.org/trunk@38390


git-svn-id: http://core.svn.wordpress.org/trunk@38331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 22:20:28 +00:00
Scott Taylor
c99df3a708 XML-RPC: break up class-IXR.php into individual class files. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38389


git-svn-id: http://core.svn.wordpress.org/trunk@38330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 22:08:33 +00:00
Scott Taylor
08233c6aff Multisite: move get_current_site() to load.php so that it can be used in more places, instead of importing global $current_site. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38388


git-svn-id: http://core.svn.wordpress.org/trunk@38329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 21:35:30 +00:00
Scott Taylor
35bdc07eac Roles: set a property, $db, on WP_Roles to reduce global imports. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38387


git-svn-id: http://core.svn.wordpress.org/trunk@38328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 21:16:59 +00:00
Scott Taylor
b9f516e55e Bootstrap: load option.php in wp-settings.php, not in functions.php. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38386


git-svn-id: http://core.svn.wordpress.org/trunk@38327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 21:11:29 +00:00
John Blackbourn
9e1542b9ec Themes: Make the template hierarchy for a given template type filterable. 
This introduces a `{$type}_template_hierarchy` filter that allows the hierarchy of candidate template filenames for a given template type to be filtered.

This allows the hierarchy to be added to or altered completely without resorting to re-building the hierarchy from scratch within the `template_include` filter, which is common and prone to conflicts between plugins and prone to getting out of sync with core's hierarchy.

Fixes #14310

Built from https://develop.svn.wordpress.org/trunk@38385


git-svn-id: http://core.svn.wordpress.org/trunk@38326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 21:03:27 +00:00
Scott Taylor
29959d0448 Bootstrap: add a composer.json file to the project. No code relies on it (yet), and no vendor dir is checked in (yet). No autoloader is being used (yet). Taking this first step will hopefully encourage the perfectionists of our world to scrutinize each line. 
To fiddle around with what it does, run `composer install` from the project root. If you do not have Composer installed:
https://getcomposer.org/doc/00-intro.md#locally

tl;dr for Mac/Homebrew users: `brew install composer`

Classes from `wp-includes` and `wp-admin` are eligible for autoloading via `autoload.classmap`. Through a tornado of recent commits, many unsuitable files have been transitioned into a more acceptable state for autoloading: 1 file per class, no side effects.

The file bootstrap in `wp-settings.php` can transition into `autoload.files`. This will be done with care and attention.

See #36335.

Built from https://develop.svn.wordpress.org/trunk@38384


git-svn-id: http://core.svn.wordpress.org/trunk@38325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 21:00:29 +00:00
Scott Taylor
525bb21513 Unit Tests: after r38303, replace usage of global $_wp_additional_image_sizes with wp_get_additional_image_sizes(). 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38383


git-svn-id: http://core.svn.wordpress.org/trunk@38324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 20:51:43 +00:00
John Blackbourn
3644bc160f Build/Test Tools: Remove many unnecessary calls to rand_str() which can, in theory, fail at random. Static strings are much more appropriate. 
See #37371

Built from https://develop.svn.wordpress.org/trunk@38382


git-svn-id: http://core.svn.wordpress.org/trunk@38323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 20:22:43 +00:00
Boone Gorges
0b81d79c86 Don't improperly cast IDs when fetching post, user, or term objects. 
Blindly casting passed IDs to integers can generate false positives
when the ID is cast to `1`.

Props deeptiboddapati.
Fixes #37738.
Built from https://develop.svn.wordpress.org/trunk@38381


git-svn-id: http://core.svn.wordpress.org/trunk@38322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 19:09:27 +00:00
Scott Taylor
11216c7069 FTP: ensure that there is only one class named ftp, which is what is expected in the loading of this arcane library. This ensures that an autoload generator, something along the lines of Composer, won't hiccup when it gets to these files. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38380


git-svn-id: http://core.svn.wordpress.org/trunk@38321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 18:47:29 +00:00
Scott Taylor
b1c6049be4 Upgrade/Install: wp-admin/includes/class-wp-upgrader-skins.php is unused, remove it. All of the same includes are loaded in class-wp-upgrader.php. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38379


git-svn-id: http://core.svn.wordpress.org/trunk@38320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 18:25:30 +00:00
John Blackbourn
32d5e7f31d Role/Capability: Only users who can manage options should be able to trash/delete the page for posts or the front page, as they are the only users who can restore it or subsequently alter the "Front page displays" setting. 
Fixes #37580
Props JakePT

Built from https://develop.svn.wordpress.org/trunk@38378


git-svn-id: http://core.svn.wordpress.org/trunk@38319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 18:23:31 +00:00
Boone Gorges
3d593c5fc1 Eliminate unnecessary variable in WP_Term_Query. 
Props ocean90.
Fixes #37544.
Built from https://develop.svn.wordpress.org/trunk@38377


git-svn-id: http://core.svn.wordpress.org/trunk@38318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 18:12:26 +00:00
Scott Taylor
b3d474a6dc Load: move WP_MatchesMapRegex into its own file. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38376


git-svn-id: http://core.svn.wordpress.org/trunk@38317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 18:11:39 +00:00
Scott Taylor
b2c394a330 Script Loader: move _WP_Dependency into its own file. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38375


git-svn-id: http://core.svn.wordpress.org/trunk@38316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 18:06:39 +00:00
Scott Taylor
76c7864367 Load: remove class-feed.php (There is no class named Feed or WP_Feed, it just loads other classes) and, instead, move the require calls to the only place they are ever included: inside fetch_feed(). This simplifies the include path. 
Tested with this feed in a widget: `http://rss.nytimes.com/services/xml/rss/nyt/HomePage.xml`.

See #36335.

Built from https://develop.svn.wordpress.org/trunk@38374


git-svn-id: http://core.svn.wordpress.org/trunk@38315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 17:53:30 +00:00
Scott Taylor
524effb58f Load: remove session.php and, instead, move the 2 require calls to wp-settings.php. This simplifies the include path. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38373


git-svn-id: http://core.svn.wordpress.org/trunk@38314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 17:45:17 +00:00
Boone Gorges
51a2235c19 Use shared fixture in comment_exists() tests. 
Props Frank Klein.
Fixes #37842.
Built from https://develop.svn.wordpress.org/trunk@38372


git-svn-id: http://core.svn.wordpress.org/trunk@38313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 17:42:50 +00:00
Scott Taylor
481123661c Load: load class-phpass.php (PasswordHash class) early in wp-settings.php, instead of require_once()'ing it in several places. 
See #36335.

Built from https://develop.svn.wordpress.org/trunk@38371


git-svn-id: http://core.svn.wordpress.org/trunk@38312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 17:40:35 +00:00
John Blackbourn
f189b72b22 Docs: Alignment after [38369]. 
See #37770

Built from https://develop.svn.wordpress.org/trunk@38370


git-svn-id: http://core.svn.wordpress.org/trunk@38311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 16:51:28 +00:00
John Blackbourn
94c8ca0f2e Docs: Correct various documentation around object and stdClass types. 
See #37770

Built from https://develop.svn.wordpress.org/trunk@38369


git-svn-id: http://core.svn.wordpress.org/trunk@38310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 16:49:45 +00:00
John Blackbourn
f53cc848e4 Embeds: Add a missing regex delimiter for Facebook URLs. 
See #34737

Built from https://develop.svn.wordpress.org/trunk@38368


git-svn-id: http://core.svn.wordpress.org/trunk@38309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 12:17:28 +00:00
John Blackbourn
07c31a5437 Embeds: Add support for embedding Facebook posts and videos via oEmbed. 
Fixes #34737
Props pento, GaryJ

Built from https://develop.svn.wordpress.org/trunk@38367


git-svn-id: http://core.svn.wordpress.org/trunk@38308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 11:57:30 +00:00
John Blackbourn
a71d445b80 Embeds: Many of our oEmbed providers now default to HTTPS embeds, redirect to the HTTPS oEmbed endpoint, or have complete support for HTTPS even if they don't default to HTTPS. 
This change defaults to using HTTPS endpoints for oEmbeds for those providers that have full HTTPS support and don't redirect back to HTTP when clicking through from the embed. It covers:

* Vimeo
* SmugMug
* Scribd
* WordPress.tv
* SoundCloud
* Meetup
* issuu
* Mixcloud
* TED

See #28507

Built from https://develop.svn.wordpress.org/trunk@38366


git-svn-id: http://core.svn.wordpress.org/trunk@38307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 11:25:29 +00:00
John Blackbourn
c7884d542e Embeds: Always use the HTTPS endpoint for YouTube embeds. The scheme parameter is no longer required as all YouTube assets now use HTTPS. 
See #36274, #28507
Props zsusag, tollmanz

Built from https://develop.svn.wordpress.org/trunk@38365


git-svn-id: http://core.svn.wordpress.org/trunk@38306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 10:39:32 +00:00
Scott Taylor
6d87157eb9 i18n: move is_rtl() to l10n.php (which loads way earlier). Load WP_Locale file in wp-settings.php. Retire wp-includes/locale.php - it only loaded the class and the one function, is_rtl(). If someone loaded this file for fun somewhere else, it would be a fatal error. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38364


git-svn-id: http://core.svn.wordpress.org/trunk@38305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 10:20:29 +00:00
Scott Taylor
4d17b67eed Load: move is_wp_error() to load.php so that WP_Error is in a file by itself. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38363


git-svn-id: http://core.svn.wordpress.org/trunk@38304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 09:58:28 +00:00
Scott Taylor
b144d69ba0 Embed: wp-settings.php loads class-wp-embed.php, which currently produces side effects. Move the global instantiation to wp-settings.php. WP_Embed is then in a file by itself. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38362


git-svn-id: http://core.svn.wordpress.org/trunk@38303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 09:53:28 +00:00
Scott Taylor
ff59281441 OEmbed: move _wp_oembed_get_object() to embed.php, where all of the other embed functions live. WP_oEmbed is then in a file by itself. Load class-oembed.php in wp-settings.php and remove extraneous include calls. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38361


git-svn-id: http://core.svn.wordpress.org/trunk@38302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 09:49:28 +00:00
Scott Taylor
ac6c22c392 L10N: improve accuracy of docs. 
Props johnbillion.
Fixes #37585.

Built from https://develop.svn.wordpress.org/trunk@38360


git-svn-id: http://core.svn.wordpress.org/trunk@38301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 09:38:28 +00:00
Scott Taylor
6a43b84454 Formatting: for a performance boost in remove_accents(), convert chr() calls to string literals. 
Props gitlost.
Fixes #37643.

Built from https://develop.svn.wordpress.org/trunk@38359


git-svn-id: http://core.svn.wordpress.org/trunk@38300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 09:35:27 +00:00
Scott Taylor
a9386ea7c1 Editor: improve word-count.js documentation. 
Props jipmoors, andizer.
Fixes #37718.

Built from https://develop.svn.wordpress.org/trunk@38358


git-svn-id: http://core.svn.wordpress.org/trunk@38299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 09:25:27 +00:00
Scott Taylor
76926fa763 Cron: clarify descriptions for Cron API functions. 
Props johnbillion.
Fixes #37769.

Built from https://develop.svn.wordpress.org/trunk@38357


git-svn-id: http://core.svn.wordpress.org/trunk@38298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-26 09:22:30 +00:00
Scott Taylor
faccc617fb Query: collapse several of the is_* methods using __call(). Add @method annotations. 
Fixes #37830.

Built from https://develop.svn.wordpress.org/trunk@38356


git-svn-id: http://core.svn.wordpress.org/trunk@38297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-25 19:42:43 +00:00
Scott Taylor
9ce58d9d86 Site Icon: There is no good reason for class-wp-site-icon.php to drop a global instance of itself whenever the file is loaded. The lone use of the global instance of WP_Site_Icon is in an AJAX action that provides virtually no way to override - the file is loaded immediately before the global is used. 
Let us remove the `$wp_site_icon` global. I will fall on the sword if this comes back to bite us (waiting with bated breath).

See #37699.

Built from https://develop.svn.wordpress.org/trunk@38355


git-svn-id: http://core.svn.wordpress.org/trunk@38296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-25 19:09:35 +00:00
Scott Taylor
ed0da659bc Feed: move 'WP_Feed_Cache', 'WP_Feed_Cache_Transient', WP_SimplePie_File and WP_SimplePie_Sanitize_KSES into their own files via svn cp. If we move forard with autoloading, class-feed.php is useless. We could even remove it now, and just load these new files in wp-settings.php. That can be decided post-mortem. class-feed.php is an interesting name: there is no Feed or WP_Feed class. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38354


git-svn-id: http://core.svn.wordpress.org/trunk@38295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-25 18:18:39 +00:00
Scott Taylor
3d26e3513e Session: move WP_Session_Tokens and WP_User_Meta_Session_Tokens into their own files via svn cp. If we move forard with autoloading, session.php is useless. We could even remove it now, and just load these new files in wp-settings.php. That can be decided post-mortem. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38353


git-svn-id: http://core.svn.wordpress.org/trunk@38294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-25 17:44:31 +00:00
Scott Taylor
6620e0b3cc Diff: move WP_Text_Diff_Renderer_inline (behold that lowercase "i") and WP_Text_Diff_Renderer_Table into their own files via svn cp. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38352


git-svn-id: http://core.svn.wordpress.org/trunk@38293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-25 17:37:30 +00:00
Scott Taylor
d5f28fdad8 Query: move WP_Query into its own file via svn cp. 
See #37827.

Built from https://develop.svn.wordpress.org/trunk@38351


git-svn-id: http://core.svn.wordpress.org/trunk@38292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-25 17:20:38 +00:00
Drew Jaynes
f07f1b126e Docs: Add a missing parenthesis in an example in the DocBlock for wp_redirect(). 
Props shayanys.
See #37770.

Built from https://develop.svn.wordpress.org/trunk@38350


git-svn-id: http://core.svn.wordpress.org/trunk@38291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-25 07:36:31 +00:00
Andrew Ozz
15edc78f6f TinyMCE: fix toolbars alignment in RTL. 
Fixes #37760 for trunk.
Built from https://develop.svn.wordpress.org/trunk@38349


git-svn-id: http://core.svn.wordpress.org/trunk@38290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-25 01:20:30 +00:00
Sergey Biryukov
2cc42e5dbb Docs: Improve the docs for the_title() and make them more consistent with the_title_attribute(). 
Props ixkaito, swissspidy.
Fixes #37732.
Built from https://develop.svn.wordpress.org/trunk@38348


git-svn-id: http://core.svn.wordpress.org/trunk@38289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-24 15:59:29 +00:00
Sergey Biryukov
b79713c1b0 Administration: Underline links in the admin footer for better accessibility. 
Props Presskopp.
Fixes #37529.
Built from https://develop.svn.wordpress.org/trunk@38347


git-svn-id: http://core.svn.wordpress.org/trunk@38288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-24 15:43:31 +00:00
Sergey Biryukov
d611efe5b1 I18N: Add translator comments for strings in wp-includes/functions.wp-scripts.php. 
Props ramiy.
Fixes #37803.
Built from https://develop.svn.wordpress.org/trunk@38345


git-svn-id: http://core.svn.wordpress.org/trunk@38286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 23:53:27 +00:00
Sergey Biryukov
d64e4beb67 I18N: Add translator comments for strings in wp-includes/functions.php. 
Props ramiy.
Fixes #37802.
Built from https://develop.svn.wordpress.org/trunk@38344


git-svn-id: http://core.svn.wordpress.org/trunk@38285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 23:48:28 +00:00
Sergey Biryukov
51e1539ab7 I18N: Add translator comments for strings in wp-includes/deprecated.php. 
Props ramiy.
Fixes #37797.
Built from https://develop.svn.wordpress.org/trunk@38343


git-svn-id: http://core.svn.wordpress.org/trunk@38284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 23:36:28 +00:00
Sergey Biryukov
eb9cc0c13e I18N: Add translator comments for strings in wp-includes/class-walker-comment.php. 
Merge two similar strings.

Props ramiy.
Fixes #37796.
Built from https://develop.svn.wordpress.org/trunk@38342


git-svn-id: http://core.svn.wordpress.org/trunk@38283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 23:33:28 +00:00
Sergey Biryukov
420b733958 I18N: Add translator comments for strings in wp-includes/author-template.php. 
Props ramiy.
Fixes #37795.
Built from https://develop.svn.wordpress.org/trunk@38341


git-svn-id: http://core.svn.wordpress.org/trunk@38282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 23:18:29 +00:00
Sergey Biryukov
ce4c0d67dc I18N: Add translator comments for strings in wp-includes/admin-bar.php. 
Props ramiy.
Fixes #37794.
Built from https://develop.svn.wordpress.org/trunk@38340


git-svn-id: http://core.svn.wordpress.org/trunk@38281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 23:05:31 +00:00
Scott Taylor
bd816e5182 Taxonomy: in get_terms(), do not assume that legacy args are being passed when the only params are top-level meta_* values. Add keys in WP_Term_Query::__construct(). 
Adds unit tests.

Props flixos90, boonebgorges.
Fixes #37568.

Built from https://develop.svn.wordpress.org/trunk@38337


git-svn-id: http://core.svn.wordpress.org/trunk@38278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 14:45:28 +00:00
Scott Taylor
af1fb6b8d2 Query: use correct description in the docblock for $number in WP_Comment_Query, WP_Network_Query, and WP_Site_Query. 
Props flixos90.
Fixes #37621.

Built from https://develop.svn.wordpress.org/trunk@38336


git-svn-id: http://core.svn.wordpress.org/trunk@38277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 14:41:29 +00:00
Scott Taylor
d6145020ae Cache: in WP_Object_Cache, $cache_misses is public, but $cache_hits is private. They should both be public, because they're useful for debugging purposes. 
Props danielbachhuber.
Fixes #37726.

Built from https://develop.svn.wordpress.org/trunk@38335


git-svn-id: http://core.svn.wordpress.org/trunk@38276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 14:38:29 +00:00
Scott Taylor
b7812bd416 AJAX: add a new function, wp_doing_ajax(), which can replace... (wait for it...) DOING_AJAX checks via the constant. 
Props Mte90, sebastian.pisula, swissspidy.
Fixes #25669.

Built from https://develop.svn.wordpress.org/trunk@38334


git-svn-id: http://core.svn.wordpress.org/trunk@38275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 14:33:30 +00:00
Scott Taylor
6f9f3b0c56 Media: remove function_exists() call for ini_get() in _load_image_to_edit_path(). 
Props dd32.
Fixes #37681.

Built from https://develop.svn.wordpress.org/trunk@38333


git-svn-id: http://core.svn.wordpress.org/trunk@38274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 14:24:30 +00:00
Sergey Biryukov
0955ea66da WP Mail: If post-by-email functionality is disabled, wp-mail.php should return a 403 Forbidden status code instead if 500 Internal Server Error. 
Props Presskopp, tomdxw.
Fixes #37572.
Built from https://develop.svn.wordpress.org/trunk@38332


git-svn-id: http://core.svn.wordpress.org/trunk@38273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 14:02:39 +00:00
Boone Gorges
6ccd3f4795 Tests: Fix incorrect variable name from [38330]. 
See #37630.
Built from https://develop.svn.wordpress.org/trunk@38331


git-svn-id: http://core.svn.wordpress.org/trunk@38272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 13:49:33 +00:00
Boone Gorges
70077ce076 Tests: Attachment create() method should match signature of other create() methods. 
Legacy argument format continues to be accepted.

Props bcole808.
See #37630.
Built from https://develop.svn.wordpress.org/trunk@38330


git-svn-id: http://core.svn.wordpress.org/trunk@38271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 13:43:41 +00:00
Sergey Biryukov
ec8f0281fa I18N: Remove unnecessary context for two strings on "Add New User" screen. 
Props ramiy.
Fixes #37784.
Built from https://develop.svn.wordpress.org/trunk@38329


git-svn-id: http://core.svn.wordpress.org/trunk@38270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 12:54:31 +00:00
Andrew Ozz
08d59c211c TinyMCE: make sure the temporary id is removed when using the default image dialog and inserting an external image. 
Props fomenkoandrey for reporting and testing.
Fixes #37467.
Built from https://develop.svn.wordpress.org/trunk@38328


git-svn-id: http://core.svn.wordpress.org/trunk@38269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 04:43:31 +00:00
Sergey Biryukov
35e3d7e37f I18N: Remove unnecessary context in wp_post_revision_title_expanded(). 
Props ramiy.
Fixes #37781.
Built from https://develop.svn.wordpress.org/trunk@38327


git-svn-id: http://core.svn.wordpress.org/trunk@38268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 01:46:31 +00:00
Sergey Biryukov
64dac53d70 I18N: Use a consistent context for "Add New" submenu strings in admin bar (Toolbar). 
Props ramiy.
Fixes #37780.
Built from https://develop.svn.wordpress.org/trunk@38326


git-svn-id: http://core.svn.wordpress.org/trunk@38267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 01:42:32 +00:00
Sergey Biryukov
92343be1f4 I18N: Allow for WordPress Plugin/Theme Directory URLs to be localized. 
Props ramiy.
Fixes #37501.
Built from https://develop.svn.wordpress.org/trunk@38325


git-svn-id: http://core.svn.wordpress.org/trunk@38266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 01:19:39 +00:00
Sergey Biryukov
372a19a435 I18N: Replace unnecessary context with translator comments in wp_post_revision_title() and wp_post_revision_title_expanded(). 
Props ramiy.
Fixes #37778.
Built from https://develop.svn.wordpress.org/trunk@38324


git-svn-id: http://core.svn.wordpress.org/trunk@38265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 00:35:28 +00:00
Sergey Biryukov
fee26cf741 I18N: Replace unnecessary context with a translator comment for %s Sites string in network_step1(). 
Props ramiy.
Fixes #37777.
Built from https://develop.svn.wordpress.org/trunk@38323


git-svn-id: http://core.svn.wordpress.org/trunk@38264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 00:17:27 +00:00
Sergey Biryukov
96bdd4737c I18N: Replace unnecessary context with a translator comment for %s KB string on Network Settings screen. 
Props ramiy.
Fixes #37496.
Built from https://develop.svn.wordpress.org/trunk@38322


git-svn-id: http://core.svn.wordpress.org/trunk@38263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 00:11:28 +00:00
Sergey Biryukov
c86199ddb2 Embeds: In get_oembed_endpoint_url(), avoid inadvertent stomping of the $format parameter passed to oembed_endpoint_url filter. 
Props danhgilmore.
Fixes #37751.
Built from https://develop.svn.wordpress.org/trunk@38321


git-svn-id: http://core.svn.wordpress.org/trunk@38262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 00:05:30 +00:00
Sergey Biryukov
44aac380f4 I18N: Add translator comments for Edit Site: %s string in network admin. 
Props ramiy.
Fixes #37776.
Built from https://develop.svn.wordpress.org/trunk@38320


git-svn-id: http://core.svn.wordpress.org/trunk@38261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 23:53:31 +00:00
Scott Taylor
b55b6a03f4 Users: after [38317], use a @property annotation, instead of a public field. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38319


git-svn-id: http://core.svn.wordpress.org/trunk@38260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 22:15:29 +00:00
Scott Taylor
1119536085 Widgets: $option_name and $alt_option_name have been used as members ever since WP_Widget became an object in 2.8, but never declared. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38318


git-svn-id: http://core.svn.wordpress.org/trunk@38259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:51:28 +00:00
Scott Taylor
7466118616 Users: $user_level has been publicly-accessed on instances of WP_User since version 2.0, but is has never been declared. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38317


git-svn-id: http://core.svn.wordpress.org/trunk@38258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:41:28 +00:00
Scott Taylor
d3312bc278 Locale: declare the $month_genitive field on WP_Locale. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38316


git-svn-id: http://core.svn.wordpress.org/trunk@38257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:33:28 +00:00
Scott Taylor
b0fa9aac6b HTTP: in WP_HTTP_Response, the @param declarations for $status and $headers were swapped. Let us correct this. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38315


git-svn-id: http://core.svn.wordpress.org/trunk@38256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:28:27 +00:00
Scott Taylor
ca70683001 Database: WP_Network, WP_Network_Query, and WP_Site_Query call wpdb::_escape(), thus requiring it to be public. It previously had no access modifier. _ at the beginning of a method, believe it or not, does not enforce visibility constraints. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38314


git-svn-id: http://core.svn.wordpress.org/trunk@38255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:10:28 +00:00
Scott Taylor
dcb0261664 Comments: in wp_handle_comment_submission(), $_wp_unfiltered_html_comment is passed as part of $comment_data, but is not used locally. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38313


git-svn-id: http://core.svn.wordpress.org/trunk@38254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:04:28 +00:00
Scott Taylor
3755823702 Taxonomy: remove unnecessary break in WP_Term::__get(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38312


git-svn-id: http://core.svn.wordpress.org/trunk@38253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:00:30 +00:00
Scott Taylor
5025f72fd3 Nav Menus: remove unnecessary variable assignment in wp_nav_menu_item_post_type_meta_box(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38311


git-svn-id: http://core.svn.wordpress.org/trunk@38252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 20:58:28 +00:00
Scott Taylor
778d794e4f REST API: remove unnecessary variable assignments in rest_handle_options_request(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38310


git-svn-id: http://core.svn.wordpress.org/trunk@38251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 20:56:28 +00:00
Scott Taylor
a017516291 Media: remove unnecessary variable assignment in gallery_shortcode(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38309


git-svn-id: http://core.svn.wordpress.org/trunk@38250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 20:53:29 +00:00
Scott Taylor
7b30193bb7 General: remove variable set needlessly in wp_check_jsonp_callback(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38308


git-svn-id: http://core.svn.wordpress.org/trunk@38249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 20:51:30 +00:00
Drew Jaynes
22adda2aa0 Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation. 
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.

Props ramiy.
See #37748.

Built from https://develop.svn.wordpress.org/trunk@38307


git-svn-id: http://core.svn.wordpress.org/trunk@38248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 18:25:31 +00:00
Sergey Biryukov
02939c03e5 Common CSS: Allow for .nav-tab-wrapper class to be used on elements other than h3 to increase flexibility for custom settings pages. 
Props ramiy, afercia.
Fixes #37257.
Built from https://develop.svn.wordpress.org/trunk@38306


git-svn-id: http://core.svn.wordpress.org/trunk@38247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 16:33:30 +00:00
Sergey Biryukov
26d7a5607b Multisite: Fix copy/paste issue in id attribute for a dismissible message on Sites screen. 
Props imath.
Fixes #37764.
Built from https://develop.svn.wordpress.org/trunk@38305


git-svn-id: http://core.svn.wordpress.org/trunk@38246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 14:22:31 +00:00
Scott Taylor
cd6d2bae92 Login: retrieve_password() does not need to import 2 globals that it does not use. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38304


git-svn-id: http://core.svn.wordpress.org/trunk@38245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 04:48:28 +00:00
Scott Taylor
d31456b615 Media: add a function, wp_get_additional_image_sizes(), that wraps the retrieval of the global $_wp_additional_image_sizes. Removes 6 global imports. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38303


git-svn-id: http://core.svn.wordpress.org/trunk@38244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 04:37:28 +00:00
Scott Taylor
b34dea908f Media: fix unit test after [38296]. 
https://en.wikipedia.org/wiki/Coupling_(computer_programming)#Disadvantages

Fixes #36246.

Built from https://develop.svn.wordpress.org/trunk@38302


git-svn-id: http://core.svn.wordpress.org/trunk@38243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 04:17:34 +00:00
Weston Ruter
ee44093211 Customize: Ensure a newly-added custom link nav menu item has the appropriate CSS class names. 
For nav menu items of the `custom` type, their `object` should also be set to `custom`, so that the `menu-item-custom` class name will be added.

Props vishalkakadiya.
Fixes #37575.

Built from https://develop.svn.wordpress.org/trunk@38301


git-svn-id: http://core.svn.wordpress.org/trunk@38242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 03:12:32 +00:00
Weston Ruter
57740f3c91 Docs: Update jsdoc in customize-nav-menus.js to remove references to Menu Customizer plugin. 
Also fix `@param` for `updateAssignedLocationsInSectionTitle`.

Props gma992, westonruter.
Fixes #37520.

Built from https://develop.svn.wordpress.org/trunk@38300


git-svn-id: http://core.svn.wordpress.org/trunk@38241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 00:56:27 +00:00
Weston Ruter
44c499329a Docs: Update outdated phpdoc for WP_Customize_Manager::validate_setting_values() to reflect changes in [37942]. 
Props dlh.
See #37247.
Fixes #37759.

Built from https://develop.svn.wordpress.org/trunk@38299


git-svn-id: http://core.svn.wordpress.org/trunk@38240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 00:41:31 +00:00
Scott Taylor
4bdd4edb77 Comments: in WP_Comment_Query::fill_descendants(), continue if there is an empty array in the loop. 
See #37416, [38297].

Built from https://develop.svn.wordpress.org/trunk@38298


git-svn-id: http://core.svn.wordpress.org/trunk@38239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-21 06:43:29 +00:00
Scott Taylor
f02f4ac762 Comments: in WP_Comment_Query::fill_descendants(), compute count() in the first for expression so that it does not run on each iteration. 
Props vishalkakadiya, deremohan.
Fixes #37416.

Built from https://develop.svn.wordpress.org/trunk@38297


git-svn-id: http://core.svn.wordpress.org/trunk@38238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-21 06:25:29 +00:00
Scott Taylor
b8bfcb0d64 Media: use wp_get_attachment_metadata() instead of get_post_meta() where appropriate. 
Adds unit test.

Props JorritSchippers.
Fixes #36246.

Built from https://develop.svn.wordpress.org/trunk@38296


git-svn-id: http://core.svn.wordpress.org/trunk@38237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-21 06:15:30 +00:00
Scott Taylor
76540c6010 Media: wp_get_attachment_link() fails to output text for non-images if the attachment post doesn't have a title and $text (argument #5) was not passed to the func. In this case, use the filename. 
Props Jonnyauk, henry.wright.
Fixes #37343.

Built from https://develop.svn.wordpress.org/trunk@38295


git-svn-id: http://core.svn.wordpress.org/trunk@38236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 23:45:28 +00:00
Scott Taylor
7ac88c02fa Media: when calling pathinfo(), also pass a PATHINFO_* constant to avoid array notices for unset keys. 
Props JaworskiMatt.
Fixes #37608.

Built from https://develop.svn.wordpress.org/trunk@38294


git-svn-id: http://core.svn.wordpress.org/trunk@38235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 23:36:28 +00:00
Scott Taylor
d73964aab6 Media: Add some docs to media-gallery.js RIP. 
Props jipmoors.
Fixes #37717.

Built from https://develop.svn.wordpress.org/trunk@38293


git-svn-id: http://core.svn.wordpress.org/trunk@38234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 22:59:29 +00:00
Boone Gorges
344c88d39f Allow attachment taxonomies to be fetched as objects. 
By adding the `$output` parameter to `get_attachment_taxonomies()`, the
function signature matches that of `get_object_taxonomies()`. The change
also allows for more consistent behavior when passing `output=objects`
to `get_object_taxonomies()` for the 'attachment' object type, since
the `$output` parameter is now passed through the function stack.

Props codemovement.pk.
See #37368.
Built from https://develop.svn.wordpress.org/trunk@38292


git-svn-id: http://core.svn.wordpress.org/trunk@38233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 17:35:31 +00:00
Boone Gorges
188c568204 Introduce tests for get_attachment_taxonomies(). 
See #37368.
Built from https://develop.svn.wordpress.org/trunk@38291


git-svn-id: http://core.svn.wordpress.org/trunk@38232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 17:25:30 +00:00
Boone Gorges
ece461fbc3 Introduce tests for get_object_taxonomies(). 
See #37368.
Built from https://develop.svn.wordpress.org/trunk@38290


git-svn-id: http://core.svn.wordpress.org/trunk@38231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 17:01:31 +00:00
Sergey Biryukov
597c067b67 Docs: Correct usage examples for wpdb::prepare(), which should not be called statically. 
Props TJNowell.
Fixes #37744.
Built from https://develop.svn.wordpress.org/trunk@38289


git-svn-id: http://core.svn.wordpress.org/trunk@38230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 13:17:30 +00:00
Boone Gorges
d30a6a988a Query: Non-scalar and negative values for 'p' should always result in a 404. 
Previously, the 'p' query var was being run through `absint()`, which
caused unexpected results.

Props Akeif, kouratoras.
Fixes #33372.
Built from https://develop.svn.wordpress.org/trunk@38288


git-svn-id: http://core.svn.wordpress.org/trunk@38229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 02:32:30 +00:00
Boone Gorges
54fe38c7cc Mail: Don't set Sender field when setting From. 
[38058] changed `wp_mail()` so that it used PHPMailer's `setFrom()`
method rather than setting the From and FromName headers directly. See
behavior of setting the `Sender` field. This causes `mail` to be
called with the `-f` flag, which causes outgoing email to fail on some
server environments.

Props Clorith, iandunn, DrewAPicture.
Fixes #37736.
Built from https://develop.svn.wordpress.org/trunk@38286


git-svn-id: http://core.svn.wordpress.org/trunk@38227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 02:17:38 +00:00
Boone Gorges
53ef9de125 Tests: Move some utility classes to their own files. 
Props Frank Klein.
Fixes #37523.

Built from https://develop.svn.wordpress.org/trunk@38285


git-svn-id: http://core.svn.wordpress.org/trunk@38226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-19 15:45:29 +00:00
Sergey Biryukov
83bed74a2f Docs: Fix typo in load_plugin_textdomain() parameter description. 
Props tivnet.
See #37318.
Built from https://develop.svn.wordpress.org/trunk@38284


git-svn-id: http://core.svn.wordpress.org/trunk@38225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-19 14:29:30 +00:00
Boone Gorges
0da0aae4b0 Add wordpress-importer tests demonstrating slashed data behavior. 
See #21007.
Built from https://develop.svn.wordpress.org/trunk@38283


git-svn-id: http://core.svn.wordpress.org/trunk@38224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-19 13:27:30 +00:00
Aaron Jorbin
a138374ec8 Bootstrap/Load: Include Plugin API via require_once 
Currently, auto-prepended files need to directly modify the globals in order to add filters and actions. This is a bad idea. Globals are bad. You should never directly interact with the Plugin globals.

Fixes #37707.


Built from https://develop.svn.wordpress.org/trunk@38282


git-svn-id: http://core.svn.wordpress.org/trunk@38223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-19 04:10:30 +00:00
Aaron Jorbin
18f14ad752 Fix jshint of Gruntfile.js 
Introduced in [38276]

See #37720.

Built from https://develop.svn.wordpress.org/trunk@38281


git-svn-id: http://core.svn.wordpress.org/trunk@38222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 20:05:30 +00:00
Scott Taylor
3357ca23e6 Query: use composition for $db in WP_Date_Query, removes need to import global $wpdb in multiple methods. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38280


git-svn-id: http://core.svn.wordpress.org/trunk@38221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 19:48:34 +00:00
Scott Taylor
9b393cea42 Query: use composition for $db in WP_Query, removes need to import global $wpdb in multiple methods. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38279


git-svn-id: http://core.svn.wordpress.org/trunk@38220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 19:39:29 +00:00
Scott Taylor
c606046d73 Unit Tests: skip checking the value in Tests_User:test_user_properties for db. Casting to array is not the most elegant thing here, and various versions of PHP key protected/private fields differently when objects are cast. 
See [38275], #37699.

Built from https://develop.svn.wordpress.org/trunk@38278


git-svn-id: http://core.svn.wordpress.org/trunk@38219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 19:38:29 +00:00
Boone Gorges
2b7d7f4833 In is_object_in_term(), return error object rather than caching it. 
This change prevents an error object from being stored in the cache,
and prevents notices from being thrown when plucking term IDs to put
into the relationship cache.

See #32044, #36814.

Props rpayne7264.
Fixes #37721.
Built from https://develop.svn.wordpress.org/trunk@38277


git-svn-id: http://core.svn.wordpress.org/trunk@38218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 19:15:32 +00:00
Aaron Jorbin
6836de32d1 External Libraries: Update Minified version of jquery.masonry.js 
WordPress maintains the minified version of jquery.masonry.js since there is no official build, however it has been excluded from grunt's minification process. This adds a minification task to grunt, adds it to the precommit hook for JS, minifies the file, and bumps the version on jquery.masonry.min.js. The change to the non minified version was introduced in [38261].

Fixes #37720.  See #37666.

Built from https://develop.svn.wordpress.org/trunk@38276


git-svn-id: http://core.svn.wordpress.org/trunk@38217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 18:55:30 +00:00
Scott Taylor
e7ffad7fac Query: add a protected field, $db, (composition, as it were) to WP_*_Query classes to hold the value for the database abstraction, instead of importing the global $wpdb into every method that uses it. Reduces the number of global imports by 32. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38275


git-svn-id: http://core.svn.wordpress.org/trunk@38216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 18:21:31 +00:00
Dion Hulse
1dd3ed4bd5 Requests: Update to Requests master (fb5b517) which corrects a logic inversion in the cURL transport checks. 
Previously if a host had only disabled one of `curl_init()` or `curl_exec()` it wouldn't get detected correctly by Requests, which caused cURL warnings for users on an affecte dhost.

Fixes #37700 for trunk.

Built from https://develop.svn.wordpress.org/trunk@38274


git-svn-id: http://core.svn.wordpress.org/trunk@38215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 03:48:31 +00:00
Aaron Jorbin
2bd32687b3 Build/Test Tools: Ensure PHP 7.1 is tested on Travis. 
PHP 7.1 is the next version of PHP and WordPress should support it with the first major version after 7.1 launches. This will facilitate testing. Failures on 7.1 won't necessitate builds failing while 7.1 is still in beta.

Fixes #37625.


Built from https://develop.svn.wordpress.org/trunk@38273


git-svn-id: http://core.svn.wordpress.org/trunk@38214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-17 20:47:30 +00:00
John Blackbourn
594b88661a Permalinks: Correct the documentation for the get_sample_permalink filter, and improve the documentation for the get_sample_permalink() function. 
Props sebastian.pisula for the original patch
Fixes #37682

Built from https://develop.svn.wordpress.org/trunk@38272


git-svn-id: http://core.svn.wordpress.org/trunk@38213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-17 18:30:30 +00:00
Dominik Schilling
14cbd0e730 About Page: Add release video and move images to CDN. 
Props jerrysarcastic, rosso99, petya, hugobaeta, jerrysarcastic.
See #37246.
Built from https://develop.svn.wordpress.org/trunk@38267


git-svn-id: http://core.svn.wordpress.org/trunk@38208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-16 17:58:30 +00:00
Dominik Schilling
75d4429926 Post Thumbnails: Restore thumbnail support for media files. 
* Allow to add/remove a featured image to `attachment:audio` and `attachment:video` post types, see [27657].
* Change conditionals to check for theme OR post type support.
* Add tests for #12922.

Broken in [37658].

Props flixos90, joemcgill, DrewAPicture, wonderboymusic.
See #12922.
Fixes #37658.
Built from https://develop.svn.wordpress.org/trunk@38263


git-svn-id: http://core.svn.wordpress.org/trunk@38204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-15 19:16:31 +00:00
Aaron Jorbin
9c526c8a24 External Libraries: Update Masonry shim to prevent error using isAnimated option 
The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: https://github.com/desandro/masonry-v2-3-shim/pull/1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.


Built from https://develop.svn.wordpress.org/trunk@38261


git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-15 18:20:30 +00:00
Dominik Schilling
2ccd9b46dd About Page: Enhance responsive images. 
* Add `srcset` and `sizes` to the mobile image for streamlined updates.
* Modify the order of image candidate strings in each `srcset` to address a bug in iOS8 where the first candidate will always be selected when using `w` descriptors, see #35030.

Props joemcgill.
Fixes #37246.
Built from https://develop.svn.wordpress.org/trunk@38257


git-svn-id: http://core.svn.wordpress.org/trunk@38198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-13 19:28:29 +00:00
Dominik Schilling
25338b6f02 Script Loader: Fix protocol-relative URLs for the preconnect relation type. 
`wp_resource_hints()` parses the URL for the `preconnect` and `dns-prefetch` relation types to ensure correct values for both. While protocol-relative URLs are supported for `dns-prefetch`, the double slash was lost for `preconnect`.

Props swissspidy, peterwilsoncc.
Props azaozz for review.
Fixes #37652.
Built from https://develop.svn.wordpress.org/trunk@38255


git-svn-id: http://core.svn.wordpress.org/trunk@38196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-13 18:35:30 +00:00
Drew Jaynes
1691196110 Docs: Add a period missed in an argument description in [38253] for #36338. 
Built from https://develop.svn.wordpress.org/trunk@38254


git-svn-id: http://core.svn.wordpress.org/trunk@38195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-13 17:44:28 +00:00
Drew Jaynes
51810b926a Docs: Add documentation for all arguments accepted by export_wp(). 
Props theMikeD for the initial patch.
Fixes #36338.

Built from https://develop.svn.wordpress.org/trunk@38253


git-svn-id: http://core.svn.wordpress.org/trunk@38194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-13 17:43:28 +00:00
Aaron Jorbin
7e14c27bb9 Bootstrap/Load: Revert Plugin Global restoration around advance-cache.php. 
First added in [37588] and later modified in [38224], the idea was to ensure that filters/actions added before `advance-cache.php` would not disappear if `advance-cache.php` overloaded the filters/actions with code such as `$wp_filter = array()`. This is an edge case and one that there is no documented case of existing.

This restores the behavior from WordPress 4.5 and before. It is strongly encouraged that developers using `advance-cache.php` to use the Plugins API that is available before the loading of `advance-cache.php` rather than directly interacting with any of the globals.

Props azaozz, jorbin, dd32 for review, pento for review, westi for investigation, ipstenu for research.
See #36819.


Built from https://develop.svn.wordpress.org/trunk@38251


git-svn-id: http://core.svn.wordpress.org/trunk@38192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-13 16:00:33 +00:00
Sergey Biryukov
f25445a378 Users: Merge two duplicate strings introduced in [37940]. 
Props dimadin.
Fixes #37644.
Built from https://develop.svn.wordpress.org/trunk@38250


git-svn-id: http://core.svn.wordpress.org/trunk@38191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-12 14:12:32 +00:00
Dominik Schilling
3a0771b986 About Page: Fix punctuation errors in two strings. 
See #37246.
Built from https://develop.svn.wordpress.org/trunk@38248


git-svn-id: http://core.svn.wordpress.org/trunk@38189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-11 20:51:46 +00:00
Dominik Schilling
eb02dac3e7 About Page: Third pass for 4.6. 
* Adjust strings.
* Make strings translatable.
* Improve margin between copy and images.

Props Ipstenu, SergeyBiryukov, Presskopp, jeremyfelt, afragen, helen, Clorith, macmanx, DrewAPicture, voldemortensen, jorbin, MattyRob, ocean90.
See #37246.
Built from https://develop.svn.wordpress.org/trunk@38244


git-svn-id: http://core.svn.wordpress.org/trunk@38185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-10 23:33:30 +00:00
Dominik Schilling
0d2106e2eb Upgrader: Rename class-wp-automatic-upgrader.php to class-wp-automatic-updater.php. 
The class is named `WP_Automatic_Updater` not `WP_Automatic_Upgrader` like all the other upgrader classes. 

Introduced in [37409].
See #37628.
Built from https://develop.svn.wordpress.org/trunk@38242


git-svn-id: http://core.svn.wordpress.org/trunk@38183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-10 19:51:29 +00:00
Andrew Ozz
0d4320fcbc Update/Install error messages: do not escape from the template, escape the error message string before inserting it. 
Props swissspidy, ocean90.
Fixes #37623 for trunk.
Built from https://develop.svn.wordpress.org/trunk@38240


git-svn-id: http://core.svn.wordpress.org/trunk@38181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-10 19:03:31 +00:00
Sergey Biryukov
df97f83cb6 Docs: Replace some more HTTP links with HTTPS. 
Props johnpgreen.
Fixes #37622. See #36993.
Built from https://develop.svn.wordpress.org/trunk@38239


git-svn-id: http://core.svn.wordpress.org/trunk@38180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-10 16:10:31 +00:00
Drew Jaynes
7643afd97c Update/Install: Provide basic back-compat styling for the .update-message CSS class in the plugins list table. 
This change restores only the margin and padding styles for the `.update-message` class when used by plugins in the context of adding arbitrary rows to the list table. The inline-update colors and icon styles were not restored, expressly with a wide variety of plugin use-cases in mind.

Props ovann86, rahulsprajapati, ocean90, DrewAPicture.
Props helen for review.
See #37504.

Built from https://develop.svn.wordpress.org/trunk@38237


git-svn-id: http://core.svn.wordpress.org/trunk@38178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 22:45:40 +00:00
Dominik Schilling
771fc167b6 Media: In _wp_handle_upload() use call_user_func_array() to call the upload error handler. 
The default error handler `wp_handle_upload_error()` expects a reference for the first parameter but `call_user_func()` doesn't pass parameters by reference. The current code didn't produce any issues until now. PHP 7.0.9 (and PHP 7.1) is now stricter and prevents calling the error handler with a warning:
> PHP Warning:  Parameter 1 to wp_handle_upload_error() expected to be a reference, value given.

To restore the error handler `_wp_handle_upload()` now uses `call_user_func_array()`.

Props jbrinley.
Props jorbin for review.
Fixes #37570.
Built from https://develop.svn.wordpress.org/trunk@38235


git-svn-id: http://core.svn.wordpress.org/trunk@38176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 21:54:30 +00:00
Dominik Schilling
5d9f94693e About Page: Update video for streamlined updates and add srcset/sizes attributes for the static images. 
Props hugobaeta, joemcgill.
See #37246.
Built from https://develop.svn.wordpress.org/trunk@38234


git-svn-id: http://core.svn.wordpress.org/trunk@38175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 19:26:30 +00:00
Jeremy Felt
eaffe99260 Multisite: Remove unnecessary reference parameters. 
There is no advantage to passing parameters by reference to `get_site()`, `get_network()`, and `update_site_cache()`.

Props flixos90, ocean90 for review.
See #37615.

Built from https://develop.svn.wordpress.org/trunk@38232


git-svn-id: http://core.svn.wordpress.org/trunk@38173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 18:12:31 +00:00
Sergey Biryukov
822db9ce1d Embeds: Fix copy/paste error in WP_oEmbed::_add_provider_early() description. 
Props ivantedja.
Fixes #37602.
Built from https://develop.svn.wordpress.org/trunk@38230


git-svn-id: http://core.svn.wordpress.org/trunk@38171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 14:10:30 +00:00
Gary Pendergast
210e23a63d Multisite: Improve performance of the upgrade page on large networks. 
The query to select the next 5 blogs to upgrade was ordered by `registered`, which isn't indexed. This causes the query to table scan, which will be slow on networks with many blogs.

The query only needs to be ordered by something that won't change, so ordering by `blog_id` is a good replacement. `blog_id` is indexed, and it's the only column being returned, so MySQL is able to optimize for a fast index read.

Props fliespl.
Fixes #37612.


Built from https://develop.svn.wordpress.org/trunk@38229


git-svn-id: http://core.svn.wordpress.org/trunk@38170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 11:39:36 +00:00
Dominik Schilling
cb131d8d5f Updates: Add visual feedback when deleting themes/plugins. 
This corrects the selector for the delete link in `wp.updates.deletePlugin()` so the text can be changed to 'Deleting…'. `wp.updates.deleteTheme()` already worked on wp-admin/themes.php but not on wp-admin/network/themes.php because the network screen is similar to the plugins list table, this is now fixed too.
The `credential-modal-cancel` handler has been updated to support canceled delete jobs.

Props swissspidy.
Props jorbin for review.
Fixes #37603.
Built from https://develop.svn.wordpress.org/trunk@38227


git-svn-id: http://core.svn.wordpress.org/trunk@38168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 10:39:32 +00:00
Dominik Schilling
9970c6ca5a Dashboard: Don't escape widget titles in screen reader text. 
Introduced in [37972]. The title for the Quick Draft widget contains HTML to provide a JS/no-JS version.

Props SergeyBiryukov for review.
See #37595.
Fixes #37594.
Built from https://develop.svn.wordpress.org/trunk@38225


git-svn-id: http://core.svn.wordpress.org/trunk@38166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 09:07:30 +00:00
Gary Pendergast
4ac3feaa64 Boostrap/Load: Improve forward compatiblity of plugin global backup methods. 
[37588] added methods to backup the plugin globals, for ensuring that advanced cache drop-ins don't overwrite hooks that've been added earlier in the load process.

The method for restoring the plugin globals wasn't compatible with the implementation of `WP_Hook` in #17817. `WP_Hook` implements `ArrayAccess`, so `_restore_plugin_globals()` was treating it as an array, and inadvertantly overwriting the `WP_Hook` object with a plain array.

To avoid having to re-write this code as part of #17817, we now use `add_filter()` to restore any hooks that were added by cache drop-ins, which `WP_Hook` correctly supports.

Props pento, jorbin.
See #36819.


Built from https://develop.svn.wordpress.org/trunk@38223


git-svn-id: http://core.svn.wordpress.org/trunk@38164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 01:45:29 +00:00
Aaron Jorbin
b3b32f22a1 Updates: Improve experience for Bulk Actions when FTP is dismissed. 
Before this change, when a bulk update was canceled due dismissing the FTP credentials modal, part of the actions didn't get canceled.  This meant the "There is a new version of…” notices become blank and the updates you had checked became unchecked.  Now, the notices remain and you are essentially returned to the screen you had before. Strings are also updated to improve ARIA usage.

Fixes #37563.
Props ocean90, swissspidy, obenland, afercia.


Built from https://develop.svn.wordpress.org/trunk@38221


git-svn-id: http://core.svn.wordpress.org/trunk@38162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-09 01:14:28 +00:00
Aaron Jorbin
b86f7a832b Updates: Standardize JS Custom Event Names 
Custom JS events are triggered on the document in order for plugins to have something to hook into.  The standard began in #31819 is dash separated and begins with `wp` to signify the namespace, followed by the subject of our action ( "theme", "plugin", etc.) followed by the action and an optional indicator of status ( "install-success", "deleting" ).

This brings some of the theme hooks in line with the standard.  As of now, all plugin actions in `src/wp-admin/js/updates.js` have an equal corresponding theme action.

Fixes #37598.
See #37512, #37216, #31819.
Props olarmarius, ocean90.



Built from https://develop.svn.wordpress.org/trunk@38218


git-svn-id: http://core.svn.wordpress.org/trunk@38159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-08 22:49:28 +00:00
Jeremy Felt
b45adc74df Multisite: Use get_current_blog_id() in get_site() for current site. 
The global `$current_blog` is not switched in `switch_to_blog()` and can
not be used to properly retrieve current switched site information.

See #37607.

Built from https://develop.svn.wordpress.org/trunk@38217


git-svn-id: http://core.svn.wordpress.org/trunk@38158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-08 22:33:28 +00:00
Boone Gorges
0ddbc2c99f Improve category check in redirect_canonical() when permastruct contains category slug. 
[37262] changed a check in `redirect_canonical()` so that it checked
categories in the object cache rather than querying the database. However,
the check was based on the identity of `WP_Term` objects, which in
certain cases can be augmented by the main WP query routine, causing
failures of the `in_array()` check. This caused unnecessary redirects
for URLs where `is_single()` is true, but the URL is different from the
post permalink, such as the `embed` endpoint.

`has_term()` also checks the cache, but does not sufer from this bug.

Props cmillerdev.
Fixes #36602.
Built from https://develop.svn.wordpress.org/trunk@38216


git-svn-id: http://core.svn.wordpress.org/trunk@38157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-08 18:49:28 +00:00
Dominik Schilling
e9fb6e42be About Page: Use a better version of the mp4 video. 
The previous version had the wrong colors. Also remove ogv from the list, it has the wrong colors too and all current browsers support either the mp4 or webm format.

See #37246.
Built from https://develop.svn.wordpress.org/trunk@38215


git-svn-id: http://core.svn.wordpress.org/trunk@38156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-08 16:02:32 +00:00
Dominik Schilling
55c3fa0cb0 About Page: Second pass for 4.6. 
* Update images for native fonts and editor features.
* Add video animation with image fallback for update feature. 
* Rename "Simplified Disaster Recovery" to "Content Recovery".
* Fix broken layout on credits and freedoms pages.

Props hugobaeta, SergeyBiryukov, ocean90.
Fixes #37590.
See #37246.
Built from https://develop.svn.wordpress.org/trunk@38213


git-svn-id: http://core.svn.wordpress.org/trunk@38154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-07 12:48:30 +00:00
Scott Taylor
0598f0bc4b Taxononmy: set WP_Term_Query::terms when returning terms from the cache in WP_Term_Query::get_terms(). 
See #37591.

Built from https://develop.svn.wordpress.org/trunk@38212


git-svn-id: http://core.svn.wordpress.org/trunk@38153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-07 04:48:29 +00:00
Scott Taylor
e78197c461 Taxononmy: add unit that shows that WP_Term_Query is broken when the query is read from the cache. 
See #37591.

Built from https://develop.svn.wordpress.org/trunk@38211


git-svn-id: http://core.svn.wordpress.org/trunk@38152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-07 04:43:30 +00:00
Dominik Schilling
1cef5f60f9 Update/Install: Remove the .notice-error class before adding classes for the update process. 
Prevents displaying an update message with error styling.

Props obenland.
Props SergeyBiryukov for review.
Fixes #37550.
Built from https://develop.svn.wordpress.org/trunk@38209


git-svn-id: http://core.svn.wordpress.org/trunk@38150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-05 22:57:29 +00:00
Dominik Schilling
427f4b625d Customize: Increase the target size of the 'Edit Menu' button. 
Props celloexpressions.
Props afercia, helen for review.
Fixes #36795.
Built from https://develop.svn.wordpress.org/trunk@38207


git-svn-id: http://core.svn.wordpress.org/trunk@38148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-05 22:38:29 +00:00
Dominik Schilling
572a9cb488 Update/Install: Replace "error" and "-1" failure messages with a more meaningful one. 
* "-1" is an invalid nonce error, show 'An error has occurred. Please reload the page and try again.'.
* "error" means that the connection to the server was lost, show 'Connection lost or the server is busy. Please try again later.'.
* Escape the message in `wp-updates-admin-notice` because the response may include HTML.
* Remove HTML tags in `wp.updates.isValidResponse()` to make PHP's error messages more readable.

Props azaozz for review.
Fixes #37583.
Built from https://develop.svn.wordpress.org/trunk@38205


git-svn-id: http://core.svn.wordpress.org/trunk@38146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-05 19:28:30 +00:00
Andrew Nacin
4ff8257cb4 MediaElement: Remove translated string from a plugin WP doesn't bundle. 
fixes #37394.

Built from https://develop.svn.wordpress.org/trunk@38203


git-svn-id: http://core.svn.wordpress.org/trunk@38144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-05 04:44:35 +00:00
John Blackbourn
ab052361a3 Docs: Correct and clarify various @since docs. 
Fixes #37562

Built from https://develop.svn.wordpress.org/trunk@38201


git-svn-id: http://core.svn.wordpress.org/trunk@38142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-04 22:54:31 +00:00
Dominik Schilling
58d772a02f Upgrade/Install: Make some install/update failures more verbose. 
An upgrader class is used in conjunction with an upgrader skin class. A skin class handles the logging for an upgrade and informs a user about the progress and failures.
The current Ajax install/update handlers are using the `Automatic_Upgrader_Skin` class because during an Ajax request no output is intended. The difference between Ajax updates and automatic updates is that you will see the full log (usually by email) while Ajax updates focus only on success or failure. For that `Automatic_Upgrader_Skin` has one disadvantage: It doesn't provide a way to retrieve failure messages which were passed through `WP_Upgrader_Skin::error()` by the upgrader.
To solve this issue a new skin `WP_Ajax_Upgrader_Skin` has been introduced. The skin extends `Automatic_Upgrader_Skin` and overrides the `error()` and `feedback()` methods to intercept all errors, which can be a `WP_Error` object or a string.

This updates all four Ajax handler for installing/updating themes/plugins to use the new skin. They now also check the skin for any intercepted errors and pass them on to the user.

Props flixos90, obenland, ocean90.
Props DrewAPicture, pento for review.
Fixes #37531.
Built from https://develop.svn.wordpress.org/trunk@38199


git-svn-id: http://core.svn.wordpress.org/trunk@38140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-04 22:18:30 +00:00
John Blackbourn
dc3d64ed9c I18N: Correct the documented return types of get_translations_for_domain(). 
See #32246

Built from https://develop.svn.wordpress.org/trunk@38198


git-svn-id: http://core.svn.wordpress.org/trunk@38139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-04 22:13:29 +00:00
Dominik Schilling
c9c2377b1d Plugins: Also update aria-labels when a plugin update fails. 
Previously the label was stuck at "Updating…".

Props afercia, ocean90.
Props DrewAPicture for review.
Fixes #37556.
Built from https://develop.svn.wordpress.org/trunk@38196


git-svn-id: http://core.svn.wordpress.org/trunk@38137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-04 21:06:38 +00:00
Dominik Schilling
ea6e749c71 Emoji: Update the Twemoji loader to include the rainbow flag. 
[38179] added support for the rainbow flag to core, but platform compatibility is a bit strange, because the flag was defined out of sync with the usual Unicode release cycle. For example Android N supports all Unicode 9.0 emoji, but doesn't support the rainbow flag thus the rainbow flag isn't rendered.
The Twemoji loader already has an exception for flags - it'll load if the browser supports everything but flags, and then only replace flag emoji, leaving everything else as native rendering. To provide a seamless experience for all flags the loader now uses the rainbow flag to test flag support.

Props pento.
See #37543.
Fixes #37566.
Built from https://develop.svn.wordpress.org/trunk@38194


git-svn-id: http://core.svn.wordpress.org/trunk@38135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-04 20:51:31 +00:00
Sergey Biryukov
6182c9f805 Formatting: In remove_accents(), correct replacements for: 
* Latin small letter n preceded by apostrophe
* Latin capital letter Eng
* Latin small letter Eng

Props gitlost.
Fixes #37564.
Built from https://develop.svn.wordpress.org/trunk@38193


git-svn-id: http://core.svn.wordpress.org/trunk@38134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-04 13:56:29 +00:00
Dion Hulse
2d860ae3d6 Requests: Merge handling for custom HTTP methods. 
This merges the latest changes to Requests from upstream to add support for custom HTTP methods.
See 1b5ffd8501

Props Ipstenu, ocean90.
Fixes #37503 for trunk.

Built from https://develop.svn.wordpress.org/trunk@38191


git-svn-id: http://core.svn.wordpress.org/trunk@38132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-04 07:14:31 +00:00
Dominik Schilling
7ff940d217 Customize: Make the menu edit button look like a link. 
The button was introduced in [37901] to allow users switching to the selected menu for further edits. A link makes it more clear that the user is taken away from the current view.
This also adds an aria label and makes the button label more verbose, 'Edit Menu'.

Props afercia.
Props helen for review.
Fixes #36795.
Built from https://develop.svn.wordpress.org/trunk@38189


git-svn-id: http://core.svn.wordpress.org/trunk@38130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-03 22:45:30 +00:00
Aaron Jorbin
4d71eb8423 Updates: Clean up debug statements. 
Removing some `console.error` calls leftover from development and wrapping the `console.log` call in a check to ensure `console.log` exists.

Fixes #37514.
Props ocean90, obenland


Built from https://develop.svn.wordpress.org/trunk@38186


git-svn-id: http://core.svn.wordpress.org/trunk@38127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-03 22:28:39 +00:00
Aaron Jorbin
94ac1499cf Updates: Improve bulk update failure notice 
When doing a bulk update, if there are failures the user needs to know about that. This makes it clearer that you can click on the notification to see more details, especially for screen reader users.

Fixes #37510.
Props  juhise, Ankit K Gupta, afercia, jorbin, ocean90. 


Built from https://develop.svn.wordpress.org/trunk@38185


git-svn-id: http://core.svn.wordpress.org/trunk@38126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-03 22:24:35 +00:00
Dominik Schilling
ada44f2e13 About Page: First pass for 4.6 with strings (not yet translatable) and images (not CDN). 
Props macmanx, jorbin, hugobaeta, DrewAPicture, peterwilsoncc, iamfriendly, rahulsprajapati, vishalkakadiya, petya, celloexpressions, westonruter, mikeschroder, zetaraffix, mapk, boonebgorges, adamsilverstein, jeremyfelt, rosso99, karmatosed, swissspidy, michael-arestad, ramiy, ocean90.
See #37246.
Built from https://develop.svn.wordpress.org/trunk@38183


git-svn-id: http://core.svn.wordpress.org/trunk@38124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-03 19:54:48 +00:00
Boone Gorges
a2f34d9ee0 In WP_Term_Query, accept a string value for taxonomy. 
Props endocreative.
Props ocean90 for review.
Fixes #37545.
Built from https://develop.svn.wordpress.org/trunk@38181


git-svn-id: http://core.svn.wordpress.org/trunk@38122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-03 13:51:30 +00:00
Gary Pendergast
c6b0f5438a Emoji: Add support for the Rainbow and Pirate flag emoji. 
Twemoji recently added images for the Rainbow and Pirate flags, and the latest iOS 10 beta added support for the Rainbow flag. Never let it be said that WordPress is at anything less than the cutting edge of emoji research and development.

Props ocean90 for the code review.

See #37543.


Built from https://develop.svn.wordpress.org/trunk@38179


git-svn-id: http://core.svn.wordpress.org/trunk@38120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-03 00:11:32 +00:00
Helen Hou-Sandí
c914411a30 Trunk is now 4.7-alpha. 
Built from https://develop.svn.wordpress.org/trunk@38178


git-svn-id: http://core.svn.wordpress.org/trunk@38119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-02 13:45:30 +00:00
Aaron Jorbin
472e0d1978 Upgrade/Install: Trigger additional JS events in shiny updates 
Events for updating exist, but they lack context. This adds args so that plugins can detec t what plugin/theme is being installed.  Additionally, events for bulk actions, deleting and that and install is starting didn't exist, so this adds them.

Fixes #37512.
Props DavidAnderson, and ocean90, swissspidy for review.


Built from https://develop.svn.wordpress.org/trunk@38175


git-svn-id: http://core.svn.wordpress.org/trunk@38116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-31 18:57:28 +00:00
Dominik Schilling
672cf2766e Script Loader: Ignore deregistered dependencies in wp_dependencies_unique_hosts(). 
Prevents a PHP warning when a handle of a deregistered dependency is still in the queue.

Fixes #37502.
Built from https://develop.svn.wordpress.org/trunk@38174


git-svn-id: http://core.svn.wordpress.org/trunk@38115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-31 18:25:28 +00:00
Dominik Schilling
e64c675fc5 HTTP API: Set $use_authentication property of Requests_Proxy_HTTP to true when proxy authentication is required. 
Props francescobagnoli for initial patch.
Fixes #37494.
Built from https://develop.svn.wordpress.org/trunk@38173


git-svn-id: http://core.svn.wordpress.org/trunk@38114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-31 18:20:29 +00:00
Dominik Schilling
1abd5f0be7 Plugins: Use install_plugins_upload action to print the upload form. 
Since [37221] the upload form is added to every plugin install screen via `install_plugins_upload()`. Previously the form was added through the `install_plugins_upload` (alias of `install_plugins_$tab`) action which allowed plugin authors to replace the form. This restores the previous behaviour.

* Add the form only to non-upload plugin install screens.
* Replace `install_plugins_upload()` with the `install_plugins_upload` and `install_plugins_pre_upload` actions.
* Remove `$upload_tab_class` and add a CSS class for the current tab to `.wrap`
* Adjust CSS selectors and toggle the whole container to support upload without an `upload-plugin` class.

Props DavidAnderson, ocean90.
Fixes #37495.
Built from https://develop.svn.wordpress.org/trunk@38172


git-svn-id: http://core.svn.wordpress.org/trunk@38113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-31 18:11:29 +00:00
Dominik Schilling
f6e5d8db6c Bundled Themes: Bump versions and update theme tags. 
* Twenty Ten 2.2
* Twenty Eleven 2.5
* Twenty Twelve 2.1
* Twenty Thirteen 2.0
* Twenty Fourteen 1.8
* Twenty Fifteen 1.6

Props davidakennedy.
Fixes #37426.
Built from https://develop.svn.wordpress.org/trunk@38171


git-svn-id: http://core.svn.wordpress.org/trunk@38112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-31 16:37:32 +00:00
Dominik Schilling
ba12f4e95f Post WordPress 4.6 RC 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@38170


git-svn-id: http://core.svn.wordpress.org/trunk@38111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 19:02:30 +00:00
Dominik Schilling
da0661adc1 WordPress 4.6 RC 1. 
Built from https://develop.svn.wordpress.org/trunk@38169


git-svn-id: http://core.svn.wordpress.org/trunk@38110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 18:30:21 +00:00
Dominik Schilling
3105764efd Plugins: Move capability checks further up in wp_ajax_update_plugin() and wp_ajax_delete_plugin(). 
Add tests for both Ajax handlers.

Props Yorick Koster, swissspidy.
Fixes #37490.
Built from https://develop.svn.wordpress.org/trunk@38168


git-svn-id: http://core.svn.wordpress.org/trunk@38109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 17:44:41 +00:00
Dominik Schilling
e4abc1ecbf Filesystem API: Output buffering for request_filesystem_credentials() should wrap the function directly. 
Previously `ob_end_clean()` was only called when the previous condition was successful which led to unexpected results when another output buffering was involved, like PHPUnit's.

Fixes #37488.
Built from https://develop.svn.wordpress.org/trunk@38167


git-svn-id: http://core.svn.wordpress.org/trunk@38108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 17:11:56 +00:00
Weston Ruter
9ee1823d91 Customize: Prevent customize-preview-widgets JS errors in preview if a sidebar is registered with empty before_widget/after_widget params. 
Selective refresh will not be available for widgets when they lack these params, so previewing will fallback to full page refreshes. Sidebars registered as such should be rare so this accounts for an edge case.

Fixes #37478.

Built from https://develop.svn.wordpress.org/trunk@38166


git-svn-id: http://core.svn.wordpress.org/trunk@38107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 16:27:30 +00:00
Dominik Schilling
7e49f103be HTTP API: All non-GET/HEAD requests should put the arguments in the form body. 
Requests defaults to _GET/query for HEAD/GET/DELETE and _POST/body for POST/PUT/OPTIONS/PATCH. For backward compatibility `WP_HTTP` needs to force `data_format` to 'body' for all non-GET/HEAD requests.

Props dd32.
Fixes #37456.
Built from https://develop.svn.wordpress.org/trunk@38165


git-svn-id: http://core.svn.wordpress.org/trunk@38106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 15:52:28 +00:00
Dominik Schilling
b2607f8d78 HTTP API: Normalize cookies before passing them to Requests. 
Requests has its own cookie object in form of `Requests_Cookie`. Therefore we have to convert `WP_Http_Cookie` objects to `Requests_Cookie`.
This introduces `WP_Http_Cookie::get_attributes()` to retrieve cookie attributes of a `WP_Http_Cookie` object and `WP_Http::normalize_cookies()` to convert the cookie objects.

Fixes #37437.
Built from https://develop.svn.wordpress.org/trunk@38164


git-svn-id: http://core.svn.wordpress.org/trunk@38105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 15:32:27 +00:00
Dominik Schilling
962f107035 HTTP API: Bump version of Requests to 1.7. 
See #33055.
Built from https://develop.svn.wordpress.org/trunk@38163


git-svn-id: http://core.svn.wordpress.org/trunk@38104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 14:55:28 +00:00
Sergey Biryukov
ccf7a5ef24 I18N: After [38077], merge two duplicate strings in wp_insert_term() and wp_update_term(). 
Props ramiy.
See #18218.
Built from https://develop.svn.wordpress.org/trunk@38162


git-svn-id: http://core.svn.wordpress.org/trunk@38103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 10:43:27 +00:00
Peter Wilson
b65bb2525e Script Loader: Clarify documentation of wp_resource_hints hook. 
Specify that the `wp_resource_hints` hook is firing for a single relation type.

Props: dimadin for initial patch.
See #37458.

Built from https://develop.svn.wordpress.org/trunk@38161


git-svn-id: http://core.svn.wordpress.org/trunk@38102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 10:36:28 +00:00
Andrew Ozz
37018fded6 TinyMCE: fix the calculation for the inline toolbar vertical position. 
Fixes #37481.
Built from https://develop.svn.wordpress.org/trunk@38160


git-svn-id: http://core.svn.wordpress.org/trunk@38101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-27 02:59:31 +00:00
Andrew Ozz
5bccb0020d TinyMCE, inline link: 
- Remove proxying through WordPress to test if an URL exists.
- Fix and enhance the regex that tests if the URL is well formed.

Fixes #36638.
Built from https://develop.svn.wordpress.org/trunk@38159


git-svn-id: http://core.svn.wordpress.org/trunk@38100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-26 23:24:28 +00:00
Andrew Ozz
101545cbb5 TinyMCE, wpView: 
- Add the `wpview-wrap` class and pass third param to the getNodes() callback for back-compat.
- Attach the mutation observer that resizes a view iframe inside the iframe to minimize memory use/leaks.
- Remove the `wp-mce-view-unbind` event. It has never been particularly reliable and now it doesn't fire when the user deletes a view by typing or pasting over it.
- Restore changing of a view iframe body classes when the editor body classes change.

Props iseulde, azaozz.
Fixes #36434.
Built from https://develop.svn.wordpress.org/trunk@38158


git-svn-id: http://core.svn.wordpress.org/trunk@38099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-26 23:13:28 +00:00
Andrew Ozz
59c1e02c84 TinyMCE, wpView: bail early when the iframe node is not attached to the DOM. We can't load any HTML in it as here is no iframe.contentWindow in these cases. 
See #36434.
Built from https://develop.svn.wordpress.org/trunk@38157


git-svn-id: http://core.svn.wordpress.org/trunk@38098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-26 22:06:28 +00:00
Andrew Ozz
b86015e78b TinyMCE: fix selecting an image on touch in iOS Safari for TinyMCE 4.4.1. 
Fixes #37427.
Built from https://develop.svn.wordpress.org/trunk@38156


git-svn-id: http://core.svn.wordpress.org/trunk@38097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-26 21:51:27 +00:00
Andrew Ozz
fd29d3e3a3 TinyMCE: upgrade to 4.4.1, changelog: https://www.tinymce.com/docs/changelog/#version441-july262016. 
See #37427.
Fixes #37476.
Built from https://develop.svn.wordpress.org/trunk@38155


git-svn-id: http://core.svn.wordpress.org/trunk@38096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-26 21:47:28 +00:00
Dominik Schilling
de5a513027 Plugins: Use history.pushState() to customize the URL during searches. 
`history.pushState()` requires an event handler for `popstate` which doesn't exist (yet).

Props rahulsprajapati for initial patch.
Fixes #37233.
Built from https://develop.svn.wordpress.org/trunk@38154


git-svn-id: http://core.svn.wordpress.org/trunk@38095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-26 20:01:28 +00:00
Helen Hou-Sandí
8f6517c275 System fonts: Adjust the smaller tabs so they appear as tabs. 
The tab effect comes from overlapping the border of the box below. Only applies to OSX; testing did not reveal adverse effects in other OSes.

props ocean90.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@38153


git-svn-id: http://core.svn.wordpress.org/trunk@38094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-26 16:46:29 +00:00
Helen Hou-Sandí
6d28c85bc7 System fonts: Don't quote single-word font names, per our coding standards. 
props ocean90, netweb.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@38152


git-svn-id: http://core.svn.wordpress.org/trunk@38093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-26 16:39:30 +00:00
Dominik Schilling
d7253ca244 Filesystem API: Prevent an endless self-calling loop in wp_tempnam(). 
Under certain conditions upgrades on Windows may fail because `wp_tempnam()` gets called in a loop.
This can happen when `wp_tempnam()` is called with `\.maintenance` for the `$filename` parameter. The function strips the extension, in this case `.maintenance`, which results in an empty filename. Because it's empty, `wp_tempnam()` calls itself with `dirname( '\.maintenance' )`. On *nix systems this would be `"/"` which allows `wp_tempnam()` to fall back on `time()`. But on Windows it's `"\"`.

This change adds the backslash to the list of characters which allow `wp_tempnam()` to fall back on `time()`.

See [32322], [31936].
Fixes #33999.
Built from https://develop.svn.wordpress.org/trunk@38151


git-svn-id: http://core.svn.wordpress.org/trunk@38092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-25 15:28:29 +00:00
Sergey Biryukov
9631611e92 I18N: Add a translator comment for two MediaElement.js strings added in [38089]. 
Props ideag.
See #37453, #37394.
Built from https://develop.svn.wordpress.org/trunk@38150


git-svn-id: http://core.svn.wordpress.org/trunk@38091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-25 14:16:29 +00:00
Sergey Biryukov
fdc07533f5 Plugins: Add a missing space between classes on <td> element for custom columns of the Plugins list table. 
Props crstauf.
Fixes #37460.
Built from https://develop.svn.wordpress.org/trunk@38149


git-svn-id: http://core.svn.wordpress.org/trunk@38090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-25 13:28:28 +00:00
Sergey Biryukov
18601e4b5a Docs: In wp_schedule_single_event(), add a note about scheduling an event to occur within 10 minutes of another event with the same action hook. 
Props medariox.
Fixes #37455.
Built from https://develop.svn.wordpress.org/trunk@38148


git-svn-id: http://core.svn.wordpress.org/trunk@38089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-25 12:23:30 +00:00
Sergey Biryukov
a7a8585640 Posts, Post Types: Remove a redundant function_exists( 'mb_strlen' ) check in get_sample_permalink_html(). 
`mb_strlen()` is always available since [32114].

See #30633.
Built from https://develop.svn.wordpress.org/trunk@38147


git-svn-id: http://core.svn.wordpress.org/trunk@38088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-23 13:08:44 +00:00
Dominik Schilling
51671afc0a List Table: Improve WP_Plugins_List_Table::search_box() which was added in [38033]. 
* Update DocBlock to use third-person singular verb and to include a period at the end.
* Use `submit_button()` for the submit button.
* Escape the ID attribute.
* Apply the same to `WP_List_Table::search_box()`.

See #37230.
Built from https://develop.svn.wordpress.org/trunk@38146


git-svn-id: http://core.svn.wordpress.org/trunk@38087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-23 11:00:36 +00:00
Sergey Biryukov
db9ec644f5 Permalinks: In get_page_uri(), don't prepend a parent page slug if it's empty. 
Props inderpreet99, SergeyBiryukov.
Fixes #36174.
Built from https://develop.svn.wordpress.org/trunk@38145


git-svn-id: http://core.svn.wordpress.org/trunk@38086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-23 10:05:49 +00:00
Sergey Biryukov
2a4a8c0861 Unit Tests: Add a @ticket reference for test_get_page_uri_without_argument(). 
See #26284.
Built from https://develop.svn.wordpress.org/trunk@38144


git-svn-id: http://core.svn.wordpress.org/trunk@38085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-23 08:55:27 +00:00
Sergey Biryukov
452e32f2df Unit Tests: Move get_page_uri() tests to post/getPageUri.php, added in [37345]. 
See #26284.
Built from https://develop.svn.wordpress.org/trunk@38143


git-svn-id: http://core.svn.wordpress.org/trunk@38084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-23 08:53:28 +00:00
Sergey Biryukov
995dc513a4 Docs: Update the description of the $box argument of wp_nav_menu_item_taxonomy_meta_box() for consistency with [38129]. 
Missed in [38130].

See #37211.
Built from https://develop.svn.wordpress.org/trunk@38142


git-svn-id: http://core.svn.wordpress.org/trunk@38083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 16:50:28 +00:00
Dominik Schilling
50ca05f8cd Plugins: Make search field placeholder translatable. 
See #37230.
Built from https://develop.svn.wordpress.org/trunk@38141


git-svn-id: http://core.svn.wordpress.org/trunk@38082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 14:51:28 +00:00
Dominik Schilling
c61d62675a Docs: Fix typo in hook description for customize_save_validation_before. 
See #37318.
Built from https://develop.svn.wordpress.org/trunk@38140


git-svn-id: http://core.svn.wordpress.org/trunk@38081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 13:51:28 +00:00
Dominik Schilling
06c71ee6ec Docs: Fix minor formatting issue for a comment added in [38113]. 
See #32171.
Built from https://develop.svn.wordpress.org/trunk@38139


git-svn-id: http://core.svn.wordpress.org/trunk@38080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 13:46:28 +00:00
Dominik Schilling
3a3828c396 Filesystem API: Change the default value for the $context parameter of get_filesystem_method() and request_filesystem_credentials() to an empty string. 
`$context` is a full path to the directory that is tested for being writable. A path shouldn't be a boolean value.
This also updates `WP_Upgrader_Skin::request_filesystem_credentials()` and `Automatic_Upgrader_Skin::request_filesystem_credentials()` and adds missing docs.

Props DrewAPicture, ocean90.
Fixes #37412.

Built from https://develop.svn.wordpress.org/trunk@38138


git-svn-id: http://core.svn.wordpress.org/trunk@38079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 12:10:27 +00:00
Dominik Schilling
eb0ee24750 Post Thumbnails: Remove an unused nonce in _wp_post_thumbnail_html(). 
See #12922.


Built from https://develop.svn.wordpress.org/trunk@38137


git-svn-id: http://core.svn.wordpress.org/trunk@38078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 11:44:28 +00:00
Dominik Schilling
c4dfc0adba Media: Remove global import for $content_width in _wp_post_thumbnail_html(). 
`$content_width` is unused since [35023].

See #28512.
Built from https://develop.svn.wordpress.org/trunk@38136


git-svn-id: http://core.svn.wordpress.org/trunk@38077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 11:40:28 +00:00
Sergey Biryukov
c578b90b96 Docs: Fix typo in wp_title() description. 
Props ixkaito.
Fixes #37442.
Built from https://develop.svn.wordpress.org/trunk@38135


git-svn-id: http://core.svn.wordpress.org/trunk@38076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 10:45:29 +00:00
Dominik Schilling
a20e16d3c6 Docs: Change type of WP_Upgrader_Skin::$result to 'string|bool|WP_Error'. 
`$result` can be `true` too, see `Language_Pack_Upgrader::bulk_upgrade()`.

See #32246.
Built from https://develop.svn.wordpress.org/trunk@38134


git-svn-id: http://core.svn.wordpress.org/trunk@38075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-22 10:43:29 +00:00
Sergey Biryukov
2cbe10e79c Database: Replace incorrect use of E_USER_NOTICE in wpdb::_real_escape() with the version number where the message was added. 
Props andizer.
Fixes #36403.
Built from https://develop.svn.wordpress.org/trunk@38133


git-svn-id: http://core.svn.wordpress.org/trunk@38074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-21 22:45:28 +00:00
Sergey Biryukov
db523ad623 Editor: Improve styling of "Add Media" button on mobile and make it more consistent with media buttons added by plugins. 
Props FolioVision.
Fixes #36999.
Built from https://develop.svn.wordpress.org/trunk@38132


git-svn-id: http://core.svn.wordpress.org/trunk@38073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-21 21:54:32 +00:00
Sergey Biryukov
0a9bfead1c Docs: In meta box functions, clarify that "Meta box ID" refers to the id attribute of the meta box and not a numeric ID. 
Fixes #37211.
Built from https://develop.svn.wordpress.org/trunk@38131


git-svn-id: http://core.svn.wordpress.org/trunk@38072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-21 19:24:28 +00:00
Sergey Biryukov
97fd7d829f Menus: In wp_nav_menu_item_taxonomy_meta_box(): 
* Rename the `$taxonomy` parameter to `$box` for clarity and consistency with other meta box functions.
* Make the docs more consistent with `post_categories_meta_box()` and other meta box functions.

See #37211.
Built from https://develop.svn.wordpress.org/trunk@38130


git-svn-id: http://core.svn.wordpress.org/trunk@38071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-21 19:21:28 +00:00