Sergey Biryukov
c46a518330
Tests: Skip symlinked theme file tests if symlink()
is not available, e.g. in PHP 5.2.x on Windows.
...
See #43508 .
Built from https://develop.svn.wordpress.org/trunk@42819
git-svn-id: http://core.svn.wordpress.org/trunk@42649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:48:30 +00:00
Adam Silverstein
e70caa19a1
Media: Fix image cropping on touch screen devices.
...
* In initCrop, handle touch events in addition to mouse events.
* In imageSelect jQuery plugin, accept event.which of 0 as provided by touch events.
Props yahil, alexgso, joemcgill.
Fixes #41242 .
Built from https://develop.svn.wordpress.org/trunk@42818
git-svn-id: http://core.svn.wordpress.org/trunk@42648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:27:31 +00:00
Adam Silverstein
6751be3561
Customizer menus: correct oversized viewport after dragging menu items.
...
Fix an issue where the screen viewport resized to an oversized state on mobile devices after moving sub-menus.
Props kwonye.
Fixes #36884 .
Built from https://develop.svn.wordpress.org/trunk@42817
git-svn-id: http://core.svn.wordpress.org/trunk@42647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:06:30 +00:00
John Blackbourn
d1d60bb22c
Themes: Revert [42788] as it breaks a lot of things.
...
See #43228
Built from https://develop.svn.wordpress.org/trunk@42816
git-svn-id: http://core.svn.wordpress.org/trunk@42646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 17:00:31 +00:00
Andrew Ozz
63dd79d908
Respect the commenter decision when they have checked the checkbox to consent to cookies, and keep it checked when they reload the page or post another comment.
...
See #43436 .
Built from https://develop.svn.wordpress.org/trunk@42815
git-svn-id: http://core.svn.wordpress.org/trunk@42645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 15:57:30 +00:00
Andrew Ozz
b93dfd3571
Add Privacy Tools admin page under the Tools menu.
...
Props allendav, xkon, azaozz.
See #43435 .
Built from https://develop.svn.wordpress.org/trunk@42814
git-svn-id: http://core.svn.wordpress.org/trunk@42644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 15:04:33 +00:00
Sergey Biryukov
051dd178b3
Tests: Skip symlinked theme file tests if the links could not be created.
...
Fixes #43508 .
Built from https://develop.svn.wordpress.org/trunk@42812
git-svn-id: http://core.svn.wordpress.org/trunk@42642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-09 01:10:31 +00:00
Andrea Fercia
127ecc530c
Accessibility: Underline the links in the Plugins descriptions and update notices.
...
Links within blocks and lines of text should always be underlined.
Props Travel_girl, chetan200891, Shital Patel.
Fixes #42647 .
Built from https://develop.svn.wordpress.org/trunk@42810
git-svn-id: http://core.svn.wordpress.org/trunk@42640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 23:20:30 +00:00
Sergey Biryukov
eaf4f346fd
Docs: Improve documentation for meta capability filters.
...
Remove self-references, correct parameter names and descriptions.
Props milana_cap, ocean90, SergeyBiryukov.
Fixes #43504 .
Built from https://develop.svn.wordpress.org/trunk@42809
git-svn-id: http://core.svn.wordpress.org/trunk@42639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 23:19:30 +00:00
Andrea Fercia
320a05019a
Accessibility: Themes: use aria-current
for the Walker_Nav_Menu
current link.
...
The `aria-current` attribute is a simple, effective way to help assistive
technologies users orientate themselves within a list of items. Continues the
introduction in core of `aria-current` after [42440], [41683], [41359], and [41371].
Props williampatton, chetan200891, sami.keijonen.
Fixes #43191 .
Built from https://develop.svn.wordpress.org/trunk@42808
git-svn-id: http://core.svn.wordpress.org/trunk@42638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 21:31:30 +00:00
Andrea Fercia
48077799d9
Accessibility: Insert Link modal: Improve keyboard interaction.
...
Avoids to change the selected link when using the Shift and Up/Down arrow keys
to select text in the form fields.
Fixes #43253 .
Built from https://develop.svn.wordpress.org/trunk@42807
git-svn-id: http://core.svn.wordpress.org/trunk@42637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 20:58:30 +00:00
Sergey Biryukov
996efe8f6e
Filesystem API: Avoid an infinite loop in wp_mkdir_p()
when trying to determine the parent folder with open_basedir
restriction in effect.
...
Props soulseekah, 1265578519-1.
Fixes #43417 .
Built from https://develop.svn.wordpress.org/trunk@42801
git-svn-id: http://core.svn.wordpress.org/trunk@42631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 19:32:30 +00:00
Sergey Biryukov
c1897645a2
General: In wp_debug_backtrace_summary()
, normalize paths before replacement for better cross–platform compatibility.
...
Props Rarst.
Fixes #43501 .
Built from https://develop.svn.wordpress.org/trunk@42800
git-svn-id: http://core.svn.wordpress.org/trunk@42630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 17:08:31 +00:00
Sergey Biryukov
902232ffec
Tests: Correct assertion in Tests_WP_Customize_Setting::test_constructor_with_args()
.
...
Props jipmoors.
See #30988 , #43218 .
Built from https://develop.svn.wordpress.org/trunk@42799
git-svn-id: http://core.svn.wordpress.org/trunk@42629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 16:38:30 +00:00
Sergey Biryukov
e2707d57f9
Docs: Improve JSDoc for wp-includes/js/media/controllers/gallery-add.js
.
...
Props boblinthorst, bramheijmink, manuelaugustin, ireneyoast, igorsch, nataliashitova.
Fixes #43500 .
Built from https://develop.svn.wordpress.org/trunk@42798
git-svn-id: http://core.svn.wordpress.org/trunk@42628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 16:25:34 +00:00
Sergey Biryukov
fdc4f68678
Docs: Remove copy/pasted default value description for $type
in WP_Customize_Manager::add_setting()
.
...
Props DannyCooper.
Fixes #43497 .
Built from https://develop.svn.wordpress.org/trunk@42797
git-svn-id: http://core.svn.wordpress.org/trunk@42627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 13:06:33 +00:00
Sergey Biryukov
ef33f565b1
Docs: Improve documentation for add_meta_boxes
and do_meta_boxes
actions.
...
Props danieltj, johnbillion, SergeyBiryukov.
Fixes #43229 .
Built from https://develop.svn.wordpress.org/trunk@42796
git-svn-id: http://core.svn.wordpress.org/trunk@42626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 03:57:31 +00:00
Sergey Biryukov
24f43065b9
Docs: Document globals in wp-admin/revision.php
as @global
instead of @param
.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42795
git-svn-id: http://core.svn.wordpress.org/trunk@42625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-08 03:53:34 +00:00
Andrea Fercia
ffedf3d752
Accessibility: Widgets: Make the "Available Widgets" section operable with a keyboard.
...
For a number of years, the "Available Widgets" section has been off-limits for
keyboard users. Now it can be used also with the keyboard. This change introduces
also some improvements for assistive technologies.
- makes the widget toggles focusable and adds an `aria-expanded` attribute to indicate their state
- improves the toggles labelling to clarify context (add/edit)
- changes the controls to choose a sidebar from list items to buttons
- adds an `aria-label` attribute to the buttons to clarify their purpose
- adds an `aria-pressed` attribute to the buttons to indicate which one is selected
- improves color contrast of the selected button
- uses a `wp.a11y.speak()` message to announce to screen reader users when a widget has been added to a sidebar
- moves focus back to the toggle button when closing a widget
See #40677 .
Built from https://develop.svn.wordpress.org/trunk@42794
git-svn-id: http://core.svn.wordpress.org/trunk@42624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 22:27:31 +00:00
Andrea Fercia
e34999f4aa
Accessibility: Networks and Sites: mark the New Site required form fields as required.
...
Also, adds an `aria-describedby` attribute to associate the Admin Email field with its description.
Props dipesh.kakadiya, jackreichert, rianrietveld.
Fixes #37331 .
Built from https://develop.svn.wordpress.org/trunk@42793
git-svn-id: http://core.svn.wordpress.org/trunk@42623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 19:41:33 +00:00
Mike Schroder
51b0a3cd28
Media: Correctly allow changing PDF thumbnail crop value.
...
Corrects logic that keeping plugins from setting crop value of intermediate image sizes for rendered PDFs.
Adds test.
Props leemon, SergeyBiryukov, chetan200891, birgire.
Fixes #43226 .
Built from https://develop.svn.wordpress.org/trunk@42792
git-svn-id: http://core.svn.wordpress.org/trunk@42622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-07 01:19:31 +00:00
Andrew Ozz
791b11bc3f
Add a method to confirm user requests by email. First run.
...
Props mikejolley.
See #43443 .
Built from https://develop.svn.wordpress.org/trunk@42791
git-svn-id: http://core.svn.wordpress.org/trunk@42621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-06 23:47:30 +00:00
Andrea Fercia
6a4b2a022a
Accessibility: Make the Widgets screen "Enable accessibility mode" link more discoverable.
...
For a number of years, the link to the Widgets screen "Accessibility mode" lived
in the Screen Options panel, hidden by default. Many users, including assistive
technologies users, weren't able to find it or even aware it existed. By bringing
the link in the main screen, visible by default, this change makes the
"Accessibility mode" easily discoverable for everyone.
Props chetan200891, antonioeatgoat.
Fixes #42778 .
Built from https://develop.svn.wordpress.org/trunk@42790
git-svn-id: http://core.svn.wordpress.org/trunk@42620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-06 17:21:33 +00:00
John Blackbourn
6c09e79cc5
Database: Add the query start time to logged query data.
...
This allows debugging plugins to plot the time at which queries were executed.
Props Rarst for initial patch.
Fixes #43315
Built from https://develop.svn.wordpress.org/trunk@42789
git-svn-id: http://core.svn.wordpress.org/trunk@42619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 22:54:35 +00:00
John Blackbourn
ea6360b47c
Themes: Ensure the theme roots cache is cleared when registering a theme directory.
...
Props soulseekah, johnbillion
Fixes #43228
Built from https://develop.svn.wordpress.org/trunk@42788
git-svn-id: http://core.svn.wordpress.org/trunk@42618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 22:14:30 +00:00
John Blackbourn
c9b07e6411
Docs: Standardise and correct documentation relating to parameters which accept plugin names.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42787
git-svn-id: http://core.svn.wordpress.org/trunk@42617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 21:50:31 +00:00
John Blackbourn
087b52dced
Upgrade/Install: Fix the format of the upgrader_process_complete
actions after [42343].
...
More info: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1323
See #41057 , #42505
Built from https://develop.svn.wordpress.org/trunk@42786
git-svn-id: http://core.svn.wordpress.org/trunk@42616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 21:44:30 +00:00
Andrea Fercia
9842bd6d24
Accessibility: Change the "Show / Hide dismissed updates" link to a button.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Also, adds an `aria-expanded` attribute to communicate the expandable panel state
and improves the buttons spacing.
Props Cheffheid, audrasjb, afercia.
Fixes #38674 .
Built from https://develop.svn.wordpress.org/trunk@42785
git-svn-id: http://core.svn.wordpress.org/trunk@42615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 15:50:30 +00:00
Andrea Fercia
64634898c2
Accessibility: Change the media upload "Dismiss error" link to a button.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Props Cheffheid, audrasjb.
Fixes #38671 .
Built from https://develop.svn.wordpress.org/trunk@42784
git-svn-id: http://core.svn.wordpress.org/trunk@42614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 15:33:33 +00:00
Sergey Biryukov
084b48e1ba
Help/About: Adjust capability checks formatting in help text on Dashboard screen for readability and consistency with similar checks in other files.
...
See #43472 .
Built from https://develop.svn.wordpress.org/trunk@42783
git-svn-id: http://core.svn.wordpress.org/trunk@42613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:32:30 +00:00
Sergey Biryukov
24f13abf63
Help/About: Remove popular plugins feed reference from help text on Dashboard screen, no longer relevant since [40607].
...
Props denisco.
See #43472 .
Built from https://develop.svn.wordpress.org/trunk@42782
git-svn-id: http://core.svn.wordpress.org/trunk@42612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:17:31 +00:00
Sergey Biryukov
31a3083c28
Help/About: Update "WordPress News" widget references in help text and inline documentation.
...
Props monikarao, denisco.
Fixes #43400 , #43472 .
Built from https://develop.svn.wordpress.org/trunk@42781
git-svn-id: http://core.svn.wordpress.org/trunk@42611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 03:04:31 +00:00
Sergey Biryukov
5596017878
Media: Recognize .ico
files as displayable images on PHP 5.3+ and allow attachment meta data to be generated for them.
...
Props remyvv, Guido07111975.
Fixes #43458 .
Built from https://develop.svn.wordpress.org/trunk@42780
git-svn-id: http://core.svn.wordpress.org/trunk@42610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 01:03:31 +00:00
Sergey Biryukov
e451dfac9e
Help/About: Correct the number of most recent drafts in help text on Dashboard screen.
...
Props denisco.
Fixes #43471 .
Built from https://develop.svn.wordpress.org/trunk@42779
git-svn-id: http://core.svn.wordpress.org/trunk@42609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-05 00:24:30 +00:00
Sergey Biryukov
3385d5b2de
Docs: Expand delete_theme()
return value, fix typo in delete_plugins()
return value.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42778
git-svn-id: http://core.svn.wordpress.org/trunk@42608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 22:07:29 +00:00
Sergey Biryukov
58592b64dc
Docs: Use consistent description for $wp_filesystem
global.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42777
git-svn-id: http://core.svn.wordpress.org/trunk@42607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 21:58:30 +00:00
Sergey Biryukov
179bec1306
Docs: Clarify return values and improve DocBlock formatting for verify_file_md5()
, unzip_file()
, _unzip_file_ziparchive()
, _unzip_file_pclzip()
, copy_dir()
, WP_Filesystem()
.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42776
git-svn-id: http://core.svn.wordpress.org/trunk@42606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 21:43:30 +00:00
Sergey Biryukov
3c8ae81018
Docs: Clarify download_url()
return value, improve DocBlock formatting.
...
See #42505 .
Built from https://develop.svn.wordpress.org/trunk@42775
git-svn-id: http://core.svn.wordpress.org/trunk@42605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 19:50:31 +00:00
Sergey Biryukov
7b7ca428f3
Docs: Clarify that wp_update_user()
accepts an array as $userdata
argument.
...
Props nextendweb.
Fixes #43051 .
Built from https://develop.svn.wordpress.org/trunk@42774
git-svn-id: http://core.svn.wordpress.org/trunk@42604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 18:12:31 +00:00
Sergey Biryukov
86c3c7e1c9
Filesystem API: Allow download_url()
to return the response code and body on error as an additional WP_Error
object data.
...
The error response body size is limited to 1 KB by default to avoid taking up too much memory. The size can be increased using `download_url_error_max_body_size` filter.
Props soulseekah, campusboy1987, mihdan, SergeyBiryukov.
Fixes #43329 .
Built from https://develop.svn.wordpress.org/trunk@42773
git-svn-id: http://core.svn.wordpress.org/trunk@42603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 17:14:31 +00:00
Andrew Ozz
8ae59374f3
Add a checkbox to the comment form so logged out users can opt-out of commenter cookies.
...
Props lakenh, xkon, birgire, azaozz.
See #43436 .
Built from https://develop.svn.wordpress.org/trunk@42772
git-svn-id: http://core.svn.wordpress.org/trunk@42602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-04 16:41:33 +00:00
Dominik Schilling
d950c75307
Import: Avoid counting an uncountable type when reading arguments passed to a script.
...
Props josephscott.
Fixes #42898 .
Built from https://develop.svn.wordpress.org/trunk@42771
git-svn-id: http://core.svn.wordpress.org/trunk@42601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 17:17:31 +00:00
Andrew Ozz
de8936588c
Add pre-save content filter to make target=_blank always secure.
...
Props notnownikki, iseulde, azaozz
Fixes #43187
Built from https://develop.svn.wordpress.org/trunk@42770
git-svn-id: http://core.svn.wordpress.org/trunk@42600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 14:42:31 +00:00
Dominik Schilling
74cb5936fc
Docs: Remove trailing whitespace in wp-includes/post.php
.
...
Built from https://develop.svn.wordpress.org/trunk@42769
git-svn-id: http://core.svn.wordpress.org/trunk@42599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-02 10:02:33 +00:00
Boone Gorges
35ad9e9efc
Allow LIKE
queries against the 'key' value in meta queries.
...
The new `compare_key=LIKE` parameter works in conjunction with `key` in a
similar way to the `compare=LIKE` and `value`: by doing a "compares" `LIKE`
query. This allows developers to do partial matches against keys when
doing meta queries.
Props mariovalney, chasewg.
Fixes #42409 .
Built from https://develop.svn.wordpress.org/trunk@42768
git-svn-id: http://core.svn.wordpress.org/trunk@42598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-01 04:03:33 +00:00
Andrea Fercia
d2d64f13c7
Accessibility: Change the comments "Quick Edit" and "Reply" links to buttons.
...
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Props Cheffeid, audrasjb, afercia.
See #43382 , #38677 .
Fixes #43376 .
Built from https://develop.svn.wordpress.org/trunk@42767
git-svn-id: http://core.svn.wordpress.org/trunk@42597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 22:36:34 +00:00
Sergey Biryukov
e786f9eb91
Docs: Mark WP_Http::_dispatch_request()
as deprecated. It's no longer used since [37428].
...
Fixes #43414 .
Built from https://develop.svn.wordpress.org/trunk@42766
git-svn-id: http://core.svn.wordpress.org/trunk@42596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:48:30 +00:00
Sergey Biryukov
b0ddd7ca43
Docs: Add description for register_admin_color_schemes()
.
...
Props terriann, danieltj.
Fixes #42779 .
Built from https://develop.svn.wordpress.org/trunk@42765
git-svn-id: http://core.svn.wordpress.org/trunk@42595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:28:31 +00:00
Sergey Biryukov
7d8809c98b
XML-RPC: Unify permission error messages in wp_xmlrpc_server
.
...
Props ramiy.
Fixes #42266 .
Built from https://develop.svn.wordpress.org/trunk@42764
git-svn-id: http://core.svn.wordpress.org/trunk@42594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 03:19:31 +00:00
iandunn
acfced54f0
External Libraries: Test for MEjs files in src
instead of build
.
...
The `build` task doesn't get run during TravisCI jobs, so the `build` folder doesn't exist in that context. Because of that, the test added in r42762 was failling.
Checking for the files in `src` instead achieves the same goal as that commit, but should pass in Travis.
See #43101
See https://wordpress.slack.com/archives/C02RQBWTW/p1519742993000615
Built from https://develop.svn.wordpress.org/trunk@42763
git-svn-id: http://core.svn.wordpress.org/trunk@42593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-28 00:26:31 +00:00