WordPress

mirror of https://github.com/WordPress/WordPress.git synced 2024-12-24 10:09:47 +01:00

Author	SHA1	Message	Date
Dominik Schilling	289db2d37b	Customizer: Revert [31911]. We want to preserve `url` and `return` URL parameters to make the experience smoother. see #31782. Built from https://develop.svn.wordpress.org/trunk@31933 git-svn-id: http://core.svn.wordpress.org/trunk@31912 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-30 19:22:26 +00:00
Sergey Biryukov	e70e4e74fa	Press This: Use the error message returned by `wp_update_post()` instead of a generic one. props stephdau. fixes #31808. Built from https://develop.svn.wordpress.org/trunk@31930 git-svn-id: http://core.svn.wordpress.org/trunk@31909 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-30 14:39:26 +00:00
Sergey Biryukov	43a99e0f1b	Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings. props SergeyBiryukov, afercia, tyxla. fixes #30766. Built from https://develop.svn.wordpress.org/trunk@31928 git-svn-id: http://core.svn.wordpress.org/trunk@31907 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-30 12:50:29 +00:00
Andrew Ozz	6cd9c9645e	Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button. Part props afercis, joedolson. Fixes #31575. Built from https://develop.svn.wordpress.org/trunk@31925 git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-30 03:09:51 +00:00
Andrew Ozz	f663dc73d4	Press This: remove `role="application"` from the Categories list wrapper. This doesn't make it work better in screen readers. See #31443. Built from https://develop.svn.wordpress.org/trunk@31907 git-svn-id: http://core.svn.wordpress.org/trunk@31886 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-26 21:49:32 +00:00
Dominik Schilling	8daaa09c9b	Improve newly added strings for i18n: * Add context to "Format" string. * Use "Format" with context for "Post format". see #31776. Built from https://develop.svn.wordpress.org/trunk@31906 git-svn-id: http://core.svn.wordpress.org/trunk@31885 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-26 21:19:26 +00:00
Aaron Jorbin	9b23faef07	Remove Shiny Plugin Installs See #31773, #29820 Built from https://develop.svn.wordpress.org/trunk@31897 git-svn-id: http://core.svn.wordpress.org/trunk@31876 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-26 02:30:28 +00:00
Boone Gorges	60c26865f9	Check that `$_POST` array index is set before comparing it in `post_preview()`. This prevents PHP notices in cases where a user with 'edit_others_posts' but without 'publish_posts' previews another user's posts. Props tyxla. Fixes #31760. Built from https://develop.svn.wordpress.org/trunk@31896 git-svn-id: http://core.svn.wordpress.org/trunk@31875 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-26 01:45:26 +00:00
Andrew Ozz	6cc20e7095	Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed. Props stephdau. Fixes #31763. Built from https://develop.svn.wordpress.org/trunk@31894 git-svn-id: http://core.svn.wordpress.org/trunk@31873 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-26 01:17:26 +00:00
Dominik Schilling	51854c53b4	Improve alignment of labels and inputs in Quick Edit. props mattheu, valendesigns. fixes #31408. Built from https://develop.svn.wordpress.org/trunk@31890 git-svn-id: http://core.svn.wordpress.org/trunk@31869 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-25 22:25:26 +00:00
Dominik Schilling	5ef13b688e	Comments List: Don't let "Quick Edit" break on smaller screens. Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action. props kraftbj. fixes #31482. Built from https://develop.svn.wordpress.org/trunk@31889 git-svn-id: http://core.svn.wordpress.org/trunk@31868 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-25 22:15:27 +00:00
Drew Jaynes	1ad0eaf416	Clean up DocBlock information and syntax for `get_filesystem_method()`. Props ericlewis, HarishChaudhari, valendesigns. Fixes #31267. Built from https://develop.svn.wordpress.org/trunk@31884 git-svn-id: http://core.svn.wordpress.org/trunk@31863 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-25 16:32:28 +00:00
Dion Hulse	7b5ae90225	When altering the admin URL to reflect the canonical location, keep the existing hash (if present) in the URL. Fixes #31758. See #23367 Built from https://develop.svn.wordpress.org/trunk@31882 git-svn-id: http://core.svn.wordpress.org/trunk@31861 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-25 04:32:26 +00:00
Andrew Ozz	f5e6f92174	Do not output empty name and id HTML attributes in get_submit_button(). Props afercia. Fixes #31749. Built from https://develop.svn.wordpress.org/trunk@31880 git-svn-id: http://core.svn.wordpress.org/trunk@31859 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-25 03:23:27 +00:00
Sergey Biryukov	ce6c00f140	Fix a typo in [31872]. see #31738. Built from https://develop.svn.wordpress.org/trunk@31873 git-svn-id: http://core.svn.wordpress.org/trunk@31852 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-24 17:33:27 +00:00
Aaron Jorbin	9c409e31f2	Fill `$plugins['upgrade']` with extra info for use in list table Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses `$plugin['upgrade']` rather than `$plugins['all']`, we need to fill that information in both places. Fixes #31738. Built from https://develop.svn.wordpress.org/trunk@31872 git-svn-id: http://core.svn.wordpress.org/trunk@31851 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-24 17:30:26 +00:00
Andrew Ozz	0329852941	Press This: - Fix the links on inserted images to point to the source site. - Fix inserting of images above the blockquote when the editor has not been focused. Fixes #31745. Built from https://develop.svn.wordpress.org/trunk@31868 git-svn-id: http://core.svn.wordpress.org/trunk@31847 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-24 01:33:29 +00:00
Dion Hulse	3dc53770b7	Upgrader: When creating a temporary working directory, strip off `.tmp` as well as `.zip` incase we end up using that directory as the items main directory. Fixes #30945 Built from https://develop.svn.wordpress.org/trunk@31863 git-svn-id: http://core.svn.wordpress.org/trunk@31842 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-23 04:40:27 +00:00
Dion Hulse	cc903c3422	Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified. * `H:i - 09:54` * `g:i a - 9:54 am` * `F j, Y - January 3, 2015` These shouldn't be used without a/A (am/AM) * `h:i - 01:23` * `G:i - 1:23` Props iseulde. Fixes #31121 Built from https://develop.svn.wordpress.org/trunk@31862 git-svn-id: http://core.svn.wordpress.org/trunk@31841 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-23 02:14:27 +00:00
Helen Hou-Sandí	bc54176af0	Media: Show filename instead of extension in the list table. This helps differentiate between files with the same or similar image or icon. Extension shows as a part of the filename, and so is not separately needed anymore. fixes #30943. Built from https://develop.svn.wordpress.org/trunk@31857 git-svn-id: http://core.svn.wordpress.org/trunk@31836 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-22 11:02:29 +00:00
Sergey Biryukov	42b9557137	Remove leading newlines from two translatable strings. fixes #29480. Built from https://develop.svn.wordpress.org/trunk@31844 git-svn-id: http://core.svn.wordpress.org/trunk@31826 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-20 02:42:26 +00:00
Sergey Biryukov	e838ab315d	After [31730], replace one more instance of `array_shift()` with `reset()` for better performance. see #31259, #15459. Built from https://develop.svn.wordpress.org/trunk@31841 git-svn-id: http://core.svn.wordpress.org/trunk@31823 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-20 01:57:27 +00:00
Sergey Biryukov	b568da1997	Make a comment clearer (without implying inversed logic) and fix a typo. see #31645. Built from https://develop.svn.wordpress.org/trunk@31837 git-svn-id: http://core.svn.wordpress.org/trunk@31819 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-20 00:45:27 +00:00
Andrew Ozz	1666eb5616	Press This: small clean-up when generating the suggested content. Ensure all keys are always set in the array that is passed through the filter. See #31637. Built from https://develop.svn.wordpress.org/trunk@31836 git-svn-id: http://core.svn.wordpress.org/trunk@31818 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-20 00:18:26 +00:00
Aaron Jorbin	22476bf617	Fix notice that exists for plugins with no slug Not all plugins have a slug, especially plugins not from the WordPress.org repository. Props imath for initial patch. Fixes #31694 Built from https://develop.svn.wordpress.org/trunk@31834 git-svn-id: http://core.svn.wordpress.org/trunk@31816 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-19 17:48:29 +00:00
Jeremy Felt	a18118ed7c	Make dates in multisite site and user list tables translatable. Props pavelevap. Fixes #22302. Built from https://develop.svn.wordpress.org/trunk@31833 git-svn-id: http://core.svn.wordpress.org/trunk@31815 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-19 16:22:28 +00:00
Aaron Jorbin	a836a32fb4	Ensure that we target the correct plugin row for update updates The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update. Props ericlewis Fixes #31621 Built from https://develop.svn.wordpress.org/trunk@31831 git-svn-id: http://core.svn.wordpress.org/trunk@31813 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-19 05:26:28 +00:00
Scott Taylor	55fd3fa791	In the "Send Trackbacks" meta box, the description of how pingbacks work was missing a comma after the introductory clause. Props cfinke. Fixes #31668. Built from https://develop.svn.wordpress.org/trunk@31830 git-svn-id: http://core.svn.wordpress.org/trunk@31812 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-19 04:06:27 +00:00
Scott Taylor	bce851dcf2	Replace `array_shift()` with `reset()` where appropriate for performance. Props SergeyBiryukov. Fixes #31259. Built from https://develop.svn.wordpress.org/trunk@31829 git-svn-id: http://core.svn.wordpress.org/trunk@31811 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-19 03:56:27 +00:00
Scott Taylor	55ae3f9ea0	Add `WP_Posts_List_Table::is_base_request()` to determine if the current "view" is the "All" (default) view. Fixes #24869. Built from https://develop.svn.wordpress.org/trunk@31828 git-svn-id: http://core.svn.wordpress.org/trunk@31810 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-19 02:26:26 +00:00
Andrew Ozz	40ebc2784f	Press This: check if the URL is to embeddable content on a site that supports oEmbed. Then insert only the URL in the editor. It will trigger a wpView with the embedded content. Fixes #31637. Built from https://develop.svn.wordpress.org/trunk@31827 git-svn-id: http://core.svn.wordpress.org/trunk@31809 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-19 00:52:26 +00:00
Andrew Ozz	4303ea5379	Press This: prepend the site domain to root-relative URLs. Reject other relative URLs. Part props stephdau, kraftbj. Fixes #31645. Built from https://develop.svn.wordpress.org/trunk@31818 git-svn-id: http://core.svn.wordpress.org/trunk@31800 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-18 20:43:27 +00:00
Dominik Schilling	9b79c36713	WP_Filesystem: Change `WP_Filesystem_FTPext::exists()` and `WP_Filesystem_ftpsockets::exists()` to return true for empty directories. Both methods are using *nlist() which returns a list of files in a given directory or the file itself for a given file. If the result was an empty list we assumed that the file doesn't exists. This includes also cases where $file is actually an empty directory. To prevent this we now check if $file is a directory before returning the result of an empty list. Other filesystem methods are using `file_exists()` which already checks whether a file or directory exists. fixes #30815. Built from https://develop.svn.wordpress.org/trunk@31815 git-svn-id: http://core.svn.wordpress.org/trunk@31797 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-18 19:22:27 +00:00
Aaron Jorbin	2d64637ff8	Request FTP and SSH credentials when needed during shiny updates This is a restoration of [31749] which was reverted in [31755]. It includes a number of enhancements from the original version. Namely: * Not doing a credential check in src/wp-includes/script-loader.php * Add new function `wp_print_request_filesystem_credentials_modal` * update the version number in the list table when a plugin is updated UI still needs further work, but this basic version should enable more testing Props ericlewis, jorbin See #31528 Built from https://develop.svn.wordpress.org/trunk@31811 git-svn-id: http://core.svn.wordpress.org/trunk@31793 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-18 03:18:27 +00:00
Andrew Ozz	f26a2e8113	Press This: ignore site descriptions that end with an ellipsis. These are most likely auto-generated. Props kraftbj. Fixes #31639. Built from https://develop.svn.wordpress.org/trunk@31810 git-svn-id: http://core.svn.wordpress.org/trunk@31792 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-18 02:51:27 +00:00
Andrew Ozz	b00ae388c6	Press This: add `aria-describedby` to the new tag field. Props afercia. Fixes #31546. Built from https://develop.svn.wordpress.org/trunk@31808 git-svn-id: http://core.svn.wordpress.org/trunk@31790 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-18 02:18:27 +00:00
Andrew Ozz	441e1e6ab9	Press This: fix the header styling and add a logo. Props Michael-Arestad. Fixes #31472. Built from https://develop.svn.wordpress.org/trunk@31807 git-svn-id: http://core.svn.wordpress.org/trunk@31789 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-18 02:09:27 +00:00
Andrew Ozz	c04a1affd1	Press This: bump bookmarklet's version. See #31657 . Built from https://develop.svn.wordpress.org/trunk@31800 git-svn-id: http://core.svn.wordpress.org/trunk@31782 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-17 01:19:27 +00:00
Andrew Ozz	9e1d17ad36	Press This: - Strip slashes while running side_load_images(), add slashes after. - Simplify and clean up side_load_images(). - Add another arg to media_sideload_image() to return the uploaded image src only, and fix it to always return WP_Error on errors. Fixes #31660. Built from https://develop.svn.wordpress.org/trunk@31799 git-svn-id: http://core.svn.wordpress.org/trunk@31781 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-17 00:47:28 +00:00
Andrew Ozz	bf34e504dc	Press This: change the Publish button text to Submit for Review for contributors (like on the Edit Post screen). Props stephdau, DrewAPicture. Fixes #31658. Built from https://develop.svn.wordpress.org/trunk@31798 git-svn-id: http://core.svn.wordpress.org/trunk@31780 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-16 21:07:27 +00:00
Andrew Ozz	c1c29782c9	Press This: - Test image sizes from JS after Press This loads, before adding them to "Suggested media". - Clean up and simplify the HTML and JS a bit. Fixes #31561. Built from https://develop.svn.wordpress.org/trunk@31797 git-svn-id: http://core.svn.wordpress.org/trunk@31779 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-16 20:51:26 +00:00
Andrew Ozz	634df7e4a4	PressThis: add a wrapped with role = application to the categories section. Props: afercia. See #31443. Built from https://develop.svn.wordpress.org/trunk@31775 git-svn-id: http://core.svn.wordpress.org/trunk@31755 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-13 23:41:27 +00:00
Andrew Ozz	805c530cf0	PressThis: simplify and restyle the categories drop-down, remove the checkboxes and use JS to get the selected categories on submitting the form. Part prop: Michael-Arestad. Fixes #31443. Built from https://develop.svn.wordpress.org/trunk@31765 git-svn-id: http://core.svn.wordpress.org/trunk@31745 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-13 16:57:26 +00:00
Dominik Schilling	474f001c42	Revert [31749], see #31528 . Built from https://develop.svn.wordpress.org/trunk@31755 git-svn-id: http://core.svn.wordpress.org/trunk@31736 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-12 17:51:26 +00:00
Sergey Biryukov	e8a600ac94	Shiny Updates: Don't translate an error code string. props ericlewis. fixes #31606. Built from https://develop.svn.wordpress.org/trunk@31751 git-svn-id: http://core.svn.wordpress.org/trunk@31732 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-12 13:09:27 +00:00
Aaron Jorbin	5b658df402	Request FTP and SSH credentials when needed during shiny updates This is a first pass at requesting FTP and SSH credentials when needed during shiny updates. Styling and some UX improvements are still needed, but we do show the prompt and use the passed data when doing plugin installs and updates for shiny updates. There are also a couple of areas that we could improve code wise such how we create the requestFilesystemCredentials part of the localized _wpUpdatesSettings. Over the past half century, we've split the atom, we've spliced the gene and we've roamed Tranquility Base. We've reached for the stars and never have we been closer to having them in our grasp. That has nothing to do with shiny updates. Props ericlewis, jorbin, and drewapicture for testing Fixes #31528 Built from https://develop.svn.wordpress.org/trunk@31749 git-svn-id: http://core.svn.wordpress.org/trunk@31730 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-12 08:53:26 +00:00
Helen Hou-Sandí	296dba2804	Nav menus: Return to calling links "Custom Links". It was like this before 3.6 and got a bit lost during that development cycle. Also uses the terminology more consistently in the nav menu UI. props tyxla. fixes #31344. Built from https://develop.svn.wordpress.org/trunk@31748 git-svn-id: http://core.svn.wordpress.org/trunk@31729 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-12 06:15:27 +00:00
Andrew Ozz	1581ca7092	PressThis: add inline comments and some cleanup for the images and embeds regex. Props stephdau. Fixes #31373. Built from https://develop.svn.wordpress.org/trunk@31739 git-svn-id: http://core.svn.wordpress.org/trunk@31720 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-11 23:37:28 +00:00
Andrew Ozz	ce297a7227	PressThis: update _limit_url(), use esc_url_raw(). Fixes checking of urlencoded strings. See #31373. Built from https://develop.svn.wordpress.org/trunk@31737 git-svn-id: http://core.svn.wordpress.org/trunk@31718 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-11 23:23:25 +00:00
Dominik Schilling	4cc85f4da2	Administration: Remove single-use URL parameters and create canonical link based on new URL. The default removable query args are 'message', 'settings-updated', 'saved', 'update', 'updated','activated', 'activate', 'deactivate', 'locked', 'deleted', 'trashed', 'untrashed', 'enabled', 'disabled', and 'skipped'. props morganestes. fixes #23367. Built from https://develop.svn.wordpress.org/trunk@31736 git-svn-id: http://core.svn.wordpress.org/trunk@31717 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-11 23:09:26 +00:00
John Blackbourn	bb99536bf5	Introduce a new algorithm for displaying a hierarchical list of post objects in the `WP_Posts_List_Table`. This reduces processing time, reduces database queries, and substantially reduces memory use on sites with a high number of Pages. Props nofearinc, rodrigosprimo, nacin, johnbillion. Fixes #15459 Built from https://develop.svn.wordpress.org/trunk@31730 git-svn-id: http://core.svn.wordpress.org/trunk@31711 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-11 20:46:27 +00:00
Dominik Schilling	50c2cee32d	Merge three similar strings. props pavelevap. see #31013. Built from https://develop.svn.wordpress.org/trunk@31717 git-svn-id: http://core.svn.wordpress.org/trunk@31698 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-11 15:25:28 +00:00
Dominik Schilling	13ad2d4e16	Screen Options: Improve items per page option label. Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context. This change adds a default label "Number of items per page:" to `WP_Screen->render_per_page_options()` and removes all the existing one-word labels. props afercia. fixes #31349, #15576. Built from https://develop.svn.wordpress.org/trunk@31696 git-svn-id: http://core.svn.wordpress.org/trunk@31677 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-10 15:32:27 +00:00
Sergey Biryukov	19f1d4f402	EXIF/IPTC captions should populate Caption (`post_excerpt`) on upload, not Description (`post_content`). Make sure the caption is always set if found. Previously, if the caption was less than 80 characters, only the Title field would be set. props beaulebens, ericlewis, bendoh, SergeyBiryukov. fixes #22768. Built from https://develop.svn.wordpress.org/trunk@31694 git-svn-id: http://core.svn.wordpress.org/trunk@31675 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-10 05:07:28 +00:00
Andrew Ozz	be24bc3a97	PressThis: - Filter and select the content on the PHP side. Then pass only the needed data to JS. - Add the suggested post title and contend directly to the HTML. - Standardise the data type names. - Some cleanup/reduction of the code in the bookmarklet. See #31373. Built from https://develop.svn.wordpress.org/trunk@31693 git-svn-id: http://core.svn.wordpress.org/trunk@31674 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-09 21:49:28 +00:00
Dion Hulse	8a9181d8d4	SSH2 Upgrade transport: Trim the trailing newline character from the ouput of `pwd` to avoid a PHP Segfault. Fixes #30802 for trunk. Built from https://develop.svn.wordpress.org/trunk@31686 git-svn-id: http://core.svn.wordpress.org/trunk@31667 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-09 04:32:27 +00:00
Scott Taylor	0ec87e4584	There are a few functions that have the ability to return `false` instead of a string, so the return value should be checked before being passed to functions that expect string. These are trivial, but they clear out some Scrutinizer issues. See #30799. Built from https://develop.svn.wordpress.org/trunk@31681 git-svn-id: http://core.svn.wordpress.org/trunk@31662 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-09 02:11:28 +00:00
Scott Taylor	dccf5ceb90	Empty `return` statements are unnecessary at the end of functions. See #30799. Built from https://develop.svn.wordpress.org/trunk@31679 git-svn-id: http://core.svn.wordpress.org/trunk@31660 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-08 23:09:27 +00:00
Scott Taylor	c1cab11ceb	Use `$this->` instead of `parent::` when calling `tablenav()` in `WP_Theme_Install_List_Table`. See #30799. Built from https://develop.svn.wordpress.org/trunk@31672 git-svn-id: http://core.svn.wordpress.org/trunk@31653 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-07 23:03:27 +00:00
Andrew Ozz	be207e6550	PressThis: make the Preview button "subtle". See #31458. Built from https://develop.svn.wordpress.org/trunk@31655 git-svn-id: http://core.svn.wordpress.org/trunk@31636 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-07 01:50:26 +00:00
Andrew Ozz	9716d171c7	PressThis: add preview functionality. Opens the preview in a new window or a tab next to the source tab. Fixes #31458. Built from https://develop.svn.wordpress.org/trunk@31654 git-svn-id: http://core.svn.wordpress.org/trunk@31635 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-07 01:17:26 +00:00
Andrew Ozz	a27967aa05	PressThis: - Close the sidebar on moving the focus outside of it (by clicking or by "tabbing"). - Fix a (weird) structural CSS problem where clicks go through the sidebar when it is open. - Clean up the JS a bit. Fixes #31457. Built from https://develop.svn.wordpress.org/trunk@31651 git-svn-id: http://core.svn.wordpress.org/trunk@31632 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-06 22:57:26 +00:00
Scott Taylor	8f0b626d13	Introduce a function, `wp_attachment_is( $type, $post = 0 )`, to collapse the logic for determining whether an attachment is an `image`, `audio`, or `video`. This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist. See #25275. Built from https://develop.svn.wordpress.org/trunk@31645 git-svn-id: http://core.svn.wordpress.org/trunk@31626 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-06 20:26:26 +00:00
Andrew Ozz	5abac389fa	PressThis: when server-side parsing, filter small images by the width and height attributes if set. See #31373. Built from https://develop.svn.wordpress.org/trunk@31637 git-svn-id: http://core.svn.wordpress.org/trunk@31618 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-06 02:03:27 +00:00
Andrew Ozz	bcad925af4	PressThis: - Fix error when checking for empty array keys. - Add better DailyMotion embed support. Props stephdau, see #31373. Built from https://develop.svn.wordpress.org/trunk@31635 git-svn-id: http://core.svn.wordpress.org/trunk@31616 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-06 01:17:24 +00:00
Scott Taylor	da7359b060	After [31620], when checking for HTTP URLs, make sure we are checking the shortcode body instead of an indexed attribute. See #31139. Built from https://develop.svn.wordpress.org/trunk@31626 git-svn-id: http://core.svn.wordpress.org/trunk@31607 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-05 16:26:25 +00:00
Scott Taylor	f9c138b4c4	`detached` affects the `wp()` call for the media list table, so switch our new `$_GET` key to `detach`. See #6820. Built from https://develop.svn.wordpress.org/trunk@31624 git-svn-id: http://core.svn.wordpress.org/trunk@31605 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-05 15:59:27 +00:00
Scott Taylor	cc953717b7	Allow inline editing of `width` and `height` parameters while previewing an embed in the media modal: * Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link` * Allow a URL to transition to a shortcode (and vice versa) when returning an embed to TinyMCE * In `WP_Embed`, store the last URL and last set of attributes requested in class properties * `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response. This is a first pass to allow broad testing with recent MCE view changes. See #31139. Built from https://develop.svn.wordpress.org/trunk@31620 git-svn-id: http://core.svn.wordpress.org/trunk@31601 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-05 06:00:26 +00:00
Scott Taylor	d3471e9850	Allow attachments to be Detached from their parent in media grid and list modes. See #6820. Built from https://develop.svn.wordpress.org/trunk@31619 git-svn-id: http://core.svn.wordpress.org/trunk@31600 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-05 05:35:28 +00:00
Helen Hou-Sandí	df08581656	List tables: Display front and posts page indicators. fixes #30190. Built from https://develop.svn.wordpress.org/trunk@31610 git-svn-id: http://core.svn.wordpress.org/trunk@31591 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-04 19:45:25 +00:00
Andrew Ozz	f53199487d	PressThis: - Improve handling of the data, both from the bookmarklet and from server-side parsing. - Standardize on processing the data in PHP and remove duplicate code from JS. - Improve the bookmarklet code and remove pre-filtering of the data. Part props stephdau, see #31373. Built from https://develop.svn.wordpress.org/trunk@31609 git-svn-id: http://core.svn.wordpress.org/trunk@31590 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-04 19:29:25 +00:00
Helen Hou-Sandí	513a038159	Remove the once-placeholder-esque "tag hint", which has not worked in quite some time. It's not particularly useful, and adds visual noise when in place. props welcher. fixes #31485. Built from https://develop.svn.wordpress.org/trunk@31607 git-svn-id: http://core.svn.wordpress.org/trunk@31588 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-03 21:53:25 +00:00
Helen Hou-Sandí	5567d03278	Nav menus: Better JS performance on initial load of edit screen. The accessibility helpers previously processed all items when editing a menu, which was quite slow to the point of being unresponsive for large menus. They now only process items when they are expanded or a user comes near them in some way, such as hover or focus. Also simplifies a redundant set of click event handlers down to one, which further enhances performance. props atimmer, sevenspark. fixes #25698. Built from https://develop.svn.wordpress.org/trunk@31604 git-svn-id: http://core.svn.wordpress.org/trunk@31585 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-03 21:14:25 +00:00
Andrew Ozz	a9f165915f	Press This: - Remove classes from suggested HTML for the editor. - Improve the filter, pass an associative array as param. - Use <em> instead of <cite>. Props Michael-Arestad, kraftbj. Fixes #31493. Built from https://develop.svn.wordpress.org/trunk@31601 git-svn-id: http://core.svn.wordpress.org/trunk@31582 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-02 23:41:27 +00:00
Drew Jaynes	0b3c3092fc	Clean up and refine DocBlocks for a variety of functions and methods in wp-admin/includes/template.php. * Also documents the default arguments of `wp_terms_checklist()` as a hash notation. Props ipm-frommen, DrewAPicture. Fixes #31248. Built from https://develop.svn.wordpress.org/trunk@31599 git-svn-id: http://core.svn.wordpress.org/trunk@31580 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-02 06:11:40 +00:00
Andrew Ozz	c22307fd9a	PressThis: make sure buttons.css is loaded before press-this.css. Use (int) $post_ID instead of $post->ID. See #31373. Built from https://develop.svn.wordpress.org/trunk@31597 git-svn-id: http://core.svn.wordpress.org/trunk@31578 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-02 00:58:25 +00:00
Andrew Ozz	3a124ac2f4	PressThis: - Replace all `%1$s` and `%2$s` in suggestedHTML in case plugins repeat them. - Fix docs typo, props kraftbj. See #31373. Built from https://develop.svn.wordpress.org/trunk@31596 git-svn-id: http://core.svn.wordpress.org/trunk@31577 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-01 23:28:26 +00:00
Andrew Ozz	4e8138cea5	PressThis: - Simplify `getSuggestedContent()` and helpers. No need to override the global `data`. - Replace the `press_this_source_string` and `press_this_source_link` filters with `press_this_suggested_html` that allows filtering of the link and the wrapper HTML tags. See #31373. Built from https://develop.svn.wordpress.org/trunk@31595 git-svn-id: http://core.svn.wordpress.org/trunk@31576 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-01 22:44:25 +00:00
Drew Jaynes	a337c34c4e	Fix a typo in the `$args` parameter hash notation description for `add_settings_field()`. See #28975, [31592]. Built from https://develop.svn.wordpress.org/trunk@31593 git-svn-id: http://core.svn.wordpress.org/trunk@31574 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-01 07:57:32 +00:00
Drew Jaynes	82fd5e33dd	Add a hash notation for the optional `$args` parameter in `add_settings_field()`, which includes a description for the new `$class` argument added in [31560]. Also adds a changelog entry to `add_settings_field()` DocBlock for the new `$class` argument. See [31560]. Fixes #28975. Built from https://develop.svn.wordpress.org/trunk@31592 git-svn-id: http://core.svn.wordpress.org/trunk@31573 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-03-01 07:53:25 +00:00
Andrew Ozz	8164f8fe0e	PressThis: - Remove unneeded passing of post formats strings to JS. - Set the currently selected post format name with jQuery. See #31373. Built from https://develop.svn.wordpress.org/trunk@31589 git-svn-id: http://core.svn.wordpress.org/trunk@31570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-28 20:08:27 +00:00
Dominik Schilling	8ecb7f5d1e	Press This: Backwards compatibility enhancements. * Add missing actions for printing styles/scripts. * Since `$hook_suffix` is null, hardcode `press-this.php`. * Restore body classes, add filter. * Use boolean value instead of `__return_false()`. * Use `wp_json_encode()`. * Update docs for filters in script-loader.php. * Make `<a href="%1$s">%2$s</a>` not translatable. see #31373. Built from https://develop.svn.wordpress.org/trunk@31588 git-svn-id: http://core.svn.wordpress.org/trunk@31569 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-28 10:36:25 +00:00
Dominik Schilling	c7dba8b015	Press This: RTL improvements. * Load the RTL version of press-this-editor.css. * Use more semantic class names for the arrows, Makes it easier to swap the arrows in RTL, see #31478. see #31474. Built from https://develop.svn.wordpress.org/trunk@31577 git-svn-id: http://core.svn.wordpress.org/trunk@31558 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-27 19:44:24 +00:00
Scott Taylor	f6b1b01ecd	Make a new function, `wp_delete_file()`. Use it. Props scribu, wonderboymusic. Fixes #17864. Built from https://develop.svn.wordpress.org/trunk@31575 git-svn-id: http://core.svn.wordpress.org/trunk@31556 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-27 16:51:25 +00:00
Dominik Schilling	5e47a1f633	Press This: Use boolean value instead of __return_true(). Add missing hook docs. see #31373. Built from https://develop.svn.wordpress.org/trunk@31571 git-svn-id: http://core.svn.wordpress.org/trunk@31552 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-27 11:15:25 +00:00
Andrew Ozz	4593319ea7	PressThis: accessibility enhancements: - Add missing form labels. - Add some screen-reader-text and aria-hidden attributes. - Focus handling improvements. - Change tagcloud-link into a button. - Add missing ID attribute in tools.php. Props afercia. Fixes #31449. Built from https://develop.svn.wordpress.org/trunk@31566 git-svn-id: http://core.svn.wordpress.org/trunk@31547 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-27 02:50:25 +00:00
Helen Hou-Sandí	b95d99d1c1	Settings API: Allow passing a class to `add_settings_field()` via the `$args` array. While it's possible to target the wrapper element otherwise (currently a `tr`), this deficiency is made especially noticeable when custom code cannot take advantage of what core is doing, such as with avatars in #30168. props valendesigns. fixes #28975. see #30168. Built from https://develop.svn.wordpress.org/trunk@31560 git-svn-id: http://core.svn.wordpress.org/trunk@31541 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-26 19:59:25 +00:00
Sergey Biryukov	49dd31506f	Press This: Use correct URL for update bookmarklet link. props kraftbj. fixes #31461. Built from https://develop.svn.wordpress.org/trunk@31556 git-svn-id: http://core.svn.wordpress.org/trunk@31537 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-26 08:48:25 +00:00
Scott Taylor	7cb45f2402	Don't call the size function `count()` as part of a test condition in loops. Compute the size beforehand, and not on each iteration. Scrutinizer added a Performance label: these are the only violations. See #30799. Built from https://develop.svn.wordpress.org/trunk@31554 git-svn-id: http://core.svn.wordpress.org/trunk@31535 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-26 05:48:24 +00:00
Scott Taylor	4310147e54	Add missing access modifiers to `WP_Press_This`. See #31456. Built from https://develop.svn.wordpress.org/trunk@31552 git-svn-id: http://core.svn.wordpress.org/trunk@31533 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-26 05:18:25 +00:00
Drew Jaynes	50bb433c66	Ignore the internal-use function `_wp_posts_page_notice()` from parsing for the code reference. See #17470. Built from https://develop.svn.wordpress.org/trunk@31551 git-svn-id: http://core.svn.wordpress.org/trunk@31532 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-26 03:08:28 +00:00
Helen Hou-Sandí	ae3baa7c5b	Hide irrelevant UI and display a message when editing the page for posts. Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust. Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content. props alexkingorg for the initial, long-suffering patch. fixes #17470. Built from https://develop.svn.wordpress.org/trunk@31550 git-svn-id: http://core.svn.wordpress.org/trunk@31531 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-26 02:47:25 +00:00
Andrew Ozz	1857055bb8	PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373 . Built from https://develop.svn.wordpress.org/trunk@31534 git-svn-id: http://core.svn.wordpress.org/trunk@31515 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-25 01:50:26 +00:00
Mark Jaquith	8b180b9a46	Add theme browsing and theme switching to the Customizer * Brings into core the Customizer Theme Switcher feature plugin * You can now browse, preview, and activate themes right from the Customizer fixes #31303. props celloexpressions, afercia, westonruter, folletto, designsimply Built from https://develop.svn.wordpress.org/trunk@31533 git-svn-id: http://core.svn.wordpress.org/trunk@31514 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-24 20:31:24 +00:00
Drew Jaynes	4743843323	Add missing function and parameter descriptions to a variety of functions in wp-admin/includes/image-edit.php. Props NikV for the initial patch. Fixes #31353. Built from https://develop.svn.wordpress.org/trunk@31529 git-svn-id: http://core.svn.wordpress.org/trunk@31510 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-24 06:07:26 +00:00
Jeremy Felt	7644e68119	Provide proper label associations and descriptions throughout the network admin * Add labels previously missing for many inputs throughout the network admin screen. * Add proper `aria-describedby` attributes to provide better descriptions. * Wrap grouped inputs with `fieldset` elements. * Remove now unneeded `title` attributes when appropriate. Props cfoellmann, afercia, rianrietveld. Fixes #38406. Built from https://develop.svn.wordpress.org/trunk@31517 git-svn-id: http://core.svn.wordpress.org/trunk@31498 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-23 02:29:26 +00:00
Andrew Ozz	19dbf7b998	Improve table footer tab sequence by moving `<tfoot>` after `<tbody>`. Props afercia, rianrietveld, DrewAPicture. Fixes #30914 . Built from https://develop.svn.wordpress.org/trunk@31513 git-svn-id: http://core.svn.wordpress.org/trunk@31494 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-22 21:48:26 +00:00
Jeremy Felt	678982ee7e	Do not activate plugins on initial installation in multisite. Check `is_multisite()` before activating a plugin that has been installed via AJAX. Without this check, the plugin would be automatically activated on the main site of the network. Props ianmjones. Fixes #31327. Built from https://develop.svn.wordpress.org/trunk@31511 git-svn-id: http://core.svn.wordpress.org/trunk@31492 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-22 21:30:25 +00:00
Sergey Biryukov	8eb25609e9	Dashboard: Add a filter for the query arguments used for the Recent Posts widget. props danielbachhuber. fixes #29374. Built from https://develop.svn.wordpress.org/trunk@31508 git-svn-id: http://core.svn.wordpress.org/trunk@31489 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-22 19:57:24 +00:00
Sergey Biryukov	4b21c67738	Remove untranslatable period from a successful update message in `Bulk_Upgrader_Skin::add_strings()`. props mako09, DrewAPicture. fixes #30793. Built from https://develop.svn.wordpress.org/trunk@31506 git-svn-id: http://core.svn.wordpress.org/trunk@31487 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-22 17:07:24 +00:00
Sergey Biryukov	19a43125cd	Don't try to read a non-existent Exif:Title tag in `wp_read_image_metadata()`, as it's not a part of the Exif standard. props tyxla. fixes #31043. Built from https://develop.svn.wordpress.org/trunk@31462 git-svn-id: http://core.svn.wordpress.org/trunk@31443 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-14 09:14:28 +00:00
Sergey Biryukov	e2f5a8094e	Avoid a PHP notice in `wp_install_language_form()` and `wp_dropdown_languages()` if the language doesn't have a ISO 639-1 code. props barrykooij. fixes #31319. Built from https://develop.svn.wordpress.org/trunk@31447 git-svn-id: http://core.svn.wordpress.org/trunk@31428 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-13 11:23:26 +00:00
Sergey Biryukov	7b9d981a54	Use correct default values for some admin template functions. props ipm-frommen. fixes #31308. Built from https://develop.svn.wordpress.org/trunk@31446 git-svn-id: http://core.svn.wordpress.org/trunk@31427 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-13 06:51:25 +00:00
Sergey Biryukov	5a0b01edf1	Rename unused argument and remove obsolete global in `iframe_header()`. props ipm-frommen. fixes #31309. Built from https://develop.svn.wordpress.org/trunk@31443 git-svn-id: http://core.svn.wordpress.org/trunk@31424 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-13 05:31:26 +00:00
Sergey Biryukov	268d79cb77	`_list_meta_row()` should always return a string. props ipm-frommen. fixes #31310. Built from https://develop.svn.wordpress.org/trunk@31442 git-svn-id: http://core.svn.wordpress.org/trunk@31423 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-13 04:22:26 +00:00
Sergey Biryukov	6fd67ad80e	Correct parameter types for `Plugin_Upgrader::bulk_upgrade()` and `Theme_Upgrader::bulk_upgrade()`. props ipm-frommen. fixes #31312. Built from https://develop.svn.wordpress.org/trunk@31441 git-svn-id: http://core.svn.wordpress.org/trunk@31422 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-13 04:19:27 +00:00
Sergey Biryukov	43583a1b9e	Terminate JS statements in two admin files. props ipm-frommen. fixes #31311. Built from https://develop.svn.wordpress.org/trunk@31440 git-svn-id: http://core.svn.wordpress.org/trunk@31421 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-13 04:09:27 +00:00
Helen Hou-Sandí	2a1f3c4c1f	Posts list table: Add a filter to disable the months dropdown. It was previously possible to prevent it from displaying by filtering everything out from the results, but if one really doesn't want it, they should be able to short-circuit before the query even runs. props norcross, SergeyBiryukov. fixes #30254. Built from https://develop.svn.wordpress.org/trunk@31438 git-svn-id: http://core.svn.wordpress.org/trunk@31419 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-12 18:38:29 +00:00
Dion Hulse	3cec3655e9	Prevent IE9 and lower displaying the download file dialogue when attempting to upload using the `html4` Plupload handler. The HTML4 Plupload handler uses a hidden iframe to POST the upload form, Unfortunately Internet Explorer 9 doesn't support the `application/json` content-type which `wp_send_json_success()` and requires `text/html` instead. This partially reverts [30354], keeping the better error messages. Fixes #31037 for trunk. Built from https://develop.svn.wordpress.org/trunk@31429 git-svn-id: http://core.svn.wordpress.org/trunk@31410 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-12 01:15:29 +00:00
Scott Taylor	6cb16f7a21	Remove unused media JS files. See #28510. Built from https://develop.svn.wordpress.org/trunk@31405 git-svn-id: http://core.svn.wordpress.org/trunk@31386 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-10 22:45:28 +00:00
Sergey Biryukov	0e65ae6176	Remove redundant string with a typo introduced in [25481]. see #31217. Built from https://develop.svn.wordpress.org/trunk@31404 git-svn-id: http://core.svn.wordpress.org/trunk@31385 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-10 07:53:28 +00:00
Sergey Biryukov	12f4004989	Replace generic "Dear user" greeting in email notifications with a more personalized one. props Ipstenu. fixes #31217. Built from https://develop.svn.wordpress.org/trunk@31403 git-svn-id: http://core.svn.wordpress.org/trunk@31384 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-10 07:47:27 +00:00
Sergey Biryukov	f166a51809	Update body class when switching between admin color schemes. props valendesigns. fixes #30488. Built from https://develop.svn.wordpress.org/trunk@31400 git-svn-id: http://core.svn.wordpress.org/trunk@31381 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-10 02:23:28 +00:00
Boone Gorges	72f18cb067	Don't parse empty 'tax_input' keys in `edit_post()`. This fixes a bug introduced in [31359] where saving a tax_input that contained only whitespace would result in a random tag being erroneously added to the post. See #30615. Built from https://develop.svn.wordpress.org/trunk@31392 git-svn-id: http://core.svn.wordpress.org/trunk@31373 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-09 22:54:28 +00:00
Sergey Biryukov	1e0905793c	Avoid inadvertent stomping of the original `$args` parameter passed to `plugins_api_result` and `themes_api_result` filters in `plugins_api()` and `themes_api()`, respectively. Fixes a regression introduced in [25956]. props Corphi, obenland. fixes #29079. Built from https://develop.svn.wordpress.org/trunk@31363 git-svn-id: http://core.svn.wordpress.org/trunk@31344 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-07 06:21:22 +00:00
Boone Gorges	b9e661dcae	Parse non-hierarchical tag input into term IDs before sending to `wp_insert_post()`. When editing a post, non-hierarchical taxonomy terms are sent as the comma-separated list entered into the tax_input metabox. Passing these values directly to `wp_update_post()` meant that they were interpreted as term slugs rather than term names, causing mismatches when a typed string matched the slug of one term and the name of a different term. We fix the problem by preprocessing tax_input data sent from post.php, converting it to unambiguous term_ids before saving. Props boonebgorges, ArminBraun. Fixes #30615. Built from https://develop.svn.wordpress.org/trunk@31359 git-svn-id: http://core.svn.wordpress.org/trunk@31340 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-06 20:32:22 +00:00
Gary Pendergast	d7c6ac95bc	Upgrades: wp_usermeta is a global table in multisite, so it should only be upgraded by the single site routines when we're not in a multisite install. See #21212 Built from https://develop.svn.wordpress.org/trunk@31358 git-svn-id: http://core.svn.wordpress.org/trunk@31339 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-06 13:41:22 +00:00
Gary Pendergast	7444799a82	Upgrades: When upgrading a table to utf8mb4, we should run the `ALTER TABLE` query, even if it doesn't have any text columns. This will update the table's default character set, so that any text columns added in the future will have the expected character set. See #21212 Built from https://develop.svn.wordpress.org/trunk@31354 git-svn-id: http://core.svn.wordpress.org/trunk@31335 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-06 05:59:23 +00:00
Gary Pendergast	555a9f0912	Upgrades: When deciding if we can upgrade a table to utf8mb4, make sure we're checking the character set, not the collation. Bump the DB version as well, as the update in [31349] wouldn't have triggered for anyone who tried it. See #21212 Built from https://develop.svn.wordpress.org/trunk@31351 git-svn-id: http://core.svn.wordpress.org/trunk@31332 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-06 05:26:21 +00:00
Gary Pendergast	b2cf823105	WPDB: If a site is using the `utf8` charset, and their version of MySQL supports `utf8mb4`, auto-upgrade them to `utf8mb4`. This patch also resizes some indexes, to allow for the 767 byte index size limit in standard MySQL installs. See #21212 Built from https://develop.svn.wordpress.org/trunk@31349 git-svn-id: http://core.svn.wordpress.org/trunk@31330 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-06 04:51:22 +00:00
Gary Pendergast	5e4d135411	Shiny Updates: Fix a PHP warning when installing new plugins. Props lgladdy for the initial patch. See #29820 Built from https://develop.svn.wordpress.org/trunk@31345 git-svn-id: http://core.svn.wordpress.org/trunk@31326 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-06 00:34:21 +00:00
Gary Pendergast	27aa3e92d7	Shiny Updates: If the current user is not allowed to install/update plugins, we should return a JSON error, so it can be used by the JS handlers. See #29820 Built from https://develop.svn.wordpress.org/trunk@31335 git-svn-id: http://core.svn.wordpress.org/trunk@31316 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-05 06:16:23 +00:00
Gary Pendergast	b7926a518a	Shiny Updates: Add capability checks to the ajax callbacks, to ensure the current user is allowed to install/update plugins. See #29820 Built from https://develop.svn.wordpress.org/trunk@31334 git-svn-id: http://core.svn.wordpress.org/trunk@31315 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-05 06:05:22 +00:00
Gary Pendergast	9c69213f2b	Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page. This also includes JS architecture that can be expanded to support theme, core and language pack updates. Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture See #29820 Built from https://develop.svn.wordpress.org/trunk@31333 git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-05 04:19:23 +00:00
Helen Hou-Sandí	62e65c3a35	Accessibility: remove remaining instances of accesskey. It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve. props afercia. fixes #29715. Built from https://develop.svn.wordpress.org/trunk@31331 git-svn-id: http://core.svn.wordpress.org/trunk@31312 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-04 03:46:24 +00:00
Dion Hulse	e8f032c747	WP_Upgrader: Remove references to non-existant variables that have never existed. Props jdgrimes. Fixes #29087 Built from https://develop.svn.wordpress.org/trunk@31327 git-svn-id: http://core.svn.wordpress.org/trunk@31308 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-03 06:18:24 +00:00
Dion Hulse	92cb5936f1	Remove an unused parameter on install_plugins_upload(). Props michalzuber. Fixes #28964 Built from https://develop.svn.wordpress.org/trunk@31326 git-svn-id: http://core.svn.wordpress.org/trunk@31307 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-03 06:14:22 +00:00
Boone Gorges	eec82f9330	In `get_sample_permalink()`, override 'future' status before generating permalink. In [31114], `get_permalink()` was modified to prevent pretty permalinks from being generated for posts with the 'future' post status. This inadvertently broke the pretty permalink preview for scheduled posts. The fix is to include the 'future' status in the list of statuses that `get_sample_permalink()` fakes as 'publish' before it fetches a permalink. Props DrewAPicture. Fixes #30910. Built from https://develop.svn.wordpress.org/trunk@31323 git-svn-id: http://core.svn.wordpress.org/trunk@31304 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-02-02 16:50:22 +00:00
Boone Gorges	f345a72c58	Prevent terms in a show_in_quick_edit=false taxonomy from being updated by a faked AJAX request. The UI for these taxonomies was hidden in [31308], but it remained possible to send a direct POST request to the `inline-edit` endpoint to bypass the restriction. The current changeset fixes this. Props meloniq. Fixes #26948. Built from https://develop.svn.wordpress.org/trunk@31313 git-svn-id: http://core.svn.wordpress.org/trunk@31294 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-31 19:38:24 +00:00
Boone Gorges	e4f8d5e0bc	Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases. See #26948. Built from https://develop.svn.wordpress.org/trunk@31308 git-svn-id: http://core.svn.wordpress.org/trunk@31289 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-30 19:29:22 +00:00
Boone Gorges	abce542e5f	Introduce 'show_in_quick_edit' parameter for `register_taxonomy()`. Setting 'show_in_quick_edit' to false when registering a custom taxonomy will hide the taxonomy when editing posts using Quick Edit. The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered on a finer scale, as when you want a given taxonomy to be hidden for one post type but not for others. Props hlashbrooke. Fixes #26948. Built from https://develop.svn.wordpress.org/trunk@31307 git-svn-id: http://core.svn.wordpress.org/trunk@31288 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-30 19:18:23 +00:00
Sergey Biryukov	b05014805f	Don't display the Help tab reference in Page Attributes meta box if Help tab was removed. props bananastalktome. fixes #31164. Built from https://develop.svn.wordpress.org/trunk@31303 git-svn-id: http://core.svn.wordpress.org/trunk@31284 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-30 15:34:24 +00:00
Sergey Biryukov	5ac0568ee3	Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors. props tomdxw. fixes #30927. Built from https://develop.svn.wordpress.org/trunk@31300 git-svn-id: http://core.svn.wordpress.org/trunk@31281 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-29 21:15:22 +00:00
Drew Jaynes	0f20ecca9c	Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/taxonomy.php. Also adds a few missing parameter descriptions. Props ipm-frommen. See #31008. Built from https://develop.svn.wordpress.org/trunk@31293 git-svn-id: http://core.svn.wordpress.org/trunk@31274 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-29 11:34:22 +00:00
Drew Jaynes	f3033f34c6	Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/post.php Props ipm-frommen. See #31008. Built from https://develop.svn.wordpress.org/trunk@31292 git-svn-id: http://core.svn.wordpress.org/trunk@31273 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-29 11:32:22 +00:00
Drew Jaynes	d95586e943	Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php. Also generally improve existing parameter, return, and other documentation in various function DocBlocks. Props morganestes. Fixes #30825. Built from https://develop.svn.wordpress.org/trunk@31246 git-svn-id: http://core.svn.wordpress.org/trunk@31227 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-19 09:15:22 +00:00
Drew Jaynes	d41e669efe	Ensure the correct list of default tabs for the Plugin Install screen are documented. Props stevenkword. Fixes #31017. Built from https://develop.svn.wordpress.org/trunk@31244 git-svn-id: http://core.svn.wordpress.org/trunk@31225 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-19 08:44:22 +00:00
Sergey Biryukov	768624cb99	Use the site's local time to create the first post during installation. props extendwings. fixes #29296. Built from https://develop.svn.wordpress.org/trunk@31225 git-svn-id: http://core.svn.wordpress.org/trunk@31206 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-17 10:07:23 +00:00
Scott Taylor	02a1f35ac8	Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions: * In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`. * When calling `submit_button()` with no `$name`, pass empty string instead of `false`. * The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`. * In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int. See #30799. Built from https://develop.svn.wordpress.org/trunk@31220 git-svn-id: http://core.svn.wordpress.org/trunk@31201 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 22:51:21 +00:00
Scott Taylor	eeda68bbda	Fix some erroneous `@param` annotations. See #30799. Built from https://develop.svn.wordpress.org/trunk@31219 git-svn-id: http://core.svn.wordpress.org/trunk@31200 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 22:44:25 +00:00
Scott Taylor	0f6d0b84d1	Remove unused local vars in `delete_plugins()`, `delete_theme()`, `WP_Date_Query->validate_date_values()`, `global_terms()`, and `WP_Text_Diff_Renderer_Table->_changed()`. This will clear out the "Unused Code" label in the next Scrutinizer report. See #30799. Built from https://develop.svn.wordpress.org/trunk@31217 git-svn-id: http://core.svn.wordpress.org/trunk@31198 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 21:19:22 +00:00
Scott Taylor	7c5038feb6	Calling `->chown()` and `->chgrp()` in `WP_Filesystem_ftpsockets` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class. See #30799. Built from https://develop.svn.wordpress.org/trunk@31216 git-svn-id: http://core.svn.wordpress.org/trunk@31197 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 21:10:23 +00:00
Scott Taylor	6fa7021d62	Calling `->chown()` and `->chgrp()` in `WP_Filesystem_FTPext` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class. See #30799. Built from https://develop.svn.wordpress.org/trunk@31215 git-svn-id: http://core.svn.wordpress.org/trunk@31196 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 21:07:24 +00:00
Scott Taylor	b8dd1f9c69	By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors. There are plenty of other kinds of errors, but this label will be cleared out. See #30799. Built from https://develop.svn.wordpress.org/trunk@31213 git-svn-id: http://core.svn.wordpress.org/trunk@31194 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 19:13:23 +00:00
Scott Taylor	bc55996a0b	`@param` cleanup: * `get_metadata()` will return literally anything, needs to be `mixed` * `wp()` and `WP_Query::__construct()` no longer just take a query string * Clarify a few others See #30799. Built from https://develop.svn.wordpress.org/trunk@31212 git-svn-id: http://core.svn.wordpress.org/trunk@31193 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 19:03:23 +00:00
Scott Taylor	cde4c83091	[31210] broke Supportflow on dotorg, which declares these methods as `protected`. Switch to `protected` for the noop methods. The subclasses can make them more visible using `public`. See #30799. Built from https://develop.svn.wordpress.org/trunk@31211 git-svn-id: http://core.svn.wordpress.org/trunk@31192 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 18:37:24 +00:00
Scott Taylor	3fb283db0a	Add 2 noop methods to `WP_List_Table`: `->column_default()` and `->column_cb()`. `WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class. These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not. See #30799. Built from https://develop.svn.wordpress.org/trunk@31210 git-svn-id: http://core.svn.wordpress.org/trunk@31191 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 17:42:22 +00:00
Scott Taylor	895794f74d	In `WP_Filesystem_Base` subclasses that set `$wp_base`, remove this dead code. Unused since [8009] - "Make WP_Filesystem work with new directory constants" There is currently no declared field and no `@property` annotation. See #30799. Built from https://develop.svn.wordpress.org/trunk@31209 git-svn-id: http://core.svn.wordpress.org/trunk@31190 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 17:23:22 +00:00
Scott Taylor	b29a20b90a	`WP_Filesystem_Base` should declare `$errors` and `$options` as fields for use by subclasses. See #30799. Built from https://develop.svn.wordpress.org/trunk@31208 git-svn-id: http://core.svn.wordpress.org/trunk@31189 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 17:10:43 +00:00
Scott Taylor	60c285aa22	In `wp_ajax_parse_media_shortcode()`, don't require a global `$post` for all passed shortcodes. `embed` is the only shortcode that requires a post ID. This will allow MCE views to work for `playlist`, `audio`, and `video` outside of the Edit Post screen. See #30835. Built from https://develop.svn.wordpress.org/trunk@31201 git-svn-id: http://core.svn.wordpress.org/trunk@31182 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 05:19:22 +00:00
Scott Taylor	7f8b548df1	In HTML5, the `action` attribute is no longer required. Remove this attribute when empty. The admin HTML is served with the HTML5 doctype. "The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action Props voldemortensen. Fixes #30126. Built from https://develop.svn.wordpress.org/trunk@31200 git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 04:16:24 +00:00
Scott Taylor	fe6b5983df	In PHP 5.0.0, `is_a()` became deprecated in favour of the `instanceof` operator. Calling `is_a()` would result in an `E_STRICT` warning. In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings. To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls. `instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`. Props markoheijnen, wonderboymusic. Fixes #25672. Built from https://develop.svn.wordpress.org/trunk@31188 git-svn-id: http://core.svn.wordpress.org/trunk@31169 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 01:06:24 +00:00
Scott Taylor	6704875855	Replace the 3 remaining occurrences of `wpspin` GIF with `spinner`. Props avryl. Fixes #27482. Built from https://develop.svn.wordpress.org/trunk@31187 git-svn-id: http://core.svn.wordpress.org/trunk@31168 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-16 00:33:22 +00:00
Helen Hou-Sandí	62a197d6bf	List tables: Use CSS :nth-child() selectors for zebra striping. Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping. There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation. fixes #30981 and #26060. see #25060. Built from https://develop.svn.wordpress.org/trunk@31181 git-svn-id: http://core.svn.wordpress.org/trunk@31162 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-14 22:14:22 +00:00
Scott Taylor	b51593763a	`WP_Themes_List_Table` accesses `$_pagination_args` from the parent class. Switch `$_pagination_args` to `protected` in `WP_List_Table`. See #30891. Built from https://develop.svn.wordpress.org/trunk@31167 git-svn-id: http://core.svn.wordpress.org/trunk@31148 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 16:26:21 +00:00
Scott Taylor	4f6de09a5b	Add a `private` field to `WP_Terms_List_Table`, `$level`. See #30891. Built from https://develop.svn.wordpress.org/trunk@31166 git-svn-id: http://core.svn.wordpress.org/trunk@31147 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 16:23:22 +00:00
Scott Taylor	194932fd6b	Add a `private` field to `WP_Posts_List_Table`, `$is_trash`. See #30891. Built from https://develop.svn.wordpress.org/trunk@31165 git-svn-id: http://core.svn.wordpress.org/trunk@31146 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 16:22:22 +00:00
Scott Taylor	71f9bc3f42	Add a `private` field to `WP_Plugin_Install_List_Table`, `$error`. See #30891. Built from https://develop.svn.wordpress.org/trunk@31164 git-svn-id: http://core.svn.wordpress.org/trunk@31145 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 16:19:22 +00:00
Scott Taylor	91312e71cd	In lieu of refactoring, add a `private` field to `WP_MS_Themes_List_Table`, `$has_items`. Ideally, this class would overload `->has_items()` and not set a `private` field. See #30891. Built from https://develop.svn.wordpress.org/trunk@31163 git-svn-id: http://core.svn.wordpress.org/trunk@31144 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 16:17:22 +00:00
Scott Taylor	86c0f63739	Add 2 `private` fields to `WP_Media_List_Table`, `$detached` and `$is_trash`. See #30891. Built from https://develop.svn.wordpress.org/trunk@31162 git-svn-id: http://core.svn.wordpress.org/trunk@31143 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 16:08:21 +00:00
Scott Taylor	df09597a65	After [31146], properly declare `$user_can` as a `private` field in `WP_Comments_List_Table`. See #30891. Built from https://develop.svn.wordpress.org/trunk@31161 git-svn-id: http://core.svn.wordpress.org/trunk@31142 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 16:02:24 +00:00
Dion Hulse	af92025162	More concise documentation for wp_install_maybe_enable_pretty_permalinks() See #6481. Props ericlewis. Built from https://develop.svn.wordpress.org/trunk@31160 git-svn-id: http://core.svn.wordpress.org/trunk@31141 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 04:33:23 +00:00
Dion Hulse	a114d0929b	The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. See #6481. Props nacin, valendesigns Built from https://develop.svn.wordpress.org/trunk@31159 git-svn-id: http://core.svn.wordpress.org/trunk@31140 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-12 04:31:23 +00:00
Scott Taylor	e6fc90f973	In `WP_List_Table`, only call magic method internals again whitelists of properties and methods, `$compat_fields` and `$compat_methods`. See #30891. Built from https://develop.svn.wordpress.org/trunk@31146 git-svn-id: http://core.svn.wordpress.org/trunk@31127 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-11 22:20:22 +00:00
Scott Taylor	2749e46178	In `WP_Filesystem_Base`, make the only `private` member, `$cache`, `public` and remove magic methods. `$cache` was always `public` until [28487], has been essentially `public` via a magic method since. See #30891. Built from https://develop.svn.wordpress.org/trunk@31145 git-svn-id: http://core.svn.wordpress.org/trunk@31126 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-11 22:04:22 +00:00
Boone Gorges	5c0ddb8602	Default `$parent` in `category_exists()` should default to null rather than 0. [29863] made the corresponding change in `term_exists()`. Failure to change the default value in `category_exists()` meant that an unspecified value for `$parent` would limit results to top-level categories. Includes unit tests and corrected function documentation. Props hissy. Fixes #30975 for trunk. Built from https://develop.svn.wordpress.org/trunk@31140 git-svn-id: http://core.svn.wordpress.org/trunk@31121 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-11 01:26:27 +00:00
Scott Taylor	5547115dc2	Fix some `@param` docs that have chars too close them. Add `@property` annotations to `WP_User` and `WP_Post`. Remove erroneous `@param`s from image editor class methods. Officially add the property `$_column_headers` to `WP_List_Table`. See #30799. Built from https://develop.svn.wordpress.org/trunk@31127 git-svn-id: http://core.svn.wordpress.org/trunk@31108 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-10 06:57:22 +00:00
Scott Taylor	0a511680f4	Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded. See #30799. Built from https://develop.svn.wordpress.org/trunk@31126 git-svn-id: http://core.svn.wordpress.org/trunk@31107 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-10 06:54:23 +00:00
Scott Taylor	da99d29a59	Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. See #30799. Built from https://develop.svn.wordpress.org/trunk@31125 git-svn-id: http://core.svn.wordpress.org/trunk@31106 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-10 06:13:22 +00:00
Scott Taylor	1b3f91f500	Declare `$wp_version`, `$required_php_version`, and `$required_mysql_version` as globals in install and upgrade admin files. See #30799. Built from https://develop.svn.wordpress.org/trunk@31124 git-svn-id: http://core.svn.wordpress.org/trunk@31105 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-10 05:57:22 +00:00
Scott Taylor	1bac6fb886	In `wp-admin/includes/revision.php`, `$post->modified` is a coding error. It should be `$post->post_modified`. See #30799. Built from https://develop.svn.wordpress.org/trunk@31123 git-svn-id: http://core.svn.wordpress.org/trunk@31104 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-10 05:50:22 +00:00
Scott Taylor	d6ce5dd553	`WP_Upgrader` will take any "skin" that is passed to it, and set `->skin` via composition. The default type of `->skin` is `WP_Upgrader_Skin`, which doesn't have methods declared for `->bulk_header()` and `->bulk_footer()`. Add noop methods to `WP_Upgrader_Skin`. See #30799. Built from https://develop.svn.wordpress.org/trunk@31122 git-svn-id: http://core.svn.wordpress.org/trunk@31103 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-10 05:42:22 +00:00
Scott Taylor	afd09f1f04	In `wp_ajax_upload_attachment()`, `wp_check_filetype_and_ext()` doesn't need a 3rd param - it already defaults to `null`. Passing `false` would fail a strict check See #30799. Built from https://develop.svn.wordpress.org/trunk@31119 git-svn-id: http://core.svn.wordpress.org/trunk@31100 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-10 04:55:25 +00:00
Sergey Biryukov	7b04e6d4f4	Add variable type for sync_category_tag_slugs() parameters. props tillkruess. fixes #30718. Built from https://develop.svn.wordpress.org/trunk@31113 git-svn-id: http://core.svn.wordpress.org/trunk@31094 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-09 11:19:22 +00:00
Sergey Biryukov	e214fce67f	Use localized format for Last Updated date in plugin details modal, for consistency with [31055]. see #30717. Built from https://develop.svn.wordpress.org/trunk@31110 git-svn-id: http://core.svn.wordpress.org/trunk@31091 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-09 06:21:22 +00:00
Sergey Biryukov	d5d0b367ab	Improve documentation for media_handle_upload(). props ericlewis. fixes #30962. Built from https://develop.svn.wordpress.org/trunk@31109 git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-09 05:05:23 +00:00
Scott Taylor	8ee598169f	After [31105], don't ditch the `isset()` calls for BC. Declare `$page_hook` as `null` so it is initialized for all execution paths but will still fail `isset()` checks. Fixes #30958. Built from https://develop.svn.wordpress.org/trunk@31106 git-svn-id: http://core.svn.wordpress.org/trunk@31087 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 22:52:22 +00:00
Scott Taylor	60e1dd409b	Properly declare `$hook_suffix`, `$plugin_page`, `$typenow`, and `$taxnow` as globals in `wp-admin/admin.php`. Fixes #30958. Built from https://develop.svn.wordpress.org/trunk@31105 git-svn-id: http://core.svn.wordpress.org/trunk@31086 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 22:15:24 +00:00
Scott Taylor	e4b6265c7a	Overriding methods should do more than simply call the same method in the super class. See #30799. Built from https://develop.svn.wordpress.org/trunk@31101 git-svn-id: http://core.svn.wordpress.org/trunk@31082 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 21:20:22 +00:00
Scott Taylor	4a1ad9acec	Jump statements should not be followed by other statements (there were 5 lingering). See #30799. Built from https://develop.svn.wordpress.org/trunk@31100 git-svn-id: http://core.svn.wordpress.org/trunk@31081 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 21:15:22 +00:00
Scott Taylor	4feecb922c	Use `&&` instead of `and` in the 3 places where `and` was used. See #30799. Built from https://develop.svn.wordpress.org/trunk@31099 git-svn-id: http://core.svn.wordpress.org/trunk@31080 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 21:12:22 +00:00
Scott Taylor	383a5c6c24	In `wp-includes/plugin.php`, collapse 3 `else-newline-tab-if` statements. See #30799. Built from https://develop.svn.wordpress.org/trunk@31091 git-svn-id: http://core.svn.wordpress.org/trunk@31072 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 07:13:24 +00:00
Scott Taylor	60b0cd7943	The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words. This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. See #30799. Built from https://develop.svn.wordpress.org/trunk@31090 git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 07:05:25 +00:00
Dion Hulse	a4ed093250	Enable Pretty Permalinks for new sites during install if the server supports it. See #6481, Props valendesigns, DrewAPicture & ericlewis Built from https://develop.svn.wordpress.org/trunk@31089 git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 06:47:23 +00:00
Scott Taylor	ac4e67b82e	Perl-style comments should not be used See #30799. Built from https://develop.svn.wordpress.org/trunk@31079 git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 05:52:24 +00:00
Scott Taylor	e029005847	Access Modifiers: * In `WP_Plugin_Install_List_Table`, use `public` instead of `var` * In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public` * In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public` * In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`. * In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure` See #30799. Built from https://develop.svn.wordpress.org/trunk@31078 git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 05:44:23 +00:00
Scott Taylor	ff98cfcf45	Pinking Shears. See #30799. Built from https://develop.svn.wordpress.org/trunk@31077 git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 05:03:23 +00:00
Sergey Biryukov	9b0e279e82	In dashboard activity widget, display a front-end link if the user cannot edit the post. props UaMV, DrewAPicture. fixes #29025. Built from https://develop.svn.wordpress.org/trunk@31075 git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-08 00:26:22 +00:00
Sergey Biryukov	f2b5ac8ef1	Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices. props ocean90. fixes #30827 for trunk. Built from https://develop.svn.wordpress.org/trunk@31074 git-svn-id: http://core.svn.wordpress.org/trunk@31055 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-07 23:43:24 +00:00
Sergey Biryukov	f601e45055	TinyMCE: Remove dashicon-no-alt.png, unused since [30694]. props kpdesign, MattyRob. fixes #30791 for trunk. Built from https://develop.svn.wordpress.org/trunk@31073 git-svn-id: http://core.svn.wordpress.org/trunk@31054 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-07 23:32:22 +00:00
Andrew Ozz	00ff6675a2	Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167 . Built from https://develop.svn.wordpress.org/trunk@31070 git-svn-id: http://core.svn.wordpress.org/trunk@31051 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-07 22:48:22 +00:00
Sergey Biryukov	483e7a36d7	Use localized format for Last Updated date on Add Plugins screen. props tyxla. fixes #30717. Built from https://develop.svn.wordpress.org/trunk@31055 git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-06 01:03:23 +00:00
Scott Taylor	a9302b2e36	If `IMAGE_EDIT_OVERWRITE` is defined as `true`, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical). Props hew. Fixes #30394. Built from https://develop.svn.wordpress.org/trunk@31043 git-svn-id: http://core.svn.wordpress.org/trunk@31024 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-04 02:52:24 +00:00
Scott Taylor	f79eb196df	Improve the handling of comma-separated mime-types in `wp_match_mime_types()`, particularly as pertains to the mime-type selector on the Media list table screen. Props mdgl. Fixes #30788. Built from https://develop.svn.wordpress.org/trunk@31042 git-svn-id: http://core.svn.wordpress.org/trunk@31023 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-04 02:32:22 +00:00
Scott Taylor	c5f9a7c26a	Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library. Fixes #30584. Built from https://develop.svn.wordpress.org/trunk@31037 git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-03 08:24:22 +00:00
Scott Taylor	190165cb32	Use the `'not_found'` label when there are no items for a taxonomy in the terms list table. Props SergeyBiryukov. Fixes #30586. Built from https://develop.svn.wordpress.org/trunk@31035 git-svn-id: http://core.svn.wordpress.org/trunk@31016 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-03 06:20:21 +00:00
Scott Taylor	af0e5cc851	Inline `<script>`s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need `CDATA` comments. Props tw2113 for the initial patch. See #18788. Built from https://develop.svn.wordpress.org/trunk@31034 git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-03 05:46:25 +00:00
Scott Taylor	618c5b4333	When outputting JS with a `Content-Type` header: `text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329. Props sergej.mueller. Fixes #29196. Built from https://develop.svn.wordpress.org/trunk@31029 git-svn-id: http://core.svn.wordpress.org/trunk@31010 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-03 02:57:21 +00:00
Scott Taylor	5e4941023b	`WP_List_Table`'s constructor registers an `'admin_footer'` callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when `wp_comment_reply()` invokes the class constructor without checking for the existing instance via the `$wp_list_table` global. We shall check the `$wp_list_table` global in `wp_comment_reply()`. Props sorich87. Fixes #17413. Built from https://develop.svn.wordpress.org/trunk@31019 git-svn-id: http://core.svn.wordpress.org/trunk@31000 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2015-01-01 19:55:35 +00:00
Scott Taylor	952a5c9971	Support chromeless Vimeo via MEjs: * Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops! * Add `Froogaloop` to `js/mediaelement` scripts for Vimeo * Check for Vimeo in the same locations that YouTube is checked * Dynamically load Froogaloop script in admin when editing a TinyMCE view * Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream): `6f9a78e008/src/js/me-shim.js (L631)` Fixes #29267. Built from https://develop.svn.wordpress.org/trunk@31016 git-svn-id: http://core.svn.wordpress.org/trunk@30997 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-31 20:41:24 +00:00
Andrew Nacin	bc60e63518	Use correct function name in docs for get_plugin_data(). props eliorivero. fixes #30699. Built from https://develop.svn.wordpress.org/trunk@31008 git-svn-id: http://core.svn.wordpress.org/trunk@30989 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-31 08:08:22 +00:00
Boone Gorges	95dba4c8c0	When no plugins are active, return an empty array from `validate_active_plugins()`. This creates parity with the behavior of the function when plugins are active, but none are invalid. It also makes it possible to write unit tests for the function. Props sgrant. Fixes #30860. Built from https://develop.svn.wordpress.org/trunk@31003 git-svn-id: http://core.svn.wordpress.org/trunk@30984 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-30 19:31:22 +00:00
Scott Taylor	bc1341628f	Comment List Tables: * Declare `$extra_items` property * Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class. * `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter. See #30799. Built from https://develop.svn.wordpress.org/trunk@30984 git-svn-id: http://core.svn.wordpress.org/trunk@30970 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-20 23:27:25 +00:00
Scott Taylor	786caa4d55	Correct the `@param` docs for arguments that are truthy/falsey. See #30799. Built from https://develop.svn.wordpress.org/trunk@30983 git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-20 23:04:23 +00:00
Scott Taylor	5eb5afac34	For clarity, initialize some arrays that previously were only assigned via short circuit in loops. See #30799. Built from https://develop.svn.wordpress.org/trunk@30982 git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-20 22:47:22 +00:00
Scott Taylor	2dbd0d0a8f	In `image_size_input_fields()`: * Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops * Most of this function was tabbed twice, instead of once See #30799. Built from https://develop.svn.wordpress.org/trunk@30981 git-svn-id: http://core.svn.wordpress.org/trunk@30967 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-20 22:19:24 +00:00
Scott Taylor	f19bec8754	In `wp_import_handle_upload()`: `$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array. See #30799. Built from https://develop.svn.wordpress.org/trunk@30980 git-svn-id: http://core.svn.wordpress.org/trunk@30966 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-20 21:10:24 +00:00
Scott Taylor	42f5acd869	Improve some docs for `@param`. Remove an unneeded `$wpdb` global import. See #30799. Built from https://develop.svn.wordpress.org/trunk@30979 git-svn-id: http://core.svn.wordpress.org/trunk@30965 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-20 20:56:22 +00:00
Scott Taylor	574fabf2bc	Improve some `wp-admin/includes/class-wp-filesystem-*.php` docs for `@param`. See #30799. Built from https://develop.svn.wordpress.org/trunk@30978 git-svn-id: http://core.svn.wordpress.org/trunk@30964 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-20 20:40:23 +00:00
Dominik Schilling	eccd5a5eda	Pass locale to wordpress.org theme/plugin API. In the future this will be used to return localized plugin/theme info. see #30735. Built from https://develop.svn.wordpress.org/trunk@30944 git-svn-id: http://core.svn.wordpress.org/trunk@30933 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-16 22:39:22 +00:00
Andrew Nacin	8c3027c3c7	Call it 'Distraction-free writing mode' and update the help string. fixes #30657 . Built from https://develop.svn.wordpress.org/trunk@30890 git-svn-id: http://core.svn.wordpress.org/trunk@30880 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-16 10:07:23 +00:00
Andrew Nacin	7b015d507d	Update/add plugin recommendation strings. Update [30887], add a translation function to the Vine string. fixes #30337. see #30435. Built from https://develop.svn.wordpress.org/trunk@30889 git-svn-id: http://core.svn.wordpress.org/trunk@30879 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-16 10:06:24 +00:00
Andrew Nacin	23f4b0f62f	Updates to the 'Log out everywhere' implementation. * Include a message and a disabled button when you're only logged in at one location. * Avoid leaking the session token in HTML. * Simplify, simplify, simplify. see #30264. Built from https://develop.svn.wordpress.org/trunk@30888 git-svn-id: http://core.svn.wordpress.org/trunk@30878 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-16 09:15:23 +00:00
Dion Hulse	5661464d35	Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API. See #30245 Built from https://develop.svn.wordpress.org/trunk@30860 git-svn-id: http://core.svn.wordpress.org/trunk@30850 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-15 14:08:23 +00:00
Andrew Nacin	180c596d7b	Rename _wp_clear_update_cache() to wp_clean_update_cache(). This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private." wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear. see #30369. Built from https://develop.svn.wordpress.org/trunk@30856 git-svn-id: http://core.svn.wordpress.org/trunk@30846 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-15 08:55:22 +00:00
Andrew Ozz	bb67aa9d5a	Improve text for the DFW admin pointer. Remove the concatenation. Props kpdesign, ianmjones. See #30671. Built from https://develop.svn.wordpress.org/trunk@30837 git-svn-id: http://core.svn.wordpress.org/trunk@30827 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-12 22:12:22 +00:00
Andrew Ozz	0aa0016488	Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658 . Built from https://develop.svn.wordpress.org/trunk@30813 git-svn-id: http://core.svn.wordpress.org/trunk@30803 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-11 04:12:23 +00:00
Sergey Biryukov	0ef8e683f2	Revert [28948], which caused a regression. see #29573 for trunk. see #28350. Built from https://develop.svn.wordpress.org/trunk@30791 git-svn-id: http://core.svn.wordpress.org/trunk@30781 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-08 21:14:23 +00:00
Andrew Ozz	a445806c6f	Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337 . Built from https://develop.svn.wordpress.org/trunk@30782 git-svn-id: http://core.svn.wordpress.org/trunk@30772 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-07 23:40:24 +00:00
Andrew Ozz	ef0501e1bc	Better docs for `Plugin_Upgrader::deactivate_plugin_before_upgrade()`. Props DrewAPicture. Fixes #29088 . Built from https://develop.svn.wordpress.org/trunk@30762 git-svn-id: http://core.svn.wordpress.org/trunk@30752 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-07 01:19:24 +00:00
Andrew Ozz	1bb4b6a82b	Always return a value in `Plugin_Upgrader::deactivate_plugin_before_upgrade()`. Props jdgrimes. Fixes #29088 . Built from https://develop.svn.wordpress.org/trunk@30761 git-svn-id: http://core.svn.wordpress.org/trunk@30751 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-07 00:53:23 +00:00
Drew Jaynes	473ebca2af	Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in `WP_Upgrader`, `Plugin_Upgrader`, `Theme_Upgrader`, `Language_Pack_Upgrader`, `Core_Upgrader`, and `File_upload_Upgrader`. Props jdgrimes, DrewAPicture. See #29086. Built from https://develop.svn.wordpress.org/trunk@30758 git-svn-id: http://core.svn.wordpress.org/trunk@30748 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-07 00:26:22 +00:00
Drew Jaynes	cc4ac906dc	Fix a typo in the return description for `get_sample_permalink()`. Props TobiasBg. Fixes #30591. Built from https://develop.svn.wordpress.org/trunk@30755 git-svn-id: http://core.svn.wordpress.org/trunk@30745 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-06 21:46:23 +00:00
John Blackbourn	bdd00b3902	Improve various hook and filter docs so they are correctly parsed for the code reference. Fixes #30558 Props DrewAPicture Built from https://develop.svn.wordpress.org/trunk@30754 git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-06 21:32:24 +00:00
Drew Jaynes	23707b1ada	Convert various uses of `(optional)` in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP. The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis. Props coffee2code. Fixes #30591. Built from https://develop.svn.wordpress.org/trunk@30753 git-svn-id: http://core.svn.wordpress.org/trunk@30743 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-06 21:24:45 +00:00
Andrew Nacin	1cf7a49ffd	Adjust [29806] and revert [29807] to restore placeholder and email copy order. Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0. fixes #21089. Built from https://develop.svn.wordpress.org/trunk@30742 git-svn-id: http://core.svn.wordpress.org/trunk@30732 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-05 01:15:26 +00:00
John Blackbourn	543f408098	Correct the default value of the `show_split_view` argument for revisions so they are correctly displayed side by side ins tead of inline. Fixes #24908 Built from https://develop.svn.wordpress.org/trunk@30739 git-svn-id: http://core.svn.wordpress.org/trunk@30729 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-04 14:36:24 +00:00
Andrew Ozz	1bb20da03b	Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557 . Built from https://develop.svn.wordpress.org/trunk@30734 git-svn-id: http://core.svn.wordpress.org/trunk@30724 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-03 22:00:29 +00:00
Andrew Ozz	5299e95360	Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458 . Built from https://develop.svn.wordpress.org/trunk@30730 git-svn-id: http://core.svn.wordpress.org/trunk@30720 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-03 18:18:23 +00:00
Drew Jaynes	8df7115760	Use the correct hash notation syntax for the `WP_Filesystem_Base::dirlist()` DocBlock. See #28298. Built from https://develop.svn.wordpress.org/trunk@30722 git-svn-id: http://core.svn.wordpress.org/trunk@30712 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-03 10:11:22 +00:00
Andrew Ozz	04c2e80c03	Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557 . Built from https://develop.svn.wordpress.org/trunk@30718 git-svn-id: http://core.svn.wordpress.org/trunk@30708 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-02 23:23:23 +00:00
Andrew Ozz	71d0c1c977	Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458 . Built from https://develop.svn.wordpress.org/trunk@30717 git-svn-id: http://core.svn.wordpress.org/trunk@30707 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-02 23:11:24 +00:00
Andrew Ozz	f1dcfa9712	Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568 . Built from https://develop.svn.wordpress.org/trunk@30711 git-svn-id: http://core.svn.wordpress.org/trunk@30701 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-02 20:40:22 +00:00
Drew Jaynes	c4b9da857a	Using let's properly in inline comments lets us move on to more pressing matters of inline documentation. Props trepmal. Fixes #30570. Built from https://develop.svn.wordpress.org/trunk@30703 git-svn-id: http://core.svn.wordpress.org/trunk@30693 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-02 04:43:22 +00:00
John Blackbourn	6fcf4ed3c5	Prevent the deletion of a theme while it has an active child theme. Fixes #29580 Props karpstrucking, jesin Built from https://develop.svn.wordpress.org/trunk@30697 git-svn-id: http://core.svn.wordpress.org/trunk@30687 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-02 02:21:24 +00:00
Drew Jaynes	ad297dab6d	Correctly capitalize JavaScript throughout core docs. Fixes #30569. Built from https://develop.svn.wordpress.org/trunk@30695 git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-02 00:31:22 +00:00
Scott Taylor	37a23b2c73	Improve various `@param` docs. See #30224. Built from https://develop.svn.wordpress.org/trunk@30682 git-svn-id: http://core.svn.wordpress.org/trunk@30672 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-01 02:17:21 +00:00
Scott Taylor	2c32752abd	Improve various `@param` docs for `src/wp-admin/*`. See #30224. Built from https://develop.svn.wordpress.org/trunk@30680 git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-01 01:00:22 +00:00
Scott Taylor	65ab522a51	Improve various `@param` docs for List Tables. See #30224. Built from https://develop.svn.wordpress.org/trunk@30679 git-svn-id: http://core.svn.wordpress.org/trunk@30669 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-01 00:33:23 +00:00
Scott Taylor	da4c39480f	Improve various `@param` docs for `src/wp-admin/includes/class-wp-filesystem-*.php`. See #30224. Built from https://develop.svn.wordpress.org/trunk@30678 git-svn-id: http://core.svn.wordpress.org/trunk@30668 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-12-01 00:13:22 +00:00
Scott Taylor	67417897ec	Improve the `@param` docs for `src/wp-admin/includes/plugin.php`. See #30224. Built from https://develop.svn.wordpress.org/trunk@30668 git-svn-id: http://core.svn.wordpress.org/trunk@30658 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-30 22:23:23 +00:00
Scott Taylor	562ddb8316	Use `sanitize_mime_type()` instead of `urlencode()` when string-building `<option>` values in `->get_views()` for media list tables. `urlencode()` was introduced in [28553] via _duck and yours truly. Got weirder after [29625]. Props birgire. Fixes #30123. Built from https://develop.svn.wordpress.org/trunk@30661 git-svn-id: http://core.svn.wordpress.org/trunk@30651 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-30 20:23:23 +00:00
Drew Jaynes	78bb3e5ff5	Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/. Also adds a few inline `@see` cross-references as they apply. Affects DocBlocks for the following hooks: `views_{$this->screen->id}` * `bulk_actions-{$this->screen->id}` * `manage_{$this->screen->id}_sortable_columns` * `theme_action_links_$stylesheet` * `after_theme_row_$stylesheet` * `install_plugins_table_api_args_$tab` * `$prefix . plugin_action_links` * `after_plugin_row_$plugin_file` * `manage_taxonomies_for_{$post_type}_columns` * `manage_{$post_type}_posts_columns` * `manage_{$post->post_type}_posts_custom_column` * `{$taxonomy}_row_actions` * `manage_{$this->screen->taxonomy}_custom_column` * `install_themes_table_api_args_' . $tab` * `auto_update_ . $type` * `{$action}_prefilter` * `admin_head_{$content_func}` * `nav_menu_items_{$post_type_name}` * `activate_ . $plugin` * `deactivate_ . $plugin` * `edit_{$post_type}_per_page` * `postbox_classes_{$page}_{$id}` * `_wp_post_revision_field_$field` * `manage_{$screen->id}_columns` * `in_plugin_update_message-{$file}` * `in_theme_update_message-{$theme_key}` See #30552. Built from https://develop.svn.wordpress.org/trunk@30648 git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-30 11:28:24 +00:00
Drew Jaynes	3ceb75bd8e	Specify a type (array) for the `$post_data` parameter in the DocBlock for `wp_autosave()`. Props tillkruess. See #30508. Built from https://develop.svn.wordpress.org/trunk@30645 git-svn-id: http://core.svn.wordpress.org/trunk@30635 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-30 10:01:23 +00:00
Drew Jaynes	e4425165ff	Improve the inline documentation for `image_edit_apply_changes()`. Including: * Add a correct type (array) for the `$changes` parameter * Add the `@since` version * Add proper descriptions for both parameters and the return value. Props tillkruess for the initial patch. See #30508. Built from https://develop.svn.wordpress.org/trunk@30644 git-svn-id: http://core.svn.wordpress.org/trunk@30634 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-30 09:59:22 +00:00
Andrew Ozz	760e3e5fbd	Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass `$post_type` in the `wp_editor_expand` filter. See #30458 . Built from https://develop.svn.wordpress.org/trunk@30641 git-svn-id: http://core.svn.wordpress.org/trunk@30631 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-30 06:37:21 +00:00
Drew Jaynes	bb380687fa	Add missing DocBlocks for several functions in wp-admin/includes/ms.php. Props dustyf. See #30483. Built from https://develop.svn.wordpress.org/trunk@30630 git-svn-id: http://core.svn.wordpress.org/trunk@30620 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-30 05:06:23 +00:00
Drew Jaynes	3699ea4155	Use the correct type (integer) for the `$menu_id` parameter in the `wp_get_nav_menu_to_edit()` DocBlock. Also properly mark the parameter as optional and specify the default value. Props jaimieolmstead for the initial patch. Fixes #30540. Built from https://develop.svn.wordpress.org/trunk@30627 git-svn-id: http://core.svn.wordpress.org/trunk@30617 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-30 04:25:23 +00:00
Boone Gorges	c6e752b063	In `get_default_post_to_edit()`, let 'post_name' be passed to filter. Previously, it was being overridden after the default post had been inserted into the database, making it cumbersome to override with the 'wp_insert_post_data' filter. Props danielbachhuber. Fixes #29847. Built from https://develop.svn.wordpress.org/trunk@30626 git-svn-id: http://core.svn.wordpress.org/trunk@30616 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-29 19:26:23 +00:00
Drew Jaynes	4432dc752b	4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php. See #30469. Built from https://develop.svn.wordpress.org/trunk@30610 git-svn-id: http://core.svn.wordpress.org/trunk@30600 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2014-11-28 11:22:23 +00:00

... 3 4 5 6 7 ...

5409 Commits