Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-29 20:47:45 +01:00
Code Issues Projects Releases Wiki Activity
40,289 Commits 50 Branches 749 Tags 806 MiB
371f83cfd1
Commit Graph

13994 Commits

Author SHA1 Message Date
Sergey Biryukov
cc21760163 Twenty Nineteen: Make sure center-aligned images in columns do not break beyond the column boundaries. 
Props kjellr.
Fixes #47937.
Built from https://develop.svn.wordpress.org/trunk@45897


git-svn-id: http://core.svn.wordpress.org/trunk@45708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-26 19:01:55 +00:00
Sergey Biryukov
9dc2a432b1 Twenty Nineteen: Update style-rtl.css after [45773]. 
See #47850.
Built from https://develop.svn.wordpress.org/trunk@45896


git-svn-id: http://core.svn.wordpress.org/trunk@45707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-26 19:00:58 +00:00
Sergey Biryukov
baffd21844 Docs: Reference WP_Term_Query::__construct() in wp_list_categories() DocBlock for additional accepted arguments. 
Clarify that `wp_dropdown_categories()` always returns a string, regardless of the `echo` parameter.

See #47896, #47110.
Built from https://develop.svn.wordpress.org/trunk@45895


git-svn-id: http://core.svn.wordpress.org/trunk@45706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-26 17:00:55 +00:00
Boone Gorges
d1ac7170dc Taxonomy: Standardize docs for wp_list_categories(). 
Many of the parameters historically documented on this function are merely
passed through to `get_categories()` and its underlying functions. In order to
avoid unnecessary duplication of function arguments, we remove documentation of
these parameters, and replace it with reference to the wrapped functions.

Parameters that receive special treatment or are otherwise changed before
being passed through continue to be documented as part of `wp_list_categories()`.

Props audrasjb, itowhid06, birgire.
Fixes #47896.
Built from https://develop.svn.wordpress.org/trunk@45894


git-svn-id: http://core.svn.wordpress.org/trunk@45705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-26 15:24:55 +00:00
Boone Gorges
e0c83d76d1 Taxonomy: Fix unique-slug check for terms with parents. 
`wp_unique_term_slug()` appends numeric suffixes when the requested slug is
already in use by a sibling term. Changes introduced in [32837] inadvertently
caused this suffixing to be skipped in cases where the requested slug is
suffixed with the parent slug, so that it became possible to have two terms
`childslug-parentslug` underneath to the same `parentslug`. We fix this
regression by ensuring that the numeric-suffix routine runs in all cases.

Props yashar_hv, saskak, dlh.
Fixes #46431.
Built from https://develop.svn.wordpress.org/trunk@45893


git-svn-id: http://core.svn.wordpress.org/trunk@45704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-26 15:19:56 +00:00
Andrew Ozz
c5fed47367 Docs: Improve and update the description of multi_resize() to explain changes and expected use. 
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45892


git-svn-id: http://core.svn.wordpress.org/trunk@45703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-25 22:21:58 +00:00
Sergey Biryukov
b1847ef3e2 Menus: In wp_setup_nav_menu_item() and Walker_Nav_Menu_Edit::start_el(), check if the post or term associated with the menu item still exists to avoid a PHP notice. 
If the associated post or term no longer exists, mark the menu item as invalid.

Props mehulkaklotar, kamrankhorsandi, cristiano.zanca, SergeyBiryukov.
Fixes #31703.
Built from https://develop.svn.wordpress.org/trunk@45891


git-svn-id: http://core.svn.wordpress.org/trunk@45702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-25 21:32:59 +00:00
Sergey Biryukov
fe0b22cd67 Users: Adjust [45806] to make sure $all_userids is always defined. 
Props kbrownkd.
Fixes #47936.
Built from https://develop.svn.wordpress.org/trunk@45890


git-svn-id: http://core.svn.wordpress.org/trunk@45701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-25 20:03:57 +00:00
Sergey Biryukov
c896a0911e Site Health: Add timezone to Site Health Info page. 
Props justinahinon, sharaz, artisticasad, Rarst.
Fixes #47842.
Built from https://develop.svn.wordpress.org/trunk@45889


git-svn-id: http://core.svn.wordpress.org/trunk@45700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-24 19:37:57 +00:00
Boone Gorges
17d32ebc8f Taxonomy: Ensure consistency of hide_empty in term queries when taxonomy is excluded. 
When querying for terms in hierarchical categories using `hide_empty=true`,
results have historically included parent terms which are themselves
unattached to any objects (are "empty") but which have non-empty descendent
terms. Because this process involves walking the descendant tree, we avoid it
when we detect that the queried taxonomies are not hierarchical. (This
behavior was introduced in [5525].)

When the `taxonomy` parameter of `get_terms()` was made optional - see #35495,
[36614] - it affected the mechanism for avoiding unneccessary tree walks,
since there may not be any explicitly declared taxonomies to run through
`is_taxonomy_hierarchical()`. As a result, term queries excluding `taxonomy`
did not check descendants, and empty parents with non-empty children were not
included in `hide_empty` results.

We correct the behavior by crawling term descendants when the `taxonomy`
argument is absent, which means that we're querying for terms in all taxonomies.

Props smerriman.
Fixes #37728.
Built from https://develop.svn.wordpress.org/trunk@45888


git-svn-id: http://core.svn.wordpress.org/trunk@45699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-23 16:05:56 +00:00
Sergey Biryukov
9672302e04 Date/Time: Rewrite and simplify get_gmt_from_date(), get_date_from_gmt(), and iso8601_to_datetime() using wp_timezone(). 
Improve unit test coverage.

Props Rarst, goodevilgenius.
Fixes #31809.
Built from https://develop.svn.wordpress.org/trunk@45887


git-svn-id: http://core.svn.wordpress.org/trunk@45698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-23 11:03:56 +00:00
Sergey Biryukov
1aaf11947e Date/Time: Simplify the date comparing logic in WP_Community_Events::trim_events(). 
The Events API returns event date without timezone information, so trying to parse it into a timestamp and compare to a WP timestamp is pointless.

Props Rarst.
Fixes #47463.
Built from https://develop.svn.wordpress.org/trunk@45886


git-svn-id: http://core.svn.wordpress.org/trunk@45697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-23 02:15:55 +00:00
Gary Pendergast
601f5f7376 Build Tools: Pass the LOCAL_DIR environment variable through to the phpunit Docker container. 
This allows code running inside the container to know whether it's supposed to be running in `build` or `src`.

See #47767.


Built from https://develop.svn.wordpress.org/trunk@45885


git-svn-id: http://core.svn.wordpress.org/trunk@45696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-23 01:56:56 +00:00
Sergey Biryukov
6330f10b7d Date/Time: Revert unintended changes from [45882]. 
Props TimothyBlynJacobs.
See #25768.
Built from https://develop.svn.wordpress.org/trunk@45884


git-svn-id: http://core.svn.wordpress.org/trunk@45695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-23 01:16:53 +00:00
Sergey Biryukov
6e555f0c77 Date/Time: Introduce current_datetime() for better time operations. 
Returning a `DateTimeImmutable` representation of the current moment in time, this allows for a more flexible and reliable use than `current_time()` provides.

Props Rarst.
Fixes #47464.
Built from https://develop.svn.wordpress.org/trunk@45883


git-svn-id: http://core.svn.wordpress.org/trunk@45694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-23 01:12:55 +00:00
Sergey Biryukov
6f8e50c7f0 Date/Time: Rewrite and simplify date_i18n() using wp_timezone() to address multiple issues with certain date formats and timezones, while preserving some extra handling for legacy use cases. 
Improve unit test coverage.

Props Rarst, remcotolsma, raubvogel.
Fixes #25768.
Built from https://develop.svn.wordpress.org/trunk@45882


git-svn-id: http://core.svn.wordpress.org/trunk@45693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-23 00:57:56 +00:00
desrosj
e7c8b21e71 Coding Standards: Dynamic hooks should be named using interpolation not concatenation. 
Props arena, desrosj.
Fixes #47052.
Built from https://develop.svn.wordpress.org/trunk@45881


git-svn-id: http://core.svn.wordpress.org/trunk@45692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-22 19:08:55 +00:00
Sergey Biryukov
d309715a95 Coding Standards: Add missing break for the default case in wp_privacy_anonymize_data(). 
Props itowhid06.
Fixes #47921.
Built from https://develop.svn.wordpress.org/trunk@45877


git-svn-id: http://core.svn.wordpress.org/trunk@45688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-22 14:50:55 +00:00
Sergey Biryukov
8d919b09d4 Date/Time: Use wp_timezone() in WP_Date_Query::build_mysql_datetime() to address timezone issues. 
Improve unit test coverage.

Props Rarst, Biranit, birgire, jave.web, SergeyBiryukov.
Fixes #41782.
Built from https://develop.svn.wordpress.org/trunk@45876


git-svn-id: http://core.svn.wordpress.org/trunk@45687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-22 03:11:55 +00:00
Gary Pendergast
1f8563d8e7 Build Tools: Don't use git for package installs. 
While NPM supports installing packages from git locations, this requires `git` to be in the path, which won't necessarily be true, particularly on Windows.

We can download the release versions for these packages, instead.

Fixes #47916.


Built from https://develop.svn.wordpress.org/trunk@45875


git-svn-id: http://core.svn.wordpress.org/trunk@45686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-22 02:29:54 +00:00
Sergey Biryukov
ad7b2949ba Users: Adjust [45708] to make sure wp_update_user() does not issue a WP_Error if a single site was previously set up as Multisite and there's still a spam field in the user table. 
Add a unit test.

Props azaozz, SergeyBiryukov.
Fixes #45747.
Built from https://develop.svn.wordpress.org/trunk@45874


git-svn-id: http://core.svn.wordpress.org/trunk@45685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-22 01:53:55 +00:00
Sergey Biryukov
f6fc8025c4 Administration: Adjust [45814] to address a backward compatibility issue for plugins passing multiple CSS classes to add_settings_error(). 
Only add the `notice-` prefix for `error`, `success`, `warning`, `info` CSS classes, keep other classes as is.

Add unit tests for `settings_errors()`.

Props afercia, SergeyBiryukov.
Fixes #44941.
Built from https://develop.svn.wordpress.org/trunk@45873


git-svn-id: http://core.svn.wordpress.org/trunk@45684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-22 00:22:56 +00:00
Sergey Biryukov
36b4debdb4 Docs: Correct type for the $deprecated argument of get_terms(). 
Props itowhid06.
Fixes #47915.
Built from https://develop.svn.wordpress.org/trunk@45872


git-svn-id: http://core.svn.wordpress.org/trunk@45683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-21 16:27:55 +00:00
Sergey Biryukov
3d12c4b6d8 Docs: Fix typo in _wp_make_subsizes() DocBlock. 
Props itowhid06.
Fixes #47913. See #40439.
Built from https://develop.svn.wordpress.org/trunk@45871


git-svn-id: http://core.svn.wordpress.org/trunk@45682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-21 16:23:56 +00:00
Sergey Biryukov
f8fb93cd0d Customizer: Trim whitespace from custom link URLs. 
This complements a similar fix for the Menus screen in [45655].

Props donmhico, audrasjb.
Fixes #47888. See #47723.
Built from https://develop.svn.wordpress.org/trunk@45869


git-svn-id: http://core.svn.wordpress.org/trunk@45680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-21 00:27:57 +00:00
Sergey Biryukov
6b9ab1c5c5 Docs: Update @since tag for new JS functions and variables introduced in [45572]. 
Props garrett-eclipse.
See #47145.
Built from https://develop.svn.wordpress.org/trunk@45867


git-svn-id: http://core.svn.wordpress.org/trunk@45678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-20 22:54:55 +00:00
Sergey Biryukov
40d4037fa6 Twenty Seventeen: Fix tabs vs. spaces in [45764]. 
See #47414.
Built from https://develop.svn.wordpress.org/trunk@45863


git-svn-id: http://core.svn.wordpress.org/trunk@45674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-20 19:12:50 +00:00
Sergey Biryukov
18d991bfc0 Twenty Eleven: Fix tabs vs. spaces in [45763]. 
See #47414.
Built from https://develop.svn.wordpress.org/trunk@45862


git-svn-id: http://core.svn.wordpress.org/trunk@45673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-20 19:11:55 +00:00
Sergey Biryukov
561e17c1a4 Twenty Seventeen: Adjust [45764] to conform to CSS Coding Standards. 
See #47414.
Built from https://develop.svn.wordpress.org/trunk@45861


git-svn-id: http://core.svn.wordpress.org/trunk@45672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-20 19:07:49 +00:00
Sergey Biryukov
4a8c0b1498 Twenty Eleven: Adjust [45763] to conform to CSS Coding Standards. 
See #47414.
Built from https://develop.svn.wordpress.org/trunk@45860


git-svn-id: http://core.svn.wordpress.org/trunk@45671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-20 19:06:54 +00:00
Sergey Biryukov
9793494a2c Tests: Remove $wpdb global reference from test_wp_insert_user_with_empty_data(). 
See #47902.
Built from https://develop.svn.wordpress.org/trunk@45859


git-svn-id: http://core.svn.wordpress.org/trunk@45670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-20 17:28:56 +00:00
Sergey Biryukov
022de7321e Users: In wp_insert_user(), account for the wp_pre_insert_user_data filter returning empty data. 
Props juliobox, SergeyBiryukov.
Fixes #47902.
Built from https://develop.svn.wordpress.org/trunk@45858


git-svn-id: http://core.svn.wordpress.org/trunk@45669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-20 17:26:55 +00:00
Sergey Biryukov
bdb1811935 Date/Time: Fix race conditions in current_time() tests. 
* Restore default timezone before performing assertions to avoid affecting other tests in case of failure.
* Use delta comparison for timestamps to avoid race conditions.

Props SergeyBiryukov, desrosj.
Fixes #45821.
Built from https://develop.svn.wordpress.org/trunk@45857


git-svn-id: http://core.svn.wordpress.org/trunk@45668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-20 01:35:56 +00:00
Sergey Biryukov
349e9f56c1 Date/Time: Use PHP DateTime class API in current_time(). 
Only use the legacy WP timestamp approach (a sum of timestamp and timezone offset) for `timestamp` and `U` formats without the `$gmt` flag.

Otherwise, make sure the function returns correct local time for any format.

Props Rarst, jdgrimes.
Fixes #40653.
Built from https://develop.svn.wordpress.org/trunk@45856


git-svn-id: http://core.svn.wordpress.org/trunk@45667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 21:07:50 +00:00
Sergey Biryukov
26f8b67e35 Coding Standards: Use long array syntax in Tests_WP_Timezone::timezone_offset_provider(). 
Per https://make.wordpress.org/core/2019/07/12/php-coding-standards-changes/, arrays must be declared using long array syntax for clarity.

See #24730.
Built from https://develop.svn.wordpress.org/trunk@45855


git-svn-id: http://core.svn.wordpress.org/trunk@45666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 21:06:55 +00:00
Sergey Biryukov
46ca606114 Coding Standards: Use KB_IN_BYTES in get_file_data(). 
See #22405, #47632.
Built from https://develop.svn.wordpress.org/trunk@45854


git-svn-id: http://core.svn.wordpress.org/trunk@45665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 20:10:55 +00:00
Sergey Biryukov
4896dc64ee Date/Time: Introduce wp_timezone_string() and wp_timezone() for unified timezone retrieval. 
* `wp_timezone_string()` retrieves the timezone from current settings as a string. Uses the `timezone_string` option to get a proper timezone if available, otherwise falls back to an offset.
* `wp_timezone()` retrieves the timezone from current settings as a `DateTimeZone` object. Timezone can be based on a PHP timezone string or a `±HH:MM` offset.

Props Rarst, remcotolsma, johnjamesjacoby, rmccue.
Fixes #24730.
Built from https://develop.svn.wordpress.org/trunk@45853


git-svn-id: http://core.svn.wordpress.org/trunk@45664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 19:08:59 +00:00
Sergey Biryukov
82af4ad1c0 Coding Standards: Fix WPCS violations in [45851]. 
See #25347.
Built from https://develop.svn.wordpress.org/trunk@45852


git-svn-id: http://core.svn.wordpress.org/trunk@45663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 16:35:56 +00:00
Sergey Biryukov
a58eaa9424 Date/Time: In wp_insert_post(), when checking the post date to set future or publish status, use string comparison to work around far future dates (year 2038+) on 32-bit systems. 
Props Rarst, nofearinc.
Fixes #25347.
Built from https://develop.svn.wordpress.org/trunk@45851


git-svn-id: http://core.svn.wordpress.org/trunk@45662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 15:50:56 +00:00
Sergey Biryukov
3541c5d74c Date/Time: In WP_Date_Query::__construct(), return early if $date_query is empty or not an array. 
Props vishalkakadiya.
Fixes #47392.
Built from https://develop.svn.wordpress.org/trunk@45850


git-svn-id: http://core.svn.wordpress.org/trunk@45661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 15:17:56 +00:00
Gary Pendergast
7a92316fd8 Tests: Add an xdebug group for tests that require xdebug. 
These tests are now also run as their own part of the Travis build, to ensure performance of other tests isn't affected by the presence of xdebug.

Fixes #40532.


Built from https://develop.svn.wordpress.org/trunk@45827


git-svn-id: http://core.svn.wordpress.org/trunk@45638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-19 02:18:56 +00:00
Tammie Lister
a760ef9022 Multisite: Remove truncation to allow clearers identification of longer site names 
Previously the sites were truncated which meant longer names but with ending identifications were unable to be seen as different. This shows the full site name to allow easier understanding.

Props tferry, melinedo, afercia, jeremyfelt
Fixes: 47112

Built from https://develop.svn.wordpress.org/trunk@45826


git-svn-id: http://core.svn.wordpress.org/trunk@45637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-18 12:31:00 +00:00
Sergey Biryukov
d9954ed4cb Privacy: Add descriptions for sections in a personal data export file. 
Props garrett-eclipse, Venutius, karmatosed.
Fixes #45491.
Built from https://develop.svn.wordpress.org/trunk@45825


git-svn-id: http://core.svn.wordpress.org/trunk@45636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-18 02:07:57 +00:00
Sergey Biryukov
53f5b172ab Plugins: Adjust margin for plugin headings on "Add Plugins" screen to avoid overlapping with "Network Activate" button. 
Props justinahinon, chetan200891.
Fixes #47600.
Built from https://develop.svn.wordpress.org/trunk@45824


git-svn-id: http://core.svn.wordpress.org/trunk@45635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-17 14:33:56 +00:00
Sergey Biryukov
cde194a21e Pings/Trackbacks: In wp_xmlrpc_server::pingback_ping(), strip inline JS and CSS while trying to figure out the pingback context. 
Props david.binda.
Fixes #47283.
Built from https://develop.svn.wordpress.org/trunk@45823


git-svn-id: http://core.svn.wordpress.org/trunk@45634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-17 13:59:55 +00:00
Sergey Biryukov
aa8e2ff3ba Docs: Improve documentation for wp_set_auth_cookie() and related functions. 
Props arafat, SergeyBiryukov.
Fixes #47886.
Built from https://develop.svn.wordpress.org/trunk@45822


git-svn-id: http://core.svn.wordpress.org/trunk@45633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-17 13:23:55 +00:00
John Blackbourn
3796b7da13 Docs: Add a missing return type. 
See #47110

Built from https://develop.svn.wordpress.org/trunk@45821


git-svn-id: http://core.svn.wordpress.org/trunk@45632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-16 19:35:58 +00:00
K. Adam White
ca070acae3 Add @ticket annotations for [45812]. 
Props birgire.
See #43709.


Built from https://develop.svn.wordpress.org/trunk@45820


git-svn-id: http://core.svn.wordpress.org/trunk@45631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-16 03:33:55 +00:00
Gary Pendergast
ea64ea7c96 Build Tools: Improve local-env start behaviour under Docker Toolbox. 
Docker Toolbox requires port forwarding to be configured, but generates error when trying to forward a port that's already been taken.

This change removes clashing port forwarding rules before adding our own.

See #47767.


Built from https://develop.svn.wordpress.org/trunk@45819


git-svn-id: http://core.svn.wordpress.org/trunk@45630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-16 01:40:54 +00:00
Sergey Biryukov
be6bbe4b5d Administration: Replace legacy updated message type in add_settings_error() calls with success. 
See #44640.
Built from https://develop.svn.wordpress.org/trunk@45818


git-svn-id: http://core.svn.wordpress.org/trunk@45629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-16 00:39:55 +00:00
Sergey Biryukov
3f1186166d Taxonomy: In feed_links_extra() and get_the_archive_title(), make sure the queried taxonomy term exists before accessing its properties. 
Props donmhico, truchot, zaantar.
Fixes #46420.
Built from https://develop.svn.wordpress.org/trunk@45817


git-svn-id: http://core.svn.wordpress.org/trunk@45628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-16 00:24:54 +00:00
Sergey Biryukov
06d264d032 Coding Standards: In wlwmanifest_link(), use concatenation instead of commas for echo, for consistency with rsd_link() and the rest of core. 
See #47632.
Built from https://develop.svn.wordpress.org/trunk@45816


git-svn-id: http://core.svn.wordpress.org/trunk@45627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-16 00:21:56 +00:00
K. Adam White
34bc7ab089 REST API: Add @ticket annotation to test from [45813]. 
Props birgire.
See #42209.

Built from https://develop.svn.wordpress.org/trunk@45815


git-svn-id: http://core.svn.wordpress.org/trunk@45626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 23:09:54 +00:00
Sergey Biryukov
e5deae5e78 Administration: In add_settings_error(), add warning and info as possible values for message type. 
Account for these new values in `settings_errors()`, resulting in `notice-warning` and `notice-info` CSS classes.

Map legacy `error` and `updated` CSS classes to `notice-error` and `notice-success`.

Props donmhico, toddhalfpenny, flixos90, desrosj, javorszky, SergeyBiryukov.
Fixes #44640, #44941.
Built from https://develop.svn.wordpress.org/trunk@45814


git-svn-id: http://core.svn.wordpress.org/trunk@45625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 23:01:55 +00:00
K. Adam White
7eed5eff61 REST API: Always return post types list in taxonomies endpoint response as an array. 
Prevents a non-sequential post type array such as [ 0 => 'post', 2 => 'page' ] from being improperly converted to an object in the taxonomy endpoint's response JSON.

Props TimothyBlynJacobs, birgire, spectacula.
Fixes #42209.

Built from https://develop.svn.wordpress.org/trunk@45813


git-svn-id: http://core.svn.wordpress.org/trunk@45624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 22:12:55 +00:00
K. Adam White
00cb4c7dbd REST API: Prevent deletion of post revisions. 
Allowing the client to delete revisions breaks the "audit trail" functionality. This is not allowed in WordPress and shouldn't be allowed through the API.
While not recommended, a plugin may opt-in to the previous behavior by setting a custom 'delete_post' capability for the revisions post type.

Props dlh, danielbachhuber, TimothyBlynJacobs, azaozz, kadamwhite.
Fixes #43709.


Built from https://develop.svn.wordpress.org/trunk@45812


git-svn-id: http://core.svn.wordpress.org/trunk@45623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 22:01:55 +00:00
K. Adam White
5dbb64d0dd REST API: Cache results of get_item_schema on controller instances for performance. 
Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.

Built from https://develop.svn.wordpress.org/trunk@45811


git-svn-id: http://core.svn.wordpress.org/trunk@45622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 21:09:55 +00:00
K. Adam White
dbfa0c7ed4 REST API: Clarify arguments passed to rest route get & update callbacks. 
Update doc block argument definitions to clarify that the REST API always passes an array to the `get_callback` and always passes an entity object to the `update_callback`.

Props TimothyBlynJacobs, salzano.
Fixes #44432.


Built from https://develop.svn.wordpress.org/trunk@45810


git-svn-id: http://core.svn.wordpress.org/trunk@45621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 20:04:55 +00:00
K. Adam White
8dcc10693f REST API: Do not send response body if status is 204 or body is null. 
Status code 204 should indicate no response body is sent. Previously, a "null" string was sent, which MacOS Safari would try to parse as JSON and thereby fail to complete the request.

Props TimothyBlynJacobs, andizer, matthias.thiel.
Fixes #43691.


Built from https://develop.svn.wordpress.org/trunk@45809


git-svn-id: http://core.svn.wordpress.org/trunk@45620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 19:56:55 +00:00
K. Adam White
b75420443c REST API: Add test class file incorrectly omitted from [45807]. 
Props @TimothyBlynJacobs.
See #43392.

Built from https://develop.svn.wordpress.org/trunk@45808


git-svn-id: http://core.svn.wordpress.org/trunk@45619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 17:21:55 +00:00
K. Adam White
5b318f1dda REST API: Support 'object' and 'array' types in register_meta() schemas. 
Extends meta registration to support complex schema values, mirroring the functionality in the settings controller.
Error when trying to modify a meta key containing schema-nonconformant data.

Props @TimothyBlynJacobs, @birgire, @mnelson4, @flixos90.
Fixes #43392.


Built from https://develop.svn.wordpress.org/trunk@45807


git-svn-id: http://core.svn.wordpress.org/trunk@45618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 17:17:55 +00:00
Sergey Biryukov
ab0b860db9 Users: When deleting users, exclude the current user from the content existence check. 
The current user cannot be deleted, so the check is redundant in that context and should only be done for other users.

Props mt8.biz, SergeyBiryukov.
Fixes #47851.
Built from https://develop.svn.wordpress.org/trunk@45806


git-svn-id: http://core.svn.wordpress.org/trunk@45617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 13:06:55 +00:00
Gary Pendergast
7169586254 Schema: Add an index to wp_options.autoload. 
Most sites will be unaffected by this change, but those with a large number of rows in `wp_options`, only a small number of which have `autoload` set, will see a significant performance improvement.

Sites with a large number of rows in `wp_options`, with many of them having `autoload` set will unfortunately see a performance penalty on top of the already very slow queries they're running, but this should be the minority of cases.

Props DanBUK.
Fixes #24044.

Built from https://develop.svn.wordpress.org/trunk@45805


git-svn-id: http://core.svn.wordpress.org/trunk@45616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 07:13:55 +00:00
Sergey Biryukov
98ffc642a9 Networks and Sites: Trim site domain when creating a new site on Add New Site screen before further validation. 
Props dharmin16, jeremyfelt, aubreypwd.
Fixes #44808.
Built from https://develop.svn.wordpress.org/trunk@45804


git-svn-id: http://core.svn.wordpress.org/trunk@45615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 01:21:55 +00:00
Sergey Biryukov
d85ba82d8e Docs: Add missing @since tag for WP_Site_Health::has_late_cron(). 
See #47223.
Built from https://develop.svn.wordpress.org/trunk@45803


git-svn-id: http://core.svn.wordpress.org/trunk@45614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 00:42:55 +00:00
Peter Wilson
1d7ae02376 Site Health Check: New tests file missed in [45801]. 
Built from https://develop.svn.wordpress.org/trunk@45802


git-svn-id: http://core.svn.wordpress.org/trunk@45613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 00:37:56 +00:00
Peter Wilson
a56256d158 Site Health Check: Increase time allowance for cron checks. 
Introduces `WP_Site_Health::has_late_cron()` for late wp-cron jobs and extends the time allowance before a job is considered missed.

In a standard configuration using loopback requests, a job is considered late once past due and missed over five minutes past due.

Late and missed time frames are extended if `DISABLE_WP_CRON` is defined as `true` to allow for crontab tasks running less frequently. A job is considered late once it's 15 minutes past due and missed over one hour past due.

A file for site health unit tests has been introduced with tests for cron in critical, late and missed states.

Props rockfire, afragen, peterwilsoncc.
Fixes #47223.

Built from https://develop.svn.wordpress.org/trunk@45801


git-svn-id: http://core.svn.wordpress.org/trunk@45612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 00:35:55 +00:00
Gary Pendergast
b8c5530131 Build Tools: Change the PHPUnit Docker image's working directory to match the other images. 
Also, pass the `WP_MULTISITE` environment variable along to the container.

See #47767.


Built from https://develop.svn.wordpress.org/trunk@45800


git-svn-id: http://core.svn.wordpress.org/trunk@45611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-15 00:34:57 +00:00
Gary Pendergast
b473b2241e Build Tools: Run composer commands in a Docker container on Travis. 
This tidies up the `.travis.yml` file a little more.

See #47767.


Built from https://develop.svn.wordpress.org/trunk@45799


git-svn-id: http://core.svn.wordpress.org/trunk@45610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-14 23:12:55 +00:00
Sergey Biryukov
cc8e05df39 Widgets: Allow for short-circuiting widget output in the_widget() using the widget_display_callback filter, for consistency with output via a registered sidebar. 
Props MarcGuay, donmhico.
Fixes #34226.
Built from https://develop.svn.wordpress.org/trunk@45798


git-svn-id: http://core.svn.wordpress.org/trunk@45609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-14 23:03:55 +00:00
Sergey Biryukov
0e1343ee2b Docs: Correct type for query_var argument of register_taxonomy(). 
Props juiiee8487, audrasjb.
Fixes #47877.
Built from https://develop.svn.wordpress.org/trunk@45797


git-svn-id: http://core.svn.wordpress.org/trunk@45608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-14 17:47:55 +00:00
Sergey Biryukov
c03a0bea8d Posts, Post Types: In wp_trim_words() make sure the $num_words parameter is always an integer, as documented, to avoid a PHP warning. 
Props donmhico, pikamander2.
Fixes #47867.
Built from https://develop.svn.wordpress.org/trunk@45796


git-svn-id: http://core.svn.wordpress.org/trunk@45607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-14 17:18:55 +00:00
Sergey Biryukov
ae4087bca6 Users: Make wp_list_authors() unit tests more readable. 
See #23498.
Built from https://develop.svn.wordpress.org/trunk@45795


git-svn-id: http://core.svn.wordpress.org/trunk@45606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-14 15:36:57 +00:00
Sergey Biryukov
d6faa62338 Networks and Sites: Improve documentation and variable naming in switch_to_blog() and restore_current_blog(). 
In `switch_to_blog()`:

* Rename `$blog_id` to `$prev_blog_id` for clarity.
* Rename `$new_blog` to `$new_blog_id` for consistency.
* Pass `$prev_blog_id` as a second parameter to `switch_blog` action, instead of the duplicated `$new_blog_id`. This only clarifies documentation and does not affect functionality, since the values are equal in the context where the DocBlock is located.

In `restore_current_blog()`:

* Rename `$blog` to `$new_blog_id` for clarity.
* Rename `$blog_id` to `$prev_blog_id` for clarity.

Props ChriCo, jeremyfelt, SergeyBiryukov.
Fixes #45594.
Built from https://develop.svn.wordpress.org/trunk@45794


git-svn-id: http://core.svn.wordpress.org/trunk@45605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-14 14:29:56 +00:00
Sergey Biryukov
428a738f1d Plugins: Adjust the pause before running plugin search AJAX request on "Add Plugins" screen to allow more time for using browser's autocomplete. 
Props donmhico, apermo.
Fixes #46021.
Built from https://develop.svn.wordpress.org/trunk@45793


git-svn-id: http://core.svn.wordpress.org/trunk@45604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-14 02:02:56 +00:00
Sergey Biryukov
3ce3927dc1 Coding Standards: Fix JSHint error in [45790]. 
See #41545.
Built from https://develop.svn.wordpress.org/trunk@45792


git-svn-id: http://core.svn.wordpress.org/trunk@45603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-14 00:02:55 +00:00
Sergey Biryukov
4cf729f5a9 Site Health: Simplify the language in Status Health Info page introduction, add a link to Status page. 
Props birgire, mukesh27, subrataemfluence, leogermani.
Fixes #46946.
Built from https://develop.svn.wordpress.org/trunk@45791


git-svn-id: http://core.svn.wordpress.org/trunk@45602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-13 23:35:56 +00:00
Adam Silverstein
3e605d3852 Comments: enable typing cmd/ctrl-enter to submit comment forms. 
Add a key handler on the comment form that detects the cmd/ctrl-enter key press and submits the comment form. 

Props xyfi, Lindstromer, helen, splitti.
Fixes #41545.


Built from https://develop.svn.wordpress.org/trunk@45790


git-svn-id: http://core.svn.wordpress.org/trunk@45601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-13 21:26:56 +00:00
Andrew Ozz
400ed5add0 Remove trailing white space in upgrade.php. 
See #46349.
Built from https://develop.svn.wordpress.org/trunk@45789


git-svn-id: http://core.svn.wordpress.org/trunk@45600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-13 19:53:55 +00:00
Andrew Ozz
197b4a829b Admin email verification: 
- Add the `admin_email_lifespan` option when installing. Fixes a bug where the verification screen is shown right after installation.
- Reset the same option when upgrading and the user doing the DB upgrade is not an admin. This will ensure the email verification is shown next time an admin logs in.
- Use `site_url()` instead of `network_site_url()` for the form action. The latter seems needed only for password reset.

See #46349.
Built from https://develop.svn.wordpress.org/trunk@45788


git-svn-id: http://core.svn.wordpress.org/trunk@45599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-13 17:40:55 +00:00
Peter Wilson
dc2e7e716f Comments: Include post permalink in comment reply link. 
Include the post's permalink when generating reply links in `get_comment_reply_link()` to account for comments displayed on index and archive pages.

This reapplies [32786] which was inadvertently reverted in [42360].

Props justinahinon, donmhico.
See #33383.
Fixes #47174.

Built from https://develop.svn.wordpress.org/trunk@45787


git-svn-id: http://core.svn.wordpress.org/trunk@45598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-13 05:09:56 +00:00
K. Adam White
aa90dc4e8c Docs: Clarify custom-fields support requirement for viewing custom post meta in REST API. 
Fixes #47866.

Built from https://develop.svn.wordpress.org/trunk@45786


git-svn-id: http://core.svn.wordpress.org/trunk@45597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-13 01:51:56 +00:00
Gary Pendergast
28ad3662fc Build Tools: Remove the old docker-compose.yml file, now no longer used. 
See #47767.


Built from https://develop.svn.wordpress.org/trunk@45785


git-svn-id: http://core.svn.wordpress.org/trunk@45596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-12 09:22:55 +00:00
Gary Pendergast
20f833426a Build Tools: Add the docker-compose.yml file, missed in [45783]. 
See #47767.


Built from https://develop.svn.wordpress.org/trunk@45784


git-svn-id: http://core.svn.wordpress.org/trunk@45595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-12 09:21:56 +00:00
Gary Pendergast
74d03c4692 Build Tools: Miscellaneous local-env improvements. 
- Move the functionality for controlling `local-env` out of `package.json`, into JS scripts.
- Merge the `docker-compose` config files, and move it to the root directory. This allows `docker-compose.override.yml` to work for local overrides.
- Fix nginx redirecting to port 80 under some circumstances.
- `npm run env:install` now creates `wp-tests.config.php` for you.
- Cleaned up a bunch of cruft in `.travis.yml`.

See #47767.


Built from https://develop.svn.wordpress.org/trunk@45783


git-svn-id: http://core.svn.wordpress.org/trunk@45594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-12 08:29:55 +00:00
Sergey Biryukov
99f4ff2578 Site Health: Add database charset and collation information to debug info. 
Props sharaz, Clorith, SergeyBiryukov.
Fixes #47828.
Built from https://develop.svn.wordpress.org/trunk@45782


git-svn-id: http://core.svn.wordpress.org/trunk@45593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-12 01:54:57 +00:00
Sergey Biryukov
e6a4b884f5 Docs: Improve documentation for various feed link functions and filters. 
Props atachibana, SergeyBiryukov.
Fixes #47862.
Built from https://develop.svn.wordpress.org/trunk@45781


git-svn-id: http://core.svn.wordpress.org/trunk@45592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-11 17:21:57 +00:00
Sergey Biryukov
b7e7a5321b Docs: Improve documentation for get_last_updated(). 
Props atachibana.
Fixes #47861.
Built from https://develop.svn.wordpress.org/trunk@45780


git-svn-id: http://core.svn.wordpress.org/trunk@45591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-11 16:18:57 +00:00
Sergey Biryukov
80d153fb70 Docs: Improve documentation for get_page_by_title(). 
Props atachibana.
Fixes #47860.
Built from https://develop.svn.wordpress.org/trunk@45779


git-svn-id: http://core.svn.wordpress.org/trunk@45590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-11 12:42:56 +00:00
Sergey Biryukov
64290005f5 Docs: Document the show_split_view argument for wp_text_diff(). 
Convert `$args` array documentation to hash notation.

Props riddhiehta02, jeremyfelt, SergeyBiryukov.
Fixes #47224.
Built from https://develop.svn.wordpress.org/trunk@45778


git-svn-id: http://core.svn.wordpress.org/trunk@45589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-10 22:28:54 +00:00
whyisjake
1a9812d9b4 Widgets: Replace http with https in the link placeholder widget image 
The existing placeholder can make the user think that they must use http. We should encourage the use of https. 
Also, the block editor uses https for its placeholders. Let's add some consistency.

Props Chaton666, audrasjb, mukesh27.
Fixes #46320.

Built from https://develop.svn.wordpress.org/trunk@45777


git-svn-id: http://core.svn.wordpress.org/trunk@45588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-09 17:06:55 +00:00
Sergey Biryukov
6e060079ae Twenty Sixteen: Correct HelpHub URL in readme.txt. 
See #47771.
Built from https://develop.svn.wordpress.org/trunk@45776


git-svn-id: http://core.svn.wordpress.org/trunk@45587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-09 13:53:56 +00:00
Sergey Biryukov
092872c3fc Twenty Nineteen: Add missing Installation section to readme.txt, for consistency with other themes. 
See #47857.
Built from https://develop.svn.wordpress.org/trunk@45775


git-svn-id: http://core.svn.wordpress.org/trunk@45586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-09 13:42:57 +00:00
Sergey Biryukov
aaea839402 Twenty Nineteen: Add missing copyright information. 
Props poena, kjellr.
Fixes #47857.
Built from https://develop.svn.wordpress.org/trunk@45774


git-svn-id: http://core.svn.wordpress.org/trunk@45585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-09 13:36:58 +00:00
Sergey Biryukov
441a3c97e0 Twenty Nineteen: Correct license URI. 
Props munyagu, shital-patel.
Fixes #47850.
Built from https://develop.svn.wordpress.org/trunk@45773


git-svn-id: http://core.svn.wordpress.org/trunk@45584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-09 02:57:59 +00:00
Gary Pendergast
12aa773802 Feeds: Introduce the get_self_link() function. 
Corresponds to the `self_link()` template function.

This matches other feed template functions, using one function to get the value, and a different function to echo it.

Props jojotjebaby, mobeen-abdullah, donmhico, audrasjb, dshanske.
Fixes #44838.


Built from https://develop.svn.wordpress.org/trunk@45772


git-svn-id: http://core.svn.wordpress.org/trunk@45583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-09 01:31:56 +00:00
Sergey Biryukov
2aa8ce5bc5 REST API: In get_rest_url(), check if $_SERVER['SERVER_NAME'] is set to avoid a PHP warning in CLI context. 
Props paulschreiber.
Fixes #47854.
Built from https://develop.svn.wordpress.org/trunk@45771


git-svn-id: http://core.svn.wordpress.org/trunk@45582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-08 20:20:55 +00:00
Sergey Biryukov
6041a08347 Bootstrap/Load: Change "Insufficient Requirements" wp_die() heading to "Requirements Not Met", which is more appropriate for the context it's used in. 
Props yoavf.
Fixes #47575.
Built from https://develop.svn.wordpress.org/trunk@45770


git-svn-id: http://core.svn.wordpress.org/trunk@45581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-08 12:54:56 +00:00
Gary Pendergast
638bae9392 Emoji: Upgrade Twemoji to 12.1.2. 
This upgrade adds support for the transgender flag: 🏳️‍⚧️

There's some additional housekeeping in this commit:

- Twemoji recently rearranged their repository and package, so `Gruntfile.js` needed tweaking to allow for that.
- As only new files were added in this Twemoji release, the CDN version didn't need updating.

Fixes #47852.


Built from https://develop.svn.wordpress.org/trunk@45769


git-svn-id: http://core.svn.wordpress.org/trunk@45580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-08 04:05:55 +00:00
Sergey Biryukov
83187125e4 Bundled Themes: Audit and update version numbers passed to wp_enqueue_script() to ensure proper cache busting. 
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981.
Built from https://develop.svn.wordpress.org/trunk@45768


git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-08 01:29:58 +00:00
Sergey Biryukov
e0563013ed Bundled Themes: Audit and update version numbers passed to wp_enqueue_style() to ensure proper cache busting. 
Props dswebsme, ianbelanger, desrosj.
Fixes #46979.
Built from https://develop.svn.wordpress.org/trunk@45767


git-svn-id: http://core.svn.wordpress.org/trunk@45578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-08 01:25:58 +00:00
Sergey Biryukov
c965d2e097 Administration: Show a warning in Reading Settings when a Privacy Policy page is accidentally set as a Homepage or Posts page. 
Props garrett-eclipse, subrataemfluence.
Fixes #46831.
Built from https://develop.svn.wordpress.org/trunk@45766


git-svn-id: http://core.svn.wordpress.org/trunk@45577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 23:03:54 +00:00
Aaron Jorbin
b8fd2b631b Bump grunt-patch-wordpress to 2.0.0 
Fixes #47845
Props pento, kadamwhite, netweb, jorbin

Built from https://develop.svn.wordpress.org/trunk@45765


git-svn-id: http://core.svn.wordpress.org/trunk@45576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 15:09:57 +00:00
Sergey Biryukov
aa4ab3acdc Twenty Seventeen: Correct height for a Button block without text. 
Props ianbelanger, laurelfulford, nayana123.
Fixes #47414.
Built from https://develop.svn.wordpress.org/trunk@45764


git-svn-id: http://core.svn.wordpress.org/trunk@45575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 11:57:54 +00:00
Sergey Biryukov
64202a7ca3 Twenty Eleven: Correct height for a Button block without text. 
Props ianbelanger, laurelfulford, nayana123.
See #47414.
Built from https://develop.svn.wordpress.org/trunk@45763


git-svn-id: http://core.svn.wordpress.org/trunk@45574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 11:56:57 +00:00
Gary Pendergast
d5d58a90f9 Build Tools: Switch all Travis PHPUnit jobs over to Docker-based PHP. 
Additionally, there are a handful of related minor changes in this commit:
- `.travis.yml` has been tidied up a little.
- [45745] was incorrectly marking Travis jobs as passed when some PHPUnit runs failed.
- Add the `LOCAL_PHP_MEMCACHED` environment variable, for enabling Memcached.
- Add the `env:pull` NPM script, for refreshing Docker images.

See #47767.

Built from https://develop.svn.wordpress.org/trunk@45762


git-svn-id: http://core.svn.wordpress.org/trunk@45573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 11:55:57 +00:00
Sergey Biryukov
de099aec14 Twenty Nineteen: Revise Latest Posts block styles to support post content options. 
Props kjellr, ianbelanger.
Fixes #47340.
Built from https://develop.svn.wordpress.org/trunk@45761


git-svn-id: http://core.svn.wordpress.org/trunk@45572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 11:48:57 +00:00
Sergey Biryukov
72b11e3322 Twenty Nineteen: Remove duplicate height and width attributes from SVG icons. 
The attributes are added via `TwentyNineteen_SVG_Icons::get_svg()`, there's no need to have them separately in SVG sources.

Props mukesh27, albertomake.
Fixes #47128.
Built from https://develop.svn.wordpress.org/trunk@45760


git-svn-id: http://core.svn.wordpress.org/trunk@45571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 11:41:54 +00:00
Sergey Biryukov
32afb6f7c7 Coding Standards: Use strict comparison in wp-admin/edit.php. 
Props davidbaumwald.
Fixes #47201.
Built from https://develop.svn.wordpress.org/trunk@45759


git-svn-id: http://core.svn.wordpress.org/trunk@45570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 11:40:55 +00:00
Andrew Ozz
52c53ae6f8 Remove trailing white space in upgrade.php after [45757]. 
See #46349.
Built from https://develop.svn.wordpress.org/trunk@45758


git-svn-id: http://core.svn.wordpress.org/trunk@45569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 01:01:57 +00:00
Andrew Ozz
fff56d219f Add admin email verification screen. Shown every six months after an admin has logged in. 
Also includes WPCS fixes for wp-login.php.

Props andraganescu, boemedia, lessbloat, azaozz.
See #46349.
Built from https://develop.svn.wordpress.org/trunk@45757


git-svn-id: http://core.svn.wordpress.org/trunk@45568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-07 00:04:56 +00:00
Sergey Biryukov
e081194455 Administration: Correct "Quick Edit" link height in list tables for consistency with other action links. 
Props jobthomas, burhandodhy.
Fixes #47815.
Built from https://develop.svn.wordpress.org/trunk@45756


git-svn-id: http://core.svn.wordpress.org/trunk@45567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 22:20:58 +00:00
Sergey Biryukov
e4f1204e04 Coding Standards: Fix WPCS violation in [45754]. 
See #46570.
Built from https://develop.svn.wordpress.org/trunk@45755


git-svn-id: http://core.svn.wordpress.org/trunk@45566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 18:10:59 +00:00
Sergey Biryukov
282dfee8e0 General: Correctly detect large floats in is_serialized(). 
Props killerbishop, donmhico, hoythan.
Fixes #46570.
Built from https://develop.svn.wordpress.org/trunk@45754


git-svn-id: http://core.svn.wordpress.org/trunk@45565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 13:55:57 +00:00
Sergey Biryukov
d5fc1647c0 Feeds: Escape & characters in atom_site_icon() for XML, for consistency with rss2_site_icon(). 
Props abhijitrakas, shawfactor.
Fixes #47482.
Built from https://develop.svn.wordpress.org/trunk@45753


git-svn-id: http://core.svn.wordpress.org/trunk@45564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 13:15:56 +00:00
Sergey Biryukov
2ac34c799b Coding Standards: Use strict comparison in wp-admin/options-reading.php. 
Props subrataemfluence.
Fixes #46834.
Built from https://develop.svn.wordpress.org/trunk@45752


git-svn-id: http://core.svn.wordpress.org/trunk@45563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 12:52:56 +00:00
Sergey Biryukov
ad9d8c7d58 Plugins: Use include_once for wp-admin/includes/plugin-install.php in WP_Plugin_Install_List_Table::prepare_items(). 
This brings consistency with the other instances where the file is included, and allows for reusing its functions in custom code.

Props engelen, desrosj.
Fixes #38874.
Built from https://develop.svn.wordpress.org/trunk@45751


git-svn-id: http://core.svn.wordpress.org/trunk@45562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 11:07:55 +00:00
Sergey Biryukov
c1a252da8e Site Health: Use correct variable when checking PHP requirements for a plugin update in WP_Plugins_List_Table::single_row(). 
Props diddledan, sharaz, vaishalipanchal.
Fixes #47835.
Built from https://develop.svn.wordpress.org/trunk@45750


git-svn-id: http://core.svn.wordpress.org/trunk@45561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 10:58:56 +00:00
Sergey Biryukov
bec2aa0ef7 Docs: Correct @type annotation for WP_Http_Curl properties. 
Props diddledan.
Fixes #46860.
Built from https://develop.svn.wordpress.org/trunk@45749


git-svn-id: http://core.svn.wordpress.org/trunk@45560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 08:12:56 +00:00
Sergey Biryukov
bbf84bccf7 Docs: Correct @type annotation for WP_HTTP_Cookie::$expires. 
Props diddledan.
Fixes #46859.
Built from https://develop.svn.wordpress.org/trunk@45748


git-svn-id: http://core.svn.wordpress.org/trunk@45559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 07:56:56 +00:00
Sergey Biryukov
f7b8423b12 Upgrade/Install: Make sure translate_level_to_role() always returns a value. 
Props diddledan.
Fixes #46848.
Built from https://develop.svn.wordpress.org/trunk@45747


git-svn-id: http://core.svn.wordpress.org/trunk@45558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 07:48:58 +00:00
Sergey Biryukov
69bbdc4022 Posts, Post Types: Update, not delete the page_for_posts option in _reset_front_page_settings_for_post() when a linked page is deleted or trashed. 
Props diddledan.
Fixes #46850.
Built from https://develop.svn.wordpress.org/trunk@45746


git-svn-id: http://core.svn.wordpress.org/trunk@45557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 07:44:55 +00:00
Gary Pendergast
41dc3e8d39 Build Tools: Add a WordPress Development Environment. 
This commit adds the first iteration of a Docker-based config for setting up a local WordPress development environment.

Props pento, noisysocks, mcsf, pbearne, isabel_brison.
See #47767.


Built from https://develop.svn.wordpress.org/trunk@45745


git-svn-id: http://core.svn.wordpress.org/trunk@45556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-05 07:10:56 +00:00
Sergey Biryukov
545157d30d Posts, Post Types: Revert unintended change from [45742]. 
See #46503.
Built from https://develop.svn.wordpress.org/trunk@45744


git-svn-id: http://core.svn.wordpress.org/trunk@45555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 14:44:55 +00:00
Sergey Biryukov
e8cd892ba4 Administration: Display a warning at the top of "All Settings" screen. 
Props zodiac1978, donmhico, pixolin.
Fixes #47718.
Built from https://develop.svn.wordpress.org/trunk@45743


git-svn-id: http://core.svn.wordpress.org/trunk@45554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 13:03:55 +00:00
Sergey Biryukov
9967a3e030 Docs: Add missing description for $post global. 
Props immeet94.
Fixes #46503. See #47110.
Built from https://develop.svn.wordpress.org/trunk@45742


git-svn-id: http://core.svn.wordpress.org/trunk@45553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 12:28:56 +00:00
Sergey Biryukov
0cf1235477 Docs: Remove incorrect @return tags in comment_reply_link() and post_reply_link() DocBlocks. 
Props atachibana.
Fixes #47826.
Built from https://develop.svn.wordpress.org/trunk@45741


git-svn-id: http://core.svn.wordpress.org/trunk@45552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 02:20:55 +00:00
Sergey Biryukov
6da93732e7 Docs: Add missing description for $current_screen global. 
Props mukesh27.
Fixes #45604. See #47110.
Built from https://develop.svn.wordpress.org/trunk@45740


git-svn-id: http://core.svn.wordpress.org/trunk@45551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 02:03:55 +00:00
Sergey Biryukov
7f7480cb2a Docs: Add missing description for $wp_query and $wp_the_query globals. 
Props mukesh27.
See #45604, #47110.
Built from https://develop.svn.wordpress.org/trunk@45739


git-svn-id: http://core.svn.wordpress.org/trunk@45550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 01:59:56 +00:00
Sergey Biryukov
77a31e6875 Docs: Add missing description for $wp_locale_switcher global. 
See #45604, #47110.
Built from https://develop.svn.wordpress.org/trunk@45738


git-svn-id: http://core.svn.wordpress.org/trunk@45549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 01:47:55 +00:00
Sergey Biryukov
e0311b76c7 Docs: Add missing description for $wp_locale global. 
Props mukesh27.
See #45604, #47110.
Built from https://develop.svn.wordpress.org/trunk@45737


git-svn-id: http://core.svn.wordpress.org/trunk@45548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 01:46:55 +00:00
Sergey Biryukov
ea606165a5 Docs: Add missing description for $wp global. 
See #45604, #47110.
Built from https://develop.svn.wordpress.org/trunk@45736


git-svn-id: http://core.svn.wordpress.org/trunk@45547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 01:28:55 +00:00
Sergey Biryukov
b1e34ccc1f Docs: Add missing description for $wp_rewrite global. 
See #45604, #47110.
Built from https://develop.svn.wordpress.org/trunk@45735


git-svn-id: http://core.svn.wordpress.org/trunk@45546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 01:19:56 +00:00
Sergey Biryukov
29b072e706 Docs: Add missing description for $wpdb, $wp_db_version, and $wp_current_db_version globals. 
Props mukesh27, utsav72640, immeet94, SergeyBiryukov.
See #45604.
Built from https://develop.svn.wordpress.org/trunk@45734


git-svn-id: http://core.svn.wordpress.org/trunk@45545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 01:12:56 +00:00
Sergey Biryukov
702ee129ad Docs: Fix typo in a comment in WP_Site_Health::get_test_theme_version(). 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@45733


git-svn-id: http://core.svn.wordpress.org/trunk@45544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 00:48:56 +00:00
Sergey Biryukov
fd83290995 Site Health: If WP_DEFAULT_THEME doesn't exist, use WP_Theme::get_core_default_theme() as a fallback. 
Props ajayghaghretiya1, juliobox, SergeyBiryukov.
Fixes #47299.
Built from https://develop.svn.wordpress.org/trunk@45732


git-svn-id: http://core.svn.wordpress.org/trunk@45543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-04 00:02:55 +00:00
Sergey Biryukov
7dbc4d28e5 Script Loader: Send a 400 Bad Request status code in load-scripts.php and load-styles.php if the required load[] parameter is not set. 
Props compilenix.
Fixes #44108.
Built from https://develop.svn.wordpress.org/trunk@45731


git-svn-id: http://core.svn.wordpress.org/trunk@45542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 22:17:57 +00:00
Aaron Jorbin
c377191858 PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax 
PHP used to allow both square brackets and curly braces to be used interchangeably for accessing array elements and string offsets. The curly bracket syntax is only allowed in a limited set of cases and can be confusing for people not used to it.
PHP 7.4 will deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0.
Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access

See #47751.
Props jrf.


Built from https://develop.svn.wordpress.org/trunk@45730


git-svn-id: http://core.svn.wordpress.org/trunk@45541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 20:21:55 +00:00
Andrea Fercia
b853e21bf9 Accessibility: Improve the differences between revisions. 
Color alone is not sufficient to visually communicate differences.

- adds `plus` and `minus` icons to the changed lines
- adds visually hidden text: `Added`, `Deleted`, and `Unchanged` to clarify the differences to assistive technologies users

Props birgire, audrasjb, kjellr, adamsilverstein.
Fixes #43532.

Built from https://develop.svn.wordpress.org/trunk@45729


git-svn-id: http://core.svn.wordpress.org/trunk@45540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 15:46:54 +00:00
Andrea Fercia
cbd6b7b5bc Accessibility: Remove title attributes from the Meta widget. 
- removes the `Powered by WordPress, state-of-the-art semantic personal publishing platform.` title attribute
- removes the title attribute from the abbreviations: contrary to a common belief, title attributes on abbreviations are only available to a minority of users, see https://developer.paciellogroup.com/blog/2019/03/short-note-the-abbreviation-appreciation-society/
- changes the term `RSS` to `feed`, as `RSS` is a technical term not all users are supposed to be familiar with
- improves the `widget_meta_poweredby` filter documentation

Props nishitlangaliya, chetan200891, audrasjb.
See #46980, #24766.
Fixes #46978.

Built from https://develop.svn.wordpress.org/trunk@45728


git-svn-id: http://core.svn.wordpress.org/trunk@45539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 13:28:57 +00:00
Andrea Fercia
7b45746001 Menus: Fix the Custom Links text fallback. 
When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".

The changes in [36379] broke this behavior making the fallback text: ` (Pending)`, with a leading space.

Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.

Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Fixes #38415.

Built from https://develop.svn.wordpress.org/trunk@45727


git-svn-id: http://core.svn.wordpress.org/trunk@45538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 12:19:56 +00:00
Andrea Fercia
2d60076e77 Accessibility: Improve the way emojis are announced by screen readers. 
Adds an ARIA `role="img"` to the emojis markup in the front end. While the ARIA role is technically redundant, it helps Safari and VoiceOver to properly announce the emojis as "image". Without the role, they announce a generic "group" role.
Tested with Safari 12.1.1 / VoiceOver 9.

Props pento.
See #37486.

Built from https://develop.svn.wordpress.org/trunk@45726


git-svn-id: http://core.svn.wordpress.org/trunk@45537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 11:53:56 +00:00
Andrea Fercia
9228eeb47b Accessibility: Fix the alt attribute of the Gallery images within the Classic Editor. 
Passes the images `alt` attribute value to the Gallery template used within the Classic Editor.

Props yarnboy, wpboss.
Fixes #47687.

Built from https://develop.svn.wordpress.org/trunk@45725


git-svn-id: http://core.svn.wordpress.org/trunk@45536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 11:36:53 +00:00
Sergey Biryukov
76f482de43 Posts, Post Types: Check the result of wp_update_post() in wp_trash_post() and wp_untrash_post(). 
Props abhijitrakas, manzoorwani.jk, siliconforks.
Fixes #47773.
Built from https://develop.svn.wordpress.org/trunk@45724


git-svn-id: http://core.svn.wordpress.org/trunk@45535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 03:47:54 +00:00
Sergey Biryukov
c26f1c5d90 Taxonomy: Fix deprecated calls to get_terms(). 
The taxonomy should be passed as part of `$args`, rather than as its own argument.

Props sgastard, mukesh27, SergeyBiryukov.
Fixes #47819.
Built from https://develop.svn.wordpress.org/trunk@45723


git-svn-id: http://core.svn.wordpress.org/trunk@45534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-03 03:35:56 +00:00
Andrea Fercia
60431f3c53 Customize: Make the color picker close when clicking on the empty area on the right. 
Props monikarao.
Fixes #47693.

Built from https://develop.svn.wordpress.org/trunk@45722


git-svn-id: http://core.svn.wordpress.org/trunk@45533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 17:09:57 +00:00
Sergey Biryukov
ad46ef7c06 Twenty Thirteen: Make twentythirteen_author_bio_template() use author templates if exist, fall back to regular template hierarchy otherwise. 
See #32096.
Built from https://develop.svn.wordpress.org/trunk@45721


git-svn-id: http://core.svn.wordpress.org/trunk@45532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 03:09:55 +00:00
Sergey Biryukov
b900e22629 Twenty Fifteen: Make twentyfifteen_author_bio_template() use author templates if exist, fall back to regular template hierarchy otherwise. 
See #32096.
Built from https://develop.svn.wordpress.org/trunk@45720


git-svn-id: http://core.svn.wordpress.org/trunk@45531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 03:08:55 +00:00
Sergey Biryukov
e2ea3f7f30 Twenty Thirteen: Prevent author-bio.php partial template from interfering with rendering an author archive of a user with the bio username. 
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
Fixes #32096.
Built from https://develop.svn.wordpress.org/trunk@45719


git-svn-id: http://core.svn.wordpress.org/trunk@45530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 02:34:52 +00:00
Sergey Biryukov
97f28973da Twenty Fifteen: Prevent author-bio.php partial template from interfering with rendering an author archive of a user with the bio username. 
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
See #32096.
Built from https://develop.svn.wordpress.org/trunk@45718


git-svn-id: http://core.svn.wordpress.org/trunk@45529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-02 02:33:57 +00:00
Sergey Biryukov
f6770efd94 Users: Clean user cache in check_password_reset_key() tests. 
Props davidbaumwald, spacedmonkey.
See #45845.
Built from https://develop.svn.wordpress.org/trunk@45717


git-svn-id: http://core.svn.wordpress.org/trunk@45528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 19:54:55 +00:00
Sergey Biryukov
65420d3c7a Users: Replace raw SQL query in check_password_reset_key() with get_user_by(). 
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845.
Built from https://develop.svn.wordpress.org/trunk@45716


git-svn-id: http://core.svn.wordpress.org/trunk@45527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 19:19:55 +00:00
Sergey Biryukov
ee5e044a2a Users: Use clean_user_cache() in wp_insert_user(), wp_update_user(), wp_set_password(), add_user_to_blog(). 
Props spacedmonkey.
Fixes #47021.
Built from https://develop.svn.wordpress.org/trunk@45715


git-svn-id: http://core.svn.wordpress.org/trunk@45526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 17:49:57 +00:00
Sergey Biryukov
75857aa857 Users: Use wp_update_user() in get_password_reset_key(). 
Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov.
Fixes #45746.
Built from https://develop.svn.wordpress.org/trunk@45714


git-svn-id: http://core.svn.wordpress.org/trunk@45525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 17:25:55 +00:00
Sergey Biryukov
f6189321e1 Users: Reorganize user_nicename, user_url, user_registered setting in wp_insert_user() for consistency with the order or fields in the database. 
See #45746.
Built from https://develop.svn.wordpress.org/trunk@45713


git-svn-id: http://core.svn.wordpress.org/trunk@45524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 17:13:57 +00:00
Sergey Biryukov
4a6461dcc2 Users: Use get_password_reset_key() in wp_new_user_notification(). 
Props mrasharirfan, spacedmonkey.
Fixes #45745.
Built from https://develop.svn.wordpress.org/trunk@45712


git-svn-id: http://core.svn.wordpress.org/trunk@45523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 15:30:58 +00:00
Sergey Biryukov
6623a824d0 Taxonomy: Correct some strict comparisons after [45710]. 
See #47573.
Built from https://develop.svn.wordpress.org/trunk@45711


git-svn-id: http://core.svn.wordpress.org/trunk@45522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 15:04:56 +00:00
Sergey Biryukov
3e1126d940 Coding Standards: Use strict comparison in wp-includes/taxonomy.php. 
Props andizer, SergeyBiryukov.
Fixes #47573.
Built from https://develop.svn.wordpress.org/trunk@45710


git-svn-id: http://core.svn.wordpress.org/trunk@45521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 13:45:56 +00:00
Sergey Biryukov
fd03949143 Coding Standards: Fix WPCS violations after [45708]. 
See #45747.
Built from https://develop.svn.wordpress.org/trunk@45709


git-svn-id: http://core.svn.wordpress.org/trunk@45520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 12:03:56 +00:00
Sergey Biryukov
b32cff72c2 Users: Deprecate update_user_status() in favor of wp_update_user(). 
Props spacedmonkey, SergeyBiryukov.
Fixes #45747.
Built from https://develop.svn.wordpress.org/trunk@45708


git-svn-id: http://core.svn.wordpress.org/trunk@45519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 11:28:54 +00:00
Sergey Biryukov
2d574d673f Database: Use a strict comparison for has_filter() check in wpdb::placeholder_escape(). 
The filter is added with a priority of `0`, so a loose comparison had an unintended effect of adding the filter on every call.

Props withinboredom.
Fixes #47430.
Built from https://develop.svn.wordpress.org/trunk@45707


git-svn-id: http://core.svn.wordpress.org/trunk@45518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-01 02:25:56 +00:00
K. Adam White
5f9ba92af4 REST API: Skip processing fields which are not present in the selected context. 
In `WP_REST_Controller::get_fields_for_response()`, exclude fields which are not registered to appear in the request's context.

In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit.

Props dlh.
Fixes #45605.

Built from https://develop.svn.wordpress.org/trunk@45706


git-svn-id: http://core.svn.wordpress.org/trunk@45517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 20:21:56 +00:00
K. Adam White
d296736b75 REST API: Generate sample permalink only when a dependent field is requested. 
The sample permalink will now only be generated if the derivative `permalink_template` or `generated_slug` fields are to be included in the response, preventing an unnecessary database request for each post (via `wp_unique_post_slug()`) when those fields are not requested.

Props dlh.
See #45605.

Built from https://develop.svn.wordpress.org/trunk@45705


git-svn-id: http://core.svn.wordpress.org/trunk@45516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 20:00:57 +00:00
Sergey Biryukov
ee23869c68 Docs: Correct parameter documentation for bulk_edit_custom_box and quick_edit_custom_box actions. 
Props abrain.
Fixes #47810.
Built from https://develop.svn.wordpress.org/trunk@45704


git-svn-id: http://core.svn.wordpress.org/trunk@45515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 15:10:58 +00:00
Sergey Biryukov
fec01b0685 Docs: Correct parameter type and description for is_email filter. 
Props jenkoian.
Fixes #47793.
Built from https://develop.svn.wordpress.org/trunk@45703


git-svn-id: http://core.svn.wordpress.org/trunk@45514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 01:26:54 +00:00
Sergey Biryukov
383c1df66b Docs: Correct @return value description for get_term_link(). 
Props garrett-eclipse.
Fixes #47806.
Built from https://develop.svn.wordpress.org/trunk@45702


git-svn-id: http://core.svn.wordpress.org/trunk@45513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-31 01:19:56 +00:00
Tammie Lister
d5c7657189 Media: Reduces the bulk media options to have one primary button 
This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov
Fixes #46757, #46758

Built from https://develop.svn.wordpress.org/trunk@45701


git-svn-id: http://core.svn.wordpress.org/trunk@45512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-30 23:20:57 +00:00
Tammie Lister
fa9980049e Admin: Improve Dashboard icon contrast. 
The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast.

Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr 
Fixes #46935

Built from https://develop.svn.wordpress.org/trunk@45700


git-svn-id: http://core.svn.wordpress.org/trunk@45511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-30 22:54:57 +00:00
Sergey Biryukov
c7493264a4 Rewrite Rules: Check if $wp_rewrite->flush_rules() is callable before calling it in flush_rewrite_rules(). 
Props bsetiawan88, markjaquith.
Fixes #47087.
Built from https://develop.svn.wordpress.org/trunk@45699


git-svn-id: http://core.svn.wordpress.org/trunk@45510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 17:52:56 +00:00
Sergey Biryukov
98642b4821 Users: Use case-insensitive email address comparison when checking whether "Grant this user super admin privileges" checkbox should be displayed on Edit User screen. 
Props trepmal.
Fixes #47119.
Built from https://develop.svn.wordpress.org/trunk@45698


git-svn-id: http://core.svn.wordpress.org/trunk@45509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 17:42:55 +00:00
Sergey Biryukov
ec8940edeb Coding Standards: Fix WPCS violations in wp-admin/includes/class-walker-nav-menu-edit.php. 
Props sudhiryadav, audrasjb.
Fixes #46902.
Built from https://develop.svn.wordpress.org/trunk@45697


git-svn-id: http://core.svn.wordpress.org/trunk@45508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:53:52 +00:00
Sergey Biryukov
c9942bb3d8 Coding Standards: Fix WPCS violations in [45694]. 
See #47466.
Built from https://develop.svn.wordpress.org/trunk@45696


git-svn-id: http://core.svn.wordpress.org/trunk@45507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:52:56 +00:00
Sergey Biryukov
e7abdc7040 Docs: Improve the DocBlocks for got_mod_rewrite(), extract_from_markers(), insert_with_markers(). 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@45695


git-svn-id: http://core.svn.wordpress.org/trunk@45506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:35:56 +00:00
Sergey Biryukov
67e5038470 Rewrite Rules: Add a comment to # BEGIN/END .htaccess markers to clarify that the directives are dynamically generated, and should only be modified via WordPress filters. 
Introduce `insert_with_markers_inline_instructions` filter to modify the default instructions text.

Props bradleyt, SergeyBiryukov.
Fixes #47466.
Built from https://develop.svn.wordpress.org/trunk@45694


git-svn-id: http://core.svn.wordpress.org/trunk@45505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:31:57 +00:00
Sergey Biryukov
7a4d1b5dbd Permalinks: Improve appearance of URL examples on Permalink Settings screen. 
Props luan-ramos, sarath.ar.
Fixes #41559.
Built from https://develop.svn.wordpress.org/trunk@45693


git-svn-id: http://core.svn.wordpress.org/trunk@45504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:11:56 +00:00
Sergey Biryukov
b95b055225 Administration: Allow breaking long strings in <code> tags at any point, to avoid overflowing on mobile. 
Props david.binda, mukesh27.
Fixes #47329.
Built from https://develop.svn.wordpress.org/trunk@45692


git-svn-id: http://core.svn.wordpress.org/trunk@45503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 16:09:55 +00:00
Sergey Biryukov
a59301c2ba Site Health: Consistently use wpdb::db_version() for checking the database server version, instead of partically replicating its functionality. 
Props Clorith, wpfed.
Fixes #47738.
Built from https://develop.svn.wordpress.org/trunk@45691


git-svn-id: http://core.svn.wordpress.org/trunk@45502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-28 14:55:57 +00:00
Dominik Schilling
182f813e24 I18N: Display the logged out message in the user's locale 
Built from https://develop.svn.wordpress.org/trunk@45690


git-svn-id: http://core.svn.wordpress.org/trunk@45501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 14:31:55 +00:00
Dominik Schilling
391d6a3f2b I18N: Following [45688], remove test for removed method. 
See #44865.
Built from https://develop.svn.wordpress.org/trunk@45689


git-svn-id: http://core.svn.wordpress.org/trunk@45500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 14:30:57 +00:00
Dominik Schilling
892a80d974 I18N: Use RTL stylesheets when running from /src. 
To run WordPress from /src you have to use the `--dev` flag which also builds the RTL stylesheets thus the admin notice and force to LTR is no longer required.

See #44492.
Fixes #44865.
Built from https://develop.svn.wordpress.org/trunk@45688


git-svn-id: http://core.svn.wordpress.org/trunk@45499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 14:17:57 +00:00
Dominik Schilling
4d3ca52c45 REST API: Pass current request object to rest_authentication_errors filter in WP_REST_Server::check_authentication(). 
Fixes #46907.
Built from https://develop.svn.wordpress.org/trunk@45687


git-svn-id: http://core.svn.wordpress.org/trunk@45498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 13:44:57 +00:00
Dominik Schilling
81bfb111d1 Tools: Remove internationalization tools (also known as makepot.php). 
It has been a great pleasure to work with `makepot.php` over the past [https://i18n.trac.wordpress.org/changeset/4169/ 11 years] but now it's time to say goodbye.
The tools have been integrated into WP-CLI as [https://developer.wordpress.org/cli/commands/i18n/make-pot/ wp i18n make-pot] and [https://developer.wordpress.org/cli/commands/i18n/make-json/ wp i18n make-json]. The new commands were optimized to support current PHP versions and are more flexible and reliable when extracting strings for PHP, and JavaScript.

Access to the old tools continue to exist in previous branches or at https://i18n.svn.wordpress.org/tools/.

Fixes #45287.
Built from https://develop.svn.wordpress.org/trunk@45686


git-svn-id: http://core.svn.wordpress.org/trunk@45497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 13:10:56 +00:00
Dominik Schilling
8059b362e8 I18N: Add support for custom WP_PLUGIN_URL in load_script_textdomain(). 
Plugins may not be on the same host/path as the rest of the content. To support loading translations for this setup check if the script source matches `plugins_url()`.
Also fixes an undefined index notice when a custom content URL has no path.

Props odminstudios, ocean90.
Fixes #46336, #46387.
Built from https://develop.svn.wordpress.org/trunk@45685


git-svn-id: http://core.svn.wordpress.org/trunk@45496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-27 12:44:56 +00:00
Sergey Biryukov
0af752e360 Accessibility: Toolbar: Make the min-width value for #wpadminbar at 782px breakpoint consistent with that of <body>. 
This ensures that the "My Account" toolbar item stays visible at high zoom levels.

Props isabel_brison, chetan200891.
Fixes #47603.
Built from https://develop.svn.wordpress.org/trunk@45684


git-svn-id: http://core.svn.wordpress.org/trunk@45495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 22:04:55 +00:00
Sergey Biryukov
f933abef11 Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests. 
Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607.
Built from https://develop.svn.wordpress.org/trunk@45683


git-svn-id: http://core.svn.wordpress.org/trunk@45494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 17:46:56 +00:00
Sergey Biryukov
5cdbe22b16 Administration: Merge CSS rules for #adminmenu .wp-submenu a in one place. 
Props ozmatflc, AkSDvP.
Fixes #47780.
Built from https://develop.svn.wordpress.org/trunk@45682


git-svn-id: http://core.svn.wordpress.org/trunk@45493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 13:49:57 +00:00
Sergey Biryukov
33b2fbc7e7 REST API: Make "Could not update meta value in database" error messages more helpful. 
Props apermo, AkSDvP.
Fixes #46252.
Built from https://develop.svn.wordpress.org/trunk@45681


git-svn-id: http://core.svn.wordpress.org/trunk@45492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 13:20:56 +00:00
Sergey Biryukov
e925997562 Site Health: Show parent theme in its own accordion on Site Health Info screen; rename "Other Themes" to "Inactive Themes". 
Props garrett-eclipse, mukesh27, Clorith, xkon, msaggiorato.
Fixes #46925.
Built from https://develop.svn.wordpress.org/trunk@45680


git-svn-id: http://core.svn.wordpress.org/trunk@45491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 03:49:55 +00:00
Sergey Biryukov
dae07c8216 Coding Standards: Fix newlines in wp-includes/date.php. 
See #47775.
Built from https://develop.svn.wordpress.org/trunk@45679


git-svn-id: http://core.svn.wordpress.org/trunk@45490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-26 00:12:55 +00:00
Sergey Biryukov
cff445d55f Coding Standards: Move wp-includes/date.php to wp-includes/class-wp-date-query.php. 
This renames the file containing the `WP_Date_Query` class to conform to the coding standards.

This commit also includes:

- A new `date.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

Fixes #47775. See #47632.
Built from https://develop.svn.wordpress.org/trunk@45678


git-svn-id: http://core.svn.wordpress.org/trunk@45489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 23:31:56 +00:00
Sergey Biryukov
ace077085d I18N: Update translator comment missed in [45676]. 
See #47771.
Built from https://develop.svn.wordpress.org/trunk@45677


git-svn-id: http://core.svn.wordpress.org/trunk@45488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 22:56:55 +00:00
Sergey Biryukov
a186dbcb65 I18N: Update translator comments after [45674]. 
See #47771.
Built from https://develop.svn.wordpress.org/trunk@45676


git-svn-id: http://core.svn.wordpress.org/trunk@45487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 22:52:56 +00:00
Sergey Biryukov
ac10f9b9e4 Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article. 
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.
Built from https://develop.svn.wordpress.org/trunk@45675


git-svn-id: http://core.svn.wordpress.org/trunk@45486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 22:46:55 +00:00
Sergey Biryukov
8e85299a00 General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article. 
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.
Built from https://develop.svn.wordpress.org/trunk@45674


git-svn-id: http://core.svn.wordpress.org/trunk@45485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 22:45:57 +00:00
Sergey Biryukov
ccba6c4aec Upgrade/Install: Bring some consistency to installation screen styles. 
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776, #47757, #47758.
Built from https://develop.svn.wordpress.org/trunk@45673


git-svn-id: http://core.svn.wordpress.org/trunk@45484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 19:11:55 +00:00
Sergey Biryukov
1d283ef54f Docs: Clarify that is_network_admin() does not check if the site is a Multisite network; is_multisite() should be used for that. 
Props svovaf, dilipbheda, tazotodua.
Fixes #47415.
Built from https://develop.svn.wordpress.org/trunk@45672


git-svn-id: http://core.svn.wordpress.org/trunk@45483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 15:19:58 +00:00
Sergey Biryukov
8ab7bbe385 Posts, Post Types: Introduce is_sticky filter in is_sticky() to provide more flexibility for custom sticky post implementations. 
Props dehisok, greenshady.
Fixes #37629.
Built from https://develop.svn.wordpress.org/trunk@45671


git-svn-id: http://core.svn.wordpress.org/trunk@45482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 01:36:54 +00:00
Sergey Biryukov
316fa4aecb Code Editor: Check for correct mode value in wp.codeEditor.initialize to enable autocomplete support for PHP. 
Props ediamin.
Fixes #47769.
Built from https://develop.svn.wordpress.org/trunk@45670


git-svn-id: http://core.svn.wordpress.org/trunk@45481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 01:27:57 +00:00
Sergey Biryukov
aee690fd84 Permalinks: Update URLs for "Changing File Permissions" documentation article. 
Props patilswapnilv, ianbelanger, SergeyBiryukov.
Fixes #47768.
Built from https://develop.svn.wordpress.org/trunk@45669


git-svn-id: http://core.svn.wordpress.org/trunk@45480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 01:18:55 +00:00
Sergey Biryukov
5522be31e7 Coding Standards: Use correct variable in wp_dropdown_categories() after [45667]. 
See #45059.
Built from https://develop.svn.wordpress.org/trunk@45668


git-svn-id: http://core.svn.wordpress.org/trunk@45479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 01:07:54 +00:00
Sergey Biryukov
18bd01985b Coding Standards: Rename $r variable used with wp_parse_args() to $parsed_args for clarity. 
Props freewebmentor.
Fixes #45059.
Built from https://develop.svn.wordpress.org/trunk@45667


git-svn-id: http://core.svn.wordpress.org/trunk@45478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 00:48:58 +00:00
Gary Pendergast
7112ee7132 Coding Standards: Move the remaining PHPCS errors to report as warnings, and add Travis tests. 
The remaining error-level coding standards issues (specifically, associated with the sniffs `WordPress.PHP.YodaConditions.NotYoda`, `WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase`, `WordPress.DB.PreparedSQL.InterpolatedNotPrepared`, `WordPress.DB.PreparedSQL.NotPrepared`, and `WordPress.Files.FileName.InvalidClassFileName`) are marked as warnings, until they're all addressed.

This change allows us to run linting on Travis across the entire codebase, ensuring no other error-level violations can be introduced.

Additionally, PHPCS will now cache results locally, drastically improving performance for subsequent checks: scanning the entire codebase takes 1-2 minutes the first time, and less than one second for subsequent checks.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45665


git-svn-id: http://core.svn.wordpress.org/trunk@45476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 07:48:56 +00:00
Gary Pendergast
172117d35f Coding Standards: Fix a filename replacement missed in [45663]. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45664


git-svn-id: http://core.svn.wordpress.org/trunk@45475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 04:42:57 +00:00
Gary Pendergast
af0a914d14 Coding Standards: Move wp-includes/class-oembed.php to wp-includes/class-wp-oembed.php. 
This renames the file containing the `WP_oEmbed` class to conform to the coding standards.

This commit also includes:

- A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45663


git-svn-id: http://core.svn.wordpress.org/trunk@45474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 04:32:57 +00:00
Gary Pendergast
971814047f Coding Standards: Move wp-admin/custom-background.php to wp-admin/includes/class-custom-background.php 
This renames the file containing the Custom_Background class to conform to the coding standards.

This commit also includes:

- A new custom-background.php that includes the new file, for anyone that may've been including the file directly.
- Replaces a reference to the old filename with the new filename.

See #47632.

Built from https://develop.svn.wordpress.org/trunk@45662


git-svn-id: http://core.svn.wordpress.org/trunk@45473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 04:02:55 +00:00
Gary Pendergast
744ffe8e00 Coding Standards: Exclude a handful of incorrectly named files that won't be renamed. 
See #47632.

Built from https://develop.svn.wordpress.org/trunk@45661


git-svn-id: http://core.svn.wordpress.org/trunk@45472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 03:50:59 +00:00
Gary Pendergast
1f5fcff132 Coding Standards: Improve spacing of printf() calls in the admin About pages. 
Props garrett-eclipse.
Fixes #47734.


Built from https://develop.svn.wordpress.org/trunk@45660


git-svn-id: http://core.svn.wordpress.org/trunk@45471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-19 00:09:58 +00:00
Sergey Biryukov
1c331e8931 I18N: Make URLs to https://wordpress.org/about/ and related pages translatable, as they can now be localized on Rosetta sites. 
Props mukesh27.
Fixes #46386.
Built from https://develop.svn.wordpress.org/trunk@45659


git-svn-id: http://core.svn.wordpress.org/trunk@45470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-18 12:41:57 +00:00
Gary Pendergast
22412b1d97 Customizer: Show all widgets when the search field is cleared. 
When clicking the clear button on the widget search field, the search results should refresh to show all widgets.

Props Mahesh901122.
Fixes #47534.

Built from https://develop.svn.wordpress.org/trunk@45658


git-svn-id: http://core.svn.wordpress.org/trunk@45469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-18 05:55:59 +00:00
Sergey Biryukov
7149d65934 Editor: Replace external Classic Editor plugin URL with a link to Add Plugins screen with Classic Editor pre-selected. 
This applies to messages displayed when JavaScript is disabled in Block Editor, or an incompatible meta box is used.

Props garrett-eclipse, derweili, afercia.
Fixes #47487.
Built from https://develop.svn.wordpress.org/trunk@45657


git-svn-id: http://core.svn.wordpress.org/trunk@45468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-18 01:33:57 +00:00
Sergey Biryukov
4b460d0f80 Coding Standards: Fix WPCS issues in [45655]. 
See #47723.
Built from https://develop.svn.wordpress.org/trunk@45656


git-svn-id: http://core.svn.wordpress.org/trunk@45467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 19:22:56 +00:00
Sergey Biryukov
f7c4398ea9 Menus: Trim whitespace from custom link URLs. 
Props majemedia, SergeyBiryukov.
Fixes #47723.
Built from https://develop.svn.wordpress.org/trunk@45655


git-svn-id: http://core.svn.wordpress.org/trunk@45466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 18:45:58 +00:00
Gary Pendergast
24d08a9463 Coding Standards: Move wp-admin/custom-header.php to wp-admin/includes/class-custom-image-header.php 
This renames the file containing the `Custom_Image_Header` class to conform to the coding standards.

This commit also includes:
- A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45654


git-svn-id: http://core.svn.wordpress.org/trunk@45465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 06:17:56 +00:00
Gary Pendergast
83427a87a9 Coding Standards: Exclude some class names from checks when they can't be renamed. 
Renaming the classes would likely cause back compat issues, so the safest option is to allow this handful to continue unchanged.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45653


git-svn-id: http://core.svn.wordpress.org/trunk@45464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 04:34:55 +00:00
Sergey Biryukov
970fe7d85c Coding Standards: Fix WPCS issues in [45651]. 
See #38195.
Built from https://develop.svn.wordpress.org/trunk@45652


git-svn-id: http://core.svn.wordpress.org/trunk@45463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 01:50:58 +00:00
Sergey Biryukov
6cb424b978 Media: Add "Documents", "Spreadsheets", and "Archives" groups to file type filter in Media Library. 
Props zodiac1978, swissspidy, karmatosed, SergeyBiryukov.
Fixes #38195.
Built from https://develop.svn.wordpress.org/trunk@45651


git-svn-id: http://core.svn.wordpress.org/trunk@45462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 01:22:55 +00:00
Sergey Biryukov
1f256f3fdc Administration: In admin-ajax.php, send X-Robots-Tag header earlier, so that it applies before wp_die() when no action parameter was provided. 
Props robi-bobi, harryfear, garrett-eclipse.
Fixes #47711.
Built from https://develop.svn.wordpress.org/trunk@45650


git-svn-id: http://core.svn.wordpress.org/trunk@45461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-17 01:11:56 +00:00
Sergey Biryukov
66afb60397 Site Health: Use consistent verbiage for "Learn more" links. 
Props ronakganatra, garrett-eclipse.
Fixes #47302.
Built from https://develop.svn.wordpress.org/trunk@45649


git-svn-id: http://core.svn.wordpress.org/trunk@45460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 22:28:57 +00:00
Sergey Biryukov
f600647e22 Site Health: Replace "harddrive" with "device" on Site Health Info screen. 
Props chetan200891, timhavinga, Cybr, Clorith.
Fixes #46965.
Built from https://develop.svn.wordpress.org/trunk@45648


git-svn-id: http://core.svn.wordpress.org/trunk@45459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 22:19:55 +00:00
Sergey Biryukov
e5ad773194 I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings. 
Props ramiy.
Fixes #47252.
Built from https://develop.svn.wordpress.org/trunk@45647


git-svn-id: http://core.svn.wordpress.org/trunk@45458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 22:13:58 +00:00
Sergey Biryukov
2ac05ca7d5 Media: Add a unit test for wp_get_mime_types(). 
Props pbearne.
Fixes #47701.
Built from https://develop.svn.wordpress.org/trunk@45646


git-svn-id: http://core.svn.wordpress.org/trunk@45457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 21:52:57 +00:00
Andrew Ozz
5eba5381e6 Media: Sort the new sizes array by priority when creating image sub-sizes. 
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45645


git-svn-id: http://core.svn.wordpress.org/trunk@45456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 21:48:56 +00:00
Sergey Biryukov
6f2fe4da8f Customize: In WP_Customize_Widgets::capture_filter_pre_update_option(), return the filtered value instead of null when bailing early for ignored options. 
Props dlh.
Fixes #47715.
Built from https://develop.svn.wordpress.org/trunk@45644


git-svn-id: http://core.svn.wordpress.org/trunk@45455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 21:33:57 +00:00
Sergey Biryukov
62216de5d4 Docs: Move the do_mu_upgrade DocBlock out of the preceding if statement. 
Props ChriCo, dkarfa.
Fixes #47710.
Built from https://develop.svn.wordpress.org/trunk@45643


git-svn-id: http://core.svn.wordpress.org/trunk@45454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 13:15:58 +00:00
Sergey Biryukov
62dc808103 Docs: Correct @since tag for do_mu_upgrade hook, for consistency with after_mu_upgrade and wpmu_upgrade_site. 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@45642


git-svn-id: http://core.svn.wordpress.org/trunk@45453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-16 12:42:59 +00:00
Sergey Biryukov
c0e53279b3 Comments: Fix typo in comment reply observer options. 
Props maguiar.
Fixes #47706. See #46260.
Built from https://develop.svn.wordpress.org/trunk@45641


git-svn-id: http://core.svn.wordpress.org/trunk@45452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 16:46:55 +00:00
Gary Pendergast
820ce9c438 Code Modernisation: Revert [45624]. 
Changing the method signatures on `Walker` causes back compat issues.

See #47678.



Built from https://develop.svn.wordpress.org/trunk@45640


git-svn-id: http://core.svn.wordpress.org/trunk@45451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 07:04:59 +00:00
Gary Pendergast
a571a7d621 Code Modernisation: Fix known instances of array access on data types that can't be accessed as arrays. 
PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.

This change fixes all of these warnings visible in unit tests.

Props jrf.
See #47704.



Built from https://develop.svn.wordpress.org/trunk@45639


git-svn-id: http://core.svn.wordpress.org/trunk@45450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 06:25:57 +00:00
Gary Pendergast
bd45c7d3b9 Code Modernisation: Document when the Hash polyfills can be removed. 
The Hash extension cannot be disabled as of PHP 7.4. So, while we can't remove these polyfills yet, we can document when we'll be able to.

Props jrf.
Fixes #47698.


Built from https://develop.svn.wordpress.org/trunk@45638


git-svn-id: http://core.svn.wordpress.org/trunk@45449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 05:14:55 +00:00
Gary Pendergast
21df1bda5b Code Modernisation: Remove the SPL autoloader polyfill. 
As of PHP 5.3, the SPL extension cannot be disabled, so we no longer need this polyfill.

The file is kept with a `_deprecated_file()` call, to alert any plugins or themes that may be loading it directly.

Props jrf, ayeshrajans.
See #47698, #46630.


Built from https://develop.svn.wordpress.org/trunk@45637


git-svn-id: http://core.svn.wordpress.org/trunk@45448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 05:11:56 +00:00
Gary Pendergast
501b5f545b Code Modernisation: Remove the array_replace_recursive() polyfill. 
This function was added in PHP 5.3.0, so we no longer need the polyfill.

Props jrf.
See #47698.


Built from https://develop.svn.wordpress.org/trunk@45636


git-svn-id: http://core.svn.wordpress.org/trunk@45447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 05:08:56 +00:00
Gary Pendergast
fbdb267634 WPDB: Allow custom data to be added to logged queries. 
This adds a new method, `wpdb::log_query()`, and a new filter, `log_query_custom_data`. The custom data is stored as a new element in each entry of the `wpdb::$queries` array.

Props CrazyJaco, johnbillion, pento.
Fixes 42151.

Built from https://develop.svn.wordpress.org/trunk@45635


git-svn-id: http://core.svn.wordpress.org/trunk@45446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-15 04:07:57 +00:00
Sergey Biryukov
83d175cdd0 I18N: Add context for theme filter strings in WP_MS_Themes_List_Table::get_views(). 
Props audrasjb.
Fixes #47695.
Built from https://develop.svn.wordpress.org/trunk@45634


git-svn-id: http://core.svn.wordpress.org/trunk@45445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-14 14:47:56 +00:00
Sergey Biryukov
436a9512e2 Upgrade/Install: Remove debugging artifacts from wp-admin/upgrade.php added in [1229]. 
Props rahulvaza.
Fixes #47074.
Built from https://develop.svn.wordpress.org/trunk@45633


git-svn-id: http://core.svn.wordpress.org/trunk@45444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-14 14:39:57 +00:00
Sergey Biryukov
e85a5c64a3 REST API: Allow rest_get_avatar_urls() to accept full user, post, or comment objects, rather than just an email address, to provide better flexibility for alternative avatar data. 
Since the function uses `get_avatar_url()` internally, which already supports it, this should not have any backward compatibility concerns.

Props donmhico, dshanske, pputzer, joehoyle, TimothyBlynJacobs.
Fixes #40030.
Built from https://develop.svn.wordpress.org/trunk@45632


git-svn-id: http://core.svn.wordpress.org/trunk@45443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-14 14:35:56 +00:00
Andrew Ozz
ee8813606d TinyMCE: fix adding of too many undo levels for wpviews. The HTML changes several times when a wpview is added. We only want one undo level. Also fixes cases when the cursor is next to an embeddable URL in the Text tab and the user switches to the Visual tab. 
See #45307.
Built from https://develop.svn.wordpress.org/trunk@45631


git-svn-id: http://core.svn.wordpress.org/trunk@45442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 03:25:55 +00:00
Gary Pendergast
4d3a84aa9f Code Modernisation: Introduce the spread operator in wpdb::prepare(). 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45630


git-svn-id: http://core.svn.wordpress.org/trunk@45441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:17:57 +00:00
Gary Pendergast
2fe355cdd0 Code Modernisation: Introduce the spread operator in widgets.php. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45629


git-svn-id: http://core.svn.wordpress.org/trunk@45440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:14:58 +00:00
Gary Pendergast
afdbf749d7 Code Modernisation: Introduce the spread operator in theme.php. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf, pento.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45628


git-svn-id: http://core.svn.wordpress.org/trunk@45439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:10:56 +00:00
Gary Pendergast
1af80c2106 Code Modernisation: Introduce the spread operator in walk_page_dropdown_tree(). 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45627


git-svn-id: http://core.svn.wordpress.org/trunk@45438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:06:55 +00:00
Sergey Biryukov
02c07f23d5 Customize: Fix text direction for color picker in RTL. 
Props vjik for the report.
Fixes #47688. See #23740.
Built from https://develop.svn.wordpress.org/trunk@45626


git-svn-id: http://core.svn.wordpress.org/trunk@45437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:05:57 +00:00
Gary Pendergast
5fb46ff14b Code Modernisation: Introduce the spread operator in add_post_type_support(). 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf, pento.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45625


git-svn-id: http://core.svn.wordpress.org/trunk@45436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-12 00:02:56 +00:00
Gary Pendergast
41ea1f106d Code Modernisation: Introduce the spread operator in Walker. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45624


git-svn-id: http://core.svn.wordpress.org/trunk@45435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 23:51:56 +00:00
Gary Pendergast
4de2f2f49b Code Modernisation: Introduce the spread operator in WP_User. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45623


git-svn-id: http://core.svn.wordpress.org/trunk@45434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 23:48:56 +00:00
Gary Pendergast
5d658427a8 Code Modernisation: Introduce the spread operator in capabilities.php. 
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

Built from https://develop.svn.wordpress.org/trunk@45622


git-svn-id: http://core.svn.wordpress.org/trunk@45433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 23:46:56 +00:00
Andrew Ozz
ff723a2fba Editor: Make registered editor stylesheets (editor-style.css) available to the front-end. 
Props webmandesign, azaozz.
Fixes #34882.
Built from https://develop.svn.wordpress.org/trunk@45621


git-svn-id: http://core.svn.wordpress.org/trunk@45432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 18:30:57 +00:00
Andrew Ozz
969699260d TinyMCE: fix flickering inline toolbar when showing a tooltip. Take two. 
Fixes #44911.
Built from https://develop.svn.wordpress.org/trunk@45620


git-svn-id: http://core.svn.wordpress.org/trunk@45431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 18:18:58 +00:00
Gary Pendergast
bb8afb46b9 Block Editor: Avoid a PHP warning when a theme adds an editor style with an empty filename. 
Fixes #45739.

Built from https://develop.svn.wordpress.org/trunk@45619


git-svn-id: http://core.svn.wordpress.org/trunk@45430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 07:21:55 +00:00
Gary Pendergast
4c3d541e23 Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected. 
Props tmatsuur, mukesh27.
Fixes #45935.

Built from https://develop.svn.wordpress.org/trunk@45618


git-svn-id: http://core.svn.wordpress.org/trunk@45429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 06:01:58 +00:00
Sergey Biryukov
7369ff02f5 Coding Standards: Remove extra whitespace in list tables' column_cb() methods. 
See #47632.
Built from https://develop.svn.wordpress.org/trunk@45617


git-svn-id: http://core.svn.wordpress.org/trunk@45428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 21:11:58 +00:00
Sergey Biryukov
9a5f538153 Coding Standards: Remove extra whitespace in wp-admin/includes/image-edit.php. 
See #47632.
Built from https://develop.svn.wordpress.org/trunk@45616


git-svn-id: http://core.svn.wordpress.org/trunk@45427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 21:05:57 +00:00
Sergey Biryukov
6a696f6051 I18N: Move code out of translatable string in a _deprecated_argument() message in wp_stream_image(), wp_save_image_file(), and image_edit_apply_changes(). 
Props ramiy.
Fixes #47406.
Built from https://develop.svn.wordpress.org/trunk@45615


git-svn-id: http://core.svn.wordpress.org/trunk@45426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 20:57:56 +00:00
Sergey Biryukov
bb365054b8 Menus: Remove extra whitespace from URLs in Walker_Nav_Menu_Edit::start_el(). 
Props alexeyskr, SergeyBiryukov.
Fixes #47666.
Built from https://develop.svn.wordpress.org/trunk@45614


git-svn-id: http://core.svn.wordpress.org/trunk@45425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 20:45:56 +00:00
Sergey Biryukov
29e5155969 Filesystem API: Check correct variable in WP_Filesystem_Direct::dirlist() after [45611]. 
Props zinigor.
Fixes #47668. See #47632.
Built from https://develop.svn.wordpress.org/trunk@45613


git-svn-id: http://core.svn.wordpress.org/trunk@45424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 15:58:57 +00:00
Gary Pendergast
4be25f3d06 Coding Standards: Fix instances of WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase. 
See #46732.

Built from https://develop.svn.wordpress.org/trunk@45612


git-svn-id: http://core.svn.wordpress.org/trunk@45423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 06:29:57 +00:00
Gary Pendergast
abcbee954f Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged. 
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

Built from https://develop.svn.wordpress.org/trunk@45611


git-svn-id: http://core.svn.wordpress.org/trunk@45422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 05:45:58 +00:00
Andrew Ozz
4a273484f3 TinyMCE: fix flickering inline toolbar when hovering over the buttons there and the vertical scrollbar is not shown (the page height is less than the window height). Improves/removes the previous fix for similar flickering but only in RTL, see #42018. 
Props joakimsilfverberg, mukesh27, kokers, Howdy_McGee, noisysocks, azaozz.
Fixes #44911.
Built from https://develop.svn.wordpress.org/trunk@45610


git-svn-id: http://core.svn.wordpress.org/trunk@45421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 01:11:55 +00:00
Gary Pendergast
c71bc1513e Coding Standards: Add missing translator comments to the default themes. 
All default themes now have translator comments for all strings with placeholders!

See #46732.

Built from https://develop.svn.wordpress.org/trunk@45609


git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 01:10:00 +00:00
Gary Pendergast
82935b0343 Theme Editor: Hide the recommendation to create a child theme when editing a child theme. 
Props mukesh27, davidbaumwald.
Fixes #44889.

Built from https://develop.svn.wordpress.org/trunk@45608


git-svn-id: http://core.svn.wordpress.org/trunk@45419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-08 03:15:56 +00:00
Gary Pendergast
ec07a7e565 Coding Standards: Fix the remaining issues in /tests. 
All PHP files in `/tests` now conform to the PHP coding standards, or have exceptions appropriately marked.

Travis now also runs `phpcs` on the `/tests` directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45607


git-svn-id: http://core.svn.wordpress.org/trunk@45418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-08 00:56:56 +00:00
laurelfulford
83e19085a3 Twenty Thirteen: Add styles for the new Group block. 
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments. 

Props @kjellr.
Fixes #46778.


Built from https://develop.svn.wordpress.org/trunk@45606


git-svn-id: http://core.svn.wordpress.org/trunk@45417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-07 20:49:55 +00:00
laurelfulford
5b4b6d98ce Twenty Nineteen: Add styles for the new Group block. 
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments. 

Props @kjellr, @dianeco.
Fixes #46750.


Built from https://develop.svn.wordpress.org/trunk@45605


git-svn-id: http://core.svn.wordpress.org/trunk@45416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-07 20:11:57 +00:00
Gary Pendergast
28a8f31ffa Coding Standards: Add missing translator comments. 
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.

Also, WPCS now doesn't show missing translator comment warnings for test files.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45604


git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 08:04:57 +00:00
Gary Pendergast
14c7533162 Coding Standards: Fix all WordPress.DB.PreparedSQLPlaceholders issues. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45603


git-svn-id: http://core.svn.wordpress.org/trunk@45414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 05:43:55 +00:00
Gary Pendergast
87675d288b Coding Standards: Fix all WordPress.WhiteSpace.PrecisionAlignment issues. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45602


git-svn-id: http://core.svn.wordpress.org/trunk@45413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 05:21:56 +00:00
Gary Pendergast
f69c20859e Coding Standards: Fix all WordPress.CodeAnalysis.AssignmentInCondition issues. 
`WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition` can be ignored, as this is allowed in Core.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45601


git-svn-id: http://core.svn.wordpress.org/trunk@45412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 03:14:56 +00:00
Gary Pendergast
d378f0a8f4 Coding Standards: Upgrade WPCS to 2.1.1. 
Noteable changes:
- WPCS now throws warnings when non-strict comparisons are used. There are quite a few of them in Core. 🙃
- WPCS now detects and warns for assignments in loop conditions.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45600


git-svn-id: http://core.svn.wordpress.org/trunk@45411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 02:50:56 +00:00
Gary Pendergast
a02b5cc2a8 Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45599


git-svn-id: http://core.svn.wordpress.org/trunk@45410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 01:45:56 +00:00
Sergey Biryukov
b8be081e7e Text Changes: Use consistent question wording in database connection error messages. 
Props Presskopp.
See #44878.
Built from https://develop.svn.wordpress.org/trunk@45598


git-svn-id: http://core.svn.wordpress.org/trunk@45409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 10:58:56 +00:00
Sergey Biryukov
4af4c78a27 Text Changes: Use consistent question wording for plugin and theme deletion confirmations. 
Props johnjamesjacoby, Presskopp.
Fixes #44878.
Built from https://develop.svn.wordpress.org/trunk@45597


git-svn-id: http://core.svn.wordpress.org/trunk@45408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 09:56:57 +00:00
Sergey Biryukov
abe3ec288b Twenty Nineteen: Fix markup errors in twentynineteen_add_ellipses_to_nav(): 
* Add missing i18n for `aria-label` attribute.
* Remove redundant screen reader text superseded by `aria-label`.
* Remove unnecessary `id` and `class` attributes.

Props afercia, chetan200891, ianbelanger.
Fixes #47067.
Built from https://develop.svn.wordpress.org/trunk@45596


git-svn-id: http://core.svn.wordpress.org/trunk@45407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 09:23:55 +00:00
Sergey Biryukov
d1815a5c91 Twenty Nineteen: Adjust markup in twentynineteen_add_ellipses_to_nav() for better readability. 
See #47067.
Built from https://develop.svn.wordpress.org/trunk@45595


git-svn-id: http://core.svn.wordpress.org/trunk@45406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 09:15:58 +00:00
Sergey Biryukov
f84ab5e19f Twenty Nineteen: Update package.json with the latest package versions to pass npm audit. 
Props netweb.
Fixes #47631.
Built from https://develop.svn.wordpress.org/trunk@45594


git-svn-id: http://core.svn.wordpress.org/trunk@45405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 00:38:58 +00:00
Sergey Biryukov
3a57fee891 Script Loader: Remove unnecessary jquery dependency for wp-sanitize.js. 
The file is written in plain JavaScript.

Props sstoqnov.
Fixes #47324.
Built from https://develop.svn.wordpress.org/trunk@45593


git-svn-id: http://core.svn.wordpress.org/trunk@45404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 00:33:57 +00:00
Sergey Biryukov
f154cd0780 Bundled Themes: Remove extra semicolons from CSS files. 
Props shashank3105, ianbelanger.
Fixes #47178.
Built from https://develop.svn.wordpress.org/trunk@45592


git-svn-id: http://core.svn.wordpress.org/trunk@45403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 00:27:58 +00:00
Sergey Biryukov
268c64913e Query: Make sure $climits variable in WP_Query::get_posts() is always defined to avoid a PHP notice. 
Props juiiee8487, agengineering.
Fixes #47638.
Built from https://develop.svn.wordpress.org/trunk@45591


git-svn-id: http://core.svn.wordpress.org/trunk@45402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-03 01:14:57 +00:00
Gary Pendergast
4803fc405e Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45590


git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 23:42:58 +00:00
Gary Pendergast
55b2d94cca Formatting: Revert the changes to wpautop() in [45585,45587]. 
See #27350.

Built from https://develop.svn.wordpress.org/trunk@45589


git-svn-id: http://core.svn.wordpress.org/trunk@45400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 11:22:56 +00:00
Gary Pendergast
073f379fd3 Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in tests. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45588


git-svn-id: http://core.svn.wordpress.org/trunk@45399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 04:43:57 +00:00
Gary Pendergast
b57d185bb1 Formatting: Improve performance of wpautop() on large paragraphs. 
Following [45585], older versions of PHP could segfault when attempting to autop paragraphs with 10,000+ characters.

Rather than having to negative lookahead for every character in the paragraph (which could run into recursion limits), we can quickly jump ahead to the next tag and start checking from there.

See #27350.


Built from https://develop.svn.wordpress.org/trunk@45587


git-svn-id: http://core.svn.wordpress.org/trunk@45398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 03:29:55 +00:00
Gary Pendergast
d7b95b1a86 Docs: Update some function docs and signatures. 
- Update the `_wp_specialchars()` docs to match the function signature.
- Update the `human_time_diff()` function signature to match the docs.

Props subrataemfluence.
Fixes #46845.


Built from https://develop.svn.wordpress.org/trunk@45586


git-svn-id: http://core.svn.wordpress.org/trunk@45397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 01:45:58 +00:00
Gary Pendergast
23de362563 Clean up stray <p> tags added by wpautop() inside block level tags. 
`autop()` can sometimes get confused and not clean up stray `<p>` or `</p>` tags inside block level elements, which produces sub-optimal HTML. While browsers can generally handle it, there's no need to make things harder for them if we don't have to.

Props pento, ayubi, pbearne, jond, azaozz, 1994rstefan, dionysous, MikeHansenMe, jorbin, miqrogroove, niallkennedy.
Fixes #27350.



Built from https://develop.svn.wordpress.org/trunk@45585


git-svn-id: http://core.svn.wordpress.org/trunk@45396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 01:31:56 +00:00
Adam Silverstein
4568c13df8 Taxonomy: add a new 'terms_pre_query' filter to short circuit WP_Term_Query 'get_terms' queries. 
Add a new `terms_pre_query` filter which returns null by default. Return a non-null value to bypass WordPress's default `get_terms` queries.

Props jarocks, boonebgorges, spacedmonkey.
Fixes #41246.


Built from https://develop.svn.wordpress.org/trunk@45584


git-svn-id: http://core.svn.wordpress.org/trunk@45395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 20:48:58 +00:00
Gary Pendergast
cf3fa9f7c8 Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45583


git-svn-id: http://core.svn.wordpress.org/trunk@45394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 12:52:01 +00:00
Gary Pendergast
b2d5a4216c Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in the base directory. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45582


git-svn-id: http://core.svn.wordpress.org/trunk@45393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 08:27:58 +00:00
Gary Pendergast
0d23be600e Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in the default themes. 
See #47632


Built from https://develop.svn.wordpress.org/trunk@45581


git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 08:23:57 +00:00
Gary Pendergast
55af0f0d0a Coding Standards: Fix/ignore the WordPress.NamingConventions.ValidFunctionName violations. 
See #47632


Built from https://develop.svn.wordpress.org/trunk@45580


git-svn-id: http://core.svn.wordpress.org/trunk@45391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 08:01:57 +00:00
Gary Pendergast
072682b1ed Multisite: Use size_format() in display_space_usage(). 
Deleted code is the best code.

Fixes #28239.


Built from https://develop.svn.wordpress.org/trunk@45579


git-svn-id: http://core.svn.wordpress.org/trunk@45390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 03:47:56 +00:00
Gary Pendergast
abc0f7dd32 Formatting: Trim leading whitespace in esc_url(). 
Props toszcze.
Fixes #36369.


Built from https://develop.svn.wordpress.org/trunk@45578


git-svn-id: http://core.svn.wordpress.org/trunk@45389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 03:29:57 +00:00
Gary Pendergast
f3ece5149f Formatting: Don't add <p> tags inside <svg> tags. 
Inline `<svg>`s should generally work, as browsers should just ignore `<p>` or `<br/>` tags that shouldn't be inside the `<svg>`. To keep things neat, however, it's better not add them in the first place.

Props jared_smith, nacin, pento.
Fixes #9437.


Built from https://develop.svn.wordpress.org/trunk@45577


git-svn-id: http://core.svn.wordpress.org/trunk@45388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 03:19:58 +00:00
Sergey Biryukov
93f3335f13 Twenty Seventeen: Correct the CSS selectors intended to fix hover colors for MediaElement controls. 
This is a follow-up to the previous fix in [45146], which didn't work as expected.

Props ryokuhi.
Fixes #47543. See #40843.
Built from https://develop.svn.wordpress.org/trunk@45576


git-svn-id: http://core.svn.wordpress.org/trunk@45387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-29 00:51:58 +00:00
youknowriad
405efef86c Build/Test Tools: Fix the hello e2e test assertion. 
The previous assertion was always valid because we assumed it returned a single object,
while in reality it was returning an array.

Props hideokamoto.
Fixes #47622.

Built from https://develop.svn.wordpress.org/trunk@45575


git-svn-id: http://core.svn.wordpress.org/trunk@45386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-28 11:34:58 +00:00
Gary Pendergast
691ffce019 Formatting: Add correct <p> tags near <hr> tags. 
It can be tricky to know when `wpautop()` should add `<p>` tags, but one thing we can be certain about is that they really shouldn't be anywhere near `<hr>` tags.

Now they aren't.

Props solarissmoke, MattyRob, pento.
Fixes #14674.


Built from https://develop.svn.wordpress.org/trunk@45574


git-svn-id: http://core.svn.wordpress.org/trunk@45385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-28 07:16:56 +00:00
Gary Pendergast
dd38e9cc0b Formatting: Add support for seconds to human_time_diff(). 
The web has gotten so much faster since `human_time_diff()` was created, we need to be able to measure time differences with much finer granularity. Now, we can.

Props johnjamesjacoby, pento.
Fixes #35655.


Built from https://develop.svn.wordpress.org/trunk@45573


git-svn-id: http://core.svn.wordpress.org/trunk@45384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-28 06:44:57 +00:00
Andrea Fercia
00704114e0 Accessibility: Make the Media modal an ARIA modal dialog. 
For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.

This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.

This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for `aria-modal="true"` improves.

Additionally:
- moves the modal H1 heading to the beginning of the modal content 
- changes the modal left menu position to make visual and DOM order match 
- improves the `wp.media.view.FocusManager` documentation

Fixes #47145.

Built from https://develop.svn.wordpress.org/trunk@45572


git-svn-id: http://core.svn.wordpress.org/trunk@45383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 12:33:56 +00:00
youknowriad
1714484132 Build/Test Tools: Make the local env scripts executable. 
See #45165.

Built from https://develop.svn.wordpress.org/trunk@45571


git-svn-id: http://core.svn.wordpress.org/trunk@45382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 12:06:55 +00:00
youknowriad
5cf8452ae9 Build/Test Tools: Add the e2e tests setup. 
- Adds a local environment based on docker
 - Adds the e2e tests setup
 - Adds a "Hello World" e2e test to serve as a template

Props gziolo, herregroen, mcsf.
Fixes #45165.

Built from https://develop.svn.wordpress.org/trunk@45570


git-svn-id: http://core.svn.wordpress.org/trunk@45381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 11:28:19 +00:00
Gary Pendergast
d2a64fdabd Formatting: Don't convert smilies in ignored tags that have attributes. 
Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a `class` to the `<pre>` tag.

Props pento, jikamens.
Fixes #47489.


Built from https://develop.svn.wordpress.org/trunk@45569


git-svn-id: http://core.svn.wordpress.org/trunk@45380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 02:05:52 +00:00
Sergey Biryukov
573daa129c Users: Pass $length, $special_chars, and $extra_special_chars parameters to the random_password filter in wp_generate_password(). 
Props roytanck.
Fixes #47092.
Built from https://develop.svn.wordpress.org/trunk@45568


git-svn-id: http://core.svn.wordpress.org/trunk@45379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 00:48:53 +00:00
Sergey Biryukov
9d7bd11631 Docs: Correct @since for admin/edit-comments.js, introduced in [3736]. 
See #47581.
Built from https://develop.svn.wordpress.org/trunk@45567


git-svn-id: http://core.svn.wordpress.org/trunk@45378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-26 18:19:52 +00:00