Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-13 22:26:06 +01:00
Code Issues Projects Releases Wiki Activity
39,640 Commits 50 Branches 748 Tags 792 MiB
373c82a7c4
Commit Graph

54 Commits

Author SHA1 Message Date
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Gary Pendergast
c90cfa3b50 General: Fix some precision alignment formatting warnings. 
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42228


git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-26 23:57:55 +00:00
Sergey Biryukov
ac5096d8bd Embeds: Avoid "Division by zero" warning in embed-content.php template if a thumbnail has a zero height. 
Props stevenlinx, aegis123.
Fixes #40931.
Built from https://develop.svn.wordpress.org/trunk@41902


git-svn-id: http://core.svn.wordpress.org/trunk@41736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-10-18 15:09:48 +00:00
Sergey Biryukov
f69b784ec7 Embeds: Introduce embed_thumbnail_id filter for thumbnail image ID in the embed template. 
Props ketuchetan, Dency, jontyravi, Ov3rfly.
Fixes #39759.
Built from https://develop.svn.wordpress.org/trunk@41565


git-svn-id: http://core.svn.wordpress.org/trunk@41398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-22 17:35:48 +00:00
Dominik Schilling
b9d99d3288 Embeds: Don't print the HTML for a featured image if a post has no featured image. 
See [36693].
Fixes #37288.
Built from https://develop.svn.wordpress.org/trunk@37988


git-svn-id: http://core.svn.wordpress.org/trunk@37929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-06 17:08:31 +00:00
Sergey Biryukov
139387b7e5 Docs: Use 3-digit, x.x.x-style semantic versioning for _doing_it_wrong(), _deprecated_function(), _deprecated_argument(), and _deprecated_file() throughout core. 
Props metodiew.
Fixes #36495.
Built from https://develop.svn.wordpress.org/trunk@37985


git-svn-id: http://core.svn.wordpress.org/trunk@37926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-07-06 12:40:29 +00:00
Drew Jaynes
bef05b469b Docs: Standardize DocBlock summaries for hooks that serve to "print" something to use third-person singular verbs. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37560


git-svn-id: http://core.svn.wordpress.org/trunk@37528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-25 16:05:27 +00:00
Drew Jaynes
9cb5247392 Docs: Standardize filter docs in remaining wp-includes/* files to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37518


git-svn-id: http://core.svn.wordpress.org/trunk@37486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:50:28 +00:00
Pascal Birchler
d60b748652 Embeds: Change attachment metadata condition to prevent a warning in the embeds template. 
See #35237.
Fixes #36838 for trunk.
Built from https://develop.svn.wordpress.org/trunk@37452


git-svn-id: http://core.svn.wordpress.org/trunk@37420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-17 20:33:29 +00:00
Drew Jaynes
b1804afeaf Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs. 
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.

Built from https://develop.svn.wordpress.org/trunk@37431


git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-13 18:41:31 +00:00
Drew Jaynes
0e53ff6692 Docs: Standardize file headers for two embed templates introduced in [36693] for #34561. 
Props flixos90.
Also missed props for flixos90 on [37087].

See #35986. See #36352.

Built from https://develop.svn.wordpress.org/trunk@37088


git-svn-id: http://core.svn.wordpress.org/trunk@37055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-28 18:27:26 +00:00
Drew Jaynes
0405289c03 Docs: Reference the correct embed templates and template parts filenames in headers for embed files introduced or changed in 4.5. 
See [36693], #34561. See #35986. Fixes #36352.

Built from https://develop.svn.wordpress.org/trunk@37087


git-svn-id: http://core.svn.wordpress.org/trunk@37054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-28 18:24:27 +00:00
Drew Jaynes
0fc00feec3 Embeds: Introduce embed templates into the template hierarchy via theme-compat. 
Splits wp-includes/embed-template.php, introduced in 4.4, into five new templates that can be individually overridden by themes:

* embed.php
* embed-404.php
* embed-content.php
* header-embed.php
* footer-embed.php

Also introduces a new template tag for outputting the site title, `the_embed_site_title()`.

The five new templates live in theme-compat, allowing for graceful fallbacks should themes prefer not to override any or all of them.

Props swissspidy, imath, ocean90, DrewAPicture.
See #34561.

Built from https://develop.svn.wordpress.org/trunk@36693


git-svn-id: http://core.svn.wordpress.org/trunk@36660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-02-24 20:57:26 +00:00
Dominik Schilling
21b9965613 Theme Compat: Replace the custom comment form with comment_form() and reduce number of links. 
`comment_form()` has nearly the same markup as the custom form but also includes the latest enhancements like improved a11y and more filters.

Add translators comments, props ramiy.

Fixes #35888.
Built from https://develop.svn.wordpress.org/trunk@36595


git-svn-id: http://core.svn.wordpress.org/trunk@36562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-02-20 14:41:27 +00:00
John Blackbourn
a027edc277 Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times. 
Twelve years later, after no fewer than three themes have intentionally implemented popup comments in their functionality, before being abandoned for at least the last six years, we've reached a time where we can put this era behind us. A time when we can remove comment popup functionality from WordPress.

If this breaks the internet, I'll eat my hat.

Fixes #28617

Built from https://develop.svn.wordpress.org/trunk@35848


git-svn-id: http://core.svn.wordpress.org/trunk@35812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-10 03:06:30 +00:00
Sergey Biryukov
9876e2cccf Don't use <a> in translatable strings in theme-compat/sidebar.php. 
Add translator comments.

Props ramiy.
Fixes #34503.
Built from https://develop.svn.wordpress.org/trunk@35458


git-svn-id: http://core.svn.wordpress.org/trunk@35422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-30 10:40:26 +00:00
Sergey Biryukov
ba55e98b24 Add translator comments for strings in theme-compat/header.php. 
Props ramiy.
See #34503.
Built from https://develop.svn.wordpress.org/trunk@35457


git-svn-id: http://core.svn.wordpress.org/trunk@35421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-30 10:39:25 +00:00
Sergey Biryukov
7b70909232 Add translator comments for strings in theme-compat/footer.php. 
Props ramiy.
See #34503.
Built from https://develop.svn.wordpress.org/trunk@35456


git-svn-id: http://core.svn.wordpress.org/trunk@35420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-30 10:38:49 +00:00
Sergey Biryukov
d8f50fef8a Don't use <a> in translatable string in theme-compat/comments.php. 
Add translator comments.

Props ramiy.
See #34503.
Built from https://develop.svn.wordpress.org/trunk@35455


git-svn-id: http://core.svn.wordpress.org/trunk@35419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-30 10:38:25 +00:00
Sergey Biryukov
c342525d42 Add translator comments for strings in theme-compat/comments-popup.php. 
Props ramiy.
See #34503.
Built from https://develop.svn.wordpress.org/trunk@35454


git-svn-id: http://core.svn.wordpress.org/trunk@35418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-30 10:35:24 +00:00
Konstantin Obenland
c69e96422b Themes: Improve document title output. 
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.


Built from https://develop.svn.wordpress.org/trunk@35294


git-svn-id: http://core.svn.wordpress.org/trunk@35260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-20 16:21:25 +00:00
Dominik Schilling
d5be34186c Theme Compat: Remove two strings from comments-popup.php. 
`theme-compat/comments-popup.php` is a deprecated file. Instead of improving the strings in [34342] remove both superfluous paragraphs.

See #31867.
Built from https://develop.svn.wordpress.org/trunk@34351


git-svn-id: http://core.svn.wordpress.org/trunk@34315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 08:49:27 +00:00
Scott Taylor
630d3db338 Theme Compat: Avoid using HTML tags in translation strings. 
Props ramiy.	
Fixes #31867.

Built from https://develop.svn.wordpress.org/trunk@34342


git-svn-id: http://core.svn.wordpress.org/trunk@34306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-20 02:47:24 +00:00
Dominik Schilling
0891de90e0 Theme Compat: Remove commented out code. 
See #31867.
Built from https://develop.svn.wordpress.org/trunk@34316


git-svn-id: http://core.svn.wordpress.org/trunk@34280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-18 21:38:25 +00:00
Scott Taylor
c3f642bea9 After [33961], pass $comment to get_comment_date() where possible to avoid extra cache/db lookups. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34041


git-svn-id: http://core.svn.wordpress.org/trunk@34009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 06:15:24 +00:00
Scott Taylor
fc328f5484 After [33961], pass $comment to get_comment_author_link() where possible to avoid extra cache/db lookups. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34039


git-svn-id: http://core.svn.wordpress.org/trunk@34007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 06:05:24 +00:00
Helen Hou-Sandí
1f500055a6 Drop the hyphen from e-mail and standardize on email. 
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.

Built from https://develop.svn.wordpress.org/trunk@33774


git-svn-id: http://core.svn.wordpress.org/trunk@33742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-28 03:17:21 +00:00
Sergey Biryukov
ddff6fe471 Don't capitalize words in a sentence after comma. 
props bjornjohansen, netweb.
fixes #31927.
Built from https://develop.svn.wordpress.org/trunk@33079


git-svn-id: http://core.svn.wordpress.org/trunk@33050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-04 00:50:25 +00:00
Mark Jaquith
cf38b016e8 Revert [33038] because of objections raised on #22889 and #31590 
Built from https://develop.svn.wordpress.org/trunk@33042


git-svn-id: http://core.svn.wordpress.org/trunk@33013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 00:47:24 +00:00
Mark Jaquith
9d11efe23c Say goodbye to ?replytocom=123 links and their URL pollution. 
* Comment reply links continue to use JS as before.
* ?replytocom=123 links are deprecated.

props joostdevalk
fixes #22889
Built from https://develop.svn.wordpress.org/trunk@33038


git-svn-id: http://core.svn.wordpress.org/trunk@33009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 21:42:25 +00:00
John Blackbourn
da99450d30 Add a sanity check to theme-compat/header.php to avoid outputting CSS which could reference a non-existant file. 
Props Mte90

Fixes 32240

Built from https://develop.svn.wordpress.org/trunk@32496


git-svn-id: http://core.svn.wordpress.org/trunk@32466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-12 10:47:29 +00:00
Dominik Schilling
79a930aeb5 Theme Compat: Make string translatable and add translator comments. Added in [31941]. 
props dimadin.
see #28502.
fixes #31921.
Built from https://develop.svn.wordpress.org/trunk@32084


git-svn-id: http://core.svn.wordpress.org/trunk@32063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-08 18:15:28 +00:00
Sergey Biryukov
36643388ef Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings. 
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.

fixes #28502.
Built from https://develop.svn.wordpress.org/trunk@31941


git-svn-id: http://core.svn.wordpress.org/trunk@31920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-31 18:45:28 +00:00
John Blackbourn
bdd00b3902 Improve various hook and filter docs so they are correctly parsed for the code reference. 
Fixes #30558
Props DrewAPicture

Built from https://develop.svn.wordpress.org/trunk@30754


git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:32:24 +00:00
Scott Taylor
bee6492b9b Eliminate use of extract() in wp-includes/theme-compat/comments-popup.php. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28381


git-svn-id: http://core.svn.wordpress.org/trunk@28209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:40:16 +00:00
Andrew Nacin
57baf9ad8e Theme compat: Move <head profile> to <link>. 
props spmlucas.
fixes #24523.

Built from https://develop.svn.wordpress.org/trunk@27716


git-svn-id: http://core.svn.wordpress.org/trunk@27555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 17:22:15 +00:00
Andrew Nacin
0c16c0477b Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc. 
props Ipstenu, markjaquith.
see #27115.

Built from https://develop.svn.wordpress.org/trunk@27369


git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 02:34:27 +00:00
Andrew Nacin
e230a71bdb Use site_url() in theme-compat. 
props technosailor.
see #25418.

Built from https://develop.svn.wordpress.org/trunk@25672


git-svn-id: http://core.svn.wordpress.org/trunk@25588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-02 21:17:09 +00:00
Andrew Nacin
30d048a1e7 Don't return encoded ampersands from get_post_comments_feed_link() to avoid canonical redirect issues. Apply esc_url() when appropriate. 
props markjaquith, SergeyBiryukov. fixes #21841.



git-svn-id: http://core.svn.wordpress.org/trunk@22431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 19:56:10 +00:00
ryan
7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307 
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-30 18:30:03 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
ryan
616c35e71c One newline is enough. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:10:39 +00:00
nacin
43eae59235 Translated strings in attributes require esc_attr(). s/_e/esc_attr_e/g 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-20 15:04:46 +00:00
azaozz
5256d7951f <!DOCTYPE html> for all, fixes #18202 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-22 00:25:41 +00:00
nacin
881a4cc5e3 Call comment_type() without arguments that way 'Comment' is translated internally with context. fixes #15798. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-20 10:44:14 +00:00
nacin
0552424317 Revert submit_button() for wp-includes, setup-config, install, login, signup. see [16061], see #15064, fixes #15247. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-29 00:31:27 +00:00
markjaquith
fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 21:56:43 +00:00
nacin
5e1184aa57 Pinking shears. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-19 07:48:22 +00:00
nacin
6310ca6f21 Don't use deprecated functions. props filosofo, fixes #13854. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-11 17:49:35 +00:00