Upstream
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
41,263 Commits 48 Branches 718 Tags 906 MiB
Commit Graph

64 Commits

Author SHA1 Message Date
Sergey Biryukov 38676936ba Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47550


git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-04-05 03:02:11 +00:00
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards. 
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-01-29 00:45:18 +00:00
Sergey Biryukov e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation. 
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-03 00:41:05 +00:00
desrosj e7c8b21e71 Coding Standards: Dynamic hooks should be named using interpolation not concatenation. 
Props arena, desrosj.
Fixes #47052.
Built from https://develop.svn.wordpress.org/trunk@45881


git-svn-id: http://core.svn.wordpress.org/trunk@45692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-22 19:08:55 +00:00
Sergey Biryukov 83187125e4 Bundled Themes: Audit and update version numbers passed to `wp_enqueue_script()` to ensure proper cache busting. 
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981.
Built from https://develop.svn.wordpress.org/trunk@45768


git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-08 01:29:58 +00:00
Sergey Biryukov e0563013ed Bundled Themes: Audit and update version numbers passed to `wp_enqueue_style()` to ensure proper cache busting. 
Props dswebsme, ianbelanger, desrosj.
Fixes #46979.
Built from https://develop.svn.wordpress.org/trunk@45767


git-svn-id: http://core.svn.wordpress.org/trunk@45578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-08-08 01:25:58 +00:00
Sergey Biryukov ac10f9b9e4 Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article. 
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.
Built from https://develop.svn.wordpress.org/trunk@45675


git-svn-id: http://core.svn.wordpress.org/trunk@45486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-25 22:46:55 +00:00
Gary Pendergast 28a8f31ffa Coding Standards: Add missing translator comments. 
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.

Also, WPCS now doesn't show missing translator comment warnings for test files.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45604


git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 08:04:57 +00:00
Gary Pendergast 0d23be600e Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in the default themes. 
See #47632


Built from https://develop.svn.wordpress.org/trunk@45581


git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 08:23:57 +00:00
desrosj 47ad9774e3 Bundled Themes: Reverts [45213]. 
Reverting to address backward compatibility concerns in Twenty Eleven and Twenty Ten.

See #39997.
Built from https://develop.svn.wordpress.org/trunk@45218


git-svn-id: http://core.svn.wordpress.org/trunk@45027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 18:22:52 +00:00
desrosj 464535d0d3 Bundled Themes: Use the theme version when enqueuing theme specific stylesheets. 
For many bundled theme related stylesheets, a version is either not specified, or specified as a hardcoded date string when enqueued. This is problematic when a stylesheet is updated and the version number is not (which has happened several times recently). This change ensures that all bundled theme related stylesheets use the theme’s version as the stylesheet version. This ensures cache busting for theme stylesheets every time a theme is updated and guarantees that users receive any new or updated styles included in the update when visiting the site for the first time after an update.

Props parsmizban, ianbelanger, dswebsme.
Fixes #39997.
Built from https://develop.svn.wordpress.org/trunk@45213


git-svn-id: http://core.svn.wordpress.org/trunk@45022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 14:56:51 +00:00
Gary Pendergast 4487551344 Help: Update support forum links. 
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790.


Built from https://develop.svn.wordpress.org/trunk@45140


git-svn-id: http://core.svn.wordpress.org/trunk@44949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 22:59:56 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Weston Ruter f78775a6db Customize: Use selective refresh to preview changes to site title and tagline in core themes. 
Fixes issue where `wptexturize` and other filters fail to apply when previewing changes via `postMessage` transport.

See #27355.
Fixes #33738.

Built from https://develop.svn.wordpress.org/trunk@36797


git-svn-id: http://core.svn.wordpress.org/trunk@36764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-01 22:18:26 +00:00
Lance Willett 5404fa2097 Bundled themes: use SSL WordPress.org URLs. 
Props SergeyBiryukov, fixes #32083.
Built from https://develop.svn.wordpress.org/trunk@32314


git-svn-id: http://core.svn.wordpress.org/trunk@32285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-27 17:36:25 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org. 
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-12 21:29:32 +00:00
Lance Willett 8f6f787d13 Twenty Eleven: add `postMessage` support for `header_textcolor` to improve the user experience in the Customizer. 
Fixes #24128, props kovshenin, jcastaneda, and lancewillett. 
Built from https://develop.svn.wordpress.org/trunk@31971


git-svn-id: http://core.svn.wordpress.org/trunk@31950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-01 21:42:27 +00:00
Lance Willett dcf53d5bbb Twenty Eleven: fix escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31265


git-svn-id: http://core.svn.wordpress.org/trunk@31246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-22 00:42:23 +00:00
Dominik Schilling 61819a36ea Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific. 
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.
Built from https://develop.svn.wordpress.org/trunk@29903


git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-15 17:21:19 +00:00
Sergey Biryukov e9e2cf05d8 Twenty Eleven: Correct description for twentyeleven_theme_options_render_page(). 
props ericlewis.
fixes #28057.
Built from https://develop.svn.wordpress.org/trunk@28237


git-svn-id: http://core.svn.wordpress.org/trunk@28065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 00:43:16 +00:00
Lance Willett a3b09ba9d7 Twenty Eleven: remove doc block comments for `@return void`. See #27098. 
Built from https://develop.svn.wordpress.org/trunk@27597


git-svn-id: http://core.svn.wordpress.org/trunk@27440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 22:48:16 +00:00
Lance Willett 25d1363a66 Twenty Eleven: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256. 
Built from https://develop.svn.wordpress.org/trunk@25625


git-svn-id: http://core.svn.wordpress.org/trunk@25542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-25 16:50:11 +00:00
koopersmith 0df3218cc2 Theme Customizer: Ensure that JS color controls always use real color values, even if the server-side value is a hex value without a hash. fixes #20448, see #19910. 
Adds WP_Customize_Setting->sanitize_js_callback and 'customize_sanitize_js_$settingID' filter, to filter values before they're passed to JS using WP_Customize_Setting->js_value().

Adds support for regular hex colors to the color picker.

Changes color methods:
* sanitize_hex_color() accepts 3 and 6 digit hex colors (with hashes) and the empty string.
* sanitize_hex_color_no_hash() accepts 3 and 6 digit hex colors (without hashes) and the empty string.
* maybe_hash_hex_color() ensures that a hex color has a hash, and otherwise leaves the value untouched.


git-svn-id: http://core.svn.wordpress.org/trunk@20936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-26 18:44:31 +00:00
koopersmith 01f8df5b80 Twenty Eleven theme customizer integration. props lancewillett, Otto42. fixes #20448, see #19910. 
git-svn-id: http://core.svn.wordpress.org/trunk@20916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-25 21:50:01 +00:00
markjaquith 5a1279320a Remove some dead add_option() code in Twenty Eleven. props Mamaduka, emhr. fixes #19743 
git-svn-id: http://core.svn.wordpress.org/trunk@20875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-24 07:38:13 +00:00
nacin 00ab660e01 Check for wp_get_theme() in Twenty Eleven before using it, for compatibility down to WP 3.2 when Twenty Eleven was first released. see #20103. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-18 17:32:53 +00:00
nacin bf97881f98 (string) WP_Theme is now the theme name, translated. Good replacement for get_current_theme(); better than wp_get_theme()->display('Name'). see #20103, see #20138. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-29 19:27:54 +00:00
ryan f70f569825 Contextual help back compat for twentyeleven. Props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-10 18:31:44 +00:00
nacin 15ceab2647 Standardize some final help strings. We're done, aside from typos. props zeo, jane, duck_, fixes #19020. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-02 04:31:01 +00:00
nacin 26867ec70a Switch to 'Overview' for Twenty Eleven. Use the theme's textdomain. props SergeyBiryukov, see [19493], #19020. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-01 00:33:09 +00:00
ryan af1982e70a Contextual help for Twenty Eleven theme options page. see #19020 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-10 14:01:46 +00:00
ryan b051ece339 phpdoc fix. Props Jayjdk. fixes #18965 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-17 15:58:16 +00:00
nacin 50dd290502 Fix @sinces in Twenty Eleven. see #18045. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-21 21:44:47 +00:00
nacin 93560c8612 Use the Settings fields/sections API in Twenty Eleven. props chipbennett for initial patch. see #18045. for 3.3. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-21 21:37:31 +00:00
nacin 01060c0689 Twenty Eleven: Prefix theme_options_render_page(). props chipbennett, see #18045. for trunk. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-11 20:15:37 +00:00
ryan fdc7409251 twentyeleven code tidy up. Props dd32, lancewillett. fixes #17748 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-30 21:57:50 +00:00
azaozz bad6d5e3f3 Twenty Eleven RTL update, props yoavf, fixes #17882 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-25 20:24:07 +00:00
ryan 46f63a6b1e Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-11 15:44:06 +00:00
nacin bf4e70ba7a New comment bubble styling! props matveb, iandstewart, fixes #17741. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-10 23:10:23 +00:00
azaozz 3a29a3d893 Twenty Eleven code review and cleanup, props dd32, fixes #17748 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-10 23:01:16 +00:00
ryan a5dc19aa31 Add missing textdomain to twentyeleven contextual help. Props pavelevap. see #17744 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-10 17:13:23 +00:00
dd32 40a3ce969a * Don't clear link colour when switching layouts 
* Update "default colour" link when a custom colour has been selected
Fixes #17746

git-svn-id: http://svn.automattic.com/wordpress/trunk@18229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-10 13:41:51 +00:00
nacin e68bd9e42e Twenty Eleven: Properly handle the default link color for the dark theme. props dcowgill for the patch refresh. fixes #17351. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-08 17:39:12 +00:00
iandstewart af7b7c70ab Twenty Eleven: miscellaneous bug fixes and improvements 
* Only style images uploaded to the WordPress media library with border styles (and not placeholder images for content added by plugins)
* Prevent content added by plugins and long custom excerpts from overflowing the featured post slider
* Make sure small thumbnails will never appear in the Custom Header area
* Better indicate the current featured post with custom link color and cursor
* Add a class for text-only featured posts
* Style improvements for small screens


git-svn-id: http://svn.automattic.com/wordpress/trunk@18181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-07 21:28:56 +00:00
nacin ec46700dd4 Use default argument for get_option(). props dcowgill, westi. fixes #17686. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-05 19:53:31 +00:00
nacin e5090f3113 Sanity check in twentyeleven_get_theme_options() -- if the option doesn't exist, return the default options instead. We already instantiate the option on admin_init. fixes #17686. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-04 22:05:29 +00:00
ryan 6f3fdf244e Check result of add_theme_page(). Return if false. Props greuben. fixes #17677 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-03 22:37:13 +00:00
ryan 8a937b9c09 Retain screen-reader-text for pages shown in the admin. see #17524 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-02 21:59:11 +00:00
iandstewart 8a7dd1e31c Twenty Eleven: accessibility improvements and minor style fixes for galleries; See #17524 
* Improved color contrast for light and dark color schemes
* Skip link for skipping directly to sidebar content
* Skip links visible on :focus
* Using a more semantic, general class name of .assistive-text instead of .section-heading and .screen-reader-text
* Focus styles for password inputs (and a minor style fix)


git-svn-id: http://svn.automattic.com/wordpress/trunk@18117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-02 19:30:07 +00:00