Commit Graph

66 Commits

Author SHA1 Message Date
Sergey Biryukov 38676936ba Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved.
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47550


git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
Sergey Biryukov e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Sergey Biryukov 83187125e4 Bundled Themes: Audit and update version numbers passed to `wp_enqueue_script()` to ensure proper cache busting.
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981.
Built from https://develop.svn.wordpress.org/trunk@45768


git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:29:58 +00:00
Gary Pendergast c71bc1513e Coding Standards: Add missing translator comments to the default themes.
All default themes now have translator comments for all strings with placeholders!

See #46732.

Built from https://develop.svn.wordpress.org/trunk@45609


git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Tammie Lister 9ef40ced2f Twenty Fourteen: Removes video header support
Support was added to test implementation but never completed. This removes the test implementation.

Props davidakennedy
Fixes #38783

Built from https://develop.svn.wordpress.org/trunk@39226


git-svn-id: http://core.svn.wordpress.org/trunk@39166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-14 17:17:31 +00:00
Joe McGill 030bc377dd Themes: Enable video in custom headers.
This adds the ability for themes to add support for videos in custom headers
by passing `'video' => true` as an argument when adding theme support for
custom headers.

Custom video headers are managed through the “Header Visuals” (i.e. “Header Image”)
panel in the Customizer where you can select a video from the media library or set a
URL to an external video (YouTube for now) for use in custom headers.

This introduces several new functions:

`has_header_video()` – Check whether a header video is set or not.
`get_header_video_url()` – Retrieve header video URL for custom header.
`the_header_video_url()` – Display header video URL.
`get_header_video_settings()` – Retrieve header video settings.
`has_custom_header()` – Check whether a custom header is set or not.
`get_custom_header_markup()` – Retrieve the markup for a custom header.
`the_custom_header_markup()` – Print the markup for a custom header.

And a new file, `wp-includes/js/wp-custom-header.js` that handles loading videos
in custom headers.

This also enables video headers in the Twenty Seventeen and Twenty Fourteen themes.

Props davidakennedy, celloexpressions, bradyvercher, laurelfulford, joemcgill.
Fixes #38172.
Built from https://develop.svn.wordpress.org/trunk@38985


git-svn-id: http://core.svn.wordpress.org/trunk@38928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-27 21:51:31 +00:00
Weston Ruter f78775a6db Customize: Use selective refresh to preview changes to site title and tagline in core themes.
Fixes issue where `wptexturize` and other filters fail to apply when previewing changes via `postMessage` transport.

See #27355.
Fixes #33738.

Built from https://develop.svn.wordpress.org/trunk@36797


git-svn-id: http://core.svn.wordpress.org/trunk@36764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-01 22:18:26 +00:00
Dominik Schilling 64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Lance Willett 6ddbf3c8bd Twenty Fourteen: Make featured content in Customizer contextual to the front page.
Props celloexpressions, fixes #29578.

Built from https://develop.svn.wordpress.org/trunk@30143


git-svn-id: http://core.svn.wordpress.org/trunk@30143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:26:21 +00:00
Dominik Schilling 61819a36ea Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.
Built from https://develop.svn.wordpress.org/trunk@29903


git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Sergey Biryukov 05fb60ae78 Twenty Fourteen: Move custom description for background color and image from sections to controls in the customizer.
props jb510.
fixes #29490.
Built from https://develop.svn.wordpress.org/trunk@29827


git-svn-id: http://core.svn.wordpress.org/trunk@29592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-03 08:43:15 +00:00
Sergey Biryukov a1c478586b Twenty Fourteen: Fix typo in contextual help.
props vanillalounge.
fixes #27493.
Built from https://develop.svn.wordpress.org/trunk@27661


git-svn-id: http://core.svn.wordpress.org/trunk@27504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-23 12:42:14 +00:00
Lance Willett a46e7ca3dc Twenty Fourteen: remove doc block comments for `@return void`. See #27098, props philiparthurmoore.
Built from https://develop.svn.wordpress.org/trunk@27595


git-svn-id: http://core.svn.wordpress.org/trunk@27438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:44:14 +00:00
Lance Willett c2f46ac811 Twenty Fourteen: translate `featured` tag slug used to link to specific tags in Posts editor. See #26526.
Built from https://develop.svn.wordpress.org/trunk@27122


git-svn-id: http://core.svn.wordpress.org/trunk@26989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:47:11 +00:00
Lance Willett 21b5149477 Twenty Fourteen: remove extra space before a word, props ocean90. See #26437.
Built from https://develop.svn.wordpress.org/trunk@26842


git-svn-id: http://core.svn.wordpress.org/trunk@26729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 20:29:10 +00:00
Lance Willett ecf5c3ae21 Twenty Fourteen: bump JS version for customizer.js, see #26338.
Built from https://develop.svn.wordpress.org/trunk@26669


git-svn-id: http://core.svn.wordpress.org/trunk@26559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 17:33:10 +00:00
Lance Willett 5f73635e58 Twenty Fourteen: fix typo, props DrewAPicture. See #26414.
Built from https://develop.svn.wordpress.org/trunk@26646


git-svn-id: http://core.svn.wordpress.org/trunk@26536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 22:52:10 +00:00
Lance Willett 05200ae863 Twenty Fourteen: minor code cleanup in Customizer file, props obenland. Fixes #26414.
Built from https://develop.svn.wordpress.org/trunk@26643


git-svn-id: http://core.svn.wordpress.org/trunk@26533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 22:09:11 +00:00
Lance Willett 9464a4aa1a Twenty Fourteen: sanitize the values of Featured Content layout option, props kwight. Fixes #26408.
Built from https://develop.svn.wordpress.org/trunk@26636


git-svn-id: http://core.svn.wordpress.org/trunk@26526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 21:33:11 +00:00
Lance Willett f0f5a12288 Twenty Fourteen: add link to Codex documentation in Help text, and minor cleanup based on siobhan feedback. See #25837.
Built from https://develop.svn.wordpress.org/trunk@26630


git-svn-id: http://core.svn.wordpress.org/trunk@26520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 19:53:18 +00:00
Lance Willett 4d6ec7fa96 Twenty Fourteen: re-add the Header Text Customization Option. Props iamtakashi, fixes #26338; see #25540.
Built from https://develop.svn.wordpress.org/trunk@26573


git-svn-id: http://core.svn.wordpress.org/trunk@26464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 18:27:10 +00:00
Lance Willett 16544ed331 Twenty Fourteen: remove Accent Color feature. Props celloexpressions, fixes #26220.
Built from https://develop.svn.wordpress.org/trunk@26567


git-svn-id: http://core.svn.wordpress.org/trunk@26458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 18:05:10 +00:00
Lance Willett e46662b6ae Twenty Fourteen: update comment blocks to match inline docs standards. Props DrewAPicture, see #25837.
Built from https://develop.svn.wordpress.org/trunk@26556


git-svn-id: http://core.svn.wordpress.org/trunk@26447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:06:11 +00:00
Lance Willett b5dbd754d8 Twenty Fourteen: limit Help tab text to only "post" post type edit screen. Props obenland, see #25837.
Built from https://develop.svn.wordpress.org/trunk@26555


git-svn-id: http://core.svn.wordpress.org/trunk@26446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:01:10 +00:00
Sergey Biryukov b5ce3e6c96 Twenty Fourteen: use a more specific selector for tag links.
props iamtakashi.
fixes #26358.
Built from https://develop.svn.wordpress.org/trunk@26545


git-svn-id: http://core.svn.wordpress.org/trunk@26437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 23:15:10 +00:00
Lance Willett 1d0bce8013 Twenty Fourteen: update Customizer inline help text. Props siobhan, see #25837.
Built from https://develop.svn.wordpress.org/trunk@26361


git-svn-id: http://core.svn.wordpress.org/trunk@26262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 16:57:10 +00:00
Lance Willett 9e201fadff Twenty Fourteen: updates all PHP files to meet new brace style in WP coding standards. Props rickalee for initial patch, fixes #26093.
Built from https://develop.svn.wordpress.org/trunk@26260


git-svn-id: http://core.svn.wordpress.org/trunk@26166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 23:11:10 +00:00
Lance Willett 3c0f497fad Twenty Fourteen: general cleanup for spacing, inline comments. Props obenland, see #25946.
Built from https://develop.svn.wordpress.org/trunk@26227


git-svn-id: http://core.svn.wordpress.org/trunk@26134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 21:20:09 +00:00
Lance Willett 667cbb9345 Twenty Fourteen: use HTML entity for arrow in Help text string, props dd32. See #25837.
Built from https://develop.svn.wordpress.org/trunk@26211


git-svn-id: http://core.svn.wordpress.org/trunk@26119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 14:20:11 +00:00
Lance Willett 630619cf6c Twenty Fourteen: remove unneeded translator context from theme Help tab text, props domain. See #25837.
Built from https://develop.svn.wordpress.org/trunk@26190


git-svn-id: http://core.svn.wordpress.org/trunk@26098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 02:43:10 +00:00
Lance Willett 2b1c6c8ba4 Twenty Fourteen: fix tabs to spaces in two files. See #25946.
Built from https://develop.svn.wordpress.org/trunk@26154


git-svn-id: http://core.svn.wordpress.org/trunk@26065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 04:57:10 +00:00
Lance Willett 254bdd6bc9 Twenty Fourteen: first pass at adding help text to to "Help" tab for `edit.php` and `themes.php` screens. Props obenland for starter patch, see #25837.
Built from https://develop.svn.wordpress.org/trunk@26153


git-svn-id: http://core.svn.wordpress.org/trunk@26064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 04:53:09 +00:00
Lance Willett 5d32b45b79 Twenty Fourteen: use numbered placeholders for Customizer help text in case they get swapped during translation, props obenland. See #25837.
Built from https://develop.svn.wordpress.org/trunk@26135


git-svn-id: http://core.svn.wordpress.org/trunk@26047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 19:02:09 +00:00
Lance Willett cdc03fe491 Twenty Fourteen: add in more contextual help for setting up Featured Content, links to "featured" tag posts and "sticky" posts from inside the Customizer. See #25837.
Built from https://develop.svn.wordpress.org/trunk@26101


git-svn-id: http://core.svn.wordpress.org/trunk@26016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-12 17:13:09 +00:00
Lance Willett 323b7c4627 Twenty Fourteen: first pass at older Internet Explorer browser support. Props iamtakashi, see #25036.
Built from https://develop.svn.wordpress.org/trunk@26097


git-svn-id: http://core.svn.wordpress.org/trunk@26012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-12 04:18:11 +00:00
Lance Willett dc80ae6691 Twenty Fourteen: improve Featured Content experience in the Customizer. Better preview and cache clearing, props obenland and rachelbaker. Fixes #25549.
Built from https://develop.svn.wordpress.org/trunk@26079


git-svn-id: http://core.svn.wordpress.org/trunk@25999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-10 23:38:10 +00:00
Lance Willett 8e494481f8 Twenty Fourteen: add brief inline help text for Featured Content controls in Customizer. See #25837.
Built from https://develop.svn.wordpress.org/trunk@26045


git-svn-id: http://core.svn.wordpress.org/trunk@25970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-08 01:09:10 +00:00
Lance Willett 4a460f3779 Twenty Fourteen: better override for Background and Colors descriptions in Customizer, props obenland. See #25869.
Built from https://develop.svn.wordpress.org/trunk@26039


git-svn-id: http://core.svn.wordpress.org/trunk@25968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-07 20:37:08 +00:00
Lance Willett 996e9823d7 Twenty Fourteen: add contextual help text to Background and Colors controls in Customizer, using the `description` field. Props rachelbaker, see #25869.
Built from https://develop.svn.wordpress.org/trunk@26038


git-svn-id: http://core.svn.wordpress.org/trunk@25967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-07 20:28:11 +00:00
Lance Willett 5420155231 Twenty Fourteen: move all controls for managing Featured Content to the Customizer. Also implement smart fallbacks to not using a custom tag with the "featured" tag and sticky posts. Props obenland and celloexpressions, see #25549.
Built from https://develop.svn.wordpress.org/trunk@26037


git-svn-id: http://core.svn.wordpress.org/trunk@25966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-07 20:25:09 +00:00
Lance Willett 16831f259d Twenty Fourteen: improvements to Accent Color behavior, including a case where options were published too soon. Props celloexpressions, fixes #25580.
Built from https://develop.svn.wordpress.org/trunk@26021


git-svn-id: http://core.svn.wordpress.org/trunk@25952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 23:29:08 +00:00
Lance Willett 50fbc698fd Twenty Fourteen: update bundled Genericons to the latest version, 3.0.2. Props iamtakashi, closes #25812.
Built from https://develop.svn.wordpress.org/trunk@26003


git-svn-id: http://core.svn.wordpress.org/trunk@25936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-04 18:08:10 +00:00
Lance Willett e0e2ace724 Twenty Fourteen: revamp the RTL stylesheet and related cleanup. Props iamtakashi, see #25801.
Built from https://develop.svn.wordpress.org/trunk@25999


git-svn-id: http://core.svn.wordpress.org/trunk@25932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-02 04:36:12 +00:00
Lance Willett 6593ae56b8 Twenty Fourteen: second pass at revamping the main CSS file. Update pattern graphics to fix issue with orientation changes on tablets. Props iamtakashi, fixes #25592.
Built from https://develop.svn.wordpress.org/trunk@25998


git-svn-id: http://core.svn.wordpress.org/trunk@25931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-31 04:28:10 +00:00
Andrew Nacin d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Lance Willett d8ba6cde31 Twenty Fourteen: further revise primary navigation functionality, simplify mobile navigation, and clean up the main JS file. Props obenland, iamtakashi. See #25554.
Built from https://develop.svn.wordpress.org/trunk@25864


git-svn-id: http://core.svn.wordpress.org/trunk@25864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:48 +00:00
Lance Willett a9a5d30053 Twenty Fourteen: revise link colors. Props iamtakashi, see #25640.
Built from https://develop.svn.wordpress.org/trunk@25857


git-svn-id: http://core.svn.wordpress.org/trunk@25857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:57:42 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00