Commit Graph

243 Commits

Author SHA1 Message Date
Helen Hou-Sandí
1f500055a6 Drop the hyphen from e-mail and standardize on email.
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.

Built from https://develop.svn.wordpress.org/trunk@33774


git-svn-id: http://core.svn.wordpress.org/trunk@33742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 03:17:21 +00:00
John Blackbourn
a60d143f7b Correct the hook docs for the user_profile_update_errors action.
Fixes #33537
Props yamchhetri

Built from https://develop.svn.wordpress.org/trunk@33769


git-svn-id: http://core.svn.wordpress.org/trunk@33737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-27 17:16:21 +00:00
Konstantin Obenland
e6bc6242ad Passwords: Restore second parameter for wp_new_user_notification().
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.


Built from https://develop.svn.wordpress.org/trunk@33620


git-svn-id: http://core.svn.wordpress.org/trunk@33587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-17 14:25:27 +00:00
Dion Hulse
aace7c2c8d Function documentation: Fix a broken docbock introduced with [32642].
See #32444.

Built from https://develop.svn.wordpress.org/trunk@33601


git-svn-id: http://core.svn.wordpress.org/trunk@33568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-10 10:50:26 +00:00
Mark Jaquith
c5719ba15a Make the "using default password" nag more accurate.
"Easy to remember" isn't necessarily what we want to encourage.

fixes #33168
props arjunskumar
Built from https://develop.svn.wordpress.org/trunk@33485


git-svn-id: http://core.svn.wordpress.org/trunk@33452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 14:06:25 +00:00
Mark Jaquith
423a1a7ca4 New password change/set UI.
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords

see #32589

props MikeHansenMe, adamsilverstein, binarykitten
Built from https://develop.svn.wordpress.org/trunk@33023


git-svn-id: http://core.svn.wordpress.org/trunk@32994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:48:24 +00:00
Scott Taylor
c6a4512b1b Add missing doc blocks to wp-admin/includes/*.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Scott Taylor
a51dfa3971 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.

Built from https://develop.svn.wordpress.org/trunk@32653


git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 17:04:26 +00:00
Scott Taylor
b56b9b3e5c Add @global annotations for wp-admin/*.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Drew Jaynes
ba1e7a7243 Correct grammar when referring to "a user" vs "an user" in several places.
Props ocean90.
Fixes #31894.

Built from https://develop.svn.wordpress.org/trunk@32025


git-svn-id: http://core.svn.wordpress.org/trunk@32004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 14:44:27 +00:00
Scott Taylor
7d7a8aa0eb Correct all @return unknown instances.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30202


git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
Boone Gorges
24babfddb3 Allow apostrophes in email addresses when adding users via the Dashboard.
Email addresses entered in a number of interfaces were not being stripslashed
properly, with the result that the emails were not being recognized as valid.

Fixes #18039.
Built from https://develop.svn.wordpress.org/trunk@29966


git-svn-id: http://core.svn.wordpress.org/trunk@29713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-19 20:30:19 +00:00
Drew Jaynes
097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Scott Taylor
2f513d3320 Fix some hackificator odds and ends in wp-admin:
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28500


git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Andrew Nacin
edfe443afc Remove lame debugging. see #23057.
Built from https://develop.svn.wordpress.org/trunk@27467


git-svn-id: http://core.svn.wordpress.org/trunk@27312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 03:16:27 +00:00
Andrew Nacin
60953e88fd Normalize $reassign in wp_delete_user() to ensure the hooks receive consistent values.
fixes #23057.

Built from https://develop.svn.wordpress.org/trunk@27466


git-svn-id: http://core.svn.wordpress.org/trunk@27311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 03:16:14 +00:00
Sergey Biryukov
0a0589414e Fix docblock formatting in [27462]. see #23057.
Built from https://develop.svn.wordpress.org/trunk@27463


git-svn-id: http://core.svn.wordpress.org/trunk@27308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 01:26:13 +00:00
Sergey Biryukov
9c6504120f Pass $reassign parameter to 'delete_user' and 'deleted_user' actions.
props genkisan.
fixes #23057.
Built from https://develop.svn.wordpress.org/trunk@27462


git-svn-id: http://core.svn.wordpress.org/trunk@27307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 01:23:15 +00:00
Andrew Nacin
c102fd5a9d Make the user arguments for get_edit_profile_url() and get_dashboard_url() optional, defaulting to the current user.
props garyc40.
fixes #16686.

Built from https://develop.svn.wordpress.org/trunk@27260


git-svn-id: http://core.svn.wordpress.org/trunk@27117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:08:13 +00:00
Drew Jaynes
cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Drew Jaynes
c9077348ee Inline documentation for hooks in wp-admin/includes/user.php.
Props aaronholbrook for the initial patch.
Fixes #26099.

Built from https://develop.svn.wordpress.org/trunk@26503


git-svn-id: http://core.svn.wordpress.org/trunk@26397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 17:54:10 +00:00
Andrew Nacin
00c545606e Introduce wp_get_user_contact_methods() as a public version of _wp_get_user_contactmethods.
props johnnyb.
fixes #24273.

Built from https://develop.svn.wordpress.org/trunk@25606


git-svn-id: http://core.svn.wordpress.org/trunk@25523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 18:14:09 +00:00
Sergey Biryukov
6760d294bb Update phpdoc for get_user_to_edit(), get_userdata(), and get_user_by(). props tivnet. fixes #24992.
Built from https://develop.svn.wordpress.org/trunk@25204


git-svn-id: http://core.svn.wordpress.org/trunk@25176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 03:25:09 +00:00
Sergey Biryukov
34d0f347ad Revert to storing a hash of the slashed password. fixes #24367. see #17018.
git-svn-id: http://core.svn.wordpress.org/trunk@24508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-25 11:14:50 +00:00
Andrew Nacin
17ddaa8de0 delete_user_setting() and remove_action() were getting called with too many args. props rlerdorf. see #24210.
git-svn-id: http://core.svn.wordpress.org/trunk@24125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:25:15 +00:00
Sergey Biryukov
831afad92c When adding a new user in the admin, strip slashes from the password sent to the user by email. props hakre for initial patch. fixes #17018.
git-svn-id: http://core.svn.wordpress.org/trunk@23634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 06:00:16 +00:00
Ryan Boren
f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:09 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Andrew Nacin
55ba72f46e Confirm a user exists before deleting them in wp_delete_user() and wpmu_delete_user(). props scribu, fixes #23067.
git-svn-id: http://core.svn.wordpress.org/trunk@23380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 04:41:02 +00:00
Ryan Boren
51920e1858 Consolidate some strings. Props pavelevap, SergeyBiryukov. see #21728
git-svn-id: http://core.svn.wordpress.org/trunk@22124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 19:04:34 +00:00
Ryan Boren
3a5cf2395d When reassigning posts and links during user deletion, clear the post and link caches. Props kurtpayne. fixes #20447
git-svn-id: http://core.svn.wordpress.org/trunk@21798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-10 19:56:08 +00:00
Ryan Boren
cbd6a8becd Allow passing stdClass and WP_User to wp_insert_user() and wp_update_user(). Introduce WP_User::to_array(). Eliminate uses of get_object_vars() when passing to wp_*_user(). fixes #21429
git-svn-id: http://core.svn.wordpress.org/trunk@21496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-10 15:36:54 +00:00
nacin
7127ed1197 Move most instances of new WP_User to get_userdata(). see #21120.
git-svn-id: http://core.svn.wordpress.org/trunk@21413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 01:06:05 +00:00
ryan
7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 18:30:03 +00:00
markjaquith
168cc20a42 Allow tel: and fax: protocols. Wrangle the last hardcoded protocol enumeration so that it uses wp_allowed_protocols(). fixes #21081
git-svn-id: http://core.svn.wordpress.org/trunk@21170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 20:30:10 +00:00
ryan
f5366a2ccf Don't delete nav menu items when the user that owns them is deleted.
* Introduce delete_with_user flag to register_post_type
* Set delete_with_user to false for the nav_menu_item post type
* Set it to true for all other core post types
* If delete_with_user is not set, fallback to post_type_supports('author')

Props nacin
Fixes #16358


git-svn-id: http://core.svn.wordpress.org/trunk@20739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-08 17:01:50 +00:00
ryan
646cb4e2ce * Return empty arrays instead of false for all conditions in get_blogs_of_user().
* When deleting a user, use a delete_metadata_by_mid() loop over the meta so that the meta cache is cleared.
* Use remove_user_from_blog() for DRYness.

Props nacin, duck_
Fixes #19500


git-svn-id: http://svn.automattic.com/wordpress/trunk@20581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-24 22:13:47 +00:00
duck_
53e6ba7959 clean_user_cache() after the DELETE query in wp_delete_user(). See #20460.
This is to prevent plugins managing to hook in between the cache cleaning and the actual deletion.


git-svn-id: http://svn.automattic.com/wordpress/trunk@20523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-18 21:24:53 +00:00
duck_
e641c48a72 Pass full user objects to clean_user_cache(). See #19500, fixes #20460.
Prevents notices when clean_user_cache() is called for a user that has been removed from the database.


git-svn-id: http://svn.automattic.com/wordpress/trunk@20522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-18 21:07:31 +00:00
nacin
0730535015 Introduce $wpdb->delete(). props justindgivens, scribu. fixes #18948.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-24 15:24:31 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
duck_
965a71033e Remove "the hackiest hack that ever did hack" from add_user(). wp_insert_user()/edit_user() can deal with adding new users of any defined role. Fixes #18749.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:38:40 +00:00
nacin
ccf47d55c4 Remove remnants of show_admin_bar_admin. see #18811, see #18197.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-29 06:12:51 +00:00
duck_
c1d1590171 Fix typos in documentation (wp-admin/). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 14:18:10 +00:00
ryan
0f06334e11 Introduce metadata_exists(), WP_User::get_data_by(), WP_User::get(), WP_User::has_prop(). Don't fill user objects with meta. Eliminate data duplication in cache and memory. Props scribu. see #15458
git-svn-id: http://svn.automattic.com/wordpress/trunk@18597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-24 19:32:59 +00:00
ryan
58e65d1855 Admin bar visibility prefs. Props duck_. see #15829
git-svn-id: http://svn.automattic.com/wordpress/trunk@17032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-17 21:48:30 +00:00
ryan
3f72e340d6 Update since phpdoc. Props demetris. fixes #15445
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:24:38 +00:00
nacin
0902043f6d We don't want a populated WP_User object here. see #14642.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 00:26:29 +00:00
nacin
478186859b Properly check, initialize, or cast a number of variables. props ChenHui. see #14642.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-15 06:38:10 +00:00
nacin
f5e23028ff Pass user object through _wp_get_user_contactmethods() to the user_contactmethods filter. props aaroncampbell, fixes #15186.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 15:42:06 +00:00
ryan
2f022020a1 Fix notice when creating users. Props coffee2code. fixes #14286
git-svn-id: http://svn.automattic.com/wordpress/trunk@15799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-13 20:26:43 +00:00
markjaquith
df006b32e2 Fix an English fail.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-07 08:04:15 +00:00
nacin
271aa55c16 Don't show the default password nag on the profile screen. props duck_, fixes #14861.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-13 16:49:04 +00:00
scribu
253faa4bbe Deprecated get_editable_user_ids() altogether, along with similar, unused functions. See #14572
git-svn-id: http://svn.automattic.com/wordpress/trunk@15542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-27 01:07:21 +00:00
scribu
18469c28ff Deprecate unused get_author_user_ids()and get_editable_authors(). See #14572
git-svn-id: http://svn.automattic.com/wordpress/trunk@15540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-27 00:22:29 +00:00
scribu
e7a6f6f967 use get_users() in get_editable_user_ids() and cache result. See #14572
git-svn-id: http://svn.automattic.com/wordpress/trunk@15539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-27 00:18:57 +00:00
scribu
020ce73746 Ajaxify list-type screens in the admin. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@15491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-11 21:54:51 +00:00
ryan
81e213c211 Use get_current_user() and get_current_user_id() instead of global . Props filofo. see #13934 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@15315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-24 15:01:29 +00:00
westi
50b197cf94 Fix the default password nag clearer to work when an admin sets someone elses password away from the default. Fixes #12334.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-13 21:08:01 +00:00
nacin
70f36f6c41 More typos. see #13358.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-12 21:03:33 +00:00
nacin
7734a07cb2 Move post type object capabilities to a 'cap' object. Allow them to be initialized via the 'capabilities' key (an array) when registering support for the post type. Caps are now referred to by the name of the cap as if it was a post, i.e. ->cap->edit_post. see #13358.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-12 20:45:18 +00:00
ryan
2ecda01ce0 Fix user validation feedback. Props sivel. fixes #13162
git-svn-id: http://svn.automattic.com/wordpress/trunk@14428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 23:46:42 +00:00
ryan
dda59949de User deletion fixes. Props yoavf. fixes #13242
git-svn-id: http://svn.automattic.com/wordpress/trunk@14422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 23:04:42 +00:00
nacin
e40572be40 Some default password nag and user-edit div.error style cleanups.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-27 21:57:18 +00:00
nbachiyski
a8f935789b Split the default password nag text to several translatable strings
git-svn-id: http://svn.automattic.com/wordpress/trunk@14170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-20 17:15:07 +00:00
wpmuguru
b90e44bbb9 use meta caps in [14032], see #12109
git-svn-id: http://svn.automattic.com/wordpress/trunk@14033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-07 21:04:42 +00:00
ryan
f609d0c8a3 User is_super_admin(). Props ocean90. fixes #12888
git-svn-id: http://svn.automattic.com/wordpress/trunk@14032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-07 15:28:10 +00:00
nacin
927a8afbf3 Allow "No role for this blog" to be chosen on user-edit. Add defensive checks for a few potential notices. fixes #10833
git-svn-id: http://svn.automattic.com/wordpress/trunk@13961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-03 08:08:12 +00:00
nacin
69f5922799 Use correct cap in get_editable_user_ids(). edit_cap is the meta cap (edit_post) and needs a post id passed, edit_type_cap is the primitive edit_posts cap.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-03 04:38:20 +00:00
ryan
311b5a82cc Use wpdb->prefix instead of wpdb->base_prefix(). base_prefix() does not return the correct prefix when a blog ID is not passed.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-02 17:23:36 +00:00
nacin
6a1844f98e Allow MS cape-wearers to demote their blog roles to something without the edit_users cap. see #12387
git-svn-id: http://svn.automattic.com/wordpress/trunk@13934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-02 04:30:00 +00:00
nacin
d0404ed946 Password nag string cleanup. Could be good to also increase the line-height on div.updated/error at some point.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-27 07:22:05 +00:00
nacin
a7feaed0e6 Change @since 3.0 to @since 3.0.0.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:13:36 +00:00
dd32
4a59fbc765 Fix Author selection for non-post type posts. Props prettyboymp. Fixes #12408
git-svn-id: http://svn.automattic.com/wordpress/trunk@13488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-28 06:38:15 +00:00
wpmuguru
1c5f2af719 warnings cleanup edit user, props dd32, see #12387
git-svn-id: http://svn.automattic.com/wordpress/trunk@13463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-27 18:07:25 +00:00
ryan
9ab7306993 Remove author tags. fixes #12366
git-svn-id: http://svn.automattic.com/wordpress/trunk@13377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-24 19:07:21 +00:00
dd32
679250491d Variable Cleanup, Unused variables, Typo'd variables, unused code blocks. Fixes #12299
git-svn-id: http://svn.automattic.com/wordpress/trunk@13242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-20 02:01:46 +00:00
nacin
b4f362264e Don't use deprecated functions. see #11388
git-svn-id: http://svn.automattic.com/wordpress/trunk@13106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-13 10:35:10 +00:00
westi
093b14a634 Allow plugins to modify the query run by WP_User_Search. Fixes #10781 props scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-06 12:35:15 +00:00
dd32
041c570da1 Switch to *_user_option() for default password nag to avoid extra DB queries. Fixes #11380
git-svn-id: http://svn.automattic.com/wordpress/trunk@12983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-06 06:20:38 +00:00
ryan
57c4b79b91 Introduce clean_user_cache(). fixes #11761
git-svn-id: http://svn.automattic.com/wordpress/trunk@12766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-19 19:23:11 +00:00
ryan
e52de33dc2 Multisite and formatting cleanups. Introduce get_allowed_themes(). see #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-18 23:34:36 +00:00
wpmuguru
2653342f43 merge multisite wp-admin/includes except schema, See #11644
git-svn-id: http://svn.automattic.com/wordpress/trunk@12726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-15 00:21:13 +00:00
ryan
0d31c12db6 Use update and insert. Props DD32. fixes #6836
git-svn-id: http://svn.automattic.com/wordpress/trunk@12652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 20:13:54 +00:00
matt
cff2ea75c7 Cast out the lowercase P demons that snuck in. http://www.google.com/search?q=out+out+you+demons+of+stupidity
git-svn-id: http://svn.automattic.com/wordpress/trunk@12341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-08 19:59:34 +00:00
westi
be1ff7ace1 Fix user creation from admin after changes for #10751. Fixes #10811 props alexkingorg.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-18 20:47:24 +00:00
ryan
aa1e377ede Filter fields through kses upon display. Introduce sanitize_user_object() and sanitize_user_field(). see #10751
git-svn-id: http://svn.automattic.com/wordpress/trunk@11929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-14 13:57:48 +00:00
westi
d28c67315a Move _wp_get_user_contactmethods() into the registrations functions file so it is always available when required. Fixes #10662.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-20 19:51:43 +00:00
westi
8aa2598b6a Make it much easier to filter contact methods from user profiles adding and removing at will. Fixes #10240 props joostdevalk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-06 21:59:52 +00:00
ryan
fc67a8145e Return empty array instead of false from get_editable_user_ids. Props Denis-de-Bernardy, pairg. fixes #10119 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@11571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-06-15 17:48:42 +00:00
ryan
2df887bd07 Trim tailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@11450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-24 23:47:49 +00:00
westi
da5d1d8d15 Pass references and more context to the new 'user_profile_update_errors' hook. Fixes #9302.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-23 21:37:49 +00:00
markjaquith
3ebf837ced Deprecate sanitize_url() and clean_url() in favor of esc_url_raw() and esc_url()
git-svn-id: http://svn.automattic.com/wordpress/trunk@11383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 16:00:33 +00:00
markjaquith
119b39cec2 deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 15:11:07 +00:00
ryan
1a09fcc6ba Don't set user's url to http://. Props josephscott. fixes #9804
git-svn-id: http://svn.automattic.com/wordpress/trunk@11320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-13 22:41:05 +00:00
ryan
8457db3774 Add option to send password to users created from admin. Props Denis-de-Bernardy. fixes #9669
git-svn-id: http://svn.automattic.com/wordpress/trunk@11319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-13 22:35:17 +00:00
ryan
d7cfd506a4 Allow quotes in passwords. fixes #8866
git-svn-id: http://svn.automattic.com/wordpress/trunk@11292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-12 05:21:32 +00:00
ryan
4b413f9e33 Update password nage text. Props Denis-de-Bernardy. fixes #9710
git-svn-id: http://svn.automattic.com/wordpress/trunk@11266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-11 17:34:24 +00:00
ryan
185d659b85 Default password nag fixes. Props DD32. fixes #9710
git-svn-id: http://svn.automattic.com/wordpress/trunk@11217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-06 16:19:40 +00:00
markjaquith
6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 19:43:53 +00:00
azaozz
83f674bf9a Banishing ASCII quotes and apostrophes, props demetris, fixes #9655
git-svn-id: http://svn.automattic.com/wordpress/trunk@11190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 04:28:05 +00:00
westi
614244af2b Add a nag message if the user is still using an auto-generated password. See #9710 props DD32.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-03 17:06:29 +00:00
ryan
2d489767bb s/attribute_escape/attr/. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-28 05:58:45 +00:00
azaozz
71086625a6 Add hook for update profile, props Cimmo, fixes #9302
git-svn-id: http://svn.automattic.com/wordpress/trunk@11096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-27 11:18:04 +00:00
ryan
a61bc0ec8a Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@11013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-20 18:18:39 +00:00
ryan
4956e5d453 Cache user lookups made by nicename. Add get_user_by(). fixes #4170
git-svn-id: http://svn.automattic.com/wordpress/trunk@10992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-17 21:25:11 +00:00
ryan
05666ec7bc Enforce unique email addresses. Props Denis-de-Bernardy. fixes #9563
git-svn-id: http://svn.automattic.com/wordpress/trunk@10990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-17 18:43:40 +00:00
ryan
29d4257fbd Use API to delete links when deleting a user. Props TimButterfield, scohoust. fixes #7774
git-svn-id: http://svn.automattic.com/wordpress/trunk@10975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-17 02:13:00 +00:00
ryan
f17cf80acd Add deleted_user action. Props Denis-de-Bernardy. see #9422
git-svn-id: http://svn.automattic.com/wordpress/trunk@10894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-08 19:01:10 +00:00
ryan
f84839d5af Fix delete statements to ensure data integrity when innodb and foreign keys are used. Props Denis-de-Bernardy. see #9422
git-svn-id: http://svn.automattic.com/wordpress/trunk@10851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-03-31 19:16:53 +00:00
ryan
e8b6fe7347 Trim trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@10810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-03-18 02:43:45 +00:00
ryan
dd98e4f40f Create user object. Props mark8barnes. fixes #9309 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@10760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-03-10 18:37:53 +00:00
ryan
cb38e921dc Add get_editable_roles() and role filtering. Props jeremyclarke. fixes #8770
git-svn-id: http://svn.automattic.com/wordpress/trunk@10323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-06 22:00:05 +00:00
ryan
e89192b1a8 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-09 18:03:31 +00:00
ryan
ab2ac7f427 Handle both post and page caps in get_editable_user_id(). Props DD32. fixes #8208
git-svn-id: http://svn.automattic.com/wordpress/trunk@9683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-14 17:13:08 +00:00
ryan
d699f0d00d i18n fixes from nbachiyski. fixes #8142
git-svn-id: http://svn.automattic.com/wordpress/trunk@9589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-10 17:42:51 +00:00
azaozz
ce2413cb7f Use ndash for number range, props demetris, fixes #8088
git-svn-id: http://svn.automattic.com/wordpress/trunk@9565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-08 02:39:18 +00:00
azaozz
4a5e7ba2e4 Implementing new design for Edit Posts, Comments, etc. lists, props mdawaffe, see #8083
git-svn-id: http://svn.automattic.com/wordpress/trunk@9556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-06 21:56:29 +00:00
ryan
ae2c4bc50c Add opt-in optioon for comment hotkeys. Props nbachiyski. fixes #7643
git-svn-id: http://svn.automattic.com/wordpress/trunk@9217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-16 22:23:32 +00:00
markjaquith
6666636cbd Turn the Visual Editor user preference on its head, to more accurately reflect what it does now. fixes #6403. props MattyRob.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-02 22:01:33 +00:00
ryan
5fd146865b phpdoc for wp-admin/includes from jacobsantos. see #7527
git-svn-id: http://svn.automattic.com/wordpress/trunk@9053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-02 01:03:26 +00:00
westi
95e26235ad Notice fixes see #7509 props DD32 and jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-21 20:41:25 +00:00
ryan
203086a4de Option to force SSL. see #7561
git-svn-id: http://svn.automattic.com/wordpress/trunk@8701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-21 17:40:38 +00:00
ryan
113c014920 Notice fixes. Props DD32. see #7509
git-svn-id: http://svn.automattic.com/wordpress/trunk@8646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-14 17:00:37 +00:00
westi
1a98124b2c Remove extra } from query. Fixes #7416 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-07-27 08:40:29 +00:00
ryan
3f24ac2605 Fix users.php paging. Props DD32. fixes #4017
git-svn-id: http://svn.automattic.com/wordpress/trunk@8195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-25 17:02:17 +00:00
ryan
248a0c06e2 Prepare DB queries in more places. Props filosofo. see #6644
git-svn-id: http://svn.automattic.com/wordpress/trunk@7645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-04-14 16:13:25 +00:00
matt
8734e3d1bf So fresh and so clean, clean.
git-svn-id: http://svn.automattic.com/wordpress/trunk@7313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-15 17:02:16 +00:00
ryan
f0479dbc17 Admin color selector. see #6167
git-svn-id: http://svn.automattic.com/wordpress/trunk@7249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-11 21:06:03 +00:00
ryan
04c9051a7d Remove trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@7130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-02 20:17:30 +00:00
ryan
53c157426b Back to 50 per page
git-svn-id: http://svn.automattic.com/wordpress/trunk@6887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-17 20:24:43 +00:00
ryan
20e180de64 Remove pseudo role group by
git-svn-id: http://svn.automattic.com/wordpress/trunk@6886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-17 20:16:22 +00:00
ryan
22195eeaed users.php redesign. WIP
git-svn-id: http://svn.automattic.com/wordpress/trunk@6875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-16 21:44:50 +00:00
ryan
b7b689e35f Move WP_User_Search to admin includes. Props Viper007Bond. fixes #5111
git-svn-id: http://svn.automattic.com/wordpress/trunk@6615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-14 21:55:17 +00:00
ryan
dab1c792c7 Remove unused variables. Props DD32. fixes #5418
git-svn-id: http://svn.automattic.com/wordpress/trunk@6354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-05 00:29:05 +00:00
ryan
43b7cd700f get_user_by_email() and some user caching cleanups. fixes #5392
git-svn-id: http://svn.automattic.com/wordpress/trunk@6346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-27 22:14:53 +00:00
ryan
f831731601 JS/AJAX form validation from mdawaffe. fixes #5299
git-svn-id: http://svn.automattic.com/wordpress/trunk@6303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-01 06:23:16 +00:00
markjaquith
6aa8345250 Some error message normalization from Viper007Bond and DD32. fixes #5139
git-svn-id: http://svn.automattic.com/wordpress/trunk@6188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-04 19:38:35 +00:00
ryan
321c310717 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@6026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:32:58 +00:00
markjaquith
d50996b941 Order pending posts nag by post_modified ASC, drafts by post_modified DESC
git-svn-id: http://svn.automattic.com/wordpress/trunk@5750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-24 05:58:38 +00:00
markjaquith
7f44512c5d Introducing post_status="pending". see #4446 and put any initial bug reports on that ticket
git-svn-id: http://svn.automattic.com/wordpress/trunk@5707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-14 16:24:28 +00:00
ryan
770613e763 Admin includes reorg. see #4334
git-svn-id: http://svn.automattic.com/wordpress/trunk@5542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-05-25 07:16:21 +00:00