Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Gary Pendergast
c90cfa3b50
General: Fix some precision alignment formatting warnings.
...
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.
See #41057 .
Built from https://develop.svn.wordpress.org/trunk@42228
git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-26 23:57:55 +00:00
Sergey Biryukov
139387b7e5
Docs: Use 3-digit, x.x.x-style semantic versioning for _doing_it_wrong()
, _deprecated_function()
, _deprecated_argument()
, and _deprecated_file()
throughout core.
...
Props metodiew.
Fixes #36495 .
Built from https://develop.svn.wordpress.org/trunk@37985
git-svn-id: http://core.svn.wordpress.org/trunk@37926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-06 12:40:29 +00:00
Drew Jaynes
b1804afeaf
Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
...
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.
Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.
Props ocean90.
Fixes #36835 .
Built from https://develop.svn.wordpress.org/trunk@37431
git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 18:41:31 +00:00
Dominik Schilling
21b9965613
Theme Compat: Replace the custom comment form with comment_form()
and reduce number of links.
...
`comment_form()` has nearly the same markup as the custom form but also includes the latest enhancements like improved a11y and more filters.
Add translators comments, props ramiy.
Fixes #35888 .
Built from https://develop.svn.wordpress.org/trunk@36595
git-svn-id: http://core.svn.wordpress.org/trunk@36562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-20 14:41:27 +00:00
Sergey Biryukov
d8f50fef8a
Don't use <a>
in translatable string in theme-compat/comments.php
.
...
Add translator comments.
Props ramiy.
See #34503 .
Built from https://develop.svn.wordpress.org/trunk@35455
git-svn-id: http://core.svn.wordpress.org/trunk@35419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 10:38:25 +00:00
Dominik Schilling
0891de90e0
Theme Compat: Remove commented out code.
...
See #31867 .
Built from https://develop.svn.wordpress.org/trunk@34316
git-svn-id: http://core.svn.wordpress.org/trunk@34280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 21:38:25 +00:00
Sergey Biryukov
ddff6fe471
Don't capitalize words in a sentence after comma.
...
props bjornjohansen, netweb.
fixes #31927 .
Built from https://develop.svn.wordpress.org/trunk@33079
git-svn-id: http://core.svn.wordpress.org/trunk@33050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 00:50:25 +00:00
Mark Jaquith
cf38b016e8
Revert [33038] because of objections raised on #22889 and #31590
...
Built from https://develop.svn.wordpress.org/trunk@33042
git-svn-id: http://core.svn.wordpress.org/trunk@33013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 00:47:24 +00:00
Mark Jaquith
9d11efe23c
Say goodbye to ?replytocom=123 links and their URL pollution.
...
* Comment reply links continue to use JS as before.
* ?replytocom=123 links are deprecated.
props joostdevalk
fixes #22889
Built from https://develop.svn.wordpress.org/trunk@33038
git-svn-id: http://core.svn.wordpress.org/trunk@33009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 21:42:25 +00:00
Dominik Schilling
79a930aeb5
Theme Compat: Make string translatable and add translator comments. Added in [31941].
...
props dimadin.
see #28502 .
fixes #31921 .
Built from https://develop.svn.wordpress.org/trunk@32084
git-svn-id: http://core.svn.wordpress.org/trunk@32063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 18:15:28 +00:00
Sergey Biryukov
36643388ef
Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
...
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.
fixes #28502 .
Built from https://develop.svn.wordpress.org/trunk@31941
git-svn-id: http://core.svn.wordpress.org/trunk@31920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 18:45:28 +00:00
John Blackbourn
bdd00b3902
Improve various hook and filter docs so they are correctly parsed for the code reference.
...
Fixes #30558
Props DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30754
git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:32:24 +00:00
Andrew Nacin
e230a71bdb
Use site_url() in theme-compat.
...
props technosailor.
see #25418 .
Built from https://develop.svn.wordpress.org/trunk@25672
git-svn-id: http://core.svn.wordpress.org/trunk@25588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:17:09 +00:00
ryan
7b49ad8493
Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
...
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 18:30:03 +00:00
ryan
616c35e71c
One newline is enough.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
nacin
43eae59235
Translated strings in attributes require esc_attr(). s/_e/esc_attr_e/g
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-20 15:04:46 +00:00
nacin
0552424317
Revert submit_button() for wp-includes, setup-config, install, login, signup. see [16061], see #15064 , fixes #15247 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-29 00:31:27 +00:00
markjaquith
fc6e89da45
Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
nacin
5e1184aa57
Pinking shears.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-19 07:48:22 +00:00
westi
c1c0effc6a
Improved translation of the comment count in theme-compat. Props zeo.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 08:52:14 +00:00
westi
f268a16a8b
First pass of conversion of theme-compat to the I18N version of the files. See #12425
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-20 21:53:11 +00:00
westi
c01891f5bd
Refactor the error messages and make them translatable.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 10:13:40 +00:00
westi
ae468d52ac
First pass of compatibility code for old themes which relied on using templates from the default theme without expressly identifying it as the parent theme.
...
Fixes #12425 and #13009 .
The fallback to these template files is now depreceated and will be removed in a future version.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 09:57:24 +00:00