Commit Graph

112 Commits

Author SHA1 Message Date
ryan
15b9961b52 set_url_scheme() for header and background image srcs. see #20702
git-svn-id: http://core.svn.wordpress.org/trunk@20830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-18 20:22:57 +00:00
ryan
7e3010ef46 Use correct translation function. Props kobenland, SergeyBiryukov. fixes #20646
git-svn-id: http://core.svn.wordpress.org/trunk@20757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-09 21:13:22 +00:00
ryan
d3134e2688 Allow selecting custom header and background images from the media library. Props aaroncampbell, sabreuse, greuben. fixes #19840
git-svn-id: http://svn.automattic.com/wordpress/trunk@20358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-05 00:20:28 +00:00
nacin
6593186cb7 Introduce new registration methods for custom headers and custom backgrounds. Backwards compatible, but old methods will be deprecated. see #20249. see #17242.
Custom header: Use add_theme_support('custom-header', $args) instead of add_custom_image_header(). Deprecates all use of constants.
 * HEADER_TEXTCOLOR is now (string) 'default-text-color'.
 * NO_HEADER_TEXT is nowi ! (bool) 'header-text'.
 * HEADER_IMAGE_WIDTH (and _HEIGHT) are now (int) 'width' and 'height'.
 * HEADER_IMAGE is now (string) 'default-image'.
 * The 3.4 arguments 'suggested-width' and 'suggested-height' are now just 'width' and 'height' (they are "suggested" when flex-width and flex-height are set).
 * Callback arguments for add_custom_image_header() can now be passed to add_theme_support().

Custom background: Use add_theme_support('custom-background, $args) instead of add_custom_background(). Deprecates all use of constants.
 * BACKGROUND_COLOR is now (string) 'default-color'.
 * BACKGROUND_IMAGE is now (string) 'default-image'.
 * Callback arguments for add_custom_background() can now be passed to add_theme_support().

Inheritance: add_theme_support() arguments for custom headers and custom backgrounds is a first-one-wins situation. This is not an unusual paradigm for theming as a child theme (which is included first) overrides a parent theme.
 * Once an argument is explicitly set, it cannot be overridden. You must hook in earlier and set it first.
 * Any argument that is not explicitly set before WP is loaded will inherit the default value for that argument.
 * It is therefore possible for a child theme to pass minimal arguments as long as the parent theme specifies others that may be necessary.
 * Allows for a child theme to alter callbacks for <head> and preview (previously, calling add_custom_image_header more than once broke things).
 * The just-in-time bits ensure that arguments fall back to default values, that the values of all constants are considered (such as one defined after an old add_custom_image_header call), and that all constants are defined (so as to be backwards compatible).

get_theme_support(): Introduce new second argument, which headers and backgrounds leverage to return an argument. current_theme_supports() already supported checking the truthiness of the argument.
 * For example, get_theme_support( 'custom-header', 'width' ) will return the width specified during registration.
 * If you had wanted the default image, use get_theme_support( 'custom-header', 'default-image' ) instead of HEADER_IMAGE. 

Deprecate remove_custom_image_header(), remove_custom_background(). Use remove_theme_support('custom-header'), 'custom-background'.

Deprecate short-lived custom-header-uploads internal support; this is now (bool) 'uploads' for add_theme_support().

New 3.4 functions renamed or removed: Rename get_current_header_data() to get_custom_header(). Remove get_header_image_width() and _height() in favor of get_custom_header()->width and height.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-19 17:12:44 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin
15ceab2647 Standardize some final help strings. We're done, aside from typos. props zeo, jane, duck_, fixes #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-02 04:31:01 +00:00
ryan
32915a8574 Fix indent. see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 02:28:47 +00:00
ryan
8ace5a6b4c Use WP_Screen::add_help_tab(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 02:22:07 +00:00
nacin
65a10cedbb Help tweaks for themes, plugins screens. props jane, see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 01:24:39 +00:00
nacin
bfb98c193e s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
ryan
3ad1f67958 Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
nacin
fab91dd3d0 Fix attribute spacing. props mfields, fixes #18570.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-07 13:53:02 +00:00
ryan
8192d0dae8 Validation fixes. Props ocean90, peaceablewhale. see #17364
git-svn-id: http://svn.automattic.com/wordpress/trunk@18010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-23 23:33:30 +00:00
ryan
2cfb1592f0 Mark import attachments as private. Schedule job to delete old import attachments. Introduce attachment context.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-22 23:25:28 +00:00
nacin
e324f8dd88 Add clear to custom background color field. props lancewillett for initial patch. fixes #15755.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 03:31:01 +00:00
ryan
d55f5b35af Denote images that are headers or backgrounds in the media ui. Props ocean90. fixes #17291
git-svn-id: http://svn.automattic.com/wordpress/trunk@17793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 18:28:31 +00:00
ryan
04487fc268 Constructor cleanup. Props ocean90. fixes #16768
git-svn-id: http://svn.automattic.com/wordpress/trunk@17771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-29 20:05:12 +00:00
nacin
9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 15:24:49 +00:00
ryan
3f72e340d6 Update since phpdoc. Props demetris. fixes #15445
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:24:38 +00:00
markjaquith
fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
scribu
799baf139c Use submit_button() in more places. See #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@15830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-17 18:24:34 +00:00
nacin
15bc341696 phpdoc, @since, whitespace. Also require an argument in wp_insert_post(). props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-05 02:45:39 +00:00
nacin
0a30928ce3 Missing links for custom background, header, and GUU. props zeo.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 18:00:29 +00:00
nacin
69164abe07 Improve the custom background front-end callback. Also, background-attachment should default to scroll, not fixed. fixes #13751.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-10 18:28:25 +00:00
nacin
fc172d4d9a Help whitespace/punctuation cleanup. props zeo, see #13467.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-29 16:16:40 +00:00
nacin
7d34f2f431 The 'Help' tab on the custom background page should have, you know, custom background help. Oops. see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-28 00:31:16 +00:00
nacin
c91b9cc817 Custom header and background help. props jane, see #13467.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-28 00:27:53 +00:00
nacin
549ec140b9 Custom background UI tweaks. Make 'Select Color' a link instead of a button, move color below the background image options, standardize screen reader text.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-28 00:01:59 +00:00
nacin
79f077c6f6 Custom background UI updates. Add padding to radio buttons, also convert repeat/title to radio buttons. props JohnONolan, see #12186.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-21 03:31:35 +00:00
nacin
4ef2ae30fd Show updated message after resetting or removing the background image. see #12186.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 05:38:14 +00:00
nacin
d6e2ef4dbf Custom background UI updates. props ocean90 for initial patch, see #12186.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 05:17:57 +00:00
nacin
09f2cbdfa4 Validation and nonce improvements to custom background UI. props ocean90, see #12186.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-15 19:47:03 +00:00
nacin
cb0a9024ad Ensure validation. props Utkarsh, see #13383.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-14 08:20:06 +00:00
nacin
c5c6244c50 Use inline styles in custom background admin, and prepopulate background options. props jshreve, see #12186.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-14 06:48:47 +00:00
nacin
ab0cf8d942 Add closing tr tag to custom-background.php. Close paragraph tags in the recent comments and posts widget controls. props jshreve, see #13383.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-14 01:50:46 +00:00
nacin
7389ea41ea Use the edit_theme_options capability. fixes #13290.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-12 19:19:57 +00:00
ryan
82082002fb Remove only the background image, not all theme mods, when resetting the background to the default. Props ocean90. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@14578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-12 16:18:25 +00:00
ryan
c982678a0b Remove redundant CSS, lighten up border on background preview, change labels for background preview. Props johnonolan. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@14577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-12 16:03:49 +00:00
nacin
9fb099891f Add trailing slash to some home_url() calls. props zeo, fixes #13245.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-04 17:13:11 +00:00
ryan
7b7243d94a Strip trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 20:26:11 +00:00
dd32
796c494295 Add reset background image to theme default. Props lancewillett. See #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@14379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 18:52:38 +00:00
nacin
b25092d5b0 Custom background UI tweaks. Props TECannon. see #12186, fixes #12699
git-svn-id: http://svn.automattic.com/wordpress/trunk@14209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-23 22:10:21 +00:00
dd32
442d41291a Tweak new strings for better typography. Props demetris. Fixes #12962
git-svn-id: http://svn.automattic.com/wordpress/trunk@14070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-11 10:41:54 +00:00
dd32
f0088e38eb Add Repeat-x/repeat-y support to Custom Backgrounds, Add Live preview of Repeat option, Use Thumbnail of background for Background Preview. Props jshreve. See #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-28 02:53:04 +00:00
nacin
40773a776b Remove trailing whites and double semicolons.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:36:49 +00:00
nacin
a7feaed0e6 Change @since 3.0 to @since 3.0.0.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:13:36 +00:00
dd32
3d5e274179 Cleanup of Custom Background. Move JS to external file, Add @since, Remove redundant steps functionality, Preview of Image alignment. See #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-21 06:06:18 +00:00
dd32
0c47af2d38 Show Background preview and options when no Image is uploaded. Display "Updated" div upon updates. Fix Colour Picker not loading after uploading a background image. See #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-19 09:33:29 +00:00
dd32
0b4c703fd8 Add instant background-color feedback to Custom Backgrounds. Add input validation to user-entered colour data. See #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-19 09:10:37 +00:00
nacin
5097dba597 Use h3 (not h2) to break up sections on custom header/bg screens. Move div.updated message to right after the h2, as JS will move it there anyway.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-18 19:06:57 +00:00
markjaquith
58d47426cc More pedantry. "Setup" is not a verb. http://notaverb.com/setup
git-svn-id: http://svn.automattic.com/wordpress/trunk@13725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-17 04:39:50 +00:00
ryan
59873d0b4f Custom background color fixes. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-11 20:21:58 +00:00
ryan
4b766eb312 Background color selection. Props lancewillett. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-03 17:10:43 +00:00
ryan
111e334aca Drop 'Custom' from menu names. Use 'Menus' instead of Navigation. see #11817
git-svn-id: http://svn.automattic.com/wordpress/trunk@13339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-23 20:28:52 +00:00
markjaquith
09e8d27130 Whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@13316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-22 23:12:48 +00:00
ryan
2518cd05bc Typo fix. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-22 20:15:48 +00:00
ryan
05edcb0c45 Grammar fix. Don't show empty img. Cleanup POST handler. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-22 20:15:06 +00:00
ryan
0ebb6732bf Custom background styling fixes. Props yoavf. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-22 18:46:29 +00:00
ryan
f35b2128ae Add defaults for background option radios. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-18 03:12:05 +00:00
ryan
d472b153ca Add some options to custom background admin. Needs styling. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-18 00:14:56 +00:00
ryan
6eadff2714 Use switch_themes instead of edit_themes so that non super admins on multisite installs can customize headers and backgrounds. Add CYA cap checks.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-10 16:49:16 +00:00
ryan
61859c5f5e First pass at custom background support. Needs UI love. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-09 20:37:12 +00:00