Commit Graph

19607 Commits

Author SHA1 Message Date
John Blackbourn b6c6c35c1b WordPress 6.0.8.
Built from https://develop.svn.wordpress.org/branches/6.0@57964


git-svn-id: http://core.svn.wordpress.org/branches/6.0@57458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-04-09 15:33:07 +00:00
Joe McGill b934f4596f WordPress 6.0.7.
Built from https://develop.svn.wordpress.org/branches/6.0@57434


git-svn-id: http://core.svn.wordpress.org/branches/6.0@56940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-30 16:35:13 +00:00
Aaron Jorbin 76807c3079 Grouped Backports to the 6.0 branch
- Install: When populating options, maybe_serialize instead of always serialize.
- Uploads: Check for and verify ZIP archives.

Merges [57388] and [57389] to the 6.0 branch.

Props costdev, peterwilsoncc, azaozz, tykoted, johnbillion, desrosj, afragen, jorbin, xknown.


Built from https://develop.svn.wordpress.org/branches/6.0@57395


git-svn-id: http://core.svn.wordpress.org/branches/6.0@56901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-30 14:41:13 +00:00
audrasjb adbdf975bd WordPress 6.0.6.
Built from https://develop.svn.wordpress.org/branches/6.0@56892


git-svn-id: http://core.svn.wordpress.org/branches/6.0@56403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-10-12 18:39:14 +00:00
Joe McGill 173b1a5337 Grouped backports to the 6.0 branch.
- REST API: Limit `search_columns` for users without `list_users`.
- Comments: Prevent users who can not see a post from seeing comments on it.
- Application Passwords: Prevent the use of some pseudo protocols in application passwords.
- Restrict media shortcode ajax to certain type
- REST API: Ensure no-cache headers are sent when methods are overriden.
- Prevent unintended behavior when certain objects are unserialized.

Merges [56833], [56834], [56835], [56836], [56837], and [56838] to the 6.0 branch.
Props xknown, jorbin, Vortfu, joehoyle, timothyblynjacobs, peterwilsoncc, ehtis, tykoted, martinkrcho, paulkevan, dd32, antpb, rmccue.

Built from https://develop.svn.wordpress.org/branches/6.0@56870


git-svn-id: http://core.svn.wordpress.org/branches/6.0@56381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-10-12 18:18:49 +00:00
desrosj 0dbb25a43d WordPress 6.0.5.
Built from https://develop.svn.wordpress.org/branches/6.0@55835


git-svn-id: http://core.svn.wordpress.org/branches/6.0@55347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-05-20 04:15:51 +00:00
audrasjb 7a6bb60778 Grouped backports to the 6.0 branch.
- Media: Prevent CSRF setting attachment thumbnails.
- Embeds: Add protocol validation for WordPress Embed code.
- I18N: Introduce sanitization function for locale.
- Editor: Ensure block comments are of a valid form.
- Editor: Remove shortcode support from block templates.

Merges [55760-55764] to the 6.0 branch.
Props dd32, isabel_brison, martinkrcho, matveb, ocean90, paulkevan, peterwilsoncc, timothyblynjacobs, xknown, youknowriad.


Built from https://develop.svn.wordpress.org/branches/6.0@55773


git-svn-id: http://core.svn.wordpress.org/branches/6.0@55285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-05-16 15:20:13 +00:00
Peter Wilson c084bac788 I18N: Add new strings to `about.php` for use with end-of-life updates.
This changeset adds two additional translation strings in the changelog file, for use when releasing the final version of WordPress on a particular branch.

Props peterwilsoncc, audrasjb, mukesh27.
Merges [55350] to the 6.0 branch.
Fixes #57216.


Built from https://develop.svn.wordpress.org/branches/6.0@55372


git-svn-id: http://core.svn.wordpress.org/branches/6.0@54905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-21 02:39:12 +00:00
audrasjb 558b045358 Help/About: Update the About page for WordPress 6.0.3.
Built from https://develop.svn.wordpress.org/branches/6.0@54577


git-svn-id: http://core.svn.wordpress.org/branches/6.0@54131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-10-17 19:40:26 +00:00
audrasjb 2049ade675 Media: Refactor search by filename within the admin.
Props vortfu, xknown, peterwilsoncc, paulkevan.
Merges [54524] to the 6.0 branch.

Built from https://develop.svn.wordpress.org/branches/6.0@54534


git-svn-id: http://core.svn.wordpress.org/branches/6.0@54089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-10-17 12:26:09 +00:00
Peter Wilson d1b6543d22 Security: Introduce strings to indicate support status.
Add strings for use in future maintenance/security releases to indicate the security support status of the version of WordPress.

Two strings are introduced:

* indicating the version of WordPress is not receiving security updates, and,
* indicating the version of WordPress will shortly stop receiving security updates.

This change does not make use of the strings, the purpose is to make them available to translators prior to dropping support of selected versions of WordPress.

Props costdev, chesio, robinwpdeveloper, desrosj, rudlinkon, mukesh27, sumitbagthariya16.
Merges [54322] to the 6.0 branch.
See #56532.


Built from https://develop.svn.wordpress.org/branches/6.0@54430


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-10-10 04:45:16 +00:00
desrosj 3eeab6c06b WordPress 6.0.2.
Built from https://develop.svn.wordpress.org/branches/6.0@53987


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-08-30 17:24:15 +00:00
Sergey Biryukov e7a4fcd163 Plugins: Escape output in error messages.
Props tykoted, paulkevan, peterwilsoncc.
Merges [53960] to the 6.0 branch.
Built from https://develop.svn.wordpress.org/branches/6.0@53963


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-08-30 15:23:08 +00:00
Sergey Biryukov 4be05ba50f Help/About: Improve vertical alignment in the Additional Design Tools section.
This makes a transparent circle SVG smaller by removing empty space to match the height of other images in the same section, so that all three columns are aligned correctly.

Follow-up to [53339].

Props sabernhardt, weboccults, ironprogrammer, webcommsat, marybaum, oglekler.
Merges [53924] to the 6.0 branch.
Fixes #56210.
Built from https://develop.svn.wordpress.org/branches/6.0@53925


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-08-23 13:50:08 +00:00
Sergey Biryukov 7dfcfb4718 Help/About: Update the About page for WordPress 6.0.1.
Fixes #56200.
Built from https://develop.svn.wordpress.org/branches/6.0@53694


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-07-12 12:54:16 +00:00
Sergey Biryukov bb5f476908 Editor: Include user's name in the `wp_refresh_post_lock()` response.
This ensures that the post lock data returned by the Heartbeat API is consistent.

Previously, `wp_check_locked_posts()` was updated to return the name of the user currently editing the post, but the `wp_refresh_post_lock()` response did not get a similar change.

Follow-up to [53070].

Props nathan.noom.
Merges [53692] to the 6.0 branch.
Fixes #56197.
Built from https://develop.svn.wordpress.org/branches/6.0@53693


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-07-11 18:22:22 +00:00
Sergey Biryukov 1579b5d2e0 Themes: Revert the change of theme preview width on Add Themes screen.
The intention was for the preview ratio to remain accurate for the user's screen size when the sidebar is open, but this appears to have caused unintended side effects to the preview alignment.

Follow-up to [52647].

Props superbthemescom, Presskopp.
Merges [53663] to the 6.0 branch.
Fixes #56097. See #54764.
Built from https://develop.svn.wordpress.org/branches/6.0@53664


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-07-05 15:38:12 +00:00
Sergey Biryukov 403a1ee7e7 Help/About: Add cache busting string to video thumbnail.
Append `?ver=6.0` to the image used for linking to the video to break the cache in browsers, proxy servers and on the CDN.

A new version of the image has been uploaded and replaced the file in the original location.

Props annezazu, critterverse, ryelle, costdev, ironprogrammer, dd32, peterwilsoncc.
Merges [53447] to the 6.0 branch.
Fixes #55808.
Built from https://develop.svn.wordpress.org/branches/6.0@53649


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-07-04 18:38:15 +00:00
Peter Wilson 9e63e99a3d Help/About: Finalise links on about page.
Wrap up about page for 6.0 release.

Props ryelle, mukesh27, hellofromTonya, SergeyBiryukov, peterwilsoncc.
Merges [53442] to the 6.0 branch.
Fixes #55775.


Built from https://develop.svn.wordpress.org/branches/6.0@53443


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-24 00:19:18 +00:00
Sergey Biryukov dce34573ae Upgrade/Install: Update `$_old_files` for 6.0.
Props hellofromTonya, JeffPaul, SergeyBiryukov.
Merges [53439] to the 6.0 branch.
Fixes #55794.
Built from https://develop.svn.wordpress.org/branches/6.0@53440


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-23 17:04:14 +00:00
ryelle a826d9e50c Administration: Fix image overlap in Dashboard welcome panel.
Use longhand positioning properties (top, right, etc) so that the rtlcss build process can correctly adjust the layout for the RTL CSS.

Props ryelle, costdev, ironprogrammer, hellofromtonya.
Merges [53437] to the 6.0 branch.
Fixes #55793.


Built from https://develop.svn.wordpress.org/branches/6.0@53438


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-23 16:55:13 +00:00
Peter Wilson 2011bb9093 Themes: Accept valid block themes.
Updates theme validation to accept block themes. This replaces the requirement for an `index.php` with a requirement for either an `index.php`, `/templates/index.html` or the deprecated `/block-templates/index.html`.

Validation is updated for theme uploads, within `WP_Theme::__construct` and `validate_current_theme()`. 

A block theme using the deprecated file structure is now included in the unit tests.

Props peterwilsoncc, sergeybiryukov, hellofromtonya, costdev, azaozz, gziolo, FlorianBrinkmann, Boniu91, aristath, poena, audrasjb.
Merges [53416] to the 6.0 branch.
Fixes #55682.

Built from https://develop.svn.wordpress.org/branches/6.0@53417


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-20 01:01:14 +00:00
Peter Wilson 5541f90c38 Site Editor: Include `style` parameter in home template redirect.
When redirecting the site editor to the home template include the `style` querystring parameter if it is set. This ensures the style panel opens if the user expects it.

Props grantmkin, mamaduka, peterwilsoncc, gziolo.
Merges [53413] to the 6.0 branch.
Fixes #55752.


Built from https://develop.svn.wordpress.org/branches/6.0@53415


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-20 00:19:20 +00:00
ryelle 94a29bade1 Help/About: Ensure about page shows current header.
Add a query string parameter to the about page header images to ensure the cache is broken in browsers and CDNs.

Props ryelle.
Merges [53409] to the 6.0 branch.
Fixes #55750.


Built from https://develop.svn.wordpress.org/branches/6.0@53412


git-svn-id: http://core.svn.wordpress.org/branches/6.0@53001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-18 15:42:15 +00:00
gziolo 347a117b37 Editor: Update WordPress packages for 6.0 RC 3
[53402] Theme: Use a better method to determine the theme name during export

[53403] Editor: Update WordPress packages for 6.0 RC 3

[53404] Editor: Return additional block patterns to server-generated settings

Props SergeyBiryukov, scruffian, davidbaumwald, jeremyfelt, zieladam, ndiego, jsnajdr, peterwilsoncc, johnstonphilip.
Merges [53402], [53403] and [53404] to the 6.0 branch.
Fixes #55567.


Built from https://develop.svn.wordpress.org/branches/6.0@53405


git-svn-id: http://core.svn.wordpress.org/branches/6.0@52994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-17 15:43:41 +00:00
ryelle 83ec312628 Administration: Update design of the Dashboard welcome panel.
This updates the panel to match the 6.0 About page styles, with the 6.0 graphic changing color based on the selected admin color scheme.

Props fcoveram, critterverse, joedolson, SergeyBiryukov.
Merges [53383] to the 6.0 branch.
Fixes #55532.


Built from https://develop.svn.wordpress.org/branches/6.0@53385


git-svn-id: http://core.svn.wordpress.org/branches/6.0@52974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-10 17:10:09 +00:00
ryelle 22a6198eb8 Help/About: Update the About section for 6.0.
Switch the images to use the s.w.org CDN. Update the font style and spacing on the About page. Update the header images for Credits, Freedoms, and Privacy.

Props fcoveram, peterwilsoncc, SergeyBiryukov.
Merges [53382] to the 6.0 branch.
Fixes #55434.


Built from https://develop.svn.wordpress.org/branches/6.0@53384


git-svn-id: http://core.svn.wordpress.org/branches/6.0@52973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-10 16:58:08 +00:00
Peter Wilson afa1841d32 Quick/Bulk Edit: Remove duplicate HTML IDs.
Rename `#inline-edit-legend` to avoid duplicate HTML IDs. These have been renamed `#quick-edit-legend` and `#bulk-edit-legend` for the quick and bulk editors respectively.

This HTML ID is not required by the quick editor duplicated via JavaScript so is removed as part of the duplication process.

Follow up to [53096].

Props azaozz, costdev, greglone, hellofromtonya, ironprogrammer, joedolson, sabernhardt, SergeyBiryukov, audrasjb.
Merges [53352] to the 6.0 branch.
Fixes #55575.
See #35483.

Built from https://develop.svn.wordpress.org/branches/6.0@53361


git-svn-id: http://core.svn.wordpress.org/branches/6.0@52950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-07 03:10:13 +00:00
audrasjb 974c591ce3 Help/About: Add link to 6.0 Field Guide, fix missing placeholder in string.
Follow-up to [53339].

Props audrasjb, ryelle.
Merges [53354] to the 6.0 branch.
See #55434.

Built from https://develop.svn.wordpress.org/branches/6.0@53356


git-svn-id: http://core.svn.wordpress.org/branches/6.0@52945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-05 22:03:13 +00:00
ryelle 7bd9548322 Help/About: Update the About section for 6.0.
This is the start of the WordPress 6.0 about page, introducing new content and a first pass of the new style.

Props fcoveram, estelaris, JeffPaul, critterverse, chanthaboune, dansoschin, webcommsat, annezazu, marybaum, cbringmann, eidolonnight, laurlittle, sergeybiryukov.
See #55434.


Built from https://develop.svn.wordpress.org/trunk@53339


git-svn-id: http://core.svn.wordpress.org/trunk@52928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-03 16:28:09 +00:00
audrasjb 4de4330b17 General: Add missing `strong` tag to some error messages.
This changeset adds missing `strong` tag to some error messages and updates some AJAX messages, for better consistency.

Follow-up to [53118].

Props NekoJonez, audrasjb, ocean90.
Fixes #54437.

Built from https://develop.svn.wordpress.org/trunk@53337


git-svn-id: http://core.svn.wordpress.org/trunk@52926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-03 14:53:09 +00:00
Sergey Biryukov 056bbc95ea Docs: Improve `plugin_install_action_links` filter's docs.
Refer developers to `plugins_api()` for array of plugin data.

Follow-up to [53074], [53328].

Props afragen, pbiron.
See #55480.
Built from https://develop.svn.wordpress.org/trunk@53330


git-svn-id: http://core.svn.wordpress.org/trunk@52919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-02 13:07:14 +00:00
Peter Wilson 0fcdd744c1 Plugins: Improve `plugin_install_description` filter's docs.
Refer developers to `plugins_api()` for array of plugin data.

Props afragen, pbiron, SergeyBiryukov, costdev.
Fixes #55480.


Built from https://develop.svn.wordpress.org/trunk@53328


git-svn-id: http://core.svn.wordpress.org/trunk@52917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-05-02 02:46:11 +00:00
John Blackbourn bdaba2407c Docs: Improve documentation of the `walker` argument for various functions.
See #54729

Built from https://develop.svn.wordpress.org/trunk@53318


git-svn-id: http://core.svn.wordpress.org/trunk@52907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-29 19:28:09 +00:00
Peter Wilson ef8a32f6b9 Media: Validate track number ID3 tags before use.
Validate current and total track ID3 tags as numeric before use.

Props mjkhajeh, SergeyBiryukov, costdev.
Fixes #55204.


Built from https://develop.svn.wordpress.org/trunk@53307


git-svn-id: http://core.svn.wordpress.org/trunk@52896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-29 04:50:12 +00:00
Sergey Biryukov 2334cea3e9 Bootstrap/Load: Move some more administration-related hooks to `admin-filters.php`.
Follow-up to [53266].

Fixes #54795.
Built from https://develop.svn.wordpress.org/trunk@53304


git-svn-id: http://core.svn.wordpress.org/trunk@52893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-28 16:39:11 +00:00
Mike Schroder d9266d5bfd Media: Ensure `wp_read_image_metadata` filter returns array for `$iptc` and `$exif`.
Makes the behavior of the filter lines up with its documentation.
Previously, both `$iptc` and `$exif` could return `false` when `exif_read_data()` or `iptcparse()` failed.

Now, if those functions do not return an array, the results are explicitly set to `array()`.

Props volodymyrkolesnykov, SergeyBiryukov, sabernhardt, sumitsingh, mikeschroder.
Fixes #54637.
Built from https://develop.svn.wordpress.org/trunk@53303


git-svn-id: http://core.svn.wordpress.org/trunk@52892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-28 11:00:10 +00:00
John Blackbourn c6dbcf8576 Docs: Various docblock corrections and improvements for changes introduced in 6.0.
See #54729

Built from https://develop.svn.wordpress.org/trunk@53302


git-svn-id: http://core.svn.wordpress.org/trunk@52891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-28 09:59:13 +00:00
John Blackbourn 6aa053dc01 Docs: Various docblock improvements.
See #54729

Built from https://develop.svn.wordpress.org/trunk@53299


git-svn-id: http://core.svn.wordpress.org/trunk@52888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-28 09:46:21 +00:00
Peter Wilson 87c8ca71b5 Built tools: Reduce file size of About page texture.
Reduce the file size of the file `src/wp-admin/images/about-texture.png` by running it through the grunt precommit hook.

Other modified files are not included in this commit as there is no change in file size.

See #48703.


Built from https://develop.svn.wordpress.org/trunk@53293


git-svn-id: http://core.svn.wordpress.org/trunk@52882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-27 05:37:08 +00:00
Peter Wilson da0ce4038f Media: Ensure `wp_crop_image()` returns correct file type.
Return the correct file path from `wp_crop_image()` when a developer modifies the file type with via the `image_editor_output_format` filter.

Previously the function would return a broken file reference containing the original file extension rather than the one specified via the filter.

Props mat-lipe, adamsilverstein.
Fixes #55403.


Built from https://develop.svn.wordpress.org/trunk@53292


git-svn-id: http://core.svn.wordpress.org/trunk@52881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-27 05:21:08 +00:00
audrasjb 22de3f7711 Widgets: Fix Classic Widgets screen toggle response on small screens.
This changeset updates the toogle logic to fix Widget's responsive behavior on Classic Widgets screen.

Props inc2734, kmix39, dlh, desrosj, costdev, Boniu91.
Fixes #48896.

Built from https://develop.svn.wordpress.org/trunk@53267


git-svn-id: http://core.svn.wordpress.org/trunk@52856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-26 06:54:09 +00:00
audrasjb 813c4d604c Bootstrap/load: Move administration related hooks to `admin-filters.php`.
This change moves some administration related hooks from `default-filters.php` to `admin-filters.php`. It also updates the `default-filters.php` docblock to indicate that contextualized hooks should be located in the most appropriate place.

Props dlh, hellofromTonya, antonvlasenko, audrasjb, azaozz.
Fixes #54795.

Built from https://develop.svn.wordpress.org/trunk@53266


git-svn-id: http://core.svn.wordpress.org/trunk@52855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-26 06:32:08 +00:00
Peter Wilson e9610a5d20 Administration: Trigger a notice for incorrect `add_menu_page()` parameter.
Trigger a notice (via `_doing_it_wrong()`) for developers incorrectly setting the position when calling `add_menu_page()`.

Modify a similar message in `add_submenu_page()` to combine near identical strings and match the error description to the conditions in which it is called.

Follow up to [52569], [53104].

Fixes #40927.

Built from https://develop.svn.wordpress.org/trunk@53264


git-svn-id: http://core.svn.wordpress.org/trunk@52853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-26 02:59:08 +00:00
Sergey Biryukov 0cc2cb34cd Code Modernization: Rename parameters that use reserved keywords in `wp-admin/install-helper.php`.
While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the `$default` parameter to `$default_value` in `check_column()`.

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.
Built from https://develop.svn.wordpress.org/trunk@53232


git-svn-id: http://core.svn.wordpress.org/trunk@52821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-20 11:19:12 +00:00
Sergey Biryukov 91ad9dbb07 Code Modernization: Rename parameters that use reserved keywords in `wp-admin/includes/upgrade.php`.
While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the `$public` parameter to `$is_public` in `wp_install()`.

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.
Built from https://develop.svn.wordpress.org/trunk@53230


git-svn-id: http://core.svn.wordpress.org/trunk@52819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-20 10:46:09 +00:00
audrasjb 3d7603869b Docs: Misc fixes and improvements in the Administration Media API docblocks, as per documentation standards.
See #54729.

Built from https://develop.svn.wordpress.org/trunk@53229


git-svn-id: http://core.svn.wordpress.org/trunk@52818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-20 08:29:08 +00:00
audrasjb aab2815d58 Media: Remove `attachment_fields_to_save` filter and deprecate `image_attachment_fields_to_save()`.
This filter prevented removing attachment titles. This changeset removes the filter and deprecates the related function since it is no longer used.

Props dromero20, desrosj, Junaidkbr, francina, antpb, audrasjb, aadilali, etaproducto, azouamauriac, Boniu91, SergeyBiryukov.
Fixes #39108.

Built from https://develop.svn.wordpress.org/trunk@53228


git-svn-id: http://core.svn.wordpress.org/trunk@52817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-20 08:13:10 +00:00
Sergey Biryukov eeb9f68181 Menus: Use correct parameter in `_wp_nav_menu_meta_box_object()`.
Follow-up to [53220].

Props davidbaumwald.
See #55327.
Built from https://develop.svn.wordpress.org/trunk@53222


git-svn-id: http://core.svn.wordpress.org/trunk@52811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-19 15:59:10 +00:00
Sergey Biryukov 9ce061ae8c Code Modernization: Rename parameters that use reserved keywords in `wp-admin/includes/template.php`.
While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:
* Renames the `$echo` parameter to `$display` in:
 * `wp_popular_terms_checklist()`
 * `_post_states()`
 * `_media_states()`
* Renames the `$default` parameter to `$default_term` in `wp_popular_terms_checklist()`.
* Renames the `$default` parameter to `$default_template` in `page_template_dropdown()`.
* Renames the `$default` parameter to `$default_page` in `parent_dropdown()`.
* Renames the `$object` parameter to `$data_object` in:
 * `do_block_editor_incompatible_meta_box()`
 * `do_meta_boxes()`
 * `do_accordion_sections()`
* Amends the `$item_object` parameter in other functions for consistency:
 * `wp_nav_menu_item_post_type_meta_box()`
 * `wp_nav_menu_item_taxonomy_meta_box()`
 * `_wp_nav_menu_meta_box_object()`

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.
Built from https://develop.svn.wordpress.org/trunk@53220


git-svn-id: http://core.svn.wordpress.org/trunk@52809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-04-19 15:13:08 +00:00