Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-04 01:39:37 +01:00
Code Issues Projects Releases Wiki Activity
29,288 Commits 50 Branches 747 Tags 785 MiB
42b9557137
Commit Graph

64 Commits

Author SHA1 Message Date
Dominik Schilling
13ad2d4e16 Screen Options: Improve items per page option label. 
Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to `WP_Screen->render_per_page_options()` and removes all the existing one-word labels.

props afercia.
fixes #31349, #15576.
Built from https://develop.svn.wordpress.org/trunk@31696


git-svn-id: http://core.svn.wordpress.org/trunk@31677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-10 15:32:27 +00:00
Scott Taylor
0ec87e4584 There are a few functions that have the ability to return false instead of a string, so the return value should be checked before being passed to functions that expect string. 
These are trivial, but they clear out some Scrutinizer issues.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31681


git-svn-id: http://core.svn.wordpress.org/trunk@31662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-09 02:11:28 +00:00
Scott Taylor
7f8b548df1 In HTML5, the action attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 04:16:24 +00:00
Dominik Schilling
57c41263d7 Language packs: Remove translations when deleting a theme or a plugin. 
This is for translation files in WP_LANG_DIR which are installed through a language pack.
Change `wp_get_installed_translations()` to only return a translation if the .mo file also exists.

fixes #29860.
Built from https://develop.svn.wordpress.org/trunk@29856


git-svn-id: http://core.svn.wordpress.org/trunk@29619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-08 19:05:20 +00:00
Sergey Biryukov
53642c5d16 Network Admin: Properly check if the theme is active on the main site to avoid deleting it via bulk actions. 
props ocean90.
fixes #29861.
Built from https://develop.svn.wordpress.org/trunk@29839


git-svn-id: http://core.svn.wordpress.org/trunk@29603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-05 20:37:17 +00:00
Scott Taylor
64418c0192 In wp-admin/network/themes.php, break is unreachabled after exit. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28308


git-svn-id: http://core.svn.wordpress.org/trunk@28136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:08:14 +00:00
Andrew Nacin
dce0b9adea Use SSL when linking to WordPress.org. see #27115. 
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:14:15 +00:00
Andrew Nacin
df48cebeb4 No-JavaScript and no-Customizer support for the new Themes screen. 
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.

Built from https://develop.svn.wordpress.org/trunk@26726


git-svn-id: http://core.svn.wordpress.org/trunk@26615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-06 16:11:10 +00:00
Andrew Ozz
8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119 
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 03:53:11 +00:00
Andrew Nacin
fd57b239d2 Don't rely on include_path to include files. 
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-25 00:18:11 +00:00
Mark Jaquith
211a3eec8b Keep the theme update thickbox from being obscured by the toolbar. 
props ParadisePorridge, SergeyBiryukov. fixes #23984.

git-svn-id: http://core.svn.wordpress.org/trunk@24558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-05 15:15:58 +00:00
Dion Hulse
434aef8e89 Fix Bulk Theme Deletion in the Network Admin when using FTP. Props kobenland. Fixes #20671 
git-svn-id: http://core.svn.wordpress.org/trunk@22084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-29 01:36:14 +00:00
nacin
9d20dfc4e1 Enforce multisite plugins menu preference in map_meta_cap(). This means a simple current_user_can('activate_plugins') check will handle the 'Enable administration menus' setting. 
Remove bogus checks for enabling/disabling the 'themes' menu (something core does not handle out of the box) when in the network admin.

fixes #21123.



git-svn-id: http://core.svn.wordpress.org/trunk@21198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-30 12:40:25 +00:00
ryan
bbb1494919 Use the stylesheet rather than the template to create the network enable theme nonce. Fix network enable redirect following theme installation. Props duck_, nacin. fixes #20916 
git-svn-id: http://core.svn.wordpress.org/trunk@21062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-12 15:31:25 +00:00
nacin
7bac1174bf In multisite, list broken themes on network/themes.php instead of on individual Manage Themes pages. see #20103. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-08 07:32:42 +00:00
nacin
6321f9060c Use wp_get_theme() rather than get_theme_data() in the verify theme deletion (multisite network) screen. see #20103. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-29 07:50:56 +00:00
ryan
616c35e71c One newline is enough. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:10:39 +00:00
ryan
02a1dd7ccb Best practice, use wp_safe_redirect() when dealing with referrers. Props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-10 18:26:48 +00:00
ryan
9d03183e6d Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-08 23:02:33 +00:00
ryan
8ace5a6b4c Use WP_Screen::add_help_tab(). see #19020 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-01 02:22:07 +00:00
nacin
cece838d8f More s/add_help_sidebar/set_help_sidebar/. fixes #19020. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-02 21:32:16 +00:00
ryan
366db8c10b Use add_help_sidebar(). see #19020 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-02 05:33:53 +00:00
nacin
795ca8d394 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-07 04:57:12 +00:00
ryan
435b3a0177 Implement bulk update for network/themes.php. Props ocean90. fixes #18687 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-03 14:35:43 +00:00
azaozz
bbafdfa0e5 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-03 04:00:57 +00:00
azaozz
3575537e5f Add screen_options with contextual content, see #18690 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-02 06:59:36 +00:00
nacin
0fe8ea2f72 Add 'Network Enable' link after installing a theme in the network admin. props PeteMall, fixes #18468. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-18 22:40:37 +00:00
westi
1443193079 Help Tab text updatates. Fixes #17312 prop dougwrites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-01 15:37:04 +00:00
markjaquith
0e57bd3a37 Centralize pagination bound exceeding redirects for list tables. props garyc40. props johnjamesjacoby. fixes #16208 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-12 06:09:42 +00:00
koopersmith
2207bfe689 Admin Header 2: The Return of 32px Icons. Props, iammattthomas. see #17324. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-12 00:22:22 +00:00
ryan
e5ec44416a Remove favorite_actions() from h2s. Restore Add New buttons. see #17324 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-10 19:18:16 +00:00
markjaquith
8d87f5dcb4 Big UI style update. props koopersmith. see #17324 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-04 20:15:05 +00:00
nacin
37075f7f71 Remove AJAX from list tables. first pass. see #16262. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-16 21:47:24 +00:00
markjaquith
8e2683d127 Add "paged param is greater than total pages" redirects to a few more screens. props greuben. fixes #16187 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-13 00:03:38 +00:00
ryan
e7890765b7 Fix post theme delete redirect. Props greuben. see #16117 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-07 19:58:25 +00:00
ryan
9b88439cb6 Fix net admin theme deletion over FTP. see #16117 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-07 19:01:34 +00:00
ryan
5d9061c660 Add context to string. Props nbachiyski. fixes #16130 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-07 16:23:52 +00:00
westi
c0828c77d0 Ensure that we apply the absolute integer casting result to the variable we are going to use. See #16119 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-06 08:51:45 +00:00
nacin
291e6c8038 Remove redundancy in these arguments. props PeteMall, fixes #15920. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-25 13:44:03 +00:00
ryan
625a229313 MS themes fixes. Fix bulk actions when no items selected. Props SergeyBiryukov, nacin. fixes #15920 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-24 17:41:36 +00:00
nacin
79b1cc7492 Remove this check in favor of the one added in [17126]. see #15969. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-23 19:40:32 +00:00
nacin
c7677394b7 bulk-themes nonce for network/themes.php deletion. props PeteMall, see #15969. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-23 18:53:44 +00:00
ryan
7d88a90a22 nonce checks for ms themes. see #15969 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-23 16:20:36 +00:00
ryan
602c7e4762 Check bulk-themes nonce before bulk delete. fixes #15922 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-23 15:56:32 +00:00
ryan
a1d8c65604 Add delete support to network themes. Props PeteMall. fixes #15707 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-21 16:50:16 +00:00
ryan
09a2d27d5e Remove 'Search Results filter from ms themes. fixes #15872 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-19 01:11:38 +00:00
nacin
0f2672e53d Move to what will be the new Network Admin Codex page URLs. see #15314. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-18 18:27:12 +00:00
scribu
cfe09b99e5 Introduce WP_List_Table::search_box(). See #15353 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 20:45:10 +00:00
nacin
cc08068dba Remove check_permissions() calls outside of AJAX context. Also only check for switch_themes in check_permissions() for the themes table. see #15326. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 08:43:22 +00:00
nacin
d0e27b0935 Network Admin contextual help. props andrea_r (!), see #15314. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 06:52:47 +00:00