Andrew Ozz
19dbf7b998
Improve table footer tab sequence by moving <tfoot>
after <tbody>
. Props afercia, rianrietveld, DrewAPicture. Fixes #30914 .
...
Built from https://develop.svn.wordpress.org/trunk@31513
git-svn-id: http://core.svn.wordpress.org/trunk@31494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:48:26 +00:00
Jeremy Felt
678982ee7e
Do not activate plugins on initial installation in multisite.
...
Check `is_multisite()` before activating a plugin that has been installed via AJAX. Without this check, the plugin would be automatically activated on the main site of the network.
Props ianmjones.
Fixes #31327 .
Built from https://develop.svn.wordpress.org/trunk@31511
git-svn-id: http://core.svn.wordpress.org/trunk@31492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:30:25 +00:00
Sergey Biryukov
0231047071
Delegate focusin
and focusout
events for row actions to make sure the actions are always revealed on focus.
...
props afercia.
fixes #29765 .
Built from https://develop.svn.wordpress.org/trunk@31509
git-svn-id: http://core.svn.wordpress.org/trunk@31490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 20:14:25 +00:00
Sergey Biryukov
8eb25609e9
Dashboard: Add a filter for the query arguments used for the Recent Posts widget.
...
props danielbachhuber.
fixes #29374 .
Built from https://develop.svn.wordpress.org/trunk@31508
git-svn-id: http://core.svn.wordpress.org/trunk@31489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:57:24 +00:00
Sergey Biryukov
93e5bb3702
Quick Edit: Make date fields a bit wider.
...
props Ravindra Pal Singh, janhenckens.
fixes #27912 .
Built from https://develop.svn.wordpress.org/trunk@31507
git-svn-id: http://core.svn.wordpress.org/trunk@31488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:24:25 +00:00
Sergey Biryukov
4b21c67738
Remove untranslatable period from a successful update message in Bulk_Upgrader_Skin::add_strings()
.
...
props mako09, DrewAPicture.
fixes #30793 .
Built from https://develop.svn.wordpress.org/trunk@31506
git-svn-id: http://core.svn.wordpress.org/trunk@31487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:07:24 +00:00
Dominik Schilling
2b9a79db8e
Run Autoprefixer after [31504].
...
This removes media queries for Opera < 12 and `-ms-animation`/`@-ms-keyframes` which was never (dev versions excluded) supported by IE.
see #31337 .
Built from https://develop.svn.wordpress.org/trunk@31505
git-svn-id: http://core.svn.wordpress.org/trunk@31486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:00:24 +00:00
Sergey Biryukov
1ab9aa255e
Use correct closing tag for "Under the Hood" header on About screen.
...
props tyxla.
fixes #31402 .
Built from https://develop.svn.wordpress.org/trunk@31503
git-svn-id: http://core.svn.wordpress.org/trunk@31484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 16:44:25 +00:00
Sergey Biryukov
f7df99549a
Themes: Add feedback for screen readers when search results are changed.
...
props obenland, joedolson.
see #26600 .
Built from https://develop.svn.wordpress.org/trunk@31497
git-svn-id: http://core.svn.wordpress.org/trunk@31478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 10:15:26 +00:00
Sergey Biryukov
677d37753f
Themes: Update the theme count when searching for installed themes, like we do on Add Themes screen.
...
props afercia.
see #26600 .
Built from https://develop.svn.wordpress.org/trunk@31495
git-svn-id: http://core.svn.wordpress.org/trunk@31476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 09:41:24 +00:00
Sergey Biryukov
3c64d94ba9
Fix typo in [30760].
...
props afercia.
fixes #31393 .
Built from https://develop.svn.wordpress.org/trunk@31484
git-svn-id: http://core.svn.wordpress.org/trunk@31465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-20 17:09:28 +00:00
Sergey Biryukov
109295cdd4
When creating a new user, pasting a password should update the password strength indicator.
...
props dipesh.kakadiya.
fixes #31226 .
Built from https://develop.svn.wordpress.org/trunk@31483
git-svn-id: http://core.svn.wordpress.org/trunk@31464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-20 13:05:27 +00:00
Dominik Schilling
7bd3ea7da9
grunt autoprefixer
for [31333].
...
see ##29820.
Built from https://develop.svn.wordpress.org/trunk@31465
git-svn-id: http://core.svn.wordpress.org/trunk@31446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-15 12:18:25 +00:00
Sergey Biryukov
19a43125cd
Don't try to read a non-existent Exif:Title tag in wp_read_image_metadata()
, as it's not a part of the Exif standard.
...
props tyxla.
fixes #31043 .
Built from https://develop.svn.wordpress.org/trunk@31462
git-svn-id: http://core.svn.wordpress.org/trunk@31443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-14 09:14:28 +00:00
Sergey Biryukov
fd6448247b
Customizer: Remove margin for hidden controls.
...
props dlh.
fixes #31330 .
Built from https://develop.svn.wordpress.org/trunk@31460
git-svn-id: http://core.svn.wordpress.org/trunk@31441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-14 08:46:27 +00:00
Sergey Biryukov
e2f5a8094e
Avoid a PHP notice in wp_install_language_form()
and wp_dropdown_languages()
if the language doesn't have a ISO 639-1 code.
...
props barrykooij.
fixes #31319 .
Built from https://develop.svn.wordpress.org/trunk@31447
git-svn-id: http://core.svn.wordpress.org/trunk@31428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 11:23:26 +00:00
Sergey Biryukov
7b9d981a54
Use correct default values for some admin template functions.
...
props ipm-frommen.
fixes #31308 .
Built from https://develop.svn.wordpress.org/trunk@31446
git-svn-id: http://core.svn.wordpress.org/trunk@31427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 06:51:25 +00:00
Sergey Biryukov
5a0b01edf1
Rename unused argument and remove obsolete global in iframe_header()
.
...
props ipm-frommen.
fixes #31309 .
Built from https://develop.svn.wordpress.org/trunk@31443
git-svn-id: http://core.svn.wordpress.org/trunk@31424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 05:31:26 +00:00
Sergey Biryukov
268d79cb77
_list_meta_row()
should always return a string.
...
props ipm-frommen.
fixes #31310 .
Built from https://develop.svn.wordpress.org/trunk@31442
git-svn-id: http://core.svn.wordpress.org/trunk@31423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 04:22:26 +00:00
Sergey Biryukov
6fd67ad80e
Correct parameter types for Plugin_Upgrader::bulk_upgrade()
and Theme_Upgrader::bulk_upgrade()
.
...
props ipm-frommen.
fixes #31312 .
Built from https://develop.svn.wordpress.org/trunk@31441
git-svn-id: http://core.svn.wordpress.org/trunk@31422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 04:19:27 +00:00
Sergey Biryukov
43583a1b9e
Terminate JS statements in two admin files.
...
props ipm-frommen.
fixes #31311 .
Built from https://develop.svn.wordpress.org/trunk@31440
git-svn-id: http://core.svn.wordpress.org/trunk@31421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 04:09:27 +00:00
Helen Hou-Sandí
2a1f3c4c1f
Posts list table: Add a filter to disable the months dropdown.
...
It was previously possible to prevent it from displaying by filtering everything out from the results, but if one really doesn't want it, they should be able to short-circuit before the query even runs.
props norcross, SergeyBiryukov.
fixes #30254 .
Built from https://develop.svn.wordpress.org/trunk@31438
git-svn-id: http://core.svn.wordpress.org/trunk@31419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-12 18:38:29 +00:00
Dion Hulse
3cec3655e9
Prevent IE9 and lower displaying the download file dialogue when attempting to upload using the html4
Plupload handler.
...
The HTML4 Plupload handler uses a hidden iframe to POST the upload form,
Unfortunately Internet Explorer 9 doesn't support the `application/json`
content-type which `wp_send_json_success()` and requires `text/html` instead.
This partially reverts [30354], keeping the better error messages.
Fixes #31037 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31429
git-svn-id: http://core.svn.wordpress.org/trunk@31410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-12 01:15:29 +00:00
Dominik Schilling
70ca74b37b
Customizer: Don't focus new widgets if they are added programmatically.
...
props westonruter.
fixes #31295 .
Built from https://develop.svn.wordpress.org/trunk@31428
git-svn-id: http://core.svn.wordpress.org/trunk@31409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 23:32:27 +00:00
Dominik Schilling
4b66a66b20
Escape Customizer links in the admin menu. Fix usage of add_query_arg()
.
...
props iseulde.
fixes #30952 .
Built from https://develop.svn.wordpress.org/trunk@31427
git-svn-id: http://core.svn.wordpress.org/trunk@31408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 22:48:27 +00:00
Dominik Schilling
1a45201b98
Update grunt-cssjanus to 0.2.4, we no longer need the fork.
...
Upstream changes:
* https://github.com/cssjanus/cssjanus/compare/v1.0.2...v1.1.2
* https://github.com/cssjanus/grunt-cssjanus/compare/v0.2.2...v0.2.4
fixes #30997 .
Built from https://develop.svn.wordpress.org/trunk@31425
git-svn-id: http://core.svn.wordpress.org/trunk@31406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 22:28:29 +00:00
Helen Hou-Sandí
b6edb31874
Admin menu: Ensure top level menu item keeps hover color when hovering over or focusing on the submenu.
...
props stevehickeydesign, melchoyce.
fixes #31275 .
Built from https://develop.svn.wordpress.org/trunk@31424
git-svn-id: http://core.svn.wordpress.org/trunk@31405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 22:25:27 +00:00
Helen Hou-Sandí
bcda24004a
Update the default admin color scheme for more unity and refinement.
...
This removes the red channel from blues and cools the grays a bit for a more cohesive and purposeful color scheme.
props hugobaeta.
fixes #31234 .
Built from https://develop.svn.wordpress.org/trunk@31422
git-svn-id: http://core.svn.wordpress.org/trunk@31403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 22:18:26 +00:00
Dominik Schilling
46f98473d1
Widgets: Add return param for widgets admin page to the "Manage in Customizer" link.
...
props tywayne.
fixes #30888 .
Built from https://develop.svn.wordpress.org/trunk@31420
git-svn-id: http://core.svn.wordpress.org/trunk@31401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 20:57:26 +00:00
Dominik Schilling
6adb5c0618
Customizer: Improve [31252] to show the move-widget buttons only if there is more than one *rendered* sidebar.
...
fixes #30690 .
Built from https://develop.svn.wordpress.org/trunk@31419
git-svn-id: http://core.svn.wordpress.org/trunk@31400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 20:45:26 +00:00
Gary Pendergast
daf711a338
Shiny Updates: Replace $.post()
calls with wp.ajax.post()
, and clean up a bunch of the now unnecessary code.
...
See #29820
Built from https://develop.svn.wordpress.org/trunk@31409
git-svn-id: http://core.svn.wordpress.org/trunk@31390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 05:06:28 +00:00
Scott Taylor
6cb16f7a21
Remove unused media JS files.
...
See #28510 .
Built from https://develop.svn.wordpress.org/trunk@31405
git-svn-id: http://core.svn.wordpress.org/trunk@31386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 22:45:28 +00:00
Sergey Biryukov
0e65ae6176
Remove redundant string with a typo introduced in [25481].
...
see #31217 .
Built from https://develop.svn.wordpress.org/trunk@31404
git-svn-id: http://core.svn.wordpress.org/trunk@31385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 07:53:28 +00:00
Sergey Biryukov
12f4004989
Replace generic "Dear user" greeting in email notifications with a more personalized one.
...
props Ipstenu.
fixes #31217 .
Built from https://develop.svn.wordpress.org/trunk@31403
git-svn-id: http://core.svn.wordpress.org/trunk@31384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 07:47:27 +00:00
Sergey Biryukov
f166a51809
Update body class when switching between admin color schemes.
...
props valendesigns.
fixes #30488 .
Built from https://develop.svn.wordpress.org/trunk@31400
git-svn-id: http://core.svn.wordpress.org/trunk@31381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-10 02:23:28 +00:00
Boone Gorges
72f18cb067
Don't parse empty 'tax_input' keys in edit_post()
.
...
This fixes a bug introduced in [31359] where saving a tax_input that contained
only whitespace would result in a random tag being erroneously added to the
post.
See #30615 .
Built from https://develop.svn.wordpress.org/trunk@31392
git-svn-id: http://core.svn.wordpress.org/trunk@31373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 22:54:28 +00:00
Dominik Schilling
941075c8ca
Improve the Customize experience on mobile.
...
Before: https://make.wordpress.org/flow/2015/02/02/a-peek-at-the-customizer-on-an-iphone-6/
After: https://make.wordpress.org/flow/2015/02/03/vizrec-for-28784-improve-the-customize-experience-on-mobile-iphone-6-28784-diff-4-2-alpha-31325/
props celloexpressions.
see #28784 .
Built from https://develop.svn.wordpress.org/trunk@31384
git-svn-id: http://core.svn.wordpress.org/trunk@31365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 12:36:28 +00:00
Dion Hulse
502515974c
Updates: Display plugin update rows even for plugins which are not hosted by WordPress.org or the HTTP request times out on.
...
See #29583 .
Fixes #30767 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31382
git-svn-id: http://core.svn.wordpress.org/trunk@31363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-09 06:32:26 +00:00
Sergey Biryukov
623981c8d6
Use a positive wording for translations update notice.
...
props DrewAPicture, siobhan, netweb.
fixes #28199 .
Built from https://develop.svn.wordpress.org/trunk@31368
git-svn-id: http://core.svn.wordpress.org/trunk@31349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-08 04:09:22 +00:00
Sergey Biryukov
137204b033
In _wp_menu_output()
, $submenu_items
is an array and should be initialized as such.
...
props ipm-frommen.
fixes #31257 .
Built from https://develop.svn.wordpress.org/trunk@31364
git-svn-id: http://core.svn.wordpress.org/trunk@31345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-07 17:57:24 +00:00
Sergey Biryukov
1e0905793c
Avoid inadvertent stomping of the original $args
parameter passed to plugins_api_result
and themes_api_result
filters in plugins_api()
and themes_api()
, respectively.
...
Fixes a regression introduced in [25956].
props Corphi, obenland.
fixes #29079 .
Built from https://develop.svn.wordpress.org/trunk@31363
git-svn-id: http://core.svn.wordpress.org/trunk@31344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-07 06:21:22 +00:00
Andrew Ozz
c765424ad5
Editor: prevent errors in editor-expand when the Text editor is not used. Props iseulde, fixes #31163 .
...
Built from https://develop.svn.wordpress.org/trunk@31361
git-svn-id: http://core.svn.wordpress.org/trunk@31342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 22:25:23 +00:00
Boone Gorges
b9e661dcae
Parse non-hierarchical tag input into term IDs before sending to wp_insert_post()
.
...
When editing a post, non-hierarchical taxonomy terms are sent as the
comma-separated list entered into the tax_input metabox. Passing these
values directly to `wp_update_post()` meant that they were interpreted as
term slugs rather than term names, causing mismatches when a typed string
matched the slug of one term and the name of a different term. We fix the
problem by preprocessing tax_input data sent from post.php, converting it to
unambiguous term_ids before saving.
Props boonebgorges, ArminBraun.
Fixes #30615 .
Built from https://develop.svn.wordpress.org/trunk@31359
git-svn-id: http://core.svn.wordpress.org/trunk@31340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 20:32:22 +00:00
Gary Pendergast
d7c6ac95bc
Upgrades: wp_usermeta is a global table in multisite, so it should only be upgraded by the single site routines when we're not in a multisite install.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@31358
git-svn-id: http://core.svn.wordpress.org/trunk@31339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 13:41:22 +00:00
Gary Pendergast
7444799a82
Upgrades: When upgrading a table to utf8mb4, we should run the ALTER TABLE
query, even if it doesn't have any text columns. This will update the table's default character set, so that any text columns added in the future will have the expected character set.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@31354
git-svn-id: http://core.svn.wordpress.org/trunk@31335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:59:23 +00:00
Gary Pendergast
555a9f0912
Upgrades: When deciding if we can upgrade a table to utf8mb4, make sure we're checking the character set, not the collation.
...
Bump the DB version as well, as the update in [31349] wouldn't have triggered for anyone who tried it.
See #21212
Built from https://develop.svn.wordpress.org/trunk@31351
git-svn-id: http://core.svn.wordpress.org/trunk@31332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 05:26:21 +00:00
Gary Pendergast
b2cf823105
WPDB: If a site is using the utf8
charset, and their version of MySQL supports utf8mb4
, auto-upgrade them to utf8mb4
.
...
This patch also resizes some indexes, to allow for the 767 byte index size limit in standard MySQL installs.
See #21212
Built from https://develop.svn.wordpress.org/trunk@31349
git-svn-id: http://core.svn.wordpress.org/trunk@31330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 04:51:22 +00:00
Gary Pendergast
5e4d135411
Shiny Updates: Fix a PHP warning when installing new plugins.
...
Props lgladdy for the initial patch.
See #29820
Built from https://develop.svn.wordpress.org/trunk@31345
git-svn-id: http://core.svn.wordpress.org/trunk@31326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-06 00:34:21 +00:00
Boone Gorges
69504de9d8
jshint fixes for shiny updates JS.
...
As introduced in [31333].
Props iseulde.
See #29820 .
Built from https://develop.svn.wordpress.org/trunk@31341
git-svn-id: http://core.svn.wordpress.org/trunk@31322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 19:52:22 +00:00
Gary Pendergast
27aa3e92d7
Shiny Updates: If the current user is not allowed to install/update plugins, we should return a JSON error, so it can be used by the JS handlers.
...
See #29820
Built from https://develop.svn.wordpress.org/trunk@31335
git-svn-id: http://core.svn.wordpress.org/trunk@31316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 06:16:23 +00:00
Gary Pendergast
b7926a518a
Shiny Updates: Add capability checks to the ajax callbacks, to ensure the current user is allowed to install/update plugins.
...
See #29820
Built from https://develop.svn.wordpress.org/trunk@31334
git-svn-id: http://core.svn.wordpress.org/trunk@31315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 06:05:22 +00:00
Gary Pendergast
9c69213f2b
Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
...
This also includes JS architecture that can be expanded to support theme, core and language pack updates.
Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture
See #29820
Built from https://develop.svn.wordpress.org/trunk@31333
git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 04:19:23 +00:00
Andrew Ozz
f13cb317a4
Fix displaying long tag names in the Tags postbox. Props trishasalas, carolinegeven, iseulde. Fixes #18946 .
...
Built from https://develop.svn.wordpress.org/trunk@31332
git-svn-id: http://core.svn.wordpress.org/trunk@31313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-04 22:15:25 +00:00
Helen Hou-Sandí
62e65c3a35
Accessibility: remove remaining instances of accesskey.
...
It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve.
props afercia.
fixes #29715 .
Built from https://develop.svn.wordpress.org/trunk@31331
git-svn-id: http://core.svn.wordpress.org/trunk@31312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-04 03:46:24 +00:00
Helen Hou-Sandí
641f767fd9
Themes: Allow version number in the overlay to be selected.
...
props johneckman.
fixes #31205 .
Built from https://develop.svn.wordpress.org/trunk@31330
git-svn-id: http://core.svn.wordpress.org/trunk@31311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 15:15:25 +00:00
Dion Hulse
121f83ab39
Remove an extra indent from most of media-new.php.
...
Built from https://develop.svn.wordpress.org/trunk@31328
git-svn-id: http://core.svn.wordpress.org/trunk@31309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 07:47:22 +00:00
Dion Hulse
e8f032c747
WP_Upgrader: Remove references to non-existant variables that have never existed.
...
Props jdgrimes. Fixes #29087
Built from https://develop.svn.wordpress.org/trunk@31327
git-svn-id: http://core.svn.wordpress.org/trunk@31308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 06:18:24 +00:00
Dion Hulse
92cb5936f1
Remove an unused parameter on install_plugins_upload().
...
Props michalzuber. Fixes #28964
Built from https://develop.svn.wordpress.org/trunk@31326
git-svn-id: http://core.svn.wordpress.org/trunk@31307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 06:14:22 +00:00
Boone Gorges
eec82f9330
In get_sample_permalink()
, override 'future' status before generating permalink.
...
In [31114], `get_permalink()` was modified to prevent pretty permalinks from
being generated for posts with the 'future' post status. This inadvertently
broke the pretty permalink preview for scheduled posts. The fix is to include
the 'future' status in the list of statuses that `get_sample_permalink()` fakes
as 'publish' before it fetches a permalink.
Props DrewAPicture.
Fixes #30910 .
Built from https://develop.svn.wordpress.org/trunk@31323
git-svn-id: http://core.svn.wordpress.org/trunk@31304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-02 16:50:22 +00:00
Sergey Biryukov
a82763b7b6
Menus: Don't display "Move" text without direction if there is only one menu item.
...
props kucrut for initial patch.
fixes #30765 .
Built from https://develop.svn.wordpress.org/trunk@31320
git-svn-id: http://core.svn.wordpress.org/trunk@31301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-01 05:29:26 +00:00
Sergey Biryukov
f824de609d
Reduce the size of the WordPress logo tap target on log in screen on mobile, to avoid unexpected redirect away from the form.
...
props mzak.
fixes #31185 .
Built from https://develop.svn.wordpress.org/trunk@31318
git-svn-id: http://core.svn.wordpress.org/trunk@31299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 21:32:22 +00:00
Sergey Biryukov
7d99c51b3b
Themes: Remove a Chrome workaround that causes theme screenshots to look too crisp and no longer appears to be relevant.
...
props mzak.
fixes #26584 .
Built from https://develop.svn.wordpress.org/trunk@31316
git-svn-id: http://core.svn.wordpress.org/trunk@31297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 20:39:25 +00:00
Boone Gorges
f345a72c58
Prevent terms in a show_in_quick_edit=false taxonomy from being updated by a faked AJAX request.
...
The UI for these taxonomies was hidden in [31308], but it remained possible to
send a direct POST request to the `inline-edit` endpoint to bypass the
restriction. The current changeset fixes this.
Props meloniq.
Fixes #26948 .
Built from https://develop.svn.wordpress.org/trunk@31313
git-svn-id: http://core.svn.wordpress.org/trunk@31294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-31 19:38:24 +00:00
Boone Gorges
e4f8d5e0bc
Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases.
...
See #26948 .
Built from https://develop.svn.wordpress.org/trunk@31308
git-svn-id: http://core.svn.wordpress.org/trunk@31289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 19:29:22 +00:00
Boone Gorges
abce542e5f
Introduce 'show_in_quick_edit' parameter for register_taxonomy()
.
...
Setting 'show_in_quick_edit' to false when registering a custom taxonomy will
hide the taxonomy when editing posts using Quick Edit.
The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered
on a finer scale, as when you want a given taxonomy to be hidden for one post
type but not for others.
Props hlashbrooke.
Fixes #26948 .
Built from https://develop.svn.wordpress.org/trunk@31307
git-svn-id: http://core.svn.wordpress.org/trunk@31288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 19:18:23 +00:00
Sergey Biryukov
b05014805f
Don't display the Help tab reference in Page Attributes meta box if Help tab was removed.
...
props bananastalktome.
fixes #31164 .
Built from https://develop.svn.wordpress.org/trunk@31303
git-svn-id: http://core.svn.wordpress.org/trunk@31284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-30 15:34:24 +00:00
Sergey Biryukov
5ac0568ee3
Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
...
props tomdxw.
fixes #30927 .
Built from https://develop.svn.wordpress.org/trunk@31300
git-svn-id: http://core.svn.wordpress.org/trunk@31281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 21:15:22 +00:00
Dominik Schilling
72229b25c8
Add New User: Remove trailing whitespace from button labels.
...
fixes #31175 .
Built from https://develop.svn.wordpress.org/trunk@31298
git-svn-id: http://core.svn.wordpress.org/trunk@31279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 14:54:21 +00:00
Drew Jaynes
de1f0a0487
Avoid confusion by clarifying an inline comment on logic for performing multisite upgrades.
...
Props dmchale for the initial patch.
Fixes #30837 .
Built from https://develop.svn.wordpress.org/trunk@31297
git-svn-id: http://core.svn.wordpress.org/trunk@31278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:53:21 +00:00
Drew Jaynes
0f20ecca9c
Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/taxonomy.php.
...
Also adds a few missing parameter descriptions.
Props ipm-frommen.
See #31008 .
Built from https://develop.svn.wordpress.org/trunk@31293
git-svn-id: http://core.svn.wordpress.org/trunk@31274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:34:22 +00:00
Drew Jaynes
f3033f34c6
Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/post.php
...
Props ipm-frommen.
See #31008 .
Built from https://develop.svn.wordpress.org/trunk@31292
git-svn-id: http://core.svn.wordpress.org/trunk@31273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 11:32:22 +00:00
Boone Gorges
8627216105
When updating the name a hierarchical term with Quick Edit, update the corresponding option in the Parent dropdown.
...
Props garyc40, rmarks.
Fixes #14565 .
Built from https://develop.svn.wordpress.org/trunk@31288
git-svn-id: http://core.svn.wordpress.org/trunk@31269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 01:53:22 +00:00
Sergey Biryukov
5aadff88f6
Remove duplicate label on installation screen.
...
props Ankit K Gupta.
fixes #31131 .
Built from https://develop.svn.wordpress.org/trunk@31282
git-svn-id: http://core.svn.wordpress.org/trunk@31263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 19:39:23 +00:00
Sergey Biryukov
98da858b40
Revert [30027]. These fields are already sufficiently labeled; duplicate labels can lead to confused behavior for screen readers.
...
see #31117 , #30101 .
Built from https://develop.svn.wordpress.org/trunk@31281
git-svn-id: http://core.svn.wordpress.org/trunk@31262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-25 18:33:22 +00:00
Sergey Biryukov
15fc97b1cf
Quick Edit: Don't save the post if Enter is pressed on the Cancel link.
...
props afercia.
fixes #30345 .
Built from https://develop.svn.wordpress.org/trunk@31274
git-svn-id: http://core.svn.wordpress.org/trunk@31255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-24 15:07:22 +00:00
Aaron Jorbin
a4a1273d3a
Improve accessibility of nav menu locations form.
...
A couple of small tweaks to the nav menu locations form that make it friendlier to assistive technology. These include:
* labels for selects
* better context for the "Edit" link. We hide "edit" from screen readers and instead give them a phrase with context since they may not be able to take advantage of the visual context
Additionally, there are some minor css tweaks to improve the visual alignment of the rows.
We also remove duplicate IDs and use classes instead.
Props afercia.
fixes #31090 .
Built from https://develop.svn.wordpress.org/trunk@31272
git-svn-id: http://core.svn.wordpress.org/trunk@31253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-23 18:18:26 +00:00
Dominik Schilling
b4bb289b5d
Customizer: Hide the reorder-widgets button when a widget area is empty.
...
props celloexpressions.
fixes #27787 .
Built from https://develop.svn.wordpress.org/trunk@31255
git-svn-id: http://core.svn.wordpress.org/trunk@31236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 22:45:22 +00:00
Dominik Schilling
0c0675627b
Customizer: If there's only one available sidebar, hide the move-widget button.
...
props celloexpressions.
fixes #30690 .
Built from https://develop.svn.wordpress.org/trunk@31252
git-svn-id: http://core.svn.wordpress.org/trunk@31233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 20:36:21 +00:00
Sergey Biryukov
067ee8c476
Remove inaccurate part of {$taxonomy}_add_form_fields action description.
...
props joostdekeijzer.
fixes #31052 .
Built from https://develop.svn.wordpress.org/trunk@31247
git-svn-id: http://core.svn.wordpress.org/trunk@31228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 15:31:23 +00:00
Drew Jaynes
d95586e943
Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php.
...
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.
Props morganestes.
Fixes #30825 .
Built from https://develop.svn.wordpress.org/trunk@31246
git-svn-id: http://core.svn.wordpress.org/trunk@31227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 09:15:22 +00:00
Drew Jaynes
d41e669efe
Ensure the correct list of default tabs for the Plugin Install screen are documented.
...
Props stevenkword.
Fixes #31017 .
Built from https://develop.svn.wordpress.org/trunk@31244
git-svn-id: http://core.svn.wordpress.org/trunk@31225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-19 08:44:22 +00:00
Sergey Biryukov
eedb4857ba
Strip HTML tags when searching for installed themes.
...
props enej, SergeyBiryukov, obenland.
fixes #27561 .
Built from https://develop.svn.wordpress.org/trunk@31240
git-svn-id: http://core.svn.wordpress.org/trunk@31221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-18 20:40:23 +00:00
Sergey Biryukov
8b50aef14c
Customizer: Make "Search widgets" input sticky.
...
props celloexpressions.
fixes #30751 .
Built from https://develop.svn.wordpress.org/trunk@31227
git-svn-id: http://core.svn.wordpress.org/trunk@31208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 13:15:23 +00:00
Sergey Biryukov
768624cb99
Use the site's local time to create the first post during installation.
...
props extendwings.
fixes #29296 .
Built from https://develop.svn.wordpress.org/trunk@31225
git-svn-id: http://core.svn.wordpress.org/trunk@31206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 10:07:23 +00:00
Scott Taylor
02a1f35ac8
Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:
...
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`.
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31220
git-svn-id: http://core.svn.wordpress.org/trunk@31201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 22:51:21 +00:00
Scott Taylor
eeda68bbda
Fix some erroneous @param
annotations.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31219
git-svn-id: http://core.svn.wordpress.org/trunk@31200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 22:44:25 +00:00
Scott Taylor
0f6d0b84d1
Remove unused local vars in delete_plugins()
, delete_theme()
, WP_Date_Query->validate_date_values()
, global_terms()
, and WP_Text_Diff_Renderer_Table->_changed()
.
...
This will clear out the "Unused Code" label in the next Scrutinizer report.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31217
git-svn-id: http://core.svn.wordpress.org/trunk@31198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:19:22 +00:00
Scott Taylor
7c5038feb6
Calling ->chown()
and ->chgrp()
in WP_Filesystem_ftpsockets
produces no side-effects. Remove the calls. ->chgrp()
is defined in the super class, and does nothing, can be removed from the child class.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31216
git-svn-id: http://core.svn.wordpress.org/trunk@31197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:10:23 +00:00
Scott Taylor
6fa7021d62
Calling ->chown()
and ->chgrp()
in WP_Filesystem_FTPext
produces no side-effects. Remove the calls. ->chgrp()
is defined in the super class, and does nothing, can be removed from the child class.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31215
git-svn-id: http://core.svn.wordpress.org/trunk@31196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 21:07:24 +00:00
Scott Taylor
b8dd1f9c69
By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors.
...
There are plenty of other kinds of errors, but this label will be cleared out.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31213
git-svn-id: http://core.svn.wordpress.org/trunk@31194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 19:13:23 +00:00
Scott Taylor
bc55996a0b
@param
cleanup:
...
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31212
git-svn-id: http://core.svn.wordpress.org/trunk@31193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 19:03:23 +00:00
Scott Taylor
cde4c83091
[31210] broke Supportflow on dotorg, which declares these methods as protected
. Switch to protected
for the noop methods. The subclasses can make them more visible using public
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31211
git-svn-id: http://core.svn.wordpress.org/trunk@31192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 18:37:24 +00:00
Scott Taylor
3fb283db0a
Add 2 noop methods to WP_List_Table
: ->column_default()
and ->column_cb()
.
...
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.
These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31210
git-svn-id: http://core.svn.wordpress.org/trunk@31191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:42:22 +00:00
Scott Taylor
895794f74d
In WP_Filesystem_Base
subclasses that set $wp_base
, remove this dead code.
...
Unused since [8009] - "Make WP_Filesystem work with new directory constants"
There is currently no declared field and no `@property` annotation.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31209
git-svn-id: http://core.svn.wordpress.org/trunk@31190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:23:22 +00:00
Scott Taylor
b29a20b90a
WP_Filesystem_Base
should declare $errors
and $options
as fields for use by subclasses.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31208
git-svn-id: http://core.svn.wordpress.org/trunk@31189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 17:10:43 +00:00
Scott Taylor
60c285aa22
In wp_ajax_parse_media_shortcode()
, don't require a global $post
for all passed shortcodes.
...
`embed` is the only shortcode that requires a post ID. This will allow MCE views to work for `playlist`, `audio`, and `video` outside of the Edit Post screen.
See #30835 .
Built from https://develop.svn.wordpress.org/trunk@31201
git-svn-id: http://core.svn.wordpress.org/trunk@31182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 05:19:22 +00:00
Scott Taylor
7f8b548df1
In HTML5, the action
attribute is no longer required. Remove this attribute when empty.
...
The admin HTML is served with the HTML5 doctype.
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action
Props voldemortensen.
Fixes #30126 .
Built from https://develop.svn.wordpress.org/trunk@31200
git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 04:16:24 +00:00
Scott Taylor
fe6b5983df
In PHP 5.0.0, is_a()
became deprecated in favour of the instanceof
operator. Calling is_a()
would result in an E_STRICT
warning.
...
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.
To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.
`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.
Props markoheijnen, wonderboymusic.
Fixes #25672 .
Built from https://develop.svn.wordpress.org/trunk@31188
git-svn-id: http://core.svn.wordpress.org/trunk@31169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 01:06:24 +00:00
Scott Taylor
6704875855
Replace the 3 remaining occurrences of wpspin
GIF with spinner
.
...
Props avryl.
Fixes #27482 .
Built from https://develop.svn.wordpress.org/trunk@31187
git-svn-id: http://core.svn.wordpress.org/trunk@31168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 00:33:22 +00:00
Scott Taylor
6b84df3bbd
Ensure that <figcaption>
is not autop'd.
...
Fixes #29219 .
Built from https://develop.svn.wordpress.org/trunk@31186
git-svn-id: http://core.svn.wordpress.org/trunk@31167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 00:27:21 +00:00
Helen Hou-Sandí
62a197d6bf
List tables: Use CSS :nth-child() selectors for zebra striping.
...
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.
There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.
fixes #30981 and #26060 . see #25060 .
Built from https://develop.svn.wordpress.org/trunk@31181
git-svn-id: http://core.svn.wordpress.org/trunk@31162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-14 22:14:22 +00:00
Sergey Biryukov
19e51601ab
Revert [31173] and target only taxonomy and link manager tables in keyboard focus code.
...
props afercia.
fixes #30980 .
Built from https://develop.svn.wordpress.org/trunk@31177
git-svn-id: http://core.svn.wordpress.org/trunk@31158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 14:01:22 +00:00
Sergey Biryukov
3ac60370b8
Reveal row actions on focus on taxonomy screens.
...
props afercia.
fixes #30980 .
Built from https://develop.svn.wordpress.org/trunk@31173
git-svn-id: http://core.svn.wordpress.org/trunk@31154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 07:02:22 +00:00
Drew Jaynes
f2bc30c03f
Ensure we're using the correct @ignore
phpDocumentor tag to mark elements that should be skipped when parsing.
...
Up to this point, various core elements' DocBlocks incorrectly included an `@internal` tag as a means for skipping the parsing process. When paired with a description (inline or otherwise), `@internal` is a valid tag meant to provide internal-only context, but not necessarily to skip parsing the entire element.
See #30987 .
Built from https://develop.svn.wordpress.org/trunk@31170
git-svn-id: http://core.svn.wordpress.org/trunk@31151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 00:51:21 +00:00
Scott Taylor
b51593763a
WP_Themes_List_Table
accesses $_pagination_args
from the parent class. Switch $_pagination_args
to protected
in WP_List_Table
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31167
git-svn-id: http://core.svn.wordpress.org/trunk@31148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:26:21 +00:00
Scott Taylor
4f6de09a5b
Add a private
field to WP_Terms_List_Table
, $level
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31166
git-svn-id: http://core.svn.wordpress.org/trunk@31147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:23:22 +00:00
Scott Taylor
194932fd6b
Add a private
field to WP_Posts_List_Table
, $is_trash
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31165
git-svn-id: http://core.svn.wordpress.org/trunk@31146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:22:22 +00:00
Scott Taylor
71f9bc3f42
Add a private
field to WP_Plugin_Install_List_Table
, $error
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31164
git-svn-id: http://core.svn.wordpress.org/trunk@31145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:19:22 +00:00
Scott Taylor
91312e71cd
In lieu of refactoring, add a private
field to WP_MS_Themes_List_Table
, $has_items
. Ideally, this class would overload ->has_items()
and not set a private
field.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31163
git-svn-id: http://core.svn.wordpress.org/trunk@31144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:17:22 +00:00
Scott Taylor
86c0f63739
Add 2 private
fields to WP_Media_List_Table
, $detached
and $is_trash
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31162
git-svn-id: http://core.svn.wordpress.org/trunk@31143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:08:21 +00:00
Scott Taylor
df09597a65
After [31146], properly declare $user_can
as a private
field in WP_Comments_List_Table
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31161
git-svn-id: http://core.svn.wordpress.org/trunk@31142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:02:24 +00:00
Dion Hulse
af92025162
More concise documentation for wp_install_maybe_enable_pretty_permalinks()
...
See #6481 . Props ericlewis.
Built from https://develop.svn.wordpress.org/trunk@31160
git-svn-id: http://core.svn.wordpress.org/trunk@31141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 04:33:23 +00:00
Dion Hulse
a114d0929b
The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable.
...
See #6481 . Props nacin, valendesigns
Built from https://develop.svn.wordpress.org/trunk@31159
git-svn-id: http://core.svn.wordpress.org/trunk@31140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 04:31:23 +00:00
Jeremy Felt
40bcb404a3
Update home
and siteurl
after path slashes are validated in update_blog_details()
...
When editing a site, if `home` and `siteurl` are checked to be updated along with a site's domain and path, they should receive the results of any modifications in `update_blog_details()` rather than trusting the POST data.
Previously, it was possible to save a value without a leading slash on the path, causing an invalid URL to be stored.
Props earnjam.
Fixes #30417 .
Built from https://develop.svn.wordpress.org/trunk@31156
git-svn-id: http://core.svn.wordpress.org/trunk@31137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 01:57:23 +00:00
Scott Taylor
e6fc90f973
In WP_List_Table
, only call magic method internals again whitelists of properties and methods, $compat_fields
and $compat_methods
.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31146
git-svn-id: http://core.svn.wordpress.org/trunk@31127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:20:22 +00:00
Scott Taylor
2749e46178
In WP_Filesystem_Base
, make the only private
member, $cache
, public
and remove magic methods. $cache
was always public
until [28487], has been essentially public
via a magic method since.
...
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31145
git-svn-id: http://core.svn.wordpress.org/trunk@31126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 22:04:22 +00:00
Boone Gorges
5c0ddb8602
Default $parent
in category_exists()
should default to null rather than 0.
...
[29863] made the corresponding change in `term_exists()`. Failure to change the
default value in `category_exists()` meant that an unspecified value for
`$parent` would limit results to top-level categories.
Includes unit tests and corrected function documentation.
Props hissy.
Fixes #30975 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31140
git-svn-id: http://core.svn.wordpress.org/trunk@31121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-11 01:26:27 +00:00
Scott Taylor
a56d920454
In Custom_Image_Header
:
...
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` values
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 4 properties marked `private`: `$uploaded_headers`, `$default_headers`, `$page`, and `$updated` - `$page` and `$uploaded_headers` are never used and `$updated` was added by me in [30187] during 4.1. `$default_headers` does not necessarily need to be `private`
Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the `$uploaded_headers` property - it is used nowhere and is dead code.
Set `$default_headers` to `public`.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31134
git-svn-id: http://core.svn.wordpress.org/trunk@31115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 22:11:22 +00:00
Scott Taylor
61f5cc459e
In Custom_Background
:
...
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` value
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 2 properties marked `private`, `$page` and `$updated` - `$page` is never used and `$updated` was added by me in [30186] during 4.1
Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.
See #30891 .
Built from https://develop.svn.wordpress.org/trunk@31133
git-svn-id: http://core.svn.wordpress.org/trunk@31114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:59:22 +00:00
Scott Taylor
56d6682461
In edit-form-advanced.php
:
...
* `get_permalink( $post_ID )` can return `false`, set it to a variable and check it
* Using the variable allows us to replace 11 separate calls to `get_permalink( $post_ID )` in the file
* These notices were triggered by the potential for `false` to be passed to `esc_url()`
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31131
git-svn-id: http://core.svn.wordpress.org/trunk@31112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:21:22 +00:00
Scott Taylor
a6d6ba957b
get_header_image()
can return false
. In Custom_Image_Header->step_1()
, check the value before setting the background-image
portion of the style
attribute. Setting the the URL to empty string will cause the current request to be set as the source of the background image.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31130
git-svn-id: http://core.svn.wordpress.org/trunk@31111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 21:08:22 +00:00
Scott Taylor
aaae4e9df0
Since get_theme_mod()
returns false
on failure, $background_image_thumb
can be set to it and checked instead of calling get_background_image()
3 times in Custom_Background->admin_page()
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31129
git-svn-id: http://core.svn.wordpress.org/trunk@31110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 20:44:22 +00:00
Scott Taylor
2b6b7c0235
Declare $action
as a global in wp-admin/comment.php
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31128
git-svn-id: http://core.svn.wordpress.org/trunk@31109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 20:42:24 +00:00
Scott Taylor
5547115dc2
Fix some @param
docs that have chars too close them.
...
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31127
git-svn-id: http://core.svn.wordpress.org/trunk@31108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:57:22 +00:00
Scott Taylor
0a511680f4
Adding a @return
annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31126
git-svn-id: http://core.svn.wordpress.org/trunk@31107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:54:23 +00:00
Scott Taylor
da99d29a59
Adding a @return
annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31125
git-svn-id: http://core.svn.wordpress.org/trunk@31106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 06:13:22 +00:00
Scott Taylor
1b3f91f500
Declare $wp_version
, $required_php_version
, and $required_mysql_version
as globals in install and upgrade admin files.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31124
git-svn-id: http://core.svn.wordpress.org/trunk@31105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:57:22 +00:00
Scott Taylor
1bac6fb886
In wp-admin/includes/revision.php
, $post->modified
is a coding error. It should be $post->post_modified
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31123
git-svn-id: http://core.svn.wordpress.org/trunk@31104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:50:22 +00:00
Scott Taylor
d6ce5dd553
WP_Upgrader
will take any "skin" that is passed to it, and set ->skin
via composition. The default type of ->skin
is WP_Upgrader_Skin
, which doesn't have methods declared for ->bulk_header()
and ->bulk_footer()
. Add noop methods to WP_Upgrader_Skin
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31122
git-svn-id: http://core.svn.wordpress.org/trunk@31103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:42:22 +00:00
Scott Taylor
84867b3e9c
Admin globals:
...
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and `$post` as globals where applicable
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31121
git-svn-id: http://core.svn.wordpress.org/trunk@31102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 05:29:22 +00:00
Scott Taylor
afd09f1f04
In wp_ajax_upload_attachment()
, wp_check_filetype_and_ext()
doesn't need a 3rd param - it already defaults to null
. Passing false
would fail a strict check
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31119
git-svn-id: http://core.svn.wordpress.org/trunk@31100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 04:55:25 +00:00
Andrew Ozz
3324fb71f6
TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961 .
...
Built from https://develop.svn.wordpress.org/trunk@31118
git-svn-id: http://core.svn.wordpress.org/trunk@31099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-10 01:32:26 +00:00
Scott Taylor
709698a579
In Custom_Background
and Custom_Header
:
...
* In `->init()`, don't check `current_user_can()` since `add_theme_page()` will return `false` immediately if the cap check fails.
* Bail if `add_theme_page()` returns `false`
* `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already defaults to `null`. Passing `false` would fail a strict check.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31116
git-svn-id: http://core.svn.wordpress.org/trunk@31097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 21:07:22 +00:00
Sergey Biryukov
7b04e6d4f4
Add variable type for sync_category_tag_slugs() parameters.
...
props tillkruess.
fixes #30718 .
Built from https://develop.svn.wordpress.org/trunk@31113
git-svn-id: http://core.svn.wordpress.org/trunk@31094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 11:19:22 +00:00
Sergey Biryukov
e214fce67f
Use localized format for Last Updated date in plugin details modal, for consistency with [31055].
...
see #30717 .
Built from https://develop.svn.wordpress.org/trunk@31110
git-svn-id: http://core.svn.wordpress.org/trunk@31091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 06:21:22 +00:00
Sergey Biryukov
d5d0b367ab
Improve documentation for media_handle_upload().
...
props ericlewis.
fixes #30962 .
Built from https://develop.svn.wordpress.org/trunk@31109
git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 05:05:23 +00:00
Scott Taylor
8ee598169f
After [31105], don't ditch the isset()
calls for BC. Declare $page_hook
as null
so it is initialized for all execution paths but will still fail isset()
checks.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31106
git-svn-id: http://core.svn.wordpress.org/trunk@31087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:52:22 +00:00
Scott Taylor
60e1dd409b
Properly declare $hook_suffix
, $plugin_page
, $typenow
, and $taxnow
as globals in wp-admin/admin.php
.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31105
git-svn-id: http://core.svn.wordpress.org/trunk@31086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:15:24 +00:00
Scott Taylor
e4b6265c7a
Overriding methods should do more than simply call the same method in the super class.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31101
git-svn-id: http://core.svn.wordpress.org/trunk@31082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:20:22 +00:00
Scott Taylor
4a1ad9acec
Jump statements should not be followed by other statements (there were 5 lingering).
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31100
git-svn-id: http://core.svn.wordpress.org/trunk@31081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:15:22 +00:00
Scott Taylor
4feecb922c
Use &&
instead of and
in the 3 places where and
was used.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31099
git-svn-id: http://core.svn.wordpress.org/trunk@31080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 21:12:22 +00:00
Helen Hou-Sandí
bc7cc3bb12
Collapse additional avatar settings if avatars are disabled.
...
props markjaquith, krogsgard, valendesigns.
fixes #30168 .
Built from https://develop.svn.wordpress.org/trunk@31095
git-svn-id: http://core.svn.wordpress.org/trunk@31076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 17:01:24 +00:00
Scott Taylor
383a5c6c24
In wp-includes/plugin.php
, collapse 3 else-newline-tab-if
statements.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31091
git-svn-id: http://core.svn.wordpress.org/trunk@31072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:13:24 +00:00
Scott Taylor
60b0cd7943
The keyword elseif
should be used instead of else if
so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31090
git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Dion Hulse
a4ed093250
Enable Pretty Permalinks for new sites during install if the server supports it.
...
See #6481 , Props valendesigns, DrewAPicture & ericlewis
Built from https://develop.svn.wordpress.org/trunk@31089
git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 06:47:23 +00:00
Scott Taylor
ac4e67b82e
Perl-style comments should not be used
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31079
git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:52:24 +00:00
Scott Taylor
e029005847
Access Modifiers:
...
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31078
git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:44:23 +00:00
Scott Taylor
ff98cfcf45
Pinking Shears.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31077
git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 05:03:23 +00:00
Sergey Biryukov
9b0e279e82
In dashboard activity widget, display a front-end link if the user cannot edit the post.
...
props UaMV, DrewAPicture.
fixes #29025 .
Built from https://develop.svn.wordpress.org/trunk@31075
git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 00:26:22 +00:00
Sergey Biryukov
f2b5ac8ef1
Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices.
...
props ocean90.
fixes #30827 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31074
git-svn-id: http://core.svn.wordpress.org/trunk@31055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:43:24 +00:00
Sergey Biryukov
f601e45055
TinyMCE: Remove dashicon-no-alt.png, unused since [30694].
...
props kpdesign, MattyRob.
fixes #30791 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31073
git-svn-id: http://core.svn.wordpress.org/trunk@31054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:32:22 +00:00
Sergey Biryukov
da4a8f56f5
Theme install: Display an appropriate string if theme has not been rated yet.
...
props kevdotbadger, valendesigns.
fixes #28147 .
Built from https://develop.svn.wordpress.org/trunk@31072
git-svn-id: http://core.svn.wordpress.org/trunk@31053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 23:17:22 +00:00
Andrew Ozz
00ff6675a2
Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167 .
...
Built from https://develop.svn.wordpress.org/trunk@31070
git-svn-id: http://core.svn.wordpress.org/trunk@31051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 22:48:22 +00:00
Sergey Biryukov
1c9e1836ac
Remove obsolete help sentence on Edit User screen.
...
fixes #30750 .
Built from https://develop.svn.wordpress.org/trunk@31067
git-svn-id: http://core.svn.wordpress.org/trunk@31048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-07 08:23:23 +00:00
Dominik Schilling
56981c7143
Customizer: Send JSON success for customize_save
and allow response to be filtered.
...
props westonruter.
fixes #29098 .
Built from https://develop.svn.wordpress.org/trunk@31062
git-svn-id: http://core.svn.wordpress.org/trunk@31043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 21:47:23 +00:00
Sergey Biryukov
483e7a36d7
Use localized format for Last Updated date on Add Plugins screen.
...
props tyxla.
fixes #30717 .
Built from https://develop.svn.wordpress.org/trunk@31055
git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-06 01:03:23 +00:00
Sergey Biryukov
291de9cac1
Themes: Fix position of admin notice with .notice class.
...
fixes #30895 .
Built from https://develop.svn.wordpress.org/trunk@31054
git-svn-id: http://core.svn.wordpress.org/trunk@31035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 20:06:23 +00:00
Sergey Biryukov
1541bc1537
Pass comment author name and comment ID to 'get_comment_author_link' filter on Edit Comment screen, for consistency with [30092].
...
props tyxla.
fixes #30894 .
Built from https://develop.svn.wordpress.org/trunk@31053
git-svn-id: http://core.svn.wordpress.org/trunk@31034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-05 19:10:23 +00:00
Scott Taylor
a9302b2e36
If IMAGE_EDIT_OVERWRITE
is defined as true
, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical).
...
Props hew.
Fixes #30394 .
Built from https://develop.svn.wordpress.org/trunk@31043
git-svn-id: http://core.svn.wordpress.org/trunk@31024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:52:24 +00:00
Scott Taylor
f79eb196df
Improve the handling of comma-separated mime-types in wp_match_mime_types()
, particularly as pertains to the mime-type selector on the Media list table screen.
...
Props mdgl.
Fixes #30788 .
Built from https://develop.svn.wordpress.org/trunk@31042
git-svn-id: http://core.svn.wordpress.org/trunk@31023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:32:22 +00:00
Scott Taylor
ada7442b9e
After [31037], ensure that the library is passed as a map to the Media Grid instance. Remove useless query vars.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31041
git-svn-id: http://core.svn.wordpress.org/trunk@31022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-04 02:07:23 +00:00
Scott Taylor
c5f9a7c26a
Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library.
...
Fixes #30584 .
Built from https://develop.svn.wordpress.org/trunk@31037
git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 08:24:22 +00:00
Scott Taylor
190165cb32
Use the 'not_found'
label when there are no items for a taxonomy in the terms list table.
...
Props SergeyBiryukov.
Fixes #30586 .
Built from https://develop.svn.wordpress.org/trunk@31035
git-svn-id: http://core.svn.wordpress.org/trunk@31016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 06:20:21 +00:00
Scott Taylor
af0e5cc851
Inline <script>
s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA
comments.
...
Props tw2113 for the initial patch.
See #18788 .
Built from https://develop.svn.wordpress.org/trunk@31034
git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:46:25 +00:00
Scott Taylor
618c5b4333
When outputting JS with a Content-Type
header:
...
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.
Props sergej.mueller.
Fixes #29196 .
Built from https://develop.svn.wordpress.org/trunk@31029
git-svn-id: http://core.svn.wordpress.org/trunk@31010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 02:57:21 +00:00
Andrew Ozz
e0189c3686
Move the (recently added) .notice
admin notices below the first H2, same as the .updated
and .error
notices. Props sippis, fixes #30885 .
...
Built from https://develop.svn.wordpress.org/trunk@31023
git-svn-id: http://core.svn.wordpress.org/trunk@31004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-02 18:52:23 +00:00
Scott Taylor
5e4941023b
WP_List_Table
's constructor registers an 'admin_footer'
callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when wp_comment_reply()
invokes the class constructor without checking for the existing instance via the $wp_list_table
global.
...
We shall check the `$wp_list_table` global in `wp_comment_reply()`.
Props sorich87.
Fixes #17413 .
Built from https://develop.svn.wordpress.org/trunk@31019
git-svn-id: http://core.svn.wordpress.org/trunk@31000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-01 19:55:35 +00:00
Scott Taylor
952a5c9971
Support chromeless Vimeo via MEjs:
...
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)
Fixes #29267 .
Built from https://develop.svn.wordpress.org/trunk@31016
git-svn-id: http://core.svn.wordpress.org/trunk@30997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 20:41:24 +00:00
Aaron Jorbin
7ea306dd9d
Set the type attribute of the buttons for logging out of all sessions to buttons
...
By not setting this attribute, the buttons default to submit and as the first
submit button on the page, it causes pressing the enter key to log you out of
all sessions. This change restores the pre 4.1 behavior where pressing enter
while focused on a form field submits the form.
props ocean90
fixes #30871 for trunk
Built from https://develop.svn.wordpress.org/trunk@31010
git-svn-id: http://core.svn.wordpress.org/trunk@30991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 17:33:24 +00:00
Andrew Nacin
bc60e63518
Use correct function name in docs for get_plugin_data().
...
props eliorivero.
fixes #30699 .
Built from https://develop.svn.wordpress.org/trunk@31008
git-svn-id: http://core.svn.wordpress.org/trunk@30989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-31 08:08:22 +00:00
Boone Gorges
95dba4c8c0
When no plugins are active, return an empty array from validate_active_plugins()
.
...
This creates parity with the behavior of the function when plugins *are* active,
but none are invalid. It also makes it possible to write unit tests for the
function.
Props sgrant.
Fixes #30860 .
Built from https://develop.svn.wordpress.org/trunk@31003
git-svn-id: http://core.svn.wordpress.org/trunk@30984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-30 19:31:22 +00:00
Boone Gorges
8572a07a25
Fix incorrect @since
tag introduced in [30998].
...
Props dimadin.
See #25853 .
Built from https://develop.svn.wordpress.org/trunk@30999
git-svn-id: http://core.svn.wordpress.org/trunk@30981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-29 17:18:22 +00:00
Boone Gorges
25e625b9b0
Apply 'taxonomy_parent_dropdown_args' filter when editing terms.
...
Added in WP 3.7 [25123], the 'taxonomy_parent_dropdown_args' filter affected
only the term creation interface. This changeset introduces parity by ensuring
that it is applied when editing terms as well.
The new `$context` parameter indicates whether the filter is being applied in
a 'new' or 'edit' context.
Props TimothyBlynJacobs, DrewAPicture.
Fixes #29853 .
Built from https://develop.svn.wordpress.org/trunk@30998
git-svn-id: http://core.svn.wordpress.org/trunk@30980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-29 15:27:22 +00:00
Dominik Schilling
14abcecf81
Customizer: Use correct event variable when moving widgets to another widget area.
...
Fixes "ReferenceError: event is not defined error." in Firefox.
props tywayne.
fixes #30818 .
Built from https://develop.svn.wordpress.org/trunk@30992
git-svn-id: http://core.svn.wordpress.org/trunk@30974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-23 17:24:24 +00:00
Dominik Schilling
93605deef5
Customizer: Improve IE 8 compatibility.
...
* Use square bracket notation for `default` keywords.
* Use Underscores `indexOf` for arrays.
props westonruter, ocean90.
fixes #30781 for trunk.
Built from https://develop.svn.wordpress.org/trunk@30991
git-svn-id: http://core.svn.wordpress.org/trunk@30973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-23 17:05:26 +00:00
Scott Taylor
bc1341628f
Comment List Tables:
...
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30984
git-svn-id: http://core.svn.wordpress.org/trunk@30970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:27:25 +00:00
Scott Taylor
786caa4d55
Correct the @param
docs for arguments that are truthy/falsey.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30983
git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:04:23 +00:00
Scott Taylor
5eb5afac34
For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30982
git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:47:22 +00:00
Scott Taylor
2dbd0d0a8f
In image_size_input_fields()
:
...
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30981
git-svn-id: http://core.svn.wordpress.org/trunk@30967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:19:24 +00:00
Scott Taylor
f19bec8754
In wp_import_handle_upload()
:
...
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30980
git-svn-id: http://core.svn.wordpress.org/trunk@30966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 21:10:24 +00:00
Scott Taylor
42f5acd869
Improve some docs for @param
. Remove an unneeded $wpdb
global import.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30979
git-svn-id: http://core.svn.wordpress.org/trunk@30965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 20:56:22 +00:00
Scott Taylor
574fabf2bc
Improve some wp-admin/includes/class-wp-filesystem-*.php
docs for @param
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30978
git-svn-id: http://core.svn.wordpress.org/trunk@30964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 20:40:23 +00:00
Andrew Ozz
6bde00ec42
Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk.
...
Built from https://develop.svn.wordpress.org/trunk@30977
git-svn-id: http://core.svn.wordpress.org/trunk@30963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 19:33:23 +00:00
Andrew Nacin
a814ef7bcc
About page: CDN images.
...
Built from https://develop.svn.wordpress.org/trunk@30971
git-svn-id: http://core.svn.wordpress.org/trunk@30958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-18 17:55:22 +00:00
Helen Hou-Sandí
e9d3be4d99
Ensure inline code examples stay LTR, punctuation and all.
...
props alex-ye.
see #30748 .
Built from https://develop.svn.wordpress.org/trunk@30952
git-svn-id: http://core.svn.wordpress.org/trunk@30940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:22:22 +00:00
Helen Hou-Sandí
b25e4524fc
About page: Don't allow tab text to wrap.
...
Some language, browser, and OS combinations (notably Arabic, Chrome, and Windows) were wrapping.
see #30743 .
Built from https://develop.svn.wordpress.org/trunk@30951
git-svn-id: http://core.svn.wordpress.org/trunk@30939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-17 16:02:22 +00:00
Dominik Schilling
626af35acb
About: Fix the WordPress badge.
...
`css-clean` (minifies our CSS) has an issue when using multiple backgrounds and background position together. Instead of relying on browser support for multiple backgrounds to display the WP logo as SVG, use the `.svg` CSS class.
see #30735 .
Built from https://develop.svn.wordpress.org/trunk@30946
git-svn-id: http://core.svn.wordpress.org/trunk@30935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 22:54:21 +00:00
Dominik Schilling
eccd5a5eda
Pass locale to wordpress.org theme/plugin API.
...
In the future this will be used to return localized plugin/theme info.
see #30735 .
Built from https://develop.svn.wordpress.org/trunk@30944
git-svn-id: http://core.svn.wordpress.org/trunk@30933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 22:39:22 +00:00
Andrew Nacin
72083f67cd
Last about page string. props celloexpressions. fixes #30435 .
...
Built from https://develop.svn.wordpress.org/trunk@30929
git-svn-id: http://core.svn.wordpress.org/trunk@30918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 21:27:22 +00:00
John Blackbourn
b43470397d
Make the DFW paragraph on the About page narrower to mitigate an orphan in Firefox.
...
See #30435
Props melchoyce
Built from https://develop.svn.wordpress.org/trunk@30921
git-svn-id: http://core.svn.wordpress.org/trunk@30910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 20:02:23 +00:00
John Blackbourn
9592b26cbe
Move a <code>
tag out of a localised string on the About page.
...
Props pavelevap
See #30435
Built from https://develop.svn.wordpress.org/trunk@30903
git-svn-id: http://core.svn.wordpress.org/trunk@30893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 14:04:22 +00:00
Andrew Nacin
8c3027c3c7
Call it 'Distraction-free writing mode' and update the help string. fixes #30657 .
...
Built from https://develop.svn.wordpress.org/trunk@30890
git-svn-id: http://core.svn.wordpress.org/trunk@30880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 10:07:23 +00:00
Andrew Nacin
7b015d507d
Update/add plugin recommendation strings.
...
Update [30887], add a translation function to the Vine string.
fixes #30337 . see #30435 .
Built from https://develop.svn.wordpress.org/trunk@30889
git-svn-id: http://core.svn.wordpress.org/trunk@30879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 10:06:24 +00:00
Andrew Nacin
23f4b0f62f
Updates to the 'Log out everywhere' implementation.
...
* Include a message and a disabled button when you're only logged in at one location.
* Avoid leaking the session token in HTML.
* Simplify, simplify, simplify.
see #30264 .
Built from https://develop.svn.wordpress.org/trunk@30888
git-svn-id: http://core.svn.wordpress.org/trunk@30878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 09:15:23 +00:00
Andrew Nacin
6abad25e05
Finalize two more about page strings. see #30435 .
...
Built from https://develop.svn.wordpress.org/trunk@30887
git-svn-id: http://core.svn.wordpress.org/trunk@30877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 08:58:23 +00:00
Dominik Schilling
fcb00b75e2
Customizer: Add _wp_attachment_is_custom_background
meta to uploaded background images.
...
Adds `$type` property to `WP_Customize_Background_Image_Control` (PHP) and introduces `wp.customize.BackgroundControl` (JS).
see #30707 .
Built from https://develop.svn.wordpress.org/trunk@30885
git-svn-id: http://core.svn.wordpress.org/trunk@30873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 23:28:23 +00:00
Dominik Schilling
824d751879
Autoprefixer for [30857].
...
see #30435 .
Built from https://develop.svn.wordpress.org/trunk@30884
git-svn-id: http://core.svn.wordpress.org/trunk@30872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 23:20:23 +00:00
John Blackbourn
b01740334c
Correct the height of the search type select
element when searching the plugin directory.
...
See #30719
Props pavelevap, eliorivero
Built from https://develop.svn.wordpress.org/trunk@30879
git-svn-id: http://core.svn.wordpress.org/trunk@30867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 22:32:23 +00:00
Dominik Schilling
4652717828
Customizer: Remove date filter from the Header/Background Image upload frames.
...
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].
see #30689 .
Built from https://develop.svn.wordpress.org/trunk@30872
git-svn-id: http://core.svn.wordpress.org/trunk@30862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 20:27:22 +00:00
Dominik Schilling
d5914fc1c8
Customizer: Import missing wp.customize.Control.prototype._toggleActive
.
...
Check also if `completeCallback` is set before calling it.
props westonruter.
see #30701 .
Built from https://develop.svn.wordpress.org/trunk@30871
git-svn-id: http://core.svn.wordpress.org/trunk@30861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 19:54:21 +00:00