Lance Willett
42d2f4fc21
Bundled themes: use correct logic in IE conditional comments in header template. Props mikemanger, fixes #28151 .
...
Built from https://develop.svn.wordpress.org/trunk@28341
git-svn-id: http://core.svn.wordpress.org/trunk@28169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 04:27:15 +00:00
Scott Taylor
aa83aea519
In wp-login.php
, break
is unreachable after exit
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28340
git-svn-id: http://core.svn.wordpress.org/trunk@28168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:58:15 +00:00
Scott Taylor
361e3e1ee6
In wpdb
, remove dead code:
...
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28339
git-svn-id: http://core.svn.wordpress.org/trunk@28167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:56:14 +00:00
Scott Taylor
06373a6f32
In WP_Widget::update_callback()
, $sidebars_widgets
is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28338
git-svn-id: http://core.svn.wordpress.org/trunk@28166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:52:15 +00:00
Scott Taylor
49251efc74
In wp-includes/theme.php
, break
is unreachable after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28337
git-svn-id: http://core.svn.wordpress.org/trunk@28165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:50:14 +00:00
Scott Taylor
cca9ff329b
In print_admin_styles()
, $zip
is never used after being set. $compress_css
does not need to be imported.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28336
git-svn-id: http://core.svn.wordpress.org/trunk@28164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:47:14 +00:00
Scott Taylor
1ef3438961
In wp_default_scripts()
, $max_upload_size
and its entangled children $max_up
and $max_post
create quite the ternary operator... that is never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28335
git-svn-id: http://core.svn.wordpress.org/trunk@28163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:45:14 +00:00
Scott Taylor
5b6b17fc80
In wp-includes/revision.php
- remove dead code:
...
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28334
git-svn-id: http://core.svn.wordpress.org/trunk@28162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:38:16 +00:00
Scott Taylor
5bc59586da
In WP_Query
, remove duplicate variable setting:
...
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28333
git-svn-id: http://core.svn.wordpress.org/trunk@28161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:43:20 +00:00
Scott Taylor
1aed1f1108
In get_pages()
, $cache
does not need to be reset to an empty array. update_post_cache( $pages )
takes care of priming.
...
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28332
git-svn-id: http://core.svn.wordpress.org/trunk@28160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:39:14 +00:00
Scott Taylor
ef34785160
In wp_get_attachment_link()
, $post_title
is set and then not used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28331
git-svn-id: http://core.svn.wordpress.org/trunk@28159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:35:16 +00:00
Scott Taylor
9a1dcd1a7c
In Walker_Nav_Menu::start_el()
, $class_names
is set twice before it is used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28330
git-svn-id: http://core.svn.wordpress.org/trunk@28158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:33:14 +00:00
Scott Taylor
c96d7fff01
In get_network_by_path()
, $exact_domains
is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28329
git-svn-id: http://core.svn.wordpress.org/trunk@28157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:32:16 +00:00
Scott Taylor
b2b25f7326
In update_metadata_by_mid()
, $original_value
is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28328
git-svn-id: http://core.svn.wordpress.org/trunk@28156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:29:26 +00:00
Scott Taylor
0910376bfe
In edit_post_link()
, $post_type_obj
is unused.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28327
git-svn-id: http://core.svn.wordpress.org/trunk@28155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:27:15 +00:00
Scott Taylor
3d0eed82f8
In paginate_links()
, break
is unreachable after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28326
git-svn-id: http://core.svn.wordpress.org/trunk@28154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:25:15 +00:00
Scott Taylor
de4eaacd89
In wp-includes/functions.php
, remove dead code:
...
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28325
git-svn-id: http://core.svn.wordpress.org/trunk@28153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:23:14 +00:00
Scott Taylor
7eeafa3537
In wp_set_comment_status()
, the default
case returns, so no default value for $status
is needed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28324
git-svn-id: http://core.svn.wordpress.org/trunk@28152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:17:15 +00:00
Scott Taylor
de262f553c
In wp-includes/comment-template.php
, remove dead code:
...
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28323
git-svn-id: http://core.svn.wordpress.org/trunk@28151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:15:17 +00:00
Scott Taylor
6b80da9d96
In Walker::walk()
and Walker::paged_walk()
, $id_field
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28322
git-svn-id: http://core.svn.wordpress.org/trunk@28150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:09:19 +00:00
Sergey Biryukov
d711c32138
Update deleted site message in ms_site_check().
...
props boonebgorges.
fixes #28150 .
Built from https://develop.svn.wordpress.org/trunk@28321
git-svn-id: http://core.svn.wordpress.org/trunk@28149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:46:15 +00:00
Scott Taylor
013d4dc387
In WP_Image_Editor::get_output_format()
, $file_mime
and $file_ext
are set twice before they are used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28320
git-svn-id: http://core.svn.wordpress.org/trunk@28148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:37:29 +00:00
Scott Taylor
73b102bd84
In wp-includes/class-wp-customize-setting.php
, break
is unreachable after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28319
git-svn-id: http://core.svn.wordpress.org/trunk@28147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:34:14 +00:00
Scott Taylor
0a4af6d45c
In wp-includes/class-wp-admin-bar.php
, break
is unreachabled after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28318
git-svn-id: http://core.svn.wordpress.org/trunk@28146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:29:15 +00:00
Scott Taylor
5bd852c262
In WP_Http_Curl::request()
, $theResponse
is unused. There are other curl_exec()
calls that do not return as well.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28317
git-svn-id: http://core.svn.wordpress.org/trunk@28145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:26:14 +00:00
Scott Taylor
63a210e7c8
In wp-includes/bookmark.php
, remove dead code:
...
* In `get_bookmarks()`, `$cache` is set twice before it is used.
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28316
git-svn-id: http://core.svn.wordpress.org/trunk@28144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:22:16 +00:00
Scott Taylor
5f27d149a3
In wp-admin/users.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28315
git-svn-id: http://core.svn.wordpress.org/trunk@28143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:19:14 +00:00
Scott Taylor
402d8b80fb
In core_upgrade_preamble()
, $alternate
is set then never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28314
git-svn-id: http://core.svn.wordpress.org/trunk@28142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:17:18 +00:00
Scott Taylor
e9bb9c0f12
In wp-admin/theme-editor.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28313
git-svn-id: http://core.svn.wordpress.org/trunk@28141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:16:26 +00:00
Scott Taylor
517dbfaa21
In wp-admin/post.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28312
git-svn-id: http://core.svn.wordpress.org/trunk@28140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:15:15 +00:00
Scott Taylor
327b38f298
In wp-admin/plugins.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28311
git-svn-id: http://core.svn.wordpress.org/trunk@28139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:13:14 +00:00
Scott Taylor
ac63c66c5a
In wp-admin/plugin-editor.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28310
git-svn-id: http://core.svn.wordpress.org/trunk@28138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:12:14 +00:00
Scott Taylor
0f8fb8a148
In wp-admin/network/users.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28309
git-svn-id: http://core.svn.wordpress.org/trunk@28137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:11:14 +00:00
Scott Taylor
64418c0192
In wp-admin/network/themes.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28308
git-svn-id: http://core.svn.wordpress.org/trunk@28136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:08:14 +00:00
Scott Taylor
f5d23b82bd
In wp-admin/link.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28307
git-svn-id: http://core.svn.wordpress.org/trunk@28135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:06:14 +00:00
Scott Taylor
213a7de0b7
In display_setup_form()
, $admin_password
is set and (fortunately) not used or displayed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28306
git-svn-id: http://core.svn.wordpress.org/trunk@28134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:04:15 +00:00
Scott Taylor
c2d44c5736
In wp-admin/includes/upgrade.php
, remove dead code:
...
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28305
git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:27:15 +00:00
Scott Taylor
aaa3eb07ad
In wp-admin/includes/update.php
, remove dead code:
...
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28304
git-svn-id: http://core.svn.wordpress.org/trunk@28132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:21:14 +00:00
Scott Taylor
b80cda5d17
In WP_Screen::render_screen_options()
, remove dead code:
...
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28303
git-svn-id: http://core.svn.wordpress.org/trunk@28131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:14:15 +00:00
Scott Taylor
2e417f0ca4
In get_sample_permalink_html()
, $view_link
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28302
git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:11:14 +00:00
Scott Taylor
44e2d48a3c
In install_plugin_information()
, $title
is set in a foreach
loop and never used. This appears to be due to copy-pasting a previous foreach
loop and not discarding these bits.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28301
git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:00:18 +00:00
Scott Taylor
e57fa7300d
In wp-admin/includes/nav-menu.php
, remove dead code:
...
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it.
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28300
git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:55:14 +00:00
Scott Taylor
85bdc64173
In update_option_new_admin_email()
, $email
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28299
git-svn-id: http://core.svn.wordpress.org/trunk@28127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:48:14 +00:00
Scott Taylor
6066f85853
In attachment_submit_meta_box()
, remove dead code:
...
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28298
git-svn-id: http://core.svn.wordpress.org/trunk@28126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:45:14 +00:00
Scott Taylor
71ac0f21c2
In get_media_item()
, $tags
and $_tags
are set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28297
git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:41:17 +00:00
Scott Taylor
3054b924a3
In WP_Users_List_Table::get_views()
, $current_role
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28296
git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:33:15 +00:00
Scott Taylor
209f008d77
In WP_MS_Users_List_Table::get_views()
, remove dead code:
...
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28295
git-svn-id: http://core.svn.wordpress.org/trunk@28123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:30:14 +00:00
Dominik Schilling
f7539feb4d
Custom Header: Fix logic when a theme doesn't set default-text-color
.
...
fixes #28042 .
Built from https://develop.svn.wordpress.org/trunk@28294
git-svn-id: http://core.svn.wordpress.org/trunk@28122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:27:54 +00:00
Scott Taylor
970477d25e
In WP_Media_List_Table
, remove dead code:
...
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28293
git-svn-id: http://core.svn.wordpress.org/trunk@28121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:27:33 +00:00
Scott Taylor
28d98a89f3
In ajax-actions.php
, remove dead code:
...
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28292
git-svn-id: http://core.svn.wordpress.org/trunk@28120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:19:14 +00:00