Commit Graph

19396 Commits

Author SHA1 Message Date
Scott Taylor
45a0c26091 Taxonomy: get_terms_to_edit() can also return false or WP_Error. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations.
Props valendesigns.
Fixes #30472.

Built from https://develop.svn.wordpress.org/trunk@35139


git-svn-id: http://core.svn.wordpress.org/trunk@35104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 16:40:26 +00:00
Drew Jaynes
dc92982950 Users: Restore changes from [35114] accidentally reverted in [35135].
See #28631.

Built from https://develop.svn.wordpress.org/trunk@35138


git-svn-id: http://core.svn.wordpress.org/trunk@35103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 15:45:25 +00:00
Boone Gorges
b36cc4deab Create fewer fixtures in some XML-RPC tests.
See #30017, #33968.
Built from https://develop.svn.wordpress.org/trunk@35137


git-svn-id: http://core.svn.wordpress.org/trunk@35102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 15:32:25 +00:00
Boone Gorges
f240b3398f In WP_UnitTestCase, only flush rewrite rules when they're set.
See [34810]. See #33968.
Built from https://develop.svn.wordpress.org/trunk@35136


git-svn-id: http://core.svn.wordpress.org/trunk@35101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 15:22:24 +00:00
Drew Jaynes
cdd8891631 Docs: Add a changelog entry mentioning that the number argument now supports -1 (all).
Also fixes the argument description.

-1 support was added in [35114].

See #28631.

Built from https://develop.svn.wordpress.org/trunk@35135


git-svn-id: http://core.svn.wordpress.org/trunk@35100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 15:16:24 +00:00
Scott Taylor
7c88e86bf6 Theme Editor: add a filter, wp_theme_editor_filetypes, to allow more filetypes to be edited via the Theme Editor. Usage of the Theme Editor is strenuously discouraged, but we should allow you to add whatever filetypes (.less, .scss) you would like.
Props MikeHansenMe, pross.
Fixes #22924.

Built from https://develop.svn.wordpress.org/trunk@35134


git-svn-id: http://core.svn.wordpress.org/trunk@35099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 14:14:24 +00:00
Scott Taylor
357b916211 Theme Installer: fix the theme "Install"/"Installed" button's vertical alignment for HiDPI displays.
Props paulwilde.
Fixes #34198.

Built from https://develop.svn.wordpress.org/trunk@35133


git-svn-id: http://core.svn.wordpress.org/trunk@35098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 13:52:27 +00:00
Sergey Biryukov
e19cda5c2d Toolbar: Improve padding of toolbar submenu items on small screens.
Props tillkruess.
Fixes #28608.
Built from https://develop.svn.wordpress.org/trunk@35132


git-svn-id: http://core.svn.wordpress.org/trunk@35097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:40:25 +00:00
Sergey Biryukov
be10375eb6 Accessibility: Add back-compat styles for plugins that still use h2 as a main heading in their screens.
Props afercia.
Fixes #33559.
Built from https://develop.svn.wordpress.org/trunk@35131


git-svn-id: http://core.svn.wordpress.org/trunk@35096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:17:24 +00:00
Sergey Biryukov
1c9ea9bb4a Accessibility: Correct the style for Popular Tags header on Edit Tags screen after [33917].
Props afercia.
See #33559. See #33658.
Built from https://develop.svn.wordpress.org/trunk@35130


git-svn-id: http://core.svn.wordpress.org/trunk@35095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:14:25 +00:00
Sergey Biryukov
7ebbe03a1f Acessibility: "Add New Category" links on Edit Post screen should not be a header.
Props afercia.
Fixes #33557.
Built from https://develop.svn.wordpress.org/trunk@35129


git-svn-id: http://core.svn.wordpress.org/trunk@35094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:00:25 +00:00
Sergey Biryukov
1c5d327676 Accessibility: bump headings one level up in post meta boxes for a better headings hierarchy.
Props afercia, joedolson, wonderboymusic.
See #33557.
Built from https://develop.svn.wordpress.org/trunk@35128


git-svn-id: http://core.svn.wordpress.org/trunk@35093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:57:24 +00:00
Sergey Biryukov
3cd956f9bb Add the CSS changes missed in [35126].
Props afercia.
See #34263.
Built from https://develop.svn.wordpress.org/trunk@35127


git-svn-id: http://core.svn.wordpress.org/trunk@35092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:51:24 +00:00
Sergey Biryukov
8688df4306 Accessibility: bump headings one level up on Credits screen for a better headings hierarchy.
Props afercia.
Fixes #34263.
Built from https://develop.svn.wordpress.org/trunk@35126


git-svn-id: http://core.svn.wordpress.org/trunk@35091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:49:26 +00:00
Scott Taylor
596431bd21 Admin Bar: fix the alignment of secondary menu item arrows.
Props juhise.
Fixes #33836.

Built from https://develop.svn.wordpress.org/trunk@35125


git-svn-id: http://core.svn.wordpress.org/trunk@35090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:54:24 +00:00
Scott Taylor
06594694e6 After [35122], update test_wp_unique_filename() to reflect the change.
See #16226.

Built from https://develop.svn.wordpress.org/trunk@35124


git-svn-id: http://core.svn.wordpress.org/trunk@35089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:42:25 +00:00
Boone Gorges
8de6b7aa8e Correct expected counts in WP_User_Query 'number' test.
The `create_many()` number should be padded by just one, to account for the
user created by the test suite. Introduced in [35114].

We also don't have to create so many fixtures to run this test.

See #28631.
Built from https://develop.svn.wordpress.org/trunk@35123


git-svn-id: http://core.svn.wordpress.org/trunk@35088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:26:23 +00:00
Scott Taylor
d8e20fa273 Fotmatting: in sanitize_file_name(), escape % when uploads contain them, otherwise attachment URLs will unescape the char and break.
Adds unit tests.

Props mordauk, simonwheatley, dd32, solarissmoke.
Fixes #16226.

Built from https://develop.svn.wordpress.org/trunk@35122


git-svn-id: http://core.svn.wordpress.org/trunk@35087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:22:24 +00:00
Sergey Biryukov
ae0f01904f Feeds: Remove a confusing comment from add_feed(), added in [3638].
It always overrides the default callback if it's set, regardless of the `in_array()` check.

See #34259.
Built from https://develop.svn.wordpress.org/trunk@35121


git-svn-id: http://core.svn.wordpress.org/trunk@35086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:14:25 +00:00
Boone Gorges
cd563fd404 Use a more reliable method for generating get_terms() cache key.
Previously, the cache key included a serialization of `list_terms_exclusions`
callbacks, to ensure that the cache was differentiated properly for different
uses of the `list_terms_exclusions` filter. This strategy was flawed in a
couple of ways: serialization doesn't work equally well for all callable types;
the serialization required reaching into the `$wp_filter` global; serializing
the callback itself didn't properly account for the possibility that the
callback might return different values in different contexts; the cache key
didn't account for other filters that similarly affect the cached values, such
as `terms_clauses`.

We skirt all these issues by concatenating the cache key using the SQL query
string, which will reflect all filters applied earlier in `get_terms()`.

Props boonebgorges, wonderboymusic.
Fixes #21267.
Built from https://develop.svn.wordpress.org/trunk@35120


git-svn-id: http://core.svn.wordpress.org/trunk@35085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:07:24 +00:00
Sergey Biryukov
bac64cc984 Docs: Describe the $feedname argument of add_feed().
Fixes #34259.
Built from https://develop.svn.wordpress.org/trunk@35119


git-svn-id: http://core.svn.wordpress.org/trunk@35084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:01:25 +00:00
Sergey Biryukov
ae9ce0ccd7 Feeds: Pass the second parameter of "do_feed_{$feed}" action, feed name, to callbacks added via add_feed().
The `$feed` parameter was added in [35115].

Props slimndap.
See #34259.
Built from https://develop.svn.wordpress.org/trunk@35118


git-svn-id: http://core.svn.wordpress.org/trunk@35083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:59:24 +00:00
Boone Gorges
7de3499949 In get_terms(), don't store WP_Term objects in cache.
Fixes #34282.
Built from https://develop.svn.wordpress.org/trunk@35117


git-svn-id: http://core.svn.wordpress.org/trunk@35082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:58:24 +00:00
Scott Taylor
fc842e33c9 Users: when passing a WP_User instance to wp_update_user(), ensure that the user password is not accidentally double-hashed. This is terrifying.
Adds unit tests.

Props tbcorr, salcode.
Fixes #28435.

Built from https://develop.svn.wordpress.org/trunk@35116


git-svn-id: http://core.svn.wordpress.org/trunk@35081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:48:24 +00:00
Sergey Biryukov
c332da3e12 Feeds: Pass the feed name to do_feed_{$feed} action.
Props johnbillion.
See #34259.
Built from https://develop.svn.wordpress.org/trunk@35115


git-svn-id: http://core.svn.wordpress.org/trunk@35080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:44:23 +00:00
Scott Taylor
c9babc4cdd Users: allow -1 (no limit, use with extreme caution on large sites) as the value for number in WP_User_Query - similar to posts_per_page => -1 in WP_Query.
Adds unit tests.

Props mordauk, jesin, nofearinc.
Fixes #28631.

Built from https://develop.svn.wordpress.org/trunk@35114


git-svn-id: http://core.svn.wordpress.org/trunk@35079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:40:24 +00:00
Scott Taylor
5bb40ab27d Widgets: after [35106], ensure that the widget required by the unit test is registered.
See #19450.

Built from https://develop.svn.wordpress.org/trunk@35113


git-svn-id: http://core.svn.wordpress.org/trunk@35078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:37:12 +00:00
Boone Gorges
bec9315360 In term meta lazy-loading tests, force WP_Query to cache results.
By default, `WP_Query` will not cache query results when using a persistent
object cache. The lazyload tests, however, depend on the cache being set during
each `WP_Query`, because the object cache is cleared between tests.

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35112


git-svn-id: http://core.svn.wordpress.org/trunk@35077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:36:48 +00:00
Boone Gorges
07b7e7b3c7 Remove dead code from WP_Query::lazyload_term_meta().
Built from https://develop.svn.wordpress.org/trunk@35111


git-svn-id: http://core.svn.wordpress.org/trunk@35076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:36:25 +00:00
Sergey Biryukov
2c12662eff Remove obsolete code from `WP_Users_List_Table::get_sortable_columns().
Sorting by post count was disabled in [17024].

Props jdgrimes.
See #15861.
Built from https://develop.svn.wordpress.org/trunk@35110


git-svn-id: http://core.svn.wordpress.org/trunk@35075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:25:25 +00:00
Sergey Biryukov
319d0e8bf0 Replace get_bloginfo( 'wpurl' ) with admin_url() for plugin activation error message.
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
Fixes #34280.
Built from https://develop.svn.wordpress.org/trunk@35109


git-svn-id: http://core.svn.wordpress.org/trunk@35074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:12:24 +00:00
Boone Gorges
5d07f8eb46 In cache tests, determine cache class name dynamically.
Some cache backends may use a class name other than `WP_Object_Cache` for their
cache drop-in. For example, certain versions of the APC Object Cache plugin
have a shim called `APC_Object_Cache`.

See #31491.
Built from https://develop.svn.wordpress.org/trunk@35108


git-svn-id: http://core.svn.wordpress.org/trunk@35073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:07:25 +00:00
Sergey Biryukov
34732f5a80 Replace get_bloginfo( 'wpurl' ) with admin_url() in plugin editor.
Use `add_query_arg()` instead of constructing the URL manually.

Props johnbillion.
See #34280.
Built from https://develop.svn.wordpress.org/trunk@35107


git-svn-id: http://core.svn.wordpress.org/trunk@35072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:05:24 +00:00
Scott Taylor
05cd8a447e Widgets: When using the_widget(), the $before_widget argument only receives the widget class if using the default sidebar arguments. Run sprintf after parsing the args to fix this.
Adds unit test.

Props coffee2code.
Fixes #19450.

Built from https://develop.svn.wordpress.org/trunk@35106


git-svn-id: http://core.svn.wordpress.org/trunk@35071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:49:48 +00:00
Sergey Biryukov
426944c744 Replace get_bloginfo( 'wpurl' ) with site_url() in rsd_link().
Ensure the correct scheme is used for the `application/rsd+xml` link URL.

Props johnbillion.
See #34280.
Built from https://develop.svn.wordpress.org/trunk@35105


git-svn-id: http://core.svn.wordpress.org/trunk@35070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:49:26 +00:00
Drew Jaynes
649382a7f1 Widgets: Rename the $name parameter in is_registered_sidebar() to $sidebar_id and adjust the accepted types to string|int as sidebar IDs can be numeric.
See #24878.

Built from https://develop.svn.wordpress.org/trunk@35104


git-svn-id: http://core.svn.wordpress.org/trunk@35069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:45:25 +00:00
Scott Taylor
2e6865a7fb Widgets: add a default filter for widget_text (used by the Text widget), balanceTags, which respects the option for use_balanceTags.
Props MikeHansenMe.
Fixes #23083.

Built from https://develop.svn.wordpress.org/trunk@35103


git-svn-id: http://core.svn.wordpress.org/trunk@35068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:40:26 +00:00
Scott Taylor
aa92c9555a Widgets: add a function, is_registered_sidebar() - helps us avoid touching the $wp_registered_sidebars global.
Props GaryJ, wonderboymusic.
Fixes #24878.

Built from https://develop.svn.wordpress.org/trunk@35102


git-svn-id: http://core.svn.wordpress.org/trunk@35067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:33:25 +00:00
Boone Gorges
ff0b621719 Don't match partial roles in WP_User_Query.
Because 'role=ocean90' shouldn't match 'role=bocean901'.

Props bocean901, ocean90.
Fixes #22212.
Built from https://develop.svn.wordpress.org/trunk@35101


git-svn-id: http://core.svn.wordpress.org/trunk@35066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:32:25 +00:00
Scott Taylor
e7c2544a89 Widgets: when getting settings, and none exist, set them to empty to avoid extraneous database queries on subsequent requests.
Adds unit tests.

Props kovshenin, MikeHansenMe, dlh.
Fixes #26876.

Built from https://develop.svn.wordpress.org/trunk@35100


git-svn-id: http://core.svn.wordpress.org/trunk@35065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:13:24 +00:00
Scott Taylor
a31d7e37dc Color Picker: when opening and closing, toggle a wp-picker-active class on the wrapper.
Props norcross.
Fixes #29471.

Built from https://develop.svn.wordpress.org/trunk@35099


git-svn-id: http://core.svn.wordpress.org/trunk@35064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:08:25 +00:00
Drew Jaynes
48811702cd Feeds: Simplify logic for checking if the do_feed_{$feed} action is hooked to any callbacks.
See [35097] for where the aforementioned hook was renamed to actually be dynamic, thus rendering creation of the extra `$hook` variable moot.

See #34264.

Built from https://develop.svn.wordpress.org/trunk@35098


git-svn-id: http://core.svn.wordpress.org/trunk@35063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:07:25 +00:00
Drew Jaynes
b234b5d896 Feeds: Adjust the do_feed_{$feed} hook name to actually be dynamic, rather than pre-storing the tag name in a variable and referencing that.
Props johnbillion.
Fixes #34264.

Built from https://develop.svn.wordpress.org/trunk@35097


git-svn-id: http://core.svn.wordpress.org/trunk@35062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:03:25 +00:00
Sergey Biryukov
b30dcc3f62 Format the number of comments in wp-includes/embed-template.php for the locale.
Props johnbillion.
Fixes #34276.
Built from https://develop.svn.wordpress.org/trunk@35096


git-svn-id: http://core.svn.wordpress.org/trunk@35061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:02:25 +00:00
Scott Taylor
8941648ead XML-RPC: Add a filter, xmlrpc_memory_limit, to allow the value of $xmlrpc_memory_limit to be increased.
Props ankit.gade.
Fixes #29957.

Built from https://develop.svn.wordpress.org/trunk@35095


git-svn-id: http://core.svn.wordpress.org/trunk@35060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:01:24 +00:00
Drew Jaynes
bcc7f8d079 Plugins: Introduce the delete_plugin transactional hook, which fires immediately after a plugin deletion attempt occurs.
Props Veraxus for the initial patch.
Fixes #26904.

Built from https://develop.svn.wordpress.org/trunk@35094


git-svn-id: http://core.svn.wordpress.org/trunk@35059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 00:57:25 +00:00
Drew Jaynes
ad6a1303dc Login: Pass the username and WP_User object to the retrieve_password_title filter.
Adding these parameters creates parity with the `retrieve_password_message` filter, used for modifying the message body of the same password reset email.

Props sudar.
Fixes #34252.

Built from https://develop.svn.wordpress.org/trunk@35093


git-svn-id: http://core.svn.wordpress.org/trunk@35058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 00:51:24 +00:00
Sergey Biryukov
7ef095171a In number_format_i18n(), check if $wp_locale is set before using it.
Props pauldewouters.
Fixes #31553.
Built from https://develop.svn.wordpress.org/trunk@35092


git-svn-id: http://core.svn.wordpress.org/trunk@35057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 00:30:24 +00:00
Sergey Biryukov
e6987f3c31 Correct the post_date format in WP_Date_Query tests.
It should be `'Y-m-d H:i:s'` in order to match the regex in `get_gmt_from_date()` if `'timezone_string'` option is not set.

Props pbearne.
Fixes #34277.
Built from https://develop.svn.wordpress.org/trunk@35091


git-svn-id: http://core.svn.wordpress.org/trunk@35056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 23:40:24 +00:00
John Blackbourn
00388a1dbf Add missing @since params and update the docs for site_icon_url() and has_site_icon().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35090


git-svn-id: http://core.svn.wordpress.org/trunk@35055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 23:28:24 +00:00