Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-10 21:00:59 +01:00
Code Issues Projects Releases Wiki Activity
21,532 Commits 50 Branches 747 Tags 791 MiB
46a8e6e3de
Commit Graph

78 Commits

Author SHA1 Message Date
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Andrew Nacin
557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987. 
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-25 05:26:19 +00:00
nacin
95ab5d397e Anchor a regular expression in wp-mail.php to ensure we are matching the Reply-To: header, not the In-Reply-To: header. 
Per RFCs *822, mail headers must start at the beginning of a line. This same pattern could be continued throughout this file.

props solarissmoke.
fixes #18923.



git-svn-id: http://core.svn.wordpress.org/trunk@20682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-02 13:32:19 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
ryan
ec4ccf2900 Deprecate get_userdatabylogin() and get_user_by_email(). Props scribu. fixes #18333 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-05 16:57:31 +00:00
ryan
1a552dd029 Strip trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 02:42:15 +00:00
nacin
1d8718e03d Adjust POP3 error checks in wp-mail.php. props solarissmoke, fixes #13163. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-08 19:34:59 +00:00
dd32
442d41291a Tweak new strings for better typography. Props demetris. Fixes #12962 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-11 10:41:54 +00:00
westi
3e4ce6e9a3 Switch from POST_BY_EMAIL constant to enable post-by-email when multisite to a filter. See #12381. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-25 22:06:10 +00:00
ryan
9f1aa91f37 Integrate maybe_cancel_post_by_email() into wp-mail.php. see #11644 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-26 20:53:59 +00:00
westi
ad83f73957 Make the action name for post-by-email takeover actually unique so the plugins are not triggered every time WP tries to send an email! 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-18 20:43:05 +00:00
westi
8772775a15 Post by Email plugins might want to use there own POP3 class so move the action earlier. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-10 20:05:24 +00:00
westi
91582e7d2c Allow a plugin to do a complete takeover of Post by Email 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-28 07:18:05 +00:00
westi
46ffb5bbbc Allow a plugin to do a complete takeover of Post by Email 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-28 07:17:03 +00:00
westi
45ec67dc13 Set the interval to 5 minutes like I meant. See #7245 props aaroncampbell. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-07 17:11:39 +00:00
westi
1199fd75f0 Limit wp-mail blog by email checks to every 5 minutes. Fixes #7245 based on patches from lilyfan and Denis-de-Bernardy. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-06 19:58:47 +00:00
markjaquith
119b39cec2 deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-18 15:11:07 +00:00
azaozz
83f674bf9a Banishing ASCII quotes and apostrophes, props demetris, fixes #9655 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-05 04:28:05 +00:00
ryan
47aa41a9e6 Don't absint gmt_offset. Props Hirvine. fixes #9162 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-23 07:03:21 +00:00
ryan
e8b6fe7347 Trim trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-18 02:43:45 +00:00
westi
48f9d53e41 Add a filter to allow post-by-email plugins better control over the content. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-22 22:31:27 +00:00
ryan
e89192b1a8 Strip trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-09 18:03:31 +00:00
westi
84867318d6 Improve wp-mail utf8 support. Fixes #6788 props filosofo. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-02 18:40:16 +00:00
ryan
0f33f00e43 Localization for wp-mail. Props filosofo. fixes #8051 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-03 23:35:34 +00:00
ryan
23feb0523b Revert POP3 changes. Localization for wp-mail. Props filosofo. see #8051 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-03 23:25:11 +00:00
westi
00583d64eb Performance improvements using strpos. Fixes #7611 and #7610 props johnbillion. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-27 20:47:01 +00:00
westi
ec5a60f0cf Remove setting of error_reporting and just use the default WordPress error_reporting settings. Fixes #7035 props jacobsantos. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-07-29 19:56:38 +00:00
ryan
a6a1522a8d File file level phpdoc from jacobsantos. see #7037 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-25 15:50:15 +00:00
ryan
5b8113578d Allow wp-config.php to exist one level up from WordPress root directory. Props sambauers. fixes #6933 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-21 05:59:27 +00:00
ryan
eabc128c41 Don't echo content. Props xknown. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-29 19:38:33 +00:00
ryan
baf6e7b6ae Don't echo posted content. Specialchars all other displayed info. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-29 19:20:15 +00:00
ryan
6d6280b7a2 Add some sanitization 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-27 08:08:11 +00:00
ryan
b7f907b875 Escape pop3 error messages. Props xknown. fixes #5484 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-18 20:06:37 +00:00
westi
80f85b53e3 Ensure wp-mail doesn't issue a 500 error if no messages are available to post. Fixed #5420 props Bobcat 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-05 07:39:07 +00:00
ryan
a7c0525870 When posting by email, publish only if user has publish caps, otherwise set status to pending. Props Bobcat. fixes #4642 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-11-29 05:51:09 +00:00
ryan
a92c487cc0 Fix email address parsing in wp-mail.php. Props Bobcat. fixes #5169 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-10-21 06:18:59 +00:00
markjaquith
88735ac45a Strip From/Reply-To from e-mail before sanitizing in wp-mail.php. Props Bobcat. fixes #5169 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-10-10 16:46:20 +00:00
markjaquith
1b7798d214 Properly sanitize e-mail addresses in wp-mail.php. Props giannis1. fixes #5169 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-10-09 22:15:37 +00:00
ryan
9bfccd6286 Add checks for WP_Error. Props filosofo. see #4809 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-09-18 16:32:22 +00:00
markjaquith
6ecaec3d1f Skip deprecated option replacement in wp-mail.php. props Nazgul. fixes #4924 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-09-07 02:07:13 +00:00
ryan
645bbfa324 Formatting cleanups from johnjosephbachir. fixes #4775 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-19 22:25:44 +00:00
ryan
2f09416258 Trim empty lines. Nothing but newline. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-14 02:25:30 +00:00
rob1n
b6fc2cacce Add in missing delimiter. fixes #4226 for 2.0, 2.2 and 2.3 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-05-05 02:51:20 +00:00
rob1n
7068240303 Add support to wp-mail.php for quoted-printable Content-Transfer-Encoding. Props Nazgul. fixes #2460 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-04-06 02:57:46 +00:00
matt
3d21925922 Ryan slays the dragon. (Some of these return WP_Error objects.) 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-03-23 02:05:29 +00:00
matt
7602d17899 (int)er the dragon. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-03-23 00:59:21 +00:00
ryan
849a0d29d7 Use get_option instead of get_settings. Just 'cause. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-08-30 21:46:31 +00:00
ryan
4e5380a24a wp_die() improvements from Sewar. fixes #2902 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-07-10 05:29:10 +00:00
ryan
42557940a1 Use wp_die(). Props filosofo. fixes #2914 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-07-05 22:00:03 +00:00