Sergey Biryukov
be718ee860
Declare the variable before using it.
...
props danielbachhuber.
fixes #28932 .
Built from https://develop.svn.wordpress.org/trunk@29215
git-svn-id: http://core.svn.wordpress.org/trunk@28999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 22:01:14 +00:00
Scott Taylor
fa02568c42
Merge wp_handle_upload()
and wp_handle_sideload()
by making them each wrap a new function: _wp_handle_upload()
.
...
Props DrewAPicture for docs.
Fixes #23686 .
Built from https://develop.svn.wordpress.org/trunk@29209
git-svn-id: http://core.svn.wordpress.org/trunk@28993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 18:58:44 +00:00
Drew Jaynes
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Scott Taylor
d395142fb9
In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
...
Props joedolson.
Fixes #28853 .
Built from https://develop.svn.wordpress.org/trunk@29201
git-svn-id: http://core.svn.wordpress.org/trunk@28985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:50:14 +00:00
Drew Jaynes
9ae01ba532
Fix a typo in the @access
tag for WP_List_Table::__get()
.
...
Props joehoyle.
Fixes #28925 . See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29199
git-svn-id: http://core.svn.wordpress.org/trunk@28983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 22:13:14 +00:00
Andrew Nacin
4bf7cdd49b
DB schema change: Add comment_author_email(10) index.
...
props tellyworth, pento.
fixes #21435 .
Built from https://develop.svn.wordpress.org/trunk@29188
git-svn-id: http://core.svn.wordpress.org/trunk@28972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-16 15:54:16 +00:00
Scott Taylor
043715e8a4
Add a new AJAX action: parse-media-shortcode
. This async call will replace JS rendering of audio/video/playlist shortcodes.
...
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29178
git-svn-id: http://core.svn.wordpress.org/trunk@28962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 22:08:14 +00:00
Scott Taylor
89d9bbd7f6
Make audio and video URLs/embed handlers work in <iframe>
-sandbox'd MCE views.
...
Introduce:
`get_editor_stylesheets()`
`wp_media_mce_styles()`.
See #28905 .
Built from https://develop.svn.wordpress.org/trunk@29176
git-svn-id: http://core.svn.wordpress.org/trunk@28960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 21:51:15 +00:00
Dominik Schilling
1ecb1f0e8b
Remove unused variable in WP_Theme_Install_List_Table::install_theme_info()
. Unused since [26380].
...
props Corphi.
fixes #28749 .
Built from https://develop.svn.wordpress.org/trunk@29173
git-svn-id: http://core.svn.wordpress.org/trunk@28957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 20:28:15 +00:00
Dominik Schilling
d8ffbb19fc
Remove plugin_install_details_link
filter, which was added in [29047].
...
see #28785 .
Built from https://develop.svn.wordpress.org/trunk@29171
git-svn-id: http://core.svn.wordpress.org/trunk@28955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 19:50:14 +00:00
Dominik Schilling
57c914f75a
Customizer: Add meta capability customize
which is mapped to edit_theme_options
.
...
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.
props westonruter, nacin.
fixes #28605 .
Built from https://develop.svn.wordpress.org/trunk@29170
git-svn-id: http://core.svn.wordpress.org/trunk@28954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 19:01:16 +00:00
Scott Taylor
c3b068a599
Missed one: WP_MS_Sites_List_Table::display_rows()
must be public
.
...
Props extendwings.
Fixes #28894 .
Built from https://develop.svn.wordpress.org/trunk@29166
git-svn-id: http://core.svn.wordpress.org/trunk@28950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 15:42:15 +00:00
Drew Jaynes
3665b5a1a1
Add periods to short descriptions for magic methods added in [28501], [28521], and [28524].
...
See #22234 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29165
git-svn-id: http://core.svn.wordpress.org/trunk@28949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 01:12:14 +00:00
Drew Jaynes
204a4bc6bf
Inline documentation cleanup for 4.0 audit.
...
* phpDoc tweaks for `wp_get_available_translations_from_api()`, `wp_install_download_language_pack()`, and `wp_install_load_language()`, added in [29018]
See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29154
git-svn-id: http://core.svn.wordpress.org/trunk@28938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:17:15 +00:00
Drew Jaynes
79a4fd8fef
Inline documentation for the 'plugin_install_details_link' hook added in [29047] should use a 3-digit, x.x.x-style @since
version.
...
See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29152
git-svn-id: http://core.svn.wordpress.org/trunk@28936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:10:15 +00:00
Drew Jaynes
b8d47f48c5
Inline documentation cleanup for 4.0 audit.
...
* Alignment for the 'term_search_min_chars' hook docs, added in [28892]
* Globals added for `wp_ajax_parse_embed()`, added [28580]
See #28885 .
Built from https://develop.svn.wordpress.org/trunk@29151
git-svn-id: http://core.svn.wordpress.org/trunk@28935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 00:06:15 +00:00
Drew Jaynes
90d7cc27c2
Fill out inline documentation for magic methods added to the WP_List_Table
class in [28493], [28521], and [28524].
...
See #22234 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29148
git-svn-id: http://core.svn.wordpress.org/trunk@28932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 23:55:16 +00:00
Drew Jaynes
e923e70d86
Fill out inline documentation for magic methods added to the WP_Filesystem_Base
class in [28521].
...
See #22234 and #28885 .
Built from https://develop.svn.wordpress.org/trunk@29147
git-svn-id: http://core.svn.wordpress.org/trunk@28931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 23:52:14 +00:00
Scott Taylor
176b9b2301
Fix mismatches in access modifiers for WP_List_Table
+ subclasses.
...
Fixes #28843 , #28879 .
Built from https://develop.svn.wordpress.org/trunk@29137
git-svn-id: http://core.svn.wordpress.org/trunk@28921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 22:09:16 +00:00
Dominik Schilling
6ef23ea006
Lists View Switcher: Replace blank image with screen reader text.
...
props davidakennedy.
fixes #28871 .
Built from https://develop.svn.wordpress.org/trunk@29133
git-svn-id: http://core.svn.wordpress.org/trunk@28918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 11:05:15 +00:00
Dominik Schilling
e398ae8161
Remove unused variable in wp_dashboard_plugins_output()
. Unused since [26144].
...
props michalzuber.
see #28872 .
Built from https://develop.svn.wordpress.org/trunk@29130
git-svn-id: http://core.svn.wordpress.org/trunk@28915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 10:31:16 +00:00
Dominik Schilling
8cbada97be
Improvements to the plugin information modal:
...
* Whitespace/braces cleanup for [29040].
* Reduce width of modal to 792px, which is the default banner size.
* Reduce banner height when screen height is smaller than 500px.
* Remove inline CSS.
* Re-use tab var in JS.
* Encode ampersands in links.
props avryl, michalzuber, ocean90.
see #27440 .
Built from https://develop.svn.wordpress.org/trunk@29125
git-svn-id: http://core.svn.wordpress.org/trunk@28910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-12 22:08:16 +00:00
Sergey Biryukov
60a0b3b17d
Use correct ID for plugin search input label.
...
Make the search button name and ID consistent with the ones in WP_List_Table::search_box().
props joedolson.
fixes #28856 .
Built from https://develop.svn.wordpress.org/trunk@29123
git-svn-id: http://core.svn.wordpress.org/trunk@28908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-12 17:45:15 +00:00
Scott Taylor
40725e9e67
Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.
...
Props SergeyBiryukov.
See #28843 and [28583].
Built from https://develop.svn.wordpress.org/trunk@29118
git-svn-id: http://core.svn.wordpress.org/trunk@28904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-12 03:27:14 +00:00
Scott Taylor
59ffcf668b
Media Grid, for audio files:
...
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`
See #28839 .
Built from https://develop.svn.wordpress.org/trunk@29104
git-svn-id: http://core.svn.wordpress.org/trunk@28890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 20:55:15 +00:00
Sergey Biryukov
cca7157c0d
Escape taxonomy name when used in attributes in post_categories_meta_box().
...
props pbearne.
fixes #28836 .
Built from https://develop.svn.wordpress.org/trunk@29099
git-svn-id: http://core.svn.wordpress.org/trunk@28885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 18:56:16 +00:00
Scott Taylor
b16d3bd6ad
Media Grid: make registering Screen Options for non-list tables more generic.
...
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29079
git-svn-id: http://core.svn.wordpress.org/trunk@28865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:44:16 +00:00
Scott Taylor
a9fb59151b
Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun.
...
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29078
git-svn-id: http://core.svn.wordpress.org/trunk@28864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:26:16 +00:00
Scott Taylor
a89060013b
Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
...
See #24716 .
Built from https://develop.svn.wordpress.org/trunk@29077
git-svn-id: http://core.svn.wordpress.org/trunk@28863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:00:17 +00:00
Andrew Nacin
e9d2d8ead9
Unload the current default textdomain in wp_install_load_language().
...
see #28577 .
Built from https://develop.svn.wordpress.org/trunk@29059
git-svn-id: http://core.svn.wordpress.org/trunk@28847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 09:55:14 +00:00
Helen Hou-Sandí
a180b44763
Display plugin install results as "cards" rather than in a list table, first run.
...
props stephdau, ryelle, tellyworth, melchoyce. see #28785 , #28646 .
Built from https://develop.svn.wordpress.org/trunk@29047
git-svn-id: http://core.svn.wordpress.org/trunk@28835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-09 20:02:14 +00:00
Helen Hou-Sandí
2dfccee78f
Improvements to the plugin information modal:
...
* Show the banner image when available.
* Show contributors and ratings breakdown in the FYI box.
* Show reviews in a tab.
props stephdau, tellyworth, paulwilde, michalzuber. see #27440 . fixes #19784 , #22599 , #26202 .
Built from https://develop.svn.wordpress.org/trunk@29040
git-svn-id: http://core.svn.wordpress.org/trunk@28828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-09 17:28:17 +00:00
Drew Jaynes
b10e168751
Add @see
reference for set_post_thumbnail()
in the phpDoc for wp_ajax_set_attachment_thumbnail()
.
...
See #27891 .
Built from https://develop.svn.wordpress.org/trunk@29037
git-svn-id: http://core.svn.wordpress.org/trunk@28825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 20:36:13 +00:00
Scott Taylor
57dbc55e6e
When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well.
...
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.
Fixes #27891 .
Built from https://develop.svn.wordpress.org/trunk@29029
git-svn-id: http://core.svn.wordpress.org/trunk@28817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 17:48:17 +00:00
John Blackbourn
d237bc419d
Narrower layout and loading spinner for the install screen language selector. See #28577
...
Built from https://develop.svn.wordpress.org/trunk@29021
git-svn-id: http://core.svn.wordpress.org/trunk@28809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 00:33:15 +00:00
John Blackbourn
64f686b4c8
Focus and blur styling (via JS) for the install screen language selector. Props jorbin. See #28577
...
Built from https://develop.svn.wordpress.org/trunk@29020
git-svn-id: http://core.svn.wordpress.org/trunk@28808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 00:30:14 +00:00
Andrew Nacin
bc47136605
Language on install: Docs and naming cleanups. see #28577 .
...
Built from https://develop.svn.wordpress.org/trunk@29018
git-svn-id: http://core.svn.wordpress.org/trunk@28806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-07 21:49:15 +00:00
John Blackbourn
ea46c7423a
Correct the usage of the variable passed to wp_install_download_language_pack()
and kill an unused local variable. Props michalzuber. Also avoid using the $_REQUEST
superglobal in this function. See #28577 .
...
Built from https://develop.svn.wordpress.org/trunk@29016
git-svn-id: http://core.svn.wordpress.org/trunk@28804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-07 18:06:15 +00:00
Andrew Nacin
7a1351b411
Bring the language chooser to setup-config.php.
...
see #28577 .
Built from https://develop.svn.wordpress.org/trunk@29006
git-svn-id: http://core.svn.wordpress.org/trunk@28794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-05 05:14:15 +00:00
Sergey Biryukov
4b7a9edd27
Reinstate 'install_themes_tabs' filter.
...
props ghost1227.
fixes #28578 .
Built from https://develop.svn.wordpress.org/trunk@29002
git-svn-id: http://core.svn.wordpress.org/trunk@28790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-04 23:58:15 +00:00
Drew Jaynes
eedd151405
Note in the hook docs for preview_post_link
that the $post
parameter was added.
...
See #28729 .
Built from https://develop.svn.wordpress.org/trunk@28979
git-svn-id: http://core.svn.wordpress.org/trunk@28768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 20:05:14 +00:00
Drew Jaynes
d4dd02b4ae
Remove backticks on $post
variables in some short parameter descriptions.
...
See [28653], [28654].
See #28388 .
Built from https://develop.svn.wordpress.org/trunk@28976
git-svn-id: http://core.svn.wordpress.org/trunk@28765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 19:28:14 +00:00
Drew Jaynes
0ac4474ce4
Fix an incomplete docblock for wp_create_categories()
as part of $post/$post_id
cleanup.
...
See #28388 .
Built from https://develop.svn.wordpress.org/trunk@28975
git-svn-id: http://core.svn.wordpress.org/trunk@28764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 19:22:15 +00:00
John Blackbourn
38749f273c
Use the admin scheme for theme preview URLs when installing new themes. See #21919 .
...
Built from https://develop.svn.wordpress.org/trunk@28974
git-svn-id: http://core.svn.wordpress.org/trunk@28763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 18:48:16 +00:00
Helen Hou-Sandí
5f6b531f70
Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for oembed_ttl
.
...
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.
oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.
The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.
Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.
As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.
props markjaquith. fixes #14759 . see #17210 .
Built from https://develop.svn.wordpress.org/trunk@28972
git-svn-id: http://core.svn.wordpress.org/trunk@28761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 16:45:14 +00:00
Sergey Biryukov
4e75d406ec
Pass $post object to 'preview_post_link' filter.
...
props danielbachhuber.
fixes #28729 .
Built from https://develop.svn.wordpress.org/trunk@28969
git-svn-id: http://core.svn.wordpress.org/trunk@28758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 14:42:15 +00:00
Sergey Biryukov
489693cd30
Remove non-breaking spaces from auto update email text.
...
props trepmal.
fixes #28715 .
Built from https://develop.svn.wordpress.org/trunk@28956
git-svn-id: http://core.svn.wordpress.org/trunk@28752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-02 12:46:17 +00:00
Sergey Biryukov
27ba686eee
Simplify a condition in get_sample_permalink_html().
...
see #28350 .
Built from https://develop.svn.wordpress.org/trunk@28948
git-svn-id: http://core.svn.wordpress.org/trunk@28745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-02 00:11:15 +00:00
Sergey Biryukov
fc24029d65
Simplify logic in get_sample_permalink_html(), remove duplicated code.
...
see #28350 .
Built from https://develop.svn.wordpress.org/trunk@28947
git-svn-id: http://core.svn.wordpress.org/trunk@28744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-02 00:04:15 +00:00
Sergey Biryukov
16bb742b66
Display a correct preview link for drafts when permalinks are disabled.
...
see #28350 .
Built from https://develop.svn.wordpress.org/trunk@28946
git-svn-id: http://core.svn.wordpress.org/trunk@28743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-01 23:56:14 +00:00