Commit Graph

524 Commits

Author SHA1 Message Date
Scott Taylor
b7812bd416 AJAX: add a new function, wp_doing_ajax(), which can replace... (wait for it...) DOING_AJAX checks via the constant.
Props Mte90, sebastian.pisula, swissspidy.
Fixes #25669.

Built from https://develop.svn.wordpress.org/trunk@38334


git-svn-id: http://core.svn.wordpress.org/trunk@38275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-23 14:33:30 +00:00
Drew Jaynes
6c7148943b Docs: Standardize capitalization of Ajax throughout core documentation per the core spelling guide.
Ajax, while considered an acronym for Asynchronous JavaScript and XML, is most commonly capitalized only in the first character.

Part props ocean90.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@38028


git-svn-id: http://core.svn.wordpress.org/trunk@37969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-10 00:51:30 +00:00
Dominik Schilling
3d6fc45834 Dashboard: Don't add a "Configure" link to the toggle button.
The HTML for the toggle gets appended to the widget name which is later used for the widget title and the screen reader text of the toggle button. Storing the original widget name in the arguments allows us to use the name without the HTML for the screen reader text and doesn't require further changes by plugin developers.

Props nicholas_io, swissspidy.
Fixes #35021.
Built from https://develop.svn.wordpress.org/trunk@37972


git-svn-id: http://core.svn.wordpress.org/trunk@37913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-05 15:22:29 +00:00
Peter Wilson
47d26cd9fb DOCS: Replace HTTP links with HTTPS.
Replaces unsecure links in documentation and translator comments with their secure versions.

Props johnpgreen, netweb

Fixes #36993

Built from https://develop.svn.wordpress.org/trunk@37674


git-svn-id: http://core.svn.wordpress.org/trunk@37640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-10 04:50:33 +00:00
Drew Jaynes
1947f4d17c Docs: Apply inline @see tags to hooks referenced in DocBlocks for wp-admin/* files.
Applying these specially-crafted `@see` tags allows the Code Reference parser to recognize and link these elements as actions and filters.

See #36921.

Built from https://develop.svn.wordpress.org/trunk@37537


git-svn-id: http://core.svn.wordpress.org/trunk@37505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 17:28:27 +00:00
Drew Jaynes
c3055cc190 Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37488


git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:01:30 +00:00
Sergey Biryukov
dc5815146e Dashboard: Display the comment counts in wp_dashboard_right_now() in the rare initial condition when there are 0 approved comments and only pending comments, so the AJAX count update could work.
Props afercia.
Fixes #35519.
Built from https://develop.svn.wordpress.org/trunk@37335


git-svn-id: http://core.svn.wordpress.org/trunk@37301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-01 11:06:28 +00:00
Scott Taylor
be59d289b7 Dashboard: toggle the "View" link for comments when Approving / Unapproving from the Dashboard widget.
Fixes #35518.

Built from https://develop.svn.wordpress.org/trunk@37302


git-svn-id: http://core.svn.wordpress.org/trunk@37268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-22 21:30:28 +00:00
Andrea Fercia
fd1f45a7cf Accessibility: Improve accessibility for the Plugin details modal.
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.
Built from https://develop.svn.wordpress.org/trunk@36964


git-svn-id: http://core.svn.wordpress.org/trunk@36932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 22:37:26 +00:00
Drew Jaynes
d59fdfd951 Docs: Add a missing @since version to the DocBlock for wp_add_dashboard_widget().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36878


git-svn-id: http://core.svn.wordpress.org/trunk@36845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-07 22:17:26 +00:00
Sergey Biryukov
b80a516549 Docs: Add wp_add_dashboard_widget() parameter descriptions.
Props meitar for initial patch.
Fixes #36092.
Built from https://develop.svn.wordpress.org/trunk@36868


git-svn-id: http://core.svn.wordpress.org/trunk@36835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-06 12:08:28 +00:00
Drew Jaynes
5c8a9e68b6 Docs: Add a more descriptive changelog entry to the hook doc for the privacy_on_link_title filter.
See #35049. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36823


git-svn-id: http://core.svn.wordpress.org/trunk@36790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-03 08:56:26 +00:00
Sergey Biryukov
5ed4b4ed7b I18N: Remove HTML tags from translatable string in wp-admin/includes/dashboard.php.
Props ramiy, SergeyBiryukov.
Fixes #36013.
Built from https://develop.svn.wordpress.org/trunk@36793


git-svn-id: http://core.svn.wordpress.org/trunk@36760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-01 01:39:27 +00:00
Andrea Fercia
9308ec9513 Comments: Add missing placeholder for printf() after [36683].
Fixes #35392.
Built from https://develop.svn.wordpress.org/trunk@36767


git-svn-id: http://core.svn.wordpress.org/trunk@36734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-28 21:39:26 +00:00
Andrea Fercia
43b722b8fc Accessibility: improve accessibility of the Dashboard "Recent Comments" widget.
- Makes the list of comments a list
- Always displays the title of the post the comment relates to, linked to the post itself and no more to the Edit screen
- Headings: changes the visible one in "Recent Comments" and adds a hidden "View more comments" heading before the views links
- Adds the pending status indicator to Pingbacks and Trackbacks

Props rachelbaker, afercia.

Fixes #35392.
Built from https://develop.svn.wordpress.org/trunk@36683


git-svn-id: http://core.svn.wordpress.org/trunk@36650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-24 16:07:26 +00:00
Drew Jaynes
26bf8cda9b Docs: Add more complete information to DocBlocks for private core functions _wp_dashboard_control_callback() and _wp_dashboard_recent_comments_row().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36474


git-svn-id: http://core.svn.wordpress.org/trunk@36441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-03 20:20:26 +00:00
John Blackbourn
a4facedfee Docs: Various docblock corrections.
See #32246

Built from https://develop.svn.wordpress.org/trunk@36250


git-svn-id: http://core.svn.wordpress.org/trunk@36217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-10 01:26:25 +00:00
Andrea Fercia
b4cc1cfc48 Accessibility: Remove title attributes from the Admin Dashboard.
Uses `aria-label` and `screen-reader-text` where appropriate. Also removes
the default title attribute output by `privacy_on_link_title`, preserving
the ability to use the filter.

Fixes #35049.
Built from https://develop.svn.wordpress.org/trunk@36172


git-svn-id: http://core.svn.wordpress.org/trunk@36139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-05 14:19:28 +00:00
Sergey Biryukov
34ce39c782 List tables: After [34006], remove unnecessary context from 'View' string, for consistency with other strings in the same context.
Props MikeHansenMe, subharanjan.
Fixes #34914.
Built from https://develop.svn.wordpress.org/trunk@35900


git-svn-id: http://core.svn.wordpress.org/trunk@35864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 18:37:26 +00:00
Pascal Birchler
54b8c3e53b Docs: Fix some minor DocBlock alignment issues.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35885


git-svn-id: http://core.svn.wordpress.org/trunk@35849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 15:37:28 +00:00
Pascal Birchler
ba9475786a Dashboard: Do not show "Search Engines Discouraged" text when the blog_public option is not set.
Search engines are only discouraged from indexing the site when the option is explicitly set to `0`.

Fixes #34860.
Built from https://develop.svn.wordpress.org/trunk@35873


git-svn-id: http://core.svn.wordpress.org/trunk@35837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:03:26 +00:00
Ella Iseulde Van Dorpe
657d3b50af Make date format consistent across the admin
The 'date_format' and 'time_format' options shouldn't affect the backend.

See #30864


Built from https://develop.svn.wordpress.org/trunk@35811


git-svn-id: http://core.svn.wordpress.org/trunk@35775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 04:26:27 +00:00
Sergey Biryukov
bfbd9e3ec3 Don't use <a> in translatable strings in `wp-admin/includes/dashboard.php'.
Add translator commments.

Props ramiy.
Fixes #34501.
Built from https://develop.svn.wordpress.org/trunk@35443


git-svn-id: http://core.svn.wordpress.org/trunk@35407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:33:25 +00:00
Scott Taylor
843d1c003b Dashboard: make tags used for headings more semantic.
Props Cheffheid, afercia.
Fixes #33558.

Built from https://develop.svn.wordpress.org/trunk@35414


git-svn-id: http://core.svn.wordpress.org/trunk@35378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 17:57:25 +00:00
Scott Taylor
b0561ed6e4 Dashboard: use the create_posts cap on the post type object when determining if the Quick Press widget can be displayed.
Props jim912, ocean90, chriscct7.
Fixes #25681.

Built from https://develop.svn.wordpress.org/trunk@35282


git-svn-id: http://core.svn.wordpress.org/trunk@35248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:49:24 +00:00
Drew Jaynes
c6bffb6264 Docs: Fix some minor formatting in the $query_args parameter description for the `` filter doc.
See #8243. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35004


git-svn-id: http://core.svn.wordpress.org/trunk@34969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:39:24 +00:00
Drew Jaynes
504ff07656 Dashboard: Introduce the dashboard_recent_drafts_query_args filter, making it possible to manipulate the post query arguments used in the 'Recent Drafts' dashboard widget.
Props iamfriendly.
Fixes #8243.

Built from https://develop.svn.wordpress.org/trunk@35003


git-svn-id: http://core.svn.wordpress.org/trunk@34968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:33:25 +00:00
Sergey Biryukov
dfc4654172 Dashboard: Display year in Activity widget if the post date year is not the same as the current one.
Props GaryJ, chriscct7.
Fixes #26502.
Built from https://develop.svn.wordpress.org/trunk@34980


git-svn-id: http://core.svn.wordpress.org/trunk@34945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 04:26:24 +00:00
Jeremy Felt
9926983b66 Revert [34778], continue using _site_option() for the current network.
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@34912


git-svn-id: http://core.svn.wordpress.org/trunk@34877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 17:11:25 +00:00
John Blackbourn
815635548a Switch the remaining user-facing links to wordpress.org over to HTTPS.
Fixes #27115

Built from https://develop.svn.wordpress.org/trunk@34783


git-svn-id: http://core.svn.wordpress.org/trunk@34748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 22:46:28 +00:00
Jeremy Felt
54512d64cb MS: Use *_network_option() functions throughout core.
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.

Built from https://develop.svn.wordpress.org/trunk@34778


git-svn-id: http://core.svn.wordpress.org/trunk@34743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 19:08:26 +00:00
John Blackbourn
aa35e473f7 callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead.
Fixes #34032

Built from https://develop.svn.wordpress.org/trunk@34566


git-svn-id: http://core.svn.wordpress.org/trunk@34530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 23:58:25 +00:00
Drew Jaynes
3229785656 Docs: Fix the syntax for a mid-file sectional comment in wp-admin/includes/dashboard.php.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@34565


git-svn-id: http://core.svn.wordpress.org/trunk@34529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 22:51:24 +00:00
Drew Jaynes
115c382132 Docs: Remove an inline comment duplicated by the DocBlock summary for wp_dashboard_trigger_widget_control().
Props tyxla.
Fixes #34014.

Built from https://develop.svn.wordpress.org/trunk@34564


git-svn-id: http://core.svn.wordpress.org/trunk@34528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 22:50:26 +00:00
Scott Taylor
5b9af35c4c Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget.
Fixes #10422.

Built from https://develop.svn.wordpress.org/trunk@34500


git-svn-id: http://core.svn.wordpress.org/trunk@34464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 15:53:25 +00:00
Scott Taylor
3c1e05f7c9 Dashboard: 2 submit buttons don't need names.
Props garyc40, gizburdt.
Fixes #16345.

Built from https://develop.svn.wordpress.org/trunk@34382


git-svn-id: http://core.svn.wordpress.org/trunk@34346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 05:45:26 +00:00
Scott Taylor
58c3c30e8d After [33961], pass $comment to comment_class() where possible to avoid extra cache/db lookups.
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34040


git-svn-id: http://core.svn.wordpress.org/trunk@34008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:12:24 +00:00
Scott Taylor
4465a83b95 After [34015], handle orphaned comments in the Dashboard comments widget. Pass full $comment versus just passing the comment ID when possible.
See #33710.

Built from https://develop.svn.wordpress.org/trunk@34038


git-svn-id: http://core.svn.wordpress.org/trunk@34006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 05:56:24 +00:00
Scott Taylor
6e22d94488 Add a "View" row action for approved comments on the Dashboard screen, remove the link labeled #.
Props rachelbaker, zeo.
Fixes #18885. 

Built from https://develop.svn.wordpress.org/trunk@34006


git-svn-id: http://core.svn.wordpress.org/trunk@33975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 17:49:24 +00:00
Sergey Biryukov
c65f37f892 Correct description for version and current_version parameters in wp_check_browser_version() response.
Props extendwings.
Fixes #33753.
Built from https://develop.svn.wordpress.org/trunk@33932


git-svn-id: http://core.svn.wordpress.org/trunk@33901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 00:17:24 +00:00
Scott Taylor
e73ee5ac98 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33891


git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 18:17:24 +00:00
Sergey Biryukov
43194cea1c Add 'dashboard_secondary_items' filter for the number of secondary link items in the 'WordPress News' dashboard widget.
props MikeHansenMe, DrewAPicture.
fixes #31434.
Built from https://develop.svn.wordpress.org/trunk@33833


git-svn-id: http://core.svn.wordpress.org/trunk@33801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 21:57:21 +00:00
Scott Taylor
ef87172270 foreach is a statement, not a function.
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33734


git-svn-id: http://core.svn.wordpress.org/trunk@33702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-25 20:28:22 +00:00
Gary Pendergast
fe5a844be5 Capabilities: When creating an auto-draft, ensure that the current user still has permission to do so.
Built from https://develop.svn.wordpress.org/trunk@33357


git-svn-id: http://core.svn.wordpress.org/trunk@33329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 04:02:25 +00:00
John Blackbourn
f3eba1581c Place the locale inside the md5 hash in the dashboard RSS feed widget transient key to prevent the transient timeout option name becoming longer than the allowed field size.
Props andg
Fixes #32804

Built from https://develop.svn.wordpress.org/trunk@33192


git-svn-id: http://core.svn.wordpress.org/trunk@33164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 15:32:25 +00:00
John Blackbourn
1f7a3bc58d Append the current locale to dashboard RSS widget cache keys so they refresh accordingly when the locale is changed.
Fixes #32804
Props andg

Built from https://develop.svn.wordpress.org/trunk@33183


git-svn-id: http://core.svn.wordpress.org/trunk@33155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-12 22:07:25 +00:00
Helen Hou-Sandí
0b046085ae Show row actions on focus for the dashboard comment list.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33106


git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:26:24 +00:00
Scott Taylor
42d51a4f89 Add doc blocks to functions that are missing them.
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32672


git-svn-id: http://core.svn.wordpress.org/trunk@32642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 03:18:25 +00:00
Scott Taylor
b3e0cfd25d Add (more) missing doc blocks to wp-admin/includes/*.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32655


git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:17:27 +00:00
Scott Taylor
a51dfa3971 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.

Built from https://develop.svn.wordpress.org/trunk@32653


git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 17:04:26 +00:00
Scott Taylor
b56b9b3e5c Add @global annotations for wp-admin/*.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Scott Taylor
19b8ef0c92 get_comments() can return int, so a few places need to check if the return value is traversable before passing what is assumed to be an array.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32600


git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:59:25 +00:00
Gary Pendergast
e3f1f8fed1 Ensure post titles are correctly escaped on the Dashboard.
Props helen, ocean90, dd32, pento.


Built from https://develop.svn.wordpress.org/trunk@32175


git-svn-id: http://core.svn.wordpress.org/trunk@32150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 07:39:25 +00:00
Dominik Schilling
64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Jeremy Felt
7644e68119 Provide proper label associations and descriptions throughout the network admin
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.

Built from https://develop.svn.wordpress.org/trunk@31517


git-svn-id: http://core.svn.wordpress.org/trunk@31498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 02:29:26 +00:00
Sergey Biryukov
8eb25609e9 Dashboard: Add a filter for the query arguments used for the Recent Posts widget.
props danielbachhuber.
fixes #29374.
Built from https://develop.svn.wordpress.org/trunk@31508


git-svn-id: http://core.svn.wordpress.org/trunk@31489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:57:24 +00:00
Scott Taylor
7f8b548df1 In HTML5, the action attribute is no longer required. Remove this attribute when empty.
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 04:16:24 +00:00
Sergey Biryukov
9b0e279e82 In dashboard activity widget, display a front-end link if the user cannot edit the post.
props UaMV, DrewAPicture.
fixes #29025.
Built from https://develop.svn.wordpress.org/trunk@31075


git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 00:26:22 +00:00
Scott Taylor
5e3a64e83d Correct some types in wp-admin/*-location files' doc blocks.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30203


git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 07:09:23 +00:00
Mark Jaquith
184fa46699 Use HTTPS links for planet.wordpress.org
see #27115
Built from https://develop.svn.wordpress.org/trunk@29787


git-svn-id: http://core.svn.wordpress.org/trunk@29559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 13:24:15 +00:00
Mark Jaquith
28bf972789 Show the number of approved comments instead of all comments on
the dashboard in the "At a glance" section.

fixes #26738. props benjmay
Built from https://develop.svn.wordpress.org/trunk@29785


git-svn-id: http://core.svn.wordpress.org/trunk@29557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 12:42:16 +00:00
Scott Taylor
19db9a253d wp_dashboard_cached_rss_widget() contained some func_get_args() code that was indescribably weird.
This keeps it weird, but makes sure that `$check_urls` gets passed to the callback.

Props michalzuber, ocean90.
Fixes #28872.

Built from https://develop.svn.wordpress.org/trunk@29442


git-svn-id: http://core.svn.wordpress.org/trunk@29220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-07 21:47:16 +00:00
Sergey Biryukov
4078e14d1e QuickPress: Disable autocomplete for content, enable "Save Draft" button on load.
props morganestes, michalzuber.
fixes #27760.
Built from https://develop.svn.wordpress.org/trunk@29323


git-svn-id: http://core.svn.wordpress.org/trunk@29104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-29 15:34:16 +00:00
Drew Jaynes
097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Dominik Schilling
57c914f75a Customizer: Add meta capability customize which is mapped to edit_theme_options.
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.

props westonruter, nacin.
fixes #28605.
Built from https://develop.svn.wordpress.org/trunk@29170


git-svn-id: http://core.svn.wordpress.org/trunk@28954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-14 19:01:16 +00:00
Dominik Schilling
e398ae8161 Remove unused variable in wp_dashboard_plugins_output(). Unused since [26144].
props michalzuber.
see #28872.
Built from https://develop.svn.wordpress.org/trunk@29130


git-svn-id: http://core.svn.wordpress.org/trunk@28915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 10:31:16 +00:00
Scott Taylor
812ea43343 Don't use variable variables in wp_dashboard_plugins_output(). Variable variables aren't the worst thing about this function.
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28742


git-svn-id: http://core.svn.wordpress.org/trunk@28556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 18:55:14 +00:00
Scott Taylor
af860fbe84 Cleanup for switch statements:
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.


Built from https://develop.svn.wordpress.org/trunk@28633


git-svn-id: http://core.svn.wordpress.org/trunk@28452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 17:58:15 +00:00
Sergey Biryukov
d3e6a5ded0 Remove obsolete code from wp_dashboard_setup().
props kitchin.
fixes #26604.
Built from https://develop.svn.wordpress.org/trunk@28592


git-svn-id: http://core.svn.wordpress.org/trunk@28417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-27 15:41:15 +00:00
Scott Taylor
d22b5226a8 In wp_dashboard_recent_posts(), $i is set and never used.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28545


git-svn-id: http://core.svn.wordpress.org/trunk@28371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:56:15 +00:00
Scott Taylor
0e03abda62 $theme_name is set but no longer used in wp_dashboard_right_now(). The theme name is displayed with the call to update_right_now_message().
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28544


git-svn-id: http://core.svn.wordpress.org/trunk@28370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 18:54:13 +00:00
Scott Taylor
b8d469600b These functions import $wpdb but do not use it.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28539


git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:37:14 +00:00
Scott Taylor
130771a383 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28497


git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:59:15 +00:00
Scott Taylor
21379dcde0 Remove a dead variable, $start, from wp_dashboard_recent_comments().
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28263


git-svn-id: http://core.svn.wordpress.org/trunk@28091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:35:14 +00:00
Andrew Nacin
2fd8b60c22 Avoid JS errors before the commentReply script loads. Let's make this unobtrusive soon.
props aubreypwd.
fixes #24741.

Built from https://develop.svn.wordpress.org/trunk@27747


git-svn-id: http://core.svn.wordpress.org/trunk@27584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 18:53:15 +00:00
Andrew Nacin
fbd1443a0b Restore the update message in the dashboard, removed in 3.8.
props obenland.
fixes #26664.

Built from https://develop.svn.wordpress.org/trunk@27711


git-svn-id: http://core.svn.wordpress.org/trunk@27550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 14:36:15 +00:00
Drew Jaynes
0b8798684b Inline documentation for hooks in wp-admin/includes/dashboard.php.
Props mauryaratan. Props kpdesign for some minor cleanup.
Fixes #25752.

Built from https://develop.svn.wordpress.org/trunk@27669


git-svn-id: http://core.svn.wordpress.org/trunk@27512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 02:21:15 +00:00
Andrew Nacin
111e6a73be Skipping placeholders in a string will only catch translators off guard.
see #27453, #27132.

Built from https://develop.svn.wordpress.org/trunk@27613


git-svn-id: http://core.svn.wordpress.org/trunk@27456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:53:14 +00:00
John Blackbourn
80fe1b0e79 Introduce permission checks for post queries and edit links in the At a Glance dashboard widget. Fixes #27132. Props mattheu.
Built from https://develop.svn.wordpress.org/trunk@27596


git-svn-id: http://core.svn.wordpress.org/trunk@27439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:44:27 +00:00
John Blackbourn
181c2d091e Remove the "See more" toggle from the At a Glance dashboard widget. Fixes #26614.
Built from https://develop.svn.wordpress.org/trunk@27583


git-svn-id: http://core.svn.wordpress.org/trunk@27426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 12:56:14 +00:00
Andrew Nacin
6c03a28512 Cap and theme support checks for the welcome panel.
props MikeHansenMe.
fixes #26276.

Built from https://develop.svn.wordpress.org/trunk@27563


git-svn-id: http://core.svn.wordpress.org/trunk@27406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-17 19:47:15 +00:00
Sergey Biryukov
ab03c0db64 Fix .comment-grey-bubble markup and remove a stray </h5> tag.
props avryl.
fixes #27408.
Built from https://develop.svn.wordpress.org/trunk@27548


git-svn-id: http://core.svn.wordpress.org/trunk@27391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 04:32:15 +00:00
Dominik Schilling
00f224624e "At a Glance" widget: Move get_avatar() line out of if-block.
This allows you to show avatars for custom comment types via the `get_avatar_comment_types` filter.

props zodiac1978.
fixes #26944.
Built from https://develop.svn.wordpress.org/trunk@27384


git-svn-id: http://core.svn.wordpress.org/trunk@27232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 20:14:14 +00:00
Andrew Nacin
06efe8130d Dashboard widgets: Don't link to Pages or Posts for Authors or Contributors respectively.
props mattheu.
see #26574 for trunk.

Built from https://develop.svn.wordpress.org/trunk@26999


git-svn-id: http://core.svn.wordpress.org/trunk@26876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 16:52:11 +00:00
Andrew Nacin
659334bd59 Introduce dashboard_glance_items filter which replaces 3.7 right_now_* hooks that were tied to table markup.
fixes #26495.

Built from https://develop.svn.wordpress.org/trunk@26832


git-svn-id: http://core.svn.wordpress.org/trunk@26719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 19:12:10 +00:00
Matt Thomas
cd465575f1 Expand the Quick Draft section by default. Fixes #26463, props bassgang.
Built from https://develop.svn.wordpress.org/trunk@26813


git-svn-id: http://core.svn.wordpress.org/trunk@26700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 00:43:11 +00:00
Andrew Nacin
17e3271415 Translator's comment for a date_i18n() string.
props netweb.
fixes #26470.

Built from https://develop.svn.wordpress.org/trunk@26758


git-svn-id: http://core.svn.wordpress.org/trunk@26646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 00:38:13 +00:00
Andrew Nacin
61b7831f56 Dashboard: Restore a line that vanished from my editor to print recently published posts. Also fix an off-by-one error.
see [26704]. see #26066.

Built from https://develop.svn.wordpress.org/trunk@26741


git-svn-id: http://core.svn.wordpress.org/trunk@26630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 20:13:11 +00:00
Drew Jaynes
7bf5470bab Inline documentation fixes for hooks and functions introduced in 3.8.0.
Built from https://develop.svn.wordpress.org/trunk@26736


git-svn-id: http://core.svn.wordpress.org/trunk@26625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:18:11 +00:00
Andrew Nacin
8a2accaa41 Fix various i18n issues on the dashboard. Limits it to posts and pages only for 3.8.
props SergeyBiryukov, dimadin.
fixes #26066.

Built from https://develop.svn.wordpress.org/trunk@26704


git-svn-id: http://core.svn.wordpress.org/trunk@26594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 23:34:11 +00:00
Andrew Nacin
8de0c10bb9 Restore "Search Engines Discouraged" to the dashboard.
props JustinSainton.
fixes #26431.

Built from https://develop.svn.wordpress.org/trunk@26700


git-svn-id: http://core.svn.wordpress.org/trunk@26590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 23:05:10 +00:00
Andrew Nacin
4a3e2f84b9 Dashboard: Rename the Site Content widget (née Right Now) to At a Glance.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26697


git-svn-id: http://core.svn.wordpress.org/trunk@26587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:38:11 +00:00
Andrew Nacin
1788d5840f Dashboard backwards compatibility updates.
* Restore missing wp_dashboard_rss_control() helper.
 * Restore all original 3.7 functions, deprecating many, reusing others. 
 * Rename and remove functions so as not to clash with the original dash plugin.
 * Filter cleanup/restoration.

see #25824, #26334.

Built from https://develop.svn.wordpress.org/trunk@26690


git-svn-id: http://core.svn.wordpress.org/trunk@26580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 21:23:10 +00:00
Andrew Nacin
757a470708 Include columns-# CSS class in wp_dashboard() for when the screen supports it.
props westi.
fixes #26354.

Built from https://develop.svn.wordpress.org/trunk@26617


git-svn-id: http://core.svn.wordpress.org/trunk@26507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 17:28:11 +00:00
Andrew Nacin
7e5b2a013a Restore original properties of the right now (activity) and primary (news) dashboard widgets.
This avoids issues with those trying to remove/disable core meta boxes.

fixes #26392.

Built from https://develop.svn.wordpress.org/trunk@26611


git-svn-id: http://core.svn.wordpress.org/trunk@26501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 16:56:10 +00:00
Helen Hou-Sandí
725eb939d7 Better Dashboard treatment when in no-JS, especially Quick Draft. props georgestephanis, helen. fixes #26376.
Built from https://develop.svn.wordpress.org/trunk@26563


git-svn-id: http://core.svn.wordpress.org/trunk@26454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:32:19 +00:00
Helen Hou-Sandí
236f388d6d Don't show the Activity widget on the Network Admin Dashboard. props ocean90. fixes #26184.
Built from https://develop.svn.wordpress.org/trunk@26394


git-svn-id: http://core.svn.wordpress.org/trunk@26294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 05:29:10 +00:00
Helen Hou-Sandí
2c9af1367e Dashboard columns:
* Improve responsive breakpoints for.
* Remove obsolete network admin option.
* Remove unnecessary JS.

props SergeyBiryukov, kraftbj, lessbloat. fixes #26074.

Built from https://develop.svn.wordpress.org/trunk@26392


git-svn-id: http://core.svn.wordpress.org/trunk@26292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 05:09:10 +00:00
Dominik Schilling
06b4f99e18 Dashboard: Use _draft_or_post_title() to display (no title) if no post title is set. see #25824.
Built from https://develop.svn.wordpress.org/trunk@26337


git-svn-id: http://core.svn.wordpress.org/trunk@26238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 14:13:09 +00:00
Sergey Biryukov
35ec8405f0 Fix date comparison in dashboard_relative_date(). fixes #26033.
Built from https://develop.svn.wordpress.org/trunk@26242


git-svn-id: http://core.svn.wordpress.org/trunk@26149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 03:30:09 +00:00
Sergey Biryukov
ecd594b5a6 PHPDoc and i18n fixes for dashboard widgets.
props dimadin for initial patch.
see #25824.
Built from https://develop.svn.wordpress.org/trunk@26241


git-svn-id: http://core.svn.wordpress.org/trunk@26148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 03:21:10 +00:00
Andrew Nacin
963b2aa574 Merge wp_dashboard_recent_quickdrafts() into wp_dashboard_quick_press(). see #25824.
Built from https://develop.svn.wordpress.org/trunk@26221


git-svn-id: http://core.svn.wordpress.org/trunk@26129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 20:40:15 +00:00
Andrew Nacin
2cc8ed1594 Dash cleanup.
* Use wp_add_dashboard_widget() rather than add_meta_box().
 * Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
 * Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
 * Remove some debug cruft that was preventing caching and invalidation.
 * Simplify lots of things where possible.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26220


git-svn-id: http://core.svn.wordpress.org/trunk@26128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 20:15:10 +00:00
Andrew Nacin
809b335f7a Merge the new dashboard design into core.
Merges https://github.com/growthdesigner/wp-dash.

props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26144


git-svn-id: http://core.svn.wordpress.org/trunk@26055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 22:09:10 +00:00
Andrew Nacin
5361a8abca Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
74488bdcb0 Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Andrew Nacin
7de2054ece Show a proper error message on the dashboard when the current theme is broken.
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.

Clean up broken/ugly "alt" row styling when we are displaying broken themes.

props johnbillion for initial patch.
fixes #21670.

Built from https://develop.svn.wordpress.org/trunk@25666


git-svn-id: http://core.svn.wordpress.org/trunk@25582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 20:50:09 +00:00
Andrew Nacin
4587da663f Allow callback args to be passed from wp_add_dashboard_widget() to add_meta_box().
props jdgrimes.
fixes #25152.

Built from https://develop.svn.wordpress.org/trunk@25454


git-svn-id: http://core.svn.wordpress.org/trunk@25375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-16 18:07:10 +00:00
Andrew Nacin
fef6081046 Move to JSON for three api.wordpress.org endpoints. see #25311.
Built from https://develop.svn.wordpress.org/trunk@25441


git-svn-id: http://core.svn.wordpress.org/trunk@25362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 19:31:08 +00:00
Sergey Biryukov
05d55a400b Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250.
Built from https://develop.svn.wordpress.org/trunk@25298


git-svn-id: http://core.svn.wordpress.org/trunk@25261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 18:17:10 +00:00
Andrew Nacin
9b0e21493d In the admin, do not use auto-generated Gravatar images for comment authors.
This makes it easier to recognize Gravatars (or lack thereof) when moderating comments.

props solarissmoke.
fixes #7054.


Built from https://develop.svn.wordpress.org/trunk@25091


git-svn-id: http://core.svn.wordpress.org/trunk@25075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 20:08:08 +00:00
Andrew Nacin
797ee34bc3 Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389.
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:01:57 +00:00
Ryan Boren
66472f11a0 phpdoc improvements for wp_dashboard_quota()
Props DrewAPicture, h4ck3rm1k3


git-svn-id: http://core.svn.wordpress.org/trunk@24246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 12:37:30 +00:00
Sergey Biryukov
415a5c60da * Pass ellipsis as a parameter to wp_html_excerpt() instead of appending it manually.
* Consolidate the logic to avoid appending ellipsis if the entire string is shown.
* Show ellipsis after truncated filenames and post titles.

props solarissmoke, bpetty, SergeyBiryukov. fixes #11446.

git-svn-id: http://core.svn.wordpress.org/trunk@24214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 00:22:02 +00:00
Sergey Biryukov
08bef7a3cb Use wp_trim_words() in Recent Drafts widget. fixes #24292.
git-svn-id: http://core.svn.wordpress.org/trunk@24212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 23:06:41 +00:00
Sergey Biryukov
57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:27:31 +00:00
Sergey Biryukov
581975e9bf Add description for wp_dashboard_rss_output(). props aaronholbrook for initial patch. fixes #23301.
git-svn-id: http://core.svn.wordpress.org/trunk@23606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 04:34:39 +00:00
Ryan Boren
5f809d1d22 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:00:25 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Peter Westwood
f683fc7677 Tighten our braces. Fixes #23118 props evansolomon.
git-svn-id: http://core.svn.wordpress.org/trunk@23265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 10:13:51 +00:00
Andrew Nacin
a13a011265 Translate the 'First Steps with WordPress' Codex link. props SergeyBiryukov, fixes #22767.
git-svn-id: http://core.svn.wordpress.org/trunk@23082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:51:24 +00:00
Ryan Boren
63662a9b7b In the QuickPress media modal, use the new post id when a post is published.
Props nacin, koopersmith
fixes #22673


git-svn-id: http://core.svn.wordpress.org/trunk@22994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 07:17:10 +00:00
Ryan Boren
b7b54c00e9 Namespace the dashboard widget nonce to avoid collisions with plugins.
git-svn-id: http://core.svn.wordpress.org/trunk@22964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 00:12:43 +00:00
Ryan Boren
d4abd95449 Scope button classes so they can be used on the frontend without interfering with theme styles.
Props helenyhou, koopersmith
fixes #22644


git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:40:59 +00:00
Andrew Nacin
24b82f2c3b Nonces for dashboard controls.
git-svn-id: http://core.svn.wordpress.org/trunk@22930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 00:01:02 +00:00
Ryan Boren
52dcf95dcd Gettext markup for a welcome screen string. Props SergeyBiryukov, xibe. fixes #22546
git-svn-id: http://core.svn.wordpress.org/trunk@22831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-23 16:42:31 +00:00
Andrew Ozz
c4fd7d119b Welcome screen: clean up the css, improve the html, add RTL styles, props helenyhou TobiasBg ocean90, fixes #21368, see #22453
git-svn-id: http://core.svn.wordpress.org/trunk@22638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 21:51:39 +00:00
Peter Westwood
06830f4501 Multisite: When displaying the upload quota and space used in the dashboard widget format them nicely.
git-svn-id: http://core.svn.wordpress.org/trunk@22498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 10:47:43 +00:00
Andrew Ozz
cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Ryan Boren
6757005b59 Welcome screen refresh. Now with icons. Props lessbloat, empireoflight. fixes #21368
git-svn-id: http://core.svn.wordpress.org/trunk@22379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 21:12:46 +00:00
Andrew Nacin
076ede55f2 Split by [\r\n\t ] rather than \s to avoid UTF-8 issues. props SergeyBiryukov. fixes #21625.
git-svn-id: http://core.svn.wordpress.org/trunk@22306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-25 21:09:42 +00:00
Ryan Boren
1714e085e4 Don't create {$blog_id}_user-settings, {$blog_id}_user-settings-time, and {$blog_id}_dashboard_quick_press_last_post_id user options when a super admin visits a site they aren't a member of. Instead, rely solely on the wp-settings cookie.
fixes #22178


git-svn-id: http://core.svn.wordpress.org/trunk@22256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-17 18:58:09 +00:00
Andrew Ozz
e6fe8c83a3 Tab indexes: when tabbing out of the editors make sure the next focused element is the expected/default action, fix focusing the next field when picking a date for future post, props lessbloat, fixes #21340
git-svn-id: http://core.svn.wordpress.org/trunk@22250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-16 21:38:35 +00:00
Andrew Nacin
f27e7f051f Align QuickPress fields. props lessbloat. fixes #21754.
git-svn-id: http://core.svn.wordpress.org/trunk@22146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-09 19:07:09 +00:00
Andrew Nacin
b0e29340e1 Provide no-customize fallback to the welcome screen. Use the customize overlay rather than a page reload. see #21368.
git-svn-id: http://core.svn.wordpress.org/trunk@22089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-01 14:58:05 +00:00
Andrew Nacin
1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin
51ad055a68 New design and content for the welcome panel. First pass.
props lessbloat, helenyhou, georgestephanis, sabreuse, ryelle.
see #21368.



git-svn-id: http://core.svn.wordpress.org/trunk@22018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:44:43 +00:00
Andrew Nacin
557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 05:26:19 +00:00
Andrew Nacin
c1b0670c2d Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598.
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
Andrew Nacin
cfdab676fa Replace QuickPress labels with gray prompt texts. Stylish, but also done for localization purposes (string lengths). props ocean90. fixes #21754.
git-svn-id: http://core.svn.wordpress.org/trunk@21894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 18:45:44 +00:00
Andrew Nacin
7fd32ab9fc Fold Privacy Settings into Reading Settings, moving blog_public (search engine/robots) to options-reading and removing options-privacy.
When blog_public only has two values (as judged by whether the blog_privacy_selector action is used), convert from radio buttons to a checkbox, and rename from 'Site Visibility' to a more specific 'Search Engine Visibility'.

The text and implementation may change a bit. see #16416.



git-svn-id: http://core.svn.wordpress.org/trunk@21838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-13 17:28:57 +00:00
Daryl Koopersmith
67894a3407 New button styles.
Using the new buttons:

* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".

For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.

get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).

props lessbloat, helenyhou, trepmal, nacin. see #21598.



git-svn-id: http://core.svn.wordpress.org/trunk@21789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-08 04:58:34 +00:00
westi
4443baaab9 Multisite: Rework the upload space usage tracking code so as to be fully pluggable.
* Moves some admin only functions into wp-admin/includes/ms.php from wp-includes/ms-functions.php
 * Reworked the variable naming to be more in line with the Coding Standards
 * Introduced a new get_space_used() function instead of calculating it in multiple places.

Fixes #21181 props dllh and jkudish for inital work on this.


git-svn-id: http://core.svn.wordpress.org/trunk@21387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-01 13:52:06 +00:00
ryan
7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 18:30:03 +00:00
azaozz
34535097b7 Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar).
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.

Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.

See #21340.

git-svn-id: http://core.svn.wordpress.org/trunk@21311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 00:15:15 +00:00
nacin
cacce8add0 Fix the 'Display item date' configuration option for the Incoming Links dashboard widget. props Latz, SergeyBiryukov, fixes #20644.
git-svn-id: http://core.svn.wordpress.org/trunk@21249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 19:16:53 +00:00
nacin
149eff94a1 WP.org no longer returns this old structure. The title of the item is the plugin name in full. fixes #21012.
git-svn-id: http://core.svn.wordpress.org/trunk@21160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 19:34:25 +00:00
nacin
3ebea2f218 Remove user/site suggestions (autocompletion) from search inputs, as the UX isn't proper.
* Removes all instances of site-search, so away it goes. Sidesteps a number of bugs with site-search.
 * Renames user-search to user-suggest, which means it better describes the current behavior (autocompletion) while allowing for future behavior (instant search).
 * Ties user suggestions to a single .wp-suggest-user class.

with help from markjaquith, helenyhou, wonderboymusic. 
fixes #20835.



git-svn-id: http://core.svn.wordpress.org/trunk@21003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:51:33 +00:00