Scott Taylor
592f3d9c6c
After [33961], ensure that comment filters that expect a comment ID are receiving one.
...
Props dimadin.
Fixes #33809 .
Built from https://develop.svn.wordpress.org/trunk@34008
git-svn-id: http://core.svn.wordpress.org/trunk@33977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 18:10:25 +00:00
Scott Taylor
8cd584e6ed
In wp_generate_attachment_metadata()
, also pass $metadata
to the intermediate_image_sizes_advanced
filter.
...
Props amereservant, wonderboymusic.
Fixes #23401 .
Built from https://develop.svn.wordpress.org/trunk@34007
git-svn-id: http://core.svn.wordpress.org/trunk@33976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 18:04:24 +00:00
Scott Taylor
6e22d94488
Add a "View" row action for approved comments on the Dashboard screen, remove the link labeled #
.
...
Props rachelbaker, zeo.
Fixes #18885 .
Built from https://develop.svn.wordpress.org/trunk@34006
git-svn-id: http://core.svn.wordpress.org/trunk@33975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 17:49:24 +00:00
Scott Taylor
527b5b1405
In WP_Posts_List_Table::column_date()
, the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before.
...
Props johnbillion, wonderboymusic.
Fixes #18641 .
Built from https://develop.svn.wordpress.org/trunk@34005
git-svn-id: http://core.svn.wordpress.org/trunk@33974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 17:43:24 +00:00
Scott Taylor
39411b8e61
Cleanup the text for Publish Settings > Publish
in the edit-form-advanced
help tab. Clarify that Private posts aren't hidden from editors and administrators.
...
Props sillybean.
Fixes #18418 .
Built from https://develop.svn.wordpress.org/trunk@34004
git-svn-id: http://core.svn.wordpress.org/trunk@33973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 17:36:24 +00:00
Scott Taylor
52498a8546
In wp_media_upload_handler()
, replace a lingering instance of media_upload_gallery()
with wp_iframe(...)
...
Props jeffstieler, antpb.
Fixes #17812 .
Built from https://develop.svn.wordpress.org/trunk@34003
git-svn-id: http://core.svn.wordpress.org/trunk@33972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 17:24:23 +00:00
Scott Taylor
811f76699b
media-new.php
, when using the browser uploader, if the result of uploading is a WP_Error
- wp_die()
with the error, instead of redirecting with a generic error.
...
Props solarissmoke.
Fixes #16820 .
Built from https://develop.svn.wordpress.org/trunk@34002
git-svn-id: http://core.svn.wordpress.org/trunk@33971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 17:18:24 +00:00
Scott Taylor
47409875ab
In get_page_uri()
, do not add parent slugs to orphaned pages.
...
Adds unit test.
Props filosofo, MikeHansenMe, MikeHansenMe, chriscct7.
Fixes #15963 .
Built from https://develop.svn.wordpress.org/trunk@34001
git-svn-id: http://core.svn.wordpress.org/trunk@33970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 16:54:24 +00:00
Scott Taylor
49b8ccec79
When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts.
...
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405 .
Built from https://develop.svn.wordpress.org/trunk@34000
git-svn-id: http://core.svn.wordpress.org/trunk@33969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 16:47:24 +00:00
Jeremy Felt
2762f019f7
Multisite: Correct ms_not_installed()
@since
version for new parameters
...
Props dimadin.
See 27264.
Built from https://develop.svn.wordpress.org/trunk@33999
git-svn-id: http://core.svn.wordpress.org/trunk@33968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 16:21:26 +00:00
Sergey Biryukov
f9e7fb306c
Merge two similar strings.
...
Props dipesh.kakadiya.
Fixes #33777 .
Built from https://develop.svn.wordpress.org/trunk@33998
git-svn-id: http://core.svn.wordpress.org/trunk@33967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 10:59:27 +00:00
Jeremy Felt
52c3be1602
Multisite: Add action to handle network not found
...
`ms_network_not_found` fires when the global `$current_site` has not been filled and `ms_not_installed()` is about to fire. It cannot be used to populate `$current_site`, but can be used to capture the request and redirect or present a custom error.
Props rmccue.
Fixes #31702 .
Built from https://develop.svn.wordpress.org/trunk@33990
git-svn-id: http://core.svn.wordpress.org/trunk@33959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 05:06:24 +00:00
Jeremy Felt
7278744dd0
Multisite: Remove $domain
and $path
globals in ms_not_installed()
...
Further reduces the reliance on these unnecessary globals.
Fixes #27264 .
Built from https://develop.svn.wordpress.org/trunk@33989
git-svn-id: http://core.svn.wordpress.org/trunk@33958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 03:53:24 +00:00
Jeremy Felt
d1f818a61d
Multisite: Allow users with manage_network_users
to edit network users.
...
Other users in a network can now be given capabilities to manage users without also having global super admin privileges.
* Users with `manage_network_users` can not edit super admins.
* Users with `manage_network_users` can not promote users to super admin.
* Uses of `is_super_admin()` in `user-new.php` are now updated to `manage_network_users`.
Props daniellandau, chriscct7.
Fixes #16860 .
Built from https://develop.svn.wordpress.org/trunk@33988
git-svn-id: http://core.svn.wordpress.org/trunk@33957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 03:34:23 +00:00
Jeremy Felt
cb22d36f61
Multisite: Test edit_user
capabilities for multisite administrators
...
An administrator in multisite can not edit users other than itself.
Props daniellandau for the initial patch.
See #16860 .
Built from https://develop.svn.wordpress.org/trunk@33987
git-svn-id: http://core.svn.wordpress.org/trunk@33956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 03:21:24 +00:00
Scott Taylor
52516a68ab
After the global
churn in [33964], also set $post
to null
at the end of WP_Comments_List_Table::single_row()
to ensure that an orphaned comment doesn't inherit the previous row's $post
context.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33986
git-svn-id: http://core.svn.wordpress.org/trunk@33955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 03:12:23 +00:00
Scott Taylor
2c21d12232
Implement a priority system for Help Tabs to add them at specific positions.
...
Adds unit tests.
Props swissspidy.
Fixes #19828 .
Built from https://develop.svn.wordpress.org/trunk@33985
git-svn-id: http://core.svn.wordpress.org/trunk@33954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 01:27:23 +00:00
Scott Taylor
b8c37073d8
Add @access
docs to class-wp-filesystem-*
files.
...
Props wenthemes.
Fixes #33725 .
Built from https://develop.svn.wordpress.org/trunk@33984
git-svn-id: http://core.svn.wordpress.org/trunk@33953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 01:21:24 +00:00
Scott Taylor
2736486f5a
Plugins page: re-word "No out of date plugins were selected." to "All selected plugins are up to date." since it's not really an error condition.
...
Props swissspidy.
Fixes #26494 .
Built from https://develop.svn.wordpress.org/trunk@33983
git-svn-id: http://core.svn.wordpress.org/trunk@33952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 01:11:24 +00:00
Scott Taylor
bbbbf11961
After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc).
...
See #33414 .
Built from https://develop.svn.wordpress.org/trunk@33982
git-svn-id: http://core.svn.wordpress.org/trunk@33951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 01:03:25 +00:00
Andrew Ozz
0f3f7160e4
TinyMCE: update to 4.2.5, changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=index&pr_id=1 .
...
Fixes #33782 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33981
git-svn-id: http://core.svn.wordpress.org/trunk@33950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 19:45:26 +00:00
Drew Jaynes
55f3b892fb
Docs: Add a changelog entry to the DocBlock for touch_time()
to mention the shift from accessing the global $comment
to using get_comment()
.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33979
git-svn-id: http://core.svn.wordpress.org/trunk@33948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 15:48:25 +00:00
Drew Jaynes
f5c8f20a69
Docs: Use the $widget_links_args
parameter in the hook doc for the widget_links_args
filter, introduced when the args array was split out to a variable in [33971].
...
See #20788 .
Built from https://develop.svn.wordpress.org/trunk@33978
git-svn-id: http://core.svn.wordpress.org/trunk@33947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 15:45:27 +00:00
Scott Taylor
4bdda75696
WP_Widget_Links
: pass widget instance to widget_links_args
filter
...
Props SergeyBiryukov, MikeHansenMe, DrewAPicture.
Fixes #20788 .
Built from https://develop.svn.wordpress.org/trunk@33971
git-svn-id: http://core.svn.wordpress.org/trunk@33940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 04:42:24 +00:00
Scott Taylor
02ae926dfd
Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading...
...
Props yoavf.
Fixes #32875 .
Built from https://develop.svn.wordpress.org/trunk@33970
git-svn-id: http://core.svn.wordpress.org/trunk@33939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 04:39:25 +00:00
Scott Taylor
62ec4a3bfd
Deprecate wp_get_http()
- function isn't used anywhere (apart from itself).
...
Props swissspidy.
Fixes #33709 .
Built from https://develop.svn.wordpress.org/trunk@33969
git-svn-id: http://core.svn.wordpress.org/trunk@33938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 04:26:25 +00:00
Scott Taylor
b05593c0b9
Add a parameter, $post
, to get_{$adjacent}_post_join
, get_{$adjacent}_post_where
, and get_{$adjacent}_post_sort
...
Props JustinSainton.
Fixes #24597 .
Built from https://develop.svn.wordpress.org/trunk@33968
git-svn-id: http://core.svn.wordpress.org/trunk@33937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 03:49:24 +00:00
Scott Taylor
7ef604c052
Ensure that role
is not empty before adding it in add_role()
function and methods.
...
Props MikeHansenMe, dannydehaan, michielhab.
Fixes #23746 .
Built from https://develop.svn.wordpress.org/trunk@33967
git-svn-id: http://core.svn.wordpress.org/trunk@33936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 03:42:25 +00:00
Scott Taylor
6d4442ba12
Revisions screen: change language from "Return to post editor" to "Return to editor" - more generic for usage by custom post types.
...
Props lancewillett, adamsilverstein.
Fixes #31910 .
Built from https://develop.svn.wordpress.org/trunk@33966
git-svn-id: http://core.svn.wordpress.org/trunk@33935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 03:23:23 +00:00
Scott Taylor
246f2a6bd9
Use get_comment()
instead of a global in touch_time()
.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33965
git-svn-id: http://core.svn.wordpress.org/trunk@33934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 03:05:24 +00:00
Scott Taylor
71f955dc84
In WP_Comments_List_Table
, favor passing WP_Comment
instances instead of $comment_ID
to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33964
git-svn-id: http://core.svn.wordpress.org/trunk@33933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 03:00:24 +00:00
Scott Taylor
d973339738
After [33891], get_comment()
returns global $comment
if no args are passed and the global is set (after setting the default to null
here). This allows us to ditch global comment imports.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33963
git-svn-id: http://core.svn.wordpress.org/trunk@33932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 02:51:24 +00:00
Scott Taylor
67f90df6a4
Walker_Comment
should be in its own file. Loaded now via wp-includes/comment.php
, which makes it 100% BC.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@33962
git-svn-id: http://core.svn.wordpress.org/trunk@33931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 02:41:24 +00:00
Scott Taylor
433c786bde
After [33891], a lot of comment functions can take WP_Comment
instead of only accepting comment_ID
. Update the @param
docs to reflect this.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@33961
git-svn-id: http://core.svn.wordpress.org/trunk@33930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 02:34:24 +00:00
Scott Taylor
627396ac0c
Speed up browserify
builds, don't uglify
the media builds on watch
.
...
Props iseulde.
Fixes #31911 .
Built from https://develop.svn.wordpress.org/trunk@33960
git-svn-id: http://core.svn.wordpress.org/trunk@33929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 02:12:24 +00:00
Scott Taylor
5c9e3b00ce
Pre-req for Media builds: make sure the watcher actually works for browserify
.
...
See #31911 .
Built from https://develop.svn.wordpress.org/trunk@33959
git-svn-id: http://core.svn.wordpress.org/trunk@33928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 02:03:24 +00:00
Scott Taylor
8879565c0a
In WP_User
, add @property
docs for description
, first_name
, and last_name
. user_firstname
and user_lastname
only exist for back-compat.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33958
git-svn-id: http://core.svn.wordpress.org/trunk@33927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 01:13:24 +00:00
Scott Taylor
5e9e1d14bd
WP_Theme
has an ad hoc property in WP_MS_Themes_List_Table
, $update
. This can be set to a default value on the class, as it's not obtained via __get()
.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33957
git-svn-id: http://core.svn.wordpress.org/trunk@33926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 01:02:24 +00:00
Scott Taylor
128cc02f39
In wpdb::get_col_length()
, the final return false
is unreachable since the default switch
case returns.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@33956
git-svn-id: http://core.svn.wordpress.org/trunk@33925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-09 00:48:26 +00:00
Andrew Ozz
4e7dd2c4b1
Formatting: maintain the content of HTML comments when they contain <object>
tags. Add more tests for wpaitop().
...
Props miqrogroove.
Fixes #33645 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33955
git-svn-id: http://core.svn.wordpress.org/trunk@33924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 22:55:24 +00:00
Scott Taylor
c1bb5b5ce3
After [33843], update the location of some files in This filter is documented in
docs
...
Props dimadin.
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@33954
git-svn-id: http://core.svn.wordpress.org/trunk@33923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 22:17:26 +00:00
Scott Taylor
3d8199c4eb
Multisite: Don't allow sites to be created with the following reserved slugs: wp-admin
, wp-content
, wp-includes
...
Props austinginder.
Fixes #33615 .
Built from https://develop.svn.wordpress.org/trunk@33952
git-svn-id: http://core.svn.wordpress.org/trunk@33921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 19:32:24 +00:00
Scott Taylor
0c97b3625e
After [33814], checked()
outputs a leading space, so some extra spaces can be removed in the HTML for default widget forms.
...
See #23012 .
Built from https://develop.svn.wordpress.org/trunk@33951
git-svn-id: http://core.svn.wordpress.org/trunk@33920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 19:23:24 +00:00
Scott Taylor
00c8fe6b38
Bump the timeout in trackback()
to 10 seconds (from 4) to match wp_xmlrpc_server::pingback_ping()
and prevent trackback timeouts.
...
Props gnaka08 for the initial patch.
Fixes #10414 .
Built from https://develop.svn.wordpress.org/trunk@33948
git-svn-id: http://core.svn.wordpress.org/trunk@33917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 18:56:25 +00:00
Scott Taylor
1cd398db0e
After [33840], JS regex needs the g
modifier.
...
Add another unit test case.
Props kitchin.
Fixes #22781 .
Built from https://develop.svn.wordpress.org/trunk@33947
git-svn-id: http://core.svn.wordpress.org/trunk@33916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 16:44:26 +00:00
Gary Pendergast
40f45a0b89
Tests: Check that readme.html
is recommending an actively supported version of MySQL.
...
Per the MySQL support guidelines (https://www.mysql.com/support/ ), Oracle provides active support for MySQL releases for 5 years from the General Availality release.
See #33758 .
Built from https://develop.svn.wordpress.org/trunk@33946
git-svn-id: http://core.svn.wordpress.org/trunk@33915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 03:24:26 +00:00
Andrea Fercia
a49f9ef68f
Bump H3 headings to H2 on the Network Add New User screen for better accessibility.
...
Props Cheffheid.
Fixes #33605 .
Built from https://develop.svn.wordpress.org/trunk@33945
git-svn-id: http://core.svn.wordpress.org/trunk@33914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 16:03:25 +00:00
Gary Pendergast
c44c7338c0
Tests: Add an extra warning message when checking the recommended PHP version.
...
See #33758 .
Built from https://develop.svn.wordpress.org/trunk@33944
git-svn-id: http://core.svn.wordpress.org/trunk@33913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 07:28:24 +00:00
Weston Ruter
7c6534fd4c
Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
...
Fixes #33695 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33939
git-svn-id: http://core.svn.wordpress.org/trunk@33908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 05:59:24 +00:00
Weston Ruter
274373afc6
Customize: Fix clearing of a color control's setting by using proper empty value.
...
Props stevehenty.
Fixes #30280 .
Built from https://develop.svn.wordpress.org/trunk@33938
git-svn-id: http://core.svn.wordpress.org/trunk@33907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-07 05:48:23 +00:00