Commit Graph

52 Commits

Author SHA1 Message Date
omarreiss
bdbaccce37 General: Explicitly assigns all JS globals to the window.
Many variables in the JavaScript were defined in the global scope without being explicitly assigned to the window. When built with Webpack, the code gets encapsulated in anonymous functions and those implicit globals get assigned to the wrong scope. This patch prevents that from happening.

Fixes #44371. See #43731.

Built from https://develop.svn.wordpress.org/trunk@43577


git-svn-id: http://core.svn.wordpress.org/trunk@43406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-19 13:33:24 +00:00
atimmer
bde558be2f Docs: Add file doc @output annotations.
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.

The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.

Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361.

Built from https://develop.svn.wordpress.org/trunk@43347


git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
Andrea Fercia
54a45f6d77 Accessibility: Change the terms "Quick Edit" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
See #38677 / [42725].

Fixes #43382.

Built from https://develop.svn.wordpress.org/trunk@42727


git-svn-id: http://core.svn.wordpress.org/trunk@42557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-21 23:04:31 +00:00
atimmer
f6a37e7d39 Docs: Remove @summary tags from JSDoc.
As decided in the JavaScript core chat. With a few reasons:

* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.

The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.

Props herregroen.
Fixes #42901.

Built from https://develop.svn.wordpress.org/trunk@42411


git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 14:14:53 +00:00
Andrea Fercia
a42b9cebde Quick/Bulk Edit: Improve the inline error messages styling.
- uses the core `notice` styles for the Quick Edit form inline error messages
- adds missing periods at the end of a few error messages

Props ocean90, karmatosed, melchoyce, afercia.
Fixes #35496.

Built from https://develop.svn.wordpress.org/trunk@41684


git-svn-id: http://core.svn.wordpress.org/trunk@41518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-02 21:52:52 +00:00
Sergey Biryukov
bb0cec0bfe Docs: Add documentation for wp-admin/js/inline-edit-tax.js.
Props atimmer, boblinthorst.
Fixes #37571.
Built from https://develop.svn.wordpress.org/trunk@38644


git-svn-id: http://core.svn.wordpress.org/trunk@38587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-22 18:50:28 +00:00
Andrea Fercia
1ae8891261 Accessibility: make the tab order match the visual order in the Edit terms screens.
Fixes #35664.
Built from https://develop.svn.wordpress.org/trunk@37439


git-svn-id: http://core.svn.wordpress.org/trunk@37405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-16 13:02:29 +00:00
Andrea Fercia
e41649c325 Accessibility: Improve focus handling on the Taxonomies Quick Edit.
Moves focus back to a proper place when saving or closing the form.

Fixes #35460.
Built from https://develop.svn.wordpress.org/trunk@36304


git-svn-id: http://core.svn.wordpress.org/trunk@36271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-14 23:03:26 +00:00
Andrea Fercia
9b486acb9b Quick Edit: on the Taxonomies screens, prevent a page reload when pressing Enter on a focused field.
Fixes #35401 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36260


git-svn-id: http://core.svn.wordpress.org/trunk@36227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-11 13:15:29 +00:00
Andrea Fercia
5f93491286 Accessibility: improvements for the taxonomies Quick Edit form.
Changes the "Cancel" and "Update" controls in buttons for better semantics and
accessibility. On cancel and successful saving, moves focus back to the term title
to avoid a focus loss. Dispatches error and success messages to `wp.a11y.speak`
to give assistive technologies users an audible feedback.

Patch prepared at #wpcdit, first Italian WordPress Contributor Day.

Props garusky, chiara_09.
Fixes #34613.
Built from https://develop.svn.wordpress.org/trunk@35605


git-svn-id: http://core.svn.wordpress.org/trunk@35569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-11 00:24:28 +00:00
Helen Hou-Sandí
8f85bb1ac5 Bulk/quick edit: Set the correct colspan.
`thead` can contain `td`s now, too.

props afercia.
fixes #31654.

Built from https://develop.svn.wordpress.org/trunk@33015


git-svn-id: http://core.svn.wordpress.org/trunk@32986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:06:25 +00:00
Helen Hou-Sandí
3ac1a19529 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.

Built from https://develop.svn.wordpress.org/trunk@31996


git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Helen Hou-Sandí
591c4b7d3b List tables: Go back to inserting quick edit rows after, as some plugins rely on that assumption. Results are the same.
fixes #26060.

Built from https://develop.svn.wordpress.org/trunk@31820


git-svn-id: http://core.svn.wordpress.org/trunk@31802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 21:50:27 +00:00
Gary Pendergast
b7546d798f Emoji: Instead of having custom hooks for Ajax callbacks, use MutationObserver to re-parse any changed elements in the DOM.
Props iseulde

See #31242


Built from https://develop.svn.wordpress.org/trunk@31750


git-svn-id: http://core.svn.wordpress.org/trunk@31731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 12:52:26 +00:00
Andrew Nacin
78679bfb3f Emoji JS cleanup.
* Filename: emoji.js => wp-emoji.js
 * Script handle: emoji => wp-emoji
 * Object: WPEmoji => wp.emoji
 * Script settings: EmojiSettings => _wpemojiSettings
 * Setting key: base_url => baseUrl
 * Remove executable bit from files

see #31242.

Built from https://develop.svn.wordpress.org/trunk@31744


git-svn-id: http://core.svn.wordpress.org/trunk@31725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 03:17:26 +00:00
Sergey Biryukov
9f6cd01346 Fix JSHint errors in [31734] and add missing dependencies.
props iseulde.
fixes #31328.
Built from https://develop.svn.wordpress.org/trunk@31741


git-svn-id: http://core.svn.wordpress.org/trunk@31722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 01:05:26 +00:00
Gary Pendergast
03ade8c011 Add emoji URL support, and Twemoji fallback for displaying slugs in wp-admin, when the browser doesn't natively support emoji.
Props pento, SergeyBiryukov and boonebgorges.

Fixes #31328


Built from https://develop.svn.wordpress.org/trunk@31734


git-svn-id: http://core.svn.wordpress.org/trunk@31715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 22:55:28 +00:00
Boone Gorges
8627216105 When updating the name a hierarchical term with Quick Edit, update the corresponding option in the Parent dropdown.
Props garyc40, rmarks.
Fixes #14565.
Built from https://develop.svn.wordpress.org/trunk@31288


git-svn-id: http://core.svn.wordpress.org/trunk@31269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-29 01:53:22 +00:00
Helen Hou-Sandí
62a197d6bf List tables: Use CSS :nth-child() selectors for zebra striping.
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.

Built from https://develop.svn.wordpress.org/trunk@31181


git-svn-id: http://core.svn.wordpress.org/trunk@31162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-14 22:14:22 +00:00
Andrew Nacin
56f5b8b4ec JSHint fixes for inline-edit-tax.js.
props dougwollison.
fixes #26002.

Built from https://develop.svn.wordpress.org/trunk@26265


git-svn-id: http://core.svn.wordpress.org/trunk@26171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 04:35:09 +00:00
Sergey Biryukov
e64191e739 Change jQuery selector in Quick Edit to avoid losing data in IE8.
fixes #24923 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26123


git-svn-id: http://core.svn.wordpress.org/trunk@26035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 04:06:09 +00:00
Helen Hou-Sandí
7439445462 Make sure quick edited non-alternate taxonomy list table rows don't become alternate. props c3mdigital. fixes #25059.
Built from https://develop.svn.wordpress.org/trunk@25463


git-svn-id: http://core.svn.wordpress.org/trunk@25384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-16 21:11:09 +00:00
Andrew Nacin
2a956dd5b7 Stop using jQuery.live(). props ocean90. see #22975.
git-svn-id: http://core.svn.wordpress.org/trunk@23444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 17:46:12 +00:00
Andrew Ozz
cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Andrew Nacin
1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin
2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot
af84dbcf93 Compress scripts/styles: 3.4-alpha-20192.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-15 13:58:27 +00:00
azaozz
ec2778daa9 Do not run bulk edit when the user clicks on a filter, fixes #17733
git-svn-id: http://svn.automattic.com/wordpress/trunk@18222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 00:01:16 +00:00
azaozz
b1fe99c5ce jQuery 1.6.1 and fix for some small bugs that popped up while testing it, props JDTrower, fixes #17311
git-svn-id: http://svn.automattic.com/wordpress/trunk@17907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 22:00:31 +00:00
azaozz
f385e7da46 Use new jQuery methods when adding, editing and deleting tags with AJAX, fix warning when deleting tags, see #10239
git-svn-id: http://svn.automattic.com/wordpress/trunk@11676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-07-01 08:12:39 +00:00
azaozz
affd966711 Custom taxonomies support: quick edit, delete, show in the menu
git-svn-id: http://svn.automattic.com/wordpress/trunk@10557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-02-12 08:00:29 +00:00
azaozz
05ed1d870d Remove unused category parent settings from inline-edit-tax.js
git-svn-id: http://svn.automattic.com/wordpress/trunk@10342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-10 14:09:06 +00:00
azaozz
a750885c8e Minify all js and add the non-minified files as .dev.js
git-svn-id: http://svn.automattic.com/wordpress/trunk@10291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-02 15:08:58 +00:00
azaozz
b54484f937 Faster hide-if-no-js, if-js-closed, etc. needed when loading scripts in the footer.
git-svn-id: http://svn.automattic.com/wordpress/trunk@10258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-27 12:18:38 +00:00
ryan
e89192b1a8 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-09 18:03:31 +00:00
azaozz
57b4d9966c Fix urlencoded chars in links after using QE
git-svn-id: http://svn.automattic.com/wordpress/trunk@10101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-07 05:14:49 +00:00
ryan
10fef332d6 Set eol-style
git-svn-id: http://svn.automattic.com/wordpress/trunk@10054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-05 01:44:26 +00:00
azaozz
eb42b45767 QE: set colspan and fix IE input field width
git-svn-id: http://svn.automattic.com/wordpress/trunk@9738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-17 20:08:38 +00:00
azaozz
5ca12b7518 Show a space as thousands separator for comments count when setting from js, hide ajax throbber when QE returns an error, see#8227 fixes #8225
git-svn-id: http://svn.automattic.com/wordpress/trunk@9726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-15 21:58:51 +00:00
azaozz
f0804b3c26 QE: fix notices and check if the returned string contains the row HTML, props DD32, fixes #8115
git-svn-id: http://svn.automattic.com/wordpress/trunk@9712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-15 12:04:38 +00:00
azaozz
b756fbabcd QE fixes: don't display-filter titles, show QE for newly added cats and tags, fixes #8146
git-svn-id: http://svn.automattic.com/wordpress/trunk@9606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-11 09:39:42 +00:00
azaozz
41870c14a8 New design of Quick/Bulk Edit (added some colors and IE fixes), props mdawaffe, see #8144
git-svn-id: http://svn.automattic.com/wordpress/trunk@9604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-11 02:58:24 +00:00
azaozz
fb0c4d0bef Fix QE for the last category, fixes #8077
git-svn-id: http://svn.automattic.com/wordpress/trunk@9588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-10 10:50:37 +00:00
azaozz
c5af1c84e3 Press Enter to save in Quick Edit, props aaron_guitar, fixes #8061
git-svn-id: http://svn.automattic.com/wordpress/trunk@9566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-08 06:54:42 +00:00
azaozz
785d668c28 Unhide the Quick Edit link when adding new category by AJAX, fixes #8077
git-svn-id: http://svn.automattic.com/wordpress/trunk@9551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-06 17:57:26 +00:00
azaozz
68e1a688dc Disable dblclick for pages, posts and taxonomy QE
git-svn-id: http://svn.automattic.com/wordpress/trunk@9439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-31 18:31:26 +00:00
azaozz
002d07c3af Remove Quick Edit when clicking search or filter buttons
git-svn-id: http://svn.automattic.com/wordpress/trunk@9334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-24 20:50:20 +00:00
ryan
710529051d Remove titles from inline edit rows
git-svn-id: http://svn.automattic.com/wordpress/trunk@9298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-23 16:37:19 +00:00
ryan
838f6b5d93 Bring back Quick Edit links
git-svn-id: http://svn.automattic.com/wordpress/trunk@9297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-23 16:34:21 +00:00
azaozz
0a7871c4ab Quick Edit: remove action links, remove row titles, add hint in footer
git-svn-id: http://svn.automattic.com/wordpress/trunk@9162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-14 10:33:18 +00:00