Commit Graph

13534 Commits

Author SHA1 Message Date
Sergey Biryukov
89e7a75d96 Date/Time: Eliminate use of date_default_timezone_set() for determining DST status on General Options screen.
Time calculations should not need to rely on manipulating global PHP configuration state.

Props Rarst.
Fixes #46483.
Built from https://develop.svn.wordpress.org/trunk@45556


git-svn-id: http://core.svn.wordpress.org/trunk@45367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:11:53 +00:00
Sergey Biryukov
a06e914bae Date/Time: Add more supported formats to wp_maybe_decline_date().
Props SergeyBiryukov, Rarst.
Fixes #37411.
Built from https://develop.svn.wordpress.org/trunk@45555


git-svn-id: http://core.svn.wordpress.org/trunk@45366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 13:47:52 +00:00
desrosj
bd239b4be8 XML-RPC: Merge similar translation strings.
Props ramiy.
Fixes #47039.
Built from https://develop.svn.wordpress.org/trunk@45554


git-svn-id: http://core.svn.wordpress.org/trunk@45365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 12:53:52 +00:00
atimmer
8756207ef2 Comments: Open comment quick edit on double click.
In [42767] the quick edit button changed from a link to a button. This caused the jQuery code that selects on a link to no longer work. This commit restores the previous behavior.

Fixes #47572.
See #43382, #38677.

Built from https://develop.svn.wordpress.org/trunk@45553


git-svn-id: http://core.svn.wordpress.org/trunk@45364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 10:06:51 +00:00
desrosj
470177a906 Help/About: Improve wording of PHP Error Protection section.
Props pedromendonca, garrett-eclipse.
See #47475.
Fixes #47538.
Built from https://develop.svn.wordpress.org/trunk@45551


git-svn-id: http://core.svn.wordpress.org/trunk@45362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 09:52:54 +00:00
Sergey Biryukov
f0e9ffdebb Plugins: When validating plugin's WordPress and PHP requirements, check for Requires at least and Requires PHP headers in the plugin's main PHP file.
This allows for blocking plugin activation if it requires a higher version of PHP or WordPress, and does not have a `readme.txt` file.

If the headers are defined in both `readme.txt` and the main plugin file, precedence is given to the plugin file.

Props afragen, Otto42, Ipstenu.
Fixes #46938.
Built from https://develop.svn.wordpress.org/trunk@45546


git-svn-id: http://core.svn.wordpress.org/trunk@45357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-18 03:24:52 +00:00
Sergey Biryukov
55d05b56c3 Bootstrap/Load: Set expiration of the recovery mode cookie to the same amount of time for which the token in it is valid: a week by default.
Props david.binda, TimothyBlynJacobs.
Fixes #47480.
Built from https://develop.svn.wordpress.org/trunk@45545


git-svn-id: http://core.svn.wordpress.org/trunk@45356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-17 19:17:54 +00:00
Sergey Biryukov
038c980a42 Bootstrap/Load: Return a 403 error code when the recovery mode cookie is invalid or expired, or the exit recovery mode nonce check failed.
Props david.binda, spacedmonkey.
Fixes #47479.
Built from https://develop.svn.wordpress.org/trunk@45544


git-svn-id: http://core.svn.wordpress.org/trunk@45355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-17 18:37:55 +00:00
Andrew Ozz
88ffa41ee3 Media: Ignore errors coming from image_resize_dimensions() when creating sub-sizes (for now). It returns false when the requested size is larger than the original image and should be skipped. This triggers new WP_Error in WP_Image_Editor::resize().
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45543


git-svn-id: http://core.svn.wordpress.org/trunk@45354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-16 01:33:51 +00:00
Sergey Biryukov
4e4ef1170b I18N: Merge duplicate strings in notifications displayed when a new user has been created or added to the site.
Props ramiy.
Fixes #35746.
Built from https://develop.svn.wordpress.org/trunk@45542


git-svn-id: http://core.svn.wordpress.org/trunk@45353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 18:57:52 +00:00
Andrew Ozz
6b74e27d04 Media: fix support for arrays for the crop setting for registered image sub-sizes in wp_get_registered_image_subsizes().
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45541


git-svn-id: http://core.svn.wordpress.org/trunk@45352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 17:17:52 +00:00
Andrew Ozz
da7839dc45 After [45538]: fix another WPCS "strict comparison" fix.
Props birgire.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45540


git-svn-id: http://core.svn.wordpress.org/trunk@45351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 16:24:52 +00:00
Andrew Ozz
5987caeecc After [45538]: fix a WPCS fix and make couple of var names consistent.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45539


git-svn-id: http://core.svn.wordpress.org/trunk@45350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 01:32:53 +00:00
Andrew Ozz
05302bd054 Save progress of intermediate image creation after upload. First run.
- Introduces `wp_get_missing_image_subsizes()` and `wp_update_image_subsizes()` to generate image sub-sizes that are missing or were not created after the upload.
- Adds a way to display errors that happened while creating sub-sizes.
- Introduces `wp_create_image_subsizes()` intended for use after an image was uploaded. It saves/updates the image metadata immediately after each sub-size is created. This fixes the (long standing) problem when some of the sub-size image files were created but there was a timeout or an error and the metadata was not saved. Until now such uploads were considered "failed" which usually resulted in the user trying to upload the same image again, creating even more "orphan" image files.

Note that the patch also includes some unrelated WPCS fixes.

Props mikeschroder, azaozz.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45538


git-svn-id: http://core.svn.wordpress.org/trunk@45349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 01:02:52 +00:00
Sergey Biryukov
8a2daa7648 Menus: Set better default for $args parameter in Walker_Nav_Menu methods, to match the documented parameter type.
Props trasweb.
Fixes #47524.
Built from https://develop.svn.wordpress.org/trunk@45537


git-svn-id: http://core.svn.wordpress.org/trunk@45348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-14 11:26:52 +00:00
Sergey Biryukov
0239fe6d10 Administration: Adjust code for "Manage widgets or menus" item on "Welcome to WordPress" panel to avoid an extra space after [42343].
Props Presskopp, davidbaumwald.
Fixes #47536.
Built from https://develop.svn.wordpress.org/trunk@45536


git-svn-id: http://core.svn.wordpress.org/trunk@45347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-14 00:29:52 +00:00
desrosj
3d61f81536 Docs: Fix typos in Services_JSON DocBlocks.
Props mukesh27.
Fixes #47401.
Built from https://develop.svn.wordpress.org/trunk@45535


git-svn-id: http://core.svn.wordpress.org/trunk@45346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 19:19:52 +00:00
Andrew Ozz
d38e15e59d Fix displaying of the "An updated version of WordPress is available." notice when running the latest nightly build. Note that it is still displayed when running a local build or from /src.
Props afragen, audrasjb, SergeyBiryukov.
Fixes #45202.
Built from https://develop.svn.wordpress.org/trunk@45532


git-svn-id: http://core.svn.wordpress.org/trunk@45343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:43:53 +00:00
Andrea Fercia
d69a3e6f90 Accessibility: Handle one more case of focus loss when switching view in the Media Views.
See #43169.

Built from https://develop.svn.wordpress.org/trunk@45531


git-svn-id: http://core.svn.wordpress.org/trunk@45342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:22:52 +00:00
Andrew Ozz
727838a11b Add a Recovery Mode Exit button to the notice. This fixes it in responsive view.
Props desrosj, karmatosed, chetan200891, afercia, afragen, garrett-eclipse.
Fixes #47070.
Built from https://develop.svn.wordpress.org/trunk@45529


git-svn-id: http://core.svn.wordpress.org/trunk@45340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:00:52 +00:00
desrosj
7be747f86d Customize: Remove “Update” link for themes on multisite installs.
In [38887], installing themes in the Customizer was disabled for multisite installs. However, an update link continues to be displayed when a theme update is available. Clicking the link causes a JavaScript error.

This removes that update link because updates cannot actually be performed in the Customizer in this situation.

Props desrosj, earnjam, mukesh27, audrasjb, garrett-eclipse.
Fixes #46997.
Built from https://develop.svn.wordpress.org/trunk@45527


git-svn-id: http://core.svn.wordpress.org/trunk@45338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 15:31:52 +00:00
Andrea Fercia
c622fb4fe1 Media: Make sure the bottom media toolbar content is fully visible with Internet Explorer 11.
Props mspatovaliyski.
Fixes #47502.

Built from https://develop.svn.wordpress.org/trunk@45526


git-svn-id: http://core.svn.wordpress.org/trunk@45337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 14:12:52 +00:00
Weston Ruter
2ca468889a Bundled Theme: Fix malformed Google Font URL for Twenty Twelve due to double-encoding of +
Amends [45485].
Fixes #47282.

Built from https://develop.svn.wordpress.org/trunk@45525


git-svn-id: http://core.svn.wordpress.org/trunk@45336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 23:33:50 +00:00
Andrea Fercia
340fd28d82 Accessibility: Improve focus management in the Media Views.
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()

Fixes #43169.

Built from https://develop.svn.wordpress.org/trunk@45524


git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 21:03:52 +00:00
Andrea Fercia
9f579ea448 Administration: Improve the horizontal centering of the Site Health tabs.
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Fixes #46881.

Built from https://develop.svn.wordpress.org/trunk@45522


git-svn-id: http://core.svn.wordpress.org/trunk@45333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:31:52 +00:00
Andrea Fercia
9f7f9d2d89 Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position.
Fixes #45094.

Built from https://develop.svn.wordpress.org/trunk@45520


git-svn-id: http://core.svn.wordpress.org/trunk@45331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:21:54 +00:00
Andrew Ozz
d0c1b77cda Privacy tools:
- Move the (remaining) privacy tools related functions from `wp-admin/includes/file.php` to `wp-admin/includes/privacy-tools.php`.
- Move the `WP_User_Request` class to a separate file.

See #43895.
Built from https://develop.svn.wordpress.org/trunk@45519


git-svn-id: http://core.svn.wordpress.org/trunk@45330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 23:54:53 +00:00
Sergey Biryukov
3b69e493f6 I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page.
Props pedromendonca, garrett-eclipse.
Fixes #47475.
Built from https://develop.svn.wordpress.org/trunk@45515


git-svn-id: http://core.svn.wordpress.org/trunk@45326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 14:14:51 +00:00
Peter Wilson
a5e57d7245 Site health: Introduce view_site_health_checks capability.
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.

The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.

The capability is granted on the `user_has_cap` filter.

Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Fixes #46957.


Built from https://develop.svn.wordpress.org/trunk@45507


git-svn-id: http://core.svn.wordpress.org/trunk@45318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 07:42:52 +00:00
Andrea Fercia
f57e10a35d Accessibility: Fix the order of the Previous, Next, and Close buttons in the Attachment Details modal.
Making the visual and DOM order match benefits keyboard users who navigate documents sequentially and expect the focus order to be consistent with the sequential reading order.

Fixes #47458.

Built from https://develop.svn.wordpress.org/trunk@45506


git-svn-id: http://core.svn.wordpress.org/trunk@45317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-09 15:48:53 +00:00
John Blackbourn
c9b51df3d0 I18N: Allow the length of automatically generated excerpts to be localized.
This introduces three new strings that can be used to control the maximum length of automatically generated excerpts for posts, comments, and draft post previews in the dashboard. Optionally combined with the existing word count type control this allows languages which include many multibyte characters to specify more appropriate maximum excerpt lengths.

Props miyauchi, birgire, johnbillion

Fixes #44541

Built from https://develop.svn.wordpress.org/trunk@45505


git-svn-id: http://core.svn.wordpress.org/trunk@45316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 18:42:52 +00:00
John Blackbourn
eeba1c1244 HTTP API: Ensure the http_api_debug hook is fired for all responses.
This means that logging and debugging functionality can access the error code and error message for erroneous responses under all conditions. The hook is not fired when a request is short-circuited with the `pre_http_request` filter, because this filter itself can be used in that situation.

Fixes #25747

Built from https://develop.svn.wordpress.org/trunk@45504


git-svn-id: http://core.svn.wordpress.org/trunk@45315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 17:10:52 +00:00
Andrea Fercia
935c35fe34 Accessibility: Improve the Screen Options and Help buttons order.
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Fixes #45094.

Built from https://develop.svn.wordpress.org/trunk@45503


git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:31:53 +00:00
Andrea Fercia
be14c6e5c6 Administration: Improve the Screen Options and Help buttons focus style after [45501].
Amends [45501].
See #46749.

Built from https://develop.svn.wordpress.org/trunk@45502


git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:07:52 +00:00
Andrea Fercia
17034e2a4e Administration: Remove extra border from the Screen Options and Help buttons.
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.
Fixes #46749.

Built from https://develop.svn.wordpress.org/trunk@45501


git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 14:50:52 +00:00
Andrew Ozz
7cee029897 Privacy tools: remove some left-over code and fix inline comment.
See #43895.


Built from https://develop.svn.wordpress.org/trunk@45500


git-svn-id: http://core.svn.wordpress.org/trunk@45311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 00:30:51 +00:00
Andrea Fercia
6a9bcaeaa9 Accessibility: Improve accessibility of all the media views form controls.
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8

Fixes #47141.
Fixes #47122.

Built from https://develop.svn.wordpress.org/trunk@45499


git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:45:02 +00:00
Andrea Fercia
314bfab180 Regenerate the REST API fixtures after [45443].
See #38517.

Built from https://develop.svn.wordpress.org/trunk@45498


git-svn-id: http://core.svn.wordpress.org/trunk@45309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:24:52 +00:00
Andrea Fercia
d5333b9593 Fix the media player controls bar width in the media views.
Props vaishalipanchal, chetan200891.
Fixes #47457.

Built from https://develop.svn.wordpress.org/trunk@45497


git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 13:29:52 +00:00
Sergey Biryukov
056b9c47a2 Docs: Fix typo in comment_class() DocBlock.
Props mbabker.
Fixes #47499.
Built from https://develop.svn.wordpress.org/trunk@45496


git-svn-id: http://core.svn.wordpress.org/trunk@45307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 23:52:51 +00:00
Sergey Biryukov
baa2cd69b8 Media: Restore correct arrow direction in RTL in Attachment Details modal.
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Fixes #46289.
Built from https://develop.svn.wordpress.org/trunk@45495


git-svn-id: http://core.svn.wordpress.org/trunk@45306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 01:25:52 +00:00
Sergey Biryukov
53719315b4 I18N: Merge duplicate "Original" strings used in the same context (referring to image size).
Props mukesh27.
Fixes #47486.
Built from https://develop.svn.wordpress.org/trunk@45494


git-svn-id: http://core.svn.wordpress.org/trunk@45305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:23:52 +00:00
Sergey Biryukov
3f9bf72d69 I18N: Correct encoding for wp-includes/widgets/class-wp-widget-calendar.php, accidentally saved in ANSI instead of UTF-8.
See #47485.
Built from https://develop.svn.wordpress.org/trunk@45493


git-svn-id: http://core.svn.wordpress.org/trunk@45304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:09:53 +00:00
Sergey Biryukov
16dfde180c I18N: Merge duplicate "A calendar of your site’s posts" strings used in the Calendar widget and the Calendar block in the editor.
Props jorgefilipecosta, ramiy.
Fixes #47485.
Built from https://develop.svn.wordpress.org/trunk@45492


git-svn-id: http://core.svn.wordpress.org/trunk@45303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:03:53 +00:00
Sergey Biryukov
8c449d3312 Posts, Post Types: Switch the order of arguments for implode() in the_meta() to match the function notation.
Props loyaltymanufaktur.
Fixes #47481.
Built from https://develop.svn.wordpress.org/trunk@45491


git-svn-id: http://core.svn.wordpress.org/trunk@45302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 00:16:54 +00:00
desrosj
4c0620bdf8 Privacy: Remove inline CSS within personal data request list tables.
The `.hidden` class can be used to show and hide UI elements instead.

Props birgire, pratikthink, garrett-eclipse.
Fixes #44839.
Built from https://develop.svn.wordpress.org/trunk@45490


git-svn-id: http://core.svn.wordpress.org/trunk@45301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 23:40:55 +00:00
Sergey Biryukov
aa59cb8359 Docs: Correct parameter name for wp_new_user_notification_email_admin filter.
Props needle.
Fixes #47476.
Built from https://develop.svn.wordpress.org/trunk@45489


git-svn-id: http://core.svn.wordpress.org/trunk@45300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 12:48:55 +00:00
Sergey Biryukov
32d761ce7d I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
Props ramiy.
Fixes #47227.
Built from https://develop.svn.wordpress.org/trunk@45488


git-svn-id: http://core.svn.wordpress.org/trunk@45299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-01 22:10:52 +00:00
Sergey Biryukov
13da094c39 Upgrade/Install: Correct operator precedence for an error code in WP_Ajax_Upgrader_Skin::error().
Props jrf.
Fixes #47441.
Built from https://develop.svn.wordpress.org/trunk@45487


git-svn-id: http://core.svn.wordpress.org/trunk@45298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:14:52 +00:00
Sergey Biryukov
410eb3501b Build/Test Tools: Add $current_screen to the list of globals to unset in WP_UnitTestCase_Base::go_to().
Props mauteri.
Fixes #47439.
Built from https://develop.svn.wordpress.org/trunk@45486


git-svn-id: http://core.svn.wordpress.org/trunk@45297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:07:51 +00:00
Felix Arntz
3c40573f77 Bundled Theme: Load Google fonts with display=fallback parameter for better UX in case the font cannot be loaded.
Providing this query parameter ensures the stylesheet contains the `font-display: fallback` rule. This changeset also updates the Open Sans font used by core accordingly.

Props westonruter.
Fixes #47282.

Built from https://develop.svn.wordpress.org/trunk@45485


git-svn-id: http://core.svn.wordpress.org/trunk@45296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 10:10:54 +00:00
Sergey Biryukov
0d40c54f9b CSS Coding Standards: Use unitless values for line-height in wp-admin/css/media.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45484


git-svn-id: http://core.svn.wordpress.org/trunk@45295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:45:50 +00:00
Sergey Biryukov
412ffd0aaf Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.

See #46530.
Built from https://develop.svn.wordpress.org/trunk@45483


git-svn-id: http://core.svn.wordpress.org/trunk@45294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:40:52 +00:00
youknowriad
ebb0b92081 Block Editor: Update packages to the ones slated for WP5.2.2
- Fix the template validation notice
 - Fix for focus jumps when typing in meta attributes

Packages updated:

 - @wordpress/block-editor@2.0.3
 - @wordpress/block-library@2.4.6
 - @wordpress/e2e-tests@1.1.6
 - @wordpress/edit-post@3.3.6
 - @wordpress/editor@9.2.6
 - @wordpress/format-library@1.4.6

Props aduth, desrosj.
Fixes #47429.

Built from https://develop.svn.wordpress.org/trunk@45481


git-svn-id: http://core.svn.wordpress.org/trunk@45292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:41:57 +00:00
desrosj
349d95f27a Docs: Add missing function documentation for list_plugin_updates().
Introduced in [9543].

Props priyankkpatel, mukesh27.
Fixes #47424.
Built from https://develop.svn.wordpress.org/trunk@45480


git-svn-id: http://core.svn.wordpress.org/trunk@45291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:10:52 +00:00
desrosj
012d05f5c0 Docs: Add missing documentation for the locale meta field.
The user’s locale is passed in the `$meta` parameter for `insert_user_meta`. Added in [38705].

Props tmatsuur.
Fixes #47423.
Built from https://develop.svn.wordpress.org/trunk@45479


git-svn-id: http://core.svn.wordpress.org/trunk@45290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 14:37:53 +00:00
Sergey Biryukov
96a533b279 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/media-views.css.
Props ianbelanger, pbiron, afercia.
Fixes #46529. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45478


git-svn-id: http://core.svn.wordpress.org/trunk@45289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 13:18:52 +00:00
Sergey Biryukov
9bab7d6fd6 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/editor.css.
Props ianbelanger, pbiron, afercia.
Fixes #46528. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45477


git-svn-id: http://core.svn.wordpress.org/trunk@45288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:45:53 +00:00
Sergey Biryukov
5083e104d4 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/buttons.css.
Props ianbelanger, pbiron, afercia.
Fixes #46526. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45476


git-svn-id: http://core.svn.wordpress.org/trunk@45287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:42:52 +00:00
Sergey Biryukov
1d98a92fad CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-pointer.css.
Props ianbelanger, pbiron, afercia.
Fixes #46525. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45475


git-svn-id: http://core.svn.wordpress.org/trunk@45286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:41:51 +00:00
Sergey Biryukov
90b2092ab6 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-embed-template.css.
Props ianbelanger, pbiron, afercia.
Fixes #46524. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45474


git-svn-id: http://core.svn.wordpress.org/trunk@45285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:40:52 +00:00
Sergey Biryukov
05afb2271d CSS Coding Standards: Use unitless values for line-height in wp-includes/functions.php.
Props ianbelanger, pbiron, afercia.
Fixes #46523. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45473


git-svn-id: http://core.svn.wordpress.org/trunk@45284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:39:52 +00:00
Sergey Biryukov
820baca1bd CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-auth-check.css.
Props ianbelanger, pbiron, afercia.
Fixes #46522. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45472


git-svn-id: http://core.svn.wordpress.org/trunk@45283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:37:52 +00:00
Sergey Biryukov
e6b98a469c CSS Coding Standards: Use unitless values for line-height in wp-includes/css/jquery-ui-dialog.css.
Props ianbelanger, pbiron, afercia.
Fixes #46521. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45471


git-svn-id: http://core.svn.wordpress.org/trunk@45282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:36:52 +00:00
Sergey Biryukov
8738c23afc CSS Coding Standards: Use unitless values for line-height in wp-includes/css/customize-preview.css.
Props ianbelanger, pbiron, afercia.
Fixes #46520. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45470


git-svn-id: http://core.svn.wordpress.org/trunk@45281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:34:52 +00:00
Sergey Biryukov
2a417c2168 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/admin-bar.css.
Props ianbelanger, pbiron, afercia.
Fixes #46519. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45469


git-svn-id: http://core.svn.wordpress.org/trunk@45280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:32:51 +00:00
Sergey Biryukov
fdc6b9583b CSS Coding Standards: Use unitless values for line-height in wp-admin/css/revisions.css.
Props ianbelanger, pbiron, afercia.
Fixes #46517. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45468


git-svn-id: http://core.svn.wordpress.org/trunk@45279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:16:52 +00:00
Sergey Biryukov
ca6aa01705 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/list-tables.css.
Props ianbelanger, pbiron, afercia.
Fixes #46515. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45467


git-svn-id: http://core.svn.wordpress.org/trunk@45278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:15:52 +00:00
Sergey Biryukov
afaeca95cf CSS Coding Standards: Use unitless values for line-height in wp-admin/css/login.css.
Props ianbelanger, pbiron, afercia.
Fixes #46514. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45466


git-svn-id: http://core.svn.wordpress.org/trunk@45277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:09:52 +00:00
Sergey Biryukov
1899a99c35 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/install.css.
Props ianbelanger, pbiron, afercia.
Fixes #46513. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45465


git-svn-id: http://core.svn.wordpress.org/trunk@45276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:53:53 +00:00
Sergey Biryukov
03814826b2 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/forms.css.
Props ianbelanger, pbiron, afercia.
Fixes #46512. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45464


git-svn-id: http://core.svn.wordpress.org/trunk@45275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:49:53 +00:00
Andrea Fercia
41accccad6 Administration: Improve the Site Health tables layout for small screens.
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.	
Fixes #46960.

Built from https://develop.svn.wordpress.org/trunk@45463


git-svn-id: http://core.svn.wordpress.org/trunk@45274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 18:22:51 +00:00
Sergey Biryukov
52d478cb0d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/edit.css.
Props ianbelanger, pbiron, afercia.
Fixes #46511. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45462


git-svn-id: http://core.svn.wordpress.org/trunk@45273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:05:53 +00:00
Sergey Biryukov
ce25e2f34d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/dashboard.css.
Props ianbelanger, pbiron, afercia.
Fixes #46510. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45461


git-svn-id: http://core.svn.wordpress.org/trunk@45272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:03:52 +00:00
Sergey Biryukov
9860a4366d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-widgets.css.
Props ianbelanger, pbiron, afercia.
Fixes #46509. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45460


git-svn-id: http://core.svn.wordpress.org/trunk@45271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:01:53 +00:00
desrosj
bb3c264350 Administration: Add missing filter documentation for Site Health auto update tests.
Props johnbillion, mukesh27.
Fixes #47388.
Built from https://develop.svn.wordpress.org/trunk@45459


git-svn-id: http://core.svn.wordpress.org/trunk@45270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 13:59:51 +00:00
Andrew Ozz
d23160d427 Fix unit tests after [45456]. The query string is a bit different but the results are the same.
See #45346.
Built from https://develop.svn.wordpress.org/trunk@45458


git-svn-id: http://core.svn.wordpress.org/trunk@45269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 04:19:53 +00:00
Andrew Ozz
311527b41d Fix previous WPCS errors in script-loader.php triggered by [45456].
See #45346.
Built from https://develop.svn.wordpress.org/trunk@45457


git-svn-id: http://core.svn.wordpress.org/trunk@45268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 03:32:52 +00:00
Andrew Ozz
6de52463a7 Script loader: prevent sorting of the load array in the query string when passing the script handles to load-scripts.php and load-styles.php.
Fixes #45346 #26886.
Built from https://develop.svn.wordpress.org/trunk@45456


git-svn-id: http://core.svn.wordpress.org/trunk@45267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 02:43:55 +00:00
Andrew Ozz
b8fa71964f Build tools, WPCS: disable line ending check when running phpcs but fix them to \n whit phpcfb. Fixes (erroneous) reports on Windows about improper line endings in all files. They are managed directly by Git or SVN.
Fixes #47411.
Built from https://develop.svn.wordpress.org/trunk@45455


git-svn-id: http://core.svn.wordpress.org/trunk@45266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 00:26:54 +00:00
Sergey Biryukov
51ee349942 Docs: Add a comment about the reinstated wp-admin/options-privacy.php.
See #43895.
Built from https://develop.svn.wordpress.org/trunk@45454


git-svn-id: http://core.svn.wordpress.org/trunk@45265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 03:03:52 +00:00
Sergey Biryukov
96b4570781 Privacy: Remove reinstated wp-admin/options-privacy.php from $_old_files.
Fix WPCS violations in [45448].

See #43895.
Built from https://develop.svn.wordpress.org/trunk@45453


git-svn-id: http://core.svn.wordpress.org/trunk@45264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 02:40:53 +00:00
Andrew Ozz
2f7f0ad901 Fix typo in [45451] and move the redirect to the proper location.
See #43895.
Built from https://develop.svn.wordpress.org/trunk@45452


git-svn-id: http://core.svn.wordpress.org/trunk@45263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 23:21:51 +00:00
Andrew Ozz
cbcccbd5b6 Privacy tools: restore privacy.php to its "proper" use to output the Privacy tab on the About screen, see [42814]. Then add the Privacy tab updates from freedoms.php.
See #43895.


Built from https://develop.svn.wordpress.org/trunk@45451


git-svn-id: http://core.svn.wordpress.org/trunk@45262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:57:52 +00:00
John Blackbourn
6aab3f2f05 Docs: Improve documentation for some more variadic functions.
Fixes #37402

Built from https://develop.svn.wordpress.org/trunk@45450


git-svn-id: http://core.svn.wordpress.org/trunk@45261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:48:51 +00:00
John Blackbourn
557ef04409 Docs: Improve docs for variadic functions relating to widgets and their controls.
See #37402

Built from https://develop.svn.wordpress.org/trunk@45449


git-svn-id: http://core.svn.wordpress.org/trunk@45260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 22:05:51 +00:00
Andrew Ozz
87acdab81d Privacy tools: Organize privacy functions into logical files and classes.
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895.
Built from https://develop.svn.wordpress.org/trunk@45448


git-svn-id: http://core.svn.wordpress.org/trunk@45259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 20:50:53 +00:00
Sergey Biryukov
67f944caa6 I18N: Remove PHP function name from translatable string in WP_Recovery_Mode_Email_Service.
Props ramiy.
Fixes #47255.
Built from https://develop.svn.wordpress.org/trunk@45447


git-svn-id: http://core.svn.wordpress.org/trunk@45258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 20:44:52 +00:00
John Blackbourn
ead1a54576 Build/Test Tools: Revert an accidental change to Node dependencies.
See #47380

Built from https://develop.svn.wordpress.org/trunk@45446


git-svn-id: http://core.svn.wordpress.org/trunk@45257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 19:37:51 +00:00
John Blackbourn
27365c4ec4 Build/Test Tools: Remove the dependency on a globally installed Grunt.
The existing `"grunt": "grunt"` script in `package.json` allows for the use of `npm run grunt ...` which uses the local `grunt` binary in the project's `node_modules`.

Fixes #47380

Built from https://develop.svn.wordpress.org/trunk@45445


git-svn-id: http://core.svn.wordpress.org/trunk@45256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 19:35:51 +00:00
Sergey Biryukov
2205bc5e92 I18N: Merge duplicate "Invalid post parent ID" strings.
Props ramiy.
Fixes #47270.
Built from https://develop.svn.wordpress.org/trunk@45444


git-svn-id: http://core.svn.wordpress.org/trunk@45255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 19:05:53 +00:00
Sergey Biryukov
d4256378dd Administration: Replace one more reference to "articles" with "posts" for greater consistency of terminology.
See #38517.
Built from https://develop.svn.wordpress.org/trunk@45443


git-svn-id: http://core.svn.wordpress.org/trunk@45254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:51:52 +00:00
Sergey Biryukov
b8b12b4946 I18N: Merge duplicate "Status is forbidden" strings.
Props ramiy.
Fixes #47037.
Built from https://develop.svn.wordpress.org/trunk@45442


git-svn-id: http://core.svn.wordpress.org/trunk@45253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:47:53 +00:00
Sergey Biryukov
cd9c6ce36e I18N: Merge duplicate "Add Comment" strings.
Props ramiy.
Fixes #47246.
Built from https://develop.svn.wordpress.org/trunk@45441


git-svn-id: http://core.svn.wordpress.org/trunk@45252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:43:52 +00:00
Sergey Biryukov
dd7956c674 I18N: Use consistent error messages when importing or exporting content.
Props ramiy.
Fixes #42269.
Built from https://develop.svn.wordpress.org/trunk@45440


git-svn-id: http://core.svn.wordpress.org/trunk@45251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 18:09:52 +00:00
Sergey Biryukov
702f7d4e8d I18N: Merge duplicate "not allowed to manage options" strings.
Props ramiy.
Fixes #42271.
Built from https://develop.svn.wordpress.org/trunk@45439


git-svn-id: http://core.svn.wordpress.org/trunk@45250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 16:00:52 +00:00
Sergey Biryukov
b97a2d4366 I18N: Merge duplicate "Loading..." strings.
Props ramiy.
Fixes #47248.
Built from https://develop.svn.wordpress.org/trunk@45438


git-svn-id: http://core.svn.wordpress.org/trunk@45249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:46:52 +00:00
Sergey Biryukov
21a12ce6cd I18N: Merge similar strings in Edit Media help tabs.
Props ramiy.
Fixes #46919.
Built from https://develop.svn.wordpress.org/trunk@45437


git-svn-id: http://core.svn.wordpress.org/trunk@45248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:38:53 +00:00
Sergey Biryukov
f5f7e99927 I18N: Remove unnecessary context for "WordPress.org" string in WP_Widget_Meta.
Props ramiy.
Fixes #47038.
Built from https://develop.svn.wordpress.org/trunk@45436


git-svn-id: http://core.svn.wordpress.org/trunk@45247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:33:52 +00:00
Sergey Biryukov
bc8ddf3b38 I18N: Remove unnecessary HTML from "Previewing:" string in WP_Customize_Theme_Control.
Props ramiy.
Fixes #47271.
Built from https://develop.svn.wordpress.org/trunk@45435


git-svn-id: http://core.svn.wordpress.org/trunk@45246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:30:53 +00:00
Sergey Biryukov
47720de1c2 Text Changes: Use consistent question wording for discarding unpublished changes in Customizer.
Props ramiy.
Fixes #47258.
Built from https://develop.svn.wordpress.org/trunk@45434


git-svn-id: http://core.svn.wordpress.org/trunk@45245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 15:19:50 +00:00
Sergey Biryukov
9f4c2fcbae I18N: Merge duplicate "Try Again" strings.
Props ramiy.
Fixes #47251.
Built from https://develop.svn.wordpress.org/trunk@45433


git-svn-id: http://core.svn.wordpress.org/trunk@45244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 14:40:51 +00:00
Sergey Biryukov
6c50f22e4e I18N: Remove unnecessary markup from plugin action messages, for consistency with the rest of the admin.
Props ramiy.
Fixes #47238.
Built from https://develop.svn.wordpress.org/trunk@45432


git-svn-id: http://core.svn.wordpress.org/trunk@45243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 14:36:51 +00:00
Sergey Biryukov
f5db16738e Administration: Merge similar "file does not exist" messages in plugin and theme editors.
Props ramiy.
Fixes #47249.
Built from https://develop.svn.wordpress.org/trunk@45431


git-svn-id: http://core.svn.wordpress.org/trunk@45242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 12:35:51 +00:00
Sergey Biryukov
5ec3c66bd3 Docs: Correct @type annotation for wpdb::$last_query.
Props nextendweb, mukesh27.
Fixes #47095.
Built from https://develop.svn.wordpress.org/trunk@45430


git-svn-id: http://core.svn.wordpress.org/trunk@45241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:30:51 +00:00
Sergey Biryukov
7aa0ce19cd Docs: Correct @type annotation for WP_Customize_Widgets properties.
Props diddledan.
Fixes #46856.
Built from https://develop.svn.wordpress.org/trunk@45429


git-svn-id: http://core.svn.wordpress.org/trunk@45240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:16:52 +00:00
Sergey Biryukov
b08c42eb80 Docs: Correct @type annotation for WP_Customize_Selective_Refresh::$current_partial_id.
Props diddledan.
Fixes #46854.
Built from https://develop.svn.wordpress.org/trunk@45428


git-svn-id: http://core.svn.wordpress.org/trunk@45239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:12:52 +00:00
Sergey Biryukov
3e6ed38da1 Docs: Correct @type annotation for WP_Customize_Nav_Menu_Item_Setting::$value.
Props diddledan.
Fixes #46853.
Built from https://develop.svn.wordpress.org/trunk@45427


git-svn-id: http://core.svn.wordpress.org/trunk@45238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:10:52 +00:00
Sergey Biryukov
19503190ba Docs: Correct @type annotation for WP_Customize_Manager::$_changeset_data.
Props diddledan.
Fixes #46852.
Built from https://develop.svn.wordpress.org/trunk@45426


git-svn-id: http://core.svn.wordpress.org/trunk@45237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:07:53 +00:00
Sergey Biryukov
f66429486a Twenty Seventeen: Accessibility: Add missing focus state for native audio and video embeds.
Props kjellr, karlgroves.
Fixes #47190.
Built from https://develop.svn.wordpress.org/trunk@45425


git-svn-id: http://core.svn.wordpress.org/trunk@45236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 02:01:52 +00:00
Sergey Biryukov
c77e771c84 Date/Time: Replace all instances of date() with gmdate().
Use of `date()` in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).

`gmdate()` is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.

Props nielsdeblaauw, Rarst.
Fixes #46438. See #44491.
Built from https://develop.svn.wordpress.org/trunk@45424


git-svn-id: http://core.svn.wordpress.org/trunk@45235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 00:12:54 +00:00
John Blackbourn
17cc8cd0f8 Docs: Correct a theme feature name.
See #45134

Built from https://develop.svn.wordpress.org/trunk@45423


git-svn-id: http://core.svn.wordpress.org/trunk@45234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 23:46:52 +00:00
John Blackbourn
04bba79df9 Docs: Improve documentation for variadic functions relating to post type support and theme support.
See #37402

Built from https://develop.svn.wordpress.org/trunk@45422


git-svn-id: http://core.svn.wordpress.org/trunk@45233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 23:41:54 +00:00
John Blackbourn
e91bf3535c Docs: Correct a function name in the do_action() documentation.
See #37402

Built from https://develop.svn.wordpress.org/trunk@45421


git-svn-id: http://core.svn.wordpress.org/trunk@45232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 22:53:51 +00:00
John Blackbourn
9abcf7881f Docs: Improve and correct documentation for hook-related variadic functions.
See #37402

Built from https://develop.svn.wordpress.org/trunk@45420


git-svn-id: http://core.svn.wordpress.org/trunk@45231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 22:52:54 +00:00
John Blackbourn
26d5e05b75 Docs: Standardise documentation for capability-related variadic functions.
See #37402

Built from https://develop.svn.wordpress.org/trunk@45419


git-svn-id: http://core.svn.wordpress.org/trunk@45230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 22:27:51 +00:00
John Blackbourn
9c6393e967 Docs: Switch to the more common syntax for variadic function documentation.
See #37402

Built from https://develop.svn.wordpress.org/trunk@45418


git-svn-id: http://core.svn.wordpress.org/trunk@45229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 21:59:51 +00:00
Andrea Fercia
fc17576fd2 Accessibility: Improve toggling the "Post locked" information visibility.
- effectively hides the "Post locked" information from assistive technologies
- when a post is locked, reveals the "Post locked" information without CSS animation
- the height CSS animation didn't work anyways after [24906]

See #24553.
Fixes #44946.

Built from https://develop.svn.wordpress.org/trunk@45417


git-svn-id: http://core.svn.wordpress.org/trunk@45228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 17:15:52 +00:00
Andrea Fercia
48d9d94881 Accessibility: Improve settings tables and forms after [45403].
- adds `role="presentation"` to the edit comment table 
- removes a few pointless `<fieldset>` elements
- adds a few missing `<label>` elements
- adds the CSS class `class="td-full"` to table rows spanning to multiple cells
- adds explicit `scope="row"` attribute to the table headers in `options-permalink.php`: this table is better communicated as data table 
- uses consistent label association in the "Privacy Settings" page
- in the installation page "Set up your database connection": associates descriptions to their inout fields using `aria-describedby`
- improves the link to gravatar.com in the `user-edit.php` page

See #46899.
Fixes #47390.

Built from https://develop.svn.wordpress.org/trunk@45416


git-svn-id: http://core.svn.wordpress.org/trunk@45227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 15:19:53 +00:00
Sergey Biryukov
00c60ccd33 CSS Coding Standards: Update unitless values for line-height in wp-admin/css/widgets.css with more precise calculations.
Props ianbelanger.
Fixes #46531.
Built from https://develop.svn.wordpress.org/trunk@45415


git-svn-id: http://core.svn.wordpress.org/trunk@45226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:44:52 +00:00
Sergey Biryukov
962da3db60 CSS Coding Standards: Update unitless values for line-height in wp-admin/css/nav-menus.css with more precise calculations.
Props ianbelanger.
Fixes #46516.
Built from https://develop.svn.wordpress.org/trunk@45414


git-svn-id: http://core.svn.wordpress.org/trunk@45225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:42:52 +00:00
Sergey Biryukov
693e90ac81 Editor: In edit-form-blocks.php, check the result of wp_set_post_lock(), which may return false and cause a warning when passed to implode().
Props kakshak, aduth.
Fixes #47013.
Built from https://develop.svn.wordpress.org/trunk@45413


git-svn-id: http://core.svn.wordpress.org/trunk@45224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:35:52 +00:00
Sergey Biryukov
35a2322d32 General: Update support forum links.
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

This is a follow-up to [45140], which changed the links in help tabs.

Props dilipbheda.
Fixes #47239. See #46790.
Built from https://develop.svn.wordpress.org/trunk@45412


git-svn-id: http://core.svn.wordpress.org/trunk@45223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 14:24:50 +00:00
Andrea Fercia
add6a8e13f Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.
Fixes #47386.

Built from https://develop.svn.wordpress.org/trunk@45411


git-svn-id: http://core.svn.wordpress.org/trunk@45222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 13:32:53 +00:00
John Blackbourn
15dc9ab6ab Build/Test Tools: Ignore generated RTL CSS files from Git version control.
Fixes #47078

Built from https://develop.svn.wordpress.org/trunk@45410


git-svn-id: http://core.svn.wordpress.org/trunk@45221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:30:52 +00:00
Sergey Biryukov
2a02b8fe5d Docs: Remove full stop from ticket number.
See #46402.
Built from https://develop.svn.wordpress.org/trunk@45409


git-svn-id: http://core.svn.wordpress.org/trunk@45220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:09:52 +00:00
Sergey Biryukov
a81dfbdf0e Formatting: Don't run wp_targeted_link_rel() on entirely serialized content.
Props birgire, elliotcondon.
Fixes #46402.
Built from https://develop.svn.wordpress.org/trunk@45408


git-svn-id: http://core.svn.wordpress.org/trunk@45219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 12:05:52 +00:00
John Blackbourn
ca028cfc4c Users: Allow Super Admins to remove themselves from a site on a Multisite network.
Props Mista-Flo, birgire

Fixes #41439

Built from https://develop.svn.wordpress.org/trunk@45407


git-svn-id: http://core.svn.wordpress.org/trunk@45218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-25 00:13:53 +00:00
Sergey Biryukov
eecfa3b4ed Docs: Correct description for $seplocation parameter of wp_title().
Props mukesh27, vladlu.
Fixes #47370.
Built from https://develop.svn.wordpress.org/trunk@45406


git-svn-id: http://core.svn.wordpress.org/trunk@45217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:59:52 +00:00
John Blackbourn
61ed726067 Mail: Use the standardised spelling of email in the password reset error message.
Fixes #39110

Built from https://develop.svn.wordpress.org/trunk@45405


git-svn-id: http://core.svn.wordpress.org/trunk@45216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:53:54 +00:00
John Blackbourn
b3e297925c Mail: Improve the user experience when the password reset email cannot be sent.
This introduces a link to the support page for resetting your password, and improves the error by bringing it into the login page instead of a `wp_die()`.

Props neelpatel7295, estelaris, desrosj

Built from https://develop.svn.wordpress.org/trunk@45404


git-svn-id: http://core.svn.wordpress.org/trunk@45215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 22:14:52 +00:00
Sergey Biryukov
b77cf42c0b Accessibility: Make sure layout tables across the admin are correctly linearized.
Adds `role="presentation"` to the `<table>` elements used for layout purposes.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props greatislander, afercia.
Fixes #46899.
Built from https://develop.svn.wordpress.org/trunk@45403


git-svn-id: http://core.svn.wordpress.org/trunk@45214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 21:56:54 +00:00
John Blackbourn
01917b9f74 I18N: Add a language icon next to language selectors.
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.

Props janak007, atlasmahesh, afercia, birgire, JoshuaWold

Fixes #43144

Built from https://develop.svn.wordpress.org/trunk@45402


git-svn-id: http://core.svn.wordpress.org/trunk@45213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 20:43:52 +00:00
John Blackbourn
53794e9719 Administration: Replace references to "articles" with "posts" for greater consistency of terminology.
Props angelagibson

Fixes #38517

Built from https://develop.svn.wordpress.org/trunk@45401


git-svn-id: http://core.svn.wordpress.org/trunk@45212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 19:18:51 +00:00
Sergey Biryukov
27720e15a7 Bootstrap/Load: In wp_get_server_protocol(), check if $_SERVER['SERVER_PROTOCOL'] is defined, to avoid a notice in CLI context.
Props thakkarhardik, malthert.
Fixes #47005.
Built from https://develop.svn.wordpress.org/trunk@45400


git-svn-id: http://core.svn.wordpress.org/trunk@45211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:47:51 +00:00
Sergey Biryukov
729d4a4942 I18N: Remove PHP function name from translatable string in WP_Debug_Data.
Props ramiy.
Fixes #47254.
Built from https://develop.svn.wordpress.org/trunk@45399


git-svn-id: http://core.svn.wordpress.org/trunk@45210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:41:52 +00:00
Sergey Biryukov
e3bb526606 Login and Registration: Pass the action to site_url() in wp_logout_url() and wp_lostpassword_url():
* Make `site_url` filter in `wp_logout_url()` aware of the `logout` action.
* Make `network_site_url` filter in `wp_lostpassword_url()` aware of the `lostpassword` action.

Props jfarthing84.
Fixes #43407.
Built from https://develop.svn.wordpress.org/trunk@45398


git-svn-id: http://core.svn.wordpress.org/trunk@45209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:33:52 +00:00
Sergey Biryukov
6dc1ced79c Twenty Nineteen: Add missing icon to Edit link for pages.
Props mukesh27, ianbelanger, ounziw.
Fixes #47332.
Built from https://develop.svn.wordpress.org/trunk@45397


git-svn-id: http://core.svn.wordpress.org/trunk@45208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:22:51 +00:00
Sergey Biryukov
e4ce9663a3 I18N: Merge two similar "you may need to press the Esc key twice" strings.
Props ramiy, tmatsuur, hareesh-pillai.
Fixes #47036.
Built from https://develop.svn.wordpress.org/trunk@45396


git-svn-id: http://core.svn.wordpress.org/trunk@45207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:18:53 +00:00
Sergey Biryukov
44512b0753 I18N: Merge two similar "An unexpected error occurred" strings.
Props ramiy.
Fixes #47035.
Built from https://develop.svn.wordpress.org/trunk@45395


git-svn-id: http://core.svn.wordpress.org/trunk@45206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:14:52 +00:00
Sergey Biryukov
a36f5d2295 Docs: Fix typos in DocBlocks and comments in wp-admin/includes/file.php.
Props mukesh27.
Fixes #47026.
Built from https://develop.svn.wordpress.org/trunk@45394


git-svn-id: http://core.svn.wordpress.org/trunk@45205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:08:51 +00:00
Sergey Biryukov
68fd25ff1a Docs: Remove unused @global reference in do_blocks() DocBlock.
Props avinapatel.
Fixes #47055.
Built from https://develop.svn.wordpress.org/trunk@45393


git-svn-id: http://core.svn.wordpress.org/trunk@45204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:05:52 +00:00
Sergey Biryukov
7cadbb50bf Docs: Fix incorrect @see notation in wp_localize_script() DocBlock.
Props coffee2code, shamim51.
Fixes #47104.
Built from https://develop.svn.wordpress.org/trunk@45392


git-svn-id: http://core.svn.wordpress.org/trunk@45203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-24 01:02:51 +00:00
Sergey Biryukov
726e77d97e Networks and Sites: Readjust tabs in wp-admin/includes/network.php for (more or less) consistent alignment.
See #47062.
Built from https://develop.svn.wordpress.org/trunk@45391


git-svn-id: http://core.svn.wordpress.org/trunk@45202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:35:52 +00:00
Sergey Biryukov
139225ad7a Networks and Sites: Remove extra whitespace in .htaccess rules on Network Setup page.
Props riddhiehta02 for initial patch, sebastienserre, masterforwordpress.
Fixes #47062.
Built from https://develop.svn.wordpress.org/trunk@45390


git-svn-id: http://core.svn.wordpress.org/trunk@45201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:28:53 +00:00
John Blackbourn
239a159ad2 Administration: Don't apply italic formatting to code blocks in setting descriptions.
Props chetan200891

Fixes #42651

Built from https://develop.svn.wordpress.org/trunk@45389


git-svn-id: http://core.svn.wordpress.org/trunk@45200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 23:14:53 +00:00
John Blackbourn
75a8adb0eb Docs: Remove incorrect information about usage of the "from" filters in wp_mail(), tidy up formatting.
See #47110

Built from https://develop.svn.wordpress.org/trunk@45388


git-svn-id: http://core.svn.wordpress.org/trunk@45199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 22:42:52 +00:00
John Blackbourn
f2ef36bb2d I18N: Use a complete translatable string for the "Delete My Site" email subject.
Props thrijith

Fixes #46855

Built from https://develop.svn.wordpress.org/trunk@45387


git-svn-id: http://core.svn.wordpress.org/trunk@45198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 22:15:54 +00:00
John Blackbourn
9e891be893 Embeds: Remove the "Supports HTTPS" column from the whitelisted oEmbed provider list now that all supported providers use HTTPS.
See #28507

Built from https://develop.svn.wordpress.org/trunk@45386


git-svn-id: http://core.svn.wordpress.org/trunk@45197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:23:53 +00:00
John Blackbourn
5fe92586c0 Embeds: Use HTTPS for the Hulu oEmbed endpoint, as it redirects to HTTPS now.
Fixes #28507

Built from https://develop.svn.wordpress.org/trunk@45385


git-svn-id: http://core.svn.wordpress.org/trunk@45196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-23 21:20:52 +00:00