Commit Graph

11703 Commits

Author SHA1 Message Date
Andrew Nacin
4b559801ae Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
props dd32.
fixes #25655.

Built from https://develop.svn.wordpress.org/trunk@25866


git-svn-id: http://core.svn.wordpress.org/trunk@25866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:05 +00:00
Andrew Nacin
3b7e540f00 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
props dd32 for initial patch.
fixes #25657.

Built from https://develop.svn.wordpress.org/trunk@25863


git-svn-id: http://core.svn.wordpress.org/trunk@25863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:40 +00:00
Andrew Nacin
de7977d66c Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.

Built from https://develop.svn.wordpress.org/trunk@25861


git-svn-id: http://core.svn.wordpress.org/trunk@25861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:23 +00:00
Drew Jaynes
4d1482cd0d Inline documentation for the WP_Date_Query class in wp-includes/date.php.
- Adds a complete hash notation for the `WP_Date_Query` arguments array.
- Adds missing documentation for the `date_query_valid_columns` and `get_date_sql` filter hooks.

Props aeg0125 for the incremental patches.
Fixes #25552.

Built from https://develop.svn.wordpress.org/trunk@25860


git-svn-id: http://core.svn.wordpress.org/trunk@25860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:12 +00:00
Andrew Nacin
b134f540e2 Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.

Built from https://develop.svn.wordpress.org/trunk@25859


git-svn-id: http://core.svn.wordpress.org/trunk@25859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:57:58 +00:00
Drew Jaynes
1ace516d5f Improve inline documentation for hooks in wp-admin/customize.php.
Props kpdesign.
Fixes #25444.

Built from https://develop.svn.wordpress.org/trunk@25858


git-svn-id: http://core.svn.wordpress.org/trunk@25858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:57:50 +00:00
Andrew Nacin
04bbb52c7c Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25851


git-svn-id: http://core.svn.wordpress.org/trunk@25851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:54 +00:00
Dominik Schilling
af695281d6 Vendor-prefixes for [25845]. props jorbin. see #25603.
Built from https://develop.svn.wordpress.org/trunk@25849


git-svn-id: http://core.svn.wordpress.org/trunk@25849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:37 +00:00
Andrew Nacin
c88a0bb423 About page: Prevent the meter from briefly sticking on 'Strong' when the animation resets.
props jorbin.
see #25603.

Built from https://develop.svn.wordpress.org/trunk@25848


git-svn-id: http://core.svn.wordpress.org/trunk@25848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:29 +00:00
Andrew Nacin
112a790734 Since we're dealing with a huge password meter, don't bold half of the result strings unnecessarily. see #25603.
Built from https://develop.svn.wordpress.org/trunk@25847


git-svn-id: http://core.svn.wordpress.org/trunk@25847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:20 +00:00
Dominik Schilling
3d73363635 IE7: Fix width of the password input field on the about page. see #25603.
Built from https://develop.svn.wordpress.org/trunk@25846


git-svn-id: http://core.svn.wordpress.org/trunk@25846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:12 +00:00
Andrew Nacin
123bb3d4f2 About page: Use box-sizing: border-box on the password meter so pixels line up.
Also eliminates a duplicate width: 100% property.

fixes #25603.

Built from https://develop.svn.wordpress.org/trunk@25845


git-svn-id: http://core.svn.wordpress.org/trunk@25845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:03 +00:00
Dominik Schilling
60ac479b9c CSS cleanup for the about page.
Also fixes for IE and support for RTL.

see #25603.
Built from https://develop.svn.wordpress.org/trunk@25844


git-svn-id: http://core.svn.wordpress.org/trunk@25844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:55 +00:00
Andrew Nacin
aea50d4b4c Use correct variable. fixes #10787.
Built from https://develop.svn.wordpress.org/trunk@25843


git-svn-id: http://core.svn.wordpress.org/trunk@25843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:46 +00:00
Andrew Nacin
350365c602 Use full paths to images so they work on wp-admin/network/about.php and user/about.php. see #25603.
Built from https://develop.svn.wordpress.org/trunk@25842


git-svn-id: http://core.svn.wordpress.org/trunk@25842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:38 +00:00
Andrew Nacin
83b20ee7f9 Notify administrators of successful, failed, and pending core updates.
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.

Built from https://develop.svn.wordpress.org/trunk@25841


git-svn-id: http://core.svn.wordpress.org/trunk@25841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:30 +00:00
Andrew Nacin
b0eab438ad Remove rarr from about page text. Use a subtle background instead.
props markjaquith.
see #25603.

Built from https://develop.svn.wordpress.org/trunk@25840


git-svn-id: http://core.svn.wordpress.org/trunk@25840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:20 +00:00
Andrew Nacin
b13c7791a9 Awesome about page design for WordPress 3.7.
The page includes a giant password meter that serves as both an animated example and a working demo. How cool is that?

props jorbin, melchoyce.
see #25603.

Built from https://develop.svn.wordpress.org/trunk@25839


git-svn-id: http://core.svn.wordpress.org/trunk@25839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:12 +00:00
Andrew Nacin
27d04f9e5e Delete expired transients on database upgrades.
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.

Built from https://develop.svn.wordpress.org/trunk@25838


git-svn-id: http://core.svn.wordpress.org/trunk@25838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:02 +00:00
Andrew Nacin
fa4f4033f7 Introduce email templates for automatic background updates.
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.

Built from https://develop.svn.wordpress.org/trunk@25837


git-svn-id: http://core.svn.wordpress.org/trunk@25837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:54 +00:00
Andrew Nacin
93eefa2af3 set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
fixes #25622.

Built from https://develop.svn.wordpress.org/trunk@25836


git-svn-id: http://core.svn.wordpress.org/trunk@25836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:46 +00:00
Andrew Nacin
a3561e7e07 In automatic background updates, standardize on 'update'.
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25835


git-svn-id: http://core.svn.wordpress.org/trunk@25835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:38 +00:00
Andrew Nacin
5e5d7d8cae Remove redundant code. see #25603, #22704, [25833].
Built from https://develop.svn.wordpress.org/trunk@25834


git-svn-id: http://core.svn.wordpress.org/trunk@25834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:30 +00:00
Andrew Nacin
b9290e0ea3 Check if background core updates are supported on about.php.
see #25603, #22704.

Built from https://develop.svn.wordpress.org/trunk@25833


git-svn-id: http://core.svn.wordpress.org/trunk@25833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:22 +00:00
Andrew Nacin
31ff7d5161 Update the text for the about page, so translators can get started. Design is in flux.
props nacin, markjaquith, jorbin, jenmylo.
see #25603.

Built from https://develop.svn.wordpress.org/trunk@25832


git-svn-id: http://core.svn.wordpress.org/trunk@25832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:13 +00:00
Dion Hulse
8abd2f86d5 Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
See #25576, #22704

Built from https://develop.svn.wordpress.org/trunk@25831


git-svn-id: http://core.svn.wordpress.org/trunk@25831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:05 +00:00
Drew Jaynes
412f9dffd4 Inline documentation for hooks in wp-admin/options-general.php.
Props siobhyb for the initial patch.
Fixes #25454.

Built from https://develop.svn.wordpress.org/trunk@25830


git-svn-id: http://core.svn.wordpress.org/trunk@25830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:57 +00:00
Drew Jaynes
1178d9a80b Inline documentation for hooks in wp-admin/options-discussion.php.
Props siobhyb, ericlewis.
Fixes #25453.

Built from https://develop.svn.wordpress.org/trunk@25829


git-svn-id: http://core.svn.wordpress.org/trunk@25829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:49 +00:00
Dion Hulse
66f01957a0 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25828


git-svn-id: http://core.svn.wordpress.org/trunk@25828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:40 +00:00
Drew Jaynes
c8c2c8d2a2 Inline documentation for hooks in wp-admin/customize.php.
Props andg, rzen.
Fixes #25444.

Built from https://develop.svn.wordpress.org/trunk@25826


git-svn-id: http://core.svn.wordpress.org/trunk@25826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:23 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
564b008f67 Add editimage.min.js to $_old_files. see #24999.
Built from https://develop.svn.wordpress.org/trunk@25897


git-svn-id: http://core.svn.wordpress.org/trunk@25809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 19:27:09 +00:00
Andrew Nacin
0ceb189b7b Confirm delete_site_option() exists before calling it during an update.
This function won't yet exist when updating from 2.7 [sic].

fixes #25682 for trunk.

Built from https://develop.svn.wordpress.org/trunk@25893


git-svn-id: http://core.svn.wordpress.org/trunk@25805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 18:18:12 +00:00
Andrew Nacin
0976999929 Remove debug code from WP_Automatic_Updater::send_email().
props markmcwilliams for initial patch.
see #25678.

Built from https://develop.svn.wordpress.org/trunk@25891


git-svn-id: http://core.svn.wordpress.org/trunk@25803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 01:51:09 +00:00
Andrew Nacin
5a92b17981 About page: Cache our zxcvbn calls and limit the variation of the animation.
Diff is mostly whitespace.

props jorbin, azaozz.
fixes #25603.

Built from https://develop.svn.wordpress.org/trunk@25884


git-svn-id: http://core.svn.wordpress.org/trunk@25796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 19:51:09 +00:00
Andrew Nacin
8cbbccec81 About page, updates section: Don't show a message on about.php if the updater is 100% disabled. Don't show it if the user can't update core. Don't show the email if notifications are disabled. New string.
see #25603.

Built from https://develop.svn.wordpress.org/trunk@25883


git-svn-id: http://core.svn.wordpress.org/trunk@25795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 19:48:10 +00:00
Andrew Nacin
7b772e5c58 Introduce a send_core_update_notification_email filter to control whether to send update notifications.
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.

This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.

see #25603.

Built from https://develop.svn.wordpress.org/trunk@25882


git-svn-id: http://core.svn.wordpress.org/trunk@25794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 19:47:09 +00:00
Ryan Boren
b87d4b77e5 Pinking shears
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Andrew Nacin
a387c3bef9 Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.

This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.

fixes #25654.

Built from https://develop.svn.wordpress.org/trunk@25873


git-svn-id: http://core.svn.wordpress.org/trunk@25785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:19:09 +00:00
Andrew Nacin
58c18f0c32 Show the nag we show for a stuck .maintenance file when an auto update failed.
see #25654.

Built from https://develop.svn.wordpress.org/trunk@25872


git-svn-id: http://core.svn.wordpress.org/trunk@25784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:15:09 +00:00
Andrew Nacin
13dd29126a "some files" instead of "certain files". Less stuffy.
props markjaquith.
see #25652.

Built from https://develop.svn.wordpress.org/trunk@25871


git-svn-id: http://core.svn.wordpress.org/trunk@25783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:41:10 +00:00
Andrew Nacin
fabf119cf3 New, better error message when we realize we won't be able to copy a file and continue with the update.
fixes #25652.

Built from https://develop.svn.wordpress.org/trunk@25870


git-svn-id: http://core.svn.wordpress.org/trunk@25782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:21:10 +00:00
Andrew Nacin
d5fdd66f9d Only enforce disk free space checks when doing background updates.
see #25652.

Built from https://develop.svn.wordpress.org/trunk@25869


git-svn-id: http://core.svn.wordpress.org/trunk@25781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:18:09 +00:00
Andrew Nacin
74488bdcb0 Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Andrew Nacin
a160441c81 Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
props dd32.
fixes #25655.

Built from https://develop.svn.wordpress.org/trunk@25866


git-svn-id: http://core.svn.wordpress.org/trunk@25778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:20:10 +00:00
Andrew Nacin
097c0fd0b6 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
props dd32 for initial patch.
fixes #25657.

Built from https://develop.svn.wordpress.org/trunk@25863


git-svn-id: http://core.svn.wordpress.org/trunk@25775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 09:49:09 +00:00
Andrew Nacin
64bd5aa564 Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.

Built from https://develop.svn.wordpress.org/trunk@25861


git-svn-id: http://core.svn.wordpress.org/trunk@25773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 04:37:09 +00:00
Andrew Nacin
5a0b227316 Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.

Built from https://develop.svn.wordpress.org/trunk@25859


git-svn-id: http://core.svn.wordpress.org/trunk@25771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-21 22:29:09 +00:00
Drew Jaynes
564596c03f Improve inline documentation for hooks in wp-admin/customize.php.
Props kpdesign.
Fixes #25444.

Built from https://develop.svn.wordpress.org/trunk@25858


git-svn-id: http://core.svn.wordpress.org/trunk@25770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-21 21:17:09 +00:00
Andrew Nacin
ee489a2e81 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25851


git-svn-id: http://core.svn.wordpress.org/trunk@25763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 21:24:10 +00:00