Commit Graph

32583 Commits

Author SHA1 Message Date
Boone Gorges
5c1ca9d943 WP_Comment_Query: Fill comment objects from database when cache is unavailable.
This fixes a bug where widgets loaded in a preview or the Customizer are
rendered inside of a `wp_suspend_cache_addition()` block and thus could not
find comment objects in the cache.

Props rommelxcastro, stevehenty.
Fixes #34138.
Built from https://develop.svn.wordpress.org/trunk@35512


git-svn-id: http://core.svn.wordpress.org/trunk@35476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 21:09:27 +00:00
Drew Jaynes
1ddb8b94af Customizer: Adjust styles on panel titles to prevent descenders – such as with the letters g, j, p, q, or y – from getting cut off in some browsers.
Props umeshnevase.
Fixes #33575.

Built from https://develop.svn.wordpress.org/trunk@35511


git-svn-id: http://core.svn.wordpress.org/trunk@35475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:53:26 +00:00
Drew Jaynes
3575214485 Pages: Introduce the get_page_uri filter, which makes it possible to manipulate a given page's URI before it's returned from the like-named get_page_uri().
Props tanner-m for the initial patch.
Fixes #15963.

Built from https://develop.svn.wordpress.org/trunk@35510


git-svn-id: http://core.svn.wordpress.org/trunk@35474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:29:25 +00:00
Scott Taylor
d763eb80b7 XMLRPC: ensure that empty strings are not passed as null, which will then fail isset()
Props solarissmoke.
Fixes #16980.

Built from https://develop.svn.wordpress.org/trunk@35509


git-svn-id: http://core.svn.wordpress.org/trunk@35473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:08:25 +00:00
Aaron Jorbin
b026ad4b75 Adjust heading structure for pages using wp-admin/css/install.css
The readme, installation, upgrade, and repair pages use a common css file. The heading structure for these pages was inconstant with h2s where there should be h1s, h1s where there is no relevant info and sometimes, no h1s at all.

Fixes #34519
Props rianrietveld


Built from https://develop.svn.wordpress.org/trunk@35508


git-svn-id: http://core.svn.wordpress.org/trunk@35472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 18:00:24 +00:00
Scott Taylor
9135920061 Roles: map add_users cap to promote_users and remove it.
"Never used, will be removed." - The Ghost of 3.5 Nacin

Props Craig Ralston, renoirb.
Fixes #16719.

Built from https://develop.svn.wordpress.org/trunk@35507


git-svn-id: http://core.svn.wordpress.org/trunk@35471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 17:54:25 +00:00
Scott Taylor
5e9ed67b82 Feeds: <comments> is optional in RSS2, so don't include it when comments aren't present or open. Same for <wfw:commentRss> and <slash:comments>
Adds unit test.

Props swissspidy, realloc, hakre, sivel.
Fixes #9134.

Built from https://develop.svn.wordpress.org/trunk@35506


git-svn-id: http://core.svn.wordpress.org/trunk@35470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 17:47:25 +00:00
Sergey Biryukov
7d09847957 Add missing @group to Tests_Rel_No_Follow.
See #9959.
Built from https://develop.svn.wordpress.org/trunk@35505


git-svn-id: http://core.svn.wordpress.org/trunk@35469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 16:36:24 +00:00
Drew Jaynes
96616877ac Taxonomy: Introduce the dynamic taxonomy_labels_{$taxonomy} filter, which can be used to manipulate the labels for a given taxonomy.
The addition of this hook brings parity with the earlier-introduced `post_type_labels_{$post_type}` filter, which allows for similarly manipulating labels for a given post type.

Note: It isn't possible to unset or remove default labels via either of these hooks, only to overwrite. This is because WordPress relies on defaults being set for use in various UIs and admin experiences.

Props flixos90.
Fixes #34554.

Built from https://develop.svn.wordpress.org/trunk@35504


git-svn-id: http://core.svn.wordpress.org/trunk@35468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 16:03:25 +00:00
Drew Jaynes
fd10901db5 Docs: Add a missing return description for _get_custom_object_labels(), a private core helper function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35503


git-svn-id: http://core.svn.wordpress.org/trunk@35467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 15:47:27 +00:00
Sergey Biryukov
18852f07f2 Menus: After [35450], use correct IDs in $initial_meta_boxes.
Props swissspidy.
Fixes #33925.
Built from https://develop.svn.wordpress.org/trunk@35502


git-svn-id: http://core.svn.wordpress.org/trunk@35466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 10:56:26 +00:00
Weston Ruter
154e3d4593 Customize: Simplify condition for returning nav_menus_invalid_post_type error.
Props swissspidy.
See #16075.

Built from https://develop.svn.wordpress.org/trunk@35501


git-svn-id: http://core.svn.wordpress.org/trunk@35465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 07:29:25 +00:00
Weston Ruter
77e365efbf Customize: Add support for post_type_archive nav menu items.
Props celloexpressions, westonruter.
Fixes #16075.

Built from https://develop.svn.wordpress.org/trunk@35500


git-svn-id: http://core.svn.wordpress.org/trunk@35464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 04:30:26 +00:00
Gary Pendergast
e0cab8383c Media Library: Allow longer labels in the filter dropdowns.
Props aaronrutley, AlbertoCT.

Fixes #32005.



Built from https://develop.svn.wordpress.org/trunk@35499


git-svn-id: http://core.svn.wordpress.org/trunk@35463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 00:41:24 +00:00
Andrew Ozz
9e436c7e0f Responsive images:
- Fix `_wp_upload_dir_baseurl()` to cache by blog_id.
- Replace `path_join()` with `trailingslashit()`, it's much faster.
- Rename $image_url to $image_src for consistency (used at about 50 other places).
- Couple of tests fixes.

See #34430.
Built from https://develop.svn.wordpress.org/trunk@35498


git-svn-id: http://core.svn.wordpress.org/trunk@35462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-04 00:22:26 +00:00
Sergey Biryukov
a9d6fa9c7a Formatting: wp_make_link_relative() should return an empty string if no path is present in the link.
Props bcworkz, MikeHansenMe, chriscct7, SergeyBiryukov.
Fixes #26819.
Built from https://develop.svn.wordpress.org/trunk@35497


git-svn-id: http://core.svn.wordpress.org/trunk@35461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 21:36:25 +00:00
Sergey Biryukov
40a58409d8 Accessibility: After [35130], adjust the h2.nav-tab-wrapper selector to only override .wrap > h2:first-child.
This improves compatibility with plugins that use navigation tabs as a first H2 heading on their screens.

Props afercia.
Fixes #33559.
Built from https://develop.svn.wordpress.org/trunk@35496


git-svn-id: http://core.svn.wordpress.org/trunk@35460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 20:49:27 +00:00
Drew Jaynes
6b14ca9407 Docs: Fix two notations for the $_wp_real_parent_file global, which is an array.
Props NExt-Season.
Fixes #34443.

Built from https://develop.svn.wordpress.org/trunk@35495


git-svn-id: http://core.svn.wordpress.org/trunk@35459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 20:13:26 +00:00
Andrea Fercia
04c2cd1913 Accessibility: Improve buttons focus and links style in the install screens.
Fixes #34530.
Built from https://develop.svn.wordpress.org/trunk@35494


git-svn-id: http://core.svn.wordpress.org/trunk@35458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 17:59:24 +00:00
Andrea Fercia
862cf19772 Media: Improve form fields labels association in the Edit Media screen.
Fixes #34548.
Built from https://develop.svn.wordpress.org/trunk@35493


git-svn-id: http://core.svn.wordpress.org/trunk@35457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 16:02:25 +00:00
Andrea Fercia
d7485cf10b WP oEmbed: Improve the Sharing dialog accessibility.
Improves ARIA attributes, focus handling, and constrains tabbing within the modal dialog.

Fixes #34484.
Built from https://develop.svn.wordpress.org/trunk@35492


git-svn-id: http://core.svn.wordpress.org/trunk@35456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 15:49:27 +00:00
Andrew Ozz
ea3d7c7962 Responsive images:
- More fixes to inline docs.
- Replace the last `wp_get_attachment_metadata()` with `get_post_meta()`.
- For consistency only accept array or named size in `wp_get_attachment_image_sizes()`.

Props jaspermdegroot.
See #34430.
Built from https://develop.svn.wordpress.org/trunk@35491


git-svn-id: http://core.svn.wordpress.org/trunk@35455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-03 00:19:28 +00:00
Drew Jaynes
64f5e0683a Docs: Document use of the $comment_status global in the DocBlock for WP_Comments_List_Table::handle_row_actions().
Props shimakyohsuke.
Fixes #34425.

Built from https://develop.svn.wordpress.org/trunk@35490


git-svn-id: http://core.svn.wordpress.org/trunk@35454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-02 21:33:27 +00:00
Sergey Biryukov
f43a25bbe1 Docs: After [32654], remove duplicate @param tag in WP_List_Table::set_pagination_args() DocBlock.
Add `@since` tag.

Props bobbingwide.
See #32444.
Built from https://develop.svn.wordpress.org/trunk@35489


git-svn-id: http://core.svn.wordpress.org/trunk@35453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-02 21:03:24 +00:00
Sergey Biryukov
a44ee99ca5 Build Tools: Add Microsoft Edge to Autoprefixer options.
Props christophherr.
Fixes #34550.
Built from https://develop.svn.wordpress.org/trunk@35488


git-svn-id: http://core.svn.wordpress.org/trunk@35452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-02 20:44:27 +00:00
Gary Pendergast
c39ae3e5e2 Upgrades: Add support for FULLTEXT indexes to dbDelta().
Props edirect24, mdawaffe, pento.

Fixes #14445.


Built from https://develop.svn.wordpress.org/trunk@35487


git-svn-id: http://core.svn.wordpress.org/trunk@35451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 23:10:25 +00:00
Weston Ruter
2e98e461a2 Customize: Fix auto-expand (and focus) on newly added widgets.
Add widget controls with an initially-true `active` state so that calling `expand()` will not be short-circuited. Previously the `active` state would be set once the preview refreshes, but this happens too late for the `addWidget` call. Fixes regression introduced in [35231].

Fixes #34514.

Built from https://develop.svn.wordpress.org/trunk@35486


git-svn-id: http://core.svn.wordpress.org/trunk@35450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 22:27:26 +00:00
Drew Jaynes
6924523366 Docs: Correctly notate that the default $width and $height embed dimensions are passed to the embed_defaults filter as a compacted array, and not two distinct parameters.
Props swissspidy.
Fixes #34522.

Built from https://develop.svn.wordpress.org/trunk@35485


git-svn-id: http://core.svn.wordpress.org/trunk@35449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 15:42:25 +00:00
Sergey Biryukov
d49160ba5b Docs: Correct $post parameter description for display_post_states filter.
Props grapplerulrich.
Fixes #34541.
Built from https://develop.svn.wordpress.org/trunk@35484


git-svn-id: http://core.svn.wordpress.org/trunk@35448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 14:06:26 +00:00
Weston Ruter
8fed77574c Customize: Return user to referring URL when leaving Customizer in absence of return query param.
When referring URL is not available, default returning user to frontend URL instead of admin URL. Themes page is updated to include the `return` path in Customizer links.

Props McGuive7, westonruter.
Fixes #32637.

Built from https://develop.svn.wordpress.org/trunk@35483


git-svn-id: http://core.svn.wordpress.org/trunk@35447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 06:40:28 +00:00
Sergey Biryukov
10f3ff1753 Post List Table: Hierarchical post types should not default to sorting by date.
Regression introduced in [34728].

Props ellie.roepken.
Fixes #34473. See #25493.
Built from https://develop.svn.wordpress.org/trunk@35482


git-svn-id: http://core.svn.wordpress.org/trunk@35446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-01 00:49:24 +00:00
Andrew Ozz
26b6acd081 Responsive images: add $image_url parameter to wp_get_attachment_image_sizes() and use it in the filter. This allows themes and plugins to identify the image.
Props joemcgill.
Fixes #34477.
Built from https://develop.svn.wordpress.org/trunk@35481


git-svn-id: http://core.svn.wordpress.org/trunk@35445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 22:49:24 +00:00
Scott Taylor
60eaf79b67 Canonical: when /%post_id%/ is the permalink structure, don't redirect IDs that match Auto Drafts.
Props SergeyBiryukov.
Fixes #29431.

Built from https://develop.svn.wordpress.org/trunk@35480


git-svn-id: http://core.svn.wordpress.org/trunk@35444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:54:25 +00:00
Scott Taylor
d8eacd51d8 Media: add a new image size, medium_large. Bumps db version to add new options.
Adds unit tests.

Props DH-Shredder, joemcgill, azaozz.
Fixes #34196.

Built from https://develop.svn.wordpress.org/trunk@35479


git-svn-id: http://core.svn.wordpress.org/trunk@35443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:50:25 +00:00
Scott Taylor
382d455235 WP oEmbed: Improve height attribute sanitization
Props afercia, swissspidy.
Fixes #34527.

Built from https://develop.svn.wordpress.org/trunk@35478


git-svn-id: http://core.svn.wordpress.org/trunk@35442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:39:25 +00:00
Scott Taylor
35dd8003b0 Admin Menu: allow more than one menu item to be added at the same priority/position.
Props chriscct7.
Fixes #23316.

Built from https://develop.svn.wordpress.org/trunk@35477


git-svn-id: http://core.svn.wordpress.org/trunk@35441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:31:24 +00:00
Scott Taylor
e4a2e0c4a9 Filesystem: in WP_Filesystem_FTPext::parselisting(), check for the existence of $b['islink'] before using it.
Props jesin.
Fixes #27975.

Built from https://develop.svn.wordpress.org/trunk@35476


git-svn-id: http://core.svn.wordpress.org/trunk@35440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:17:24 +00:00
Scott Taylor
244cb3e595 Comments: don't auto-close comments on draft posts.
Adds unit tests.

Props solarissmoke, MikeHansenMe, nacin, rachelbaker.
Fixes #20262.

Built from https://develop.svn.wordpress.org/trunk@35475


git-svn-id: http://core.svn.wordpress.org/trunk@35439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:13:24 +00:00
Scott Taylor
a36900c076 REST API: remove the @internal annotation from rest_api_default_filters().
Props swissspidy, rachelbaker.
Fixes #34219.

Built from https://develop.svn.wordpress.org/trunk@35474


git-svn-id: http://core.svn.wordpress.org/trunk@35438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:08:25 +00:00
Scott Taylor
5c57e68d48 Nav Menus: add responsive styles for viewport between 768 and 1000px.
Props datta.parad, chriscct7.
Fixes #28912.

Built from https://develop.svn.wordpress.org/trunk@35473


git-svn-id: http://core.svn.wordpress.org/trunk@35437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 20:05:26 +00:00
Sergey Biryukov
74969ca0d3 Embeds: In get_post_embed_html(), move the optional $post argument after the required $width and $height.
Props swissspidy.
Fixes #34523.
Built from https://develop.svn.wordpress.org/trunk@35472


git-svn-id: http://core.svn.wordpress.org/trunk@35436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 15:51:25 +00:00
Sergey Biryukov
0b845e0364 Embeds: In get_oembed_response_data(), make the $post argument required.
`get_oembed_response_data()` is called by the API endpoint controller and never in a context where it makes sense to use the global post object.

Props swissspidy.
See #34523.
Built from https://develop.svn.wordpress.org/trunk@35471


git-svn-id: http://core.svn.wordpress.org/trunk@35435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 15:42:25 +00:00
Sergey Biryukov
64fdde928a Embeds: Fix typo in oembed_request_post_id filter DocBlock.
Props swissspidy.
See #34523.
Built from https://develop.svn.wordpress.org/trunk@35470


git-svn-id: http://core.svn.wordpress.org/trunk@35434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 15:38:25 +00:00
Andrea Fercia
d5937d6a2c Dashboard: Activity widget CSS cleanup after [35420].
Props tyxla.
Fixes #34524. See #33558.
Built from https://develop.svn.wordpress.org/trunk@35469


git-svn-id: http://core.svn.wordpress.org/trunk@35433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 13:49:25 +00:00
Drew Jaynes
e6578e7b4f Docs: Use 3-digit, x.x.x-style semantic versioning in the DocBlocks for post_form_autocomplete_off() and WP_Filesystem_SSH2::sftp_path().
Props aaronrutley.
Fixes #34518.

Built from https://develop.svn.wordpress.org/trunk@35468


git-svn-id: http://core.svn.wordpress.org/trunk@35432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 13:16:24 +00:00
Gary Pendergast
1b30c48bca Embeds: Revert [35083], as the PNG files ended up not being used in [35466].
See #34204.


Built from https://develop.svn.wordpress.org/trunk@35467


git-svn-id: http://core.svn.wordpress.org/trunk@35431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 04:42:25 +00:00
Gary Pendergast
21393df10e Embeds: Add fallbacks for IE7-9.
Older IE versions need just that little bit of extra tender care to keep them going.

Props peterwilsoncc, swissspidy, pento.

Fixes #34204.


Built from https://develop.svn.wordpress.org/trunk@35466


git-svn-id: http://core.svn.wordpress.org/trunk@35430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-31 04:38:25 +00:00
Andrew Ozz
8edcfabf9c Responsive images: few more inline docs fixes.
Props jaspermdegroot.
See #34430.
Built from https://develop.svn.wordpress.org/trunk@35465


git-svn-id: http://core.svn.wordpress.org/trunk@35429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 23:36:25 +00:00
Andrew Ozz
2021bc0da2 Responsive images:
- Merge `wp_image_srcset_attr()` into `wp_calculate_image_srcset()`.
- Remove the `wp_image_srcset` filter.
- Fix the tests for the above changes. 

See #34430.
Built from https://develop.svn.wordpress.org/trunk@35464


git-svn-id: http://core.svn.wordpress.org/trunk@35428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 23:27:24 +00:00
Andrea Fercia
f014928b44 Media: Restore proper conditional statement broken after [35427].
Unprops afercia.
See #34273.
Built from https://develop.svn.wordpress.org/trunk@35463


git-svn-id: http://core.svn.wordpress.org/trunk@35427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 22:06:24 +00:00