Commit Graph

16253 Commits

Author SHA1 Message Date
Scott Taylor
4ce271ea86 Cleanup the @property annotations for WP_User.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31555


git-svn-id: http://core.svn.wordpress.org/trunk@31536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:54:24 +00:00
Scott Taylor
7cb45f2402 Don't call the size function count() as part of a test condition in loops. Compute the size beforehand, and not on each iteration.
Scrutinizer added a Performance label: these are the only violations.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31554


git-svn-id: http://core.svn.wordpress.org/trunk@31535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:48:24 +00:00
Scott Taylor
94bd0f93b8 wp_insert_comment() should be checking and setting $compacted, not the non-existent $post_data.
See [31263], #21212.

Built from https://develop.svn.wordpress.org/trunk@31553


git-svn-id: http://core.svn.wordpress.org/trunk@31534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:38:24 +00:00
Scott Taylor
4310147e54 Add missing access modifiers to WP_Press_This.
See #31456.

Built from https://develop.svn.wordpress.org/trunk@31552


git-svn-id: http://core.svn.wordpress.org/trunk@31533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 05:18:25 +00:00
Drew Jaynes
50bb433c66 Ignore the internal-use function _wp_posts_page_notice() from parsing for the code reference.
See #17470.

Built from https://develop.svn.wordpress.org/trunk@31551


git-svn-id: http://core.svn.wordpress.org/trunk@31532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 03:08:28 +00:00
Helen Hou-Sandí
ae3baa7c5b Hide irrelevant UI and display a message when editing the page for posts.
Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.

Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.

props alexkingorg for the initial, long-suffering patch.
fixes #17470.

Built from https://develop.svn.wordpress.org/trunk@31550


git-svn-id: http://core.svn.wordpress.org/trunk@31531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 02:47:25 +00:00
Andrew Ozz
9e7561a8d4 Press This: fix notices/errors classes. Props michael-arestad. Fixes #31456.
Built from https://develop.svn.wordpress.org/trunk@31549


git-svn-id: http://core.svn.wordpress.org/trunk@31530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 01:31:26 +00:00
Andrew Ozz
5f27c59f49 TinyMCE: wpView improvements: remove the (obsolete) get/setViewText methods. Update stopping/pausing of multiple ME media players. Props iseulde. See #31412.
Built from https://develop.svn.wordpress.org/trunk@31548


git-svn-id: http://core.svn.wordpress.org/trunk@31529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-26 00:31:31 +00:00
Andrew Ozz
c30c705ec3 Press This: add press-this.css to the list of stylesheets that are minified. Bump wp_version. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31547


git-svn-id: http://core.svn.wordpress.org/trunk@31528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 23:49:24 +00:00
Andrew Ozz
b799bd8e33 TinyMCE: wpView improvements:
- Better structure, simpler "view" registration, better extensibility.
- Better inline documentation.
- Don't show a placeholder for pasted link until we know the link is "embeddable'.
And many more improvements. Props iseulde. See #31412.
Built from https://develop.svn.wordpress.org/trunk@31546


git-svn-id: http://core.svn.wordpress.org/trunk@31527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 23:13:25 +00:00
Andrew Ozz
3146475ed8 PressThis: go back to loading the minified bookmarklet content with file_get_contents(). Add Grunt task to minify bookmarklet.js on precommit and update it in /src. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31545


git-svn-id: http://core.svn.wordpress.org/trunk@31526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 20:16:24 +00:00
Drew Jaynes
0c45c387be Add a missing file header to wp-includes/class-wp-customize-widgets.php, separate out the class DocBlock for WP_Customize_Widgets.
Fixes #31446.

Built from https://develop.svn.wordpress.org/trunk@31544


git-svn-id: http://core.svn.wordpress.org/trunk@31525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:20:26 +00:00
Drew Jaynes
26f8fbd705 Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-setting.php.
* Adds a file header separate from the `WP_Customize_Setting` class block
* Fixes formatting for the `WP_Customize_Setting`, `WP_Customize_Filter_Setting`, `WP_Customize_Header_Image_Setting`, and `WP_Customize_Background_Image_Setting` class DocBlocks.

See #31446.

Built from https://develop.svn.wordpress.org/trunk@31543


git-svn-id: http://core.svn.wordpress.org/trunk@31524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:18:26 +00:00
Drew Jaynes
2058532f43 Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-section.php.
* Adds a file header separate from the `WP_Customize_Section` class block
* Fixes formatting for the `WP_Customize_Section`, `WP_Customize_Themes_Section`, and `WP_Customize_Sidebar_Section` class DocBlocks.

See #31446.

Built from https://develop.svn.wordpress.org/trunk@31542


git-svn-id: http://core.svn.wordpress.org/trunk@31523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:13:26 +00:00
Drew Jaynes
6a899c6709 Add a missing file header to wp-includes/class-wp-customize-panel.php, separate out the class DocBlock for WP_Customize_Panel.
See #31446.

Built from https://develop.svn.wordpress.org/trunk@31541


git-svn-id: http://core.svn.wordpress.org/trunk@31522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:09:25 +00:00
Drew Jaynes
5c2c3a961d Add a missing file header to wp-includes/class-wp-customize-manager.php, separate out the class DocBlock for WP_Customize_Manager.
See #31446.

Built from https://develop.svn.wordpress.org/trunk@31540


git-svn-id: http://core.svn.wordpress.org/trunk@31521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 08:07:24 +00:00
Drew Jaynes
8ffc38ce7c Add a missing file header and clean up class DocBlocks in wp-includes/class-wp-customize-control.php.
* Adds a file header separate from the `WP_Customize_Control` class block
* Fixes formatting for the `WP_Customize_Control`, `WP_Customize_Color_Control`, `WP_Customize_Upload_Control`, `WP_Customize_Image_Control`, `WP_Customize_Background_Image_Control`, `WP_Customize_Theme_Control`, `WP_Customize_New_Theme_Control`, `WP_Widget_Area_Customize_Control`, and `WP_Widget_Form_Customize_Control` class DocBlocks.
* Adds a missing class DocBlock for `WP_Customize_Header_Image_Control`

See #31446.

Built from https://develop.svn.wordpress.org/trunk@31539


git-svn-id: http://core.svn.wordpress.org/trunk@31520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 07:56:25 +00:00
Andrew Ozz
d84eda9f35 Grunt precommit cleanup. See [31533], [31535].
Built from https://develop.svn.wordpress.org/trunk@31538


git-svn-id: http://core.svn.wordpress.org/trunk@31519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 04:17:27 +00:00
Andrew Ozz
64092c309d Press This: JSON encode the URL before appending it to the bookmarklet. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31537


git-svn-id: http://core.svn.wordpress.org/trunk@31518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 03:58:25 +00:00
Mark Jaquith
bd2c067245 Make sure WP_Customize_Manager::theme() never returns null.
* Fixes issue in [31533] that caused unit test fatal error

fixes #31445
Built from https://develop.svn.wordpress.org/trunk@31536


git-svn-id: http://core.svn.wordpress.org/trunk@31517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 03:54:25 +00:00
Andrew Ozz
ce8defbeb4 PressThis:
- Hard-code the minified bookmarklet js. Adding the non-minified bookmarklet to the browser bookmarks bar may have unexpected effect.
- Fix type juggling when checking the bookmarklet version.
Props stephdau, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31535


git-svn-id: http://core.svn.wordpress.org/trunk@31516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 03:03:25 +00:00
Andrew Ozz
1857055bb8 PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31534


git-svn-id: http://core.svn.wordpress.org/trunk@31515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 01:50:26 +00:00
Mark Jaquith
8b180b9a46 Add theme browsing and theme switching to the Customizer
* Brings into core the Customizer Theme Switcher feature plugin
* You can now browse, preview, and activate themes right from the Customizer

fixes #31303.
props celloexpressions, afercia, westonruter, folletto, designsimply
Built from https://develop.svn.wordpress.org/trunk@31533


git-svn-id: http://core.svn.wordpress.org/trunk@31514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 20:31:24 +00:00
Boone Gorges
0d9275930b Add 'orderby=description' support to get_terms().
This fixes an interface inconsistency in edit-tags.php, where Description
appears as a sortable column header.

Props neil_pie.
Fixes #31364.
Built from https://develop.svn.wordpress.org/trunk@31532


git-svn-id: http://core.svn.wordpress.org/trunk@31513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 16:37:26 +00:00
Sergey Biryukov
7c8b6609ca Fix line endings after [31522].
fixes #31430.
Built from https://develop.svn.wordpress.org/trunk@31531


git-svn-id: http://core.svn.wordpress.org/trunk@31512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 10:06:24 +00:00
Drew Jaynes
46286070a5 Clarify a wide variety of function, parameter, and return descriptions in DocBlocks throughout wp-includes/media.php.
Props stevegrunwell, DrewAPicture.
Fixes #28408.

Built from https://develop.svn.wordpress.org/trunk@31530


git-svn-id: http://core.svn.wordpress.org/trunk@31511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 07:42:24 +00:00
Drew Jaynes
4743843323 Add missing function and parameter descriptions to a variety of functions in wp-admin/includes/image-edit.php.
Props NikV for the initial patch.
Fixes #31353.

Built from https://develop.svn.wordpress.org/trunk@31529


git-svn-id: http://core.svn.wordpress.org/trunk@31510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 06:07:26 +00:00
Dion Hulse
90e85a70c4 Upgrades: Specifically pass the 'version' and 'locale' POST vars through the Core Update FTP credentials form.
This bug was introduced with [30384] / #30245
Fixes #31378 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31527


git-svn-id: http://core.svn.wordpress.org/trunk@31508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-24 03:01:25 +00:00
Andrew Ozz
481889c40b Load json2.js only in IE7 and older. Fixes #31276.
Built from https://develop.svn.wordpress.org/trunk@31526


git-svn-id: http://core.svn.wordpress.org/trunk@31507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 23:04:24 +00:00
Boone Gorges
e89d237b86 Pass taxonomy name, not object, to 'edit_term_taxonomy' and 'edited_term_taxonomy' actions.
These actions are fired in a number of different places, and in some cases
the tax name is passed, while in others the taxonomy object is passed. This
inconsistency made it difficult for plugins to use the `$taxonomy` value.

Props ipm-frommen.
Fixes #30999.
Built from https://develop.svn.wordpress.org/trunk@31525


git-svn-id: http://core.svn.wordpress.org/trunk@31506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 21:08:26 +00:00
Sergey Biryukov
ad30deda04 Menus: Remove fixed height from .description-thin fields.
props tyxla.
fixes #31426.
Built from https://develop.svn.wordpress.org/trunk@31524


git-svn-id: http://core.svn.wordpress.org/trunk@31505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 20:23:26 +00:00
Sergey Biryukov
132d65ef1e Menus: Prevent checkboxes and radio buttons from being stretched to full width on mobile.
props tyxla.
fixes #31425.
Built from https://develop.svn.wordpress.org/trunk@31523


git-svn-id: http://core.svn.wordpress.org/trunk@31504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 20:03:26 +00:00
Sergey Biryukov
aade870f17 Add unit tests for get_page_template_slug().
props tyxla.
fixes #31389.
Built from https://develop.svn.wordpress.org/trunk@31522


git-svn-id: http://core.svn.wordpress.org/trunk@31503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 18:47:27 +00:00
Sergey Biryukov
6221fc86a3 Fix a typo in wp_update_nav_menu_item hook documentation.
props tyxla.
fixes #31338.
Built from https://develop.svn.wordpress.org/trunk@31521


git-svn-id: http://core.svn.wordpress.org/trunk@31502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 16:51:25 +00:00
Sergey Biryukov
c6522e3c93 Add missing labels to Archives and Categories dropdown widgets.
props joedolson, jlevandowski, DrewAPicture, SergeyBiryukov.
fixes #18650.
Built from https://develop.svn.wordpress.org/trunk@31520


git-svn-id: http://core.svn.wordpress.org/trunk@31501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 16:32:25 +00:00
Sergey Biryukov
c6c5455d93 Themes: Use a darker color for "No themes found" message to increase contrast.
props joedolson.
see #26600.
Built from https://develop.svn.wordpress.org/trunk@31519


git-svn-id: http://core.svn.wordpress.org/trunk@31500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 15:49:27 +00:00
Jeremy Felt
646e643e5d Add comment-author-is-site-member class to comment output for site members.
Add a class to allow targeting of comments made by members of a site rather than users of the entire network.

Props Viper007Bond, MikeHansenMe.

Fixes #24054.

Built from https://develop.svn.wordpress.org/trunk@31518


git-svn-id: http://core.svn.wordpress.org/trunk@31499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 02:52:24 +00:00
Jeremy Felt
7644e68119 Provide proper label associations and descriptions throughout the network admin
* Add labels previously missing for many inputs throughout the network admin screen.
* Add proper `aria-describedby` attributes to provide better descriptions.
* Wrap grouped inputs with `fieldset` elements.
* Remove now unneeded `title` attributes when appropriate.

Props cfoellmann, afercia, rianrietveld.

Fixes #38406.

Built from https://develop.svn.wordpress.org/trunk@31517


git-svn-id: http://core.svn.wordpress.org/trunk@31498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 02:29:26 +00:00
Jeremy Felt
754636aaf1 Avoid clearing stored capabilities for a user when removing their built in role in multisite.
Previously, if “No role on this site” was assigned to a user AND that user did not have an empty role array stored for the site, the `$blog_prefix . ‘capabilities’` meta for that user would be deleted completely after changes to the user were saved. Any custom capabilities stored (i.e. `$user->add_role()`) would be removed as well.

This removes the code controlling the old WPMU handling of “no role” and allows custom stored capabilities to remain. Users with no role and custom capabilities will now appear in the users list table with “None” as the role.

In the process we’re able to better clarify the multisite specific pieces that do occur.

Props PeteMall, jeremyfelt.

Fixes #18934.

Built from https://develop.svn.wordpress.org/trunk@31516


git-svn-id: http://core.svn.wordpress.org/trunk@31497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 01:34:24 +00:00
Boone Gorges
1b6bb2f183 Ensure that a request URL is always set in WP_UnitTestCase::go_to().
Failure to set this variable meant that passing the home URL to `go_to()`
(without a trailing slash) resulted in a PHP notice, and failed to reset the
globals properly.

Props joostdevalk.
Fixes #31417.
Built from https://develop.svn.wordpress.org/trunk@31515


git-svn-id: http://core.svn.wordpress.org/trunk@31496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-23 01:08:25 +00:00
Jeremy Felt
5ac75b3b0a Use response code 200 when an existing network user joins a site via invitation.
Pass a response code of 200 to `wp_die()` when a user is successfully added to an individual site after using the `/newbloguser/` URL from an invite email. This is a user facing success message.

Props MikeHansenMe.

Fixes #31224.

Built from https://develop.svn.wordpress.org/trunk@31514


git-svn-id: http://core.svn.wordpress.org/trunk@31495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 22:30:25 +00:00
Andrew Ozz
19dbf7b998 Improve table footer tab sequence by moving <tfoot> after <tbody>. Props afercia, rianrietveld, DrewAPicture. Fixes #30914.
Built from https://develop.svn.wordpress.org/trunk@31513


git-svn-id: http://core.svn.wordpress.org/trunk@31494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:48:26 +00:00
Boone Gorges
0cd7554f75 Use PHP 5.2 compatible syntax in image tests.
T_PAAMAYIM_NEKUDOTAYIM, HAKUNA_MATATA, YOLO.

See [31510], #31124.
Built from https://develop.svn.wordpress.org/trunk@31512


git-svn-id: http://core.svn.wordpress.org/trunk@31493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:42:24 +00:00
Jeremy Felt
678982ee7e Do not activate plugins on initial installation in multisite.
Check `is_multisite()` before activating a plugin that has been installed via AJAX. Without this check, the plugin would be automatically activated on the main site of the network.

Props ianmjones.

Fixes #31327.

Built from https://develop.svn.wordpress.org/trunk@31511


git-svn-id: http://core.svn.wordpress.org/trunk@31492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:30:25 +00:00
Boone Gorges
3ef981335d Better image-type support checks in image unit tests.
PHP can be compiled without support for certain image types. Our unit tests
should be sensitive to these configurations.

Fixes #31124.
Built from https://develop.svn.wordpress.org/trunk@31510


git-svn-id: http://core.svn.wordpress.org/trunk@31491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 21:07:25 +00:00
Sergey Biryukov
0231047071 Delegate focusin and focusout events for row actions to make sure the actions are always revealed on focus.
props afercia.
fixes #29765.
Built from https://develop.svn.wordpress.org/trunk@31509


git-svn-id: http://core.svn.wordpress.org/trunk@31490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 20:14:25 +00:00
Sergey Biryukov
8eb25609e9 Dashboard: Add a filter for the query arguments used for the Recent Posts widget.
props danielbachhuber.
fixes #29374.
Built from https://develop.svn.wordpress.org/trunk@31508


git-svn-id: http://core.svn.wordpress.org/trunk@31489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:57:24 +00:00
Sergey Biryukov
93e5bb3702 Quick Edit: Make date fields a bit wider.
props Ravindra Pal Singh, janhenckens.
fixes #27912.
Built from https://develop.svn.wordpress.org/trunk@31507


git-svn-id: http://core.svn.wordpress.org/trunk@31488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 19:24:25 +00:00
Sergey Biryukov
4b21c67738 Remove untranslatable period from a successful update message in Bulk_Upgrader_Skin::add_strings().
props mako09, DrewAPicture.
fixes #30793.
Built from https://develop.svn.wordpress.org/trunk@31506


git-svn-id: http://core.svn.wordpress.org/trunk@31487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:07:24 +00:00
Dominik Schilling
2b9a79db8e Run Autoprefixer after [31504].
This removes media queries for Opera < 12 and `-ms-animation`/`@-ms-keyframes` which was never (dev versions excluded) supported by IE.

see #31337.
Built from https://develop.svn.wordpress.org/trunk@31505


git-svn-id: http://core.svn.wordpress.org/trunk@31486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 17:00:24 +00:00