Commit Graph

27105 Commits

Author SHA1 Message Date
Helen Hou-Sandí
c392ff6f90 Editor scrolling: reduce the amount of height jumping on load.
props avryl.
fixes #29307.

Built from https://develop.svn.wordpress.org/trunk@29628


git-svn-id: http://core.svn.wordpress.org/trunk@29402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 18:39:17 +00:00
Helen Hou-Sandí
e04df3d976 Give pagination controls some breathing room on smaller screens.
props stephdau.
fixes #29369.

Built from https://develop.svn.wordpress.org/trunk@29627


git-svn-id: http://core.svn.wordpress.org/trunk@29401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 17:07:17 +00:00
Helen Hou-Sandí
c6527579da Fix a CSS typo from [29625]. see #28946.
Built from https://develop.svn.wordpress.org/trunk@29626


git-svn-id: http://core.svn.wordpress.org/trunk@29400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 17:04:15 +00:00
Helen Hou-Sandí
9e8b9a78ca Media library: Unify headers between view modes.
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.

This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).

props pento, helen.
fixes #28946.

Built from https://develop.svn.wordpress.org/trunk@29625


git-svn-id: http://core.svn.wordpress.org/trunk@29399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 15:58:15 +00:00
Helen Hou-Sandí
227089cb07 Plugin details: Fix review scrolling in some browsers (cough, Chrome).
Remove some unnecessary CSS from [29619].

fixes #29321.

Built from https://develop.svn.wordpress.org/trunk@29624


git-svn-id: http://core.svn.wordpress.org/trunk@29398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 13:46:15 +00:00
Dominik Schilling
32030a073f RTL: Fix modal alignments.
* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778.

fixes #29352.
Built from https://develop.svn.wordpress.org/trunk@29623


git-svn-id: http://core.svn.wordpress.org/trunk@29397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 12:55:16 +00:00
Dominik Schilling
9972b54e62 Theme Upgrader: Set is_multi to true when doing bulk upgrades.
fixes #29234.
Built from https://develop.svn.wordpress.org/trunk@29622


git-svn-id: http://core.svn.wordpress.org/trunk@29396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 09:24:17 +00:00
Dominik Schilling
5a67538b40 Language Pack Upgrader: Remove any pre-existing package checks and then set the new one for translations.
fixes #29230.
Built from https://develop.svn.wordpress.org/trunk@29621


git-svn-id: http://core.svn.wordpress.org/trunk@29395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 09:20:18 +00:00
Andrew Nacin
3951d9689c Require a non-empty $nonce value in wp_verify_nonce().
props ocean90.
fixes #29217.

Built from https://develop.svn.wordpress.org/trunk@29620


git-svn-id: http://core.svn.wordpress.org/trunk@29394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 07:39:19 +00:00
Helen Hou-Sandí
67b0e365e2 Plugin details: better review styling.
props Clorith, celloexpressions.
fixes #29321.

Built from https://develop.svn.wordpress.org/trunk@29619


git-svn-id: http://core.svn.wordpress.org/trunk@29393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 05:49:17 +00:00
Helen Hou-Sandí
86f071355c Restore spacing on the edit screen when a post type supports title but not editor.
props avryl.
fixes #28893.

Built from https://develop.svn.wordpress.org/trunk@29618


git-svn-id: http://core.svn.wordpress.org/trunk@29392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 05:25:16 +00:00
Helen Hou-Sandí
7b75eff693 Image Details modal: Restore narrow responsive layout.
props celloexpressions.
fixes #29337.

Built from https://develop.svn.wordpress.org/trunk@29617


git-svn-id: http://core.svn.wordpress.org/trunk@29391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 05:20:16 +00:00
Helen Hou-Sandí
e51fdf9d7d Focus styling: bring the blue glow to more places.
Handles color picker, theme browser, help/screen options, TinyMCE dialog buttons, jQuery UI dialog buttons, and buttons in color schemes.

props avryl, celloexpressions. fixes #28267.

Built from https://develop.svn.wordpress.org/trunk@29616


git-svn-id: http://core.svn.wordpress.org/trunk@29390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 05:17:17 +00:00
Scott Taylor
149346ff6e MCE View sandboxes:
* Use a `MutationObserver` to listen to the `body` class of the parent editor frame.
* In `wpview_media_sandbox_styles()`, only return the MEjs stylesheets.
* In `wp_ajax_parse_media_shortcode()` and `wp_ajax_parse_embed()`, return an object instead of an HTML blob to allow passing `body` and `head` separately	

Props avryl, azaozz.
Fixes #29048.

Built from https://develop.svn.wordpress.org/trunk@29615


git-svn-id: http://core.svn.wordpress.org/trunk@29389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:46:15 +00:00
Helen Hou-Sandí
e051fe3341 Media: Fix keying of selected attachments to color schemes.
props celloexpressions. see #28822.

Built from https://develop.svn.wordpress.org/trunk@29614


git-svn-id: http://core.svn.wordpress.org/trunk@29388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:37:16 +00:00
Scott Taylor
80bda02c0f Media Modal:
* the Image Details frame does not have a menu, indicate that by setting `menu: false` when adding states.
* mimic the default router rendering by toggling a `hide-menu` class on the frame when the region for menu is `null`
* remove the dead render code for the Image Details frame

See #29339.

Built from https://develop.svn.wordpress.org/trunk@29613


git-svn-id: http://core.svn.wordpress.org/trunk@29387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:22:16 +00:00
Helen Hou-Sandí
60c6399d1c Media Grid: Show upload errors above the grid rather than as a popup.
props pento, stephdau, helen. fixes #29141.

Built from https://develop.svn.wordpress.org/trunk@29612


git-svn-id: http://core.svn.wordpress.org/trunk@29386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:18:17 +00:00
Andrew Nacin
b7e33dcd5a Install: Remove reference to readme and add a hyphen missing since 2007.
props ocean90.
fixes #29290.

Built from https://develop.svn.wordpress.org/trunk@29611


git-svn-id: http://core.svn.wordpress.org/trunk@29385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-26 04:05:20 +00:00
Helen Hou-Sandí
f348ccccf8 Customizer panels: use a single back button for all panels.
This also ensures the back button is visible on iOS devices.

props celloexpressions.
fixes #29135.

Built from https://develop.svn.wordpress.org/trunk@29610


git-svn-id: http://core.svn.wordpress.org/trunk@29384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 23:05:15 +00:00
Andrew Ozz
04e28b468c Media modal: fix the progress bar in the attachment thumbnail. Props gcorne, fixes #29367
Built from https://develop.svn.wordpress.org/trunk@29609


git-svn-id: http://core.svn.wordpress.org/trunk@29383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 22:45:16 +00:00
Helen Hou-Sandí
92ee5b230c Better visual focus syling in customizer, theme preview, and attachment details modals.
props celloexpressions.
fixes #29147.

Built from https://develop.svn.wordpress.org/trunk@29608


git-svn-id: http://core.svn.wordpress.org/trunk@29382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 21:58:17 +00:00
Helen Hou-Sandí
13a49fc018 Media:
* Make attachment focus styles more obvious, particularly for already selected items.
* Fix styling for the selection set attachments.
* Remove some CSS cruft.

fixes #28822.

Built from https://develop.svn.wordpress.org/trunk@29607


git-svn-id: http://core.svn.wordpress.org/trunk@29381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 21:26:16 +00:00
Andrew Ozz
a2ad27c03e TinyMCE wpView: exclude more non-printable keyCodes in isSpecialKey(), fixes #29115
Built from https://develop.svn.wordpress.org/trunk@29606


git-svn-id: http://core.svn.wordpress.org/trunk@29380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 20:41:16 +00:00
Helen Hou-Sandí
6a734800a7 Plugin details:
Prevent plugins with long names from looking bad and breaking layouts.

props stephdau. fixes #28883.

Built from https://develop.svn.wordpress.org/trunk@29605


git-svn-id: http://core.svn.wordpress.org/trunk@29379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 20:20:16 +00:00
Helen Hou-Sandí
31a8287b20 Correct cascade oversights in form CSS. fixes #28262.
Built from https://develop.svn.wordpress.org/trunk@29604


git-svn-id: http://core.svn.wordpress.org/trunk@29378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 19:53:16 +00:00
Andrew Ozz
d0a76f284f Media modal: when inserting content, prefer the editor id passed while opening the modal. wpActiveEditor can change in the background. (Includes some precommit prefixed selectors.) Fixes #28173
Built from https://develop.svn.wordpress.org/trunk@29603


git-svn-id: http://core.svn.wordpress.org/trunk@29377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 19:37:16 +00:00
Scott Taylor
d869fe0603 Media: cleanup recent changes to media.view.FocusManager.
* Adjusts the focus method to target the menu for the current modal
* Refactor the FocusManager so that the method names and the functionality matches more closely with how it currently works. The changes in 4.0 to the FocusManager change the purpose of the focus manager entirely — instead of being a way to save and restore focus state, the new FocusManager is about constraining keyboard navigation via the tab key to inside the modal. 

Props gcorne.
See #23560.

Built from https://develop.svn.wordpress.org/trunk@29602


git-svn-id: http://core.svn.wordpress.org/trunk@29376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 18:23:16 +00:00
Scott Taylor
db0b4c5b4d Media: when activating a mode after [29056], don't trigger the {mode}:activate event twice in a row.
See #29366.

Built from https://develop.svn.wordpress.org/trunk@29601


git-svn-id: http://core.svn.wordpress.org/trunk@29375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 18:07:15 +00:00
Scott Taylor
32e896f5b8 Media Grid: exit selection mode when Esc is pressed.
Fixes #29366.

Built from https://develop.svn.wordpress.org/trunk@29600


git-svn-id: http://core.svn.wordpress.org/trunk@29374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 17:45:17 +00:00
Sergey Biryukov
fa8e82efab Send nocache_headers() on installation screens and when redirecting to them.
fixes #29248.
Built from https://develop.svn.wordpress.org/trunk@29599


git-svn-id: http://core.svn.wordpress.org/trunk@29373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 17:40:16 +00:00
Helen Hou-Sandí
a20fc80aeb Media Grid: Move CSS into an admin-only file.
`media-views.css` can be loaded on the front, which does not need this extra CSS.

fixes #29340.

Built from https://develop.svn.wordpress.org/trunk@29598


git-svn-id: http://core.svn.wordpress.org/trunk@29372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 16:51:15 +00:00
Helen Hou-Sandí
b1b7d5f3a2 Only show one search form for the plugin installer.
The field dropdown now appears in the filter bar only when doing a search.

see #28785.

Built from https://develop.svn.wordpress.org/trunk@29597


git-svn-id: http://core.svn.wordpress.org/trunk@29371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 16:03:16 +00:00
Helen Hou-Sandí
713857625e Make filter bar CSS less verbose and redundant.
Also removes an unused handler in the theme feature filter.

see #28794.

Built from https://develop.svn.wordpress.org/trunk@29596


git-svn-id: http://core.svn.wordpress.org/trunk@29370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:58:15 +00:00
Andrew Nacin
4261ce75a6 Plugins: Only show details link if user can install plugins.
fixes #17902.

Built from https://develop.svn.wordpress.org/trunk@29595


git-svn-id: http://core.svn.wordpress.org/trunk@29369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:28:17 +00:00
Sergey Biryukov
b06652da92 Install Plugins: Don't wp_die() if API can't be reached.
props johnbillion.
fixes #29361.
Built from https://develop.svn.wordpress.org/trunk@29594


git-svn-id: http://core.svn.wordpress.org/trunk@29368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 15:02:17 +00:00
Andrew Ozz
488e2aa4cf Editor expand: add border to the Text editor resize helper, helps calculating the height in some cases. Fixes #29225
Built from https://develop.svn.wordpress.org/trunk@29593


git-svn-id: http://core.svn.wordpress.org/trunk@29367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-25 03:43:17 +00:00
Andrew Ozz
58752f91db Editor scrolling: fix window height when switching Visual to Text and the editor is shorter. Props mackensen, fixes #29226.
Built from https://develop.svn.wordpress.org/trunk@29592


git-svn-id: http://core.svn.wordpress.org/trunk@29366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 23:12:15 +00:00
Andrew Nacin
15b0d10544 Plugin details: Adjust plugin title when it does not have a banner.
Smaller, bold, and Open Sans, like other modals. Only use Helvetica Neue when the plugin has a banner.

see [29040], see #27440.

Built from https://develop.svn.wordpress.org/trunk@29591


git-svn-id: http://core.svn.wordpress.org/trunk@29365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 20:48:15 +00:00
Andrew Nacin
bab83d0f5a Plugin details: Correctly calculate the height of the right column for plugins without banners.
Comment these magic numbers.

see #27440, [29474].

Built from https://develop.svn.wordpress.org/trunk@29590


git-svn-id: http://core.svn.wordpress.org/trunk@29364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 20:45:17 +00:00
Helen Hou-Sandí
ea05215581 Version bump.
Built from https://develop.svn.wordpress.org/trunk@29589


git-svn-id: http://core.svn.wordpress.org/trunk@29363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 18:44:18 +00:00
Andrew Nacin
491f5cec39 Screen: Move editor scrolling screen option to the proper place.
see [29336], see #28328.

Built from https://develop.svn.wordpress.org/trunk@29588


git-svn-id: http://core.svn.wordpress.org/trunk@29362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:57:16 +00:00
Andrew Nacin
fa120992e4 Equal margins for plugin icons. see #28785.
Built from https://develop.svn.wordpress.org/trunk@29587


git-svn-id: http://core.svn.wordpress.org/trunk@29361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:56:15 +00:00
Andrew Nacin
bb4db92621 Plugin install: Add icons to compatible/incompatible. see #29313.
Built from https://develop.svn.wordpress.org/trunk@29586


git-svn-id: http://core.svn.wordpress.org/trunk@29360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 17:26:15 +00:00
Scott Taylor
1335ff3e40 Media Grid: Don't make checkboxes tabbable when in bulk select media grid mode, fixes tabbing in bulk select mode.
Props adamsilverstein.
See #28822.

Built from https://develop.svn.wordpress.org/trunk@29585


git-svn-id: http://core.svn.wordpress.org/trunk@29359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:55:15 +00:00
Scott Taylor
d5d0b37c35 Media Grid: restore focus to the selected item when shift-tab away from the attachment details sidebar.
Fixes #29303.

Built from https://develop.svn.wordpress.org/trunk@29584


git-svn-id: http://core.svn.wordpress.org/trunk@29358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:43:16 +00:00
Dominik Schilling
3a980c39c8 Apply accessibility improvements to Plugins screen too.
props SergeyBiryukov.
fixes #29342.
Built from https://develop.svn.wordpress.org/trunk@29583


git-svn-id: http://core.svn.wordpress.org/trunk@29357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:22:16 +00:00
Helen Hou-Sandí
8a545bf05e Media: Only fire keyboard events for the Attachments view once.
Firing them twice was breaking arrow key navigation in media attachment grids.

props gcorne.
fixes #29304.

Built from https://develop.svn.wordpress.org/trunk@29582


git-svn-id: http://core.svn.wordpress.org/trunk@29356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:17:16 +00:00
Dominik Schilling
49937c88f9 Plugin compatibility is based on your version of WordPress, not your install.
fixes #29313.
Built from https://develop.svn.wordpress.org/trunk@29581


git-svn-id: http://core.svn.wordpress.org/trunk@29355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:14:16 +00:00
Dominik Schilling
6c9853930a Add missing array keys for connection type in request_filesystem_credentials().
see [28456].
fixes #29347.

Built from https://develop.svn.wordpress.org/trunk@29580


git-svn-id: http://core.svn.wordpress.org/trunk@29354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 16:04:18 +00:00
Andrew Ozz
61292620c5 Editor scrolling:
- Pin the TinyMCE statusbar (elements path) to the bottom.
- Add support for pinning the menu when present.
- Add borders from CSS.
- Optimize getting most elements outerHeight.
Part props avryl, fixes #29293, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29579


git-svn-id: http://core.svn.wordpress.org/trunk@29353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-24 05:11:16 +00:00