Commit Graph

39 Commits

Author SHA1 Message Date
Weston Ruter
ceb151029c Bundled Themes: Use defer loading strategy for theme scripts.
* Add `defer` loading strategy for all frontend end-user theme scripts (excluding Customizer preview).
* Move scripts to the `head` which relate to the initial page viewport to ensure they start loading earlier and execute sooner while still not blocking rendering.
* Update Twenty Twenty's script loader (`TwentyTwenty_Script_Loader`) to support core's built-in script loading strategies (#12009), while also retaining backwards-compatibility for child themes that may set `async` and `defer` script data.
* Update the main script loading strategy in Twenty Twenty from `async` to `defer` for better performance on repeat page views, since when an `async` script is cached it will block rendering.

Props westonruter, flixos90, sabernhardt.
Fixes #59316.

Built from https://develop.svn.wordpress.org/trunk@56556


git-svn-id: http://core.svn.wordpress.org/trunk@56068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-12 00:06:19 +00:00
Sergey Biryukov
b80ce60f70 Coding Standards: Use pre-increment/decrement for stand-alone statements.
Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:
* [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators WordPress PHP Coding Standards: Increment/decrement operators]
* [https://github.com/WordPress/WordPress-Coding-Standards/pull/2130 WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators]

Props jrf.
See #59161, #58831.
Built from https://develop.svn.wordpress.org/trunk@56549


git-svn-id: http://core.svn.wordpress.org/trunk@56061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-09 09:28:26 +00:00
desrosj
741c88b2ef Bundled Themes: Bump version numbers for WordPress 6.2.
In coordination with the release of 6.2, a new version of each bundled theme will also be released. This bumps the version of each theme to the following:

- Twenty Ten: 3.8
- Twenty Eleven: 4.3
- Twenty Twelve: 3.9
- Twenty Thirteen: 3.8
- Twenty Fourteen: 3.6
- Twenty Fifteen: 3.4
- Twenty Sixteen: 2.9
- Twenty Seventeen: 3.2
- Twenty Nineteen: 2.5
- Twenty Twenty: 2.2
- Twenty Twenty-One: 1.8
- Twenty Twenty-Two: 1.4
- Twenty Twenty-Three: 1.1

Props robinwpdeveloper, costdev, audrasjb, sabernhardt, desrosj.
Fixes #57689.
Built from https://develop.svn.wordpress.org/trunk@55476


git-svn-id: http://core.svn.wordpress.org/trunk@55009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-03-07 16:27:18 +00:00
Sergey Biryukov
803426a023 Coding Standards: Use strict comparison in bundled themes' PHP files.
This addresses all the remaining WPCS warnings in bundled themes.

Includes using the correct type when checking the number of comments, as `get_comments_number()` returns a numeric string, not an integer.

Follow-up to [41285], [44562], [47941].

Props aristath, poena, afercia, SergeyBiryukov.
See #56791.
Built from https://develop.svn.wordpress.org/trunk@55420


git-svn-id: http://core.svn.wordpress.org/trunk@54953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-24 06:23:23 +00:00
audrasjb
ca5bf74221 Twenty Eleven: Remove useless title attributes.
This changeset removes `title` attributes from various links, as they are adding redundant information.

Props sabernhardt.
See #57199, #24766, #24203.

Built from https://develop.svn.wordpress.org/trunk@54884


git-svn-id: http://core.svn.wordpress.org/trunk@54436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-11-26 22:39:10 +00:00
Sergey Biryukov
7932193708 Coding Standards: Use strict comparison where static strings are involved.
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47808


git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov
001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov
e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Sergey Biryukov
83187125e4 Bundled Themes: Audit and update version numbers passed to wp_enqueue_script() to ensure proper cache busting.
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981.
Built from https://develop.svn.wordpress.org/trunk@45768


git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:29:58 +00:00
Gary Pendergast
28a8f31ffa Coding Standards: Add missing translator comments.
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.

Also, WPCS now doesn't show missing translator comment warnings for test files.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45604


git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 08:04:57 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Lance Willett
dcf53d5bbb Twenty Eleven: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31265


git-svn-id: http://core.svn.wordpress.org/trunk@31246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:42:23 +00:00
Andrew Nacin
f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett
25d1363a66 Twenty Eleven: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25625


git-svn-id: http://core.svn.wordpress.org/trunk@25542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 16:50:11 +00:00
Lance Willett
a738cc3c83 Bundled themes: remove the_title_attribute() title attributes where it duplicates the_title() in anchor text. Props nacin, fixes #24203.
git-svn-id: http://core.svn.wordpress.org/trunk@24131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 16:57:30 +00:00
Lance Willett
9886963778 Twenty Eleven: escape i18n attributes as late as possible, props mfields. See #21756.
git-svn-id: http://core.svn.wordpress.org/trunk@22199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 21:30:42 +00:00
ryan
55958522c1 Back compat for bundled themes. Props nacin, SergeyBiryukov, kobenland. fixes #20768
git-svn-id: http://core.svn.wordpress.org/trunk@20983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 14:43:19 +00:00
nacin
cd229781b3 Remove unused variable. see #20265.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 21:38:22 +00:00
nacin
1a265e464c Move Twenty Ten and the rest of Twenty Eleven to add_theme_support() for headers and backgrounds. props sabreuse for initial patch. fixes #20265. see #20249.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 21:32:42 +00:00
westi
13b56f8880 TwentyEleven: Always call the loop properly in all template files rather than just calling the_post(). Fixes #18794 props mfields.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 16:20:49 +00:00
azaozz
1a50d6ee95 Simplify some Twenty-Eleven strings for i18n, props nbachiyski, fixes #17777
git-svn-id: http://svn.automattic.com/wordpress/trunk@18348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-27 20:24:23 +00:00
azaozz
d41f756348 TwentyEleven Theme H1 Priority, props iandstewart, fixes #17611
git-svn-id: http://svn.automattic.com/wordpress/trunk@18335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-23 23:03:46 +00:00
ryan
46f63a6b1e Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@18276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-11 15:44:06 +00:00
dd32
b1c7cbf568 Showcase template cleanup. See #17748
git-svn-id: http://svn.automattic.com/wordpress/trunk@18269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-11 05:07:18 +00:00
dd32
27ec6b7e00 Remove debug comments & more housecleaning. See #17748
git-svn-id: http://svn.automattic.com/wordpress/trunk@18266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-11 03:44:42 +00:00
ryan
a6e286b3bd Use no_found_rows for some queries. Props pavelevap. fixes #17745
git-svn-id: http://svn.automattic.com/wordpress/trunk@18239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 20:14:59 +00:00
iandstewart
6d99619150 Twenty Eleven: check for published posts on the showcase page to prevent trashed sticky posts from appearing in the featured post loop; Props kawauso
git-svn-id: http://svn.automattic.com/wordpress/trunk@18218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-09 16:53:01 +00:00
iandstewart
ff1a97a7fc Twenty Eleven: make sure we're checking for sticky posts at the correct time in showcase.php
git-svn-id: http://svn.automattic.com/wordpress/trunk@18216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-09 16:39:40 +00:00
iandstewart
af7b7c70ab Twenty Eleven: miscellaneous bug fixes and improvements
* Only style images uploaded to the WordPress media library with border styles (and not placeholder images for content added by plugins)
* Prevent content added by plugins and long custom excerpts from overflowing the featured post slider
* Make sure small thumbnails will never appear in the Custom Header area
* Better indicate the current featured post with custom link color and cursor
* Add a class for text-only featured posts
* Style improvements for small screens


git-svn-id: http://svn.automattic.com/wordpress/trunk@18181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-07 21:28:56 +00:00
nacin
7f98b9beaf Fix Twenty Eleven phpdoc subpackage names. props zeo, fixes #17444.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 19:06:09 +00:00
lancewillett
e94b17390b Twenty Eleven: fix changes in r17846, props nacin - see #17198
* Simplify WP_Query call to pass args directly
 * Don't use Yoda Conditions for <, >, <=, >= as they can be hard to read (ref: http://codex.wordpress.org/WordPress_Coding_Standards#Yoda_Conditions)
 * Fix typo in query args

git-svn-id: http://svn.automattic.com/wordpress/trunk@17847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-09 23:15:38 +00:00
lancewillett
aee2fce01f Twenty Eleven: showcase template improvements - see #17198 (props kawauso for patches)
* Only show "featured-posts" area if there are published sticky posts.
 * If there is only one sticky, hide the slider and just display the single featured post.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-09 22:54:55 +00:00
lancewillett
b89437791b Twenty Eleven: style improvements, RTL, and more header images - see #17198
* Add two more default header images (see r17729)
* Change the featured posts limit from 4 to ten in front page slider
* First pass at robust RTL styles
* Pingback style fixes
* Wider comment form for the one column layout
* Add CSS comment with instructions on how to remove the post format headings


git-svn-id: http://svn.automattic.com/wordpress/trunk@17790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-03 20:16:34 +00:00
iandstewart
ff4d0e5249 Twenty Eleven: updated DocBlock comments following Twenty Ten's example; See #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-02 21:04:44 +00:00
lancewillett
372e5fd8de Twenty Eleven: style.css cleanup and Showcase template improvements, props matveb - see #17198
* Add full support for the featured slider powered by JS (except auto-slide)
 * Change the title hover state of large stickies to white
 * Prevent plain text posts from being displayed transparently over images
 * Update slider featured image size to 500x300
 * Add comment blocks to showcase.php

git-svn-id: http://svn.automattic.com/wordpress/trunk@17761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-29 00:19:02 +00:00
lancewillett
89bad03498 Twenty Eleven: add support for Status and Quote formats, props iandstewart - see #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-26 18:46:31 +00:00
lancewillett
972a41501e Twenty Eleven: strip trailing spaces, props kawauso - see #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-26 18:34:52 +00:00
matt
7d581043df Importing Duster theme, first pass at a candidate for twentyeleven theme.
Nice to have, but optional, improvements it'd be nice to have:

* Ability to have random rotating headers. (Core improvement to custom header functionality.)
* Color and layout options.
* More post formats. (Currently supporst  Asides, Links, and Galleries.)
* CMS-style slider home page option.

Welcome, TwentyEleven née Duster. :) Track at #17198.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-20 21:46:33 +00:00