Commit Graph

23 Commits

Author SHA1 Message Date
omarreiss
bdbaccce37 General: Explicitly assigns all JS globals to the window.
Many variables in the JavaScript were defined in the global scope without being explicitly assigned to the window. When built with Webpack, the code gets encapsulated in anonymous functions and those implicit globals get assigned to the wrong scope. This patch prevents that from happening.

Fixes #44371. See #43731.

Built from https://develop.svn.wordpress.org/trunk@43577


git-svn-id: http://core.svn.wordpress.org/trunk@43406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-19 13:33:24 +00:00
atimmer
bde558be2f Docs: Add file doc @output annotations.
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.

The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.

Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361.

Built from https://develop.svn.wordpress.org/trunk@43347


git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
atimmer
d268976255 Docs: Improve JSDoc for password-strength-meter.js.
Props herregroen, carolinegeven, ireneyoast, jjcomack.
Fixes #43066.

Built from https://develop.svn.wordpress.org/trunk@42528


git-svn-id: http://core.svn.wordpress.org/trunk@42357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 13:39:33 +00:00
Peter Wilson
26c07ed8d9 Users: Check zxcvbn is defined before calling.
Prevents JavaScript errors by checking zxcvbn is defined before calling.

Changes `wp.passwordStrength.meter()` to return `-1` if the strength of the password is unknown.

On the user profile screen, `generatePassword()` checks if the user has entered the password before setting the value of the password input box.

Props peterwilsoncc, adamsilverstein.
Fixes #34905.

Built from https://develop.svn.wordpress.org/trunk@37940


git-svn-id: http://core.svn.wordpress.org/trunk@37881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-01 12:45:29 +00:00
Drew Jaynes
b1804afeaf Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.

Built from https://develop.svn.wordpress.org/trunk@37431


git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 18:41:31 +00:00
Andrew Nacin
12acfa4e81 Fix JSHint errors in 3 files.
props atimmer.
fixes #25990, #25993, #26008.

Built from https://develop.svn.wordpress.org/trunk@26199


git-svn-id: http://core.svn.wordpress.org/trunk@26107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 05:12:09 +00:00
Andrew Nacin
b13c7791a9 Awesome about page design for WordPress 3.7.
The page includes a giant password meter that serves as both an animated example and a working demo. How cool is that?

props jorbin, melchoyce.
see #25603.

Built from https://develop.svn.wordpress.org/trunk@25839


git-svn-id: http://core.svn.wordpress.org/trunk@25839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:12 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
328a847bc1 Awesome about page design for WordPress 3.7.
The page includes a giant password meter that serves as both an animated example and a working demo. How cool is that?

props jorbin, melchoyce.
see #25603.

Built from https://develop.svn.wordpress.org/trunk@25839


git-svn-id: http://core.svn.wordpress.org/trunk@25751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 08:11:09 +00:00
Andrew Nacin
5bb48eba35 Expand the zxcvbn password meter blacklist, based on user input.
props iandunn.
see #25174.

Built from https://develop.svn.wordpress.org/trunk@25637


git-svn-id: http://core.svn.wordpress.org/trunk@25554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 06:47:10 +00:00
Andrew Nacin
09e92faa6c Use Dropbox's zxcvbn library for our password meter.
The library was added in [25156].

props duck_.
see #21737.

Built from https://develop.svn.wordpress.org/trunk@25157


git-svn-id: http://core.svn.wordpress.org/trunk@25136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-28 16:09:10 +00:00
Andrew Nacin
2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
westi
7186208818 Bring back a seperate js file for the password strength meter and correctly mark it as a dependancy of the user profile code. See #5919.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 06:39:20 +00:00
scribu
08e984e5e8 move password-strength-meter.js into user-profile.js. See #5919
git-svn-id: http://svn.automattic.com/wordpress/trunk@15780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-12 20:29:19 +00:00
nacin
6ae5b10973 Squeeze out some bytes via munging.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 13:39:44 +00:00
dd32
db0706ea0e Add Password Mismatch feedback to the Password Strength Meter. Props dancole. Fixes #12576
git-svn-id: http://svn.automattic.com/wordpress/trunk@13900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-31 08:45:51 +00:00
azaozz
a750885c8e Minify all js and add the non-minified files as .dev.js
git-svn-id: http://svn.automattic.com/wordpress/trunk@10291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-02 15:08:58 +00:00
ryan
e89192b1a8 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-09 18:03:31 +00:00
ryan
3942c97d46 Improved password strength meter from Otto42. fixes #7124
git-svn-id: http://svn.automattic.com/wordpress/trunk@9276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-22 04:20:50 +00:00
azaozz
f2dd6dd861 Few small improvements to the password strength meter.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-24 14:35:46 +00:00
ryan
fb488bb835 i18n fixes from nbachiyski. fixes #6226
git-svn-id: http://svn.automattic.com/wordpress/trunk@7302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-14 20:17:17 +00:00
ryan
04c9051a7d Remove trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@7130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-02 20:17:30 +00:00
ryan
67b50add23 Rename file. see #4470
git-svn-id: http://svn.automattic.com/wordpress/trunk@6422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-19 22:46:02 +00:00