Bot (Assets)
4f3c1bb8f1
Compress scripts/styles: 3.5-RC3-23084.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:42:44 +00:00
Andrew Nacin
173806d7a1
Restore the Description field to the media UI in 3.5.
...
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.
Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.
Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.
Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768 , this should be fixed. For now, Description stays.
This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984 ). So, here is a more obvious 'workaround' for the tooltip community.
Finally, this:
* Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
* Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
* Hides the 'Describe this file...' placeholder when a field is read-only in the modal.
props nacin, helenyhou.
fixes #22759 .
git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:41:06 +00:00
Bot (Assets)
7dab3d4538
Compress scripts/styles: 3.5-RC3-23080.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 21:22:59 +00:00
Ryan Boren
52a9a8cb81
Fix uploads in IE9
...
Props koopersmith
fixes #22762
git-svn-id: http://core.svn.wordpress.org/trunk@23079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 21:21:17 +00:00
Bot (Assets)
5927d8a3db
Compress scripts/styles: 3.5-RC3-23078.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:22:54 +00:00
Andrew Nacin
88f61468b3
Media: Final names for the actions in the dialog sidebar: "Insert from URL" and "Set Featured Image" to go with "Insert Media" and "Create Gallery".
...
Longer strings (such as a translation) looks excellent when it wraps to another line.
props markjaquith, fixes #22753 .
git-svn-id: http://core.svn.wordpress.org/trunk@23076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:07:48 +00:00
Andrew Nacin
c42ae7acb6
Media: Use '%d selected' for the selection string, and offer a comment to translators to help them find a workable solution with this would-be plural string. fixes #22749 . see #22229 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 19:03:38 +00:00
Bot (Assets)
fb433d2597
Compress scripts/styles: 3.5-RC3-23073.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:58:32 +00:00
Mark Jaquith
bc8ddb3e64
Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
...
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:29:24 +00:00
Mark Jaquith
4d35b3409b
Implement tabbing between fields in the media modal. props lessbloat, koopersmith. fixes #22659
...
git-svn-id: http://core.svn.wordpress.org/trunk@23070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 09:57:58 +00:00
Mark Jaquith
d8d39ff764
When setting the featured image from the dedicated meta box, only show the featured image section in the media chooser. props koopersmith. fixes #22731
...
* Less distracting
* Some of these sections won't apply for CPTs without an editor
git-svn-id: http://core.svn.wordpress.org/trunk@23069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 09:43:10 +00:00
Mark Jaquith
e84a4a0c89
Fix the "Uploaded to this post" filter in the "Add to gallery" state. fixes #22723
...
Also, use "images" wording instead of generic "media items" when in a gallery (images-only) context. fixes #22722
Both are props koopersmith
git-svn-id: http://core.svn.wordpress.org/trunk@23068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 09:25:17 +00:00
Mark Jaquith
98fb6e45d7
Use data on the ui.item to transport the original Sortable index for the update() function. This way extensions can set/access this info in their own custom Sortable functions. see #22696
...
git-svn-id: http://core.svn.wordpress.org/trunk@23067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 09:04:19 +00:00
Bot (Assets)
48382b4b0a
Compress scripts/styles: 3.5-RC3-23066.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 04:58:33 +00:00
Ryan Boren
c4d04dd476
Clear the From URL view in the media modal after inserting an image. Improve button enable checks.
...
Props koopersmith
fixes #22740
git-svn-id: http://core.svn.wordpress.org/trunk@23065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 04:43:51 +00:00
Mark Jaquith
b6982a0804
Allow a sortable options hash to be passed in, so you can override the defaults. props koopersmith. see #22696
...
git-svn-id: http://core.svn.wordpress.org/trunk@23064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 04:11:49 +00:00
Bot (Assets)
1077e9ce03
Compress scripts/styles: 3.5-RC3-23059.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:58:34 +00:00
Andrew Nacin
a914ab2e43
Media models: Trac and ignore deleted attachments.
...
Treat an admin-ajax response of 1 as successful for backwards compatibility with existing handlers.
props koopersmith. fixes #22750 .
git-svn-id: http://core.svn.wordpress.org/trunk@23057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:31:41 +00:00
Andrew Nacin
e1405b6f1d
Media: Don't try to resize the bottom selection UI. props koopersmith. fixes #22748 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 01:38:44 +00:00
Andrew Nacin
dc9e6144be
Fix inserting of multiple attachments with captions when the first attachment does not have a caption. props azaozz. fixes #22720 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:59:25 +00:00
Bot (Assets)
87d43d7aa9
Compress scripts/styles: 3.5-RC3-23054.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:58:31 +00:00
Daryl Koopersmith
81d474cda0
Toggle display of plupload overlays when the select files button is hidden. see #22732 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:45:21 +00:00
Andrew Nacin
d720772ef3
Media: Return to the library when the editing a selection and all items get de-selected. props koopersmith. fixes #22715 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:22:11 +00:00
Ryan Boren
51db7de93b
When inserting an image From URL, show the fields only if it looks like we have a valid image.
...
Props koopersmith
fixes #22740
git-svn-id: http://core.svn.wordpress.org/trunk@23048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 23:07:41 +00:00
Bot (Assets)
d3b24a0e15
Compress scripts/styles: 3.5-RC3-23047. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:44:27 +00:00
Ryan Boren
c9db63ab1e
When deleting an image in the editor with the delete or backspace keys, hide the edit and delete popup buttons.
...
Props azaozz, lessbloat
fixes #22717
git-svn-id: http://core.svn.wordpress.org/trunk@23046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:42:26 +00:00
Ryan Boren
edf9769d26
In the media modal, clear attachment details when clearing the selection.
...
Props koopersmith
fixes #22718
git-svn-id: http://core.svn.wordpress.org/trunk@23045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:19:08 +00:00
Bot (Assets)
6cb358e0f4
Compress scripts/styles: 3.5-RC3-23043.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 20:58:33 +00:00
Andrew Nacin
bd5956087a
Media: When doing a multiple-insert into the editor, separate each inserted item with two line breaks. props tar.gz. see #22720 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 20:52:58 +00:00
Andrew Nacin
d47267224c
When adding images to a gallery, use "Images" as the filter name, rather than "All media items". props koopersmith. fixes #22722 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 20:51:37 +00:00
Bot (Assets)
affabf29f4
Compress scripts/styles: 3.5-RC3-23040.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:56:16 +00:00
Andrew Ozz
48ef1a9784
RTL: properly align the demo image in the Edit Image popup, props nacin, fixes #22733
...
git-svn-id: http://core.svn.wordpress.org/trunk@23039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:51:35 +00:00
Andrew Nacin
1c5c724b3a
Media: Properly select the select element's option in the attachment display settings. props koopersmith. fixes #22693 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:38:16 +00:00
Andrew Nacin
36554dd983
Move utils.js (cookie and user setting functions) to wp-includes to enable front-end use.
...
Make it a dependency of media-views (and therefore media-editor). Move its userSettings JS object from admin-header to being paired with the script in script loader.
see #22730 .
git-svn-id: http://core.svn.wordpress.org/trunk@23036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:29:56 +00:00
Bot (Assets)
392ade0221
Compress scripts/styles: 3.5-RC3-23035.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:58:30 +00:00
Ryan Boren
53f5c1cdc7
Better dropdown select handling.
...
Props cdog, koopersmith
fixes #22693
git-svn-id: http://core.svn.wordpress.org/trunk@23033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:50:49 +00:00
Ryan Boren
a200c702e0
Only show Delete in media modal if the user can delete.
...
Props nacin, koopersmith
fixes #22711
git-svn-id: http://core.svn.wordpress.org/trunk@23032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:33:51 +00:00
Ryan Boren
8603ed6082
Media: Hide "Edit" link in the selection view when it doesn't make sense
...
Props koopersmith, ocean90, nacin
fixes #22713
git-svn-id: http://core.svn.wordpress.org/trunk@23031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:23:47 +00:00
Bot (Assets)
dad33047b5
Compress scripts/styles: 3.5-RC3-23030.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:13:59 +00:00
Mark Jaquith
bc09152660
Fix a Firefox "scroll to bottom" bug when launching the media modal.
...
* Records main document scroll position when launching media modal.
* Restores position when media modal is closed.
* Also locks background document scrolling while media modal is open, preventing inadvertent scrolling there.
props koopersmith. fixes #22716
git-svn-id: http://core.svn.wordpress.org/trunk@23029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 17:58:24 +00:00
Mark Jaquith
82d51aeeef
Update toolbars for Embed screen. Fixes JS error. props koopersmith. fixes #22714
...
git-svn-id: http://core.svn.wordpress.org/trunk@23028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 17:45:24 +00:00
Bot (Assets)
32c83140d0
Compress scripts/styles: 3.5-RC3-23025.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 16:25:14 +00:00
Andrew Nacin
d2a9957ad8
Media: Disable 'Insert gallery' and 'Set featured image' if nothing is queued. Converts selection toolbars to use the newer view manager. props koopersmith, fixes #22714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 16:21:57 +00:00
Bot (Assets)
a1bb2f0054
Compress scripts/styles: 3.5-RC2-23018.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 06:58:31 +00:00
Mark Jaquith
55ac7a4565
Fix a typo in media-views.js that referenced frame.router.get() instead of frame.router. Fixes #22710
...
git-svn-id: http://core.svn.wordpress.org/trunk@23015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 05:18:21 +00:00
Bot (Assets)
6dee15c92e
Compress scripts/styles: 3.5-RC2-23013.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:58:31 +00:00
Ryan Boren
cbf378b601
Fix race condition in media insertion where the inserted html is invalid due to output being interleaved.
...
Props koopermsith
fixes #22696
git-svn-id: http://core.svn.wordpress.org/trunk@23012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:38:42 +00:00
Andrew Nacin
156c5fef0f
Media: When an image does not have all image sizes available, make sure we insert the requested size into the editor. props koopersmith. fixes #22693 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:04:45 +00:00
Bot (Assets)
30cf064068
Compress scripts/styles: 3.5-RC2-23007. props koopersmith. :-)
...
git-svn-id: http://core.svn.wordpress.org/trunk@23007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 01:29:58 +00:00
Ryan Boren
61a9471024
Final round of media UX improvements.
...
Props koopersmith
fixes #21390 #22502
git-svn-id: http://core.svn.wordpress.org/trunk@23006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 01:26:03 +00:00