Commit Graph

23 Commits

Author SHA1 Message Date
Andrea Fercia
faf11c8875 Accessibility: Improve the "Hello Dolly" accessibility.
- adds a visually hidden text to give context to the lyrics
- the text is `Quote from Hello Dolly song, by Jerry Herman:`
- adds a `lang` HTML attribute (when the admin language is not English) to better support assistive technologies 
- adds a `dir` HTML attribute to better support the LTR English lyrics with RTL languages 
- CSS adjustments

Props audrasjb, SergeyBiryukov, danieltj, birgire, karmatosed, desrosj, afercia.
Fixes #43632.

Built from https://develop.svn.wordpress.org/trunk@44929


git-svn-id: http://core.svn.wordpress.org/trunk@44760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-18 17:19:50 +00:00
desrosj
147ce45d29 Hello Dolly: Hide the lyrics in the block editor.
I'm sorry, Hello Dolly. You're my favorite plugin, but the way you output your lyrics doesn't play nicely with the block editor, particuarly on mobile devices.

This isn't Farewell Dolly, you're still on every other admin page, and I know you'll come back better and stronger.

Merges [43900] to trunk.

Props joen.
See #45345.
Built from https://develop.svn.wordpress.org/trunk@44229


git-svn-id: http://core.svn.wordpress.org/trunk@44059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 03:08:46 +00:00
Joe McGill
0a02c87b48 Update Hello Dolly lyrics.
This updates the Hello Dolly plugin to remove lines which could be objectionable when shown in the admin out of context, and brings the lyrics more in line with Louis Armstrong's recording.

Props sebastienthivinfocom, birgire, audrasjb, joemcgill.
Fixes #43555.

Built from https://develop.svn.wordpress.org/trunk@42839


git-svn-id: http://core.svn.wordpress.org/trunk@42669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-17 20:23:32 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Andrew Nacin
7ee6ad566d Remove /extend/ from Hello Dolly.
Well, hello, Dolly
It's so nice to have you back where you belong

fixes #24389.



git-svn-id: http://core.svn.wordpress.org/trunk@24322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:08:40 +00:00
nacin
e0c3676423 Hello Dolly 1.6. fixes typo, props sbressler, fixes #15229. Removes absolute from positioning, props kapeels, fixes #15228. Add some whitespace.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 12:43:04 +00:00
nacin
a613fa5d92 Wasn't me.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 02:23:57 +00:00
nacin
e58da4ac0a Add 'Check Again' button and timestamp to update-core. Also return the same error message for themes as we do for plugins when no checkboxes are checked. fixes #14764.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 02:21:49 +00:00
nacin
4d7c88f4a4 Introduce is_rtl(). Use it in core. It only becomes defined when locale is loaded, so it's impossible to use it too early. Deprecate the get_bloginfo('text_direction') call. fixes #13206.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 05:49:19 +00:00
ryan
9ab7306993 Remove author tags. fixes #12366
git-svn-id: http://svn.automattic.com/wordpress/trunk@13377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-24 19:07:21 +00:00
ryan
665989f969 RTL admin fixes. Props sambauers, nbachiyski. fixes #10159 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@11665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-06-29 00:40:26 +00:00
ryan
9fad7df3b2 Hello Dolly update. Props zedlander and jacobsantos. fixes #8188
git-svn-id: http://svn.automattic.com/wordpress/trunk@9684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-14 17:52:38 +00:00
westi
c0f224c020 phpdoc for hello dolly. See #7550 props jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-27 09:55:32 +00:00
ryan
aa70c022ce Update author link. Props JohnLamansky. fixes #7142
git-svn-id: http://svn.automattic.com/wordpress/trunk@8110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-16 22:30:46 +00:00
westi
bf15f62334 Line dolly up again.
git-svn-id: http://svn.automattic.com/wordpress/trunk@7097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-28 22:02:20 +00:00
westi
1e566cbf6a Update Hello Dolly for the new admin ui. Fixes #5657 props hansengel.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-16 15:07:31 +00:00
ryan
321c310717 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@6026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:32:58 +00:00
markjaquith
ea1d50ffc3 emergency Hello Dolly surgery. Crisis averted! Props joti. fixes #3282
git-svn-id: http://svn.automattic.com/wordpress/trunk@4423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-10-25 21:39:32 +00:00
matt
b6af74e8bf Freshen Dolly up
git-svn-id: http://svn.automattic.com/wordpress/trunk@2758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-08-07 10:30:53 +00:00
saxmatt
6584b204a6 Some cleanup patches from Scott: http://www.coffee2code.com/archives/2005/01/06/walking-with-15/
git-svn-id: http://svn.automattic.com/wordpress/trunk@2060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-01-06 23:10:28 +00:00
saxmatt
b6c44b22fe Updated hooks and a new Dolly plugin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@1340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-05-22 08:45:36 +00:00
saxmatt
10c6b7ea9c Changed to superglobals, and eliminated $use_cache (since we always do).
git-svn-id: http://svn.automattic.com/wordpress/trunk@1108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-04-20 22:56:47 +00:00
saxmatt
790f6e50eb Initial plugin funcitonality checkin. Not done yet.
git-svn-id: http://svn.automattic.com/wordpress/trunk@1008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-03-25 07:05:52 +00:00