Commit Graph

44 Commits

Author SHA1 Message Date
Sergey Biryukov
115866d483 Fix E_STRICT notice in WP_Theme_Install_List_Table::_js_vars(). see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-05 16:51:07 +00:00
Andrew Nacin
797ee34bc3 Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389.
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:01:57 +00:00
Ryan Boren
5f809d1d22 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:00:25 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Helen Hou-Sandí
b1f1579604 its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665.
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-20 15:55:32 +00:00
Andrew Nacin
1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
azaozz
34535097b7 Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar).
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.

Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.

See #21340.

git-svn-id: http://core.svn.wordpress.org/trunk@21311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 00:15:15 +00:00
koopersmith
14f04132af Theme Customizer: Fix scrolling on iOS and Kindle Fire. props azaozz, helenyhou. fixes #20805.
Also fixes uploader UIs on iOS and Kindle Fire by improving wp.Uploader.
Adds mobile viewport specifications.
Moves scrollbar back to fixed positioning.


git-svn-id: http://core.svn.wordpress.org/trunk@21014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:45:17 +00:00
ryan
cedff2638e Fix collapse button and return link markup for theme install preview. Props koopersmith. fixes #20800
git-svn-id: http://core.svn.wordpress.org/trunk@20968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 15:03:50 +00:00
koopersmith
32ed08e42b Theme Installer: Prevent unnecessary admin code from printing and print markup in correct order. Remove dead code. props ocean90, fixes #20695.
git-svn-id: http://core.svn.wordpress.org/trunk@20812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-16 23:38:53 +00:00
koopersmith
cf81f30e05 Install Themes: Add link to the no-js theme previewer to the 'Preview' link. props ocean90, fixes #20694.
git-svn-id: http://core.svn.wordpress.org/trunk@20811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-16 21:08:10 +00:00
koopersmith
ae14873b96 Theme Customizer: Prevent sidebar scrollbar from overlapping sidebar header or footer. fixes #20649, #20650, see #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-15 01:03:31 +00:00
ryan
260b3b07fb Normalize star ratings markup. Props helenyhou. fixes #20655
git-svn-id: http://core.svn.wordpress.org/trunk@20765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-10 19:59:48 +00:00
ryan
519af69e93 When showing already installed themes in the theme installer list, indicate in the row actions that the theme is installed and offer an update link if updates are available.
Props SergeyBiryukov
Fixes #20618


git-svn-id: http://core.svn.wordpress.org/trunk@20751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-09 15:01:49 +00:00
koopersmith
8d3c911831 Add 'Install now', 'Preview', and 'Details' links to theme install list items. fixes #20403.
git-svn-id: http://core.svn.wordpress.org/trunk@20730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-06 23:06:47 +00:00
nacin
608b26589e Default to keyword searches for the plugin and theme installers in case no search type is posted back. fixes #19619.
props georgestephanis, SergeyBiryukov for initial patches.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 00:44:47 +00:00
nacin
d17afd15a4 Reduce clutter and repetive functionality from the initial landing page for installing plugins and themes by removing the tag/author/term dropdown.
The tag cloud (plugins) and feature filter (themes) is sufficient for tag functionality. All three "search by" fields are already weighted for a standard keyword search through the WP.org API.

fixes #19619 for 3.4.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 19:37:19 +00:00
koopersmith
b909e55294 Theme browsing UX improvements. see #20403.
* On manage/install themes pages, moved author under theme name.
* On manage themes page, moved version number to details.

git-svn-id: http://svn.automattic.com/wordpress/trunk@20414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-10 00:15:13 +00:00
koopersmith
3230ba3987 Theme Customizer: Move 'collapse' button to footer and add a visible text label. see #19910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-07 00:10:22 +00:00
nacin
292f1e5f79 Deprecate display_theme(). see #19910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-07 18:29:36 +00:00
koopersmith
fba11c56e1 Theme Customizer: Make theme installer no-js compatible. Fix JS click handler that caught clicks on the 'Activate' link. Relocate display_theme() to WP_Theme_Install_List_Table->single_row(). see #19910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-07 18:24:34 +00:00
koopersmith
315033ca2a Theme Customizer: Begin integration into the install process. Combine previews, details, and install into a single workflow. see #19910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-07 17:35:17 +00:00
nacin
1fed7c5c11 Allow WP_List_Table::_js_vars() to take an array of additional args to add. Allows us to have a single variable printing data when child classes need more data. Also, fix compact() call in [20094]. see #19815.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 23:06:31 +00:00
nacin
177d1efb9f Use sanitize_key(). sanitize_title_with_dashes() is more than we need. see #19815. see [20096], [20097].
git-svn-id: http://svn.automattic.com/wordpress/trunk@20098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 22:32:29 +00:00
nacin
21663b39ea Revert [20096] which was an accidental partial revert of [20094]. see #19815.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 22:31:15 +00:00
nacin
4805a38f7d Use sanitize_key() for theme search tags/features. sanitize_title_with_dashes() is overkill. see #19815.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 22:26:58 +00:00
nacin
05313daa77 Output themes and theme-install infinite scrolling args in JS, rather than parsing query strings. props DH-Shredder, helenyhou. Make WP_Theme_Install_List_Table extend WP_Themes_List_Table. Doesn't help much yet, but we should be able to dry things up further. see #19815.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 22:09:26 +00:00
ryan
723bb1a99c Infinite scroll for themes.php and theme-install.php. Bump per page limit for themes.php to 999. Props helenyhou, DH-Shredder. see #19815
git-svn-id: http://svn.automattic.com/wordpress/trunk@19887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-09 17:20:26 +00:00
ryan
c1f604e78e Change feature filter from post to get so feature selections aren't lost when paging. Props SergeyBiryukov. fixes #18094
git-svn-id: http://svn.automattic.com/wordpress/trunk@19857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-07 21:06:52 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
azaozz
bff7722dd1 Responsive themes screen, props helenyhou, see #18198
git-svn-id: http://svn.automattic.com/wordpress/trunk@18673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-15 04:26:26 +00:00
nacin
37075f7f71 Remove AJAX from list tables. first pass. see #16262.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
ryan
d0e923486b Improve presentation when there are no available themes. Props solarissmoke, garyc40. fixes #16196
git-svn-id: http://svn.automattic.com/wordpress/trunk@17303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-15 00:35:29 +00:00
nacin
f9cdc3156d Leave the 'Try Again' link for the wp_die() when the themes API fails. props solarissmoke, fixes #16132.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-12 00:18:23 +00:00
nacin
f5cdbd1ded Add nonces to instances where the list table display() method is overridden. see #16188.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-11 22:42:22 +00:00
ryan
3bce6d9be9 List table spinner. Props scribu. see #15580
git-svn-id: http://svn.automattic.com/wordpress/trunk@17090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 18:45:05 +00:00
scribu
5fce5c6d14 Always display the table, with a placeholder row when there are no items. Fixes #15849
git-svn-id: http://svn.automattic.com/wordpress/trunk@17002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 19:05:14 +00:00
nacin
a189f21c45 Replace check_permissions() with ajax_user_can(). New method returns true/false to current_user_can(), which we then handle in admin ajax. see #15326.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 09:18:28 +00:00
scribu
4c56a85962 Use more specific view classes in plugin & theme install screens. Props batmoo. Fixes #15658
git-svn-id: http://svn.automattic.com/wordpress/trunk@16710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-03 18:51:24 +00:00
scribu
c5a9fd309d Default to get_current_screen() in list table classes. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@16182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-04 15:00:55 +00:00
westi
5e90c5d1c3 Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-04 08:07:03 +00:00
scribu
836ec33dca List-table Class Names: Consistency's Revenge. See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@16171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-03 21:09:27 +00:00
westi
ad92d629d6 The big renaming of the list-table class files.
See #14579

git-svn-id: http://svn.automattic.com/wordpress/trunk@16128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 09:19:50 +00:00