Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-24 01:57:53 +01:00
Code Issues Projects Releases Wiki Activity
31,290 Commits 50 Branches 749 Tags 806 MiB
514eb11cf4
Commit Graph

18526 Commits

Author SHA1 Message Date
Scott Taylor
cd7c0f0b0d Introduce wp_validate_action( $action = '' ), a helper function that checks $_REQUEST for action and returns it, or empty string if not present. If $action is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types. 
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.

Built from https://develop.svn.wordpress.org/trunk@34059


git-svn-id: http://core.svn.wordpress.org/trunk@34027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 21:08:26 +00:00
Dominik Schilling
d6f26e4c7c Site Icon: For preview fall back to full size URL when thumbnail size doesn't exist. 
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.

Props tyxla.
Fixes #33417.
Built from https://develop.svn.wordpress.org/trunk@34056


git-svn-id: http://core.svn.wordpress.org/trunk@34024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 20:13:25 +00:00
Dominik Schilling
09b159e494 About: Remove period from placeholder. 
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.

Props extendwings, chriscct7.
Fixes #33429.
Built from https://develop.svn.wordpress.org/trunk@34054


git-svn-id: http://core.svn.wordpress.org/trunk@34022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 19:27:24 +00:00
Dominik Schilling
a03488dbf6 Users: Import the global var $wp_hasher in wp_new_user_notification(). 
Adds `@global` entries to the DocBlock.

Fixes #33826.
Built from https://develop.svn.wordpress.org/trunk@34052


git-svn-id: http://core.svn.wordpress.org/trunk@34020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 19:10:26 +00:00
Dominik Schilling
008dca20b4 Docs: Fix DocBlock formatting for wp_insert_term(). 
Built from https://develop.svn.wordpress.org/trunk@34051


git-svn-id: http://core.svn.wordpress.org/trunk@34019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 18:48:24 +00:00
Scott Taylor
fa7bc4fda0 Upgrade MediaElement to 2.18.1 - monkey-patches to allow H264 in Chromium. 
Changelog: https://github.com/johndyer/mediaelement/compare/2.17.0...2.18.1

See #33798.

Built from https://develop.svn.wordpress.org/trunk@34050


git-svn-id: http://core.svn.wordpress.org/trunk@34018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 18:35:26 +00:00
Scott Taylor
2f0fc3b97d After [34048], restore the else statement for h (height of video) in wp_underscore_video_template(). 
See #33798.

Built from https://develop.svn.wordpress.org/trunk@34049


git-svn-id: http://core.svn.wordpress.org/trunk@34017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 18:30:26 +00:00
Scott Taylor
4b4f08c7a0 In [30082], hardcoded heights were removed on the front end for videos rendered via shortcode. These values were not removed from the admin, which was an oversight. 
See #33798.

Built from https://develop.svn.wordpress.org/trunk@34048


git-svn-id: http://core.svn.wordpress.org/trunk@34016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 18:27:25 +00:00
Scott Taylor
8ec224c2f9 Revert [34009], broke uploads. 
See #24934.


Built from https://develop.svn.wordpress.org/trunk@34047


git-svn-id: http://core.svn.wordpress.org/trunk@34015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 18:04:26 +00:00
Sergey Biryukov
0ffe65cf5c Use _x() instead of string hacks for weekday and month abbreviations. 
Props johnbillion.
Fixes #33716.
Built from https://develop.svn.wordpress.org/trunk@34046


git-svn-id: http://core.svn.wordpress.org/trunk@34014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 15:36:25 +00:00
Sergey Biryukov
99c85c5b45 Update the length limit in set_transient() docs after [34030]. 
Props OriginalEXE.
Fixes #13310.
Built from https://develop.svn.wordpress.org/trunk@34045


git-svn-id: http://core.svn.wordpress.org/trunk@34013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 15:10:27 +00:00
Sergey Biryukov
d9b7d915c2 Document @return value for wp_unschedule_event(). 
See #33475.
Built from https://develop.svn.wordpress.org/trunk@34044


git-svn-id: http://core.svn.wordpress.org/trunk@34012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 11:35:24 +00:00
Sergey Biryukov
f130fd6c32 Better align table headers with table cells on success screen after installing. 
Props umesh.nevase.
Fixes #33796.
Built from https://develop.svn.wordpress.org/trunk@34043


git-svn-id: http://core.svn.wordpress.org/trunk@34011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 11:26:26 +00:00
Scott Taylor
db4f22bfb5 After [33961], pass $comment to get_comment_link() where possible to avoid extra cache/db lookups. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34042


git-svn-id: http://core.svn.wordpress.org/trunk@34010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 06:21:25 +00:00
Scott Taylor
c3f642bea9 After [33961], pass $comment to get_comment_date() where possible to avoid extra cache/db lookups. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34041


git-svn-id: http://core.svn.wordpress.org/trunk@34009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 06:15:24 +00:00
Scott Taylor
58c3c30e8d After [33961], pass $comment to comment_class() where possible to avoid extra cache/db lookups. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34040


git-svn-id: http://core.svn.wordpress.org/trunk@34008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 06:12:24 +00:00
Scott Taylor
fc328f5484 After [33961], pass $comment to get_comment_author_link() where possible to avoid extra cache/db lookups. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34039


git-svn-id: http://core.svn.wordpress.org/trunk@34007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 06:05:24 +00:00
Scott Taylor
4465a83b95 After [34015], handle orphaned comments in the Dashboard comments widget. Pass full $comment versus just passing the comment ID when possible. 
See #33710.

Built from https://develop.svn.wordpress.org/trunk@34038


git-svn-id: http://core.svn.wordpress.org/trunk@34006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 05:56:24 +00:00
Scott Taylor
b9bbdabfe7 Create a new file, wp-admin/includes/noop.php, which loads all of the noop functions for load-script|styles.php and is only loaded by those files. DRYs in the process. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34037


git-svn-id: http://core.svn.wordpress.org/trunk@34005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 05:04:23 +00:00
Scott Taylor
db9c5c81f5 Move ad hoc functions from wp-admin/credits.php to wp-admin/includes/credits.php, which is only included by the former. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34036


git-svn-id: http://core.svn.wordpress.org/trunk@34004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 04:55:26 +00:00
Boone Gorges
cb462fa5ab Add unit tests for get_term(). 
These tests will be useful as we begin to refactor in favor of `WP_Term`.

See #14162.
Built from https://develop.svn.wordpress.org/trunk@34035


git-svn-id: http://core.svn.wordpress.org/trunk@34003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 03:11:24 +00:00
Boone Gorges
39fb7992a9 Require numeric IDs in user deletion functions. 
`wp_delete_user()` and `wpmu_delete_user()` both require an `$id` parameter.
Previously, the functions did not verify that the value passed was, in fact,
a number. As such, passing an object or any other entity that would be cast
to int `1` would result in user 1 being deleted. We fix this by enforcing
the requirement that `$id` be numeric.

Props dipesh.kakadiya, utkarshpatel, juliobox.
Fixes #33800.
Built from https://develop.svn.wordpress.org/trunk@34034


git-svn-id: http://core.svn.wordpress.org/trunk@34002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 02:25:23 +00:00
Boone Gorges
9a8a28998d Move wp_delete_user() tests to their own file. 
See #33800.

Built from https://develop.svn.wordpress.org/trunk@34033


git-svn-id: http://core.svn.wordpress.org/trunk@34001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 01:51:25 +00:00
Gary Pendergast
0d85038ce6 Schema: Increase the length of wp_options.option_name. 
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.

Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.


Built from https://develop.svn.wordpress.org/trunk@34030


git-svn-id: http://core.svn.wordpress.org/trunk@33999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 01:26:24 +00:00
Aaron Jorbin
c09b0477b2 Flush rewrite rules upon theme switch 
Themes can ( and do ) but shouldn't include custom rewrite rules.This can lead to hard to debug issues for theme authors. Theme changes are not a ultra common conclusion. Flushing the rewrite rules on theme switch will lead to a clean slate for each theme which helps make debugging easier.

And @nacin said we should do this 5 years ago at WordCamp Mid Atlantic.

Fixes #14849


Built from https://develop.svn.wordpress.org/trunk@34028


git-svn-id: http://core.svn.wordpress.org/trunk@33997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 23:50:24 +00:00
John Blackbourn
9bf86a74d0 Set the secure flag on the wp-saving-post cookie when using HTTPS. 
This cookie doesn't contain any sensitive information, but this change brings its behaviour in line with all other core cookies.

Fixes #31056

Built from https://develop.svn.wordpress.org/trunk@34027


git-svn-id: http://core.svn.wordpress.org/trunk@33996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 22:42:23 +00:00
Scott Taylor
5918b30cdd Move network_settings_add_js() from wp-admin/network/settings.php to wp-admin/includes/ms.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34026


git-svn-id: http://core.svn.wordpress.org/trunk@33995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 22:24:24 +00:00
Scott Taylor
2d2e3c911e Move confirm_delete_users() from wp-admin/network/users.php to wp-admin/includes/ms.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34025


git-svn-id: http://core.svn.wordpress.org/trunk@33994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 22:23:46 +00:00
Scott Taylor
bd0a6bbf8c Create wp-admin/includes/network.php via svn cp and only load it in wp-admin/network.php. Move the functions there. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34023


git-svn-id: http://core.svn.wordpress.org/trunk@33992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 22:01:24 +00:00
Scott Taylor
1d68ccec25 Move ad hoc Options functions to wp-admin/includes/options.php: 
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`

See #33813.

Built from https://develop.svn.wordpress.org/trunk@34022


git-svn-id: http://core.svn.wordpress.org/trunk@33991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:45:24 +00:00
Scott Taylor
a40e30e7f4 Move 2 ad hoc user admin functions: 
* Move `use_ssl_preference()` from `wp-admin/user-edit.php` to `wp-admin/includes/user.php`.
* Move `admin_created_user_email()` from `wp-admin/user-new.php` to `wp-admin/includes/user.php`.

See #33813.

Built from https://develop.svn.wordpress.org/trunk@34021


git-svn-id: http://core.svn.wordpress.org/trunk@33990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:33:33 +00:00
Scott Taylor
503aa8b76d Move redirect_post() from wp-admin/post.php to wp-admin/includes/post.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34020


git-svn-id: http://core.svn.wordpress.org/trunk@33989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:31:24 +00:00
Scott Taylor
f0b95b7bcc Move comment_footer_die() from wp-admin/comment.php to wp-admin/includes/comment.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34019


git-svn-id: http://core.svn.wordpress.org/trunk@33988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:29:24 +00:00
Scott Taylor
a1d949f361 Move plugin_sandbox_scrape() from wp-admin/plugins.php to wp-admin/includes/plugin.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34018


git-svn-id: http://core.svn.wordpress.org/trunk@33987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:24:24 +00:00
Scott Taylor
f8d7a43920 Move wp_widgets_access_body_class() (a hook callback) from wp-admin/widgets.php to wp-admin/includes/widgets.php. 
See #33813.

Built from https://develop.svn.wordpress.org/trunk@34017


git-svn-id: http://core.svn.wordpress.org/trunk@33986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:22:23 +00:00
Scott Taylor
21dd98695c After [34004], don't break apart the paragraph into multiple translatable strings. 
Fixes #18418.

Built from https://develop.svn.wordpress.org/trunk@34016


git-svn-id: http://core.svn.wordpress.org/trunk@33985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 21:00:24 +00:00
Scott Taylor
98acab10ea Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin. 
Props rachelbaker.
Fixes #33710.

Built from https://develop.svn.wordpress.org/trunk@34015


git-svn-id: http://core.svn.wordpress.org/trunk@33984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:51:23 +00:00
Scott Taylor
a5529285d1 _wpThemeSettings.l10n.searchPlaceholder is an input placeholder and doesn't handle UTF-8 or HTML entities properly. In lieu of using literal Unicode here, use .... 
See #32875.

Built from https://develop.svn.wordpress.org/trunk@34014


git-svn-id: http://core.svn.wordpress.org/trunk@33983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:36:24 +00:00
Scott Taylor
6ea147d51c After [33970], swap UTF-8 characters for their \u2026 escape sequence. 
See #32875.

Built from https://develop.svn.wordpress.org/trunk@34013


git-svn-id: http://core.svn.wordpress.org/trunk@33982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:30:24 +00:00
Jeremy Felt
cc1aade8f5 Multisite: Display content attribution drop down when deleting a user 
The previous move from `echo()` to `_e()` left some of the output hanging. Introduced in [32333].

Props figureone.
Fixes #33811 for trunk.

Built from https://develop.svn.wordpress.org/trunk@34012


git-svn-id: http://core.svn.wordpress.org/trunk@33981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:26:24 +00:00
Scott Taylor
d22fbc7545 Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values. 
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.

Built from https://develop.svn.wordpress.org/trunk@34011


git-svn-id: http://core.svn.wordpress.org/trunk@33980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:22:25 +00:00
Scott Taylor
641c07533d Clarify wp-includes/cache.php docs with some more precise language. 
Props danielbachhuber.
Fixes #33734.

Built from https://develop.svn.wordpress.org/trunk@34010


git-svn-id: http://core.svn.wordpress.org/trunk@33979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 18:24:24 +00:00
Scott Taylor
da6101d311 WP Plupload: on FileUploaded, allow success and error callbacks to receive server responses after a successful upload. 
Props ippetkov.
Fixes #24934.

Built from https://develop.svn.wordpress.org/trunk@34009


git-svn-id: http://core.svn.wordpress.org/trunk@33978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 18:19:24 +00:00
Scott Taylor
592f3d9c6c After [33961], ensure that comment filters that expect a comment ID are receiving one. 
Props dimadin.
Fixes #33809.

Built from https://develop.svn.wordpress.org/trunk@34008


git-svn-id: http://core.svn.wordpress.org/trunk@33977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 18:10:25 +00:00
Scott Taylor
8cd584e6ed In wp_generate_attachment_metadata(), also pass $metadata to the intermediate_image_sizes_advanced filter. 
Props amereservant, wonderboymusic.
Fixes #23401.

Built from https://develop.svn.wordpress.org/trunk@34007


git-svn-id: http://core.svn.wordpress.org/trunk@33976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 18:04:24 +00:00
Scott Taylor
6e22d94488 Add a "View" row action for approved comments on the Dashboard screen, remove the link labeled #. 
Props rachelbaker, zeo.
Fixes #18885. 

Built from https://develop.svn.wordpress.org/trunk@34006


git-svn-id: http://core.svn.wordpress.org/trunk@33975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 17:49:24 +00:00
Scott Taylor
527b5b1405 In WP_Posts_List_Table::column_date(), the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before. 
Props johnbillion, wonderboymusic.
Fixes #18641. 

Built from https://develop.svn.wordpress.org/trunk@34005


git-svn-id: http://core.svn.wordpress.org/trunk@33974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 17:43:24 +00:00
Scott Taylor
39411b8e61 Cleanup the text for Publish Settings > Publish in the edit-form-advanced help tab. Clarify that Private posts aren't hidden from editors and administrators. 
Props sillybean.
Fixes #18418. 

Built from https://develop.svn.wordpress.org/trunk@34004


git-svn-id: http://core.svn.wordpress.org/trunk@33973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 17:36:24 +00:00
Scott Taylor
52498a8546 In wp_media_upload_handler(), replace a lingering instance of media_upload_gallery() with wp_iframe(...) 
Props jeffstieler, antpb.
Fixes #17812. 

Built from https://develop.svn.wordpress.org/trunk@34003


git-svn-id: http://core.svn.wordpress.org/trunk@33972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 17:24:23 +00:00
Scott Taylor
811f76699b media-new.php, when using the browser uploader, if the result of uploading is a WP_Error - wp_die() with the error, instead of redirecting with a generic error. 
Props solarissmoke.
Fixes #16820. 

Built from https://develop.svn.wordpress.org/trunk@34002


git-svn-id: http://core.svn.wordpress.org/trunk@33971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 17:18:24 +00:00
Scott Taylor
47409875ab In get_page_uri(), do not add parent slugs to orphaned pages. 
Adds unit test.

Props filosofo, MikeHansenMe, MikeHansenMe, chriscct7.
Fixes #15963. 

Built from https://develop.svn.wordpress.org/trunk@34001


git-svn-id: http://core.svn.wordpress.org/trunk@33970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 16:54:24 +00:00
Scott Taylor
49b8ccec79 When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts. 
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405. 

Built from https://develop.svn.wordpress.org/trunk@34000


git-svn-id: http://core.svn.wordpress.org/trunk@33969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 16:47:24 +00:00
Jeremy Felt
2762f019f7 Multisite: Correct ms_not_installed() @since version for new parameters 
Props dimadin.
See 27264.

Built from https://develop.svn.wordpress.org/trunk@33999


git-svn-id: http://core.svn.wordpress.org/trunk@33968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 16:21:26 +00:00
Sergey Biryukov
f9e7fb306c Merge two similar strings. 
Props dipesh.kakadiya.
Fixes #33777.
Built from https://develop.svn.wordpress.org/trunk@33998


git-svn-id: http://core.svn.wordpress.org/trunk@33967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 10:59:27 +00:00
Jeremy Felt
52c3be1602 Multisite: Add action to handle network not found 
`ms_network_not_found` fires when the global `$current_site` has not been filled and `ms_not_installed()` is about to fire. It cannot be used to populate `$current_site`, but can be used to capture the request and redirect or present a custom error.

Props rmccue.
Fixes #31702.

Built from https://develop.svn.wordpress.org/trunk@33990


git-svn-id: http://core.svn.wordpress.org/trunk@33959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 05:06:24 +00:00
Jeremy Felt
7278744dd0 Multisite: Remove $domain and $path globals in ms_not_installed() 
Further reduces the reliance on these unnecessary globals.

Fixes #27264.

Built from https://develop.svn.wordpress.org/trunk@33989


git-svn-id: http://core.svn.wordpress.org/trunk@33958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 03:53:24 +00:00
Jeremy Felt
d1f818a61d Multisite: Allow users with manage_network_users to edit network users. 
Other users in a network can now be given capabilities to manage users without also having global super admin privileges.

* Users with `manage_network_users` can not edit super admins.
* Users with `manage_network_users` can not promote users to super admin.
* Uses of `is_super_admin()` in `user-new.php` are now updated to `manage_network_users`.

Props daniellandau, chriscct7.
Fixes #16860.

Built from https://develop.svn.wordpress.org/trunk@33988


git-svn-id: http://core.svn.wordpress.org/trunk@33957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 03:34:23 +00:00
Jeremy Felt
cb22d36f61 Multisite: Test edit_user capabilities for multisite administrators 
An administrator in multisite can not edit users other than itself.

Props daniellandau for the initial patch.
See #16860.

Built from https://develop.svn.wordpress.org/trunk@33987


git-svn-id: http://core.svn.wordpress.org/trunk@33956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 03:21:24 +00:00
Scott Taylor
52516a68ab After the global churn in [33964], also set $post to null at the end of WP_Comments_List_Table::single_row() to ensure that an orphaned comment doesn't inherit the previous row's $post context. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33986


git-svn-id: http://core.svn.wordpress.org/trunk@33955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 03:12:23 +00:00
Scott Taylor
2c21d12232 Implement a priority system for Help Tabs to add them at specific positions. 
Adds unit tests.

Props swissspidy.
Fixes #19828.

Built from https://develop.svn.wordpress.org/trunk@33985


git-svn-id: http://core.svn.wordpress.org/trunk@33954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 01:27:23 +00:00
Scott Taylor
b8c37073d8 Add @access docs to class-wp-filesystem-* files. 
Props wenthemes.
Fixes #33725.

Built from https://develop.svn.wordpress.org/trunk@33984


git-svn-id: http://core.svn.wordpress.org/trunk@33953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 01:21:24 +00:00
Scott Taylor
2736486f5a Plugins page: re-word "No out of date plugins were selected." to "All selected plugins are up to date." since it's not really an error condition. 
Props swissspidy.
Fixes #26494.

Built from https://develop.svn.wordpress.org/trunk@33983


git-svn-id: http://core.svn.wordpress.org/trunk@33952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 01:11:24 +00:00
Scott Taylor
bbbbf11961 After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc). 
See #33414.

Built from https://develop.svn.wordpress.org/trunk@33982


git-svn-id: http://core.svn.wordpress.org/trunk@33951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 01:03:25 +00:00
Andrew Ozz
0f3f7160e4 TinyMCE: update to 4.2.5, changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=index&pr_id=1. 
Fixes #33782 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33981


git-svn-id: http://core.svn.wordpress.org/trunk@33950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 19:45:26 +00:00
Drew Jaynes
55f3b892fb Docs: Add a changelog entry to the DocBlock for touch_time() to mention the shift from accessing the global $comment to using get_comment(). 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33979


git-svn-id: http://core.svn.wordpress.org/trunk@33948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 15:48:25 +00:00
Drew Jaynes
f5c8f20a69 Docs: Use the $widget_links_args parameter in the hook doc for the widget_links_args filter, introduced when the args array was split out to a variable in [33971]. 
See #20788.

Built from https://develop.svn.wordpress.org/trunk@33978


git-svn-id: http://core.svn.wordpress.org/trunk@33947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 15:45:27 +00:00
Scott Taylor
4bdda75696 WP_Widget_Links: pass widget instance to widget_links_args filter 
Props SergeyBiryukov, MikeHansenMe, DrewAPicture.
Fixes #20788.

Built from https://develop.svn.wordpress.org/trunk@33971


git-svn-id: http://core.svn.wordpress.org/trunk@33940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 04:42:24 +00:00
Scott Taylor
02ae926dfd Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading... 
Props yoavf.
Fixes #32875.

Built from https://develop.svn.wordpress.org/trunk@33970


git-svn-id: http://core.svn.wordpress.org/trunk@33939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 04:39:25 +00:00
Scott Taylor
62ec4a3bfd Deprecate wp_get_http() - function isn't used anywhere (apart from itself). 
Props swissspidy.
Fixes #33709.

Built from https://develop.svn.wordpress.org/trunk@33969


git-svn-id: http://core.svn.wordpress.org/trunk@33938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 04:26:25 +00:00
Scott Taylor
b05593c0b9 Add a parameter, $post, to get_{$adjacent}_post_join, get_{$adjacent}_post_where, and get_{$adjacent}_post_sort 
Props JustinSainton.
Fixes #24597.

Built from https://develop.svn.wordpress.org/trunk@33968


git-svn-id: http://core.svn.wordpress.org/trunk@33937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 03:49:24 +00:00
Scott Taylor
7ef604c052 Ensure that role is not empty before adding it in add_role() function and methods. 
Props MikeHansenMe, dannydehaan, michielhab.
Fixes #23746.

Built from https://develop.svn.wordpress.org/trunk@33967


git-svn-id: http://core.svn.wordpress.org/trunk@33936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 03:42:25 +00:00
Scott Taylor
6d4442ba12 Revisions screen: change language from "Return to post editor" to "Return to editor" - more generic for usage by custom post types. 
Props lancewillett, adamsilverstein.
Fixes #31910.

Built from https://develop.svn.wordpress.org/trunk@33966


git-svn-id: http://core.svn.wordpress.org/trunk@33935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 03:23:23 +00:00
Scott Taylor
246f2a6bd9 Use get_comment() instead of a global in touch_time(). 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33965


git-svn-id: http://core.svn.wordpress.org/trunk@33934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 03:05:24 +00:00
Scott Taylor
71f955dc84 In WP_Comments_List_Table, favor passing WP_Comment instances instead of $comment_ID to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33964


git-svn-id: http://core.svn.wordpress.org/trunk@33933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 03:00:24 +00:00
Scott Taylor
d973339738 After [33891], get_comment() returns global $comment if no args are passed and the global is set (after setting the default to null here). This allows us to ditch global comment imports. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33963


git-svn-id: http://core.svn.wordpress.org/trunk@33932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:51:24 +00:00
Scott Taylor
67f90df6a4 Walker_Comment should be in its own file. Loaded now via wp-includes/comment.php, which makes it 100% BC. 
See #33413.

Built from https://develop.svn.wordpress.org/trunk@33962


git-svn-id: http://core.svn.wordpress.org/trunk@33931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:41:24 +00:00
Scott Taylor
433c786bde After [33891], a lot of comment functions can take WP_Comment instead of only accepting comment_ID. Update the @param docs to reflect this. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33961


git-svn-id: http://core.svn.wordpress.org/trunk@33930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:34:24 +00:00
Scott Taylor
627396ac0c Speed up browserify builds, don't uglify the media builds on watch. 
Props iseulde.
Fixes #31911.

Built from https://develop.svn.wordpress.org/trunk@33960


git-svn-id: http://core.svn.wordpress.org/trunk@33929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:12:24 +00:00
Scott Taylor
5c9e3b00ce Pre-req for Media builds: make sure the watcher actually works for browserify. 
See #31911.

Built from https://develop.svn.wordpress.org/trunk@33959


git-svn-id: http://core.svn.wordpress.org/trunk@33928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:03:24 +00:00
Scott Taylor
8879565c0a In WP_User, add @property docs for description, first_name, and last_name. user_firstname and user_lastname only exist for back-compat. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33958


git-svn-id: http://core.svn.wordpress.org/trunk@33927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 01:13:24 +00:00
Scott Taylor
5e9e1d14bd WP_Theme has an ad hoc property in WP_MS_Themes_List_Table, $update. This can be set to a default value on the class, as it's not obtained via __get(). 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33957


git-svn-id: http://core.svn.wordpress.org/trunk@33926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 01:02:24 +00:00
Scott Taylor
128cc02f39 In wpdb::get_col_length(), the final return false is unreachable since the default switch case returns. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33956


git-svn-id: http://core.svn.wordpress.org/trunk@33925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 00:48:26 +00:00
Andrew Ozz
4e7dd2c4b1 Formatting: maintain the content of HTML comments when they contain <object> tags. Add more tests for wpaitop(). 
Props miqrogroove.
Fixes #33645 for trunk.
Built from https://develop.svn.wordpress.org/trunk@33955


git-svn-id: http://core.svn.wordpress.org/trunk@33924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-08 22:55:24 +00:00
Scott Taylor
c1bb5b5ce3 After [33843], update the location of some files in This filter is documented in docs 
Props dimadin.
See #33413.

Built from https://develop.svn.wordpress.org/trunk@33954


git-svn-id: http://core.svn.wordpress.org/trunk@33923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-08 22:17:26 +00:00
Scott Taylor
3d8199c4eb Multisite: Don't allow sites to be created with the following reserved slugs: wp-admin, wp-content, wp-includes 
Props austinginder.
Fixes #33615.

Built from https://develop.svn.wordpress.org/trunk@33952


git-svn-id: http://core.svn.wordpress.org/trunk@33921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-08 19:32:24 +00:00
Scott Taylor
0c97b3625e After [33814], checked() outputs a leading space, so some extra spaces can be removed in the HTML for default widget forms. 
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33951


git-svn-id: http://core.svn.wordpress.org/trunk@33920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-08 19:23:24 +00:00
Scott Taylor
00c8fe6b38 Bump the timeout in trackback() to 10 seconds (from 4) to match wp_xmlrpc_server::pingback_ping() and prevent trackback timeouts. 
Props gnaka08 for the initial patch.
Fixes #10414.

Built from https://develop.svn.wordpress.org/trunk@33948


git-svn-id: http://core.svn.wordpress.org/trunk@33917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-08 18:56:25 +00:00
Scott Taylor
1cd398db0e After [33840], JS regex needs the g modifier. 
Add another unit test case.

Props kitchin.
Fixes #22781.

Built from https://develop.svn.wordpress.org/trunk@33947


git-svn-id: http://core.svn.wordpress.org/trunk@33916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-08 16:44:26 +00:00
Gary Pendergast
40f45a0b89 Tests: Check that readme.html is recommending an actively supported version of MySQL. 
Per the MySQL support guidelines (https://www.mysql.com/support/), Oracle provides active support for MySQL releases for 5 years from the General Availality release.

See #33758.


Built from https://develop.svn.wordpress.org/trunk@33946


git-svn-id: http://core.svn.wordpress.org/trunk@33915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-08 03:24:26 +00:00
Andrea Fercia
a49f9ef68f Bump H3 headings to H2 on the Network Add New User screen for better accessibility. 
Props Cheffheid.
Fixes #33605.
Built from https://develop.svn.wordpress.org/trunk@33945


git-svn-id: http://core.svn.wordpress.org/trunk@33914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 16:03:25 +00:00
Gary Pendergast
c44c7338c0 Tests: Add an extra warning message when checking the recommended PHP version. 
See #33758.


Built from https://develop.svn.wordpress.org/trunk@33944


git-svn-id: http://core.svn.wordpress.org/trunk@33913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 07:28:24 +00:00
Weston Ruter
7c6534fd4c Customize: Fix logic for determining the container element when focusing on a panel, section, or control. 
Fixes #33695 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33939


git-svn-id: http://core.svn.wordpress.org/trunk@33908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 05:59:24 +00:00
Weston Ruter
274373afc6 Customize: Fix clearing of a color control's setting by using proper empty value. 
Props stevehenty.
Fixes #30280.


Built from https://develop.svn.wordpress.org/trunk@33938


git-svn-id: http://core.svn.wordpress.org/trunk@33907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 05:48:23 +00:00
Gary Pendergast
066c30b41e Readme: Update the recommended PHP version to 5.6. 
This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.

Fixes #33758.


Built from https://develop.svn.wordpress.org/trunk@33937


git-svn-id: http://core.svn.wordpress.org/trunk@33906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 05:23:24 +00:00
Dion Hulse
580ca68e26 Cron: Reject events when the provided $timestamp is not a valid timestamp. 
Invalid timestamps were previously accepted by the scheduling functions but would never be run due to our implementation which caused the cron option to forever contain the events.
This rejects such events which most likely only occur due to developer error.

Props utkarshpatel, wonderboymusic, SergeyBiryukov.
See #33423, Fixes #33475

Built from https://develop.svn.wordpress.org/trunk@33936


git-svn-id: http://core.svn.wordpress.org/trunk@33905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 02:39:23 +00:00
Dion Hulse
36bda54e88 Favicon: Do not specify a Content-Length: 0 header for our "empty" response to fail more gracefully on environments with extra whitespace on output. 
This allows for the web server to generate the appropriate `Content-Length` header for the request, allowing for strict clients/proxies/servers to process the response.

Props swissspidy.
Fixes #33626

Built from https://develop.svn.wordpress.org/trunk@33935


git-svn-id: http://core.svn.wordpress.org/trunk@33904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-07 02:18:26 +00:00
Sergey Biryukov
a3f82f92f1 Widgets: Don't display sidebar description container if it's empty. 
Props paulwilde.
Fixes #32448.
Built from https://develop.svn.wordpress.org/trunk@33934


git-svn-id: http://core.svn.wordpress.org/trunk@33903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 07:59:24 +00:00
Sergey Biryukov
c177344508 Merge two permission error strings. 
Props pavelevap.
Fixes #33745.
Built from https://develop.svn.wordpress.org/trunk@33933


git-svn-id: http://core.svn.wordpress.org/trunk@33902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 06:42:26 +00:00
Sergey Biryukov
c65f37f892 Correct description for version and current_version parameters in wp_check_browser_version() response. 
Props extendwings.
Fixes #33753.
Built from https://develop.svn.wordpress.org/trunk@33932


git-svn-id: http://core.svn.wordpress.org/trunk@33901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 00:17:24 +00:00
Sergey Biryukov
0424d962e1 Update the parameter docs for wp_add_post_tags(), wp_set_post_tags(), and wp_set_post_terms(). 
Props johnbillion.
Fixes #33749.
Built from https://develop.svn.wordpress.org/trunk@33931


git-svn-id: http://core.svn.wordpress.org/trunk@33900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-06 00:12:26 +00:00
Sergey Biryukov
4b5ef333a0 Correct the docblock for wp_list_widget_controls(). 
Props swissspidy.
Fixes #33751.
Built from https://develop.svn.wordpress.org/trunk@33930


git-svn-id: http://core.svn.wordpress.org/trunk@33899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 23:38:25 +00:00
John Blackbourn
504cd3bf15 Remove the 'Site Admin' link from the Meta widget if the user doesn't have access to the admin area. 
See #25162

Built from https://develop.svn.wordpress.org/trunk@33929


git-svn-id: http://core.svn.wordpress.org/trunk@33898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 23:25:24 +00:00
Sergey Biryukov
48a41a6663 List tables: Adjust the styles for checkbox column to align better with longer column names. 
Props swissspidy.
Fixes #32825.
Built from https://develop.svn.wordpress.org/trunk@33928


git-svn-id: http://core.svn.wordpress.org/trunk@33897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 23:16:23 +00:00
John Blackbourn
f482b909e6 Introduce a new $is_edge global for the Microsoft Edge browser. 
The `$is_IE` and `$is_chrome` globals no longer return `true` for Edge, which is expected as Edge is its own browser and should not be treated like IE. While it might be beneficial for Edge to be treated like Chrome on the client side, it benefits nobody for the `$is_chrome` global to return true.

See #33193
Props gregrickaby, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33927


git-svn-id: http://core.svn.wordpress.org/trunk@33896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 22:33:23 +00:00
Scott Taylor
15b487b097 After [33925], rename the unit test class to Tests_Comment_Meta_Cache to avoid collisions on the PHP 5.2 superhighway. 
See #16894.

Built from https://develop.svn.wordpress.org/trunk@33926


git-svn-id: http://core.svn.wordpress.org/trunk@33895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 22:30:24 +00:00
Scott Taylor
c231add9fe In wp_list_comments(), update the comment meta cache when the comments derive from WP_Query and the new ->comment_meta_cached prop is false. 
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.

Adds unit tests.

Props wonderboymusic, bradt.
Fixes #16894.

Built from https://develop.svn.wordpress.org/trunk@33925


git-svn-id: http://core.svn.wordpress.org/trunk@33894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 22:25:24 +00:00
John Blackbourn
3361f90a1c When a user with no role logs in, redirect them to the home page rather than their profile screen which they do not have access to. 
See #25162

Built from https://develop.svn.wordpress.org/trunk@33924


git-svn-id: http://core.svn.wordpress.org/trunk@33893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 21:34:24 +00:00
John Blackbourn
bdde0261bc Bail out early from esc_url() if the URL becomes empty after stripping out disallowed characters. 
Fixes #28015
Props jesin for the unit test

Built from https://develop.svn.wordpress.org/trunk@33923


git-svn-id: http://core.svn.wordpress.org/trunk@33892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 21:29:25 +00:00
John Blackbourn
9e6f9a5d93 Function docs for the tax_input and meta_input parameters available for wp_insert_post(). 
See #20451

Built from https://develop.svn.wordpress.org/trunk@33922


git-svn-id: http://core.svn.wordpress.org/trunk@33891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 21:02:24 +00:00
Jeremy Felt
af557379da Multisite: Update help tab text for site-info.php to reference "site URL". 
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.

Fixes #33748. See #22383.

Built from https://develop.svn.wordpress.org/trunk@33921


git-svn-id: http://core.svn.wordpress.org/trunk@33890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:53:24 +00:00
John Blackbourn
4d76ce2521 Implement a language chooser on the Network Admin -> Sites -> Add New screen. 
Props DrewAPicture
Fixes #33528

Built from https://develop.svn.wordpress.org/trunk@33920


git-svn-id: http://core.svn.wordpress.org/trunk@33889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:47:24 +00:00
Sergey Biryukov
695d3ee98b Merge two strings in Walker_Comment::comment() and Walker_Comment::html5_comment(). 
Props pavelevap.
Fixes #33744.
Built from https://develop.svn.wordpress.org/trunk@33919


git-svn-id: http://core.svn.wordpress.org/trunk@33888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:46:24 +00:00
Jeremy Felt
122862b570 Multisite: Pass the ID of the site being updated to wpmu_update_blog_options action. 
Props @swissspidy, @MikeHansenMe.
Fixes #32907.

Built from https://develop.svn.wordpress.org/trunk@33918


git-svn-id: http://core.svn.wordpress.org/trunk@33887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:39:24 +00:00
Scott Taylor
9957d43e13 Bump H3 headings to H2 on the {Term} screens for better accessibility. 
Props mrahmadawais.
Fixes #33658.

Built from https://develop.svn.wordpress.org/trunk@33917


git-svn-id: http://core.svn.wordpress.org/trunk@33886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:17:25 +00:00
Scott Taylor
acc7f66cf9 Bump H3 headings to H2 on the Discussion Settings screen for better accessibility. 
Props mrahmadawais.
Fixes #33609.

Built from https://develop.svn.wordpress.org/trunk@33916


git-svn-id: http://core.svn.wordpress.org/trunk@33885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:14:24 +00:00
Scott Taylor
941d65c462 Bump H3 headings to H2 on the Media Settings screen for better accessibility. 
Props metodiew.
Fixes #33610.

Built from https://develop.svn.wordpress.org/trunk@33915


git-svn-id: http://core.svn.wordpress.org/trunk@33884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:12:25 +00:00
Scott Taylor
2a3be365e3 Bump H3 headings to H2 on Export screen for better accessibility. 
Props metodiew.
Fixes #33608.

Built from https://develop.svn.wordpress.org/trunk@33914


git-svn-id: http://core.svn.wordpress.org/trunk@33883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:09:24 +00:00
Scott Taylor
fd21c92b22 Correct the param docs for comment_guid() and get_comment_guid(). 
Props dimadin.
Fixes #32619.

Built from https://develop.svn.wordpress.org/trunk@33913


git-svn-id: http://core.svn.wordpress.org/trunk@33882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:00:25 +00:00
Scott Taylor
f5c754bfed Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here). 
Props afercia.
Fixes #32866.

Built from https://develop.svn.wordpress.org/trunk@33912


git-svn-id: http://core.svn.wordpress.org/trunk@33881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 19:57:25 +00:00
Scott Taylor
44dace3487 Add Customizer docs. 
Props ericlewis.
See #33503.

Built from https://develop.svn.wordpress.org/trunk@33911


git-svn-id: http://core.svn.wordpress.org/trunk@33880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 19:53:24 +00:00
Scott Taylor
102a8aecf8 Allow wp_insert_post() to accept a meta_input argument. Devs should use register_meta() to ensure that specific values specified by key are sanitized properly. 
Adds unit test.

Props CoenJacobs, swissspidy.
Fixes #20451.

Built from https://develop.svn.wordpress.org/trunk@33910


git-svn-id: http://core.svn.wordpress.org/trunk@33879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 19:50:24 +00:00
Andrea Fercia
47ceb6bb5c Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens. 
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].

Fix a typo in the DocBlock for the `additional_capabilities_display` filter.

Props metodiew.
Fixes #33606. See #31650.
Built from https://develop.svn.wordpress.org/trunk@33909


git-svn-id: http://core.svn.wordpress.org/trunk@33878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 18:30:24 +00:00
Sergey Biryukov
465e348c12 Fix closing div in wp_print_request_filesystem_credentials_modal(). 
Props trepmal.
Fixes #33737.
Built from https://develop.svn.wordpress.org/trunk@33908


git-svn-id: http://core.svn.wordpress.org/trunk@33877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 15:17:24 +00:00
Sergey Biryukov
1e90498102 Update Tests_Sanitize_Option::test_sanitize_option() after [33858]. 
See #23605.
Built from https://develop.svn.wordpress.org/trunk@33907


git-svn-id: http://core.svn.wordpress.org/trunk@33876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 14:18:24 +00:00
Sergey Biryukov
3b2cf952e9 Update Tests_Admin_includesPlugin::test_menu_page_url() after [33858]. 
See #23605.
Built from https://develop.svn.wordpress.org/trunk@33906


git-svn-id: http://core.svn.wordpress.org/trunk@33875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 14:16:24 +00:00
Sergey Biryukov
faaa9b9e98 Update Tests_Formatting_GetUrlInContent::get_input_output() after [33858]. 
Props gitlost.
Fixes #23605.
Built from https://develop.svn.wordpress.org/trunk@33905


git-svn-id: http://core.svn.wordpress.org/trunk@33874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 14:06:26 +00:00
Boone Gorges
cc5eddda74 Allow wp_terms_checklist() to return markup rather than echoing it. 
Props kevinlangleyjr.
Fixes #33720.
Built from https://develop.svn.wordpress.org/trunk@33904


git-svn-id: http://core.svn.wordpress.org/trunk@33873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 21:25:25 +00:00
Boone Gorges
45e8bef3cd In get_terms(), allow terms to be ordered by 'term_id'. 
[29128] introduced updated documentation for the `'orderby'` parameter of
`get_terms()`. The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.

Props ixkaito.
Fixes #33726.
Built from https://develop.svn.wordpress.org/trunk@33903


git-svn-id: http://core.svn.wordpress.org/trunk@33872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 21:17:26 +00:00
Sergey Biryukov
f0ce1f06ea Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/js/customize-controls.js. 
fixes #33685. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33902


git-svn-id: http://core.svn.wordpress.org/trunk@33871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 03:40:25 +00:00
Drew Jaynes
d612c11ab0 Docs: Clarify the file header summary for wp-includes/rewrite-constants.php, introduced in [33751]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33901


git-svn-id: http://core.svn.wordpress.org/trunk@33870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:52:24 +00:00
Drew Jaynes
bfe8b01ef2 Docs: Clarify the file header summary for wp-includes/comment.php, the top-level file for the core Comments API. 
Also adds inline DocBlock for the `require_once()` calls that now bring in the `WP_Comment` and `WP_Comment_Query` classes, as well as core comments functionality.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33900


git-svn-id: http://core.svn.wordpress.org/trunk@33869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:47:25 +00:00
Drew Jaynes
f57d7527e6 Docs: Clarify the file header summary for wp-includes/comment-functions.php, introduced in [33750]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33899


git-svn-id: http://core.svn.wordpress.org/trunk@33868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:42:24 +00:00
Drew Jaynes
a71ee9a0ea Docs: Add a missing file header for wp-includes/class-wp-comment-query.php, introduced in [33750]. 
Also clarifies the class DocBlock summary and tags for `WP_Comment_Query`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33898


git-svn-id: http://core.svn.wordpress.org/trunk@33867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:38:24 +00:00
Drew Jaynes
5cf6c74499 Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API. 
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33897


git-svn-id: http://core.svn.wordpress.org/trunk@33866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:33:24 +00:00
Drew Jaynes
3be117216e Docs: Clarify the file header summary for wp-includes/user-functions.php, introduced in [33749]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33896


git-svn-id: http://core.svn.wordpress.org/trunk@33865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:29:24 +00:00
Drew Jaynes
e1e98b04b9 Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749]. 
Also clarifies the class DocBlock summary for `WP_User_Query` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33895


git-svn-id: http://core.svn.wordpress.org/trunk@33864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-04 01:26:25 +00:00
Scott Taylor
80a20e5c3d Handle more cases (untrailingslashit, HTTPS urls) for sanitizing an author URL for display in the comments list table. 
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.

Built from https://develop.svn.wordpress.org/trunk@33894


git-svn-id: http://core.svn.wordpress.org/trunk@33863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 23:23:24 +00:00
Drew Jaynes
54c2cabf66 Docs: Add complete file, class, property, and method documentation for the new WP_Comment class, introduced in [33891]. 
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33893


git-svn-id: http://core.svn.wordpress.org/trunk@33862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 19:58:24 +00:00
Sergey Biryukov
9ffab31d8f Add missing translation functions to the error messages added in [33889]. 
props kraftbj, GaryJ.
fixes #33684.
Built from https://develop.svn.wordpress.org/trunk@33892


git-svn-id: http://core.svn.wordpress.org/trunk@33861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:37:23 +00:00
Scott Taylor
e73ee5ac98 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33891


git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:17:24 +00:00
Helen Hou-Sandí
89de754f0e UI: Restrict textarea resizing to vertical to prevent ugliness. 
props tyxla, MatheusFD.
fixes #33400.

Built from https://develop.svn.wordpress.org/trunk@33890


git-svn-id: http://core.svn.wordpress.org/trunk@33859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:05:25 +00:00
Sergey Biryukov
ba056692a6 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-includes/class-wp-customize-manager.php. 
props kraftbj.
fixes #33684. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33889


git-svn-id: http://core.svn.wordpress.org/trunk@33858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 09:21:23 +00:00
Sergey Biryukov
bc8af88903 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/network/site-users.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33888


git-svn-id: http://core.svn.wordpress.org/trunk@33857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 09:03:24 +00:00
Sergey Biryukov
771b29455b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/includes/bookmark.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33887


git-svn-id: http://core.svn.wordpress.org/trunk@33856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:59:24 +00:00
Sergey Biryukov
c4ce11422c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/widgets.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33886


git-svn-id: http://core.svn.wordpress.org/trunk@33855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:56:24 +00:00
Sergey Biryukov
ce05b02a59 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/users.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33885


git-svn-id: http://core.svn.wordpress.org/trunk@33854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:54:24 +00:00
Sergey Biryukov
b4fbbf53cf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/user-new.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33884


git-svn-id: http://core.svn.wordpress.org/trunk@33853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 08:46:52 +00:00
Drew Jaynes
e2038f9150 Docs: Add inline DocBlocks for the require_once() calls that now bring in top-level HTTP API functionality and HTTP API classes. 
Classes brought in from separate files now include:
* `WP_Http`
* `WP_Http_Streams`
* `WP_Http_Curl`
* `WP_HTTP_Proxy`
* `WP_Http_Cookie`
* `WP_Http_Encoding`

See #33413. See #32246.

Built from https://develop.svn.wordpress.org/trunk@33882


git-svn-id: http://core.svn.wordpress.org/trunk@33851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 04:36:30 +00:00
Drew Jaynes
69375b243a Docs: Clarify the file header summary for wp-includes/http.php, the top-level file for the HTTP Request API. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33881


git-svn-id: http://core.svn.wordpress.org/trunk@33850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 04:36:08 +00:00
Drew Jaynes
853fd32e88 Docs: Add a missing file header for wp-includes/class-http.php. 
Also clarifies the class DocBlock summary for `WP_Http` to more clearly describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33880


git-svn-id: http://core.svn.wordpress.org/trunk@33849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:39:21 +00:00
Drew Jaynes
05ec4d2029 Docs: Clarify the file header summary for wp-includes/http-functions.php, introduced in [33748]. 
Also removes now-moot extra information from the file header description.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33879


git-svn-id: http://core.svn.wordpress.org/trunk@33848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:37:20 +00:00
Drew Jaynes
d948d8e104 Docs: Add a missing file header to wp-includes/class-wp-http-streams.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Streams` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33878


git-svn-id: http://core.svn.wordpress.org/trunk@33846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:33:21 +00:00
Drew Jaynes
b9ef409823 Docs: Add a missing file header to wp-includes/class-wp-http-proxy.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_HTTP_Proxy` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33876


git-svn-id: http://core.svn.wordpress.org/trunk@33844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:30:21 +00:00
Drew Jaynes
f7ba27390c Docs: Add a missing file header for wp-includes/class-wp-http-encoding.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Encoding`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33875


git-svn-id: http://core.svn.wordpress.org/trunk@33843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:28:21 +00:00
Drew Jaynes
378d3e0f8d Docs: Add a missing file header for wp-includes/class-wp-http-curl.php, introduced in [33748]. 
Also clarifies the class DocBlock summary for `WP_Http_Curl` to better describe its purpose.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33874


git-svn-id: http://core.svn.wordpress.org/trunk@33842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:23:21 +00:00
Drew Jaynes
c42da1df59 Docs: Add a missing file header to wp-includes/class-wp-http-cookie.php, introduced in [33748]. 
Also clarifies the summary in the class DocBlock for `WP_Http_Cookie`.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33873


git-svn-id: http://core.svn.wordpress.org/trunk@33841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:19:21 +00:00
Drew Jaynes
31f52091ec Docs: Clarify the file header summary for wp-includes/widgets.php, the top-level file for the core Widgets API. 
Also fixes some minor grammar issues in the file description.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33872


git-svn-id: http://core.svn.wordpress.org/trunk@33840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 03:14:20 +00:00
Drew Jaynes
0ce0241740 Docs: Clarify the file header summary for widget-functions.php, introduced in [33746]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33871


git-svn-id: http://core.svn.wordpress.org/trunk@33839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:58:20 +00:00
Drew Jaynes
95dc9825a7 Docs: Clarify the file header summary for class-wp-widget-factory.php, introduced in [33746]. 
See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33870


git-svn-id: http://core.svn.wordpress.org/trunk@33838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:54:22 +00:00
Drew Jaynes
a92dc6aeed Docs: Improve the file header for class-wp-widget.php to describe what the file contains. 
Also rewrites the class DocBlock summary for `WP_Widget` to better describe the '''purpose''' of the class.

See #33413. See #33701.

Built from https://develop.svn.wordpress.org/trunk@33869


git-svn-id: http://core.svn.wordpress.org/trunk@33837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 02:50:21 +00:00
Drew Jaynes
ab990ac594 Docs: Add a missing summary to the DocBlock for Walker::get_number_of_root_elements(). 
Props wen-solutions
See #33662.

Built from https://develop.svn.wordpress.org/trunk@33868


git-svn-id: http://core.svn.wordpress.org/trunk@33836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 19:51:21 +00:00
Scott Taylor
3cad9d8385 After [33723], ensure that $i is properly set before looping. 
See #16865.

Built from https://develop.svn.wordpress.org/trunk@33867


git-svn-id: http://core.svn.wordpress.org/trunk@33835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:48:22 +00:00
Sergey Biryukov
bc0a1e1c4b Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/themes.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33866


git-svn-id: http://core.svn.wordpress.org/trunk@33834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:45:21 +00:00
Sergey Biryukov
3e0929740e Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/press-this.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33865


git-svn-id: http://core.svn.wordpress.org/trunk@33833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:38:21 +00:00
Sergey Biryukov
d5ac2bc41e Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/post-new.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33864


git-svn-id: http://core.svn.wordpress.org/trunk@33832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:36:22 +00:00
Sergey Biryukov
a880c5c576 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/options.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33863


git-svn-id: http://core.svn.wordpress.org/trunk@33831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:31:21 +00:00
Sergey Biryukov
5ceecc4eaf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/nav-menus.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33862


git-svn-id: http://core.svn.wordpress.org/trunk@33830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:21:21 +00:00
Sergey Biryukov
b136b074bf Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33861


git-svn-id: http://core.svn.wordpress.org/trunk@33829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:15:20 +00:00
Sergey Biryukov
d2919e2d71 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit-comments.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33860


git-svn-id: http://core.svn.wordpress.org/trunk@33828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 18:04:21 +00:00
Sergey Biryukov
31b0fe4b6f Set svn:eol-style for the files added in [32806]. 
see #32576.
Built from https://develop.svn.wordpress.org/trunk@33859


git-svn-id: http://core.svn.wordpress.org/trunk@33827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:55:21 +00:00
John Blackbourn
6aad2eb98c Correctly encode spaces in URLs passed to esc_url() instead of removing them. 
Fixes #23605
Props enshrined, johnbillion

Built from https://develop.svn.wordpress.org/trunk@33858


git-svn-id: http://core.svn.wordpress.org/trunk@33826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:20:21 +00:00
Sergey Biryukov
3d1c08a1a5 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/customize.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33857


git-svn-id: http://core.svn.wordpress.org/trunk@33825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 17:05:22 +00:00
Andrea Fercia
f35c176426 Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604]. 
Fixes #33633.
Built from https://develop.svn.wordpress.org/trunk@33856


git-svn-id: http://core.svn.wordpress.org/trunk@33824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:56:20 +00:00
John Blackbourn
06c86124ad More unit tests for esc_url() and esc_url_raw(). 
See #23605, #20771, #16859

Built from https://develop.svn.wordpress.org/trunk@33855


git-svn-id: http://core.svn.wordpress.org/trunk@33823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:51:21 +00:00
Sergey Biryukov
cf69e6deb3 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/custom-header.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33854


git-svn-id: http://core.svn.wordpress.org/trunk@33822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:29:21 +00:00
Sergey Biryukov
d95417a5e7 Provide more helful feedback than just "Cheatin' uh?" for permission errors in wp-admin/media-upload.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33853


git-svn-id: http://core.svn.wordpress.org/trunk@33821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:21:21 +00:00
Sergey Biryukov
c3b663ad8d Provide more helful feedback than just “Cheatin’ uh?” for permission errors in wp-admin/edit-tags.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.
Built from https://develop.svn.wordpress.org/trunk@33852


git-svn-id: http://core.svn.wordpress.org/trunk@33820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 16:06:21 +00:00
John Blackbourn
867a449fee Add some more passing unit tests for esc_url() in preparation for upcoming changes. 
See #23605, #20771, #16859

Built from https://develop.svn.wordpress.org/trunk@33851


git-svn-id: http://core.svn.wordpress.org/trunk@33819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 14:20:21 +00:00
Boone Gorges
709fde7584 Remove # from @ticket annotation in a unit test. 
This improper character was erroneously introduced in [33724].

Props netweb.
Fixes #33532.
Built from https://develop.svn.wordpress.org/trunk@33850


git-svn-id: http://core.svn.wordpress.org/trunk@33818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 13:40:21 +00:00
John Blackbourn
606b6d15f1 Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL. 
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90

Built from https://develop.svn.wordpress.org/trunk@33849


git-svn-id: http://core.svn.wordpress.org/trunk@33817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-02 11:29:23 +00:00
Jeremy Felt
9666aec8d1 Multisite: Remove duplicate span element output from row actions 
Fixes #32961.

Built from https://develop.svn.wordpress.org/trunk@33848


git-svn-id: http://core.svn.wordpress.org/trunk@33816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 21:51:21 +00:00
Drew Jaynes
05c7abcf13 Docs: Add missing parameter documentation to the the DocBlock for WP_User::__set(). 
Props racase for the initial patch.
Fixes #33652.

Built from https://develop.svn.wordpress.org/trunk@33847


git-svn-id: http://core.svn.wordpress.org/trunk@33815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 21:47:21 +00:00
Scott Taylor
0415dd7c53 After [33807], fix unit tests for PHP 5.2 
Fixes #17626.

Built from https://develop.svn.wordpress.org/trunk@33846


git-svn-id: http://core.svn.wordpress.org/trunk@33814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 17:04:21 +00:00
Scott Taylor
9f8816c939 De-Jorbin [33814]. 
See #23012.

Built from https://develop.svn.wordpress.org/trunk@33845


git-svn-id: http://core.svn.wordpress.org/trunk@33813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 15:48:22 +00:00
Sergey Biryukov
bffe6a63ba Make curly quotes in playlist item title translatable. 
fixes #33391.
Built from https://develop.svn.wordpress.org/trunk@33844


git-svn-id: http://core.svn.wordpress.org/trunk@33812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:50:21 +00:00
Scott Taylor
9b8169bd30 Move widget classes to their own files in wp-includes/widgets: 
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded` 

See #33413, #23012.

Built from https://develop.svn.wordpress.org/trunk@33843


git-svn-id: http://core.svn.wordpress.org/trunk@33811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:49:21 +00:00
Sergey Biryukov
32b5726fd4 Merge two similar strings. 
props pavelevap.
fixes #33643.
Built from https://develop.svn.wordpress.org/trunk@33842


git-svn-id: http://core.svn.wordpress.org/trunk@33810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 13:46:24 +00:00
Scott Taylor
ecf0b82afb Add some JS docs to customize-base.js 
Props ericlewis.
Fixes #33639.

Built from https://develop.svn.wordpress.org/trunk@33841


git-svn-id: http://core.svn.wordpress.org/trunk@33809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 04:15:22 +00:00
Scott Taylor
a829ee32ce User Settings: allow dashes in get|set_user_setting() in PHP and get|setUserSetting() in JS. 
Add unit tests - there were none. Mock `set_user_setting()` since it won't run due to `headers_sent()` being `true`.

Fixes #22781.

Built from https://develop.svn.wordpress.org/trunk@33840


git-svn-id: http://core.svn.wordpress.org/trunk@33808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 03:57:21 +00:00
Sergey Biryukov
db71d238dd Correct @since version for [33838]. 
props JustinSainton.
see #23692.
Built from https://develop.svn.wordpress.org/trunk@33839


git-svn-id: http://core.svn.wordpress.org/trunk@33807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 03:14:21 +00:00
Sergey Biryukov
13540a6b30 Add filters to feed_links() to choose whether to display the links to posts feed and comments feed, separately. 
props joostdevalk, juliobox.
fixes #23692.
Built from https://develop.svn.wordpress.org/trunk@33838


git-svn-id: http://core.svn.wordpress.org/trunk@33806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-01 02:46:21 +00:00
Weston Ruter
1413f2edd5 Customizer: Collapse any expanded panel/sections before expanding other panel/sections 
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Props celloexpressions, westonruter.
Fixes #33396 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33837


git-svn-id: http://core.svn.wordpress.org/trunk@33805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 23:08:42 +00:00
Andrew Ozz
e3f3f470ea Editor, Press This: force a page reload when the user publishes a post and then clicks the back button. 
Fixes #23691.
Built from https://develop.svn.wordpress.org/trunk@33836


git-svn-id: http://core.svn.wordpress.org/trunk@33804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 23:08:22 +00:00
Andrew Ozz
db0ca19899 TinyMCE: disable the native fullscreen plugin on mobile devices by default. 
Props iseulde. Fixes #33137;
Built from https://develop.svn.wordpress.org/trunk@33835


git-svn-id: http://core.svn.wordpress.org/trunk@33803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 22:45:22 +00:00
Andrew Ozz
a231303341 TinyMCE: fix replacing the image caption HTML with the shortcode when saving the content. 
Fixes #33477.
Built from https://develop.svn.wordpress.org/trunk@33834


git-svn-id: http://core.svn.wordpress.org/trunk@33802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 22:07:21 +00:00
Sergey Biryukov
43194cea1c Add 'dashboard_secondary_items' filter for the number of secondary link items in the 'WordPress News' dashboard widget. 
props MikeHansenMe, DrewAPicture.
fixes #31434.
Built from https://develop.svn.wordpress.org/trunk@33833


git-svn-id: http://core.svn.wordpress.org/trunk@33801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:57:21 +00:00
Sergey Biryukov
a53d6b471f Add 'update_right_now_text' filter for the text displayed in the 'At a Glance' dashboard widget. 
props obenland.
fixes #33355.
Built from https://develop.svn.wordpress.org/trunk@33832


git-svn-id: http://core.svn.wordpress.org/trunk@33800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:45:21 +00:00
John Blackbourn
6a0818996d Space out. 
Built from https://develop.svn.wordpress.org/trunk@33831


git-svn-id: http://core.svn.wordpress.org/trunk@33799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:25:21 +00:00
Drew Jaynes
375d30f699 Docs: Add a duplicate filter comment to the comment_email filter call in WP_Comments_List_Table, introduced in [33829]. 
See #11566.

Built from https://develop.svn.wordpress.org/trunk@33830


git-svn-id: http://core.svn.wordpress.org/trunk@33798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:22:21 +00:00
Scott Taylor
a5b157ffde Remove the hamburger global'ing from [33828]: since no args are passed to comment_author_email_link(), the internals can be simplified and applied inline. 
See #11566. 

Built from https://develop.svn.wordpress.org/trunk@33829


git-svn-id: http://core.svn.wordpress.org/trunk@33797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-31 21:09:21 +00:00