Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-13 22:26:06 +01:00
Code Issues Projects Releases Wiki Activity
34,944 Commits 50 Branches 748 Tags 792 MiB
525bb21513
Commit Graph

34944 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Boone Gorges
70077ce076 Tests: Attachment create() method should match signature of other create() methods. 
Legacy argument format continues to be accepted.

Props bcole808.
See #37630.
Built from https://develop.svn.wordpress.org/trunk@38330


git-svn-id: http://core.svn.wordpress.org/trunk@38271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 13:43:41 +00:00
Sergey Biryukov
ec8f0281fa I18N: Remove unnecessary context for two strings on "Add New User" screen. 
Props ramiy.
Fixes #37784.
Built from https://develop.svn.wordpress.org/trunk@38329


git-svn-id: http://core.svn.wordpress.org/trunk@38270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 12:54:31 +00:00
Andrew Ozz
08d59c211c TinyMCE: make sure the temporary id is removed when using the default image dialog and inserting an external image. 
Props fomenkoandrey for reporting and testing.
Fixes #37467.
Built from https://develop.svn.wordpress.org/trunk@38328


git-svn-id: http://core.svn.wordpress.org/trunk@38269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 04:43:31 +00:00
Sergey Biryukov
35e3d7e37f I18N: Remove unnecessary context in wp_post_revision_title_expanded(). 
Props ramiy.
Fixes #37781.
Built from https://develop.svn.wordpress.org/trunk@38327


git-svn-id: http://core.svn.wordpress.org/trunk@38268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 01:46:31 +00:00
Sergey Biryukov
64dac53d70 I18N: Use a consistent context for "Add New" submenu strings in admin bar (Toolbar). 
Props ramiy.
Fixes #37780.
Built from https://develop.svn.wordpress.org/trunk@38326


git-svn-id: http://core.svn.wordpress.org/trunk@38267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 01:42:32 +00:00
Sergey Biryukov
92343be1f4 I18N: Allow for WordPress Plugin/Theme Directory URLs to be localized. 
Props ramiy.
Fixes #37501.
Built from https://develop.svn.wordpress.org/trunk@38325


git-svn-id: http://core.svn.wordpress.org/trunk@38266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 01:19:39 +00:00
Sergey Biryukov
372a19a435 I18N: Replace unnecessary context with translator comments in wp_post_revision_title() and wp_post_revision_title_expanded(). 
Props ramiy.
Fixes #37778.
Built from https://develop.svn.wordpress.org/trunk@38324


git-svn-id: http://core.svn.wordpress.org/trunk@38265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 00:35:28 +00:00
Sergey Biryukov
fee26cf741 I18N: Replace unnecessary context with a translator comment for %s Sites string in network_step1(). 
Props ramiy.
Fixes #37777.
Built from https://develop.svn.wordpress.org/trunk@38323


git-svn-id: http://core.svn.wordpress.org/trunk@38264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 00:17:27 +00:00
Sergey Biryukov
96bdd4737c I18N: Replace unnecessary context with a translator comment for %s KB string on Network Settings screen. 
Props ramiy.
Fixes #37496.
Built from https://develop.svn.wordpress.org/trunk@38322


git-svn-id: http://core.svn.wordpress.org/trunk@38263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 00:11:28 +00:00
Sergey Biryukov
c86199ddb2 Embeds: In get_oembed_endpoint_url(), avoid inadvertent stomping of the $format parameter passed to oembed_endpoint_url filter. 
Props danhgilmore.
Fixes #37751.
Built from https://develop.svn.wordpress.org/trunk@38321


git-svn-id: http://core.svn.wordpress.org/trunk@38262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-23 00:05:30 +00:00
Sergey Biryukov
44aac380f4 I18N: Add translator comments for Edit Site: %s string in network admin. 
Props ramiy.
Fixes #37776.
Built from https://develop.svn.wordpress.org/trunk@38320


git-svn-id: http://core.svn.wordpress.org/trunk@38261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 23:53:31 +00:00
Scott Taylor
b55b6a03f4 Users: after [38317], use a @property annotation, instead of a public field. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38319


git-svn-id: http://core.svn.wordpress.org/trunk@38260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 22:15:29 +00:00
Scott Taylor
1119536085 Widgets: $option_name and $alt_option_name have been used as members ever since WP_Widget became an object in 2.8, but never declared. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38318


git-svn-id: http://core.svn.wordpress.org/trunk@38259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:51:28 +00:00
Scott Taylor
7466118616 Users: $user_level has been publicly-accessed on instances of WP_User since version 2.0, but is has never been declared. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38317


git-svn-id: http://core.svn.wordpress.org/trunk@38258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:41:28 +00:00
Scott Taylor
d3312bc278 Locale: declare the $month_genitive field on WP_Locale. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38316


git-svn-id: http://core.svn.wordpress.org/trunk@38257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:33:28 +00:00
Scott Taylor
b0fa9aac6b HTTP: in WP_HTTP_Response, the @param declarations for $status and $headers were swapped. Let us correct this. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38315


git-svn-id: http://core.svn.wordpress.org/trunk@38256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:28:27 +00:00
Scott Taylor
ca70683001 Database: WP_Network, WP_Network_Query, and WP_Site_Query call wpdb::_escape(), thus requiring it to be public. It previously had no access modifier. _ at the beginning of a method, believe it or not, does not enforce visibility constraints. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38314


git-svn-id: http://core.svn.wordpress.org/trunk@38255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:10:28 +00:00
Scott Taylor
dcb0261664 Comments: in wp_handle_comment_submission(), $_wp_unfiltered_html_comment is passed as part of $comment_data, but is not used locally. 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38313


git-svn-id: http://core.svn.wordpress.org/trunk@38254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:04:28 +00:00
Scott Taylor
3755823702 Taxonomy: remove unnecessary break in WP_Term::__get(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38312


git-svn-id: http://core.svn.wordpress.org/trunk@38253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 21:00:30 +00:00
Scott Taylor
5025f72fd3 Nav Menus: remove unnecessary variable assignment in wp_nav_menu_item_post_type_meta_box(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38311


git-svn-id: http://core.svn.wordpress.org/trunk@38252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 20:58:28 +00:00
Scott Taylor
778d794e4f REST API: remove unnecessary variable assignments in rest_handle_options_request(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38310


git-svn-id: http://core.svn.wordpress.org/trunk@38251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 20:56:28 +00:00
Scott Taylor
a017516291 Media: remove unnecessary variable assignment in gallery_shortcode(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38309


git-svn-id: http://core.svn.wordpress.org/trunk@38250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 20:53:29 +00:00
Scott Taylor
7b30193bb7 General: remove variable set needlessly in wp_check_jsonp_callback(). 
See #37771.

Built from https://develop.svn.wordpress.org/trunk@38308


git-svn-id: http://core.svn.wordpress.org/trunk@38249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 20:51:30 +00:00
Drew Jaynes
22adda2aa0 Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation. 
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.

Props ramiy.
See #37748.

Built from https://develop.svn.wordpress.org/trunk@38307


git-svn-id: http://core.svn.wordpress.org/trunk@38248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 18:25:31 +00:00
Sergey Biryukov
02939c03e5 Common CSS: Allow for .nav-tab-wrapper class to be used on elements other than h3 to increase flexibility for custom settings pages. 
Props ramiy, afercia.
Fixes #37257.
Built from https://develop.svn.wordpress.org/trunk@38306


git-svn-id: http://core.svn.wordpress.org/trunk@38247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 16:33:30 +00:00
Sergey Biryukov
26d7a5607b Multisite: Fix copy/paste issue in id attribute for a dismissible message on Sites screen. 
Props imath.
Fixes #37764.
Built from https://develop.svn.wordpress.org/trunk@38305


git-svn-id: http://core.svn.wordpress.org/trunk@38246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 14:22:31 +00:00
Scott Taylor
cd6d2bae92 Login: retrieve_password() does not need to import 2 globals that it does not use. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38304


git-svn-id: http://core.svn.wordpress.org/trunk@38245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 04:48:28 +00:00
Scott Taylor
d31456b615 Media: add a function, wp_get_additional_image_sizes(), that wraps the retrieval of the global $_wp_additional_image_sizes. Removes 6 global imports. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38303


git-svn-id: http://core.svn.wordpress.org/trunk@38244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 04:37:28 +00:00
Scott Taylor
b34dea908f Media: fix unit test after [38296]. 
https://en.wikipedia.org/wiki/Coupling_(computer_programming)#Disadvantages

Fixes #36246.

Built from https://develop.svn.wordpress.org/trunk@38302


git-svn-id: http://core.svn.wordpress.org/trunk@38243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 04:17:34 +00:00
Weston Ruter
ee44093211 Customize: Ensure a newly-added custom link nav menu item has the appropriate CSS class names. 
For nav menu items of the `custom` type, their `object` should also be set to `custom`, so that the `menu-item-custom` class name will be added.

Props vishalkakadiya.
Fixes #37575.

Built from https://develop.svn.wordpress.org/trunk@38301


git-svn-id: http://core.svn.wordpress.org/trunk@38242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 03:12:32 +00:00
Weston Ruter
57740f3c91 Docs: Update jsdoc in customize-nav-menus.js to remove references to Menu Customizer plugin. 
Also fix `@param` for `updateAssignedLocationsInSectionTitle`.

Props gma992, westonruter.
Fixes #37520.

Built from https://develop.svn.wordpress.org/trunk@38300


git-svn-id: http://core.svn.wordpress.org/trunk@38241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 00:56:27 +00:00
Weston Ruter
44c499329a Docs: Update outdated phpdoc for WP_Customize_Manager::validate_setting_values() to reflect changes in [37942]. 
Props dlh.
See #37247.
Fixes #37759.

Built from https://develop.svn.wordpress.org/trunk@38299


git-svn-id: http://core.svn.wordpress.org/trunk@38240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-22 00:41:31 +00:00
Scott Taylor
4bdd4edb77 Comments: in WP_Comment_Query::fill_descendants(), continue if there is an empty array in the loop. 
See #37416, [38297].

Built from https://develop.svn.wordpress.org/trunk@38298


git-svn-id: http://core.svn.wordpress.org/trunk@38239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-21 06:43:29 +00:00
Scott Taylor
f02f4ac762 Comments: in WP_Comment_Query::fill_descendants(), compute count() in the first for expression so that it does not run on each iteration. 
Props vishalkakadiya, deremohan.
Fixes #37416.

Built from https://develop.svn.wordpress.org/trunk@38297


git-svn-id: http://core.svn.wordpress.org/trunk@38238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-21 06:25:29 +00:00
Scott Taylor
b8bfcb0d64 Media: use wp_get_attachment_metadata() instead of get_post_meta() where appropriate. 
Adds unit test.

Props JorritSchippers.
Fixes #36246.

Built from https://develop.svn.wordpress.org/trunk@38296


git-svn-id: http://core.svn.wordpress.org/trunk@38237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-21 06:15:30 +00:00
Scott Taylor
76540c6010 Media: wp_get_attachment_link() fails to output text for non-images if the attachment post doesn't have a title and $text (argument #5) was not passed to the func. In this case, use the filename. 
Props Jonnyauk, henry.wright.
Fixes #37343.

Built from https://develop.svn.wordpress.org/trunk@38295


git-svn-id: http://core.svn.wordpress.org/trunk@38236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 23:45:28 +00:00
Scott Taylor
7ac88c02fa Media: when calling pathinfo(), also pass a PATHINFO_* constant to avoid array notices for unset keys. 
Props JaworskiMatt.
Fixes #37608.

Built from https://develop.svn.wordpress.org/trunk@38294


git-svn-id: http://core.svn.wordpress.org/trunk@38235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 23:36:28 +00:00
Scott Taylor
d73964aab6 Media: Add some docs to media-gallery.js RIP. 
Props jipmoors.
Fixes #37717.

Built from https://develop.svn.wordpress.org/trunk@38293


git-svn-id: http://core.svn.wordpress.org/trunk@38234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 22:59:29 +00:00
Boone Gorges
344c88d39f Allow attachment taxonomies to be fetched as objects. 
By adding the `$output` parameter to `get_attachment_taxonomies()`, the
function signature matches that of `get_object_taxonomies()`. The change
also allows for more consistent behavior when passing `output=objects`
to `get_object_taxonomies()` for the 'attachment' object type, since
the `$output` parameter is now passed through the function stack.

Props codemovement.pk.
See #37368.
Built from https://develop.svn.wordpress.org/trunk@38292


git-svn-id: http://core.svn.wordpress.org/trunk@38233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 17:35:31 +00:00
Boone Gorges
188c568204 Introduce tests for get_attachment_taxonomies(). 
See #37368.
Built from https://develop.svn.wordpress.org/trunk@38291


git-svn-id: http://core.svn.wordpress.org/trunk@38232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 17:25:30 +00:00
Boone Gorges
ece461fbc3 Introduce tests for get_object_taxonomies(). 
See #37368.
Built from https://develop.svn.wordpress.org/trunk@38290


git-svn-id: http://core.svn.wordpress.org/trunk@38231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 17:01:31 +00:00
Sergey Biryukov
597c067b67 Docs: Correct usage examples for wpdb::prepare(), which should not be called statically. 
Props TJNowell.
Fixes #37744.
Built from https://develop.svn.wordpress.org/trunk@38289


git-svn-id: http://core.svn.wordpress.org/trunk@38230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 13:17:30 +00:00
Boone Gorges
d30a6a988a Query: Non-scalar and negative values for 'p' should always result in a 404. 
Previously, the 'p' query var was being run through `absint()`, which
caused unexpected results.

Props Akeif, kouratoras.
Fixes #33372.
Built from https://develop.svn.wordpress.org/trunk@38288


git-svn-id: http://core.svn.wordpress.org/trunk@38229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 02:32:30 +00:00
Boone Gorges
54fe38c7cc Mail: Don't set Sender field when setting From. 
[38058] changed `wp_mail()` so that it used PHPMailer's `setFrom()`
method rather than setting the From and FromName headers directly. See
behavior of setting the `Sender` field. This causes `mail` to be
called with the `-f` flag, which causes outgoing email to fail on some
server environments.

Props Clorith, iandunn, DrewAPicture.
Fixes #37736.
Built from https://develop.svn.wordpress.org/trunk@38286


git-svn-id: http://core.svn.wordpress.org/trunk@38227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-20 02:17:38 +00:00
Boone Gorges
53ef9de125 Tests: Move some utility classes to their own files. 
Props Frank Klein.
Fixes #37523.

Built from https://develop.svn.wordpress.org/trunk@38285


git-svn-id: http://core.svn.wordpress.org/trunk@38226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-19 15:45:29 +00:00
Sergey Biryukov
83bed74a2f Docs: Fix typo in load_plugin_textdomain() parameter description. 
Props tivnet.
See #37318.
Built from https://develop.svn.wordpress.org/trunk@38284


git-svn-id: http://core.svn.wordpress.org/trunk@38225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-19 14:29:30 +00:00
Boone Gorges
0da0aae4b0 Add wordpress-importer tests demonstrating slashed data behavior. 
See #21007.
Built from https://develop.svn.wordpress.org/trunk@38283


git-svn-id: http://core.svn.wordpress.org/trunk@38224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-19 13:27:30 +00:00
Aaron Jorbin
a138374ec8 Bootstrap/Load: Include Plugin API via require_once 
Currently, auto-prepended files need to directly modify the globals in order to add filters and actions. This is a bad idea. Globals are bad. You should never directly interact with the Plugin globals.

Fixes #37707.


Built from https://develop.svn.wordpress.org/trunk@38282


git-svn-id: http://core.svn.wordpress.org/trunk@38223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-19 04:10:30 +00:00
Aaron Jorbin
18f14ad752 Fix jshint of Gruntfile.js 
Introduced in [38276]

See #37720.

Built from https://develop.svn.wordpress.org/trunk@38281


git-svn-id: http://core.svn.wordpress.org/trunk@38222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 20:05:30 +00:00
Scott Taylor
3357ca23e6 Query: use composition for $db in WP_Date_Query, removes need to import global $wpdb in multiple methods. 
See #37699.

Built from https://develop.svn.wordpress.org/trunk@38280


git-svn-id: http://core.svn.wordpress.org/trunk@38221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-08-18 19:48:34 +00:00